Re: r337005 - [NFC] Rename clang::AttributeList to clang::ParsedAttr

2018-08-06 Thread Michael Kruse via cfe-commits
2018-07-13 10:07 GMT-05:00 Erich Keane via cfe-commits : > -class AttributeList { // TODO: This should really be called ParsedAttribute > +class ParsedAttr { // TODO: This should really be called ParsedAttribute Should this TODO be removed/ParsedAttr really be called ParsedAttribute? Michael

Re: r337005 - [NFC] Rename clang::AttributeList to clang::ParsedAttr

2018-08-06 Thread Michael Kruse via cfe-commits
Thank you. Michael 2018-08-06 13:13 GMT-05:00 Keane, Erich : > Good grief... I even made a note to remove this 'TODO' on my whiteboard! > > I discussed the name with AaronBallman who preferred ParsedAttr over > ParsedAttribute (since ParsedAttributes is also a type). > > Fixed in r339039. > > -

Re: r338291 - Remove trailing space

2018-07-30 Thread Michael Kruse via cfe-commits
Can you point me to such a discussion about trailing whitespace? It seems to contradict the conclusion in another current thread to not consider churn for out-of-tree users (for C++ API in this case) https://lists.llvm.org/pipermail/cfe-dev/2018-July/058579.html > We have historically taken the

r338800 - Append new attributes to the end of an AttributeList.

2018-08-02 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Thu Aug 2 18:21:16 2018 New Revision: 338800 URL: http://llvm.org/viewvc/llvm-project?rev=338800&view=rev Log: Append new attributes to the end of an AttributeList. Recommit of r335084 after revert in r335516. ... instead of prepending it at the beginning (the original

r338810 - [CodeGen] Emit parallel_loop_access for each loop in the loop stack.

2018-08-02 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Thu Aug 2 21:42:52 2018 New Revision: 338810 URL: http://llvm.org/viewvc/llvm-project?rev=338810&view=rev Log: [CodeGen] Emit parallel_loop_access for each loop in the loop stack. Summary: Emit !llvm.mem.parallel_loop_access metadata for memory accesses even if the para

r335084 - Append new attributes to the end of an AttributeList.

2018-06-20 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Tue Jun 19 16:46:52 2018 New Revision: 335084 URL: http://llvm.org/viewvc/llvm-project?rev=335084&view=rev Log: Append new attributes to the end of an AttributeList. ... instead of prepending it at the beginning (the original behavior since implemented in r122535 2010-12-

Re: r335084 - Append new attributes to the end of an AttributeList.

2018-06-24 Thread Michael Kruse via cfe-commits
Hi, multiple comments in the code indicate that the attribute order was surprising and probably has lead to bugs, and will lead to bugs in the future. The order had to be explicitly reversed to avoid those. This alone for me this seems a good reason to have the attributes in the order in which the

r348762 - Use zip_longest for iterator range comparisons. NFC.

2018-12-10 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Mon Dec 10 07:16:37 2018 New Revision: 348762 URL: http://llvm.org/viewvc/llvm-project?rev=348762&view=rev Log: Use zip_longest for iterator range comparisons. NFC. Use zip_longest in two locations that compare iterator ranges. zip_longest allows the iteration using a ran

r354817 - [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier.

2019-02-25 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Mon Feb 25 12:34:15 2019 New Revision: 354817 URL: http://llvm.org/viewvc/llvm-project?rev=354817&view=rev Log: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier. This patch implements the parsing and sema support for the OpenMP 'from'-clause with pot

Re: r355182 - [clang-format] [NFC] clang-format the Format library

2019-03-08 Thread Michael Kruse via cfe-commits
Isn't this kind of commit discouraged?, as by https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access > Avoid committing formatting- or whitespace-only changes outside of code you > plan to make subsequent changes to. and the discussion after which this has been added: https://lists.l

Re: r355182 - [clang-format] [NFC] clang-format the Format library

2019-03-11 Thread Michael Kruse via cfe-commits
Am Sa., 9. März 2019 um 13:54 Uhr schrieb MyDeveloper Day : > > Yes ideally I'd agree, It also says: > > > Avoid committing formatting- or whitespace-only changes outside of code you > > plan to make subsequent changes to. > > This was getting to be a problem, every time we edited the file (with

r357415 - [CodeGen] Generate follow-up metadata for loops with more than one transformation.

2019-04-01 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Mon Apr 1 10:47:41 2019 New Revision: 357415 URL: http://llvm.org/viewvc/llvm-project?rev=357415&view=rev Log: [CodeGen] Generate follow-up metadata for loops with more than one transformation. Before this patch, CGLoop would dump all transformations for a loop into a s

r358507 - [Test] Remove obsolete test.

2019-04-16 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Tue Apr 16 09:44:45 2019 New Revision: 358507 URL: http://llvm.org/viewvc/llvm-project?rev=358507&view=rev Log: [Test] Remove obsolete test. The FIXME of this test case has been addressed in r335084/r338800. Its execution still does not succeed because of multiple syntax

Re: [PATCH] D42642: [CUDA] Detect installation in PATH

2019-05-01 Thread Michael Kruse via cfe-commits
Hi, I had my own difficulties with this. It depends on how the repository containing the symlink has been checked-out. For instance: 1. Using a windows git (such as git extensions, mingw-git, git for windows) 2. Using git inside wsl on a drvfs mount (i.e. a windows folder mounted into the Unix fi

Re: [PATCH] D42642: [CUDA] Detect installation in PATH

2019-05-02 Thread Michael Kruse via cfe-commits
An update: I just re-tried creating a symbolic link from inside wsl on drvfs (case 2). It now created a symlink just as "mklink" does. What might have changed is that I updated to a newer insider preview or that I enabled developer mode when I tried the first time. [1] seems to apply for case 1.

r342861 - Add inherited attributes before parsed attributes.

2018-09-23 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Sun Sep 23 23:31:37 2018 New Revision: 342861 URL: http://llvm.org/viewvc/llvm-project?rev=342861&view=rev Log: Add inherited attributes before parsed attributes. Currently, attributes from previous declarations ('inherited attributes') are added to the end of a declarati

r352906 - [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.

2019-02-01 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Fri Feb 1 12:25:04 2019 New Revision: 352906 URL: http://llvm.org/viewvc/llvm-project?rev=352906&view=rev Log: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive. This patch implements parsing and sema for "omp declare mapper" directive. User defined ma

Re: r352906 - [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.

2019-02-01 Thread Michael Kruse via cfe-commits
s ASTContext while it's still incomplete. > Could you please fix this? > > /Eric > > On Fri, Feb 1, 2019 at 3:24 PM Michael Kruse via cfe-commits > wrote: >> >> Author: meinersbur >> Date: Fri Feb 1 12:25:04 2019 >> New Revision: 352906 >> >&

r354698 - [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.

2019-02-22 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Fri Feb 22 14:29:42 2019 New Revision: 354698 URL: http://llvm.org/viewvc/llvm-project?rev=354698&view=rev Log: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier. This patch implements the parsing and sema support for OpenMP to clause with potential use

r367773 - [OpenMP 5.0] Codegen support for user-defined mappers.

2019-08-03 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Sat Aug 3 21:18:42 2019 New Revision: 367773 URL: http://llvm.org/viewvc/llvm-project?rev=367773&view=rev Log: [OpenMP 5.0] Codegen support for user-defined mappers. This patch implements the code generation for OpenMP 5.0 declare mapper (user-defined mapper) constructs.

r367774 - Revert "[OpenMP 5.0] Codegen support for user-defined mappers."

2019-08-03 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Sat Aug 3 22:16:52 2019 New Revision: 367774 URL: http://llvm.org/viewvc/llvm-project?rev=367774&view=rev Log: Revert "[OpenMP 5.0] Codegen support for user-defined mappers." This reverts commit r367773. The test case OpenMP/declare_mapper_codegen.cpp is failing. Modifi

r367905 - [OpenMP 5.0] Codegen support for user-defined mappers.

2019-08-05 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Mon Aug 5 11:43:21 2019 New Revision: 367905 URL: http://llvm.org/viewvc/llvm-project?rev=367905&view=rev Log: [OpenMP 5.0] Codegen support for user-defined mappers. This patch implements the code generation for OpenMP 5.0 declare mapper (user-defined mapper) constructs.

r348944 - [Unroll/UnrollAndJam/Vectorizer/Distribute] Add followup loop attributes.

2018-12-12 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Wed Dec 12 09:32:52 2018 New Revision: 348944 URL: http://llvm.org/viewvc/llvm-project?rev=348944&view=rev Log: [Unroll/UnrollAndJam/Vectorizer/Distribute] Add followup loop attributes. When multiple loop transformation are defined in a loop's metadata, their order of ex

r349823 - [CodeGen] Generate llvm.loop.parallel_accesses instead of llvm.mem.parallel_loop_access metadata.

2018-12-20 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Thu Dec 20 13:24:54 2018 New Revision: 349823 URL: http://llvm.org/viewvc/llvm-project?rev=349823&view=rev Log: [CodeGen] Generate llvm.loop.parallel_accesses instead of llvm.mem.parallel_loop_access metadata. Instead of generating llvm.mem.parallel_loop_access metadata,

r373023 - [OpenMP 5.0] Fix user-defined mapper lookup in sema

2019-09-26 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Thu Sep 26 15:53:01 2019 New Revision: 373023 URL: http://llvm.org/viewvc/llvm-project?rev=373023&view=rev Log: [OpenMP 5.0] Fix user-defined mapper lookup in sema This patches fixes the case when a user-defined mapper is attached to the elements of an array, and to repor

Re: r335084 - Append new attributes to the end of an AttributeList.

2018-06-25 Thread Michael Kruse via cfe-commits
2018-06-25 14:20 GMT-05:00 Richard Smith : > (I'm not sure what the problem is, but as a data point, Sema::checkCall > iterates over the FormatAttrs in order, so it's possible that changing the > order may have triggered a new warning. That may be due to a pre-existing > order-dependence bug, or it

Re: r335084 - Append new attributes to the end of an AttributeList.

2018-06-25 Thread Michael Kruse via cfe-commits
I just revert if to have further discussions (r335516) Michael 2018-06-25 14:58 GMT-05:00 Eric Christopher : > > > On Mon, Jun 25, 2018 at 12:21 PM Richard Smith via cfe-commits > wrote: >> >> On 23 June 2018 at 22:34, Michael Kruse via cfe-commits >> wrote

r335516 - Revert "Append new attributes to the end of an AttributeList."

2018-06-25 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Mon Jun 25 13:06:13 2018 New Revision: 335516 URL: http://llvm.org/viewvc/llvm-project?rev=335516&view=rev Log: Revert "Append new attributes to the end of an AttributeList." This reverts commit r335084 as requested by David Jones and Eric Christopher because of differenc

Re: r335084 - Append new attributes to the end of an AttributeList.

2018-06-26 Thread Michael Kruse via cfe-commits
19:29 GMT-05:00 David Jones : > (Sorry for the late reply...) > > On Mon, Jun 25, 2018 at 2:45 PM Michael Kruse via cfe-commits > wrote: >> >> I just revert if to have further discussions (r335516) >> >> Michael >> >> 2018-06-25 14:58 GMT-05:00 Eric Chris

Re: r335084 - Append new attributes to the end of an AttributeList.

2018-06-27 Thread Michael Kruse via cfe-commits
_bug.cgi?id=37935 I landed a test for that in > r335725 (in case you're wondering why there's a new test failure when you > reland). > > Thanks for working on this! > > On Tue, Jun 26, 2018 at 9:03 AM Michael Kruse via cfe-commits > wrote: >> >> Thank yo

r336239 - [Sema] Consider all format_arg attributes.

2018-07-04 Thread Michael Kruse via cfe-commits
Author: meinersbur Date: Tue Jul 3 18:37:11 2018 New Revision: 336239 URL: http://llvm.org/viewvc/llvm-project?rev=336239&view=rev Log: [Sema] Consider all format_arg attributes. If a function has multiple format_arg attributes, clang only considers the first it finds (because AttributeLists are

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

2019-10-21 Thread Michael Kruse via cfe-commits
Am Mo., 21. Okt. 2019 um 16:01 Uhr schrieb Jordan Rupprecht via cfe-commits : > There's also a curious failure caused by this patch (confirmed passing > @r374287, failing @r374288): It's a warning, not a failure. > $ cat /tmp/vectorize.cc > void a() { > #pragma clang loop vectorize(disable) >

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

2019-10-22 Thread Michael Kruse via cfe-commits
Am Mo., 21. Okt. 2019 um 23:44 Uhr schrieb Jordan Rupprecht : > At any rate, it sounds like this is not a codegen bug at all, but just an > over-eager warning? That interpretation is different from mine. Codgen emits the following from vectorize(disable) !4 = !{!"llvm.loop.vectorize.enable", i1

Re: [PATCH] D69391: Add #pragma clang loop ivdep

2019-10-25 Thread Michael Kruse via cfe-commits
What's the motivation of even allowing `#pragma clang loop ivdep(disable)`? It either has no effect or conflicts with other loop hints. Sorry, for not using Phabricator. When I try to submit a comment, I get the following error: You Shall Not Pass: D69391 You do not have permission to edit thi

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

2019-10-25 Thread Michael Kruse via cfe-commits
@sjoerdmeijer Before recommitting, please re-open the patch review. Michael Am Do., 24. Okt. 2019 um 18:45 Uhr schrieb Jordan Rupprecht : > > Reverted in 6d424a161bf3e52730371da0b9439ed93a8ce406 due to the issue > described here. Should hopefully be a trivial fix forward. > > On Tue, Oct 22, 20

[clang] 80bd6ae - On Windows build, making the /bigobj flag global , instead of passing it per file.

2020-07-28 Thread Michael Kruse via cfe-commits
Author: Zahira Ammarguellat Date: 2020-07-28T18:04:36-05:00 New Revision: 80bd6ae13ea23d453a1f45d6ccdbfc7d0c877bb0 URL: https://github.com/llvm/llvm-project/commit/80bd6ae13ea23d453a1f45d6ccdbfc7d0c877bb0 DIFF: https://github.com/llvm/llvm-project/commit/80bd6ae13ea23d453a1f45d6ccdbfc7d0c877bb0

Re: [PATCH] D78192: Support compiler extensions as a normal component

2020-04-24 Thread Michael Kruse via cfe-commits
Weird. I already tried the patch under Windows/msvc and had no such problem. Michael Am Fr., 24. Apr. 2020 um 04:15 Uhr schrieb Russell Gallop : > > Hi Serge, > > It looks like this is failing to build on Windows bots (e.g. > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windo

[clang] 18eba16 - [OpenMP][docs] Update loop tiling status.

2020-07-31 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2020-07-31T13:01:55-05:00 New Revision: 18eba165e7ba80328a910cad3407599d8ff60f4f URL: https://github.com/llvm/llvm-project/commit/18eba165e7ba80328a910cad3407599d8ff60f4f DIFF: https://github.com/llvm/llvm-project/commit/18eba165e7ba80328a910cad3407599d8ff60f4f.diff

[clang] [clang-format] Handle variable declarations in BreakAfterAttributes (PR #71755)

2023-11-10 Thread Michael Kruse via cfe-commits
Meinersbur wrote: @owenca You can run `ninja polly-update-format` which will use the in-tree `clang-format` to reformat all files. `git add` its changes, `git add --amend`, then push. https://github.com/llvm/llvm-project/pull/71755 ___ cfe-commits m

[clang] [LinkerWrapper] Accept some needed COFF linker arguments (PR #72889)

2023-11-20 Thread Michael Kruse via cfe-commits
Meinersbur wrote: The command-line argument handling is not related to [PE](https://en.wikipedia.org/wiki/Portable_Executable)/COFF, but to Microsoft's `link.exe` command line interface, for instance [`/libpath:`](https://learn.microsoft.com/en-us/cpp/build/reference/libpath-additional-libpath

[clang] [LinkerWrapper] Accept some needed COFF linker arguments (PR #72889)

2023-11-20 Thread Michael Kruse via cfe-commits
@@ -126,3 +126,8 @@ def version : Flag<["--", "-"], "version">, Flags<[HelpHidden]>, Alias; def whole_archive : Flag<["--", "-"], "whole-archive">, Flags<[HelpHidden]>; def no_whole_archive : Flag<["--", "-"], "no-whole-archive">, Flags<[HelpHidden]>; + +// COFF-style linker

[clang] [LinkerWrapper] Accept some needed lld-link linker arguments for COFF targets (PR #72889)

2023-11-22 Thread Michael Kruse via cfe-commits
@@ -126,3 +126,8 @@ def version : Flag<["--", "-"], "version">, Flags<[HelpHidden]>, Alias; def whole_archive : Flag<["--", "-"], "whole-archive">, Flags<[HelpHidden]>; def no_whole_archive : Flag<["--", "-"], "no-whole-archive">, Flags<[HelpHidden]>; + +// COFF-style linker

[clang] [LinkerWrapper] Accept some needed lld-link linker arguments for COFF targets (PR #72889)

2023-11-22 Thread Michael Kruse via cfe-commits
@@ -126,3 +126,8 @@ def version : Flag<["--", "-"], "version">, Flags<[HelpHidden]>, Alias; def whole_archive : Flag<["--", "-"], "whole-archive">, Flags<[HelpHidden]>; def no_whole_archive : Flag<["--", "-"], "no-whole-archive">, Flags<[HelpHidden]>; + +// COFF-style linker

[clang] [LinkerWrapper] Accept some needed lld-link linker arguments for COFF targets (PR #72889)

2023-11-22 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur approved this pull request. PE file start with the magic bytes `MZ` (0x4D5A). Extracting sections can usually done with the [dumpbin.exe](https://learn.microsoft.com/en-us/cpp/build/reference/dumpbin-reference?view=msvc-170) tool. I don't know whether LLVM has mea

[clang] [LinkerWrapper] Accept some needed lld-link linker arguments for COFF targets (PR #72889)

2023-11-22 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/72889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Accept some needed lld-link linker arguments for COFF targets (PR #72889)

2023-11-22 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/72889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ae6b400 - [Preprocessor] Implement -fminimize-whitespace.

2021-07-25 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-07-25T23:30:57-05:00 New Revision: ae6b4238e5f319ffcfc713a15e459be8 URL: https://github.com/llvm/llvm-project/commit/ae6b4238e5f319ffcfc713a15e459be8 DIFF: https://github.com/llvm/llvm-project/commit/ae6b4238e5f319ffcfc713a15e459be8.diff

[clang] c6b0b16 - [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

2021-07-28 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-07-28T22:50:54-05:00 New Revision: c6b0b16c0f55c34f4eaa05184815bbbe97f4b750 URL: https://github.com/llvm/llvm-project/commit/c6b0b16c0f55c34f4eaa05184815bbbe97f4b750 DIFF: https://github.com/llvm/llvm-project/commit/c6b0b16c0f55c34f4eaa05184815bbbe97f4b750.diff

[clang] 9ec501d - [OpenMP] Refactor OMPScheduleType enum.

2022-04-18 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2022-04-18T14:03:17-05:00 New Revision: 9ec501da76fc1559cadd6d6dac32766bf4376a3d URL: https://github.com/llvm/llvm-project/commit/9ec501da76fc1559cadd6d6dac32766bf4376a3d DIFF: https://github.com/llvm/llvm-project/commit/9ec501da76fc1559cadd6d6dac32766bf4376a3d.diff

[clang] af02851 - Revert "[OpenMP] Refactor OMPScheduleType enum."

2022-04-18 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2022-04-18T14:38:31-05:00 New Revision: af0285122f306573d9bcc4c4ad7f904cfdd4d869 URL: https://github.com/llvm/llvm-project/commit/af0285122f306573d9bcc4c4ad7f904cfdd4d869 DIFF: https://github.com/llvm/llvm-project/commit/af0285122f306573d9bcc4c4ad7f904cfdd4d869.diff

[clang] 2d92ee9 - Reapply "[OpenMP] Refactor OMPScheduleType enum."

2022-04-18 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2022-04-18T21:56:47-05:00 New Revision: 2d92ee97f1afb3657579a46a7dd4611b61e9cc16 URL: https://github.com/llvm/llvm-project/commit/2d92ee97f1afb3657579a46a7dd4611b61e9cc16 DIFF: https://github.com/llvm/llvm-project/commit/2d92ee97f1afb3657579a46a7dd4611b61e9cc16.diff

[clang] acec070 - [OpenMP] Fix partial unrolling off-by-one.

2022-05-20 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2022-05-20T15:19:52-05:00 New Revision: acec07005e038ab2891f235ae60ba2f0236bb952 URL: https://github.com/llvm/llvm-project/commit/acec07005e038ab2891f235ae60ba2f0236bb952 DIFF: https://github.com/llvm/llvm-project/commit/acec07005e038ab2891f235ae60ba2f0236bb952.diff

[clang] [flang] [flang] Add --gcc-toolchain and --gcc-install-dir options to flang. (PR #87360)

2024-04-02 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur created https://github.com/llvm/llvm-project/pull/87360 The `--gcc-toolchain` and `--gcc-install-dir` option were previously only visible to the Clang driver, but not Flang. These determine which assembler, linker, and libraries to use, e.g. for cross-compiling, a

[clang] [LinkerWrapper] Use the correct empty file on Windows (PR #84322)

2024-03-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur requested changes to this pull request. https://github.com/llvm/llvm-project/pull/84322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Use the correct empty file on Windows (PR #84322)

2024-03-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/84322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Use the correct empty file on Windows (PR #84322)

2024-03-07 Thread Michael Kruse via cfe-commits
@@ -410,7 +410,10 @@ fatbinary(ArrayRef> InputFiles, Targets.push_back(Saver.save("hipv4-amdgcn-amd-amdhsa--" + Arch)); CmdArgs.push_back(Saver.save(llvm::join(Targets, ","))); - CmdArgs.push_back("-input=/dev/null"); + if (Triple.isOSWindows()) Meine

[clang] [LinkerWrapper] Use the correct empty file on Windows (PR #84322)

2024-03-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur approved this pull request. The change works, as I managed to compile a single file. However, the resulting executable segfaults for me on Windows and I get a link error when compiling multiple HIP files. Those are unrelated. https://github.com/llvm/llvm-project/p

[clang] [polly] [clang-tools-extra] [llvm] [polly] Add polly-debug flag to print debug info from all parts of polly (PR #78549)

2024-02-01 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur requested changes to this pull request. https://github.com/llvm/llvm-project/pull/78549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [polly] [llvm] [polly] Add polly-debug flag to print debug info from all parts of polly (PR #78549)

2024-02-01 Thread Michael Kruse via cfe-commits
@@ -0,0 +1,32 @@ +//===-PollyDebug.inc -Provide support for debugging Polly passes-*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang] [polly] [llvm] [polly] Add polly-debug flag to print debug info from all parts of polly (PR #78549)

2024-02-01 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/78549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [polly] [clang] [polly] Add polly-debug flag to print debug info from all parts of polly (PR #78549)

2024-02-01 Thread Michael Kruse via cfe-commits
@@ -0,0 +1,32 @@ +//===-PollyDebug.inc -Provide support for debugging Polly passes-*- C++ -*-===// Meinersbur wrote: Please use a `.h` extension for this file, it's a normal header file https://github.com/llvm/llvm-project/pull/78549 ___

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

2020-01-08 Thread Michael Kruse via cfe-commits
Am Di., 7. Jan. 2020 um 18:57 Uhr schrieb Eric Christopher via cfe-commits : >> Is there anything I should have done? Probably reaching llvm-dev before >> commiting. Reaching the right reviewers has always been a challenge to me, I >> had >> hoped that the mail to llvm-dev would trigger some subsc

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

2020-01-09 Thread Michael Kruse via cfe-commits
Am Mi., 8. Jan. 2020 um 17:20 Uhr schrieb Eric Christopher : > > > > On Wed, Jan 8, 2020 at 3:07 PM Michael Kruse > wrote: >> >> Am Di., 7. Jan. 2020 um 18:57 Uhr schrieb Eric Christopher via >> cfe-commits : >> >> Is there anything I should have done? Probably reaching llvm-dev before >> >> comm

[clang] e5dba2d - [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

2020-11-09 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2020-11-09T19:35:11-06:00 New Revision: e5dba2d7e5a6ab8266954e13844355d795c8c88b URL: https://github.com/llvm/llvm-project/commit/e5dba2d7e5a6ab8266954e13844355d795c8c88b DIFF: https://github.com/llvm/llvm-project/commit/e5dba2d7e5a6ab8266954e13844355d795c8c88b.diff

[clang] 83ff0ff - [Clang][OpenMP] Allow unified_shared_memory for Pascal-generation GPUs.

2021-05-13 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-05-13T17:15:34-05:00 New Revision: 83ff0ff46337422171fb36f934bd56c2bc1be15c URL: https://github.com/llvm/llvm-project/commit/83ff0ff46337422171fb36f934bd56c2bc1be15c DIFF: https://github.com/llvm/llvm-project/commit/83ff0ff46337422171fb36f934bd56c2bc1be15c.diff

[clang] 07a6beb - [Clang][OpenMP] Emit dependent PreInits before directive.

2021-06-02 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-06-02T16:59:35-05:00 New Revision: 07a6beb402150d25ec7c93a5747520ac2804731d URL: https://github.com/llvm/llvm-project/commit/07a6beb402150d25ec7c93a5747520ac2804731d DIFF: https://github.com/llvm/llvm-project/commit/07a6beb402150d25ec7c93a5747520ac2804731d.diff

[clang] 64e5a3b - [clang] Fix fail of OpenMP/tile_codegen_tile_for.cpp.

2021-06-02 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-06-02T21:02:05-05:00 New Revision: 64e5a3bbdde25af0fd9f2b9b8539e23f36c80601 URL: https://github.com/llvm/llvm-project/commit/64e5a3bbdde25af0fd9f2b9b8539e23f36c80601 DIFF: https://github.com/llvm/llvm-project/commit/64e5a3bbdde25af0fd9f2b9b8539e23f36c80601.diff

[clang] 74ddacd - [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

2021-02-13 Thread Michael Kruse via cfe-commits
Author: Malhar Date: 2021-02-13T17:35:54-06:00 New Revision: 74ddacd30de54e19b28218bc8563bd0f34f32cad URL: https://github.com/llvm/llvm-project/commit/74ddacd30de54e19b28218bc8563bd0f34f32cad DIFF: https://github.com/llvm/llvm-project/commit/74ddacd30de54e19b28218bc8563bd0f34f32cad.diff LOG: [

[clang] d466ca0 - [Clang][OpenMP] Add static version of getSingleClause. NFC.

2021-06-06 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-06-06T09:17:42-05:00 New Revision: d466ca087aae958d1c0a965c561be07d2cb3e7e2 URL: https://github.com/llvm/llvm-project/commit/d466ca087aae958d1c0a965c561be07d2cb3e7e2 DIFF: https://github.com/llvm/llvm-project/commit/d466ca087aae958d1c0a965c561be07d2cb3e7e2.diff

[clang] c41a8fb - [Clang][OpenMP] Refactor checking for mutually exclusive clauses. NFC.

2021-06-06 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-06-06T09:49:46-05:00 New Revision: c41a8fbfbb096995367947e5ef7d36501b04d493 URL: https://github.com/llvm/llvm-project/commit/c41a8fbfbb096995367947e5ef7d36501b04d493 DIFF: https://github.com/llvm/llvm-project/commit/c41a8fbfbb096995367947e5ef7d36501b04d493.diff

[clang] 0e25867 - [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions.

2021-08-01 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-08-01T19:08:13-05:00 New Revision: 0e2586779ca6606a3df085f253a31b89b8ad8508 URL: https://github.com/llvm/llvm-project/commit/0e2586779ca6606a3df085f253a31b89b8ad8508 DIFF: https://github.com/llvm/llvm-project/commit/0e2586779ca6606a3df085f253a31b89b8ad8508.diff

[clang] ba2be8d - [clang/OpenMP][docs] Update OpenMP support list for unroll.

2021-08-03 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-08-03T18:11:17-05:00 New Revision: ba2be8deba79f1aa64a86019e78bcd2536b14eb5 URL: https://github.com/llvm/llvm-project/commit/ba2be8deba79f1aa64a86019e78bcd2536b14eb5 DIFF: https://github.com/llvm/llvm-project/commit/ba2be8deba79f1aa64a86019e78bcd2536b14eb5.diff

[clang] b1de32d - [OMPIRBuilder] Clarify CanonicalLoopInfo. NFC.

2021-08-12 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-08-12T21:02:19-05:00 New Revision: b1de32d6ddd90046171ecee0047fbf448a97e16f URL: https://github.com/llvm/llvm-project/commit/b1de32d6ddd90046171ecee0047fbf448a97e16f DIFF: https://github.com/llvm/llvm-project/commit/b1de32d6ddd90046171ecee0047fbf448a97e16f.diff

[clang] 8f099d1 - [Preprocessor] Fix warning: left and right subexpressions are identical. NFCI.

2021-11-04 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-11-05T00:43:40-05:00 New Revision: 8f099d17a1bee857ada3c5af032cfcb559252024 URL: https://github.com/llvm/llvm-project/commit/8f099d17a1bee857ada3c5af032cfcb559252024 DIFF: https://github.com/llvm/llvm-project/commit/8f099d17a1bee857ada3c5af032cfcb559252024.diff

[clang] 1606022 - [Preprocessor] Fix newline before/after _Pragma.

2021-11-04 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-11-05T00:43:40-05:00 New Revision: 1606022fab2d90ed8ee6d15800ec1c2c293db20e URL: https://github.com/llvm/llvm-project/commit/1606022fab2d90ed8ee6d15800ec1c2c293db20e DIFF: https://github.com/llvm/llvm-project/commit/1606022fab2d90ed8ee6d15800ec1c2c293db20e.diff

[clang] bc172e5 - [clang][StaticAnalyzer] Compilation fix.

2021-03-04 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-03-04T23:23:58-06:00 New Revision: bc172e532a89754d47fef1306064a26a4dc0a76b URL: https://github.com/llvm/llvm-project/commit/bc172e532a89754d47fef1306064a26a4dc0a76b DIFF: https://github.com/llvm/llvm-project/commit/bc172e532a89754d47fef1306064a26a4dc0a76b.diff

[clang] 4b15b2d - [clang][OpenMP][docs] Update loop transformation status.

2021-03-05 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-03-05T17:26:55-06:00 New Revision: 4b15b2df23389be567814cedcfddc8008c354b3d URL: https://github.com/llvm/llvm-project/commit/4b15b2df23389be567814cedcfddc8008c354b3d DIFF: https://github.com/llvm/llvm-project/commit/4b15b2df23389be567814cedcfddc8008c354b3d.diff

Re: Buildbot cleaning for zorg upgrade

2020-02-25 Thread Michael Kruse via cfe-commits
Looking forward to the upgrade. Thanks for investing the time. I am trying to re-add buildbots for polly-x86_64 (https://reviews.llvm.org/D75127) and I am not use whether you received my messages about it. In any case, would you prefer to wait until the new instance of buildbot-master is available

Re: [PATCH] D69897: Add #pragma clang loop vectorize_assume_alignment(n)

2019-11-20 Thread Michael Kruse via cfe-commits
Am Mi., 20. Nov. 2019 um 10:21 Uhr schrieb HAPPY Mahto : >> #pragma clang loop vectorize_assume_alignment(32) >> for(int i = 0;i < n; i++){ >> a[i] = b[i] + i*i; >> } > > for this all-access inside the loop will be aligned to 32bit, > ex IR >> >> for.cond:

[clang] 2a789dd - [OpenMP][Docs] Claim loop tiling.

2019-12-13 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2019-12-13T18:42:52-06:00 New Revision: 2a789dd0ad884cbd73b962b6b07cf48e2178d2c9 URL: https://github.com/llvm/llvm-project/commit/2a789dd0ad884cbd73b962b6b07cf48e2178d2c9 DIFF: https://github.com/llvm/llvm-project/commit/2a789dd0ad884cbd73b962b6b07cf48e2178d2c9.diff

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-07-08 Thread Michael Kruse via cfe-commits
Meinersbur wrote: Using git bisect, I tracked down Flang not working anymore on Windows to this PR: ``` > flang-new hello.f90 -o hello flang-new version 19.0.0git Target: x86_64-pc-windows-msvc Thread model: posix InstalledDir: C:\Users\meinersbur\build\llvm-project\release\bin Build config: +a

[clang] [flang] [mlir] Avoid object libraries in the VS IDE (PR #93519)

2024-07-08 Thread Michael Kruse via cfe-commits
Meinersbur wrote: @dpalermo I added fix as PR #98072 https://github.com/llvm/llvm-project/pull/93519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add emitAtomicCompareExchangeBuiltin helper function (PR #101966)

2024-08-12 Thread Michael Kruse via cfe-commits
Meinersbur wrote: `TargetLibraryInfoImpl` is not contained in the backends, but implemented entirely in [`TargetLibraryInfo.cpp`](https://github.com/llvm/llvm-project/blob/main/llvm/lib/Analysis/TargetLibraryInfo.cpp). `TargetLowering` is implemented in the backend, but is also optional. If

[clang] [flang] [flang] Add --gcc-toolchain and --gcc-install-dir options to flang. (PR #87360)

2024-04-04 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur closed https://github.com/llvm/llvm-project/pull/87360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-06 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur commented: Not a full a review, but the first notes that I started with https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-06 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-06 Thread Michael Kruse via cfe-commits
@@ -1698,6 +1701,64 @@ void OpenMPIRBuilder::createTaskyield(const LocationDescription &Loc) { emitTaskyieldImpl(Loc); } +// Processes the dependencies in Dependencies and does the following +// - Allocates space on the stack of an array of DependInfo objects +// - Populate

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-06 Thread Michael Kruse via cfe-commits
@@ -2253,7 +2275,8 @@ class OpenMPIRBuilder { SmallVectorImpl &Inputs, GenMapInfoCallbackTy GenMapInfoCB, TargetBodyGenCallbackTy BodyGenCB, - TargetGenArgAccessor

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-06 Thread Michael Kruse via cfe-commits
@@ -1698,6 +1701,64 @@ void OpenMPIRBuilder::createTaskyield(const LocationDescription &Loc) { emitTaskyieldImpl(Loc); } +// Processes the dependencies in Dependencies and does the following +// - Allocates space on the stack of an array of DependInfo objects +// - Populate

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-06 Thread Michael Kruse via cfe-commits
@@ -1698,6 +1701,64 @@ void OpenMPIRBuilder::createTaskyield(const LocationDescription &Loc) { emitTaskyieldImpl(Loc); } +// Processes the dependencies in Dependencies and does the following +// - Allocates space on the stack of an array of DependInfo objects +// - Populate

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-06 Thread Michael Kruse via cfe-commits
@@ -1762,6 +1762,26 @@ class OpenMPIRBuilder { EmitFallbackCallbackTy EmitTargetCallFallbackCB, TargetKernelArgs &Args, Value *DeviceID, Value *RTLoc, InsertPointTy AllocaIP); + /// Generate a target-task for the target construct + /// + /// \param OutlinedFn Th

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-06 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-06 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
@@ -5229,13 +5362,288 @@ static void emitTargetOutlinedFunction( OMPBuilder.emitTargetRegionFunction(EntryInfo, GenerateOutlinedFunction, true, OutlinedFn, OutlinedFnID); } +OpenMPIRBuilder::InsertPointTy OpenMPIRBuilder::emitTargetTask(

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur commented: Conceptually, looks quite good. Just some style comments. https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
@@ -5212,6 +5273,78 @@ static Function *createOutlinedFunction( return Func; } +// Create an entry point for a target task with the following. +// It'll have the following signature +// void @.omp_target_task_proxy_func(i32 %thread.id, ptr %task) +// This function is called

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
@@ -5212,6 +5273,78 @@ static Function *createOutlinedFunction( return Func; } +// Create an entry point for a target task with the following. +// It'll have the following signature +// void @.omp_target_task_proxy_func(i32 %thread.id, ptr %task) +// This function is called

  1   2   3   4   >