mayurpandey updated this revision to Diff 69354.
mayurpandey added a comment.
Hi,
Updated the patch to handle the second crash. __builtin_signbit("1") was
crashing. I am not fully sure whether the check : if
(!Ty->isRealFloatingType()) is correct. Please review and let me know whether
it is f
mayurpandey updated this revision to Diff 69674.
mayurpandey added a comment.
Hi,
Updated the patch to add a template based testcase. As suggested by you, I
tried updating the error diagnostic to err_typecheck_cond_expect_float and to
issue diagnostic in similar fashion to err_typecheck_cond_ex
ping.
On Tue, Aug 30, 2016 at 7:32 PM, Mayur Pandey
wrote:
> mayurpandey updated this revision to Diff 69674.
> mayurpandey added a comment.
>
> Hi,
>
> Updated the patch to add a template based testcase. As suggested by you, I
> tried updating the error diagnostic to err_typecheck_cond_expect_f
mayurpandey updated this revision to Diff 78390.
mayurpandey added a comment.
Hi,
Updated the patch to incorporate the review comments. I had missed adding
ValArg->getType() when emitting the diagnostic which was cauing the crash.
Testing done, no regressions.
Thanks,
Mayur
https://reviews.l
mayurpandey updated this revision to Diff 78471.
mayurpandey added a comment.
Hi,
Updated the patch. Can you please commit it on my behalf as I don't have commit
access.
Thanks,
Mayur
https://reviews.llvm.org/D22334
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.
mayurpandey added a comment.
Hi David,
The crash that we see can be seen with other diagnostics for builtin if we use
the diagnostic format you suggested. I tried the same thing with
err_builtin_annotation_first_arg. The same crash can be seen. So shall I fix
this crash with this bug or file a
mayurpandey added a comment.
The crash on :
int x = __builtin_signbit("1");
is not a side effect of this patch. It was failing prior to the patch as well.
I can work on a new patch for this crash.
https://reviews.llvm.org/D22334
___
cfe-commits ma
mayurpandey created this revision.
mayurpandey added reviewers: george.burgess.iv, hfinkel.
mayurpandey added a subscriber: cfe-commits.
clang was crashing when no argument was provided to __builtin_signbit function.
Added a check to handle the error. No regressions on testing.
http://reviews.ll
