[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG16e5d6d7f98f: [clang] extend getCommonSugaredType to merge sugar nodes (authored by mizvekov). Changed prior to commit:

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. Thanks for the repro! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. In D111509#3778277 , @ronlieb wrote: > i am seeing similar issues in openmp buildbot failing with this patch I got a small patch coming up soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D133522: [clang] Fix Complex x Float conversions so it handles type sugar

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The included test case was broken by D111509 since now those types can have sugar. Re

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. Fix at https://reviews.llvm.org/D133522 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov retitled this revision from "[clang] Fix Complex x Float conversions so it handles type sugar" to "[clang] Fix Complex x Float x Int conversions so it handles type sugar". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 458877. Repository: rG LLVM

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov updated this revision to Diff 458881. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133522/new/ https://reviews.llvm.org/D133522 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/complex-int.c clang/test/SemaCXX/complex-conversion.cp

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov added a comment. I just included a similar fix for another problem I found inspecting nearby code for the same kind of bug: typedef __complex__ float ComplexFloat; int cc = 1 + (ComplexFloat)(1.0iF); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov added a comment. In D133262#3778532 , @royjacobson wrote: > In D133262#3775375 , @mizvekov > wrote: > >> @royjacobson I decided to do a complete job here and fix all those issues >> except #54993. Can

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov added a comment. In D133522#3778655 , @ronlieb wrote: > hopefully will fix this ? > invalid cast kind for complex value > UNREACHABLE executed at /clang/lib/AST/ExprConstant.cpp:14263! > PLEASE submit a bug report to https://github.com/llvm/llvm-

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov added a comment. In D133522#3778693 , @ronlieb wrote: > emailed a hopeful reproducer to you Thanks, seen! Going to start running creduce on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13352

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. In D111509#3778879 , @MaskRay wrote: > Since the fix was not merged, I will revert this soon. > > I saw a clang segfault with `clang++ libstdc++-v3/src/c++98/complex_io.cc` Would you mind if I just merge it? I was hoping there w

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov added a comment. Since the affected patch just got reverted, I will squash these fixes in the original MR instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133522/new/ https://reviews.llvm.org/D133522 ___

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 458924. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov added a comment. In D133522#3778693 , @ronlieb wrote: > emailed a hopeful reproducer to you I reduced it and confirm it was also fixed by this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 459067. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 459070. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariabl

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1091-1150 +QualType fpTy = ComplexTy->castAs()->getElementType(); IntExpr = S.ImpCastExprToType(IntExpr.get(), fpTy, CK_IntegralToFloating); IntExpr = S.ImpCastExprToType(IntExpr.get(), ComplexT

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov abandoned this revision. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1135 +QualType RHSElementType = +RHSComplexType ? RHSComplexType->getElementType() : RHSType; +QualType ResultType = shafik wrote: > Can you

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. In D111509#3778883 , @MaskRay wrote: > Sorry, I just reverted it:) You may check whether the fix fixes GCC > libstdc++-v3/src/c++98/complex_io.cc I confirm it does not crash on my system with this patch. Repository: rG LLVM

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626 + VisitDeclaratorDecl(D); + Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName()); + Record.push_back(D->getIdentifierNamespace()); + ChuanqiXu wrote: > mizvekov w

[PATCH] D133609: [Sema] compat warning of using deduced type in non-type template parameter

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1535-1545 +if (TInfo->getType()->getContainedAutoType()) { + // template + Diag(D.getIdentifierLoc(), + diag::warn_cxx14_compat_template_nontype_parm_auto_type) + << QualT

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626 + VisitDeclaratorDecl(D); + Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName()); + Record.push_back(D->getIdentifierNamespace()); + ChuanqiXu wrote: > mizvekov w

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 459362. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 459363. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaTemplateDeduc

[PATCH] D133261: NFC: [clang] add template AST test for make_integer_seq and type_pack_element

mizvekov updated this revision to Diff 459364. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133261/new/ https://reviews.llvm.org/D133261 Files: clang/test/SemaTemplate/make_integer_seq.cpp clang/test/SemaTemplate/type_pack_element.cpp Index: c

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov updated this revision to Diff 459365. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133262/new/ https://reviews.llvm.org/D133262 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ASTContext.h clang/include/clang/AST/DeclTempl

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 459366. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/performa

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

mizvekov updated this revision to Diff 459367. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132816/new/ https://reviews.llvm.org/D132816 Files: clang/include/clang/AST/Type.h clang/include/clang/AST/TypeProperties.td clang/lib/AST/ASTContext.

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov updated this revision to Diff 459368. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133468/new/ https://reviews.llvm.org/D133468 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/JSONNodeDumper.h clang/include/clang/

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 459369. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 459370. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaTemplateDeduc

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3783250 , @ychen wrote: > Hi @mizvekov , I noticed that deduction for partial ordering also inherits > this new behavior. Do you think partial ordering could opt out of this, or is > it better for partial ordering to

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3784615 , @ychen wrote: > `A` is currently modeled as ElaboratedType. It was > `TemplateSpecializationType` before. Reading comments for `ElaboratedType`, > it looks like sugar type might not be needed here? Ah you

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3784663 , @ychen wrote: > Thanks for the link. I'm not blocked by any of these patches, instead just > trying to have a mental model of when to expect the sugared type :-). For > partial ordering, the `TemplateSpecia

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. Even simpler: template using P = T; template void j(P, T, A...); template void j(P, T); void g() { j(P{}, int{}); } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D1112

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12367 + case Type::Class: \ +llvm_unreachable("Unexpected " Kind ": " #Class); + davrec wrote: > Could we just return `X` her

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 459725. Herald added subscribers: mstorsjo, arichardson. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-t

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 459726. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12367 + case Type::Class: \ +llvm_unreachable("Unexpected " Kind ": " #Class); + davrec wrote: > mizvekov wrote: > > davrec w

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov marked an inline comment as not done. mizvekov added a subscriber: davrec. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1091-1150 +QualType fpTy = ComplexTy->castAs()->getElementType(); IntExpr = S.ImpCastExprToType(IntExpr.get(), fpTy

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12367 + case Type::Class: \ +llvm_unreachable("Unexpected " Kind ": " #Class); + davrec wrote: > mizvekov wrote: > > davrec w

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. @alexfh This new revision that I just pushed should be good. Do you want to give it a look / test, or should we go ahead and merge it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D11

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3786610 , @vhscampos wrote: > For reference, another small reproducer of the crash, but with a different > stack trace than the first example posted here: > > // Must compile with -std=c++03 to crash > #include >

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

mizvekov added inline comments. Comment at: clang/include/clang/Sema/SemaConcept.h:54-68 + if (ArgA.getKind() == TemplateArgument::Type && + ArgB.getKind() == TemplateArgument::Type) +if (const auto *SubstA = +ArgA.getAsType()->getAs()) +

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5195-5196 +for (int i = 0, e = std::min(NumParams1, NumParams2); i < e; ++i) { + QualType T1 = FD1->getParamDecl(i)->getType().getDesugaredType(Context); + QualType T2 = FD2->getPar

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12367 + case Type::Class: \ +llvm_unreachable("Unexpected " Kind ": " #Class); + aaronpuchert wrote: > mizvekov wrote: > > da

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 459944. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 459946. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. @vhscampos that issue should be fixed now as well, thanks for the report! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 ___ cfe-comm

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 459959. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 460010. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 460021. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460036. mizvekov marked an inline comment as not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariab

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 460063. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/AST

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 460064. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaTemplate.cpp

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov updated this revision to Diff 460073. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133262/new/ https://reviews.llvm.org/D133262 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ASTContext.h clang/include/clang/AST/DeclTempl

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 460095. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassChe

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

mizvekov updated this revision to Diff 460127. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132816/new/ https://reviews.llvm.org/D132816 Files: clang/include/clang/AST/Type.h clang/include/clang/AST/TypeProperties.td clang/lib/AST/ASTContext.

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov updated this revision to Diff 460133. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133468/new/ https://reviews.llvm.org/D133468 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/JSONNodeDumper.h clang/include/clang/

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov retitled this revision from "WIP: Clang: fix AST representation of expanded template arguments." to "Clang: fix AST representation of expanded template arguments.". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 460206. mizvekov requested review of t

[PATCH] D133261: NFC: [clang] add template AST test for make_integer_seq and type_pack_element

mizvekov updated this revision to Diff 460219. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133261/new/ https://reviews.llvm.org/D133261 Files: clang/test/SemaTemplate/make_integer_seq.cpp clang/test/SemaTemplate/type_pack_element.cpp Index: c

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460220. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3792825 , @Abramo-Bagnara wrote: > These changes introduce a subtle bug in template instantiation of newly added > ElaboratedType around TypedefType: > > bool refersInstantiatedDecl(QualType T) in SemaTemplateInstant

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

mizvekov added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:52 + + llvm::SmallVector TemplateArgs; + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128012/new/ https://reviews.llvm.org/D

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. This looks reasonable, LGTM for what it's worth :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128012/new/ https://reviews.llvm.org/D12801

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

mizvekov added a subscriber: rjmccall. mizvekov added a comment. In D126172#3626809 , @roberteg16 wrote: > Hi again @mizvekov, I've been spending a bit of time on resuming this issue. > > When applying (after reverting the changes) the first change relat

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 447890. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-include-fixer/f

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG15f3cd6bfc67: [clang] Implement ElaboratedType sugaring for types

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 447973. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 447974. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov updated this revision to Diff 447988. mizvekov marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/ https://reviews.llvm.org/D128113 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/

[PATCH] D128095: clang: fix checking parameter packs for expansion

mizvekov updated this revision to Diff 447995. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/SemaInternal.h clang/lib/Sema/SemaTemplat

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 447997. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Fil

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3684722 , @hans wrote: > The problem is that just based on `Template` it's not clear whether it's > `S1::Foo` or `S2::Foo` that's referred to. The logic in the diagnostic here ended up doing a silent single step desu

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3684722 , @hans wrote: > Here's an example where I think this regressed a Clang diagnostic. Consider: Consider this simple extension of this example, to show how this general problem already existed: https://godbolt.

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/AST/QualTypeNames.cpp:455 + if (const auto *UT = QT->getAs()) { +return getFullyQualifiedType(UT->getUnderlyingType(), Ctx, + WithGlobalNsPrefix);

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. In D128113#3708204 , @davrec wrote: > This corrects a genuine deficiency in the AST, and the patch LGTM. Can we > knock this off Matheus' stack? Thanks :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d1a56929b72: Clang: fix AST representation of expanded template arguments. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D127695: WIP: clang: Implement Template Specialization Resugaring

mizvekov added inline comments. Comment at: clang/test/Sema/Resugar/resugar-expr.cpp:244 +// N-error@-2 {{with an rvalue of type 'int'}} +} // namespace t21 davrec wrote: > Compositions of MemberExprs/CXXMemberCallExprs have an issue: > ``` > template struct A {

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov updated this revision to Diff 359145. mizvekov added a comment. Herald added a subscriber: lxfind. Patch update: - Fixes issue where the workaround would completely supress implicit moves. - Improve tests to cover this issue. - Stop applying the workaround to throw expressions, as we hav

[PATCH] D106303: [clang] fix oops: enable implicit moves in MSVC compatibility mode

mizvekov created this revision. mizvekov added a reviewer: aaron.ballman. mizvekov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. When disabling simpler implicit moves in MSVC compatibility mode as a workaround in D105518

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov added a comment. While we are still reviewing this and it's probably going to take longer, I went ahead made a DR for fixing the same issue in main: https://reviews.llvm.org/D106303 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105951/new

[PATCH] D106303: [clang] fix oops: enable implicit moves in MSVC compatibility mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d68ecafd6ad: [clang] fix oops: enable implicit moves in MSVC compatibility mode (authored by mizvekov). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov added a comment. In D105951#2894888 , @STL_MSFT wrote: > FYI, we merged https://github.com/microsoft/STL/pull/2025 fixing the 2 > affected `return _Istr;` occurrences in `` and `` for VS > 2022 17.0 Preview 4. If you find any other affected ret

[PATCH] D105320: [CodeView] Skip emitting values bigger than supported by APInt.

mizvekov updated this revision to Diff 360643. mizvekov edited the summary of this revision. mizvekov added a comment. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. - Fixes more issues. - Add test cases. - Add some FIXME notes. Repository: rG LLVM Github Mon

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 360645. mizvekov added a comment. - Really `git add` the test case this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105320/new/ https://reviews.llvm.org/D105320 Files: clang/lib/CodeGen/CGDebugInfo.

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 360648. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105320/new/ https://reviews.llvm.org/D105320 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-cod

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov updated this revision to Diff 360660. mizvekov added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105951/new/ https://reviews.llvm.org/D105951 Files: clang/include/clang/Sema/Sema.h clang/lib/Frontend/InitPreprocess

[PATCH] D106585: Fix clang debug info irgen of i128 enums

mizvekov added a comment. Small nit but otherwise LGTM :) Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3118 +Value.setIsSigned(IsSigned); +Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value)); } Comment at: ll

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 361527. mizvekov marked an inline comment as done. mizvekov added a comment. - rebase on top of D106585 - Reimplement test based on IR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov added a comment. If you think landing this in 13 after the release branch is created will be complicated, then please consider this message a gentle **Ping** :) Frankly, I am satisfied with the mechanics of this workaround as is. - After another look, I think doing something more targe

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 361543. mizvekov marked 4 inline comments as done. mizvekov added a comment. - Expose and use APInt::isSingleWord. - Use ApInt::getLimitedValue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105320/new/ https:

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 361547. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105320/new/ https://reviews.llvm.org/D105320 Files: llvm/include/llvm/ADT/APInt.h llvm/include/llvm/IR/DIBuilder.h llvm/

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:3167 + + // TODO: Need to support bigger ints like __int128. + OS.AddComment("Value"); rnk wrote: > I don't think we need a TODO here. If Microsoft ever adds an encoding f

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf84c70a37939: [CodeView] Saturate values bigger than supported by APInt. (authored by mizvekov). Changed prior to commit: https://reviews.llvm.org

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20555a15a596: [clang] P2266 implicit moves STL workaround (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov added a comment. I received this report from one of the bots: https://lab.llvm.org/buildbot/#/builders/5/builds/9633/steps/13/logs/stdio ` FAIL: Clang :: CodeGenCXX/debug-info-enum-i128.cpp (5356 of 77963) TEST 'Clang :: CodeGenCXX/debug-info-enum-i128.cpp' F

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov added a comment. In D105320#2905887 , @rnk wrote: > Yes, I filed https://bugs.llvm.org/show_bug.cgi?id=51221 for it. I plan to > disable the test under asan for now. :-( Thanks for taking care of it though! Repository: rG LLVM Github Monor

[PATCH] D106907: [clang] fix concepts crash on substitution failure during normalization

mizvekov created this revision. mizvekov edited the summary of this revision. mizvekov added a reviewer: rsmith. mizvekov added a subscriber: Quuxplusone. mizvekov published this revision for review. mizvekov added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. T

<    1   2   3   4   5   6   7   8   9   10   >