This revision was automatically updated to reflect the committed changes.
Closed by commit rL273619: clang-format: [JS] handle conditionals in fields,
default params. (authored by mprobst).
Changed prior to commit:
http://reviews.llvm.org/D21658?vs=61726&id=61729#toc
Repository:
rL LLVM
htt
Author: mprobst
Date: Fri Jun 24 12:45:13 2016
New Revision: 273694
URL: http://llvm.org/viewvc/llvm-project?rev=273694&view=rev
Log:
clang-format: [JS] Fix build breakage.
Checking Line.MustBeDeclaration does actually break the field and param
initializer use case.
Modified:
cfe/trunk/lib/
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Checking Line.MustBeDeclaration does actually break the field and param
initializer use case.
http://reviews.llvm.org/D21691
Files:
lib/Format/TokenAnn
mprobst added a comment.
Sorry, my automated test run somehow didn't fail, and so I implemented your
suggestion which actually did break formatting.
Could you post-commit review this? It's already committed to fix the build.
http://reviews.llvm.org/D21691
___
ong as this doesn't fix a build breakage
> AFAICT. Do you mean a test failure? If so, it would be helpful to #include
> what's actually changing (before/after or calling out the failing test case
> or something).
>
>
> On Fri, Jun 24, 2016 at 7:45 PM, Martin Probst
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
ASCII case sorting does not help finding imported symbols quickly, and it is
common to have e.g. class Foo and function fooFactory exported/imported from
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D22147
Files:
lib/Format/SortJavaScriptImports.cpp
unittests/Format/SortImportsTestJS.cpp
Index: unittests/Format/SortImportsT
mprobst updated this revision to Diff 63271.
mprobst added a comment.
- clang-format: [JS] support trailing commas in imports.
http://reviews.llvm.org/D22146
Files:
lib/Format/SortJavaScriptImports.cpp
unittests/Format/SortImportsTestJS.cpp
Index: unittests/Format/SortImportsTestJS.cpp
===
Author: mprobst
Date: Sat Jul 9 10:09:22 2016
New Revision: 274976
URL: http://llvm.org/viewvc/llvm-project?rev=274976&view=rev
Log:
clang-format: [JS] support trailing commas in imports.
Reviewers: djasper
Subscribers: cfe-commits, klimek
Differential Revision: http://reviews.llvm.org/D22147
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274976: clang-format: [JS] support trailing commas in
imports. (authored by mprobst).
Changed prior to commit:
http://reviews.llvm.org/D22147?vs=63270&id=63390#toc
Repository:
rL LLVM
http://reviews
Author: mprobst
Date: Sat Jul 9 10:11:18 2016
New Revision: 274977
URL: http://llvm.org/viewvc/llvm-project?rev=274977&view=rev
Log:
clang-format: [JS] Sort imports case insensitive.
Summary: ASCII case sorting does not help finding imported symbols quickly, and
it is common to have e.g. class
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274977: clang-format: [JS] Sort imports case insensitive.
(authored by mprobst).
Changed prior to commit:
http://reviews.llvm.org/D22146?vs=63271&id=63391#toc
Repository:
rL LLVM
http://reviews.llvm
>> AFAICT. Do you mean a test failure? If so, it would be helpful to #include
>>> what's actually changing (before/after or calling out the failing test case
>>> or something).
>>>
>>>
>>> On Fri, Jun 24, 2016 at 7:45 PM, Martin Probst
cription seems wrong as this doesn't fix a build breakage
>>>> AFAICT. Do you mean a test failure? If so, it would be helpful to #include
>>>> what's actually changing (before/after or calling out the failing test case
>>>> or something).
>>>>
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D22431
Files:
lib/Format/FormatTokenLexer.cpp
lib/Format/FormatTokenLexer.h
lib/Format/TokenAnnotator.cpp
unittests/Format
mprobst added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:1821
@@ -1819,1 +1820,3 @@
+(Right.is(TT_TemplateString) && Right.TokenText.startswith("}")))
+ return 100;
}
I've chosen 100 by fair dice roll. Please advise on how to pick a
mprobst added inline comments.
Comment at: lib/Format/Format.cpp:1087
@@ +1086,3 @@
+(Style.Quotes == FormatStyle::QS_Single &&
+ !FormatTok->TokenText.startswith("\"")) ||
+(Style.Quotes == FormatStyle::QS_Double &&
djasper wrote:
> Are th
mprobst updated this revision to Diff 49562.
mprobst marked 6 inline comments as done.
mprobst added a comment.
- Move code closer together by piping Replacements into the FormatTokenLexer.
- remove sstream import
- * Treat JavaScript single quoted string literals as tok::string_literal, not
- Add
mprobst updated this revision to Diff 49569.
mprobst marked an inline comment as done.
mprobst added a comment.
- Move code closer together by piping Replacements into the FormatTokenLexer.
- remove sstream import
- * Treat JavaScript single quoted string literals as tok::string_literal, not
- Add
mprobst updated this revision to Diff 49579.
mprobst added a comment.
- Move code closer together by piping Replacements into the FormatTokenLexer.
- remove sstream import
- * Treat JavaScript single quoted string literals as tok::string_literal, not
- Address review comments, mostly renaming thin
mprobst marked 2 inline comments as done.
Comment at: unittests/Format/FormatTestJS.cpp:639-640
@@ -638,3 +638,4 @@
verifyFormat("var literal = 'hello ' +\n"
- "'world';");
+ "'worldworldworldworld';",
+ getGoogleJSStyleWithColu
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added subscribers: cfe-commits, klimek.
Automatic Semicolon Insertion can only be properly handled by parsing
source code. However conservatively catching just a few, common
situations prevents breaking code during developme
mprobst updated this revision to Diff 49883.
mprobst added a comment.
- Handle unary !.
http://reviews.llvm.org/D17910
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
mprobst updated this revision to Diff 49922.
mprobst marked 6 inline comments as done.
mprobst added a comment.
- Handle unary !.
- Address review comments.
http://reviews.llvm.org/D17910
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTes
mprobst added inline comments.
Comment at: unittests/Format/FormatTestJS.cpp:56
@@ +55,3 @@
+
+ static void verifyFormatNoMessup(
+ llvm::StringRef Code,
djasper wrote:
> I don't think it is useful to do this as there are always ways in which
> formatting c
mprobst updated this revision to Diff 50537.
mprobst added a comment.
- Handle unary !.
- Address review comments.
- Support declarations and statements in ASI.
http://reviews.llvm.org/D17910
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/Forma
mprobst created this revision.
mprobst added reviewers: djasper, klimek, cfe-commits.
Herald added a subscriber: klimek.
`import ... from ...; // from //foo:bar` serves as the equivalent if an IWYU
pragma. This change matches `// from //.*` style comments and never allows them
to wrap, just like
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
| and & in types, as opposed to the bitwise operators, should not have
whitespace around them (e.g. `Foo`).
http://reviews.llvm.org/D18294
Files:
lib/Fo
mprobst updated this revision to Diff 51159.
mprobst marked 2 inline comments as done.
mprobst added a comment.
- Address review comments.
http://reviews.llvm.org/D18294
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Forma
mprobst added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2154
@@ -2141,1 +2153,3 @@
return Style.SpacesInAngles;
+ if (Style.Language == FormatStyle::LK_JavaScript &&
+ (Left.is(TT_JsTypeOperator) || Right.is(TT_JsTypeOperator)))
djasper
mprobst marked an inline comment as done.
mprobst added a comment.
As discussed offline, this matches existing very similar behaviour for
destructured goog.require calls:
js
const {X, Y, Z} = goog.require('a'); // won't ever wrap
import {X, Y, Z} from 'a'; // Shouldn't ever wrap
It also
mprobst marked an inline comment as done.
Comment at: lib/Format/TokenAnnotator.cpp:760
@@ +759,3 @@
+ if (CurrentToken->is(tok::kw_export)) {
+// Find the 'from' part of export {...} from '...';
+// The difference here is that "export {...};" should not be tr
mprobst updated this revision to Diff 51267.
mprobst marked an inline comment as done.
mprobst added a comment.
- Address review comments:
http://reviews.llvm.org/D17440
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Forma
mprobst updated this revision to Diff 51268.
mprobst added a comment.
Rebase diff on current master.
http://reviews.llvm.org/D17440
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
mprobst updated this revision to Diff 51269.
mprobst added a comment.
- Address review comments:
- Add one more explanatory comment.
http://reviews.llvm.org/D17440
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/Form
mprobst marked 3 inline comments as done.
mprobst added a comment.
http://reviews.llvm.org/D17440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst added a comment.
I've asked for it, but don't have it yet. Feel free to commit on by behalf.
http://reviews.llvm.org/D17440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst abandoned this revision.
mprobst added a comment.
Abandoning this in favour of the "don't break imports at all" change.
http://reviews.llvm.org/D18283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: Martin Probst
Date: 2022-01-27T16:16:37+01:00
New Revision: c6d5efb5d98093c4bd7578b2ea52c9032d20dea3
URL:
https://github.com/llvm/llvm-project/commit/c6d5efb5d98093c4bd7578b2ea52c9032d20dea3
DIFF:
https://github.com/llvm/llvm-project/commit/c6d5efb5d98093c4bd7578b2ea52c9032d20dea3.diff
Author: Martin Probst
Date: 2022-01-28T11:51:28+01:00
New Revision: 03c59765b3eb2f2233728da8e16637f802147d66
URL:
https://github.com/llvm/llvm-project/commit/03c59765b3eb2f2233728da8e16637f802147d66
DIFF:
https://github.com/llvm/llvm-project/commit/03c59765b3eb2f2233728da8e16637f802147d66.diff
Author: Martin Probst
Date: 2022-01-28T12:37:45+01:00
New Revision: c26729251588cb6e9e20c3edf67d14ac9b549f9b
URL:
https://github.com/llvm/llvm-project/commit/c26729251588cb6e9e20c3edf67d14ac9b549f9b
DIFF:
https://github.com/llvm/llvm-project/commit/c26729251588cb6e9e20c3edf67d14ac9b549f9b.diff
Author: Martin Probst
Date: 2021-04-30T14:18:52+02:00
New Revision: b2780cd744eaad6f5c7f39165054cf7000a1ff07
URL:
https://github.com/llvm/llvm-project/commit/b2780cd744eaad6f5c7f39165054cf7000a1ff07
DIFF:
https://github.com/llvm/llvm-project/commit/b2780cd744eaad6f5c7f39165054cf7000a1ff07.diff
Author: Martin Probst
Date: 2021-12-06T19:01:24+01:00
New Revision: 327d966365d7b34abd25a920e1f7b5aecfa5c70f
URL:
https://github.com/llvm/llvm-project/commit/327d966365d7b34abd25a920e1f7b5aecfa5c70f
DIFF:
https://github.com/llvm/llvm-project/commit/327d966365d7b34abd25a920e1f7b5aecfa5c70f.diff
Author: Martin Probst
Date: 2021-03-30T14:31:24+02:00
New Revision: 2b30bd2be0a898d0e7cb9eb3f2cf0e0efeaa83e9
URL:
https://github.com/llvm/llvm-project/commit/2b30bd2be0a898d0e7cb9eb3f2cf0e0efeaa83e9
DIFF:
https://github.com/llvm/llvm-project/commit/2b30bd2be0a898d0e7cb9eb3f2cf0e0efeaa83e9.diff
Author: Martin Probst
Date: 2021-04-14T17:20:07+02:00
New Revision: d45df0d29f7005d3c25357f3982002eaf339f875
URL:
https://github.com/llvm/llvm-project/commit/d45df0d29f7005d3c25357f3982002eaf339f875
DIFF:
https://github.com/llvm/llvm-project/commit/d45df0d29f7005d3c25357f3982002eaf339f875.diff
Author: Martin Probst
Date: 2021-04-14T17:20:08+02:00
New Revision: 4d195f1b4dd6e3978776d69f49840439933a2543
URL:
https://github.com/llvm/llvm-project/commit/4d195f1b4dd6e3978776d69f49840439933a2543
DIFF:
https://github.com/llvm/llvm-project/commit/4d195f1b4dd6e3978776d69f49840439933a2543.diff
Author: Martin Probst
Date: 2021-04-14T19:41:18+02:00
New Revision: 2fe4909748b5f14499e83b0647b7e9ddd0068a15
URL:
https://github.com/llvm/llvm-project/commit/2fe4909748b5f14499e83b0647b7e9ddd0068a15
DIFF:
https://github.com/llvm/llvm-project/commit/2fe4909748b5f14499e83b0647b7e9ddd0068a15.diff
Author: Martin Probst
Date: 2021-04-20T13:08:18+02:00
New Revision: 3d4a6037ff462bc3e41e4924c603f0e3dfc2c06a
URL:
https://github.com/llvm/llvm-project/commit/3d4a6037ff462bc3e41e4924c603f0e3dfc2c06a
DIFF:
https://github.com/llvm/llvm-project/commit/3d4a6037ff462bc3e41e4924c603f0e3dfc2c06a.diff
Author: Martin Probst
Date: 2021-04-21T16:33:55+02:00
New Revision: 70ae843d99808b19247e968507c0019225597066
URL:
https://github.com/llvm/llvm-project/commit/70ae843d99808b19247e968507c0019225597066
DIFF:
https://github.com/llvm/llvm-project/commit/70ae843d99808b19247e968507c0019225597066.diff
Author: Martin Probst
Date: 2021-04-22T10:36:47+02:00
New Revision: fbc6f42dbee5d1d4ced30f520418c2b62942845a
URL:
https://github.com/llvm/llvm-project/commit/fbc6f42dbee5d1d4ced30f520418c2b62942845a
DIFF:
https://github.com/llvm/llvm-project/commit/fbc6f42dbee5d1d4ced30f520418c2b62942845a.diff
301 - 350 of 350 matches
Mail list logo
