r315864 - [driver] [cl] Add/fix c++17/c++latest

Author: martell Date: Sun Oct 15 10:27:58 2017 New Revision: 315864 URL: http://llvm.org/viewvc/llvm-project?rev=315864&view=rev Log: [driver] [cl] Add/fix c++17/c++latest Patch by: daxpedda Differential Revision: https://reviews.llvm.org/D38123 Modified: cfe/trunk/lib/Driver/ToolChains/Cla

r315867 - Driver: use ld64.lld when -fuse-ld=lld for darwin

Author: martell Date: Sun Oct 15 10:53:45 2017 New Revision: 315867 URL: http://llvm.org/viewvc/llvm-project?rev=315867&view=rev Log: Driver: use ld64.lld when -fuse-ld=lld for darwin When using lld on macOS the current level of detection between ld and ld64 forces us to rename lld to ld. For EL

r315868 - Fix test case regresstion from rL315864

Author: martell Date: Sun Oct 15 11:01:28 2017 New Revision: 315868 URL: http://llvm.org/viewvc/llvm-project?rev=315868&view=rev Log: Fix test case regresstion from rL315864 The patch should have been checking against STDCXX17 not STDCXX14. Modified: cfe/trunk/test/Driver/cl-options.c Modif

[libcxx] r303928 - libcxx: fix bootstrapping for mingw-w64

Author: martell Date: Thu May 25 17:37:15 2017 New Revision: 303928 URL: http://llvm.org/viewvc/llvm-project?rev=303928&view=rev Log: libcxx: fix bootstrapping for mingw-w64 Differential Revision: https://reviews.llvm.org/D33388 Modified: libcxx/trunk/cmake/config-ix.cmake libcxx/trunk/i

Re: r304012 - Enable __float128 for mingw for GCC compatibility and define __SIZEOF_FLOAT128__ on x86

Thanks Reid for looking at this today On Fri, May 26, 2017 at 6:38 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Fri May 26 12:38:15 2017 > New Revision: 304012 > > URL: http://llvm.org/viewvc/llvm-project?rev=304012&view=rev > Log: > Enable __float1

[libcxxabi] r304026 - [libcxxabi] iconv is not needed for mingw-w64

Author: martell Date: Fri May 26 14:39:39 2017 New Revision: 304026 URL: http://llvm.org/viewvc/llvm-project?rev=304026&view=rev Log: [libcxxabi] iconv is not needed for mingw-w64 Modified: libcxxabi/trunk/cmake/config-ix.cmake Modified: libcxxabi/trunk/cmake/config-ix.cmake URL: http://llv

[libcxxabi] r304110 - [libcxxabi] Disable DLL annotations on static

Author: martell Date: Sun May 28 17:46:50 2017 New Revision: 304110 URL: http://llvm.org/viewvc/llvm-project?rev=304110&view=rev Log: [libcxxabi] Disable DLL annotations on static rL288692 renames _LIBCXXABI_DISABLE_DLL_IMPORT_EXPORT to _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS Modified: lib

[libcxxabi] r304374 - [libcxxabi] Rework CMakeLists.txt into modules

Author: martell Date: Wed May 31 19:09:20 2017 New Revision: 304374 URL: http://llvm.org/viewvc/llvm-project?rev=304374&view=rev Log: [libcxxabi] Rework CMakeLists.txt into modules Refactor cmake to remove dependence on LLVM's cmake modules. This improves handling of cmake checks when cross compi

[libcxxabi] r304664 - [libcxxabi] HandleLLVMOptions in out of tree build

Author: martell Date: Sat Jun 3 12:23:19 2017 New Revision: 304664 URL: http://llvm.org/viewvc/llvm-project?rev=304664&view=rev Log: [libcxxabi] HandleLLVMOptions in out of tree build Differential revision: https://reviews.llvm.org/D33753 Modified: libcxxabi/trunk/cmake/Modules/HandleOutOfT

r313082 - [Driver] MinGW: Remove custom linker detection

Author: martell Date: Tue Sep 12 15:14:18 2017 New Revision: 313082 URL: http://llvm.org/viewvc/llvm-project?rev=313082&view=rev Log: [Driver] MinGW: Remove custom linker detection In rL289668 the ability to specify the default linker at compile time was added but because the MinGW driver used cu

[libcxx] r313084 - libcxx: fix merge_archives error variable name

Author: martell Date: Tue Sep 12 15:32:02 2017 New Revision: 313084 URL: http://llvm.org/viewvc/llvm-project?rev=313084&view=rev Log: libcxx: fix merge_archives error variable name Differential Revision: https://reviews.llvm.org/D37728 Modified: libcxx/trunk/utils/merge_archives.py Modified

Re: r313082 - [Driver] MinGW: Remove custom linker detection

green.lab.llvm.org/green/job/clang-stage1-cmake-RA- > incremental/42380/ > > it appears this commit is causing some tests to fail on our bots. Any > assistance you may provide in getting the bots back green would be greatly > appreciated. > > Respectfully, > Mike Edwards &

r313088 - Revert "[Driver] MinGW: Remove custom linker detection"

Author: martell Date: Tue Sep 12 15:58:12 2017 New Revision: 313088 URL: http://llvm.org/viewvc/llvm-project?rev=313088&view=rev Log: Revert "[Driver] MinGW: Remove custom linker detection" This reverts rL313082 Modified: cfe/trunk/lib/Driver/ToolChains/MinGW.cpp cfe/trunk/test/Driver/mi

Re: r313082 - [Driver] MinGW: Remove custom linker detection

look at: >> http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-in >> cremental/42380/ >> >> it appears this commit is causing some tests to fail on our bots. Any >> assistance you may provide in getting the bots back green would be greatly >> appreciated.

Re: r313088 - Revert "[Driver] MinGW: Remove custom linker detection"

Will do in future, thanks Rui. On Wed, Sep 13, 2017 at 12:03 AM, Rui Ueyama wrote: > When you revert a commit, please explain why you are reverting it in the > commit message. > > On Tue, Sep 12, 2017 at 3:58 PM, Martell Malone via cfe-commits < > cfe-commits@lists.llvm.org&g

Re: r313082 - [Driver] MinGW: Remove custom linker detection

green/job/clang-stage1-cmake-RA-in >>> cremental/42380/ >>> >>> it appears this commit is causing some tests to fail on our bots. Any >>> assistance you may provide in getting the bots back green would be greatly >>> appreciated. >>> >>> Respe

Re: r313088 - Revert "[Driver] MinGW: Remove custom linker detection"

2017 at 4:04 PM, Martell Malone > wrote: > >> Will do in future, thanks Rui. >> >> On Wed, Sep 13, 2017 at 12:03 AM, Rui Ueyama wrote: >> >>> When you revert a commit, please explain why you are reverting it in the >>> commit message. >>> &

r313102 - [Driver] MinGW: Remove custom linker detection

Author: martell Date: Tue Sep 12 17:46:54 2017 New Revision: 313102 URL: http://llvm.org/viewvc/llvm-project?rev=313102&view=rev Log: [Driver] MinGW: Remove custom linker detection In rL289668 the ability to specify the default linker at compile time was added but because the MinGW driver used cu

r313104 - Revert "[Driver] MinGW: Remove custom linker detection"

Author: martell Date: Tue Sep 12 17:57:50 2017 New Revision: 313104 URL: http://llvm.org/viewvc/llvm-project?rev=313104&view=rev Log: Revert "[Driver] MinGW: Remove custom linker detection" This reverts rL313102 because it still fails some build bot tests. On many linux bots it fails with the fo

Re: r313104 - Revert "[Driver] MinGW: Remove custom linker detection"

s because the only place where lld is remapped to lld-link is in lib/Driver/ToolChains/MSVC.cpp and that is only for msvc targets with a testcase in test/Driver/cl-link.c Best, Martell On Wed, Sep 13, 2017 at 1:57 AM, Martell Malone via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

Re: r313104 - Revert "[Driver] MinGW: Remove custom linker detection"

lld is remapped to lld-link is in lib/Driver/ToolChains/MSVC.cpp > and that is only for msvc targets with a testcase in test/Driver/cl-link.c > > Best, > Martell > > > On Wed, Sep 13, 2017 at 1:57 AM, Martell Malone via cfe-commits < > cfe-commits@lists.llvm.org> wrote: &

r319294 - Toolchain: Normalize dwarf, sjlj and seh eh

Author: martell Date: Tue Nov 28 22:25:13 2017 New Revision: 319294 URL: http://llvm.org/viewvc/llvm-project?rev=319294&view=rev Log: Toolchain: Normalize dwarf, sjlj and seh eh adds -fseh-exceptions and -fdwarf-exceptions flags clang will check if the user has specified an exception model flag,

r319295 - Revert "Toolchain: Normalize dwarf, sjlj and seh eh"

Author: martell Date: Tue Nov 28 22:51:27 2017 New Revision: 319295 URL: http://llvm.org/viewvc/llvm-project?rev=319295&view=rev Log: Revert "Toolchain: Normalize dwarf, sjlj and seh eh" This reverts rL319294. The windows sanitizer does not like seh on x86. Will re apply with None type for x86 R

r319297 - Toolchain: Normalize dwarf, sjlj and seh eh

Author: martell Date: Tue Nov 28 23:25:12 2017 New Revision: 319297 URL: http://llvm.org/viewvc/llvm-project?rev=319297&view=rev Log: Toolchain: Normalize dwarf, sjlj and seh eh This is a re-apply of r319294. adds -fseh-exceptions and -fdwarf-exceptions flags clang will check if the user has sp

Re: r319297 - Toolchain: Normalize dwarf, sjlj and seh eh

NK2001: unresolved external symbol > __gxx_personality_seh0 > > I'll dig in a bit to see if there's an easy fix. > > On Tue, Nov 28, 2017 at 11:25 PM, Martell Malone via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: martell >> Date

Re: r319297 - Toolchain: Normalize dwarf, sjlj and seh eh

t much later. On Wed, Nov 29, 2017 at 2:07 PM, Martin Storsjö wrote: > On Wed, 29 Nov 2017, Martin Storsjö via cfe-commits wrote: > > On Wed, 29 Nov 2017, Reid Kleckner wrote: >> >> On Wed, Nov 29, 2017 at 12:21 PM, Martin Storsjö >>> wrote: >>> On Wed

r317397 - [Driver] MinGW: Remove custom linker detection

Author: martell Date: Fri Nov 3 19:07:59 2017 New Revision: 317397 URL: http://llvm.org/viewvc/llvm-project?rev=317397&view=rev Log: [Driver] MinGW: Remove custom linker detection This is a re-apply of rL313082 which was reverted in rL313088 In rL289668 the ability to specify the default linker

r317398 - CodeGenCXX: no default dllimport storage for mingw

Author: martell Date: Fri Nov 3 19:15:49 2017 New Revision: 317398 URL: http://llvm.org/viewvc/llvm-project?rev=317398&view=rev Log: CodeGenCXX: no default dllimport storage for mingw GNU frontends don't have options like /MT, /MD This fixes a few link error regressions with libc++ and libc++abi

r318608 - [Driver] add initial support for alpine linux

Author: martell Date: Sat Nov 18 16:08:12 2017 New Revision: 318608 URL: http://llvm.org/viewvc/llvm-project?rev=318608&view=rev Log: [Driver] add initial support for alpine linux set -pie as default for musl linux targets add detection of alpine linux append appropriate compile flags for alpine

r318736 - [MS] add an init test for thumbv7-windows-msvc

Author: martell Date: Tue Nov 21 00:09:59 2017 New Revision: 318736 URL: http://llvm.org/viewvc/llvm-project?rev=318736&view=rev Log: [MS] add an init test for thumbv7-windows-msvc Modified: cfe/trunk/test/Preprocessor/init.c Modified: cfe/trunk/test/Preprocessor/init.c URL: http://llvm.org

r318755 - [MINGW] normalize WIN32 macros

Author: martell Date: Tue Nov 21 03:28:29 2017 New Revision: 318755 URL: http://llvm.org/viewvc/llvm-project?rev=318755&view=rev Log: [MINGW] normalize WIN32 macros move _WIN64 and _WIN32 defines to lib/Basic/Targets/OSTargets.h move WIN32, WIN64 and __MINGW64__ to addMinGWDefines fixes __MINGW6

r300555 - Driver: Better detection of mingw-gcc

Author: martell Date: Tue Apr 18 09:27:36 2017 New Revision: 300555 URL: http://llvm.org/viewvc/llvm-project?rev=300555&view=rev Log: Driver: Better detection of mingw-gcc Stop blindly searching for "gcc.exe" on windows. Stop assuming "/usr" on unix, fixes cross compiling. Reviewers: mati865, ya

Re: r300555 - Driver: Better detection of mingw-gcc

've got the wrong Phabricator link in the commit log. > > On 18 April 2017 at 15:27, Martell Malone via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: martell >> Date: Tue Apr 18 09:27:36 2017 >> New Revision: 300555 >> >> URL:

r300562 - mingw-w64: enable support for __declspec(selectany)

Author: martell Date: Tue Apr 18 10:56:24 2017 New Revision: 300562 URL: http://llvm.org/viewvc/llvm-project?rev=300562&view=rev Log: mingw-w64: enable support for __declspec(selectany) Add selectany as a GCC spelling for mingw-w64 Reviewers: rnk Differential revision: https://reviews.llvm.org/

[libcxxabi] r302824 - [Libcxxabi]: Support using compiler-rt for MinGW64

Author: martell Date: Thu May 11 16:16:29 2017 New Revision: 302824 URL: http://llvm.org/viewvc/llvm-project?rev=302824&view=rev Log: [Libcxxabi]: Support using compiler-rt for MinGW64 Reviewers: EricWF Differential Revision: https://reviews.llvm.org/D33098 Modified: libcxxabi/trunk/cmake/c

r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

For reference It was raised again here also https://github.com/Alexpux/MINGW-packages/issues/722 "that is extended from X86TargetInfo Which sets LongDoubleFormat = &llvm::APFloat::x87DoubleExtended;" On Saturday, Septem

Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

martell updated this revision to Diff 32007. martell added a comment. Updated to address yaron's comments. Okay for me to merge now ? http://reviews.llvm.org/D11808 Files: lib/Driver/MinGWToolChain.cpp test/Driver/Inputs/mingw_clang_tree/mingw32/i686-w64-mingw32/include/.keep test/Driver

r244902 - Driver: Fix include directories when not using libgcc under mingw

Author: martell Date: Thu Aug 13 10:41:04 2015 New Revision: 244902 URL: http://llvm.org/viewvc/llvm-project?rev=244902&view=rev Log: Driver: Fix include directories when not using libgcc under mingw Summary: When we want to use mingw-w64 and clang with compiler-rt we should not need to have libg

Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

This revision was automatically updated to reflect the committed changes. Closed by commit rL244902: Driver: Fix include directories when not using libgcc under mingw (authored by martell). Changed prior to commit: http://reviews.llvm.org/D11808?vs=32007&id=32062#toc Repository: rL LLVM htt

Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

Hi Hans, Is this bugfix something that can be merged into 3.7 ? Kind Regards Martell On Thu, Aug 13, 2015 at 4:42 PM, Martell Malone wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL244902: Driver: Fix include directories when not using >

[PATCH] D12034: WindowsARM: ignore calling conventions as described on MSDN

martell created this revision. martell added a reviewer: rnk. martell added subscribers: compnerd, cfe-commits. Herald added subscribers: rengolin, aemerson. MSDN says that fastcall stdcall and thiscall and vectorcall are all accepted but ignored on ARM and X64 https://msdn.microsoft.com/en-us/l

Re: [PATCH] D12034: WindowsARM: ignore calling conventions as described on MSDN

martell added inline comments. Comment at: test/Parser/arm-windows-calling-convention-handling.c:2 @@ -1,3 @@ -// RUN: %clang_cc1 -triple thumbv7-windows -fms-compatibility -fsyntax-only -verify %s - -int __cdecl cdecl(int a, int b, int c, int d) { // expected-warning {{calling

Re: [PATCH] D12034: WindowsARM: ignore calling conventions as described on MSDN

martell updated this revision to Diff 32164. martell added a comment. updated to reflect rnk comments http://reviews.llvm.org/D12034 Files: lib/Basic/Targets.cpp test/Parser/arm-windows-calling-convention-handling.c test/Parser/x64-windows-calling-convention-handling.c Index: test/Parser

Re: [PATCH] D12034: WindowsARM: ignore calling conventions as described on MSDN

This revision was automatically updated to reflect the committed changes. Closed by commit rL245076: Windows ARM: ignore calling conventions as described on MSDN (authored by martell). Changed prior to commit: http://reviews.llvm.org/D12034?vs=32164&id=32166#toc Repository: rL LLVM http://r

r245076 - Windows ARM: ignore calling conventions as described on MSDN

Author: martell Date: Fri Aug 14 13:00:09 2015 New Revision: 245076 URL: http://llvm.org/viewvc/llvm-project?rev=245076&view=rev Log: Windows ARM: ignore calling conventions as described on MSDN Summary: MSDN says that fastcall, stdcall, thiscall, and vectorcall are all accepted but ignored on AR

r245084 - WindowsX86: long double is x87DoubleExtended on mingw

Author: martell Date: Fri Aug 14 14:05:56 2015 New Revision: 245084 URL: http://llvm.org/viewvc/llvm-project?rev=245084&view=rev Log: WindowsX86: long double is x87DoubleExtended on mingw Summary: long double on x86 mingw is 80bits and is aligned to 16bytes Fixes: https://llv

Re: [PATCH] D12037: WindowsX86: long double is x87DoubleExtended on mingw-w64

martell added a comment. Landed in http://reviews.llvm.org/rL245084 The commit parser is bugged :/ http://reviews.llvm.org/D12037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12037: WindowsX86: long double is x87DoubleExtended on mingw-w64

martell added a comment. Hans this is something we most definitely should have in 3.7 It's a pretty big bugfix for this target :) http://reviews.llvm.org/D12037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

gt; > current clang. >> > I fixed this and added test in r245459+r245462. >> > >> > >> > 2015-08-19 19:41 GMT+03:00 Hans Wennborg via cfe-commits >> > : >> >> >> >> On Tue, Aug 18, 2015 at 6:11 PM, Richard Smith >> >&

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

> > There is no testcase for PR24398 nor the OP reporting the problem was > actually solved. Martell? I'm just re-looking through it now. X86TargetInfo sets LongDoubleFormat = &llvm::APFloat::x87DoubleExtended; X86_64TargetInfo then sets LongDoubleWidth = LongDoubleAlign = 128; X86_32TargetInfo t

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

I feel very silly now. After testing the testcase again on svn it still works. It appears the OP was looking for this patch to go onto the 3.6 branch and was applying my patch to that. I'll know in future to recheck the testcase afterwards myself in future. Apologies for the noise guys. Yaron I

[PATCH] D12466: Fix empty -L Path on OSX hosts

martell created this revision. martell added reviewers: rnk, yaron.keren. martell added a subscriber: cfe-commits. martell set the repository for this revision to rL LLVM. Not quite sure if this is the proper way to fix this. This is currently my work around when working from an OSX host though.

[PATCH] D14179: Remove some legacy mingw-w64 gcc struct info

martell created this revision. martell added a reviewer: rnk. martell added a subscriber: cfe-commits. GCC versions starting at 4.8+ conform to standard Windows 64-bit ABI. Not quite sure if we should keep this to support mingw-w64 and gcc 4.6 Thoughts ? Also it seems to fix: https://llvm.org/bug

[PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell created this revision. martell added a reviewer: rnk. martell added subscribers: cfe-commits, yaron.keren, compnerd. As of commit b8a164 mingw-w64 support clang with -fms-extensions. We can built the mingw-w64 crt with clang now also. As we are dropping support for mingw.org I think switch

Re: [PATCH] D14179: Remove some legacy mingw-w64 gcc struct info

martell added a subscriber: chapuni. martell added a comment. Ohh wow thats dated Dec 12 2013 I assume this would be suitable for 3.7.x then also. This was originally introduced by @chapuni in http://reviews.llvm.org/rL126186 No test case seems to be present for this so I think this should be good

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell added a comment. In http://reviews.llvm.org/D14180#279651, @rnk wrote: > Will Clang be able to compile the last few stable mingw-w64 releases with > this change? I'd like that to keep working. Clang has not been able to compile mingw-w64 crt for the last few releases. I have only added

r251930 - Remove some legacy mingw-w64 gcc struct info

Author: martell Date: Tue Nov 3 09:57:45 2015 New Revision: 251930 URL: http://llvm.org/viewvc/llvm-project?rev=251930&view=rev Log: Remove some legacy mingw-w64 gcc struct info As of gcc 4.7 mingw-w64 no longer emits 128-bit structs as i128 Differential Revision: http://reviews.llvm.org/D14179

Re: [PATCH] D14179: Remove some legacy mingw-w64 gcc struct info

This revision was automatically updated to reflect the committed changes. Closed by commit rL251930: Remove some legacy mingw-w64 gcc struct info (authored by martell). Changed prior to commit: http://reviews.llvm.org/D14179?vs=38744&id=39067#toc Repository: rL LLVM http://reviews.llvm.org/

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell added a comment. > This is what I'm worried about. :) Can you elaborate on what would break? Essentially mingw-w64 has a few header defines for working around builtings such as __rtdsc and the interlocked functions and some other builtins As soon as one of these headers are included it

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell added a comment. In http://reviews.llvm.org/D14180#280184, @rnk wrote: > You're mostly interested in the non-builtin parts of -fms-extensions, like > declspec and UUID, right? Yes that would be one of the main reasons, gcc is very lacking in this department :) > You can then change t

Re: [PATCH] D14179: Remove some legacy mingw-w64 gcc struct info

martell added a comment. From what I can gather it made sense at the time of gcc 4.6 so I don't think anyone is at fault :) Repository: rL LLVM http://reviews.llvm.org/D14179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

martell created this revision. martell added a reviewer: yaron.keren. martell added a subscriber: cfe-commits. When gcc is not installed we fail to set the correct include and lib directory. In some cases base is set and we might want to use clang without gcc being installed http://reviews.llvm.

Re: r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

The reason why I didn't use -fuse-ld=lld2 was because on Windows we don't have symlinks. I figured passing flavor gets over this hurdle and the installation takes up less space. If you want to change it I have no objections we will just have to look at having lld's cmake to ensure it is created on

r253813 - Driver: Specifically tell the linker the target for mingw-w64

Author: martell Date: Sat Nov 21 23:40:06 2015 New Revision: 253813 URL: http://llvm.org/viewvc/llvm-project?rev=253813&view=rev Log: Driver: Specifically tell the linker the target for mingw-w64 Cross compiling from linux and OSX results in Error: Exec format. This is because the linker is expec

r253815 - Test: Update mingw-useld.c to reflect r253813

Author: martell Date: Sat Nov 21 23:45:03 2015 New Revision: 253815 URL: http://llvm.org/viewvc/llvm-project?rev=253815&view=rev Log: Test: Update mingw-useld.c to reflect r253813 Modified: cfe/trunk/test/Driver/mingw-useld.c Modified: cfe/trunk/test/Driver/mingw-useld.c URL: http://llvm.or

r253874 - Revert part of r253813

Author: martell Date: Mon Nov 23 10:04:55 2015 New Revision: 253874 URL: http://llvm.org/viewvc/llvm-project?rev=253874&view=rev Log: Revert part of r253813 The new lld gnu frontend does not support the -target option Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/To

Re: r253813 - Driver: Specifically tell the linker the target for mingw-w64

ov 23, 2015 at 7:05 AM, Rafael Espíndola < rafael.espind...@gmail.com> wrote: > This changes the linker from old-gnu to gnu. Are you sure you want to > that? I don't think the new linker takes a -target option. In any > case, it needs a test. > > Cheers, > Rafael > &g

Re: r253874 - Revert part of r253813

Yes the test case was updated in r253815 to reflect the change of old-gnu to gnu On Mon, Nov 23, 2015 at 8:37 AM, Rafael Espíndola < rafael.espind...@gmail.com> wrote: > This still needs a testcase. > > On 23 November 2015 at 11:04, Martell Malone via cfe-commits > wrote: &

Re: r253815 - Test: Update mingw-useld.c to reflect r253813

he patches in this series) look odd. > > The new "gnu" is ELF only. What exactly are you trying to do? > > Cheers, > Rafael > > > On 22 November 2015 at 00:45, Martell Malone via cfe-commits > wrote: > > Author: martell > > Date: Sat Nov 21 23:45:03 2015

r253898 - Driver: fallback to the location of clang if no sysroot,

Author: martell Date: Mon Nov 23 12:59:48 2015 New Revision: 253898 URL: http://llvm.org/viewvc/llvm-project?rev=253898&view=rev Log: Driver: fallback to the location of clang if no sysroot, hard coding /usr makes little sense for mingw-w64. If we have portable toolchains having /usr breaks that.

Re: [PATCH] D14164: Driver: fallback to parent directory of clang if no sysroot for mingw-w64 target

This revision was automatically updated to reflect the committed changes. Closed by commit rL253898: Driver: fallback to the location of clang if no sysroot, (authored by martell). Changed prior to commit: http://reviews.llvm.org/D14164?vs=39069&id=40951#toc Repository: rL LLVM http://revie

Re: [PATCH] D14164: Driver: fallback to parent directory of clang if no sysroot for mingw-w64 target

martell added a comment. I tried adding a test case but I couldn't see how to control getInstalledDir from LIT. It is a bit redundant because this was already true for windows and there was no test case for that. After trying to create one I saw why :) I missed to formatting so I updated it in

r253899 - Fix alignment of r253898

Author: martell Date: Mon Nov 23 13:05:19 2015 New Revision: 253899 URL: http://llvm.org/viewvc/llvm-project?rev=253899&view=rev Log: Fix alignment of r253898 Modified: cfe/trunk/lib/Driver/MinGWToolChain.cpp Modified: cfe/trunk/lib/Driver/MinGWToolChain.cpp URL: http://llvm.org/viewvc/llvm

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

12:02 AM, Ismail Donmez wrote: > Hi, > > On Mon, Nov 23, 2015 at 8:59 PM, Martell Malone via cfe-commits > wrote: > > Author: martell > > Date: Mon Nov 23 12:59:48 2015 > > New Revision: 253898 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=253898&

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

> > Why not hardcode /usr for Linux hosts? Portable toolchain packages exist but can't on linux if you do this. but in general I'm sure most would agree that detection is much better then hard coding. This is why Yaron approved the patch Well this is a custom clang it can be anywhere. Official on

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

> > Searching for gcc on Linux is not a good idea, you'll find the system one > not the mingw one. Searching for i686-w64-mingw32-gcc or > x86_64-w64-mingw32-gcc should work better, that is searching for: > getTriple().getArchName()) + "-w64-mingw32-gcc" Moreover, this should work on Windows as

r254117 - Driver: protect from empty -L args

Author: martell Date: Wed Nov 25 19:02:07 2015 New Revision: 254117 URL: http://llvm.org/viewvc/llvm-project?rev=254117&view=rev Log: Driver: protect from empty -L args Differential Revision: http://reviews.llvm.org/D12466 Modified: cfe/trunk/lib/Driver/ToolChain.cpp Modified: cfe/trunk/lib

Re: [PATCH] D12466: Fix empty -L Path on OSX hosts

This revision was automatically updated to reflect the committed changes. Closed by commit rL254117: Driver: protect from empty -L args (authored by martell). Changed prior to commit: http://reviews.llvm.org/D12466?vs=33510&id=41202#toc Repository: rL LLVM http://reviews.llvm.org/D12466 Fi

Re: [PATCH] D12466: Fix empty -L Path on OSX hosts

martell added a comment. > Is this testable? Seems to me the only way to add this as a test would be to add bad code to clang to purposely pass an empty LibPath argument. This is probably something we do not want to do. This is probably why Reid never asked me for one in the review. Reposito

[PATCH] D15006: Driver: Better detection of mingw-gcc

martell created this revision. martell added a reviewer: yaron.keren. martell added a subscriber: cfe-commits. As discussed after r253898 here is the better gcc detection. Note: I could add a break in the new for loop but I don't feel it is needed Thoughts? http://reviews.llvm.org/D15006 File

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

martell updated the summary for this revision. martell updated this revision to Diff 41208. martell added a comment. Removed the break that I didn't think was needed Can be re-added ?? Will added testcases http://reviews.llvm.org/D15006 Files: lib/Driver/MinGWToolChain.cpp Index: lib/Driver

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

martell added a comment. @ismail can you test this for your setup please? :) http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

martell updated this revision to Diff 41209. martell added a comment. Updated to reflect feedback I'm not too sure what todo for testcases on this one because they already exist for the most part. I ran the test suite and they all pass. I would have to create a mingw32-gcc and {armv7|i686|x86_6

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell added a comment. I tried testing __has_builtin(_InterlockedCompareExchangeAdd) as it seem to not exist even when -fms-extensions is passed Is this a bug or it is intended ? http://reviews.llvm.org/D14180 ___ cfe-commits mailing list cfe-com

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell added a comment. @rnk you are correct. mingw-w64 has been updated accordingly http://sourceforge.net/p/mingw-w64/mingw-w64/ci/61c374ded91a7de66f42f85a9f0cf9ee20/ So where do we go from here ? Kind Regards Martell http://reviews.llvm.org/D14180 ___

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

martell added a comment. hi ismail, I will tidy up for review closer towards the weekend where i can work on out of work stuff http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

martell updated this revision to Diff 42933. martell added a comment. Sorry I was a bit slow getting around to this. Will do testcases if Yaron thinks this is okay http://reviews.llvm.org/D15006 Files: lib/Driver/MinGWToolChain.cpp lib/Driver/ToolChains.h Index: lib/Driver/ToolChains.h ==