[clang] [SCCP] [Transform] Adding ICMP folding for zext and sext in SCCPSolver (PR #67594)

https://github.com/mariannems edited https://github.com/llvm/llvm-project/pull/67594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SCCP] [Transform] Adding ICMP folding for zext and sext in SCCPSolver (PR #67594)

https://github.com/mariannems commented: Thanks for fixing that regression! https://github.com/llvm/llvm-project/pull/67594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SCCP] [Transform] Adding ICMP folding for zext and sext in SCCPSolver (PR #67594)

@@ -193,6 +193,60 @@ static bool replaceSignedInst(SCCPSolver &Solver, NewInst = BinaryOperator::Create(NewOpcode, Op0, Op1, "", &Inst); break; } + case Instruction::ICmp: { +ICmpInst &ICmp = cast(Inst); + +ZExtInst *Op0_zext = dyn_cast(ICmp.getOperand(0));

[clang] [SCCP] [Transform] Adding ICMP folding for zext and sext in SCCPSolver (PR #67594)

@@ -193,6 +193,66 @@ static bool replaceSignedInst(SCCPSolver &Solver, NewInst = BinaryOperator::Create(NewOpcode, Op0, Op1, "", &Inst); break; } + case Instruction::ICmp: { +ICmpInst &ICmp = cast(Inst); + +ZExtInst *Op0_zext = dyn_cast(ICmp.getOperand(0)); +

[clang] [SCCP] [Transform] Adding ICMP folding for zext and sext in SCCPSolver (PR #67594)

@@ -0,0 +1,185 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --tool ./bin/opt --version 3 +; See PRXXX for more details mariannems wrote: `See PRXXX` Was that autogenerated ? Does it need to be updated ? https://github.

[PATCH] D19827: Do not disable completely loop unroll according to optimization level.

mamai created this revision. mamai added a reviewer: chandlerc. mamai added a subscriber: cfe-commits. mamai set the repository for this revision to rL LLVM. By disabling completely the loop unroll at some optimization levels (e.g. /Os), the #pragma unroll have no effect at those optimization lev

Re: [PATCH] D19827: Do not disable completely loop unroll according to optimization level.

mamai added a subscriber: tyler.nowicki. mamai added a comment. I think the blog comment is right. The pragma should make the loop unroll even in /Os. I think it is essential to allow the user to optimize some specific loops even if he generally wants to optimize for size the rest of the code. I

Re: [PATCH] D19827: Do not disable completely loop unroll when optimizing for size.

mamai retitled this revision from "Do not disable completely loop unroll according to optimization level." to "Do not disable completely loop unroll when optimizing for size.". mamai updated the summary for this revision. mamai updated this revision to Diff 56133. mamai added a comment. Modified

r268509 - Do not disable completely loop unroll when optimizing for size.

Author: mamai Date: Wed May 4 10:26:28 2016 New Revision: 268509 URL: http://llvm.org/viewvc/llvm-project?rev=268509&view=rev Log: Do not disable completely loop unroll when optimizing for size. Let the loop unroll pass handle /Os. It already checks that option and adjust its thresholds accordi

Re: [PATCH] D19827: Do not disable completely loop unroll when optimizing for size.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268509: Do not disable completely loop unroll when optimizing for size. (authored by mamai). Changed prior to commit: http://reviews.llvm.org/D19827?vs=56133&id=56158#toc Repository: rL LLVM http://

[PATCH] D19925: Fixed test not to depend on loop unrolling pass

mamai created this revision. mamai added a reviewer: compnerd. mamai added a subscriber: cfe-commits. mamai set the repository for this revision to rL LLVM. This test have been broken by http://reviews.llvm.org/D19827, which re-enables loop unrolling at /Os. Since the goal of this test does not s

Re: [PATCH] D19925: Fixed test not to depend on loop unrolling pass

mamai abandoned this revision. mamai added a comment. The test have been fixed otherwise in rev 268523. Repository: rL LLVM http://reviews.llvm.org/D19925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

r266320 - clang-format: Implemented tab usage for continuation and indentation

Author: mamai Date: Thu Apr 14 09:52:26 2016 New Revision: 266320 URL: http://llvm.org/viewvc/llvm-project?rev=266320&view=rev Log: clang-format: Implemented tab usage for continuation and indentation Use tabs to fill whitespace at the start of a line. Patch by Maxime Beaulieu Differential Revi

r266319 - clang-format: Allow include of clangFormat.h in managed context

Author: mamai Date: Thu Apr 14 09:47:37 2016 New Revision: 266319 URL: http://llvm.org/viewvc/llvm-project?rev=266319&view=rev Log: clang-format: Allow include of clangFormat.h in managed context Including VirtualFileSystem.h in the clangFormat.h indirectly includes . This header is blocked when

Re: [PATCH] D19064: clang-format: Allow include of clangFormat.h in managed context

This revision was automatically updated to reflect the committed changes. Closed by commit rL266319: clang-format: Allow include of clangFormat.h in managed context (authored by mamai). Changed prior to commit: http://reviews.llvm.org/D19064?vs=53608&id=53717#toc Repository: rL LLVM http://

Re: [PATCH] D19065: clang-format: Last line in incomplete block is indented incorrectly

This revision was automatically updated to reflect the committed changes. Closed by commit rL266321: clang-format: Last line in incomplete block is indented incorrectly (authored by mamai). Changed prior to commit: http://reviews.llvm.org/D19065?vs=53582&id=53723#toc Repository: rL LLVM htt

r266321 - clang-format: Last line in incomplete block is indented incorrectly

Author: mamai Date: Thu Apr 14 09:56:49 2016 New Revision: 266321 URL: http://llvm.org/viewvc/llvm-project?rev=266321&view=rev Log: clang-format: Last line in incomplete block is indented incorrectly Indentation of the last line was reset to the initial indentation of the block when reaching EOF

Re: [PATCH] D19028: clang-format: Implemented tab usage for continuation and indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rL266320: clang-format: Implemented tab usage for continuation and indentation (authored by mamai). Changed prior to commit: http://reviews.llvm.org/D19028?vs=53444&id=53721#toc Repository: rL LLVM ht

Re: [PATCH] D18412: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker.

mamai added a subscriber: mamai. mamai added a comment. nit: in summary, consiring -> considering ? Comment at: test/clang-tidy/readability-redundant-string-cstr.cpp:54 @@ +53,3 @@ + // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: redundant call to `c_str()` [readability-redundant