[PATCH] D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else".

curdeius updated this revision to Diff 342338. curdeius added a comment. - Fix format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100727/new/ https://reviews.llvm.org/D100727 Files: clang/include/clang/Format/Format.h clang/lib/Format/Forma

[PATCH] D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else".

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d93d7ffedeb: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to… (authored by curdeius). Changed prior to commit: https://reviews.llvm.org/D100727?vs=342338&id=342417#toc Re

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

curdeius added a comment. Is it testable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://reviews.llvm.org/D101628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Looks very good already. Just some questions and test requests. Requesting changes so it shows up nicely in the revision queue. Comment at: clang/lib/Format/To

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. That's great. Thanks for working on this and for the cleanup. Comment at: clang/lib/Format/FormatTokenLexer.cpp:102 + +// FIXME: Investigate what token type giv

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

curdeius accepted this revision. curdeius added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://reviews.llvm.org/D101628 ___ cfe-commits mailing list cfe-commit

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius added a comment. In D101702#2736886 , @exv wrote: > According to the wiki, it seems like someone who has commit access must now > submit this change. Yes, I'll land it. Please provide "Name " for commit attribution if it differs from the info

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius added a comment. Preferably a new one unless it's something really minor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ cfe-commits mailing list

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius added a comment. Could you please rebase to re-run the CI (that failed for sum unrelated reason)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ c

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

curdeius added a comment. You can add a parent revision so that this patch will be applied upon its parent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101860/new/ https://reviews.llvm.org/D101860 ___

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM pending CI. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2531 + parseRecord(); + // This does not apply for Java, JavaScript and C#. + if (Style.Language

[PATCH] D101862: [clang-format] Rename common types between C#/JS

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM pending CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101862/new/ https://reviews.llvm.org/D101862 ___

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. I like the idea, but we need more tests. Comment at: clang/include/clang/Format/Format.h:93 + /// if ``true``, when using static initialization for an array

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

curdeius added inline comments. Comment at: clang/tools/clang-format/git-clang-format:345 + for filename in list(dictionary.keys()): +print(os.getcwd()) +if os.path.islink(filename): Is this print supposed to stay or is it a remnant of print-debugging?

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM but let's wait a day or two before landing, so that others can chime in. Btw, do you have commit rights? If no, please provide "Name " for commit attribution. Comme

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

curdeius added a comment. Oh, I forgot, please add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

This revision was automatically updated to reflect the committed changes. Closed by commit rGa437befa8f85: [clang-format] Add more support for C# 8 nullables (authored by exv, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1017

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

This revision was automatically updated to reflect the committed changes. Closed by commit rGec725b307f3f: [clang-format] Fix C# nullable-related errors (authored by exv, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101860/ne

[PATCH] D101862: [clang-format] Rename common types between C#/JS

This revision was automatically updated to reflect the committed changes. Closed by commit rGcdf33962d976: [clang-format] Rename common types between C#/JS (authored by exv, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101862

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

curdeius added inline comments. Comment at: clang/docs/ReleaseNotes.rst:247-248 +- Option ``AlignArrayOfStructure`` has been added to allow for ordering array-like + initializers into nice orderly columns while respecting column limits. +

[PATCH] D116494: [clang-format] spacesRequiredBetween is not honouring clang-format off/on

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116494/new/ https://reviews.llvm.org/D116494 ___ cfe-commits mailing list cfe-comm

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/52914. Repository: rG LLVM

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

curdeius added a comment. I know I changed existing tests. I'm not sure what we really want here. If you have ideas, I'm open to suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116527/new/ https://reviews.llvm.org/D116527 __

[PATCH] D116371: [clang-format] Support inheriting from more than 1 parents in the fallback case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0090cd4e7a24: [clang-format] Support inheriting from more than 1 parents in the fallback case (authored by zwliew, committed by curdeius). Repositor

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3760 + true: false: + void operator++ (int a);vs.void operator++(int a); + Please add operator call as well to the example

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

curdeius added a comment. @GPery, do you need help landing this? If so, please indicate the name and email you'd like to be used for the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___

[PATCH] D116189: [clang-format][NFC] Correct comment about checking merging of blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG694e6bcd525f: [clang-format][NFC] Correct comment about checking merging of blocks (authored by yodaldevoid, committed by curdeius). Changed prior t

[PATCH] D106349: [clang-format] respect AfterEnum for enums

curdeius accepted this revision. curdeius added a comment. LGTM. If nobody objects, I'll land this today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/ https://reviews.llvm.org/D106349 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D116314: [clang-format] Add style to separate definition blocks

curdeius accepted this revision. curdeius added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D106349: [clang-format] respect AfterEnum for enums

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7972b2e42276: [clang-format] respect AfterEnum for enums (authored by m1cha, committed by curdeius). Changed prior to commit: https://reviews.llvm

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

curdeius accepted this revision. curdeius added a comment. LGTM. If you need help landing this (if you don't have commit rights), just give your name and email that you want to be used for the contribution and someone will land it for you. See also https://llvm.org/docs/DeveloperPolicy.html#obt

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfe3180742ad: [clang-format] Add penalty for breaking after '(' (authored by G. Pery , committed by curdeius). Repository: rG LLVM Gi

[PATCH] D116553: [clang-format] Fix incorrect formatting of lambdas inside brace initialisation when the return type has square brackets `[]`.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/52943. Before: namespace n

[PATCH] D116553: [clang-format] Fix incorrect formatting of lambdas inside brace initialisation when the return type has square brackets `[]`.

curdeius updated this revision to Diff 397123. curdeius added a comment. This patch fixes as well https://github.com/llvm/llvm-project/issues/27146. Added a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116553/new/ https://reviews.llvm.o

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

curdeius added a comment. In D116527#3217211 , @MyDeveloperDay wrote: > The fix looks ok, butr I don't understand the cause of the side effect? is it > explicitly aligning to the v of `auto v`? It's adding two spaces inside the `auto v = ...`, becaus

[PATCH] D116558: [clang-format][NFC] Don't pass member by argument

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116558/new/ https://reviews.llvm.org/D116558 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D116559: [clang-format][NFC] Early return in TokenAnnotator::next

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116559/new/ https://reviews.llvm.org/D116559 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D116560: [clang-format][NFC] TokenAnnotator: Use range based for

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116560/new/ https://reviews.llvm.org/D116560 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D116561: [clang-format][NFC] Use Prev instead of Current->Previous

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116561/new/ https://reviews.llvm.org/D116561 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D116562: [clang-format][NFC] Right.Previous is Left

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116562/new/ https://reviews.llvm.org/D116562 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

curdeius accepted this revision. curdeius added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116557/new/ https://reviews.llvm.org/D116557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D116563: [clang-format][NFC] Put all state change into the for statement

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116563/new/ https://reviews.llvm.org/D116563 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D116553: [clang-format] Fix incorrect formatting of lambdas inside brace initialisation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2b6e21f19da: [clang-format] Fix incorrect formatting of lambdas inside brace initialisation (authored by curdeius). Repository: rG LLVM Github Mo

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

curdeius added a comment. @HazardyKnusperkeks, it *seems* as if this commit (or one of others indicated on Changes tab of the link below) provoked failures in ASan. But it could be something else. https://lab.llvm.org/buildbot/#/builders/5/builds/16734 Could you have a look? Repository: rG L

[PATCH] D116592: [clang-format] Missing space after cast in a macro

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116592/new/ https://reviews.llvm.org/D116592 __

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

curdeius updated this revision to Diff 397265. curdeius added a comment. Reverted test changes. Checking for identifier before brace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116527/new/ https://reviews.llvm.org/D116527 Files: clang/lib/For

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda6b0d0b768e: [clang-format] Add an option to add a space between operator overloading and… (authored by rajatbajpai, committed by curdeius). Chang

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Thanks for working on this! Apart from other reviewer's comments, it looks pretty much ok, but the tests are a bit messy IMO. I'd like to see something that tests 4 cases (false +

[PATCH] D116647: [clang-format] Simplify raw string regex. NFC.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduced in https://reviews.llvm.org/D115168. Repository: rG LLVM Github M

[PATCH] D116647: [clang-format] Simplify raw string regex. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46db030188e5: [clang-format] Simplify raw string regex. NFC. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5109737c924d: [clang-format] Fix indentation for array variables with alignment of… (authored by curdeius). Repository: rG LLVM Github Monorepo C

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

curdeius accepted this revision. curdeius added a comment. That's look good. And it's a nice clean up with all those repeated checks removed. Don't forget to reformat before landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115060/new/ https://reviews.llvm.org/D115060 ___

[PATCH] D116658: [clang-format][NFC] Fix typo in comment

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. You need someone to land it for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116658/new/ https://reviews.llvm.org/D116658 _

[PATCH] D116658: [clang-format][NFC] Fix typo in comment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG319971ca958a: [clang-format][NFC] Fix typo in comment (authored by pjessesco, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

curdeius added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:830 + verifyFormat("template using A = quantity, 1>;", Style); + verifyFormat("template using A = quantity /**/, 1>;", + Style); Could you test with a line

[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

curdeius added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:830 + verifyFormat("template using A = quantity, 1>;", Style); + verifyFormat("template using A = quantity /**/, 1>;", + Style); curdeius wrote: > curdeius

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

curdeius accepted this revision. curdeius added a comment. LGTM with some nits. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:435-454 +bool UnwrappedLineParser::precededByCommentOrPPDirective() const { + const size_t size = Lines.size(); + if (size > 0 && Lines[size -

[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! Thanks :). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116726/new/ https://reviews.llvm.org/D116726 ___ cfe-commits mailing li

[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

curdeius added a comment. Just a last thought, you can maybe minimize some of the test cases. It seems that even: using X = Y /**/ <>; reproduces the issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116726/new/ https://reviews.llvm.org/D116726 __

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

curdeius added inline comments. Comment at: clang/include/clang/Format/Format.h:2620 + /// + /// * If ``ColumnWidth`` is 0 (no limit on the number of columns), + /// then import statements will keep the number of lines they Please change all occurrences of `

[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

curdeius added a comment. Cool. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116726/new/ https://reviews.llvm.org/D116726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D116767: [clang-format] Fix `BraceWrapping: AfterFunction` affecting synchronized blocks in Java.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/32031. Before this change, Br

[PATCH] D116795: [clang-format] Use range-for loops. NFC.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116795 Files:

[PATCH] D116767: [clang-format] Fix `BraceWrapping: AfterFunction` affecting synchronized blocks in Java.

curdeius added a comment. Thanks for the reviews! Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1528 // for them (the one we know is missing are lambdas). -if (Style.BraceWrapping.AfterFunction) +if ((Style.Language == FormatStyle::LK_Java) && +

[PATCH] D116767: [clang-format] Fix `BraceWrapping: AfterFunction` affecting synchronized blocks in Java.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1528 // for them (the one we know is missing are lambdas). -if (Style.BraceWrapping.AfterFunction) +if ((Style.Language == FormatStyle::LK_Java) && +Line->Tok

[PATCH] D116795: [clang-format] Use range-for loops. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG01f355fe95f6: [clang-format] Use range-for loops. NFC. (authored by curdeius). Changed prior to commit: https://reviews.llvm.org/D116795?vs=398060&id=398071#toc Repository: rG LLVM Github Monorepo C

[PATCH] D116767: [clang-format] Fix `BraceWrapping: AfterFunction` affecting synchronized blocks in Java.

This revision was automatically updated to reflect the committed changes. Closed by commit rG91b9e6729c11: [clang-format] Fix `BraceWrapping: AfterFunction` affecting synchronized blocks… (authored by curdeius). Changed prior to commit: https://reviews.llvm.org/D116767?vs=397987&id=398074#toc

[PATCH] D116806: [clang-format] Ensure we can correctly parse lambda in the template argument list

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/unittests/Format/FormatTest.cpp:23171 + verifyFormat("struct Z : X {};", Style); + verifyFormat("template struct X {};", Style); +} ---

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4810-4811 + + verifyFormat("#define STRINGIFY(t) #t\n" + "#define MAKEVERSIONSTRING(x, y, z, build) STRINGIFY(x) \".\" STRINGIFY(y) \".\" STRINGIFY(z) \".\" STRINGIFY(build)\n", +

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

curdeius added a comment. @GoBigorGoHome, are you still interested in this review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94955/new/ https://reviews.llvm.org/D94955 ___ cfe-commits mailing list cf

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

curdeius added a comment. @aybassiouny, still interested in working on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99031/new/ https://reviews.llvm.org/D99031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D116920: [clang-format] clang-format eats space in front of attributes for operator delete

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1729 } else if (Current.is(tok::r_paren)) { if (rParenEndsCast(Current)) Current.setType(TT_CastRParen); The current solution looks a bit like a hack to me. Unles

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4810-4811 + + verifyFormat("#define STRINGIFY(t) #t\n" + "#define MAKEVERSIONSTRING(x, y, z, build) STRINGIFY(x) \".\" STRINGIFY(y) \".\" STRINGIFY(z) \".\" STRINGIFY(build)\n", +

[PATCH] D116920: [clang-format] clang-format eats space in front of attributes for operator delete

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:9463 + + verifyFormat("void operator delete(void *foo) ATTRIB;"); + verifyFormat("void operator new(void *foo) ATTRIB;"); Please add a test for `operator delete[]`. Repository:

[PATCH] D116920: [clang-format] clang-format eats space in front of attributes for operator delete

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Don't forget to reformat. It's a pity though that we cannot use `MightBeFunctionDecl`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116920/new/ https://reviews.llvm.org/D1

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/24784. With config: AllowS

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

curdeius added a comment. Still WIP but I'd like to have some feedback. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:283 + + // FIXME: Use IndentTracker to avoid loop? + // Find the last line with lower level. Because of thi

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:278 +// Just checking TheLine->Level != 0 is not enough, because it +// provokes treating functions inside intended namespaces as short. +if ((*I)->Level !=

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

curdeius accepted this revision. curdeius added a comment. LGTM. Thanks for working on this! But before landing, please retest the original misformatted code from the bug report with a freshly built clang-format. Also, do you have commit rights? If not, do you want someone to land it on your be

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

curdeius marked 2 inline comments as done. curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:297 + return true; +if (Style.isCpp() && RecordTok->is(tok::kw_union)) + return true; -

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM apart from nits. I agree though that spaceRequired(Before|Between) need some refactoring love. Comment at: clang/docs/ReleaseNotes.rst:327 +- Option ``SpacesInJavaSc

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTestJS.cpp:1708-1713 verifyFormat("class X {\n" " contructor(x: {\n" "a: a|null,\n" "b: b|null,\n" " }) {}\n" "}")

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

curdeius requested changes to this revision. curdeius added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/TokenAnnotator.cpp:3524-3525 return false; if (Left.is(TT_JsTypeOperator) || Right.is(TT_JsTypeOperator)) re

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTestJS.cpp:1705-1713 verifyFormat("let x: {x: number|null} = {x: number | null};"); verifyFormat("let nested: {x: {y: number|null}};"); verifyFormat("let mixed: {x: [number|null, {w: number}]};");

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

curdeius added a comment. @MyDeveloperDay, do you have any more objections? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116859/new/ https://reviews.llvm.org/D116859 ___ cfe-commits mailing list cfe-com

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

This revision was automatically updated to reflect the committed changes. Closed by commit rG47a9eb2117aa: [clang-format] Fix break being added to macro define with ColumnLimit: 0 (authored by futuarmo, committed by curdeius). Changed prior to commit: https://reviews.llvm.org/D116859?vs=399394&

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4810 + + verifyFormat("#define A LOOONG() LOOONG()\n", + ZeroColumn); futuarmo wrote: > owenpan wrote: > > Please remove the newline a

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:19610 getLLVMStyleWithColumns(35)); - verifyFormat("\"一 二 三 四 五 六 七 八 九 十\"", - getLLVMStyleWithColumns(31)); + verifyFormat("\"一 二 三 四 五 六 七 八 九 十\"", getLLVMStyleWi

[PATCH] D117289: [clang-format] Fix namespace end comments fixer with anonymous namespaces.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, a strange trailing comment was produced: namespace out { namespac

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

curdeius commandeered this revision. curdeius edited reviewers, added: aybassiouny; removed: curdeius. curdeius added a comment. This bug is not present in clang-format 13 (nor master), but was there in v12. I'll commandeer this revision to keep the regression tests. CHANGES SINCE LAST ACTION

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

curdeius updated this revision to Diff 399926. curdeius added a comment. Keep tests only. Clean up. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99031/new/ https://reviews.llvm.org/D99031 Files: clang/unittests/Format/FormatTest.cpp I

[PATCH] D117289: [clang-format] Fix namespace end comments fixer with anonymous namespaces.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG717cd16e85fa: [clang-format] Fix namespace end comments fixer with anonymous namespaces. (authored by curdeius). Repository: rG LLVM Github Monore

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

curdeius updated this revision to Diff 399945. curdeius added a comment. Minor clean up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117142/new/ https://reviews.llvm.org/D117142 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unitte

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

curdeius updated this revision to Diff 399946. curdeius added a comment. Rebase to fix Windows CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117142/new/ https://reviews.llvm.org/D117142 Files: clang/lib/Format/UnwrappedLineFormatter.cpp cl

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/docs/ClangFormatStyleOptions.rst:3398 +**RemoveBracesLLVM** (``Boolean``) :versionbadge:`clang-format 14` + Remove optional braces of control s

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

curdeius commandeered this revision. curdeius edited reviewers, added: GoBigorGoHome; removed: curdeius. curdeius added a comment. Commandeering as it's stale.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94955/new/ https://reviews.llvm.org/D9495

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

curdeius updated this revision to Diff 399982. curdeius added a comment. Add more tests. Fix missed cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94955/new/ https://reviews.llvm.org/D94955 Files: clang/lib/Format/UnwrappedLineFormatter.cp

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

curdeius updated this revision to Diff 399987. curdeius added a comment. Assert + test for loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94955/new/ https://reviews.llvm.org/D94955 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

curdeius marked 5 inline comments as done. curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:2181-2185 + EXPECT_EQ(Style.AllowShortBlocksOnASingleLine, FormatStyle::SBS_Never); + EXPECT_EQ(Style.AllowShortLoopsOnASingleLine, false); verifyForm

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

curdeius updated this revision to Diff 36. curdeius added a comment. Clean up tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94955/new/ https://reviews.llvm.org/D94955 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unittest

<    2   3   4   5   6   7   8   9   >