https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/120013
>From 9422b097ff80f5501dcf4fa3d41176b9439ab3f6 Mon Sep 17 00:00:00 2001
From: Dmitry Chestnykh
Date: Sun, 15 Dec 2024 21:18:23 +0300
Subject: [PATCH] [Libunwind] Don't XFAIL tests with msan
---
libunwind/test/
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/112978
>From 7b8f1538b452d6c16874d0f076baa2d54abb66b0 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 13 May 2022 09:26:01 -0400
Subject: [PATCH] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends
by a
@@ -150,3 +150,23 @@ clang::parseDarwinSDKInfo(llvm::vfs::FileSystem &VFS,
StringRef SDKRootPath) {
return llvm::make_error("invalid SDKSettings.json",
llvm::inconvertibleErrorCode());
}
+
+// For certain platforms/environments al
@@ -339,13 +340,11 @@ void InitHeaderSearch::AddDefaultIncludePaths(
if (triple.isOSDarwin()) {
ldionne wrote:
FWIW I agree with your assessment @cyndyishida. I just did the exercise of
picking up #75841 and we basically need to pass `-iframework` from the dr
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/112978
>From 7b8f1538b452d6c16874d0f076baa2d54abb66b0 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 13 May 2022 09:26:01 -0400
Subject: [PATCH 1/3] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY &
friends
@@ -1,13 +1,6 @@
-// RUN: %clang -cc1 -fcuda-is-device -isysroot /var/empty \
-// RUN: -triple nvptx-nvidia-cuda -aux-triple i386-apple-macosx \
-// RUN: -E -fcuda-is-device -v -o /dev/null -x cuda %s 2>&1 | FileCheck %s
-
-// RUN: %clang -cc1 -isysroot /var/empty \
-// RUN:
@@ -0,0 +1,26 @@
+// UNSUPPORTED: system-windows
+// Windows is unsupported because we use the Unix path separator `/` in the
test.
+
+// Add default directories before running clang to check default
+// search paths.
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: cp -R %S/Inputs/M
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/120149
>From e578bd75d82a5ff16168222e4f30c32f9aa5e6bd Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Mon, 16 Dec 2024 13:28:38 -0500
Subject: [PATCH 1/3] [clang][Darwin] Remove legacy framework search path logic
in
@@ -2539,6 +2550,18 @@ void DarwinClang::AddClangSystemIncludeArgs(const
llvm::opt::ArgList &DriverArgs
llvm::sys::path::append(P, "usr", "include");
addExternCSystemInclude(DriverArgs, CC1Args, P.str());
}
+
+ // Add default framework search paths
+ auto addFramew
ldionne wrote:
>
> 1. I'm not convinced the library part is true. The reality is that we support
> Clang and GCC, and if they both support the builtins (or provide different
> ones for the same feature) we remove our fallback implementations and thus
> reducing the complexity for libc++. GCC
https://github.com/ldionne commented:
I didn't have time to gather much context around this patch, sorry, I just
noticed your question on Discord.
https://github.com/llvm/llvm-project/pull/114382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -172,6 +172,7 @@ def parseScript(test, preamble):
f"{compileFlags} "
"-Wno-reserved-module-identifier
-Wno-reserved-user-defined-literal "
"-fmodule-file=std=%T/std.pcm " # The std.compat module
imports std.
+
@@ -188,6 +189,7 @@ def parseScript(test, preamble):
"%dbg(MODULE std) %{cxx} %{flags} "
f"{compileFlags} "
"-Wno-reserved-module-identifier
-Wno-reserved-user-defined-literal "
+"-fexperimental-modules-reduced-bmi "
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/114382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"],
"internal-externc-isystem">,
"implicit extern \"C\" semantics; these are assumed to not be "
"user-provided and are used to model system and standard headers' "
"paths.">;
+d
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/123098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Which identifiers exactly are causing issues? I think we could tackle that by
adding them to `__undef_macros` and to `_LIBCPP_PUSH_MACROS` and
`_LIBCPP_POP_MACROS` instead. That's generally what we do to work around name
collisions on individual platforms: it's more robust and d
ldionne wrote:
> > @erichkeane @ldionne should the `libcxx` tests
> > ([common_reference.compile.pass.cpp](https://github.com/llvm/llvm-project/blob/main/libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/common_reference.compile.pass.cpp),
> >
> > [apply_extended_types.pass.cpp](https
ldionne wrote:
Closing as stale, please feel free to reopen if you want to pursue this.
https://github.com/llvm/llvm-project/pull/105990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/105990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/123098
The documentation wasn't very clear about whether ordering is controlled within
or across TUs, and same for dylibs. Clarify that, and also add mentions for the
state of support on Mach-O platforms.
>From 05bb2
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/123098
>From 05bb2f8554e7dab1e084738155348389284bcc36 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 15 Jan 2025 13:03:04 -0500
Subject: [PATCH 1/2] [clang] Improve the documentation for the init_priority
attr
@@ -121,11 +121,12 @@ def InitPriorityDocs : Documentation {
In C++, the order in which global variables are initialized across translation
units is unspecified, unlike the ordering within a single translation unit. The
``init_priority`` attribute allows you to specify a relati
ldionne wrote:
Sure, but I am not certain why you added some newlines though.
https://github.com/llvm/llvm-project/pull/125412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,646 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/125412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
https://github.com/ldionne commented:
I would like this patch to also deprecate the old builtin. I think the
existence of the old builtin is going to cause significant confusion and risk
introducing bugs. I always imagined that the old builtin would in fact be
"fixed in place" once the Standar
https://github.com/ldionne commented:
I think this should also impact the set of headers being searched. On
per-target runtimes, I think we look for libc++ headers under
`include/c++/v1/` in addition to `include/c++/v1` (since that's where
`__config_site` ends up)? I'm not super familiar with
https://github.com/ldionne commented:
I don't have comment on the diff but I think it's great that AIX is moving
towards the mechanism that we want to use for all targets!
https://github.com/llvm/llvm-project/pull/132821
___
cfe-commits mailing list
c
https://github.com/ldionne approved this pull request.
Waiving `reviewers/libcxx` code review.
https://github.com/llvm/llvm-project/pull/132870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/ldionne approved this pull request.
I think this is great and I don't think it impacts libc++ since we moved off of
the builtin a few months ago (in preparation for these kinds of changes).
https://github.com/llvm/llvm-project/pull/138835
_
901 - 933 of 933 matches
Mail list logo