[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies created this revision. Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauhe

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies added a comment. For some reason the diff is showing the difference between 2 commits on my branch, anyone know how to fix this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 ___

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:367 // that can be valid on the real entry. - // This is what I want to do AttributeList NewAttrs = AttributeList::get(Ctx, AttributeList::FunctionIndex, ftynse wrote: >

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies updated this revision to Diff 525778. electriclilies added a comment. Squish commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 Files: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicO

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies updated this revision to Diff 525779. electriclilies added a comment. Remove whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 Files: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrins

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:130 - llvm::CallInst *inst = builder.CreateCall(fn, moduleTranslation.lookupValues(op.getOperands())); ftynse wrote: > Don't use `auto`

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98 static LogicalResult convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleT

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98 static LogicalResult convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleT

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98 static LogicalResult convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleT

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies updated this revision to Diff 525815. electriclilies added a comment. fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 Files: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td m

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98 static LogicalResult convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleT

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies updated this revision to Diff 525831. electriclilies added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 Files: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies updated this revision to Diff 526115. electriclilies added a comment. fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 Files: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies updated this revision to Diff 526117. electriclilies added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 Files: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td mli