lewmpk created this revision.
lewmpk added reviewers: alexfh, alexfh_.
Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai.
Herald added a project: clang.
Addresses the bugzilla bug #30397.
modernize-use-override suggests that destructors require the override specifier
and the CPP
lewmpk updated this revision to Diff 188622.
lewmpk marked an inline comment as done.
lewmpk added a comment.
- addressed comments
- provided tests
- updated documentation
- updated release notes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58731/new/
https://reviews.llvm.org/D58731
lewmpk marked 2 inline comments as done and an inline comment as not done.
lewmpk added inline comments.
Comment at: clang-tidy/modernize/UseOverrideCheck.h:23
+ : ClangTidyCheck(Name, Context),
+IgnoreDestructors(Options.get("IgnoreDestructors", false)) {}
void r
lewmpk updated this revision to Diff 188628.
lewmpk added a comment.
addressed comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58731/new/
https://reviews.llvm.org/D58731
Files:
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/modernize/UseOverrideCheck
lewmpk added a comment.
thanks for the feedback everyone (and the warm welcome)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58731/new/
https://reviews.llvm.org/D58731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
lewmpk added a comment.
I'm trying to find a way to run the test. If someone else has already tested it
then yes please.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58731/new/
https://reviews.llvm.org/D58731
___
cfe-commits mailing list
lewmpk updated this revision to Diff 188638.
lewmpk added a comment.
- fixed tests
- fixed typo in documentation
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58731/new/
https://reviews.llvm.org/D58731
Files:
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy
lewmpk updated this revision to Diff 188642.
lewmpk added a comment.
cleaned up documentation
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58731/new/
https://reviews.llvm.org/D58731
Files:
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/modernize/UseOverrid
lewmpk created this revision.
lewmpk added a reviewer: clang-tools-extra.
lewmpk added projects: clang, clang-tools-extra.
Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai.
Bugzilla: 40852
c++
int main()
{
const char* a = __FILE__;
const char* b = __FUNCTION__;
lewmpk added a comment.
Okk, it seems that the consensus is that `__FUNCTION__` should not be cast to
`char*`. ( I'll research a bit before I pick up a task in the future :) )
I'm happy to abandon this diff - any objections?
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
http
lewmpk added a comment.
I'm happy to land this ASAP but I don't have commit rights
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57087/new/
https://reviews.llvm.org/D57087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
lewmpk added a comment.
I'm happy to land this ASAP but I don't have commit rights
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58731/new/
https://reviews.llvm.org/D58731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
lewmpk created this revision.
lewmpk added reviewers: hokein, aaron.ballman, alexfh, JonasToth.
Herald added subscribers: cfe-commits, jdoerfert, kbarton, xazax.hun, mgorny,
nemanjai.
Herald added a project: clang.
lewmpk added a subscriber: clang-tools-extra.
Repository:
rCTE Clang Tools Extra
lewmpk updated this revision to Diff 188893.
lewmpk added a comment.
fixed ordering of cppcoreguidelines module checks
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/CM
lewmpk added a comment.
I'll improve the tests :)
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
lewmpk updated this revision to Diff 188901.
lewmpk added a comment.
removed unneccesary include
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-t
lewmpk updated this revision to Diff 188900.
lewmpk added a comment.
fixed nested use case
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cp
lewmpk updated this revision to Diff 188908.
lewmpk added a comment.
handle other basiclockable types
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
cl
lewmpk updated this revision to Diff 188910.
lewmpk added a comment.
renamed option for cppcoreguidelines-use-raii-locks
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/
lewmpk updated this revision to Diff 188911.
lewmpk added a comment.
fixed documentation
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppc
lewmpk updated this revision to Diff 188912.
lewmpk added a comment.
fixed documentation again
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tid
lewmpk updated this revision to Diff 188913.
lewmpk added a comment.
fixed documentation formatting
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clan
lewmpk marked 3 inline comments as done.
lewmpk added inline comments.
Comment at: clang-tidy/cppcoreguidelines/UseRaiiLocksCheck.cpp:26
+ recordType(hasDeclaration(cxxRecordDecl(hasName("::std::mutex"));
+ // Match expressions of type mutex or mutex pointer
+ const au
lewmpk updated this revision to Diff 188915.
lewmpk added a comment.
fixed documentation formatting
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clan
lewmpk updated this revision to Diff 188918.
lewmpk added a comment.
improved tests
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoregu
lewmpk updated this revision to Diff 188919.
lewmpk added a comment.
support try_lock_for and try_lock_until
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/CMakeLists.t
lewmpk updated this revision to Diff 188920.
lewmpk added a comment.
remove support for try_lock_for and try_lock_until
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/C
lewmpk updated this revision to Diff 189054.
lewmpk added a comment.
refactor and improved tests
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-t
lewmpk updated this revision to Diff 189055.
lewmpk added a comment.
added support for boost lockable types
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/CMakeLists.tx
lewmpk marked 7 inline comments as done.
lewmpk added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-use-raii-locks.cpp:4
+// Mock implementation of std::mutex
+namespace std {
+struct mutex {
JonasToth wrote:
> Please add more tests
>
> What hap
lewmpk updated this revision to Diff 189078.
lewmpk marked an inline comment as done.
lewmpk added a comment.
added example in docs and explicitly specified types for some variables
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://re
lewmpk marked an inline comment as done.
lewmpk added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-use-raii-locks.cpp:90
+ for (auto i = 0; i < 3; i++) {
+m.lock();
+// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: use RAII
JonasToth wrote:
lewmpk updated this revision to Diff 189157.
lewmpk added a comment.
match lock() and unlock() calls by decl
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/CMakeLists.t
33 matches
Mail list logo
