[PATCH] D118739: Revert "[ASan] Not linking asan_static library for DSO."

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7dd7ad827a0: Revert "[ASan] Not linking asan_static library for DSO." (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D120391: [Driver] Add -fno-sanitize-address-globals-dead-stripping

kstoimenov accepted this revision. kstoimenov added a comment. This revision is now accepted and ready to land. LGTM. But please wait for LTGM from vitalybuka@. Also there is internal asan-globals-live-support flag if you need it before this one lands. Repository: rG LLVM Github Monorepo CHA

[PATCH] D120394: [asan] Allow -fsanitize-address-globals-dead-stripping with -fno-data-sections for ELF

kstoimenov accepted this revision. kstoimenov added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120394/new/ https://reviews.llvm.org/D120394 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 397613. kstoimenov added a comment. Removed driver part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: compiler-rt/lib/asan/CMakeLists.txt compiler-rt

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG027ffb173a68: [ASan] Moved optimized callbacks into a separate library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D116670: [ASan] Driver changes to always link-in asan_static library.

kstoimenov created this revision. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This enables the changes from D116182 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116670

[PATCH] D116670: [ASan] Driver changes to always link-in asan_static library.

kstoimenov updated this revision to Diff 397908. kstoimenov added a comment. Lint if statement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116670/new/ https://reviews.llvm.org/D116670 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/

[PATCH] D116670: [ASan] Driver changes to always link-in asan_static library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3b9edf8b8c3: [ASan] Driver changes to always link-in asan_static library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov created this revision. Herald added a subscriber: mgorny. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This will allow linking in the callbacks directly instead of using PLT. Repository: rG

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 395914. kstoimenov added a comment. Updated a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396031. kstoimenov marked an inline comment as done. kstoimenov added a comment. Remaned dso to static. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: cl

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov added a comment. Renamed it 'dso' to 'static'. I know it could be a little bit confusing. I was considering 'static_link' or 'always_static', but it seems too long. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://revie

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab3640aa0e83: [ASan] Moved optimized callbacks into a separate library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D116223: Revert "[ASan] Moved optimized callbacks into a separate library."

kstoimenov created this revision. Herald added a subscriber: mgorny. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This reverts commit ab3640aa0e8361921a5d0cdc393a5b75e78ec22b

[PATCH] D116223: Revert "[ASan] Moved optimized callbacks into a separate library."

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4bf31659fac7: Revert "[ASan] Moved optimized callbacks into a separate library." (authored by kstoimenov). Repository: rG LLVM Github Monorepo CH

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396081. kstoimenov added a comment. Added asan_rtl_static.cpp empty file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/Comm

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396082. kstoimenov added a comment. s/set/append/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396083. kstoimenov added a comment. Fixed a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/te

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov requested review of this revision. kstoimenov added a comment. Added empty asan_static_rtl.cpp to work around the Windows build problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71b3bfde9cd2: [ASan] Moved optimized callbacks into a separate library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov created this revision. Herald added subscribers: ormris, dexonsmith, dang, hiraditya. kstoimenov requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Added and implemente

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 380829. kstoimenov added a comment. Fixed the test to pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 381365. kstoimenov added a comment. Removed the top level flag and addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/llvm/A

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov marked 4 inline comments as done. kstoimenov added inline comments. Comment at: clang/test/CodeGen/asan-stack-safety-analysis.c:1 +// REQUIRES: x86-registered-target + fmayer wrote: > fmayer wrote: > > Should this file be in llvm/test/Instrumentation/

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 381391. kstoimenov added a comment. Added support for legacy pass manager and a test for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:812 bool runOnFunction(Function &F) override { +if (ClUseStackSafety) { + report_fatal_error("Stack safety analysis is not supported " fmayer wrote:

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov added a comment. This should be good for re-review now. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 ___ cfe-commits mailing list cfe-commit

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 367872. kstoimenov added a comment. Removed test code which should be added under a different directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: l

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 367873. kstoimenov added a comment. Moved files from the parent patch which didn't belong there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: llvm/incl

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 367876. kstoimenov added a comment. Herald added a subscriber: mgorny. Moved back to using AccessInfo and fixed the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 367881. kstoimenov added a comment. This time AddressSanitizer.cpp should be updated for real. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: llvm/lib/Tr

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 367882. kstoimenov added a comment. Upload after updating AddressSanitizer.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intri

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov added a comment. All tests are passing locally. Should be good to review now. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:150 +namespace AsanAccessInfo { + vitalybuka wrote: > It's not how enums described here > htt

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368162. kstoimenov marked 4 inline comments as done. kstoimenov added a comment. Addressed the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: l

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:150 +namespace AsanAccessInfo { + vitalybuka wrote: > kstoimenov wrote: > > vitalybuka wrote: > > > It's not how enums described here > > > https://ll

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368236. kstoimenov added a comment. Fixed code generation bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intrinsics.td llvm/i

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368346. kstoimenov added a comment. Attempt to split AddressSanitizer.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: llvm/lib/Transforms/Instrumenta

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368347. kstoimenov added a comment. Attempt to split AddressSanitizer.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intrinsics

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov added a comment. Tests are still WIP. This is not ready for review yet. I will ping you when it it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368352. kstoimenov added a comment. Second attempt to split AddressSanitizer.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Int

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368367. kstoimenov marked an inline comment as done. kstoimenov added a comment. Fixed a crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/inclu

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov added inline comments. Comment at: llvm/lib/Target/X86/X86MCInstLower.cpp:1426 + OutStreamer->emitInstruction(MCInstBuilder(X86::AND32ri8) + .addReg(X86::ECX) + .addReg(X86::ECX) vita

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov planned changes to this revision. kstoimenov added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 ___ cfe-commits mailing list cf

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9588b685c6b2: [asan] Implemented intrinsic for the custom calling convention similar used by… (authored by kstoimenov). Repository: rG LLVM Github

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368432. kstoimenov added a comment. Updating after pushing D107850 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: llv

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368510. kstoimenov added a comment. Updated with the fix for Bazel build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intrinsics.

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov added a comment. Thanks! I will submit tomorrow morning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368650. kstoimenov added a comment. Updated from the revert commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intrinsics.td l

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG832aae738bec: [asan] Implemented intrinsic for the custom calling convention similar used by… (authored by kstoimenov). Repository: rG LLVM Github

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368663. kstoimenov added a comment. Upload after submitting the main patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: llvm/lib/Transforms/Instrument

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368903. kstoimenov added a comment. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368959. kstoimenov added a comment. Fixed the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: llvm/lib/Transforms/Instrumentation/AddressSanitizer.c

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3f413962627: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

<    1   2