Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added inline comments. Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13 @@ -13,2 +12,3 @@ +https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions All parameters should be named, with identical names in the declaratio

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

2016-02-26 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a subscriber: omtcyf0. omtcyf0 added a comment. @xazax.hun did you actually run the tool on the LLVM codebase? Because this check generates **tons** of false-positive reports during codebase analysis. See the minimal example below. omtcyf0-laptop:playground omtcyf0$ cat main.cp

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

2016-02-26 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. In http://reviews.llvm.org/D16535#362689, @alexfh wrote: > In http://reviews.llvm.org/D16535#362685, @omtcyf0 wrote: > > > @xazax.hun did you actually run the tool on the LLVM codebase? > > > > Because this check generates **tons** of false-positive reports during > > co

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

2016-02-26 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. Hm. Seems like this **is** either me using `run-clang-tidy.py` wrong or it working not properly, because I still get compilation errors. I believe I've done the same thing yesterday using the older tree and I didn't get any. Thus said, everything's alright if the AST is

[PATCH] D19406: [clang-tidy] Release Notes fix typo in check link

2016-04-22 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added reviewers: alexfh, LegalizeAdulthood, hokein. omtcyf0 added a subscriber: cfe-commits. This is intended to fix https://llvm.org/bugs/show_bug.cgi?id=27426 http://reviews.llvm.org/D19406 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst

Re: [PATCH] D19406: [clang-tidy] fix link in Release Notes

2016-04-22 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. @hokein Great, thanks! I'd be very grateful if you could land it! http://reviews.llvm.org/D19406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21974: [clang-include-fixer] fix PEP8 warnings

2016-07-04 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added a subscriber: cfe-commits. This fixes PEP8 E231, E225, E226, E302 warnings http://reviews.llvm.org/D21974 Files: include-fixer/tool/clang-include-fixer.py Index: include-fixer/tool/clang-include-fixer.py

Re: [PATCH] D21974: [clang-include-fixer] fix PEP8 warnings

2016-07-04 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. @bkramer I don't. Can you please land it? http://reviews.llvm.org/D21974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

2016-07-05 Thread Kirill Bobyrev via cfe-commits
omtcyf0 marked 2 inline comments as done. Comment at: docs/clang-tidy/checks/modernize-deprecated-headers.rst:45 @@ +44,3 @@ + +These checks don't have effect in C++: + At least that's what cppreference tells me. http://reviews.llvm.org/D17990 ___

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

2016-07-05 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 62701. omtcyf0 added a comment. How it looks better now. http://reviews.llvm.org/D17990 Files: clang-tidy/modernize/DeprecatedHeadersCheck.cpp docs/clang-tidy/checks/modernize-deprecated-headers.rst test/clang-tidy/modernize-deprecated-headers-cxx03.c

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

2016-07-06 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 62850. omtcyf0 marked 3 inline comments as done. http://reviews.llvm.org/D17990 Files: clang-tidy/modernize/DeprecatedHeadersCheck.cpp docs/clang-tidy/checks/modernize-deprecated-headers.rst test/clang-tidy/modernize-deprecated-headers-cxx03.cpp test/

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

2016-07-06 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. resolved small problems http://reviews.llvm.org/D17990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

2016-07-06 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. @alexfh same applies to the other headers. All of them are marked as "deprecated" there. Not sure if I should also mark and since they are in "has no effect in C++" section now, though. http://reviews.llvm.org/D17990 __

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

2016-07-06 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. http://en.cppreference.com/w/cpp/header for reference http://reviews.llvm.org/D17990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22087: [clang-rename] add basic vim integration

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63054. omtcyf0 marked 5 inline comments as done. http://reviews.llvm.org/D22087 Files: clang-rename/tool/clang-rename.py Index: clang-rename/tool/clang-rename.py === --- /dev/null +++ clang-re

[PATCH] D22087: [clang-rename] add basic vim integration

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added reviewers: alexfh, klimek. omtcyf0 added a subscriber: cfe-commits. This patch introduces basic Vim integration for clang-rename tool. For setup reference see clang-rename/tool/clang-rename.py http://reviews.llvm.org/D22087 Files: clang-rename/tool

Re: [PATCH] D22087: [clang-rename] add basic vim integration

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. Yup. FeelsBadMan. One note about that header removal: how do I do it then? I thought attaching such changes to a random patch is not a problem. Otherwise there will be some one-line patches for such things, won't they? Comment at: clang-rename/tool/Cl

Re: [PATCH] D22087: [clang-rename] add basic vim integration

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 marked an inline comment as done. omtcyf0 added a comment. http://reviews.llvm.org/D22087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22087: [clang-rename] add basic vim integration

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63058. http://reviews.llvm.org/D22087 Files: clang-rename/tool/clang-rename.py Index: clang-rename/tool/clang-rename.py === --- /dev/null +++ clang-rename/tool/clang-rename.py @@ -0,0 +1,61 @@

Re: [PATCH] D22087: [clang-rename] add basic vim integration

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63057. omtcyf0 marked 2 inline comments as done. http://reviews.llvm.org/D22087 Files: clang-rename/tool/clang-rename.py Index: clang-rename/tool/clang-rename.py === --- /dev/null +++ clang-re

Re: [PATCH] D22087: [clang-rename] add basic vim integration

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 marked an inline comment as done. Comment at: clang-rename/tool/clang-rename.py:13 @@ +12,3 @@ +map ,cr :pyf /clang-rename.py + +IMPORTANT NOTE: Before running the tool, make sure you saved the file. Aw, sure; sorry for that. That's an artifact from fi

[PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added reviewers: alexfh, klimek, bkramer, ioeric. omtcyf0 added a subscriber: cfe-commits. This patch does the following: * enforces proper formatting for few files (i.e. deals with 80 linewidth violations and few other things) * ensures '\n' chars are pass

Re: [PATCH] D22087: [clang-rename] add basic vim integration

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. @bkramer can you please land the patch? http://reviews.llvm.org/D22087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added inline comments. Comment at: clang-rename/USRLocFinder.h:38 @@ -37,2 +37,2 @@ -#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H +#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H bkramer wrote: > In LLVM we usually have

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63093. omtcyf0 marked an inline comment as done. http://reviews.llvm.org/D22091 Files: clang-rename/RenamingAction.cpp clang-rename/USRLocFinder.cpp clang-rename/USRLocFinder.h clang-rename/tool/ClangRename.cpp Index: clang-rename/tool/ClangRename.cp

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a subscriber: omtcyf0. omtcyf0 added a comment. Hi @vmiklos! Thank you very much for contributing to clang-rename. The patch looks nice, but it conflicts with my understanding of the view on what the tool should do. Generally, I do not support the idea of adding an option to perf

Re: [PATCH] D22087: [clang-rename] add basic vim integration

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. @kimgr oops, sorry. I'll send a cleanup patch. Thanks for noticing. Repository: rL LLVM http://reviews.llvm.org/D22087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D22100: [clang-rename] fix typo in Python script for Vim integration

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added reviewers: kimgr, alexfh, bkramer, hokein, ioeric. omtcyf0 added a subscriber: cfe-commits. http://reviews.llvm.org/D22100 Files: clang-rename/tool/clang-rename.py Index: clang-rename/tool/clang-rename.py

[PATCH] D22102: [clang-rename] extend testset

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added reviewers: alexfh, klimek, bkramer, ioeric. omtcyf0 added a subscriber: cfe-commits. This patch introduces few additional tests including one case the tool does not handle yet, which should be fixed in the future. http://reviews.llvm.org/D22102 Files

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. Miklos, thanks for the feedback! Hm, I'm not sure about a) and b) camps here. I think we can have both. It may be that I haven't looked too much into the code or I am missing something, but so far both integration and cross-TU analysis seem OK together in one tool as f

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. Manuel, > I think it's important to note that Miklos is probably a user, otherwise I'd > guess he wouldn't add those features. Sure. But there are different kinds of users :) IIRC there's a discussion in cfe-def called "Clang should natively support Fortran" or someth

[PATCH] D22129: [clang-rename] add documentation

2016-07-08 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added reviewers: alexfh, ioeric, bkramer, klimek, hokein. omtcyf0 added a subscriber: cfe-commits. clang-rename needs at least to have a minimum documentation to provide a small introduction for new users http://reviews.llvm.org/D22129 Files: docs/clang-

Re: [PATCH] D22100: [clang-rename] fix typo in Python script for Vim integration

2016-07-08 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. @hokein thanks! Can you please land it? I don't have commit access. http://reviews.llvm.org/D22100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22129: [clang-rename] add documentation

2016-07-08 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63202. omtcyf0 marked an inline comment as done. http://reviews.llvm.org/D22129 Files: docs/clang-rename.rst docs/index.rst Index: docs/index.rst === --- docs/index.rst +++ docs/index.rst @@

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

2016-07-10 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63418. http://reviews.llvm.org/D22091 Files: clang-rename/RenamingAction.cpp clang-rename/USRLocFinder.cpp clang-rename/USRLocFinder.h clang-rename/tool/ClangRename.cpp Index: clang-rename/tool/ClangRename.cpp

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

2016-07-10 Thread Kirill Bobyrev via cfe-commits
omtcyf0 marked an inline comment as done. Comment at: clang-rename/USRLocFinder.cpp:73-75 @@ -73,3 +72,5 @@ SourceLocation Location = Initializer->getSourceLocation(); - StringRef TokenName = Lexer::getSourceText(CharSourceRange::getTokenRange(Location), Cont

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

2016-07-11 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63463. omtcyf0 added a comment. Add new test, which ensures clang-rename failure if new name is not passed. http://reviews.llvm.org/D22091 Files: clang-rename/RenamingAction.cpp clang-rename/USRLocFinder.cpp clang-rename/USRLocFinder.h clang-rename/

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-11 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63470. omtcyf0 added a comment. add XFAIL test with virtual function renaming http://reviews.llvm.org/D22102 Files: test/clang-rename/FunctionMacro.cpp test/clang-rename/Namespace.cpp test/clang-rename/TemplateTypename.cpp test/clang-rename/Variable

Re: [PATCH] D22129: [clang-rename] add documentation

2016-07-12 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63646. omtcyf0 marked 6 inline comments as done. omtcyf0 added a comment. Fixed. Thanks for the feedback! http://reviews.llvm.org/D22129 Files: docs/clang-rename.rst Index: docs/clang-rename.rst ==

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-12 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63647. http://reviews.llvm.org/D22102 Files: test/clang-rename/FunctionMacro.cpp test/clang-rename/Namespace.cpp test/clang-rename/TemplateTypename.cpp test/clang-rename/VariableMacro.cpp test/clang-rename/VirtualFunction.cpp Index: test/clang-rena

Re: [PATCH] D22129: [clang-rename] add documentation

2016-07-13 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. Any other objections? http://reviews.llvm.org/D22129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

2016-07-13 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. Does it look good now? http://reviews.llvm.org/D22091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

2016-07-14 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63931. http://reviews.llvm.org/D22091 Files: clang-rename/RenamingAction.cpp clang-rename/USRLocFinder.cpp clang-rename/USRLocFinder.h clang-rename/tool/ClangRename.cpp test/clang-rename/NoNewName.cpp Index: test/clang-rename/NoNewName.cpp

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

2016-07-14 Thread Kirill Bobyrev via cfe-commits
omtcyf0 marked an inline comment as done. omtcyf0 added a comment. Thanks, @alexfh! Can you please land it? http://reviews.llvm.org/D22091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-14 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63934. http://reviews.llvm.org/D22102 Files: test/clang-rename/FunctionMacro.cpp test/clang-rename/Namespace.cpp test/clang-rename/TemplateTypename.cpp test/clang-rename/UserDefinedConversion.cpp test/clang-rename/VariableMacro.cpp test/clang-rena

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-14 Thread Kirill Bobyrev via cfe-commits
omtcyf0 marked an inline comment as done. omtcyf0 added a comment. Oops, sorry. Fixed it. +1 currently unsupported test. http://reviews.llvm.org/D22102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-14 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. Thanks, Manuel! Can you please land it? http://reviews.llvm.org/D22102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-14 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63939. http://reviews.llvm.org/D22102 Files: test/clang-rename/FunctionMacro.cpp test/clang-rename/Namespace.cpp test/clang-rename/TemplateTypename.cpp test/clang-rename/UserDefinedConversion.cpp test/clang-rename/VariableMacro.cpp Index: test/clan

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-14 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. @vmiklos sure thing. Thanks for noticing! http://reviews.llvm.org/D22102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22237: clang-rename: fix renaming member functions

2016-07-14 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a subscriber: omtcyf0. omtcyf0 added a comment. This one doesn't fix it though. It only deals with declarations of overridden functions. This is the test that still fails: / RUN: cat %s > %t.cpp // RUN: clang-rename -offset=161 -new-name=boo %t.cpp -i -- // RUN: sed 's,//.*,

[clang-tools-extra] r275545 - [clang-rename] add few tests

2016-07-15 Thread Kirill Bobyrev via cfe-commits
Author: omtcyfz Date: Fri Jul 15 05:21:33 2016 New Revision: 275545 URL: http://llvm.org/viewvc/llvm-project?rev=275545&view=rev Log: [clang-rename] add few tests Thiis patch introduces few additional tests including one case the tool does not handle yet, which should be fixed in the future. Di

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-15 Thread Kirill Bobyrev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL275545: [clang-rename] add few tests (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D22102?vs=63939&id=64119#toc Repository: rL LLVM https://reviews.llvm.org/D22102 Files:

[clang-tools-extra] r275550 - [clang-rename] apply stylistic fixes

2016-07-15 Thread Kirill Bobyrev via cfe-commits
Author: omtcyfz Date: Fri Jul 15 06:29:16 2016 New Revision: 275550 URL: http://llvm.org/viewvc/llvm-project?rev=275550&view=rev Log: [clang-rename] apply stylistic fixes Modified: clang-tools-extra/trunk/clang-rename/USRFinder.cpp clang-tools-extra/trunk/clang-rename/USRFindingAction.h

[clang-tools-extra] r275556 - [clang-rename] fix testset

2016-07-15 Thread Kirill Bobyrev via cfe-commits
Author: omtcyfz Date: Fri Jul 15 07:22:38 2016 New Revision: 275556 URL: http://llvm.org/viewvc/llvm-project?rev=275556&view=rev Log: [clang-rename] fix testset Make yet unsupported tests marked with FIXME pass so that buildbot doesn't fail. Added: clang-tools-extra/trunk/test/clang-rename/C

[PATCH] D22408: [clang-rename] add support for overridden functions

2016-07-15 Thread Kirill Bobyrev via cfe-commits
omtcyfz created this revision. omtcyfz added reviewers: bkramer, alexfh, klimek. omtcyfz added a subscriber: cfe-commits. add implementation and tests for virtual function renaming https://reviews.llvm.org/D22408 Files: clang-rename/USRFindingAction.cpp test/clang-rename/VirtualFunctionFindI

Re: [PATCH] D22237: clang-rename: fix renaming member functions

2016-07-15 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. Hi! Sorry for a late response. The issue is that you only deal with the consequences of this "bug". Overridden functions simply have different USRs, so the solution is just to add relevant USRs. Trying to deal with it in `USRLocFinder.cpp` doesn't seem right; the chan

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

2016-07-16 Thread Kirill Bobyrev via cfe-commits
omtcyfz added a subscriber: omtcyfz. omtcyfz added a comment. - Can you please update diff? I changed most of the tests recently. - I think you should update `doc/clang-rename` in this patch (making it a subsequent patch isn't worthy IMO) - Updating `clang-rename/tool/clang-rename.py` (simply add

[clang-tools-extra] r275681 - [clang-rename] remove obsolete tests and apply fixes to existing

2016-07-16 Thread Kirill Bobyrev via cfe-commits
Author: omtcyfz Date: Sat Jul 16 03:55:01 2016 New Revision: 275681 URL: http://llvm.org/viewvc/llvm-project?rev=275681&view=rev Log: [clang-rename] remove obsolete tests and apply fixes to existing Few tests introduced by previous patch had obsolete counterparts. Applied fixes to {Dynamic|Stati

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

2016-07-16 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 64228. omtcyfz marked an inline comment as done. https://reviews.llvm.org/D22408 Files: clang-rename/USRFindingAction.cpp test/clang-rename/VirtualFunctionFindInBaseClass.cpp test/clang-rename/VirtualFunctionFindInDerivedClass.cpp Index: test/clang-ren

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

2016-07-16 Thread Kirill Bobyrev via cfe-commits
omtcyfz added inline comments. Comment at: clang-rename/USRFindingAction.cpp:62 @@ +61,3 @@ + bool Found = false; + for (auto &OverriddenMethod : D->overridden_methods()) { +if (std::find(USRs->begin(), USRs->end(), Prazek wrote: > const auto &Ov

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

2016-07-16 Thread Kirill Bobyrev via cfe-commits
omtcyfz added a comment. In https://reviews.llvm.org/D21814#486269, @vmiklos wrote: > In https://reviews.llvm.org/D21814#486204, @omtcyfz wrote: > > > - Can you please update diff? I changed most of the tests recently. > > > Sure, I actually wanted to ask if those test additions were meant to be

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

2016-07-18 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 64285. omtcyfz marked an inline comment as done. omtcyfz added a comment. replaced RecursiveASTVisitor with ASTMatcher https://reviews.llvm.org/D22408 Files: clang-rename/USRFindingAction.cpp test/clang-rename/VirtualFunctionFindInBaseClass.cpp test/c

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

2016-07-18 Thread Kirill Bobyrev via cfe-commits
omtcyfz marked an inline comment as done. Comment at: clang-rename/USRFindingAction.cpp:48 @@ +47,3 @@ +// +// FIXME: It's better to match ctors/dtors via typeLoc's instead of adding +// their USRs to the storage, because we can also match CXXConversionDecl's by T

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

2016-07-18 Thread Kirill Bobyrev via cfe-commits
omtcyfz marked an inline comment as done. omtcyfz added a comment. https://reviews.llvm.org/D22408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

2016-07-18 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 64293. omtcyfz marked 3 inline comments as done. omtcyfz added a comment. Addressed Manuel's comments. https://reviews.llvm.org/D22408 Files: clang-rename/USRFindingAction.cpp test/clang-rename/VirtualFunctionFindInBaseClass.cpp test/clang-rename/Virt

[PATCH] D22465: [clang-rename] introduce better symbol finding and add few more tests

2016-07-18 Thread Kirill Bobyrev via cfe-commits
omtcyfz created this revision. omtcyfz added reviewers: klimek, bkramer, alexfh. omtcyfz added a subscriber: cfe-commits. https://reviews.llvm.org/D22465 Files: clang-rename/RenamingAction.cpp clang-rename/USRFinder.cpp clang-rename/USRLocFinder.cpp test/clang-rename/ClassNameInFunctionDe

Re: [PATCH] D22465: [clang-rename] introduce better symbol finding and add few more tests

2016-07-18 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 64327. omtcyfz added a comment. add XFAIL to currently unsupported test https://reviews.llvm.org/D22465 Files: clang-rename/RenamingAction.cpp clang-rename/USRFinder.cpp clang-rename/USRLocFinder.cpp test/clang-rename/ClassNameInFunctionDefenition.c

[PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

2016-03-09 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added reviewers: alexfh, rsmith, LegalizeAdulthood. omtcyf0 added a subscriber: cfe-commits. This patch introduces a minor list of changes as proposed by Richard Smith in the mailing list. See original comments with an impact on the future check state below

Re: [clang-tools-extra] r261738 - [clang-tidy] introduce modernize-deprecated-headers check

2016-03-09 Thread Kirill Bobyrev via cfe-commits
Hi! Sorry for a late response: I was away for a while. Alexander, thank you for the message forwarding, I wasn’t subscribed to cfe-commits, I guess I should do it now not to miss the comments on some of my patches! Richard, thank you for the valuable feedback! I’ve created a patch, which chan

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

2016-03-11 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. @alexfh, why? I've deleted these headers both from sources and from testset, didn't I? http://reviews.llvm.org/D17990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D15685: [clang-tidy] introducing cppcoreguidelines-enum-all-caps check

2015-12-29 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. @alexfh, Thanks for the feedback! What you said seems reasonable to me, I'll follow your advice and come up with the proposed solution! http://reviews.llvm.org/D15685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D16270: [clang-tidy] Python scripts shebang fixes

2016-01-18 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added reviewers: klimek, alexfh. omtcyf0 added a subscriber: cfe-commits. This patch fixes shebang lines in Python script files. Most Python scripts in LLVM & Clang are using this shebang line. [[ https://mail.python.org/pipermail/tutor/2007-June/054816.htm

Re: [PATCH] D16270: [clang-tidy] Python scripts shebang fixes

2016-01-18 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. @alexfh, yes, please! That'll be very nice. http://reviews.llvm.org/D16270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15370: [scan-view] replace deprecated optparse with argparse

2015-12-09 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added a reviewer: ddunbar. omtcyf0 added a subscriber: cfe-commits. scan-view migrated from optparse deprecated Python module to its replacement (argparse) and resolved few conflicts with pep8 http://reviews.llvm.org/D15370 Files: tools/scan-view/bin/sca

Re: [PATCH] D15370: [scan-view] replace deprecated optparse with argparse

2015-12-12 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 42636. omtcyf0 added a comment. Added tool description. http://reviews.llvm.org/D15370 Files: tools/scan-view/bin/scan-view Index: tools/scan-view/bin/scan-view === --- tools/scan-view/bin/s

[PATCH] D15685: [clang-tidy] introducing cppcoreguidelines-enum-all-caps check

2015-12-21 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added reviewers: alexfh, chapuni, klimek. omtcyf0 added a subscriber: cfe-commits. This patch introduces cppcoreguidelines-enum-all-caps, which flags all ALL_CAPS enumerations. As written in C++ Core Guidelines: enumerations should not be named using ALL_C

[clang] [clang-format] New clang-format-indent-mode for Emacs (PR #78904)

2024-04-14 Thread Kirill Bobyrev via cfe-commits
kirillbobyrev wrote: I'm sorry, I haven't touched Emacs and its Clang-Format integration for 8 years, so I am not very qualified to review this. I would advise to use clangd + LSP integration instead. https://github.com/llvm/llvm-project/pull/78904 _

[clang-tools-extra] 2d9198c - [clangd] Remove redundant check for renamed symbol origin

2022-01-18 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2022-01-18T09:43:53+01:00 New Revision: 2d9198cec994b91fc13ef6cdd6983c61aaa1f726 URL: https://github.com/llvm/llvm-project/commit/2d9198cec994b91fc13ef6cdd6983c61aaa1f726 DIFF: https://github.com/llvm/llvm-project/commit/2d9198cec994b91fc13ef6cdd6983c61aaa1f726.diff

[clang] a2fe81f - [clang] NFC: Use flush() idiomatically

2022-01-26 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2022-01-26T18:24:38+01:00 New Revision: a2fe81f32c3a2772e49cbd5978db4e5812a3 URL: https://github.com/llvm/llvm-project/commit/a2fe81f32c3a2772e49cbd5978db4e5812a3 DIFF: https://github.com/llvm/llvm-project/commit/a2fe81f32c3a2772e49cbd5978db4e5812a3.diff

[clang-tools-extra] d5106c8 - [clangd] NFC: Cleanup IncludeCleaner API

2022-03-08 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2022-03-08T13:43:25+01:00 New Revision: d5106c8f973b76e49d64ac3d91236efafd771c7c URL: https://github.com/llvm/llvm-project/commit/d5106c8f973b76e49d64ac3d91236efafd771c7c DIFF: https://github.com/llvm/llvm-project/commit/d5106c8f973b76e49d64ac3d91236efafd771c7c.diff

[clang-tools-extra] 34593ae - Introduce clangd-server-monitor tool

2021-05-04 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-05-04T12:48:21+02:00 New Revision: 34593ae9982ad267639893ed4ce41242f9493056 URL: https://github.com/llvm/llvm-project/commit/34593ae9982ad267639893ed4ce41242f9493056 DIFF: https://github.com/llvm/llvm-project/commit/34593ae9982ad267639893ed4ce41242f9493056.diff

[clang-tools-extra] e623ce6 - [clangd] Split CC and refs limit and increase refs limit to 1000

2021-05-05 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-05-05T23:39:48+02:00 New Revision: e623ce6188d698422d4ead24065056d6a869e6f8 URL: https://github.com/llvm/llvm-project/commit/e623ce6188d698422d4ead24065056d6a869e6f8 DIFF: https://github.com/llvm/llvm-project/commit/e623ce6188d698422d4ead24065056d6a869e6f8.diff

[clang-tools-extra] a9bf327 - [clangd] Fix build after D115243

2022-01-13 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2022-01-13T13:44:19+01:00 New Revision: a9bf32763d3929672fe243f84e6a103c91260ef0 URL: https://github.com/llvm/llvm-project/commit/a9bf32763d3929672fe243f84e6a103c91260ef0 DIFF: https://github.com/llvm/llvm-project/commit/a9bf32763d3929672fe243f84e6a103c91260ef0.diff

[clang-tools-extra] 976a74d - [clangd] Dex Trigrams: Improve query trigram generation

2021-12-07 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-12-07T15:46:13+01:00 New Revision: 976a74d7d2dbd19670614f603caf490cca892fdc URL: https://github.com/llvm/llvm-project/commit/976a74d7d2dbd19670614f603caf490cca892fdc DIFF: https://github.com/llvm/llvm-project/commit/976a74d7d2dbd19670614f603caf490cca892fdc.diff

[clang-tools-extra] eecfc73 - [clangd] Record IWYU pragma keep in the IncludeStructure

2021-12-08 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-12-08T15:55:50+01:00 New Revision: eecfc73ae4b909dbf26bd2d85b8c6580927df9fc URL: https://github.com/llvm/llvm-project/commit/eecfc73ae4b909dbf26bd2d85b8c6580927df9fc DIFF: https://github.com/llvm/llvm-project/commit/eecfc73ae4b909dbf26bd2d85b8c6580927df9fc.diff

[clang-tools-extra] b673bc3 - [clangd] Suppress IncludeCleaner warnings for headers behind pragma keep

2021-12-08 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-12-08T18:07:40+01:00 New Revision: b673bc36eacd68c15262a222ce940f36f4be0cec URL: https://github.com/llvm/llvm-project/commit/b673bc36eacd68c15262a222ce940f36f4be0cec DIFF: https://github.com/llvm/llvm-project/commit/b673bc36eacd68c15262a222ce940f36f4be0cec.diff

[clang-tools-extra] 524fe51 - [clangd] Add basic monitoring info request for remote index server

2021-03-16 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-03-16T13:37:58+01:00 New Revision: 524fe515091d31e1c054fc521113a3bf2088d159 URL: https://github.com/llvm/llvm-project/commit/524fe515091d31e1c054fc521113a3bf2088d159 DIFF: https://github.com/llvm/llvm-project/commit/524fe515091d31e1c054fc521113a3bf2088d159.diff

[clang-tools-extra] ebfcd06 - [clangd] IncludeCleaner: Mark used headers

2021-10-05 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-05T18:08:24+02:00 New Revision: ebfcd06d422286dcdd0e9a8c57e207a46c8fb8fb URL: https://github.com/llvm/llvm-project/commit/ebfcd06d422286dcdd0e9a8c57e207a46c8fb8fb DIFF: https://github.com/llvm/llvm-project/commit/ebfcd06d422286dcdd0e9a8c57e207a46c8fb8fb.diff

[clang-tools-extra] 32ab79e - [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

2021-10-05 Thread Kirill Bobyrev via cfe-commits
Author: Matt Beardsley Date: 2021-10-05T18:09:53+02:00 New Revision: 32ab79ebc496d73cb0eb3ad3b54d32b00fc49ba1 URL: https://github.com/llvm/llvm-project/commit/32ab79ebc496d73cb0eb3ad3b54d32b00fc49ba1 DIFF: https://github.com/llvm/llvm-project/commit/32ab79ebc496d73cb0eb3ad3b54d32b00fc49ba1.diff

Re: [PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

2021-10-05 Thread Kirill Bobyrev via cfe-commits
You're welcome :) Yeah, I think there's even `arc land` that's _intended_ for this but I'm just using the patch option. And it pulls from Phabricator (name, email etc). On Tue, Oct 5, 2021 at 6:17 PM Matt Beardsley via Phabricator < revi...@reviews.llvm.org> wrote: > mattbeardsley added a comment

[clang-tools-extra] 0c14e27 - [clangd] Revert unwanted change from D108194

2021-10-05 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-05T18:44:43+02:00 New Revision: 0c14e279c7294cb354e803ba5f2557425fee7c59 URL: https://github.com/llvm/llvm-project/commit/0c14e279c7294cb354e803ba5f2557425fee7c59 DIFF: https://github.com/llvm/llvm-project/commit/0c14e279c7294cb354e803ba5f2557425fee7c59.diff

[clang-tools-extra] b1309a1 - [clangd] Revert unwanted change from D108194

2021-10-08 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-08T10:42:30+02:00 New Revision: b1309a1ed99deb3508da9d53fee2ae1f766d8432 URL: https://github.com/llvm/llvm-project/commit/b1309a1ed99deb3508da9d53fee2ae1f766d8432 DIFF: https://github.com/llvm/llvm-project/commit/b1309a1ed99deb3508da9d53fee2ae1f766d8432.diff

[clang-tools-extra] 6393c21 - [clangd] IncludeCleaner: Stop crashing when included file is not found

2021-10-08 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-08T14:51:11+02:00 New Revision: 6393c21d476de2584b3ac010aace6a9b26d5bbec URL: https://github.com/llvm/llvm-project/commit/6393c21d476de2584b3ac010aace6a9b26d5bbec DIFF: https://github.com/llvm/llvm-project/commit/6393c21d476de2584b3ac010aace6a9b26d5bbec.diff

[clang-tools-extra] 0ce3c71 - [clangd] IncludeCleaner: Handle macros coming from ScratchBuffer

2021-10-14 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-14T13:36:37+02:00 New Revision: 0ce3c7111e909faa0202358bcfd6a46e3ace58b5 URL: https://github.com/llvm/llvm-project/commit/0ce3c7111e909faa0202358bcfd6a46e3ace58b5 DIFF: https://github.com/llvm/llvm-project/commit/0ce3c7111e909faa0202358bcfd6a46e3ace58b5.diff

[clang-tools-extra] c6bf8b8 - Fix python 2-vs-3 issues in add_new_check.py and rename_check.py

2021-09-11 Thread Kirill Bobyrev via cfe-commits
Author: Matt Beardsley Date: 2021-09-11T09:52:50+02:00 New Revision: c6bf8b8592431a4e39aeb20cc185b8fae0d52e43 URL: https://github.com/llvm/llvm-project/commit/c6bf8b8592431a4e39aeb20cc185b8fae0d52e43 DIFF: https://github.com/llvm/llvm-project/commit/c6bf8b8592431a4e39aeb20cc185b8fae0d52e43.diff

[clang] [clang-tools-extra] [llvm] Remove clang-rename (PR #108988)

2024-09-17 Thread Kirill Bobyrev via cfe-commits
https://github.com/kirillbobyrev approved this pull request. I agree, clang-rename should probably be removed. I haven't touched it in years and its usability has dropped over the last few years after I re-implemented the most useful functionality in clangd. https://github.com/llvm/llvm-projec

<    2   3   4   5   6   7