hxy9243 created this revision.
hxy9243 added reviewers: sebpop, hiraditya, wmi.
hxy9243 added a subscriber: cfe-commits.
hxy9243 set the repository for this revision to rL LLVM.
This patch moves some existing functions from the memory.cpp to the memory
header file, so that they could be properly
hxy9243 updated this revision to Diff 73293.
hxy9243 added a comment.
Addresses comments from @halyavin, rename "atomic_support.h" to
"__atomic_support" to avoid collisions with application headers.
Repository:
rL LLVM
https://reviews.llvm.org/D24991
Files:
libcxx/include/__atomic_support
hxy9243 added a comment.
Thanks for pointing out. It's true that it may cause ABI breakage. It would be
nice to keep compatibility while getting the performance benefits from inlining.
I've tested the patch with google-benchmark/util_smartptr_libcxx shipped with
libcxx on x86_64 server, and att
Author: hxy9243
Date: Mon Jan 16 20:46:33 2017
New Revision: 292184
URL: http://llvm.org/viewvc/llvm-project?rev=292184&view=rev
Log:
[Test patch] Inline hot functions in libcxx shared_ptr
Moves hot functions such as atomic add into the memory header file
so that they can be inlined, which brings
hxy9243 added a comment.
Ping. @mclow.lists, @EricWF, any ideas on this patch?
Thanks very much!
https://reviews.llvm.org/D24991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hxy9243 accepted this revision.
hxy9243 added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Notice that the performance gain can only be observed when compiled with the
updated C++ header files.
https://reviews.llvm.org/D24991
_
hxy9243 added a comment.
In https://reviews.llvm.org/D24991#586248, @kubabrecka wrote:
> In https://reviews.llvm.org/D24991#586219, @sebpop wrote:
>
> > I just ran ninja check-all with and without this patch and there are no
> > regressions in compiler-rt on an x86_64-linux machine.
>
>
> The TS
