[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

KP added inline comments. Comment at: unittests/Format/FormatTest.cpp:7878 +" int const i = 1;\n" +" int **j = 2, ***k;\n" +" int &k = i;\n" djasper wrote: > This looks wrong to me. Wouldn't you want to align

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

KP added a comment. ping https://reviews.llvm.org/D27651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

KP updated this revision to Diff 83639. KP added a comment. Thanks Beren. No problem for me to rebase once https://reviews.llvm.org/D21279 is merged. I've added test cases for PAS_Middle and PAS_Left, I'm a bit surprised with some of the results (although it is not impacted by my changes). Wi

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

KP updated this revision to Diff 83676. KP added a comment. Thanks for the review! Split declarations in test cases with PAS_Middle/PAS_Left. Add tests with references and rvalue references. https://reviews.llvm.org/D27651 Files: lib/Format/WhitespaceManager.cpp unittests/Format/FormatTest.

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

KP updated this revision to Diff 83829. KP added a comment. Rename IsPointerOrReference to isPointerOrReference to comply with coding style https://reviews.llvm.org/D27651 Files: lib/Format/WhitespaceManager.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ===

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

KP added a comment. ping https://reviews.llvm.org/D27651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

KP updated this revision to Diff 95375. KP added a comment. Rebase on current trunk. Is there any chance to get this merge ? Please let me know if anything else is needed. Thanks, Ken-Patrick https://reviews.llvm.org/D27651 Files: lib/Format/WhitespaceManager.cpp unittests/Format/FormatT

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

KP added a comment. In https://reviews.llvm.org/D27651#661490, @djasper wrote: > I have given stuff in WhitespaceManager access to the actual FormatToken in > r293616. Hopefully that simplifies this patch. Thanks! I'll try to rebase and see what can be improved. https://reviews.llvm.org/D276

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

KP updated this revision to Diff 86681. KP added a comment. Rebase after r293616. Replace isPointerOrReference with a direct check on the token type. https://reviews.llvm.org/D27651 Files: lib/Format/WhitespaceManager.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

KP created this revision. KP added a reviewer: djasper. KP added a subscriber: cfe-commits. Herald added a subscriber: klimek. With AlignConsecutiveDeclarations and PointerAlignment: Right *s and &s were left dangling. For instance const char* const* v1; float const* v2; SomeVeryLongType