kadircet updated this revision to Diff 159510.
kadircet marked 6 inline comments as done.
kadircet added a comment.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50193
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Diagnostics.cpp
cl
kadircet updated this revision to Diff 159648.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Resolve some more discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50193
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Diagnostic
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE339224: Added functionality to suggest FixIts for
conversion of '->' to '.' and vice… (authored by
kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50193?vs=159648&id=1596
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric.
Repository:
rC Clang
https://reviews.llvm.org/D50443
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/Preprocessor.cpp
Index: lib/Lex/Prepro
kadircet updated this revision to Diff 159703.
kadircet marked an inline comment as done.
kadircet added a comment.
- Resolve discussions.
Repository:
rC Clang
https://reviews.llvm.org/D50443
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/Preprocessor.cpp
Index: lib/Lex/Preprocessor.c
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric.
Completion replies contains textEdits as well. Note that this change
relies on https://reviews.llvm.org/D50443.
Repository:
rCTE Clang Tools Extr
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ioeric,
mgorny.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
Files:
clangd/CMakeLists.txt
clangd/Cancellation.cpp
clang
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50555
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
uni
kadircet updated this revision to Diff 160073.
kadircet marked 5 inline comments as done.
kadircet added a comment.
Herald added a subscriber: mgrang.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50449
Files:
clangd/CodeComplete.cpp
clangd/CodeCompl
kadircet added inline comments.
Comment at: clangd/CodeComplete.cpp:1310
+ // other.
+ for (const auto &FixIt : FixIts) {
+if (IsRangeConsecutive(FixIt.range, LSP.textEdit->range)) {
ilya-biryukov wrote:
> Maybe keep the `reserve` call? (we could reserve on
kadircet updated this revision to Diff 160097.
kadircet marked 3 inline comments as done.
kadircet added a comment.
Herald added a subscriber: mgrang.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50555
Files:
clangd/CodeComplete.cpp
clangd/Quality.c
kadircet updated this revision to Diff 160299.
kadircet added a comment.
- Resolve discussions.
- Fix typo.
Repository:
rC Clang
https://reviews.llvm.org/D50443
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/Preprocessor.cpp
Index: lib/Lex/Preprocessor.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339540: [clang] Store code completion token range in
preprocessor. (authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50443
F
kadircet updated this revision to Diff 160303.
kadircet added a comment.
- Rebase.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50449
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/SourceCode.cpp
clangd/SourceCode.h
unittests/clan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339543: [clangd] Support textEdit in addition to insertText.
(authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50449
Files:
kadircet updated this revision to Diff 160306.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Rebase & Resolve discussions.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50555
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE339547: [clangd] Introduce scoring mechanism for
SignatureInformations. (authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50555?vs=160306&id=160307#toc
Reposit
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50635
Files:
test/clangd/completion-snippets.test
test/clangd/completion.test
Index: te
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339572: Fix lint tests for D50449 (authored by kadircet,
committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50635
Files:
clang-tools-extra/trunk/t
kadircet updated this revision to Diff 160531.
kadircet marked 7 inline comments as done.
kadircet added a comment.
- Polished API.
- Resolved discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
Files:
clangd/CMakeLists.txt
clangd/Cancellation.cpp
clangd/Can
kadircet updated this revision to Diff 160636.
kadircet marked 4 inline comments as done.
kadircet added a comment.
- Get rid of getCancellationError.
- Add replyError helper.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
Files:
clangd/CMakeLists.txt
clangd/Cancellat
kadircet added inline comments.
Comment at: clangd/Cancellation.cpp:17
+namespace {
+static Key>> CancellationTokenKey;
+} // namespace
ilya-biryukov wrote:
> Having a `shared_ptr` key in the Context can cause data races (e.g. if we
> copy it concurrently from m
kadircet updated this revision to Diff 160652.
kadircet marked 8 inline comments as done.
kadircet added a comment.
- Resolve discussions.
- Get rid of CancellationHandler class.
- Change error class name.
- Improve documentation.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D5
kadircet added inline comments.
Comment at: clangd/Cancellation.h:71
+
+class TaskHandle {
+public:
ilya-biryukov wrote:
> I wonder if we should make `TaskHandle` move-only?
>
> The reasoning is that is can be easily used from multiple threads (since it's
> use
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
kadircet created this revision.
kadircet added reviewers: ioeric, ilya-biryukov, hokein.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Currently we only add parantheses to the functions if snippets are
enabled, which also inserts snippets for parameters into parantheses. Addin
kadircet updated this revision to Diff 160986.
kadircet added a comment.
- Made TaskHandle move-only. Since it is costly and most likely unnecessary to
copy it other than to move it into Context.
- Provided an explicit clone method for copying.
Repository:
rCTE Clang Tools Extra
https://revi
kadircet updated this revision to Diff 161018.
kadircet marked 21 inline comments as done.
kadircet added a comment.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
Files:
clangd/CMakeLists.txt
clangd/Cancellation.cpp
clangd/Cancellation.h
cl
kadircet added inline comments.
Comment at: clangd/Cancellation.h:92
+ operator bool() const { return isCancelled(); }
+ friend CancellationToken isCancelled();
+
ilya-biryukov wrote:
> It's a bit confusing that this name clashes with a member function.
> We se
kadircet updated this revision to Diff 161023.
kadircet marked an inline comment as done.
kadircet added a comment.
- Change option name.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50835
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
unittests/clangd/CodeComplet
kadircet added inline comments.
Comment at: clangd/CodeComplete.h:85
+
+ /// Enables cursor to be moved around according to completions needs even
when
+ /// snippets are disabled. For example selecting a function with parameters
as
ioeric wrote:
> IIRC, the
kadircet created this revision.
kadircet added reviewers: ilya-biryukov, hokein, ioeric.
Herald added subscribers: cfe-commits, arphaman, jkorous.
Whenever a code-completion is triggered within a class/struct/union looks at
base classes and figures out non-overriden virtual functions. Than suggest
kadircet updated this revision to Diff 161243.
kadircet added a comment.
- Change option name.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50835
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCo
kadircet marked 3 inline comments as done.
kadircet added inline comments.
Comment at: clangd/CodeComplete.cpp:1377
+ // Check whether function has any parameters or not.
+ LSP.textEdit->newText += SnippetSuffix.size() > 2 ? "(${0})" : "()";
+else
i
kadircet updated this revision to Diff 161256.
kadircet added a comment.
- Only append to snippets of type function or method.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50835
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
unittests/clangd/CodeCompleteTests.cpp
kadircet updated this revision to Diff 161261.
kadircet marked 10 inline comments as done.
kadircet added a comment.
- Resolve discussions & Delete enclosing quotes when normalizing.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
Files:
clangd/CMakeLists.txt
clangd/Ca
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:621
+ std::lock_guard Lock(TaskHandlesMutex);
+ const auto &it = TaskHandles.find(Params.ID);
+ if (it != TaskHandles.end()) {
ilya-biryukov wrote
kadircet added inline comments.
Comment at: clangd/CodeComplete.cpp:1381
+ // Check whether function has any parameters or not.
+ LSP.textEdit->newText += SnippetSuffix.size() > 2 ? "(${0})" : "()";
+}
ioeric wrote:
> I think we are missing one case
kadircet updated this revision to Diff 161265.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50835
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
unittests/clangd/CodeComple
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340040: [clangd] Add parantheses while auto-completing
functions. (authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50835
kadircet updated this revision to Diff 161428.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Check cancellation earlier && Fix normalization difference between string and
integer request ids.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
Files:
kadircet added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:75
+std::string NormalizeRequestID(const json::Value &ID) {
+ CancelParams CP;
+ fromJSON(json::Object{{"id", ID}}, CP);
ioeric wrote:
> Use `ID.getAsString()`?
Unfortunately id can be both
kadircet added inline comments.
Comment at: unittests/clangd/CodeCompleteTests.cpp:1710
+ $bol^
+ ab$ab^
+ x.ab$dot^
Maybe an EXPECT for this one as well?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50962
__
kadircet updated this revision to Diff 161683.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Put overrides through scoring and resolve nits.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50898
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at: clangd/CodeComplete.cpp:1233
+// struct/class/union definition.
+const auto Overrides = getVirtualNonOverridenMethods(
+Recorder->CCSema->CurContext, Recorder->CCSema);
kadircet updated this revision to Diff 161716.
kadircet marked 4 inline comments as done.
kadircet added a comment.
- Get rid of CancellationToken && Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
Files:
clangd/CMakeLists.txt
clangd/Cancellation.c
kadircet created this revision.
kadircet added reviewers: ilya-biryukov, ioeric, hokein.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Currently CodeCompleteCall only gets called after a comma or parantheses. This
patch makes sure it is called even at the cases like:
foo(1^
kadircet created this revision.
kadircet added reviewers: ilya-biryukov, ioeric, hokein.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51039
Files:
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clan
kadircet added a comment.
After today's offline discussion I suppose we are not going to implement it
within Sema. And also I think getVirtualNonOverridenMethods is a pretty generic
function that has no ties to clangd, so it can be easily moved into Sema.
Should we still move it into a separate
kadircet updated this revision to Diff 161908.
kadircet marked 6 inline comments as done.
kadircet added a comment.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
Files:
clangd/CMakeLists.txt
clangd/Cancellation.cpp
clangd/Cancellation.h
cla
kadircet created this revision.
kadircet added reviewers: ilya-biryukov, ioeric, hokein.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
We were handling the EnableFunctionArgSnippets only when we are producing LSP
response. Move that code into CompletionItem generation so that
kadircet updated this revision to Diff 161963.
kadircet marked 6 inline comments as done.
kadircet added a comment.
- Resolve discussions.
- Fix a bug inside summarizeOverride.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50898
Files:
clangd/CodeComplete.cpp
clangd/CodeCo
kadircet updated this revision to Diff 161966.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Resolve discussions.
- Add tests.
- Fix a bug noticed by lit tests.
Repository:
rC Clang
https://reviews.llvm.org/D51038
Files:
include/clang/Parse/Parser.h
lib/Parse/Par
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340527: [clangd] Move function argument snippet disable
mechanism from LSP rendering to… (authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://revi
kadircet updated this revision to Diff 162151.
kadircet added a comment.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50898
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCo
kadircet updated this revision to Diff 162157.
kadircet added a comment.
- Resolve discussions.
- Move override generation logic from render to item generation so that
internal clients can use it as well, also use a boolean for checking override
status of a bundle to be more efficient.
- Change
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE340530: [clangd] Suggest code-completions for overriding
base class virtual methods. (authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50898?vs=162157&id=162158
kadircet created this revision.
kadircet added reviewers: ilya-biryukov, hokein, ioeric.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Currently we match an include only if we are inside filename, with this patch we
will match whenever we are on the starting line of the includ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340539: [clangd] Check for include overlapping looks for
only the line now. (authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/
kadircet updated this revision to Diff 162342.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Change a few comments.
- Add some assertions.
- Fix a data race.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
Files:
clangd/CMakeLists.txt
clangd/Ca
kadircet marked 2 inline comments as done.
kadircet added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:351
+ [this](llvm::Expected List) {
+auto _ = llvm::make_scope_exit([this]() { CleanupTaskHandle(); });
+
ilya-biryukov wrote:
> Cleanup
kadircet added inline comments.
Comment at: clangd/Protocol.h:883
+/// converts it into a string.
+bool parseNumberOrString(const llvm::json::Value &Params, std::string &Parsed,
+ const std::string &Field);
ilya-biryukov wrote:
> Maybe sim
kadircet updated this revision to Diff 162354.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Change helper for normalizing Number | String.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
Files:
clangd/CMakeLists.txt
clangd/Cancellation.cpp
c
kadircet updated this revision to Diff 162365.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Resolve comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
Files:
clangd/CMakeLists.txt
clangd/Cancellation.cpp
clangd/Cancellation.h
clangd
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340607: [clangd] Initial cancellation mechanism for LSP
requests. (authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50502
kadircet created this revision.
kadircet added reviewers: hokein, ioeric, ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Currently LSP clients cannot directly change IncludeFixIts or
EnableFunctionArgSnippets parameters. This patch is to provide them with a way
t
kadircet added inline comments.
Comment at: clangd/Protocol.h:889
+ // Does this node implement the method targeted by the request?
+ bool DeclaresMethod;
+
I think comment and the name is in contradiction here, do you mean
DefinesMethod?
Co
kadircet added inline comments.
Comment at: clangd/ProtocolHandlers.cpp:70
Register("textDocument/hover", &ProtocolCallbacks::onHover);
+ Register("textDocument/typeHierarchy", &ProtocolCallbacks::onTypeHierarchy);
Register("textDocument/documentSymbol",
&ProtocolCallback
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:184
+ size_t Bytes = PairedSlabSize;
+ Bytes += LookupTable.size() * sizeof(std::pair);
Bytes += SymbolQuality.size() * sizeof(std::pair);
Why not use `LookupTable.ge
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:91
+ for (const auto &P : FileToSlabs)
+Result += P.second->size();
+ return Result;
Why not `bytes` here as well?
https://reviews.llvm.org/D51539
kadircet updated this revision to Diff 163968.
kadircet added a comment.
Rebase
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51039
Files:
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCompleteTests.cpp
=
kadircet updated this revision to Diff 163970.
kadircet added a comment.
- Update tests.
- Update comment.
- Rebase.
Repository:
rC Clang
https://reviews.llvm.org/D51038
Files:
include/clang/Parse/Parser.h
lib/Parse/ParseExpr.cpp
test/CodeCompletion/function-overloads-inside-param.cpp
kadircet updated this revision to Diff 163971.
kadircet added a comment.
- Update comments.
Repository:
rC Clang
https://reviews.llvm.org/D51038
Files:
include/clang/Parse/Parser.h
lib/Parse/ParseExpr.cpp
test/CodeCompletion/function-overloads-inside-param.cpp
test/CodeCompletion/fun
kadircet added inline comments.
Comment at: clangd/index/Index.h:171
+ /// See also isIndexedForCodeCompletion().
+ IsIndexedForCodeCompletion = 1 << 0,
+ /// Indicates if the symbol is deprecated.
nit: rename to IndexedForCodeCompletion, since it is more of a
kadircet added inline comments.
Comment at: unittests/clangd/SymbolCollectorTests.cpp:1020
+ const std::string Header = R"(
+void TestClangc() __attribute__((deprecated("", "")));
+void TestClangd();
No need for the optional parameters,
```
void TestCl
kadircet created this revision.
kadircet added reviewers: ioeric, sammccall, ilya-biryukov, hokein.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Adds deprecation warnings to diagnostics. Also lowers the severity from
warning to notes to not to annoy people that work on big co
kadircet added inline comments.
Comment at: clangd/Diagnostics.cpp:299
+D.Severity =
+D.Category == "Deprecations" ? DiagnosticsEngine::Note : DiagLevel;
return D;
Couldn't find a better way to check for this one. Category types are coming
from
kadircet updated this revision to Diff 164268.
kadircet added a comment.
- Formatting.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51747
Files:
clangd/ClangdServer.cpp
clangd/Diagnostics.cpp
unittests/clangd/ClangdUnitTests.cpp
Index: unittests/clangd/ClangdUnitTests
kadircet added inline comments.
Comment at: test/Index/complete-block-property-assignment.m:71
+// RUN: c-index-test -code-completion-at=%s:54:15 %s | FileCheck
-check-prefix=CHECK-NO1 %s
+// CHECK-NO1: ObjCPropertyDecl:{ResultType int}{TypedText foo} (35)
ily
kadircet updated this revision to Diff 164307.
kadircet added a comment.
- Fix tests.
Repository:
rC Clang
https://reviews.llvm.org/D51038
Files:
include/clang/Parse/Parser.h
lib/Parse/ParseExpr.cpp
test/CodeCompletion/function-overloads-inside-param.cpp
test/CodeCompletion/function-
kadircet updated this revision to Diff 164477.
kadircet added a comment.
- Rebase and use new signature help.
Currently the problem is, there are again some tests out there that rely on
CodeCompeleteOrdinaryName to be called even when getting overloads at an unknown
parameter type. These tests ar
kadircet added a comment.
In https://reviews.llvm.org/D51747#1227089, @ilya-biryukov wrote:
> Not sure if it's fine to hijack our own diagnostic-specific flags in to clang
> command args.
>
> Cons that I see:
>
> 1. There is no way for the users to turn them off if they find them
> non-useful.
kadircet added a comment.
In https://reviews.llvm.org/D51038#1228618, @ilya-biryukov wrote:
> > Currently the problem is, there are again some tests out there that rely on
> > CodeCompeleteOrdinaryName to be called even when getting overloads at an
> > unknown
> > parameter type
>
> CodeComple
kadircet updated this revision to Diff 164639.
kadircet marked an inline comment as done.
kadircet added a comment.
- Change "inside parameter" checking and fix completion string printing for
optional parameters.
- Update tests.
Repository:
rC Clang
https://reviews.llvm.org/D51038
Files:
kadircet updated this revision to Diff 164649.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Resolve discussions.
Repository:
rC Clang
https://reviews.llvm.org/D51038
Files:
include/clang/Parse/Parser.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseExpr.cpp
lib/Pars
kadircet updated this revision to Diff 164659.
kadircet added a comment.
- Inline completers.
Repository:
rC Clang
https://reviews.llvm.org/D51038
Files:
include/clang/Parse/Parser.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseExpr.cpp
lib/Parse/ParseExprCXX.cpp
lib/Parse/ParseOpenMP.cp
kadircet updated this revision to Diff 164661.
kadircet marked an inline comment as done.
kadircet added a comment.
- One last completer
Repository:
rC Clang
https://reviews.llvm.org/D51038
Files:
include/clang/Parse/Parser.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseExpr.cpp
lib/Parse/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341824: [clang] Make sure codecompletion is called for calls
even when inside a token. (authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341830: [clangd] Add unittests for D51038 (authored by
kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51039?vs=163968&id=164668#toc
kadircet created this revision.
kadircet added reviewers: sammccall, ilya-biryukov, ioeric.
Herald added a subscriber: cfe-commits.
Factors out member decleration gathering and uses it in parsing to call
signature
help. Doesn't support signature help for base class constructors, the code was
too
kadircet added a comment.
In https://reviews.llvm.org/D51297#1228725, @ioeric wrote:
> I also support having some instructions/pointers on editor integration. That
> said, I think we should have a section "Editor integration" with a list of
> editor clients that are known to work with clangd, i
kadircet updated this revision to Diff 164830.
kadircet marked 5 inline comments as done.
kadircet added a comment.
- Change flag's name and rebase.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51214
Files:
clangd/tool/ClangdMain.cpp
Index: clangd/tool/ClangdMain.cpp
kadircet updated this revision to Diff 164844.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Move ValueDecl extraction to a helper.
- Call completion handlers as well.
Repository:
rC Clang
https://reviews.llvm.org/D51917
Files:
include/clang/Sema/Sema.h
lib/Parse
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51924
Files:
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/Code
kadircet updated this revision to Diff 164847.
kadircet marked 4 inline comments as done.
kadircet added a comment.
- Update descriptions and change parameter name.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51214
Files:
clangd/tool/ClangdMain.cpp
Index: clangd/tool/Cla
kadircet added a comment.
In https://reviews.llvm.org/D51747#1229066, @sammccall wrote:
> In https://reviews.llvm.org/D51747#1228919, @ilya-biryukov wrote:
>
> > > Most of the value of adding an option is: if someone complains, we can
> > > tell them to go away :-) One possible corollary is: we
kadircet updated this revision to Diff 164864.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Resolve discussions.
Repository:
rC Clang
https://reviews.llvm.org/D51917
Files:
include/clang/Sema/Sema.h
lib/Parse/ParseDeclCXX.cpp
lib/Sema/SemaCodeComplete.cpp
li
kadircet added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:197
+static llvm::cl::opt IncludeFixIts(
+"include-fixits",
ilya-biryukov wrote:
> sammccall wrote:
> > ilya-biryukov wrote:
> > > I wonder if we should make the `IncludeFixIts` option h
kadircet updated this revision to Diff 164866.
kadircet added a comment.
- Update tests.
Repository:
rC Clang
https://reviews.llvm.org/D51917
Files:
include/clang/Sema/Sema.h
lib/Parse/ParseDeclCXX.cpp
lib/Sema/SemaCodeComplete.cpp
lib/Sema/SemaDeclCXX.cpp
test/CodeCompletion/ctor-
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341949: [CodeCompletion] Enable signature help when
initializing class/struct/union… (authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51917?vs=164866&id=164883#t
1 - 100 of 3849 matches
Mail list logo
