juliehockett added inline comments.
Comment at: docs/clang-tidy/checks/fuchsia-overloaded-operator.rst:17
+
+See the features disallowed in Fuchsia at
https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.md
JonasToth wrote:
> Could you make the link clickab
juliehockett updated this revision to Diff 127806.
juliehockett added a comment.
Updating matcher to include overloaded operators outside classes.
https://reviews.llvm.org/D41363
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/Overloade
juliehockett updated this revision to Diff 127960.
juliehockett marked 5 inline comments as done.
juliehockett added a comment.
Fixing comments
https://reviews.llvm.org/D41363
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/OverloadedOp
juliehockett added a comment.
> Are the Fuchsia library headers intended to also comply with this rule? I
> notice there's mention of a unique_ptr class, and I can't imagine that
> working without overloading more operators than just assignment. Perhaps this
> check should not be triggered for
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321363: [clang-tidy] Adding Fuchsia checker for overloaded
operators (authored by juliehockett, committed by ).
Herald added a subscriber: klimek.
Changed prior to commit:
https://reviews.llvm.org/D4136
juliehockett created this revision.
juliehockett added reviewers: aaron.ballman, alexfh, hokein.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
Adds a check to the Fuchsia module to warn if statically-stored objects are
created, unless constructed wi
juliehockett updated this revision to Diff 128060.
juliehockett marked 3 inline comments as done.
https://reviews.llvm.org/D41546
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/StaticallyConstructedObjectsCheck.cpp
clang-tidy/fuchsia/S
juliehockett created this revision.
juliehockett added a reviewer: alexfh.
juliehockett added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.
Updating fuchsia-overloaded-operator check to not issue warnings for invalid
locations.
Fixes PR35803.
https://reviews.llvm.org/D417
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE321762: [clang-tidy] Update fuchsia-overloaded-operator to
check for valid loc (authored by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41708?vs=128548&id=128563#t
juliehockett updated this revision to Diff 128641.
juliehockett added a comment.
1. Adding in a basic test setup for the framework
2. Pulling the YAML specs out into their own file
3. Expanding the representation to consider different types of declarations
(namespace, tag, and function) and store
juliehockett updated this revision to Diff 128806.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
1. Narrowing check to only warn if the declaration is a global non-trivial
object with explicit static storage, unless the object either has a `constexpr`
constructor o
juliehockett updated this revision to Diff 129208.
juliehockett marked 5 inline comments as done.
juliehockett added a comment.
Updating matcher to catch dynamically initialized constructors and fixing
comments.
https://reviews.llvm.org/D41546
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang
juliehockett updated this revision to Diff 129498.
juliehockett marked 8 inline comments as done.
juliehockett added a comment.
1. Updating check and tests to address virtual inheritance
2. Rebasing from trunk
https://reviews.llvm.org/D40580
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-ti
juliehockett updated this revision to Diff 136096.
juliehockett marked 16 inline comments as done.
juliehockett added a comment.
Fixing comments and updating tests.
https://reviews.llvm.org/D43778
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy
juliehockett updated this revision to Diff 136161.
juliehockett marked 15 inline comments as done.
juliehockett added a comment.
Fixing comments
https://reviews.llvm.org/D41102
Files:
CMakeLists.txt
clang-doc/BitcodeWriter.cpp
clang-doc/BitcodeWriter.h
clang-doc/CMakeLists.txt
clang-d
juliehockett added a comment.
In https://reviews.llvm.org/D41102#1020808, @lebedev.ri wrote:
> Ok, great.
> And it will also complain if you try to output a block within block?
Um...no. Since you can have subblocks within blocks.
Comment at: clang-doc/BitcodeWriter.cpp:191
juliehockett added inline comments.
Comment at: clang-doc/BitcodeWriter.h:37
+ static constexpr unsigned SubblockIDSize = 4U;
+ static constexpr unsigned BoolSize = 1U;
+ static constexpr unsigned IntSize = 16U;
lebedev.ri wrote:
> Hmm, you build with asserts
juliehockett updated this revision to Diff 136303.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
Running clang-format and fixing newlines
https://reviews.llvm.org/D41102
Files:
CMakeLists.txt
clang-doc/BitcodeWriter.cpp
clang-doc/BitcodeWriter.h
clang-doc/
juliehockett updated this revision to Diff 136520.
juliehockett marked 14 inline comments as done.
juliehockett added a comment.
Fixing comments and adding tests
https://reviews.llvm.org/D41102
Files:
CMakeLists.txt
clang-doc/BitcodeWriter.cpp
clang-doc/BitcodeWriter.h
clang-doc/CMakeLi
juliehockett updated this revision to Diff 136650.
juliehockett marked 16 inline comments as done.
juliehockett added a comment.
Adding tests, fixing comments, and removing an (as-of-yet) unused element of
the CommentInfo struct.
https://reviews.llvm.org/D41102
Files:
CMakeLists.txt
clang-
juliehockett added inline comments.
Comment at: clang-doc/BitcodeWriter.cpp:196
+/// \brief Emits a record name to the BLOCKINFO block.
+void ClangDocBitcodeWriter::emitRecordID(RecordId ID) {
+ assert(RecordIdNameMap[ID] && "Unknown Abbreviation");
lebedev.ri w
juliehockett updated this revision to Diff 136660.
juliehockett marked an inline comment as done.
juliehockett added a comment.
Cleaning up some and updating based on changes to the parent diff.
https://reviews.llvm.org/D43341
Files:
clang-doc/BitcodeReader.cpp
clang-doc/BitcodeReader.h
c
juliehockett updated this revision to Diff 136791.
juliehockett marked 11 inline comments as done.
juliehockett added a comment.
Addressing comments
https://reviews.llvm.org/D41102
Files:
CMakeLists.txt
clang-doc/BitcodeWriter.cpp
clang-doc/BitcodeWriter.h
clang-doc/CMakeLists.txt
cla
juliehockett updated this revision to Diff 136793.
juliehockett added a comment.
Updating for parent diff & refactoring reader.
https://reviews.llvm.org/D43341
Files:
clang-doc/BitcodeReader.cpp
clang-doc/BitcodeReader.h
clang-doc/BitcodeWriter.cpp
clang-doc/BitcodeWriter.h
clang-doc/
juliehockett updated this revision to Diff 136809.
juliehockett marked an inline comment as done.
juliehockett added a comment.
Removing IsDefinition field.
https://reviews.llvm.org/D41102
Files:
CMakeLists.txt
clang-doc/BitcodeWriter.cpp
clang-doc/BitcodeWriter.h
clang-doc/CMakeLists.t
juliehockett added inline comments.
Comment at: clang-doc/Representation.h:117
+ bool IsDefinition = false;
+ llvm::Optional DefLoc;
+ llvm::SmallVector Loc;
lebedev.ri wrote:
> I meant that `IsDefinition` controls whether `DefLoc` will be set/used or not.
> S
juliehockett added a comment.
In https://reviews.llvm.org/D41102#1028228, @Athosvk wrote:
> This seems like quite a decent approach! That being said, I don't see the
> pointer yet? I assume you mean that you will be adding this? Additionally, a
> slight disadvantage of doing this generic approa
juliehockett updated this revision to Diff 137244.
juliehockett added a comment.
Adding hashing to reduce the size of USRs and updating tests.
https://reviews.llvm.org/D41102
Files:
CMakeLists.txt
clang-doc/BitcodeWriter.cpp
clang-doc/BitcodeWriter.h
clang-doc/CMakeLists.txt
clang-doc
juliehockett updated this revision to Diff 137245.
juliehockett marked 8 inline comments as done.
juliehockett added a comment.
Adding in support for mapper tests and addressing comments.
https://reviews.llvm.org/D43341
Files:
clang-doc/BitcodeReader.cpp
clang-doc/BitcodeReader.h
clang-do
juliehockett added inline comments.
Comment at: clang-doc/BitcodeReader.cpp:19
+
+void ClangDocBitcodeReader::storeData(llvm::SmallString<4> &Field,
+ llvm::StringRef Blob) {
lebedev.ri wrote:
> I think all these `SmallString`
juliehockett updated this revision to Diff 137272.
juliehockett marked 6 inline comments as done.
juliehockett added a comment.
Updating based on parent changes
https://reviews.llvm.org/D43667
Files:
clang-doc/CMakeLists.txt
clang-doc/Representation.h
clang-doc/generators/CMakeLists.txt
juliehockett updated this revision to Diff 137457.
juliehockett marked 13 inline comments as done.
juliehockett added a comment.
Updating bitcode writer for hashed USRs, and re-running clang-format. Also
cleaning up a couple of unused fields.
https://reviews.llvm.org/D41102
Files:
CMakeLists
This revision was automatically updated to reflect the committed changes.
juliehockett marked 11 inline comments as done.
Closed by commit rL327102: [clang-doc] Setup clang-doc frontend framework
(authored by juliehockett, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to
This revision was automatically updated to reflect the committed changes.
juliehockett marked an inline comment as done.
Closed by commit rCTE327186: [clang-tidy] Update run-clang-tidy.py with config
arg (authored by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.or
juliehockett created this revision.
juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
Adding a checker to fuchsia-zx (for zircon) to flag instances where specific
objects are temporaril
juliehockett added a comment.
In https://reviews.llvm.org/D41102#1034919, @lebedev.ri wrote:
> Since the commit was reverted, did you mean to either recommit it, or reopen
> this (with updated diff), so it does not get lost?
Relanded in r327295.
Comment at: clang-doc/Bitcod
juliehockett updated this revision to Diff 138241.
juliehockett marked 8 inline comments as done.
juliehockett retitled this revision from "[clang-tidy] Add Fuchsia checker for
temporary objects" to "[clang-tidy] Add Zircon module to clang-tidy".
juliehockett edited the summary of this revision.
j
juliehockett updated this revision to Diff 138264.
juliehockett marked 6 inline comments as done.
juliehockett added a comment.
Addressing comments
https://reviews.llvm.org/D44346
Files:
clang-tidy/CMakeLists.txt
clang-tidy/tool/CMakeLists.txt
clang-tidy/tool/ClangTidyMain.cpp
clang-tid
juliehockett updated this revision to Diff 138286.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
Addomg tests amd fixing documentation
https://reviews.llvm.org/D44346
Files:
clang-tidy/CMakeLists.txt
clang-tidy/tool/CMakeLists.txt
clang-tidy/tool/ClangTidyMa
juliehockett updated this revision to Diff 138392.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
Fixing tests and updating docs
https://reviews.llvm.org/D44346
Files:
clang-tidy/CMakeLists.txt
clang-tidy/tool/CMakeLists.txt
clang-tidy/tool/ClangTidyMain.cpp
juliehockett added inline comments.
Comment at: clang-tidy/fuchsia/FuchsiaTidyModule.cpp:44
+CheckFactories.registerCheck(
+"fuchsia-zx-temporary-objects");
}
aaron.ballman wrote:
> Do we want a zircon module instead? I'm wondering about people who
juliehockett updated this revision to Diff 138466.
juliehockett marked 2 inline comments as done.
juliehockett added a comment.
Updating decl passed to warning string
https://reviews.llvm.org/D44346
Files:
clang-tidy/CMakeLists.txt
clang-tidy/tool/CMakeLists.txt
clang-tidy/tool/ClangTidyM
juliehockett updated this revision to Diff 138468.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
Updating docs.
https://reviews.llvm.org/D44346
Files:
clang-tidy/CMakeLists.txt
clang-tidy/tool/CMakeLists.txt
clang-tidy/tool/ClangTidyMain.cpp
clang-tidy/zir
juliehockett updated this revision to Diff 138470.
juliehockett added a comment.
Fixing a typo sorry
https://reviews.llvm.org/D44346
Files:
clang-tidy/CMakeLists.txt
clang-tidy/tool/CMakeLists.txt
clang-tidy/tool/ClangTidyMain.cpp
clang-tidy/zircon/CMakeLists.txt
clang-tidy/zircon/Tem
This revision was automatically updated to reflect the committed changes.
juliehockett marked 2 inline comments as done.
Closed by commit rL327590: [clang-tidy] Add Zircon module to clang-tidy
(authored by juliehockett, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior
juliehockett added a comment.
I was just thinking of disabling the one test that has an issue
(class-in-function) on Windows -- the filename is only used in generating
*some* USRs, so all of the other ones are fine. We ran into some issues with
that though, since `UNSUPPORTED: system-windows` d
juliehockett added a comment.
In https://reviews.llvm.org/D41102#1041791, @lebedev.ri wrote:
> Have you tried something more broad, like
> `UNSUPPORTED: mingw32,win32`
> ?
That wasn't working either, confusingly, at least on the local windows machine
I have.
Repository:
rL LLVM
https://
juliehockett updated this revision to Diff 149371.
juliehockett marked 13 inline comments as done.
juliehockett added a comment.
Fixing comments
https://reviews.llvm.org/D43341
Files:
clang-doc/BitcodeReader.cpp
clang-doc/BitcodeReader.h
clang-doc/BitcodeWriter.cpp
clang-doc/BitcodeWrit
juliehockett added inline comments.
Comment at: clang-doc/tool/ClangDocMain.cpp:181
+doc::writeInfo(I.get(), Buffer);
+ if (DumpResultToFile("bc", Group.getKey() + ".bc", Buffer))
+return 1;
ioeric wrote:
> juliehockett wrote:
> > ioeric wrot
juliehockett updated this revision to Diff 149373.
https://reviews.llvm.org/D43667
Files:
clang-doc/CMakeLists.txt
clang-doc/Generators.cpp
clang-doc/Generators.h
clang-doc/Representation.h
clang-doc/YAMLGenerator.cpp
clang-doc/tool/ClangDocMain.cpp
test/clang-doc/yaml-comments.cpp
juliehockett updated this revision to Diff 149500.
juliehockett marked 8 inline comments as done.
https://reviews.llvm.org/D43341
Files:
clang-doc/BitcodeReader.cpp
clang-doc/BitcodeReader.h
clang-doc/BitcodeWriter.cpp
clang-doc/BitcodeWriter.h
clang-doc/CMakeLists.txt
clang-doc/Repre
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333932: [clang-doc] Implement reducer portion of the
frontend framework (authored by juliehockett, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.
juliehockett added a comment.
Already fixed in https://reviews.llvm.org/rL333936, sorry!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47732
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
juliehockett updated this revision to Diff 149856.
juliehockett marked 4 inline comments as done.
juliehockett added a comment.
Addressing comments
https://reviews.llvm.org/D43667
Files:
clang-doc/CMakeLists.txt
clang-doc/Generators.cpp
clang-doc/Generators.h
clang-doc/Representation.h
juliehockett updated this revision to Diff 149997.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
Fixing comments
https://reviews.llvm.org/D43667
Files:
clang-doc/CMakeLists.txt
clang-doc/Generators.cpp
clang-doc/Generators.h
clang-doc/Representation.h
cl
juliehockett added inline comments.
Comment at: clang-doc/YAMLGenerator.cpp:265
+// and thus register the generator.
+volatile int YAMLGeneratorAnchorSource = 0;
+
ioeric wrote:
> nit: add `static`?
`static` declares it as file-local, and so the `extern` referenc
juliehockett closed this revision.
juliehockett added a comment.
Closed in r334103 .
https://reviews.llvm.org/D43667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
juliehockett created this revision.
juliehockett added reviewers: ioeric, lebedev.ri.
juliehockett added a project: clang-tools-extra.
The first reduce pass combines all duplicate info data into one representation
of that declaration info. This second pass iterates through the output of that
fir
juliehockett updated this revision to Diff 152135.
juliehockett added a comment.
Updating to reflect changes to the framework (and make it work).
https://reviews.llvm.org/D43424
Files:
clang-tools-extra/clang-doc/CMakeLists.txt
clang-tools-extra/clang-doc/Generators.cpp
clang-tools-extra/
juliehockett added a comment.
Can you re-upload the patch with context? (i.e. use -U99 or similar)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
juliehockett added a comment.
So on seeing this, all of the plumbing needed to get that particular value
where you need it is a bit ugly. I'm inclined to suggest wrapping it in a
`ClangDocContext`, containing it and the `ExecutionContext` in the `ClangDoc.h`
file:
struct ClangDocContext {
juliehockett created this revision.
juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, mgorny.
This is part of a move to convert clang-doc's tests to a more maintainable unit
test fram
juliehockett created this revision.
juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri.
juliehockett added a project: clang-tools-extra.
Herald added a subscriber: mgorny.
This is part of a move to convert clang-doc's tests to a more maintainable unit
test framework, with a small
juliehockett created this revision.
juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri.
juliehockett added a project: clang-tools-extra.
Herald added a subscriber: mgorny.
This is part of a move to convert clang-doc's tests to a more maintainable unit
test framework, with a small
juliehockett updated this revision to Diff 169221.
juliehockett added a comment.
Switching to raw strings.
https://reviews.llvm.org/D53085
Files:
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp
Index: clang-tools-extra/unittest
juliehockett created this revision.
juliehockett added reviewers: ioeric, leonardchan, jakehehrlich, lebedev.ri,
phosek.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman.
Since we generally want to document a whole project, not just one file.
@ioeric,
juliehockett updated this revision to Diff 169304.
https://reviews.llvm.org/D53170
Files:
clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
Index: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
===
--- clang-tools-extra/clang-
juliehockett updated this revision to Diff 169411.
https://reviews.llvm.org/D53170
Files:
clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
Index: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
===
--- clang-tools-extra/clang-
juliehockett marked 3 inline comments as done.
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:203
+llvm::Expected>
+createClangDocExecutor(int &argc, const char **argv,
+ llvm::cl::OptionCategory &Category)
juliehockett updated this revision to Diff 169414.
juliehockett marked 3 inline comments as done.
https://reviews.llvm.org/D53170
Files:
clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
Index: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
=
juliehockett updated this revision to Diff 169748.
juliehockett marked 2 inline comments as done.
https://reviews.llvm.org/D53081
Files:
clang-tools-extra/unittests/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/ClangDocTest.cpp
c
juliehockett updated this revision to Diff 169751.
juliehockett marked an inline comment as done.
https://reviews.llvm.org/D53084
Files:
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/YAMLGeneratorTest.cpp
Index: clang-tools-extra/unittests/clang-d
juliehockett updated this revision to Diff 169752.
juliehockett marked an inline comment as done.
https://reviews.llvm.org/D53085
Files:
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp
Index: clang-tools-extra/unittests/clang-doc
juliehockett updated this revision to Diff 169754.
juliehockett marked an inline comment as done.
https://reviews.llvm.org/D53081
Files:
clang-tools-extra/unittests/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/ClangDocTest.cpp
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344650: [clang-doc] Add unit tests for serialization
(authored by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53081?vs=169754&id=169907#toc
Repository:
rCTE Cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344652: [clang-doc] Add unit tests for merging (authored by
juliehockett, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53083?vs=169014&id=1
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344653: [clang-doc] Add unit tests for YAML generation
(authored by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53084?vs=169751&id=169910#toc
Repository:
rCTE C
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344654: [clang-doc] Add unit tests for Markdown generation
(authored by juliehockett, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53085?vs
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344654: [clang-doc] Add unit tests for Markdown generation
(authored by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53085?vs=169752&id=169911#toc
Repository:
rL
juliehockett created this revision.
juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman.
Makes bitcode tests line up with what's actually called in the tool. Should fix
the failing bot.
juliehockett created this revision.
juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri.
juliehockett added a project: clang-tools-extra.
https://reviews.llvm.org/D53382
Files:
clang-tools-extra/docs/clang-doc.rst
Index: clang-tools-extra/docs/clang-doc.rst
===
This revision was automatically updated to reflect the committed changes.
juliehockett marked an inline comment as done.
Closed by commit rL344707: [clang-doc] Bringing bitcode tests in line (authored
by juliehockett, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commi
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345418: [clang-doc] Switch to default to all-TUs executor
(authored by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53170?vs=169414&id=171331#toc
Repository:
rCT
juliehockett created this revision.
juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
Adds a checker to warn against using the std namespace, as Zircon's kernel
lib++ policy does not al
juliehockett updated this revision to Diff 171810.
juliehockett marked 5 inline comments as done.
https://reviews.llvm.org/D53882
Files:
clang-tools-extra/clang-tidy/zircon/CMakeLists.txt
clang-tools-extra/clang-tidy/zircon/NoStdNamespaceCheck.cpp
clang-tools-extra/clang-tidy/zircon/NoStdNa
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/NoStdNamespaceCheck.cpp:71
+void NoStdNamespaceCheck::check(const MatchFinder::MatchResult &Result) {
+ if (const auto *D = Result.Nodes.getNodeAs("stdVar"))
+diag(D->getBeginLoc(),
-
juliehockett accepted this revision.
juliehockett added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56825/new/
https://reviews.llvm.org/D56825
___
cf
juliehockett planned changes to this revision.
juliehockett marked 5 inline comments as done.
juliehockett added a comment.
In https://reviews.llvm.org/D53882#1282219, @aaron.ballman wrote:
> I am a bit confused by what this check is trying to accomplish. It seems like
> this is intended to catc
juliehockett created this revision.
juliehockett added reviewers: aaron.ballman, alexfh, hokein.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
Adds a check to convert fbl::move to std::move.
This check is part of a set of migration checks as we prep
juliehockett created this revision.
juliehockett added reviewers: aaron.ballman, alexfh, hokein.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
Adds a check to convert to std .
This check is part of a set of migration checks as we prepare to move Zi
juliehockett added a comment.
In https://reviews.llvm.org/D54168#1289128, @JonasToth wrote:
> I think this check is ok in the current form, but does it really need to be
> in upstream clang-tidy? You said its for migration only, so it is not
> valuable for you for a long time either?
So yes,
juliehockett updated this revision to Diff 172889.
juliehockett marked 4 inline comments as done.
https://reviews.llvm.org/D54168
Files:
clang-tools-extra/clang-tidy/zircon/CMakeLists.txt
clang-tools-extra/clang-tidy/zircon/FblMoveCheck.cpp
clang-tools-extra/clang-tidy/zircon/FblMoveCheck.h
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47
+SrcMgr::CharacteristicKind FileType) {
+ if (FileName == "fbl/limits.h") {
+unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1;
aa
juliehockett updated this revision to Diff 172892.
juliehockett marked 2 inline comments as done.
https://reviews.llvm.org/D54168
Files:
clang-tools-extra/clang-tidy/zircon/CMakeLists.txt
clang-tools-extra/clang-tidy/zircon/FblMoveCheck.cpp
clang-tools-extra/clang-tidy/zircon/FblMoveCheck.h
juliehockett updated this revision to Diff 172891.
juliehockett marked 5 inline comments as done.
https://reviews.llvm.org/D54169
Files:
clang-tools-extra/clang-tidy/zircon/CMakeLists.txt
clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp
clang-tools-extra/clang-tidy/zircon/FblLimitsChe
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47
+SrcMgr::CharacteristicKind FileType) {
+ if (FileName == "fbl/limits.h") {
+unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1;
aa
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47
+SrcMgr::CharacteristicKind FileType) {
+ if (FileName == "fbl/limits.h") {
+unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1;
aa
juliehockett abandoned this revision.
juliehockett added a comment.
After a lot of discussion, we'll do this migration internally. Thanks for your
comments!
https://reviews.llvm.org/D54169
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
juliehockett abandoned this revision.
juliehockett added a comment.
After a lot of discussion, we'll do this migration internally. Thanks for your
comments!
https://reviews.llvm.org/D54168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
juliehockett created this revision.
juliehockett added reviewers: phosek, leonardchan.
juliehockett added a project: clang-tools-extra.
Herald added a subscriber: mgorny.
Instead of as clang_executable.
https://reviews.llvm.org/D59974
Files:
clang-tools-extra/clang-doc/tool/CMakeLists.txt
I
101 - 200 of 402 matches
Mail list logo
