[PATCH] D16262: [libc++] Treat trailing backslashes in a regex pattern as invalid.

2016-01-18 Thread Josh Petrie via cfe-commits
jpetrie created this revision. jpetrie added a reviewer: mclow.lists. jpetrie added a subscriber: cfe-commits. std::regex should throw std::regex_error if constructed with a pattern ending in a trailing backslash, since a trailing backlash is not a valid escape sequence. http://reviews.llvm.org

Re: [PATCH] D16262: [libc++] Treat trailing backslashes in a regex pattern as invalid.

2016-01-19 Thread Josh Petrie via cfe-commits
jpetrie added a comment. In http://reviews.llvm.org/D16262#329328, @mclow.lists wrote: > This looks good to me. A quick search for `\\` in regex didn't find any > other obvious instances of this anti-pattern. For the record, the bug is > https://llvm.org/bugs/show_bug.cgi?id=26175 > > Can you