[clang] [libc] Attempt to enable missing string functions for offloading (PR #67869)

2023-09-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/67869 Summary: We previously had to disable these string functions because they were not compatible with the definitions coming from the GNU / host environment. The GPU, when exporting its declarations, has a very diffi

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

2023-10-02 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/67981 Summary: The `algorithm` header included here sometimes caused issues when using `libc++` over `libstdc++`. This was primarily because of the order they were included in. This patch just gets rid of this dependen

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

2023-10-02 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/67981 >From 3ce25920eb83ed2e859050fd24dada7b232e0431 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 2 Oct 2023 07:25:03 -0500 Subject: [PATCH] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

2023-10-02 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/67981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

2023-10-02 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Did you test it with internal CI? We may need some HIP header changes to > avoid regressing existing HIP apps. No, I don't know how to do that. Hopefully people aren't relying on this to be included elsewhere, since its replacement in this single file is pretty striaghtforwar

[clang-tools-extra] [libc] Fix linking of AMDGPU device runtime control constants for math (PR #65676)

2023-10-02 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/65676 >From d11fae15878622eb2eb452aedf616e01b577e102 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 7 Sep 2023 16:08:30 -0500 Subject: [PATCH 1/2] [libc] Fix linking of AMDGPU device runtime control constants

[clang] [libc] Fix linking of AMDGPU device runtime control constants for math (PR #65676)

2023-10-02 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/65676 >From d11fae15878622eb2eb452aedf616e01b577e102 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 7 Sep 2023 16:08:30 -0500 Subject: [PATCH 1/2] [libc] Fix linking of AMDGPU device runtime control constants

[clang] [libc] Fix linking of AMDGPU device runtime control constants for math (PR #65676)

2023-10-02 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Ping. This is a bug fix that prevents this from actually being used and doesn't change any existing behavior. https://github.com/llvm/llvm-project/pull/65676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang-tools-extra] [libc] Fix linking of AMDGPU device runtime control constants for math (PR #65676)

2023-10-02 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Ping. This is a bug fix that prevents this from actually being used and doesn't change any existing behavior. https://github.com/llvm/llvm-project/pull/65676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

2023-10-02 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/67981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Support compressing device binary (PR #67162)

2023-10-02 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > We need to support compression/uncompression of standalone bundled bitcode, > and standalone bundled code objects that are not embedded in ELF or COFF > binaries. An OS-neutral binary format is preferred. I think my ideal solution would be LLVM supporting some module metada

[clang] [HIP] Support compressing device binary (PR #67162)

2023-10-02 Thread Joseph Huber via cfe-commits
@@ -881,6 +900,184 @@ CreateFileHandler(MemoryBuffer &FirstInput, "'" + FilesType + "': invalid file type specified"); } +OffloadBundlerConfig::OffloadBundlerConfig() { + auto IgnoreEnvVarOpt = + llvm::sys::Process::GetEnv("OFFLOAD_BUNDLER_IGNO

[clang] [HIP] Support compressing device binary (PR #67162)

2023-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. I think in the long term we need to move away from the bundler, which would suggest we probably want something similar in the "new driver". But overall the changes here are pretty self contained and the concept is straightforward. https://

[clang] [LinkerWrapper] Fix resolution of weak symbols during LTO (PR #68215)

2023-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/68215 Summary: Weak symbols are supposed to have the semantics that they can be overriden by a strong (i.e. global) definition. This wasn't being respected by the LTO pass because we simply used the first definition tha

[clang] [LinkerWrapper] Fix resolution of weak symbols during LTO (PR #68215)

2023-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/68215 >From f2e29b6136d245e0712bfb87de1f4253d12dd6f5 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 4 Oct 2023 07:34:01 -0500 Subject: [PATCH] [LinkerWrapper] Fix resolution of weak symbols during LTO Summary:

[clang] AddDefaultRTL (PR #68220)

2023-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/68220 - [LinkerWrapper] Fix resolution of weak symbols during LTO - [Libomptarget] Make the DeviceRTL configuration globals weak >From f2e29b6136d245e0712bfb87de1f4253d12dd6f5 Mon Sep 17 00:00:00 2001 From: Joseph Hub

[clang] [Libomptarget] Make the DeviceRTL configuration globals weak (PR #68220)

2023-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/68220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Fix resolution of weak symbols during LTO (PR #68215)

2023-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/68215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

2023-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/68264 Summary: There's some logic in the AMDGPU target that manually resets the requested visibility of certain variables. This was triggering when we set a constant variable in OpenMP. However, we shouldn't do this for

[clang] [libc] Partially implement 'rand' for the GPU (PR #66167)

2023-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/66167 >From 7abe016b179a986ee6f94973a1a2c313185705f0 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 12 Sep 2023 18:13:22 -0500 Subject: [PATCH] [libc] Partially implement 'rand' for the GPU Summary: This patch

[clang-tools-extra] [libc] Partially implement 'rand' for the GPU (PR #66167)

2023-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/66167 >From 7abe016b179a986ee6f94973a1a2c313185705f0 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 12 Sep 2023 18:13:22 -0500 Subject: [PATCH] [libc] Partially implement 'rand' for the GPU Summary: This patch

[clang] [libc] Partially implement 'rand' for the GPU (PR #66167)

2023-10-04 Thread Joseph Huber via cfe-commits
jhuber6 wrote: ping https://github.com/llvm/llvm-project/pull/66167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Partially implement 'rand' for the GPU (PR #66167)

2023-10-04 Thread Joseph Huber via cfe-commits
jhuber6 wrote: ping https://github.com/llvm/llvm-project/pull/66167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

2023-10-05 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/68264 >From 52d11d0d975f03a3cd2760b42236b5ec8097331b Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 4 Oct 2023 16:50:20 -0500 Subject: [PATCH 1/2] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohos

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

2023-10-05 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > This stuff looks very cuda/opencl specific. It's definitely surprising for > C++ code. Do we need it for openmp? If not it seems better to guard the hack > with visibility behind if (hip) You reminded me that I need to refine this logic as well. What it's doing here is basica

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

2023-10-05 Thread Joseph Huber via cfe-commits
@@ -1,5 +1,5 @@ // RUN: %clang_cc1 -debug-info-kind=limited -verify -fopenmp -x c++ -triple nvptx64-unknown-unknown -fopenmp-targets=nvptx64-nvidia-cuda -emit-llvm %s -fopenmp-is-target-device -o - | FileCheck %s -// RUN: %clang_cc1 -debug-info-kind=limited -verify -fopenmp -x

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

2023-10-05 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/68264 >From 52d11d0d975f03a3cd2760b42236b5ec8097331b Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 4 Oct 2023 16:50:20 -0500 Subject: [PATCH 1/2] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohos

[clang] [HIP] Support compressing device binary (PR #67162)

2023-10-05 Thread Joseph Huber via cfe-commits
jhuber6 wrote: For reference, I've had similar problems in the past. Usually it happens because the header needs to be aligned on a `uint64_t` to be read. The ELF section has 8-byte alignment, but that can be incorrect when extracting from something like an archive. I just make a copy in that

[clang] [libc] Partially implement 'rand' for the GPU (PR #66167)

2023-10-05 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Can you double check this error from the linux x86_64 bot: > > ``` > /var/lib/buildkite-agent/builds/linux-56-7f758798dd-khkmx-1/llvm-project/github-pull-requests/libc/test/src/stdlib/rand_test.cpp:27:2: > error: unterminated conditional directive > -- > | #ifndef LIBC_TARGET

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

2023-10-05 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/68264 >From ddccf41b5c3a198db80199d2432afe60c41cad7b Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 4 Oct 2023 16:50:20 -0500 Subject: [PATCH] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost va

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

2023-10-05 Thread Joseph Huber via cfe-commits
@@ -308,12 +308,13 @@ static bool requiresAMDGPUProtectedVisibility(const Decl *D, if (GV->getVisibility() != llvm::GlobalValue::HiddenVisibility) return false; - return D->hasAttr() || - (isa(D) && D->hasAttr()) || - (isa(D) && - (D->hasAttr()

[clang] [libc] Enable remaining string functions on the GPU (PR #68346)

2023-10-05 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/68346 Summary: We previously had to disable these string functions because they were not compatible with the definitions coming from the GNU / host environment. The GPU, when exporting its declarations, has a very diffi

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

2023-10-05 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/68264 >From 5010ba6ec2f7370d2efc01d2fafb86d55c4dd883 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 4 Oct 2023 16:50:20 -0500 Subject: [PATCH] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost va

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

2023-10-05 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/68264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][Clang] Force use of `num_teams` and `thread_limit` for bare kernel (PR #68373)

2023-10-05 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Does `thread_limit` directly imply the number of threads? I thought that it merely set an upper bound such that it cannot be increased beyond that via environment variables. https://github.com/llvm/llvm-project/pull/68373 ___ cfe-commi

[clang-tools-extra] e6b98b7 - [Clangd] Fix ambiguous use of 'Range'

2023-07-18 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-07-18T11:41:24-05:00 New Revision: e6b98b7eff28de52927fb2ce7030e97ac363e1c0 URL: https://github.com/llvm/llvm-project/commit/e6b98b7eff28de52927fb2ce7030e97ac363e1c0 DIFF: https://github.com/llvm/llvm-project/commit/e6b98b7eff28de52927fb2ce7030e97ac363e1c0.diff

[clang] d2ac006 - [Clang] Only emit CUDA version warnings when creating the CUDA toolchain

2023-07-18 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-07-18T13:48:11-05:00 New Revision: d2ac0069a21b79efdcd32ba4cc44dc7f08a25b8b URL: https://github.com/llvm/llvm-project/commit/d2ac0069a21b79efdcd32ba4cc44dc7f08a25b8b DIFF: https://github.com/llvm/llvm-project/commit/d2ac0069a21b79efdcd32ba4cc44dc7f08a25b8b.diff

[clang] a37d747 - [OpenMP][Docs] Add some things to the OpenMP support

2023-07-19 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-07-19T13:17:39-05:00 New Revision: a37d7472225442227c531ce85a7448499f70b72e URL: https://github.com/llvm/llvm-project/commit/a37d7472225442227c531ce85a7448499f70b72e DIFF: https://github.com/llvm/llvm-project/commit/a37d7472225442227c531ce85a7448499f70b72e.diff

[clang] 4ab4e40 - [OpenMP] Always pass the optimization level to the linker wrapper

2023-08-18 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-08-18T17:10:13-05:00 New Revision: 4ab4e40fa2944bfd2ed44c63027e7a838043e0fd URL: https://github.com/llvm/llvm-project/commit/4ab4e40fa2944bfd2ed44c63027e7a838043e0fd DIFF: https://github.com/llvm/llvm-project/commit/4ab4e40fa2944bfd2ed44c63027e7a838043e0fd.diff

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

2023-10-06 Thread Joseph Huber via cfe-commits
jhuber6 wrote: I already changed the `init_fini_array_test` while I fixed an unrelated problem, so it should be fine now. https://github.com/llvm/llvm-project/pull/67673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [libc] Fix linking of AMDGPU device runtime control constants for math (PR #65676)

2023-10-06 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/65676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Fix linking of AMDGPU device runtime control constants for math (PR #65676)

2023-10-06 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/65676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 85feb93 - [OpenMP] Fix setting visibility on declare target variables

2023-10-09 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-10-09T07:56:43-05:00 New Revision: 85feb9347f77859a877e767692e1c11d00cf6ffd URL: https://github.com/llvm/llvm-project/commit/85feb9347f77859a877e767692e1c11d00cf6ffd DIFF: https://github.com/llvm/llvm-project/commit/85feb9347f77859a877e767692e1c11d00cf6ffd.diff

[clang] b7de1d0 - [Clang][NFC] Use correct tool name for NVIDIA's 'nvlink'

2023-10-16 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-10-16T15:41:01-05:00 New Revision: b7de1d07e5298bdd97816043360ea334378f5565 URL: https://github.com/llvm/llvm-project/commit/b7de1d07e5298bdd97816043360ea334378f5565 DIFF: https://github.com/llvm/llvm-project/commit/b7de1d07e5298bdd97816043360ea334378f5565.diff

[clang] Correctly link and optimize device libraries with -mlink-builtin-bitcode (PR #69371)

2023-10-17 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > This handles the edge case where optimization introduces new device library > functions, such as a fused sincos() from separate sin() and cos() calls. This seems like a pretty big change to solve just this problem. Could we not just put `nobuiltin` on said function to stop it

[clang] Correctly link and optimize device libraries with -mlink-builtin-bitcode (PR #69371)

2023-10-17 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > sincos() is just one example. There are several other cases that can trigger > this issue. fold_rootn() generates new function calls for square and cubic > roots, fold_pow() does a similar thing for specific powers (ex 2), etc. > > We did try disabling -amdgpu-prelink, and it

[clang] Correctly link and optimize device libraries with -mlink-builtin-bitcode (PR #69371)

2023-10-17 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > This approach assumes that whatever the function call was transformed into > > also exists in the same library, which isn't necessarily true. > > True, good point. But I don't think it's necessarily due to this approach, > but more of how AMDGPULibCalls is implemented. It se

[clang] 141c4e7 - [OpenMP] Do not always emit unused extern variables

2023-07-28 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-07-28T11:52:05-05:00 New Revision: 141c4e7a9403fed46d84c7f0429295bd28c89368 URL: https://github.com/llvm/llvm-project/commit/141c4e7a9403fed46d84c7f0429295bd28c89368 DIFF: https://github.com/llvm/llvm-project/commit/141c4e7a9403fed46d84c7f0429295bd28c89368.diff

[clang] bc08022 - [Clang] Fix Offloading related tests after D156363

2023-08-02 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-08-02T14:34:51-05:00 New Revision: bc080221b3a2c73739caa2bf0521dd3984d0a934 URL: https://github.com/llvm/llvm-project/commit/bc080221b3a2c73739caa2bf0521dd3984d0a934 DIFF: https://github.com/llvm/llvm-project/commit/bc080221b3a2c73739caa2bf0521dd3984d0a934.diff

[clang] ab202aa - [Clang] Increase default architecture from sm_35 to sm_52

2023-08-02 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-08-02T17:30:23-05:00 New Revision: ab202aa7004a451ee9f496505256cfcb94d71747 URL: https://github.com/llvm/llvm-project/commit/ab202aa7004a451ee9f496505256cfcb94d71747 DIFF: https://github.com/llvm/llvm-project/commit/ab202aa7004a451ee9f496505256cfcb94d71747.diff

[clang] 0ba9aec - [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

2023-08-07 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-08-07T14:08:04-05:00 New Revision: 0ba9aec38faa8f567741fdb4eac1149c3fe94ceb URL: https://github.com/llvm/llvm-project/commit/0ba9aec38faa8f567741fdb4eac1149c3fe94ceb DIFF: https://github.com/llvm/llvm-project/commit/0ba9aec38faa8f567741fdb4eac1149c3fe94ceb.diff

[clang] 9e99a4f - [NVPTX] Fix missed test after adding alias support for NVPTX

2023-08-07 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-08-07T14:35:02-05:00 New Revision: 9e99a4f0db0e21b68e9aab9ad6f32f34d42eb460 URL: https://github.com/llvm/llvm-project/commit/9e99a4f0db0e21b68e9aab9ad6f32f34d42eb460 DIFF: https://github.com/llvm/llvm-project/commit/9e99a4f0db0e21b68e9aab9ad6f32f34d42eb460.diff

[clang] 61709bb - [OpenMP] Ensure wrapper headers are included on both host and device

2023-08-08 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-08-08T19:07:47-05:00 New Revision: 61709bbae37af4e01cf93c6d112ba984bbd9a7ea URL: https://github.com/llvm/llvm-project/commit/61709bbae37af4e01cf93c6d112ba984bbd9a7ea DIFF: https://github.com/llvm/llvm-project/commit/61709bbae37af4e01cf93c6d112ba984bbd9a7ea.diff

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. I manually set the code object of the `libc` test suite to be `4` for the time being. That should unblock this. https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-com

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

2023-09-12 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 review_requested https://github.com/llvm/llvm-project/pull/66162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

2023-09-12 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/66162: Summary: We use the 1llvm.amgcn.abi.version` varaible to control code generation. This is emitted in every module now to indicate what should be used when compiling. Previously, the logic caused us to emit an ext

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

2023-09-12 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 review_requested https://github.com/llvm/llvm-project/pull/66162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

2023-09-12 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 review_requested https://github.com/llvm/llvm-project/pull/66162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

2023-09-12 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 review_requested https://github.com/llvm/llvm-project/pull/66162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

2023-09-12 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/66162: >From a78d2d9459563cb2582502a4afefb74bbed1afa4 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 12 Sep 2023 19:22:30 -0500 Subject: [PATCH] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "no

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

2023-09-12 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/66162: >From afe74583e6f9a5bd785427204866367f3eac8620 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 12 Sep 2023 19:22:30 -0500 Subject: [PATCH] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "no

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

2023-09-12 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/66162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

2023-09-13 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/66205: Summary: Currently, there is an assertion that prevents us from emitting an AMDGPU global with a non-target specific address space (i.e. numerical attribute). I'm unsure what the original intentions of this asser

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

2023-09-13 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 review_requested https://github.com/llvm/llvm-project/pull/66205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

2023-09-13 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 review_requested https://github.com/llvm/llvm-project/pull/66205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

2023-09-13 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 review_requested https://github.com/llvm/llvm-project/pull/66205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

2023-09-13 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --check-globals --version 3 +// RUN: %clang_cc1 -cc1 -triple amdgcn-amd-amdhsa -emit-llvm %s -o - | FileCheck %s + +int [[clang::opencl_global]] a = 0; +int [[clang::opencl_

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

2023-09-13 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/66205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

2023-09-13 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/66205: >From 97642f663099cfb42792cd2415387170a146d9e2 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 13 Sep 2023 07:57:47 -0500 Subject: [PATCH] [Clang][AMDGPU] Permit language address spaces for AMDGPU global

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

2023-09-13 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --check-globals --version 3 +// RUN: %clang_cc1 -cc1 -triple amdgcn-amd-amdhsa -emit-llvm %s -o - | FileCheck %s + +int [[clang::opencl_global]] a = 0; +int [[clang::opencl_

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

2023-09-13 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 resolved https://github.com/llvm/llvm-project/pull/66205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

2023-09-13 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/66162: >From 1aab90448afc0f072d194eb956f6543e82d76303 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 12 Sep 2023 19:22:30 -0500 Subject: [PATCH] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "no

[clang] a4a2637 - [libc] Add support for creating wrapper headers for offloading in clang

2023-07-06 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-07-06T18:10:49-05:00 New Revision: a4a26374aa11d48ac6bf65c78c2aaf8f16414287 URL: https://github.com/llvm/llvm-project/commit/a4a26374aa11d48ac6bf65c78c2aaf8f16414287 DIFF: https://github.com/llvm/llvm-project/commit/a4a26374aa11d48ac6bf65c78c2aaf8f16414287.diff

[clang] 6ca6cdb - Revert "[libc] Add support for creating wrapper headers for offloading in clang"

2023-07-06 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-07-06T18:26:41-05:00 New Revision: 6ca6cdb23ece54fcbdead75cda3dd36e08db9665 URL: https://github.com/llvm/llvm-project/commit/6ca6cdb23ece54fcbdead75cda3dd36e08db9665 DIFF: https://github.com/llvm/llvm-project/commit/6ca6cdb23ece54fcbdead75cda3dd36e08db9665.diff

[clang] 2a65d03 - [libc] Add support for creating wrapper headers for offloading in clang

2023-07-07 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-07-07T16:02:33-05:00 New Revision: 2a65d0388ca0f1c756f4c1a859cbb9e24b364942 URL: https://github.com/llvm/llvm-project/commit/2a65d0388ca0f1c756f4c1a859cbb9e24b364942 DIFF: https://github.com/llvm/llvm-project/commit/2a65d0388ca0f1c756f4c1a859cbb9e24b364942.diff

[clang] b454e7a - [libc] Remove GPU string functions incompatible with C++

2023-07-10 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-07-10T10:40:10-05:00 New Revision: b454e7aa7ceb35a0070406ebd7ffdf1ed85f5ef8 URL: https://github.com/llvm/llvm-project/commit/b454e7aa7ceb35a0070406ebd7ffdf1ed85f5ef8 DIFF: https://github.com/llvm/llvm-project/commit/b454e7aa7ceb35a0070406ebd7ffdf1ed85f5ef8.diff

[clang] 9da61ae - [OpenMP] Emit offloading entries for indirect target variables

2023-08-24 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-08-24T18:21:13-05:00 New Revision: 9da61aed751ea6a51e7fa2e970de896d3cc27791 URL: https://github.com/llvm/llvm-project/commit/9da61aed751ea6a51e7fa2e970de896d3cc27791 DIFF: https://github.com/llvm/llvm-project/commit/9da61aed751ea6a51e7fa2e970de896d3cc27791.diff

[clang] 1376dfa - [OpenMP][Fix] Update test after changing flag value

2023-08-25 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-08-25T18:59:43-05:00 New Revision: 1376dfa32c5b94b33d396ecfd5a6e27cd9179b2f URL: https://github.com/llvm/llvm-project/commit/1376dfa32c5b94b33d396ecfd5a6e27cd9179b2f DIFF: https://github.com/llvm/llvm-project/commit/1376dfa32c5b94b33d396ecfd5a6e27cd9179b2f.diff

[clang] 30307a7 - [libc] Implement the 'clock()' function on the GPU

2023-08-30 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-08-30T16:16:34-05:00 New Revision: 30307a7bb795cf5e5ccdcb923bd8a7401d3d4bd6 URL: https://github.com/llvm/llvm-project/commit/30307a7bb795cf5e5ccdcb923bd8a7401d3d4bd6 DIFF: https://github.com/llvm/llvm-project/commit/30307a7bb795cf5e5ccdcb923bd8a7401d3d4bd6.diff

[clang] e082973 - [Clang][libc] Add wrapper headers for `assert.h` for the GPU libc

2023-09-01 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-09-01T18:34:09-05:00 New Revision: e0829739bc77606aa4dcd4769869d2e9ad9d2ec0 URL: https://github.com/llvm/llvm-project/commit/e0829739bc77606aa4dcd4769869d2e9ad9d2ec0 DIFF: https://github.com/llvm/llvm-project/commit/e0829739bc77606aa4dcd4769869d2e9ad9d2ec0.diff

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-05 Thread Joseph Huber via cfe-commits
jhuber6 wrote: The `libc` tests will need to be updated as well. I'll need to look into that. https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] 37edd91 - [OpenMP] Do not add wrapper headers if using '-nogpuinc'

2022-11-28 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-11-28T10:20:31-06:00 New Revision: 37edd910478d911f93044d524a61974c991e6cae URL: https://github.com/llvm/llvm-project/commit/37edd910478d911f93044d524a61974c991e6cae DIFF: https://github.com/llvm/llvm-project/commit/37edd910478d911f93044d524a61974c991e6cae.diff

[clang] bfd69ad - [LinkerWrapper] Ignore OFK_None kinds for building registration code

2022-11-29 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-11-29T09:46:51-06:00 New Revision: bfd69ad59672e67d60e71d66df7ef878c18a7bb8 URL: https://github.com/llvm/llvm-project/commit/bfd69ad59672e67d60e71d66df7ef878c18a7bb8 DIFF: https://github.com/llvm/llvm-project/commit/bfd69ad59672e67d60e71d66df7ef878c18a7bb8.diff

[clang] 55f3849 - [Clang] Always use --no-undefined when linking AMDGPU images

2023-03-14 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-03-14T13:11:33-05:00 New Revision: 55f38495e38e2a3aeb4f2dac852644eb4937bd74 URL: https://github.com/llvm/llvm-project/commit/55f38495e38e2a3aeb4f2dac852644eb4937bd74 DIFF: https://github.com/llvm/llvm-project/commit/55f38495e38e2a3aeb4f2dac852644eb4937bd74.diff

[clang] af54d1e - [NVPTX] Set the atomic inling threshold when targeting NVPTX directly

2023-03-23 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-03-23T16:30:07-05:00 New Revision: af54d1e852850edcc7b9485851320d9ebf1be4fe URL: https://github.com/llvm/llvm-project/commit/af54d1e852850edcc7b9485851320d9ebf1be4fe DIFF: https://github.com/llvm/llvm-project/commit/af54d1e852850edcc7b9485851320d9ebf1be4fe.diff

[clang] 9ddc03a - [OpenMP] Fix test after updating NVPTX atomic inlines

2023-03-23 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-03-23T16:41:25-05:00 New Revision: 9ddc03a17dba1d7aaad73067325344f6b79441b0 URL: https://github.com/llvm/llvm-project/commit/9ddc03a17dba1d7aaad73067325344f6b79441b0 DIFF: https://github.com/llvm/llvm-project/commit/9ddc03a17dba1d7aaad73067325344f6b79441b0.diff

[clang] 29a5c3c - [NVPTX] Introduce attribute to mark kernels without a language mode

2023-03-24 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-03-24T14:42:25-05:00 New Revision: 29a5c3c8fe30dcfb19dd86dd5f3f201435311997 URL: https://github.com/llvm/llvm-project/commit/29a5c3c8fe30dcfb19dd86dd5f3f201435311997 DIFF: https://github.com/llvm/llvm-project/commit/29a5c3c8fe30dcfb19dd86dd5f3f201435311997.diff

[clang] b530e1a - [LinkerWrapper] Do not extract globals with no offloading language

2023-03-27 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-03-27T11:38:27-05:00 New Revision: b530e1af62be16ffb06285ddca27a413f5089b7e URL: https://github.com/llvm/llvm-project/commit/b530e1af62be16ffb06285ddca27a413f5089b7e DIFF: https://github.com/llvm/llvm-project/commit/b530e1af62be16ffb06285ddca27a413f5089b7e.diff

[clang] bed7005 - [NVPTX] Add __CUDA_ARCH__ macro to standalone NVPTX compilations

2023-03-27 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-03-27T18:08:15-05:00 New Revision: bed7005eb4d4850b6f9d93707213ced5c0c19de0 URL: https://github.com/llvm/llvm-project/commit/bed7005eb4d4850b6f9d93707213ced5c0c19de0 DIFF: https://github.com/llvm/llvm-project/commit/bed7005eb4d4850b6f9d93707213ced5c0c19de0.diff

[clang] 853d405 - [OpenMP] Ignore implicit casts on assertion for `use_device_ptr`

2023-02-27 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-02-27T10:48:20-06:00 New Revision: 853d4059135bdadf74d67f59215b21026b6f939e URL: https://github.com/llvm/llvm-project/commit/853d4059135bdadf74d67f59215b21026b6f939e DIFF: https://github.com/llvm/llvm-project/commit/853d4059135bdadf74d67f59215b21026b6f939e.diff

[clang] 466b432 - [clang-format] Only add pragma continuation indentation for 'omp' clauses

2023-02-28 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-02-28T15:15:44-06:00 New Revision: 466b4327f8fcaf82178b02dffc66a5ff11a150d4 URL: https://github.com/llvm/llvm-project/commit/466b4327f8fcaf82178b02dffc66a5ff11a150d4 DIFF: https://github.com/llvm/llvm-project/commit/466b4327f8fcaf82178b02dffc66a5ff11a150d4.diff

[clang] a26aabe - [Clang] Add --version and --help messages to amdgpu/nvptx-arch

2023-03-13 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-03-13T12:32:42-05:00 New Revision: a26aabefe535d323c416d7d57be8c669f3741f15 URL: https://github.com/llvm/llvm-project/commit/a26aabefe535d323c416d7d57be8c669f3741f15 DIFF: https://github.com/llvm/llvm-project/commit/a26aabefe535d323c416d7d57be8c669f3741f15.diff

[clang] c2aabcf - [LinkerWrapper] Switch to add_clang_tool() macro

2023-03-13 Thread Joseph Huber via cfe-commits
Author: Evangelos Foutras Date: 2023-03-13T12:43:12-05:00 New Revision: c2aabcfc8395ba30884dd3c1ecc2b192ae85a78d URL: https://github.com/llvm/llvm-project/commit/c2aabcfc8395ba30884dd3c1ecc2b192ae85a78d DIFF: https://github.com/llvm/llvm-project/commit/c2aabcfc8395ba30884dd3c1ecc2b192ae85a78d.d

[clang] 1b40df1 - [Clang] Fix not including clangBasic in the dynamic build

2023-03-13 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-03-13T12:41:16-05:00 New Revision: 1b40df1de7a4b3664a55becd776c250f20db0041 URL: https://github.com/llvm/llvm-project/commit/1b40df1de7a4b3664a55becd776c250f20db0041 DIFF: https://github.com/llvm/llvm-project/commit/1b40df1de7a4b3664a55becd776c250f20db0041.diff

[clang] 8784b6a - [Clang] Allow bitcode linking when the input is LLVM-IR

2023-06-20 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-06-20T08:02:58-05:00 New Revision: 8784b6a8540f4a333690e7233587859f1d82f620 URL: https://github.com/llvm/llvm-project/commit/8784b6a8540f4a333690e7233587859f1d82f620 DIFF: https://github.com/llvm/llvm-project/commit/8784b6a8540f4a333690e7233587859f1d82f620.diff

[clang] efacdfc - [LinkerWrapper] Support linking vendor bitcode late

2023-06-20 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-06-20T08:02:59-05:00 New Revision: efacdfc235e327341d2b8a733d9963fb526cf17b URL: https://github.com/llvm/llvm-project/commit/efacdfc235e327341d2b8a733d9963fb526cf17b DIFF: https://github.com/llvm/llvm-project/commit/efacdfc235e327341d2b8a733d9963fb526cf17b.diff

[clang] 767852b - [Clang] Disable `libc` headers for offloading languages

2023-06-22 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-06-22T14:12:32-05:00 New Revision: 767852b1a8e38b87fc9a20a28adb0056d1bf2cb8 URL: https://github.com/llvm/llvm-project/commit/767852b1a8e38b87fc9a20a28adb0056d1bf2cb8 DIFF: https://github.com/llvm/llvm-project/commit/767852b1a8e38b87fc9a20a28adb0056d1bf2cb8.diff

[clang] 869baa9 - [ClangPackager] Add an option to extract inputs to an archive

2023-06-23 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-06-23T15:03:43-05:00 New Revision: 869baa9125736f6140ef770e4a3a852c5f9be505 URL: https://github.com/llvm/llvm-project/commit/869baa9125736f6140ef770e4a3a852c5f9be505 DIFF: https://github.com/llvm/llvm-project/commit/869baa9125736f6140ef770e4a3a852c5f9be505.diff

[clang] 1d699bf - [OpenMP] Always apply target declarations to canonical definitions

2023-06-27 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-06-27T09:15:03-05:00 New Revision: 1d699bf2664d2a9e64024fd9eb87451d6360ea8c URL: https://github.com/llvm/llvm-project/commit/1d699bf2664d2a9e64024fd9eb87451d6360ea8c DIFF: https://github.com/llvm/llvm-project/commit/1d699bf2664d2a9e64024fd9eb87451d6360ea8c.diff

[clang] 7653011 - [AMDGPU] Always pass `-mcpu` to the `lld` linker

2023-06-28 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-06-28T08:52:37-05:00 New Revision: 765301183f58a28af65b112db44218dc224b9fec URL: https://github.com/llvm/llvm-project/commit/765301183f58a28af65b112db44218dc224b9fec DIFF: https://github.com/llvm/llvm-project/commit/765301183f58a28af65b112db44218dc224b9fec.diff

<    5   6   7   8   9   10   11   12   13   14   >