[clang] f263bd8 - [Clang] Implicitly include LLVM libc headers for the GPU

2023-04-03 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-04-03T12:57:21-05:00 New Revision: f263bd8f7d4c82af9672803e6d8d57f25c929d00 URL: https://github.com/llvm/llvm-project/commit/f263bd8f7d4c82af9672803e6d8d57f25c929d00 DIFF: https://github.com/llvm/llvm-project/commit/f263bd8f7d4c82af9672803e6d8d57f25c929d00.diff

[clang] d78ceeb - [Clang] Fix failing test on windows and add TODO for gpu headers

2023-04-03 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-04-03T16:54:22-05:00 New Revision: d78ceeba986b5ebe83f935175e584c346a52b8a3 URL: https://github.com/llvm/llvm-project/commit/d78ceeba986b5ebe83f935175e584c346a52b8a3 DIFF: https://github.com/llvm/llvm-project/commit/d78ceeba986b5ebe83f935175e584c346a52b8a3.diff

[clang] ad6a7d7 - [nvptx-arch] Dynamically load `libcuda.so.1` directly instead

2023-04-04 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-04-04T19:50:31-05:00 New Revision: ad6a7d7dc9a2055ac3a4658d90ec86d78c3199b5 URL: https://github.com/llvm/llvm-project/commit/ad6a7d7dc9a2055ac3a4658d90ec86d78c3199b5 DIFF: https://github.com/llvm/llvm-project/commit/ad6a7d7dc9a2055ac3a4658d90ec86d78c3199b5.diff

[clang-tools-extra] 1663016 - [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

2023-04-16 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-04-16T10:58:44-05:00 New Revision: 1663016b41d71a60f3d268607c6fbf16fcf85172 URL: https://github.com/llvm/llvm-project/commit/1663016b41d71a60f3d268607c6fbf16fcf85172 DIFF: https://github.com/llvm/llvm-project/commit/1663016b41d71a60f3d268607c6fbf16fcf85172.diff

[clang] ba9590d - [Clang][Docs] Add help test to `-march` and `-mcpu` to suggest `-mcpu=help`

2023-05-22 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-05-22T10:28:46-05:00 New Revision: ba9590d8bc76f9d410a626c26a3d55e1381de4aa URL: https://github.com/llvm/llvm-project/commit/ba9590d8bc76f9d410a626c26a3d55e1381de4aa DIFF: https://github.com/llvm/llvm-project/commit/ba9590d8bc76f9d410a626c26a3d55e1381de4aa.diff

[clang] a26bd95 - [LinkerWrapper] Fix static library symbol resolution

2023-06-01 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-06-01T06:51:51-05:00 New Revision: a26bd95325f120d9737a0b03c80eabddb56f46db URL: https://github.com/llvm/llvm-project/commit/a26bd95325f120d9737a0b03c80eabddb56f46db DIFF: https://github.com/llvm/llvm-project/commit/a26bd95325f120d9737a0b03c80eabddb56f46db.diff

[clang-tools-extra] 860e439 - [Clang] Fix missing libraries for the include cleaner check

2023-06-02 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-06-02T12:43:55-05:00 New Revision: 860e439fb27f86b97bfd9acce5e27f4337c471c7 URL: https://github.com/llvm/llvm-project/commit/860e439fb27f86b97bfd9acce5e27f4337c471c7 DIFF: https://github.com/llvm/llvm-project/commit/860e439fb27f86b97bfd9acce5e27f4337c471c7.diff

[clang] 472393e - [Clang] Disable building tools for 32-bit hosts as well

2023-02-07 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-02-07T21:18:50-06:00 New Revision: 472393eff45002f60826f04fcc9261eeaa9f8691 URL: https://github.com/llvm/llvm-project/commit/472393eff45002f60826f04fcc9261eeaa9f8691 DIFF: https://github.com/llvm/llvm-project/commit/472393eff45002f60826f04fcc9261eeaa9f8691.diff

[clang] 067a5c6 - [amdgpu-arch] Fix build of amdgpu-arch with CLANG_LINK_CLANG_DYLIB

2023-02-10 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-02-10T08:23:49-06:00 New Revision: 067a5c68845c13d45e85ec9eaa11d2b2d829bab4 URL: https://github.com/llvm/llvm-project/commit/067a5c68845c13d45e85ec9eaa11d2b2d829bab4 DIFF: https://github.com/llvm/llvm-project/commit/067a5c68845c13d45e85ec9eaa11d2b2d829bab4.diff

[clang] 861764b - [NVPTX] Fix NVPTX output name in the driver with `-save-temps`

2023-02-15 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-02-15T07:39:59-06:00 New Revision: 861764b1c5f7fc31601655f01d84407d42013c30 URL: https://github.com/llvm/llvm-project/commit/861764b1c5f7fc31601655f01d84407d42013c30 DIFF: https://github.com/llvm/llvm-project/commit/861764b1c5f7fc31601655f01d84407d42013c30.diff

[clang] c45d2df - [Clang] Add options in LTO mode when cross compiling for AMDGPU

2023-02-22 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-02-22T10:14:05-06:00 New Revision: c45d2df05e0e7b6f2517aa2933a24928b4942a3f URL: https://github.com/llvm/llvm-project/commit/c45d2df05e0e7b6f2517aa2933a24928b4942a3f DIFF: https://github.com/llvm/llvm-project/commit/c45d2df05e0e7b6f2517aa2933a24928b4942a3f.diff

[clang] c2c917f - [Clang] Change default triple to LLVM_HOST_TRIPLE for the CUDA toolchain

2023-05-08 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-05-08T15:54:50-05:00 New Revision: c2c917f7f6680ec7a1214af9f5105c2beb9ba162 URL: https://github.com/llvm/llvm-project/commit/c2c917f7f6680ec7a1214af9f5105c2beb9ba162 DIFF: https://github.com/llvm/llvm-project/commit/c2c917f7f6680ec7a1214af9f5105c2beb9ba162.diff

[clang] e494ebf - [OpenMP] Fix incorrect interop type for number of dependencies

2023-05-08 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-05-08T21:02:43-05:00 New Revision: e494ebf9d09b1112dcf4f22984bdb51bbf5d8cd7 URL: https://github.com/llvm/llvm-project/commit/e494ebf9d09b1112dcf4f22984bdb51bbf5d8cd7 DIFF: https://github.com/llvm/llvm-project/commit/e494ebf9d09b1112dcf4f22984bdb51bbf5d8cd7.diff

[clang-tools-extra] 28bdff1 - [clangd][NFX][FIX] Fix conflicting symbol name `Expr`

2023-05-09 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-05-09T07:58:36-05:00 New Revision: 28bdff19e3ad981ef83e372e8c301f1407b82135 URL: https://github.com/llvm/llvm-project/commit/28bdff19e3ad981ef83e372e8c301f1407b82135 DIFF: https://github.com/llvm/llvm-project/commit/28bdff19e3ad981ef83e372e8c301f1407b82135.diff

[clang] 027aeec - [Clang] Respect `-L` options when compiling directly for AMDGPU

2023-05-11 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-05-11T16:02:54-05:00 New Revision: 027aeec7da67afe33b159f5e42dec57488897454 URL: https://github.com/llvm/llvm-project/commit/027aeec7da67afe33b159f5e42dec57488897454 DIFF: https://github.com/llvm/llvm-project/commit/027aeec7da67afe33b159f5e42dec57488897454.diff

[clang] dd02984 - [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

2023-05-12 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-05-12T13:14:27-05:00 New Revision: dd02984519abafe7637cdafcf4ede8b303f385ab URL: https://github.com/llvm/llvm-project/commit/dd02984519abafe7637cdafcf4ede8b303f385ab DIFF: https://github.com/llvm/llvm-project/commit/dd02984519abafe7637cdafcf4ede8b303f385ab.diff

[clang] 66da9ec - [Clang] Remove direct linking of offloading runtimes from the arch tools

2023-05-17 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-05-17T17:47:49-05:00 New Revision: 66da9ec073ff8dde54b70adcf3b62914769324bf URL: https://github.com/llvm/llvm-project/commit/66da9ec073ff8dde54b70adcf3b62914769324bf DIFF: https://github.com/llvm/llvm-project/commit/66da9ec073ff8dde54b70adcf3b62914769324bf.diff

[clang] f665760 - [Clang] Accept and forward `-fconvergent-functions` in the driver

2023-04-24 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-04-24T09:11:21-05:00 New Revision: f6657601629005cc9e488f159e310ae4008a25ea URL: https://github.com/llvm/llvm-project/commit/f6657601629005cc9e488f159e310ae4008a25ea DIFF: https://github.com/llvm/llvm-project/commit/f6657601629005cc9e488f159e310ae4008a25ea.diff

[clang] f05ce90 - [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

2023-05-04 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-05-04T07:13:00-05:00 New Revision: f05ce9045af4a40232c08451cb0aef64b0e673b2 URL: https://github.com/llvm/llvm-project/commit/f05ce9045af4a40232c08451cb0aef64b0e673b2 DIFF: https://github.com/llvm/llvm-project/commit/f05ce9045af4a40232c08451cb0aef64b0e673b2.diff

[clang] dc81d2a - [OpenMP] Fix using the target ID when using the new driver

2023-06-07 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-06-07T19:17:27-05:00 New Revision: dc81d2a4d5b38a82cdc76c41522e61f0de716904 URL: https://github.com/llvm/llvm-project/commit/dc81d2a4d5b38a82cdc76c41522e61f0de716904 DIFF: https://github.com/llvm/llvm-project/commit/dc81d2a4d5b38a82cdc76c41522e61f0de716904.diff

[clang] e96bec9 - [OpenMP] Correctly diagnose conflicting target identifierers for AMDGPU

2023-06-15 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-06-15T07:06:44-05:00 New Revision: e96bec9cd8e14ee2174490c0ce09cedfcd6be79e URL: https://github.com/llvm/llvm-project/commit/e96bec9cd8e14ee2174490c0ce09cedfcd6be79e DIFF: https://github.com/llvm/llvm-project/commit/e96bec9cd8e14ee2174490c0ce09cedfcd6be79e.diff

[clang] df41577 - [LinkerWrapper] Fix use-after-free when using JIT

2022-12-05 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-12-05T07:51:20-06:00 New Revision: df415774d2a584fb6a62bedf9a4ee936396a0e41 URL: https://github.com/llvm/llvm-project/commit/df415774d2a584fb6a62bedf9a4ee936396a0e41 DIFF: https://github.com/llvm/llvm-project/commit/df415774d2a584fb6a62bedf9a4ee936396a0e41.diff

[clang] [clang][CodeGen] Shift relink option implementation away from module cloning (PR #81693)

2024-02-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Looks fine. https://github.com/llvm/llvm-project/pull/81693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Allow partial linking for `-fgpu-rdc` (PR #81700)

2024-02-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: This makes sense overall, though it's very complicated. Generally we just need to make sure these things are private to one group of files. There's a lot more to parse here compared to the `linker-wrapper`. Do any of these tests check when called with `-r`

[clang] fa9e297 - [ClangPackager] Fix passing in multiple instances of `file`

2024-02-14 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-02-14T22:11:21-06:00 New Revision: fa9e297b8b63dacb962d99814e698658ad71f946 URL: https://github.com/llvm/llvm-project/commit/fa9e297b8b63dacb962d99814e698658ad71f946 DIFF: https://github.com/llvm/llvm-project/commit/fa9e297b8b63dacb962d99814e698658ad71f946.diff

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/81921 Summary: This is a massive patch because it reworks the entire build and everything that depends on it. This is not split up because various bots would fail otherwise. I will attempt to describe the necessary chan

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From 5fdaa384ebc962429950b79098dee0581c74f4f3 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/81921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From 613402be5f027c7f5494513772d0f17dd046a3e8 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-15 Thread Joseph Huber via cfe-commits
@@ -533,15 +542,14 @@ endfunction(add_integration_test) set(LIBC_HERMETIC_TEST_COMPILE_OPTIONS ${LIBC_COMPILE_OPTIONS_DEFAULT} jhuber6 wrote: Yeah there's a lot of logic that's moved and broken after rebasing. Trying to figure out what's changed. https://githu

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-15 Thread Joseph Huber via cfe-commits
@@ -1,12 +1,9 @@ set(libc_archive_targets "") + list(APPEND added_archive_targets ${archive_1}) jhuber6 wrote: Don't know how that got there, I'll fix it. https://github.com/llvm/llvm-project/pull/81921 ___ cfe-commi

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From caf0ee274f353b6adb23c455121ec2102c260de0 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From d0f782f4db249f6be08dba5060ee403974c95fdf Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From 3c4a7ea70941fbf3c8a47c0715423ae38cc25a68 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [llvm] [mlir] [openmp] [OpenMP] Remove `register_requires` global constructor (PR #80460)

2024-02-16 Thread Joseph Huber via cfe-commits
jhuber6 wrote: ping https://github.com/llvm/llvm-project/pull/80460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add 'CLANG_ALLOW_IMPLICIT_RPATH' to enable toolchain use of -rpath (PR #82004)

2024-02-16 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/82004 Summary: The original discussion in https://reviews.llvm.org/D118493 was that `clang` should not be adding `-rpath` implicitly for toolchains. The main motivation behind that change was the 'Fedora' toolchain disa

[clang] [Clang] Add 'CLANG_ALLOW_IMPLICIT_RPATH' to enable toolchain use of -rpath (PR #82004)

2024-02-16 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/82004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add 'CLANG_ALLOW_IMPLICIT_RPATH' to enable toolchain use of -rpath (PR #82004)

2024-02-16 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > I don't think a CMake option is the right way to go here. For example, I > doubt we would actually use this CMake option in Fedora if this patch is > committed. Does Fedora only use default configurations when building its packages? > Does gcc use rpath for libgomp? That's i

[clang] [Clang] Add 'CLANG_ALLOW_IMPLICIT_RPATH' to enable toolchain use of -rpath (PR #82004)

2024-02-16 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > Does Fedora only use default configurations when building its packages? > > We try to stick to the defaults as much as possible. Having an implicit rpath > by default causes issues when building other RPMs with clang, and typically, > if we need to change something in order

[clang] [Clang] Add 'CLANG_ALLOW_IMPLICIT_RPATH' to enable toolchain use of -rpath (PR #82004)

2024-02-16 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > We could make this logic more complicated by checking the system > > automatically `execute_command(lsb_release)` or something. > > I think this is too complicated and fragile. If we want to do something > specifically to support the distro use case, I think we should do thi

[clang] [Clang] Add 'CLANG_ALLOW_IMPLICIT_RPATH' to enable toolchain use of -rpath (PR #82004)

2024-02-16 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > I believe right now the `rtlib-rpath` points to the path > > `${CLANG_BINARY}../lib/${HOST_TRIPLE}/`. I think it's definitely reasonable > > to not put this on system libraries if that's a solution, since we can > > generally assume it's a global installation and already cov

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-16 Thread Joseph Huber via cfe-commits
@@ -135,86 +147,20 @@ function(_get_common_test_compile_options output_var flags) # list(APPEND compile_options "-Wglobal-constructors") # endif() endif() - if (LIBC_TARGET_ARCHITECTURE_IS_GPU) -# TODO: Set these flags -# list(APPEND compile_options "-nogp

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-16 Thread Joseph Huber via cfe-commits
@@ -135,86 +147,20 @@ function(_get_common_test_compile_options output_var flags) # list(APPEND compile_options "-Wglobal-constructors") # endif() endif() - if (LIBC_TARGET_ARCHITECTURE_IS_GPU) -# TODO: Set these flags -# list(APPEND compile_options "-nogp

[clang] [Clang] Add 'CLANG_ALLOW_IMPLICIT_RPATH' to enable toolchain use of -rpath (PR #82004)

2024-02-16 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Could we have the upstream default be to install a clang.cfg file in bin/ > which has -fimplicit-openmp-rpath (or whatever the hoption is)? Configuration files as far as I'm aware can't do toolchain / language specific stuff, so it's a little weaker than being able to just res

[clang] [llvm] [openmp] [PGO][OpenMP] Instrumentation for GPU devices (PR #76587)

2024-02-16 Thread Joseph Huber via cfe-commits
@@ -2067,6 +2067,10 @@ Constant *ConstantExpr::getBitCast(Constant *C, Type *DstTy, Constant *ConstantExpr::getAddrSpaceCast(Constant *C, Type *DstTy, bool OnlyIfReduced) { + // Skip cast if types are identical jhuber

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-16 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From c4758c8663307708e5ac653a8692e595f4b1f4cc Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-17 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From 63e4205a9f5cc3ea8a4ce0730b01d78b6c9bde42 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-17 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Tested this one a few machines and it works as expected after some final tweaks. FYI @jplehr and @Artem-B, this will change the CMake configuration required for building and testing on the build bots. The new expected way to test each one respectively would be the following ```

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From 85f7218baa72307699b48bffa3da4005597ec719 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From 8727a9631480deac9d9df386ed26dfcd35914a13 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From f3013086f60f2a78c12887cf1736455e8fb1911b Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [Clang][NVPTX] Allow passing arguments to the linker while standalone (PR #73030)

2024-02-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/73030 >From ee43e8f9ae90bcd70d46b17cfecb854711a4b1ce Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 21 Nov 2023 13:45:10 -0600 Subject: [PATCH] [Clang][NVPTX] Allow passing arguments to the linker while standa

[clang] [Clang][NVPTX] Allow passing arguments to the linker while standalone (PR #73030)

2024-02-19 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Ping, once https://github.com/llvm/llvm-project/pull/81921 lands this patch won't cause any issues with the `libc` build like it does currently so I'd like to land this afterwards. https://github.com/llvm/llvm-project/pull/73030 ___ cf

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-19 Thread Joseph Huber via cfe-commits
@@ -50,31 +50,9 @@ function(collect_object_file_deps target result) endif() endfunction(collect_object_file_deps) -# A rule to build a library from a collection of entrypoint objects. -# Usage: -# add_entrypoint_library( -# DEPENDS -# ) -# -# NOTE: If one want

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/81921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-20 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From a396fe930db6c3fb20dc4f7918736e54d21cb24b Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [NVPTX] Enable the _Float16 type for NVPTX compilation (PR #82436)

2024-02-20 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/82436 Summary: The PTX target supports the f16 type natively and we alreaqdy have a few LLVM backend tests that support the LLVM-IR. We should be able to enable this for generic use. This is done prior the f16 math func

[clang] [NVPTX] Enable the _Float16 type for NVPTX compilation (PR #82436)

2024-02-20 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/82436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [openmp] [OpenMP] Remove `register_requires` global constructor (PR #80460)

2024-02-21 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/80460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From 2cf6f184e2e8a6abc31e0dfb19c706569357597d Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From 575390d65fd35729e855823e38dfd28f7a15debd Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From c118c0b82cf47b36460479fd920325dedc7a6c79 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/81921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Append target search paths for direct offloading compilation (PR #82699)

2024-02-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/82699 Summary: Recent changes to the `libc` project caused the headers to be installed to `include/` for the GPU and the libraries to be in `lib/`. This means we should automatically append these search paths so they ca

[clang] [Clang][NVPTX] Allow passing arguments to the linker while standalone (PR #73030)

2024-02-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/73030 >From ee43e8f9ae90bcd70d46b17cfecb854711a4b1ce Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 21 Nov 2023 13:45:10 -0600 Subject: [PATCH] [Clang][NVPTX] Allow passing arguments to the linker while standa

[clang] [Clang][NVPTX] Allow passing arguments to the linker while standalone (PR #73030)

2024-02-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/73030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e3cab8f - [LinkerWrapper] Fix test after permitting NVPTX linker arguments

2024-02-22 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-02-22T16:54:03-06:00 New Revision: e3cab8fe82eb71fadb251d11fec7df9fa0dbdd27 URL: https://github.com/llvm/llvm-project/commit/e3cab8fe82eb71fadb251d11fec7df9fa0dbdd27 DIFF: https://github.com/llvm/llvm-project/commit/e3cab8fe82eb71fadb251d11fec7df9fa0dbdd27.diff

[clang] e8740d4 - [Clang] Fix missing architecture on CUDA test

2024-02-22 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-02-22T16:59:56-06:00 New Revision: e8740d4eb1c88e968b155f73ac745f80b4681589 URL: https://github.com/llvm/llvm-project/commit/e8740d4eb1c88e968b155f73ac745f80b4681589 DIFF: https://github.com/llvm/llvm-project/commit/e8740d4eb1c88e968b155f73ac745f80b4681589.diff

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-07-01 Thread Joseph Huber via cfe-commits
@@ -942,6 +942,36 @@ struct Amdgpu final : public VariadicABIInfo { } }; +struct NVPTX final : public VariadicABIInfo { + + bool enableForTarget() override { return true; } + + bool vaListPassedInSSARegister() override { return true; } + + Type *vaListType(LLVMContext &Ct

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-07-01 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > The nvptx lowering looks dubious - values smaller than slot size should be > passed with the same alignment as the slot and presently aren't. A struct > containing i8, i16 or half should be miscompiled on nvptx as written. I mentioned this in the original patch, it's correct a

[clang] [llvm] [LLVM] Fix incorrect alignment on AMDGPU variadics (PR #96370)

2024-07-01 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Patch should not land. Need to know what bug this was trying to address to > guess at what the right fix would be. My understanding was that the variadics did lowering to a struct with a minimum alignment of four. This currently *doesn't* do that, hence my confusion. The curr

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-07-01 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > You could theoretically break this if you didn't go through the C ABI and > > ignored type promotion, but I'm not concerned with that kind of misuse > > since it's against the ABI in the first place. > > The IR has its own ABI that may or may not match whatever the platform

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-07-01 Thread Joseph Huber via cfe-commits
@@ -942,6 +942,36 @@ struct Amdgpu final : public VariadicABIInfo { } }; +struct NVPTX final : public VariadicABIInfo { + + bool enableForTarget() override { return true; } + + bool vaListPassedInSSARegister() override { return true; } + + Type *vaListType(LLVMContext &Ct

[clang] [llvm] [LLVM] Fix incorrect alignment on AMDGPU variadics (PR #96370)

2024-07-01 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/96370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Fix incorrect alignment on AMDGPU variadics (PR #96370)

2024-07-01 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Lower than native alignment is legal in AMDGPU hardware and it's possible to work around in the `printf` implementation, closing. https://github.com/llvm/llvm-project/pull/96370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-07-01 Thread Joseph Huber via cfe-commits
@@ -54,7 +54,34 @@ class MockArgList { } template LIBC_INLINE T next_var() { -++arg_counter; +arg_counter++; +return T(arg_counter); + } + + size_t read_count() const { return arg_counter; } +}; + +// Used by the GPU implementation to parse how many bytes ne

[clang] [Clang] Introduce 'clang-nvlink-wrapper' to work around 'nvlink' (PR #96561)

2024-07-01 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/96561 >From 12d00a54169fef15efccfe9472db25b1261d31d3 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 24 Jun 2024 15:14:52 -0500 Subject: [PATCH] [Clang] Introduce 'clang-nvlink-wrappaer' to work around 'nvlink'

[clang] [libc] [llvm] [NVPTX] Implement variadic functions using IR lowering (PR #96015)

2024-07-01 Thread Joseph Huber via cfe-commits
@@ -116,8 +116,7 @@ class LLVM_LIBRARY_VISIBILITY NVPTXTargetInfo : public TargetInfo { } BuiltinVaListKind getBuiltinVaListKind() const override { -// FIXME: implement -return TargetInfo::CharPtrBuiltinVaList; +return TargetInfo::VoidPtrBuiltinVaList; ---

[clang] [libc] [llvm] [NVPTX] Implement variadic functions using IR lowering (PR #96015)

2024-07-01 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/96015 >From 8bd49caa9fa93fd3d0812e0a4315f8ff4956056a Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 17 Jun 2024 15:32:31 -0500 Subject: [PATCH 1/2] [NVPTX] Implement variadic functions using IR lowering Summar

[clang] [Clang] Introduce 'clang-nvlink-wrapper' to work around 'nvlink' (PR #96561)

2024-07-02 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/96561 >From 3b10fce6b3d3f8eeb7bd9a3828d488362bb061dd Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 24 Jun 2024 15:14:52 -0500 Subject: [PATCH] [Clang] Introduce 'clang-nvlink-wrappaer' to work around 'nvlink'

[clang] [llvm] [mlir] [OpenMP] Migrate GPU Reductions CodeGen from Clang to OMPIRBuilder (PR #80343)

2024-07-02 Thread Joseph Huber via cfe-commits
jhuber6 wrote: This patch causes the `offloading/bug51781.c` test to fail when compiled with reductions + debug information. ```console > clang ../offload/test/offloading/bug51781.c -fopenmp -O1 --offload-arch=sm_89 > -DADD_REDUCTION --offload-device-only -gline-tables-only !dbg attachment poin

[clang] [Clang] Introduce 'clang-nvlink-wrapper' to work around 'nvlink' (PR #96561)

2024-07-02 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/96561 >From 2bb5bd081a29b9bf1c4e6e0f727e21a1b9258920 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 24 Jun 2024 15:14:52 -0500 Subject: [PATCH] [Clang] Introduce 'clang-nvlink-wrappaer' to work around 'nvlink'

[clang] [Clang] Introduce 'clang-nvlink-wrapper' to work around 'nvlink' (PR #96561)

2024-07-02 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/96561 >From 2d3957ac14906d569acf5b3ceb5c7e2f4dfabe54 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 24 Jun 2024 15:14:52 -0500 Subject: [PATCH] [Clang] Introduce 'clang-nvlink-wrappaer' to work around 'nvlink'

[clang] [flang] [Flang-new][OpenMP] Add bitcode files for AMD GPU OpenMP (PR #96742)

2024-07-03 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Would it be possible for you to investigate that? It really shouldn't be required if we can't help it. https://github.com/llvm/llvm-project/pull/96742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [LinkerWrapper] Pass all files to the device linker (PR #97573)

2024-07-03 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/97573 Summary: The linker wrapper's job is to extract embedded device code from fat binaries and create linked images that can then be embedded and executed. In order to support LTO, we originally reinvented all of the

[libunwind] [libunwind] Remove needless `sys/uio.h` (PR #97495)

2024-07-03 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/97495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Correctly code-gen default atomic mem order (PR #97663)

2024-07-03 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/97663 Summary: The parsing for this was implemented, but we never hooked up the default value to the result of this clause. This patch adds the support by making it default to the requires directive. >From fa3561bd4d4

[clang] [LinkerWrapper] Pass all files to the device linker (PR #97573)

2024-07-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/97573 >From 7a64ee668b33c912f83d4f848ab72d421f8a1bec Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 24 Jun 2024 15:14:52 -0500 Subject: [PATCH 1/2] [Clang] Introduce 'clang-nvlink-wrappaer' to work around 'nvl

[clang] [llvm] [Offload] Move HIP and CUDA to new driver by default (PR #84420)

2024-09-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/84420 >From ac95806fa58d919a21f3724b10ba0634ff381d18 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 7 Mar 2024 15:48:00 -0600 Subject: [PATCH] [Offload] Move HIP and CUDA to new driver by default Summary: This

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/102521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > FWIW, on one of my test systems that's currently very busy, check-offload > consistently fails with amdgpu-arch timeouts. However, the following so far > makes it consistently succeed: > > ``` > $ CLANG_TOOLCHAIN_PROGRAM_TIMEOUT=60 ninja check-offload > ``` > > Previously, I'

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-09 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > Possibly worth increasing it to a minute then, > > Should we also land the env var? If so, I'll just extend this patch. > > Either way, any objection to moving `[Default]SecondsToWait` into > executeToolChainProgram so we're maintaining it in just one place? > > > this is b

[clang] [llvm] [Coroutines] Change `llvm.coro.noop` to accept `llvm_anyptr_ty` instead (PR #102096)

2024-08-12 Thread Joseph Huber via cfe-commits
@@ -123,6 +123,17 @@ bool coro::declaresIntrinsics(const Module &M, return false; } +// Verifies if a module has any intrinsics. +bool coro::declaresIntrinsics(const Module &M, + const DenseSet &Identifiers) { + for (const Function &F : M.functi

[clang] [llvm] [Coroutines] Change `llvm.coro.noop` to accept `llvm_anyptr_ty` instead (PR #102096)

2024-08-12 Thread Joseph Huber via cfe-commits
@@ -123,6 +123,17 @@ bool coro::declaresIntrinsics(const Module &M, return false; } +// Verifies if a module has any intrinsics. +bool coro::declaresIntrinsics(const Module &M, + const DenseSet &Identifiers) { + for (const Function &F : M.functi

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-08-12 Thread Joseph Huber via cfe-commits
@@ -553,9 +562,23 @@ void NVPTX::FatBinary::ConstructJob(Compilation &C, const JobAction &JA, continue; // We need to pass an Arch of the form "sm_XX" for cubin files and // "compute_XX" for ptx. -const char *Arch = (II.getType() == types::TY_PP_Asm) -

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-08-12 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. LG in general https://github.com/llvm/llvm-project/pull/100247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-08-12 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/100247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Always pass `-flto` if the linker supports it (PR #102972)

2024-08-12 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/102972 Summary; Now that we use the linker to do LTO / device linking, we need to inform the `clang` invocation to use `-flto` so it forwards arguments like `-On` correctly. >From b89e843bcca89e53552fead5a8b88e5046c37

[clang] [LinkerWrapper] Always pass `-flto` if the linker supports it (PR #102972)

2024-08-13 Thread Joseph Huber via cfe-commits
jhuber6 wrote: I'm very familiar with that error message, it's https://github.com/llvm/llvm-project/issues/64863. I guess I should just manually pass the optimization level at `O2` for now. https://github.com/llvm/llvm-project/pull/102972 ___ cfe-com

[clang] [LinkerWrapper] Always pass `-flto` if the linker supports it (PR #102972)

2024-08-13 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > I guess I should just manually pass the optimization level at `O2` for now. > > Would -O3 still pass through? Should, the behavior that was apparently passing was using `-O2`. https://github.com/llvm/llvm-project/pull/102972 ___ cf

<    6   7   8   9   10   11   12   13   14   15   >