https://github.com/jroelofs closed
https://github.com/llvm/llvm-project/pull/114410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs wrote:
sure!
https://github.com/llvm/llvm-project/pull/114410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs wrote:
I think this diagnostic should not be firing on `%x` format specifiers:
https://clang.godbolt.org/z/YGh1qdq1h
```
#include
void bad() {
int u = 0;
printf("%x\n", u);
}
```
```
:5:20: warning: format specifies type 'unsigned int' but the argument
has type 'int' [-Wfor
https://github.com/jroelofs created
https://github.com/llvm/llvm-project/pull/115546
This is a partial revert of e314622f204a01ffeda59cbe046dd403b01f8b74
rdar://139237593
>From a54e1c1b7ff03fa0f29b0a64e290763d6b085df8 Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Fri, 8 Nov 2024 13:46:33 -
@@ -91,17 +91,20 @@ void sc_caller(void) __arm_streaming_compatible {
}
-// CHECK: attributes #[[ATTR0:[0-9]+]] = {{.*}} "aarch64_pstate_sm_body"
-// CHECK: attributes #[[ATTR1:[0-9]+]] = {{.*}} "aarch64_pstate_sm_body"
-// CHECK: attributes #[[ATTR2:[0-9]+]] = {{.*}}
-// CHE
@@ -91,17 +91,20 @@ void sc_caller(void) __arm_streaming_compatible {
}
-// CHECK: attributes #[[ATTR0:[0-9]+]] = {{.*}} "aarch64_pstate_sm_body"
-// CHECK: attributes #[[ATTR1:[0-9]+]] = {{.*}} "aarch64_pstate_sm_body"
-// CHECK: attributes #[[ATTR2:[0-9]+]] = {{.*}}
-// CHE
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/111962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs deleted
https://github.com/llvm/llvm-project/pull/116028
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/116028
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/114410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/113281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs wrote:
At the very least, the fixit shouldn't be recommending precisely what the user
wrote, which funnily enough, gcc also gets wrong:
https://clang.godbolt.org/z/88sqM5xET
https://github.com/llvm/llvm-project/pull/74440
___
cfe-commits mai
jroelofs wrote:
@compnerd @etcwilde WDYT about conditionalizing the new dependency with an `if
(TARGET vt_gen)` instead of doing the `add_subdirectory()` dance?
https://github.com/llvm/llvm-project/pull/109601
___
cfe-commits mailing list
cfe-commits@
jroelofs wrote:
@mgorny https://github.com/llvm/llvm-project/pull/109601
https://github.com/llvm/llvm-project/pull/109306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/109306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/115363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs wrote:
oh, right. nvm
https://github.com/llvm/llvm-project/pull/108658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs wrote:
> The ; did you mean to use BAR? version was accidentally emitted in some
> cases where it didn't make sense to do so, but the tests still passed because
> the diagnostic did contain cannot use FOO in context asdf.
There's a `FileCheck` flag to enforce this: `--match-full-line
@@ -5796,12 +5796,18 @@ declared entity. The entity must not have weak linkage;
for example, in C++,
it cannot be applied to a declaration if a definition at that location would be
considered inline.
-Not all targets support this attribute. ELF target support depends on both
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/114387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -151,6 +152,9 @@ static bool useFramePointerForTargetByDefault(const
llvm::opt::ArgList &Args,
}
}
+ if (toolchains::isARMBareMetal(Triple))
jroelofs wrote:
good idea re: `isArmEABIBareMetal`
https://github.com/llvm/llvm-project/pull/117140
__
https://github.com/jroelofs updated
https://github.com/llvm/llvm-project/pull/115546
>From a54e1c1b7ff03fa0f29b0a64e290763d6b085df8 Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Fri, 8 Nov 2024 13:46:33 -0800
Subject: [PATCH 1/2] [llvm][ARM] Restore the default to -mstrict-align on
Apple fi
https://github.com/jroelofs edited
https://github.com/llvm/llvm-project/pull/116257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -48,6 +48,19 @@ std::optional
AArch64::ArchInfo::findBySubArch(StringRef SubA
return {};
}
+unsigned AArch64::getFMVPriority(ArrayRef Features) {
+ constexpr unsigned MaxFMVPriority = 1000;
+ unsigned Priority = 0;
+ unsigned NumFeatures = 0;
+ for (StringRef Feature
@@ -48,6 +48,19 @@ std::optional
AArch64::ArchInfo::findBySubArch(StringRef SubA
return {};
}
+unsigned AArch64::getFMVPriority(ArrayRef Features) {
+ constexpr unsigned MaxFMVPriority = 1000;
+ unsigned Priority = 0;
+ unsigned NumFeatures = 0;
+ for (StringRef Feature
https://github.com/jroelofs closed
https://github.com/llvm/llvm-project/pull/115546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -48,6 +48,19 @@ std::optional
AArch64::ArchInfo::findBySubArch(StringRef SubA
return {};
}
+unsigned AArch64::getFMVPriority(ArrayRef Features) {
+ constexpr unsigned MaxFMVPriority = 1000;
+ unsigned Priority = 0;
+ unsigned NumFeatures = 0;
+ for (StringRef Feature
@@ -48,6 +48,19 @@ std::optional
AArch64::ArchInfo::findBySubArch(StringRef SubA
return {};
}
+unsigned AArch64::getFMVPriority(ArrayRef Features) {
+ constexpr unsigned MaxFMVPriority = 1000;
+ unsigned Priority = 0;
+ unsigned NumFeatures = 0;
+ for (StringRef Feature
@@ -48,6 +48,19 @@ std::optional
AArch64::ArchInfo::findBySubArch(StringRef SubA
return {};
}
+unsigned AArch64::getFMVPriority(ArrayRef Features) {
+ constexpr unsigned MaxFMVPriority = 1000;
+ unsigned Priority = 0;
+ unsigned NumFeatures = 0;
+ for (StringRef Feature
https://github.com/jroelofs approved this pull request.
LGTM as a refactor. We don't need to solve the spec clarification thing in this
PR:
https://github.com/llvm/llvm-project/pull/116257/files#r1844489795
https://github.com/llvm/llvm-project/pull/116257
__
jroelofs wrote:
> > A motivating example might be target_version("simd+dotprod") and
> > target_version("sve"): when sve is available we should pick that version,
> > but the current rule prioritizes the number of attribute-specified features
> > over their overall weight.
>
> I agree about t
jroelofs wrote:
> Looking at the test failure, it appears that when only building
> `check-clang-tools`, no `clang` binary was built. So the test driver cannot
> find `clang`. Maybe this diagnostics binary file should be checked in for the
> test? That will not catch future errors if the diagn
https://github.com/jroelofs updated
https://github.com/llvm/llvm-project/pull/118581
>From 46775c380244e47ddd9a3188651f37c3a3b33d23 Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Tue, 3 Dec 2024 18:04:49 -0800
Subject: [PATCH 1/3] Add processor aliases back to -print-supported-cpus and
-mcpu
https://github.com/jroelofs edited
https://github.com/llvm/llvm-project/pull/118581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,15 @@
+// REQUIRES: clang
+// RUN: not %clang %s -serialize-diagnostics %s.diag
jroelofs wrote:
recommend putting the new file under `%t` instead of `%s`, so this doesn't
pollute the source dir.
https://github.com/llvm/llvm-project/pull/118522
__
@@ -0,0 +1,129 @@
+//=== ClangReadDiagnostics.cpp - clang-read-diagnostics tool
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,10 @@
+include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
jroelofs wrote:
I'm not sure this is necessary.
https://github.com/llvm/llvm-project/pull/118522
___
cfe-commits mailing list
cfe-commits@lists.llvm
jroelofs wrote:
> Suppose you have target_version("i8mm+dotprod") and target_version("fcma").
> The first version clearly has higher priority
According to the [current
rules](https://arm-software.github.io/acle/main/acle.html#selection) yes, but
IMO that rule is broken and doesn't match user
jroelofs wrote:
Looks okay to me, but let me tag some clang-tools-extra folks for a second look.
https://github.com/llvm/llvm-project/pull/118522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
https://github.com/jroelofs updated
https://github.com/llvm/llvm-project/pull/118581
>From 46775c380244e47ddd9a3188651f37c3a3b33d23 Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Tue, 3 Dec 2024 18:04:49 -0800
Subject: [PATCH 1/6] Add processor aliases back to -print-supported-cpus and
-mcpu
https://github.com/jroelofs closed
https://github.com/llvm/llvm-project/pull/118581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/120507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs wrote:
IIUC `__MACH__` means "the kernel is Mach, and we're going to be loaded by
dyld", and `apple-none-macho` targets is _not_ that.
> as Swift expects all MachO targets to have that defined.
can you elaborate on that expectation?
https://github.com/llvm/llvm-project/pull/120507
__
@@ -49,16 +49,11 @@ std::optional
AArch64::ArchInfo::findBySubArch(StringRef SubA
}
unsigned AArch64::getFMVPriority(ArrayRef Features) {
jroelofs wrote:
I'm not sure that this interface can correctly describe the new rule. ISTM it
would have to be a compar
jroelofs wrote:
I see a new warning from this patch:
```
clang/lib/Driver/ToolChains/SYCL.cpp:35:10: warning: returning address of local
temporary object [-Wreturn-stack-address]
```
https://github.com/llvm/llvm-project/pull/117268
___
cfe-commits mai
https://github.com/jroelofs closed
https://github.com/llvm/llvm-project/pull/126721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/126721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs wrote:
> > > Suppose you have target_version("i8mm+dotprod") and
> > > target_version("fcma"). The first version clearly has higher priority
> >
> >
> > According to the [current
> > rules](https://arm-software.github.io/acle/main/acle.html#selection) yes,
> > but IMO that rule is
@@ -109,16 +109,27 @@ class alignas(void *) Stmt {
//===--- Statement bitfields classes ---===//
+ enum { NumStmtBits = 10 };
+
+#define STMT(CLASS, PARENT)
+#define STMT_RANGE(BASE, FIRST, LAST)
+#define LAST_STMT_RANGE(BASE, FIRST, LAST)
jroelofs wrote:
> > > Let's just increase to 9 bits.
> > > Have you checked whether the size of `Stmt` or `Expr` changes when you do
> > > this?
> >
> >
> > I have these concerns as well, this ends up affecting the size of a lot of
> > things
> > That said, StmtNodes.td already has 267 it
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/120341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2631,55 +2643,65 @@ void DarwinClang::AddClangCXXStdlibIncludeArgs(
}
case ToolChain::CST_Libstdcxx:
-llvm::SmallString<128> UsrIncludeCxx = Sysroot;
-llvm::sys::path::append(UsrIncludeCxx, "usr", "include", "c++");
-
-llvm::Triple::ArchType arch = getTripl
@@ -0,0 +1,55 @@
+// UNSUPPORTED: system-windows
+// Windows is unsupported because we use the Unix path separator `/` in the
test.
+
+// Add default directories before running clang to check default
+// search paths.
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: cp -R %S/Inputs/M
@@ -0,0 +1,55 @@
+// UNSUPPORTED: system-windows
+// Windows is unsupported because we use the Unix path separator `/` in the
test.
+
jroelofs wrote:
As written, this requires an `aarch64-registered-target`. I think you can avoid
that though by turning these
@@ -0,0 +1,55 @@
+// UNSUPPORTED: system-windows
+// Windows is unsupported because we use the Unix path separator `/` in the
test.
+
+// Add default directories before running clang to check default
+// search paths.
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: cp -R %S/Inputs/M
@@ -0,0 +1,55 @@
+// UNSUPPORTED: system-windows
+// Windows is unsupported because we use the Unix path separator `/` in the
test.
+
+// Add default directories before running clang to check default
+// search paths.
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: cp -R %S/Inputs/M
jroelofs wrote:
may as well address @nikic's post-commit suggestion to move this out of the
header, and into a source file, while you're here:
https://github.com/llvm/llvm-project/pull/120341#discussion_r1893822845
https://github.com/llvm/llvm-project/pull/120643
__
@@ -114,10 +114,10 @@ class alignas(void *) Stmt {
#define STMT(CLASS, PARENT)
#define STMT_RANGE(BASE, FIRST, LAST)
#define LAST_STMT_RANGE(BASE, FIRST, LAST)
\
- static_assert(
@@ -0,0 +1,55 @@
+// UNSUPPORTED: system-windows
+// Windows is unsupported because we use the Unix path separator `/` in the
test.
+
+// Add default directories before running clang to check default
+// search paths.
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: cp -R %S/Inputs/M
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/120643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -114,10 +114,9 @@ class alignas(void *) Stmt {
#define STMT(CLASS, PARENT)
#define STMT_RANGE(BASE, FIRST, LAST)
#define LAST_STMT_RANGE(BASE, FIRST, LAST)
\
- static_assert(
@@ -290,8 +290,50 @@ class LLVM_LIBRARY_VISIBILITY MachO : public ToolChain {
/// }
};
+/// Apple specific MachO extensions
+class LLVM_LIBRARY_VISIBILITY AppleMachO : public MachO {
+public:
+ AppleMachO(const Driver &D, const llvm::Triple &Triple,
+ const llvm
@@ -0,0 +1,43 @@
+// UNSUPPORTED: system-windows
+// Windows is unsupported because we use the Unix path separator `/` in the
test.
+
+// Unlike the Darwin driver, the MachO driver doesn't add any framework search
paths,
+// only the normal header ones.
+// RUN: %clang -x c -t
@@ -0,0 +1,43 @@
+// UNSUPPORTED: system-windows
+// Windows is unsupported because we use the Unix path separator `/` in the
test.
+
+// Unlike the Darwin driver, the MachO driver doesn't add any framework search
paths,
+// only the normal header ones.
+// RUN: %clang -x c -t
@@ -0,0 +1,43 @@
+// UNSUPPORTED: system-windows
+// Windows is unsupported because we use the Unix path separator `/` in the
test.
+
+// Unlike the Darwin driver, the MachO driver doesn't add any framework search
paths,
+// only the normal header ones.
+// RUN: %clang -x c -t
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/120507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1018,13 +1018,19 @@ bool Darwin::hasBlocksRuntime() const {
}
}
-void Darwin::AddCudaIncludeArgs(const ArgList &DriverArgs,
-ArgStringList &CC1Args) const {
+void MachO::AddCudaIncludeArgs(const ArgList &DriverArgs,
+
@@ -290,8 +290,50 @@ class LLVM_LIBRARY_VISIBILITY MachO : public ToolChain {
/// }
};
+/// Apple specific MachO extensions
+class LLVM_LIBRARY_VISIBILITY AppleMachO : public MachO {
+public:
+ AppleMachO(const Driver &D, const llvm::Triple &Triple,
+ const llvm
https://github.com/jroelofs created
https://github.com/llvm/llvm-project/pull/118581
They were accidentally dropped in
https://github.com/llvm/llvm-project/pull/96249
rdar://140853882
>From 46775c380244e47ddd9a3188651f37c3a3b33d23 Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Tue, 3 Dec 2
@@ -25,3 +26,12 @@
// CHECK-ARM: cortex-a73
// CHECK-ARM: cortex-a75
// CHECK-ARM: Use -mcpu or -mtune to specify the target's processor.
+
+// RUN: %clang --target=arm64-apple-macosx --print-supported-cpus 2>&1 | \
+// RUN: FileCheck %s --check-prefix=CHECK-AARCH64
--implic
@@ -0,0 +1,14 @@
+// RUN: %clang %s -serialize-diagnostics %s.diag || true
jroelofs wrote:
```suggestion
// RUN: not %clang %s -serialize-diagnostics %s.diag
```
https://github.com/llvm/llvm-project/pull/118522
___
cfe
https://github.com/jroelofs approved this pull request.
The patch itself LGTM though, despite my gripes on the current prioritization
rule.
https://github.com/llvm/llvm-project/pull/118544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
@@ -1,3 +1,4 @@
+// REQUIRES: default-cxx-stdlib=libstdc++
jroelofs wrote:
I think it's fine. I'm not sure `REQUIRES` has a `!=`
https://github.com/llvm/llvm-project/pull/122145
___
cfe-commits mailing list
cfe-commits
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/121921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/122145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -243,6 +247,8 @@ std::unique_ptr AllocateTarget(const
llvm::Triple &Triple,
case llvm::Triple::thumbeb:
jroelofs wrote:
oh, I missed that we're already lumping `arm-none-macho` & friends under
`DarwinARMTargetInfo`.
https://github.com/llvm/llvm-project/p
https://github.com/jroelofs closed
https://github.com/llvm/llvm-project/pull/123827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs closed
https://github.com/llvm/llvm-project/pull/117243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/124266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs created
https://github.com/llvm/llvm-project/pull/124364
... pointing out the previous declaration.
>From 3a2d96d127a3c233f7352acb17ef4a3a6b0a0a0b Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Fri, 24 Jan 2025 15:01:18 -0800
Subject: [PATCH] [clang][Sema][FMV] Ad
https://github.com/jroelofs edited
https://github.com/llvm/llvm-project/pull/124364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs closed
https://github.com/llvm/llvm-project/pull/124364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs wrote:
cc @ian-twilightcoder
https://github.com/llvm/llvm-project/pull/117243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs wrote:
https://github.com/llvm/llvm-project/pull/123827
https://github.com/llvm/llvm-project/pull/123336
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs created
https://github.com/llvm/llvm-project/pull/123827
This commit addresses some uncertainty raised in
84fa1755a5b7845ddaeaa513a3786013c76c9c88 as to which features Apple M4 has.
>From 1a97bea824bd6a1595fba2fc394ba9469fc92f8b Mon Sep 17 00:00:00 2001
From: Jon Roe
@@ -243,6 +247,8 @@ std::unique_ptr AllocateTarget(const
llvm::Triple &Triple,
case llvm::Triple::thumbeb:
jroelofs wrote:
github won't let me add a comment in the right spot, but I think we need:
```
case llvm::Triple::arm:
case llvm::Triple::thumb:
@@ -2763,9 +2764,10 @@ bool
CodeGenModule::GetCPUAndFeaturesAttributes(GlobalDecl GD,
Attrs.addAttribute("fmv-features");
AddedAttr = true;
} else if (!Feats.empty()) {
- llvm::sort(Feats);
+ // Sort features and remove duplicates.
+ std::set Ord
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/122427
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2763,9 +2764,10 @@ bool
CodeGenModule::GetCPUAndFeaturesAttributes(GlobalDecl GD,
Attrs.addAttribute("fmv-features");
AddedAttr = true;
} else if (!Feats.empty()) {
- llvm::sort(Feats);
+ // Sort features and remove duplicates.
+ std::set Ord
jroelofs wrote:
also:
```
clang/lib/Driver/ToolChains/SYCL.h:27:17: warning: private field 'D' is not
used [-Wunused-private-field]
```
https://github.com/llvm/llvm-project/pull/117268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
jroelofs wrote:
> Hi @jroelofs @DanielKristofKiss. I am not sure how to detect on other
> platforms. Suggestions for apple and windows welcome.
The place to look for feature tests on Apple platforms is here:
https://github.com/apple-oss-distributions/xnu/blob/main/osfmk/arm/cpu_capabilities_pu
@@ -33,7 +33,7 @@ enum CPUFeatures {
FEAT_FP,
FEAT_SIMD,
FEAT_CRC,
- RESERVED_FEAT_SHA1, // previously used and now ABI legacy
+ FEAT_CSSC,
jroelofs wrote:
Is re-using this index okay re: the ABI legacy thing?
https://github.com/llvm/llvm-project/pull
jroelofs wrote:
Correct, and that's fine: nothing we've previously shipped supports FEAT_CSSC.
https://github.com/llvm/llvm-project/pull/132727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/132727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs wrote:
Looks mechanically okay, but I need to defer to Ahmed on whether you're missing
other bits that go along with this. He's around, just need to be patient ;)
https://github.com/llvm/llvm-project/pull/132834
___
cfe-commits mailing list
c
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/138677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/127152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
401 - 498 of 498 matches
Mail list logo
