[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. Hmm, there recently were quite some changes in the MultiArch and GCC search path functionality in the Driver and I can unfortunately no longer get it to work on x32. I had a relatively simple approach but I cannot get it to add the path for the crt.o objects and so on

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz marked an inline comment as done. glaubitz added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz marked an inline comment as done. glaubitz added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:90 return "x86_64-linux-android"; -// We don't want this for x32, otherwise it will match x86_64 libs -if (TargetEnvironment != llvm::Triple::GNUX32 && -D.getVFS().exists(SysR

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz updated this revision to Diff 334071. glaubitz retitled this revision from "[Driver] Fix architecture triplets and search paths for Linux x32" to "WIP: [Driver] Fix architecture triplets and search paths for Linux x32". glaubitz added a comment. Updated version which unfortunately still

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2657952 , @hvdijk wrote: > I may be missing something, but I do not understand the problem. What > systems, other than Debian multi-arch, are you looking to also add support > for? My own native x32 system uses `(/usr)

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. In D98574#2654686 , @joerg wrote: > The NetBSD part looks ok, but also lacks proper testing. I'm not sure anyone > but Linux cares at all otherwise as they lack 32bit SPARC support. Well, there were no tests for NetBSD before, s

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2659654 , @hvdijk wrote: > I am testing the below, on top of c8e56f394af0b9e32c413d62a0e7aebbba3e6b70 > , both > in a Debian chroot and in my non-Deb

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2660022 , @hvdijk wrote: > I think the problem is actually the other thing covered before (don't provide > un-normalised triples as cmake arguments), though the wrong detection of > LLVM_HOST_TRIPLE will cause other is

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2662440 , @hvdijk wrote: > In D52050#2662372 , @MaskRay wrote: > >> Mostly looks good. >> >>> `clang/test/Driver/Inputs/basic_cross_linux_tree/usr/lib/gcc/x86_64-unknown-linux-gnu

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2110 + static const char *const X32Triples[] = {"x86_64-linux-gnux32", + "x86_64-unknown-linux-gnux32", + "x86_64-p

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2662656 , @hvdijk wrote: > I have also updated the summary to provide a more complete explanation of the > changes, and hope the revised summary will answer @MaskRay's questions. In D52050#2662648

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2663247 , @hvdijk wrote: > In D52050#2663205 , @glaubitz wrote: > >> I think, however, we should bump the rest of the paths to 10.2.0 if possible. > > I updated all the Linux tree

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. Thanks, this finally fixes the build for me. I wasn't aware that there was a `getArchNameForCompilerRTLib()` function in clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100148/new/ https://reviews.llvm.org/D100148 _

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added inline comments. Comment at: clang/test/Driver/sanitizer-ld.c:309 // CHECK-UBSAN-LINUX: "-lpthread" // RUN: %clang -fsanitize=undefined -fno-sanitize-link-runtime %s -### -o %t.o 2>&1 \ Do we need want to run the test for i386 anymore? Repos

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added inline comments. Comment at: clang/test/Driver/sanitizer-ld.c:309 // CHECK-UBSAN-LINUX: "-lpthread" // RUN: %clang -fsanitize=undefined -fno-sanitize-link-runtime %s -### -o %t.o 2>&1 \ glaubitz wrote: > Do we need want to run the test for i38

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz accepted this revision. glaubitz added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/sanitizer-ld.c:309 // CHECK-UBSAN-LINUX: "-lpthread" // RUN: %clang -fsanitize=undefined -fno-sanitize-link-runtime %s -### -o %t.o

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. So, we only need D99988 and this one (D100148 ) now and the LLVM package will finally build on Debian without any additional tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. Hi! Can we get this patch merged as-is or do we need anything else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100148/new/ https://reviews.llvm.org/D100148 ___ cfe-commits ma

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. In D100148#2683710 , @hvdijk wrote: > In D100148#2683325 , @glaubitz > wrote: > >> Hi! Can we get this patch merged as-is or do we need anything else? > > Sorry, miscommunication. I was

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. @hvdijk I just noticed that the sanitizer defines `SANITIZER_X32` for x32, so I assume your patch itself is already correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100148/new/ https://reviews.llvm.org/D100148

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2468424 , @jrtc27 wrote: >> However, that's not the same as whether we're on an x86_64 system or on an >> x32 system determines which GNU triplet to use and which include and library >> search paths are our primary one

[PATCH] D108792: [M68k] Update pointer data layout

glaubitz added a comment. @ricky26 Could you also get this fix backported in the LLVM fork of Rust? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108792/new/ https://reviews.llvm.org/D108792 ___ cfe-comm

<    1   2