https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/109656
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/109004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jayfoad wrote:
+1 to @efriedma-quic and @jdoerfert's comments. DataLayout should remain as
generic as possible. Trying to encode a concept of "_the_ flat address space"
in it seems way too specific to one optimization for one or two targets.
https://github.com/llvm/llvm-project/pull/108786
___
jayfoad wrote:
This is mostly so that we don't need to carry this change downstream, while we
have downstream patches that add a few builtin types. It seems inevitable that
it will need to be changed upstream pretty soon anyway.
https://github.com/llvm/llvm-project/pull/113559
https://github.com/jayfoad updated
https://github.com/llvm/llvm-project/pull/99016
>From c2eda0aaeeaf9c8711cf64830df9bb3fee842f80 Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Tue, 16 Jul 2024 11:29:05 +0100
Subject: [PATCH 1/5] [IR] Add TargetExtType::CanBeAlloca property
Add a property to al
@@ -838,12 +838,14 @@ static TargetTypeInfo getTargetTypeInfo(const
TargetExtType *Ty) {
return TargetTypeInfo(PointerType::get(C, 0), TargetExtType::CanBeGlobal);
jayfoad wrote:
I'm now using the newly added `amdgcn.named.barrier` for testing.
https://git
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/99016
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jayfoad updated
https://github.com/llvm/llvm-project/pull/99016
>From c2eda0aaeeaf9c8711cf64830df9bb3fee842f80 Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Tue, 16 Jul 2024 11:29:05 +0100
Subject: [PATCH 1/4] [IR] Add TargetExtType::CanBeAlloca property
Add a property to al
@@ -146,6 +146,11 @@ define amdgpu_kernel void @test_kernel() {
; RUN: llc -mtriple=amdgcn-amd-amdhsa --amdhsa-code-object-version=6
-mcpu=gfx9-generic -filetype=obj -O0 -o %t.o %s
; RUN: llvm-objdump -D --arch-name=amdgcn -mllvm
--amdhsa-code-object-version=6 --mcpu=gfx9-gene
@@ -1617,6 +1617,7 @@ const EnumEntry ElfHeaderMipsFlags[] = {
ENUM_ENT(EF_AMDGPU_MACH_AMDGCN_GFX90A, "gfx90a"),
\
ENUM_ENT(EF_AMDGPU_MACH_AMDGCN_GFX90C, "gfx90c"),
\
ENUM_ENT(EF_AMDGPU_MACH_AMDGCN_GFX940, "gfx940"),
https://github.com/jayfoad created
https://github.com/llvm/llvm-project/pull/108968
Remove the MangledName field since these types just use the normal Name
for mangling purposes.
>From 97fc6c239af3cadb61fe70cd07bb3b31c5da7a52 Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Tue, 17 Sep 2024 12:5
https://github.com/jayfoad created
https://github.com/llvm/llvm-project/pull/108970
None
>From 9c2e1d8470b7b1a0647baece8fa41cf8ce7b4f5d Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Tue, 17 Sep 2024 13:28:11 +0100
Subject: [PATCH] [Clang] Add and use mangleVendorType helper. NFC.
---
clang/l
@@ -4778,6 +4782,8 @@ bool Type::canHaveNullability(bool ResultIfUnknown) const
{
#include "clang/Basic/RISCVVTypes.def"
#define WASM_TYPE(Name, Id, SingletonId) case BuiltinType::Id:
#include "clang/Basic/WebAssemblyReferenceTypes.def"
+#define AMDGPU_TYPE(Name, Id, Singleton
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/108968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jayfoad created
https://github.com/llvm/llvm-project/pull/109004
Tweak encodeTypeForFunctionPointerAuth to handle all AMDGPU builtin
types generically instead of just __amdgpu_buffer_rsrc_t which happens
to be the only one defined so far.
>From c79c60d4488e7ddd1d8a2f0e141847
jayfoad wrote:
> Use TargetInfo when deciding is an address space is compatible
Typo? "Use TargetInfo when deciding *if* an address space is compatible"
https://github.com/llvm/llvm-project/pull/115777
___
cfe-commits mailing list
cfe-commits@lists.ll
https://github.com/jayfoad approved this pull request.
https://github.com/llvm/llvm-project/pull/121736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jayfoad commented:
No objections, just a couple of ideas for improvements. I have no idea if
`ParentMap` lookups are on any kind of hot path.
https://github.com/llvm/llvm-project/pull/121736
___
cfe-commits mailing list
cfe-commits@
https://github.com/jayfoad edited
https://github.com/llvm/llvm-project/pull/121736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -34,13 +34,13 @@ static void BuildParentMap(MapTy& M, Stmt* S,
case Stmt::PseudoObjectExprClass: {
PseudoObjectExpr *POE = cast(S);
-if (OVMode == OV_Opaque && M[POE->getSyntacticForm()])
+if (OVMode == OV_Opaque && M.contains(POE->getSyntacticForm()))
---
@@ -78,7 +78,7 @@ static void BuildParentMap(MapTy& M, Stmt* S,
// The right thing to do is to give the OpaqueValueExpr its syntactic
// parent, then not reassign that when traversing the semantic expressions.
OpaqueValueExpr *OVE = cast(S);
-if (OVMode == OV_Tr
https://github.com/jayfoad approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/124616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jayfoad created
https://github.com/llvm/llvm-project/pull/124929
None
>From 03ea8ad4f2a7b6589539dbc137c356455225fc15 Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Wed, 29 Jan 2025 14:49:05 +
Subject: [PATCH] Fix typo "tranpose"
---
clang/lib/Headers/amxtf32transposeint
jayfoad wrote:
Ping. This is ready again for review.
https://github.com/llvm/llvm-project/pull/99016
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -228,6 +228,8 @@ class StructType : public Type {
SCDB_NotContainsScalableVector = 32,
SCDB_ContainsNonGlobalTargetExtType = 64,
SCDB_NotContainsNonGlobalTargetExtType = 128,
+SCDB_ContainsNonLocalTargetExtType = 64,
+SCDB_NotContainsNonLocalTargetExtType
@@ -4285,6 +4291,12 @@ void Verifier::visitAllocaInst(AllocaInst &AI) {
SmallPtrSet Visited;
Check(AI.getAllocatedType()->isSized(&Visited),
"Cannot allocate unsized type", &AI);
+ // Check if it's a target extension type that disallows being used on the
+ // stac
@@ -1630,9 +1630,9 @@ class Record {
SmallVector Assertions;
SmallVector Dumps;
- // All superclasses in the inheritance forest in post-order (yes, it
+ // Direct superclasses, which are roots of the inheritance forest (yes, it
// must be a forest; diamond-shaped inhe
https://github.com/jayfoad updated
https://github.com/llvm/llvm-project/pull/123072
>From f12511a0fd30c47ea08e6c126cae558215758183 Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Wed, 15 Jan 2025 13:34:41 +
Subject: [PATCH 01/14] Change API of getSuperClasses
---
llvm/include/llvm/TableGen/
@@ -699,7 +699,8 @@ def DS_PERMUTE_B32 : DS_1A1D_PERMUTE <"ds_permute_b32",
int_amdgcn_ds_permute>;
def DS_BPERMUTE_B32 : DS_1A1D_PERMUTE <"ds_bpermute_b32",
int_amdgcn_ds_bpermute>;
-def DS_BPERMUTE
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/124929
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/122880
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jayfoad created
https://github.com/llvm/llvm-project/pull/122880
None
>From d9a92edae5d021eed39acbdb22fa195dff78315d Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Tue, 14 Jan 2025 10:00:41 +
Subject: [PATCH] [llvm-project] Fix typos mutli and mutliple. NFC.
---
.../cla
https://github.com/jayfoad updated
https://github.com/llvm/llvm-project/pull/123072
>From f12511a0fd30c47ea08e6c126cae558215758183 Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Wed, 15 Jan 2025 13:34:41 +
Subject: [PATCH 01/11] Change API of getSuperClasses
---
llvm/include/llvm/TableGen/
@@ -1718,15 +1719,30 @@ class Record {
ArrayRef getAssertions() const { return Assertions; }
ArrayRef getDumps() const { return Dumps; }
- ArrayRef> getSuperClasses() const {
-return SuperClasses;
+ /// Append all superclasses in post-order to \p Classes.
+ void get
https://github.com/jayfoad edited
https://github.com/llvm/llvm-project/pull/123072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jayfoad updated
https://github.com/llvm/llvm-project/pull/123072
>From f12511a0fd30c47ea08e6c126cae558215758183 Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Wed, 15 Jan 2025 13:34:41 +
Subject: [PATCH 01/13] Change API of getSuperClasses
---
llvm/include/llvm/TableGen/
jayfoad wrote:
> Waiting for clang/mlir changes
All done now.
https://github.com/llvm/llvm-project/pull/123072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jayfoad updated
https://github.com/llvm/llvm-project/pull/123072
>From f12511a0fd30c47ea08e6c126cae558215758183 Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Wed, 15 Jan 2025 13:34:41 +
Subject: [PATCH 01/13] Change API of getSuperClasses
---
llvm/include/llvm/TableGen/
https://github.com/jayfoad approved this pull request.
https://github.com/llvm/llvm-project/pull/122169
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -114,22 +114,23 @@ static Value *handleHlslClip(const CallExpr *E,
CodeGenFunction *CGF) {
CMP = CGF->Builder.CreateIntrinsic(
CGF->Builder.getInt1Ty(), CGF->CGM.getHLSLRuntime().getAnyIntrinsic(),
{FCompInst}, nullptr);
- } else
+ } else {
CMP =
https://github.com/jayfoad edited
https://github.com/llvm/llvm-project/pull/131942
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Juan Manuel Martinez =?utf-8?q?Caamaño?=
Message-ID:
In-Reply-To:
jayfoad wrote:
At the hardware level, GFX11 removed the ability for buffer, **scratch** and
**global** instructions to return directly to LDS. So can we use one attribute
that covers all three of those?
https://github.com/llv
https://github.com/jayfoad approved this pull request.
LGTM, seems like a nice (minor) cleanup.
https://github.com/llvm/llvm-project/pull/131942
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
https://github.com/jayfoad edited
https://github.com/llvm/llvm-project/pull/135036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1578,6 +1578,11 @@ class MovDPP8Pattern : GCNPat <
let OtherPredicates = [Pred];
}
+def : GCNPat <
jayfoad wrote:
Can you do this in the definition of V_CVT_OFF_F32_I4, instead of using a
separate Pat?
https://github.com/llvm/llvm-project/pull/133741
https://github.com/jayfoad created
https://github.com/llvm/llvm-project/pull/134616
This matches the spelling of the keyword in LLVM IR.
>From 66171b22b10cf5cded18899e06657b66e82a1e6b Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Mon, 7 Apr 2025 12:21:56 +0100
Subject: [PATCH] [Clang] Use "sy
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/134616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/134092
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jayfoad wrote:
> Please try not to create big PRs that are crossing subproject boundaries,
> you'll have a hard time finding a reviewer will to sign off of a patch that
> Rouches other parts of the project. 10 small/trivial PRs are less work for
> the reviewers than one big one.
Fair enough.
https://github.com/jayfoad created
https://github.com/llvm/llvm-project/pull/134092
None
>From 10ab02a61b5e2ec3f58a12c78e7b3b989a349a8f Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Wed, 2 Apr 2025 15:35:32 +0100
Subject: [PATCH] Fix typos: paramter, parametr, parametere
---
bolt/utils/bughu
jayfoad wrote:
> This PR adds a amdgns_load_to_lds intrinsic that abstracts over loads to LDS
> from global (address space 1) pointers and buffer fat pointers (address space
> 7), since they use the same API and "gather from a pointer to LDS" is
> something of an abstract operation.
High leve
jayfoad wrote:
> > High level question: I don't understand why you call this a "gather"
> > operation. What do you mean by that? Isn't it semantically just a memcpy,
> > or a (global/buffer) load followed by a (LDS) store?
>
> The semantics of this operation (at least in the pre-gfx950 cases)
https://github.com/jayfoad updated
https://github.com/llvm/llvm-project/pull/123072
>From f12511a0fd30c47ea08e6c126cae558215758183 Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Wed, 15 Jan 2025 13:34:41 +
Subject: [PATCH 01/16] Change API of getSuperClasses
---
llvm/include/llvm/TableGen/
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/123072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jayfoad wrote:
> reverse-ping - what's the plan for this please?
To forget about it :) I think it's good to go now.
https://github.com/llvm/llvm-project/pull/123072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
jayfoad wrote:
> I still think we need an intrinsic here because a load + an addtid store can
> be scheduled much different from the asynchronous "gather to LDS" - and
> because we don't want this load/store to not be optimized
IMO the intrinsic should only be added as a last resort if we real
@@ -2641,6 +2641,28 @@ def int_amdgcn_perm :
// GFX9 Intrinsics
//===--===//
+/// This is a general-purpose intrinsic for all operations that take a pointer
+/// a base location in LDS, and a data size and us
@@ -59,22 +59,42 @@ namespace llvm {
~ScopedFatalErrorHandler() { remove_fatal_error_handler(); }
};
-/// Reports a serious error, calling any installed error handler. These
-/// functions are intended to be used for error conditions which are outside
-/// the control of
@@ -2981,7 +2981,7 @@ ScalarEvolution::getOrCreateAddExpr(ArrayRef Ops,
static_cast(UniqueSCEVs.FindNodeOrInsertPos(ID, IP));
if (!S) {
const SCEV **O = SCEVAllocator.Allocate(Ops.size());
-std::uninitialized_copy(Ops.begin(), Ops.end(), O);
+llvm::uninitial
@@ -2641,6 +2641,28 @@ def int_amdgcn_perm :
// GFX9 Intrinsics
//===--===//
+/// This is a general-purpose intrinsic for all operations that take a pointer
+/// a base location in LDS, and a data size and us
jayfoad wrote:
Thanks for doing this. I like it. Definitely an improvement on the status quo.
I would be tempted to go further, and replace all uses of `report_fatal_error`.
https://github.com/llvm/llvm-project/pull/138251
___
cfe-commits mailing list
https://github.com/jayfoad approved this pull request.
https://github.com/llvm/llvm-project/pull/138251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
201 - 262 of 262 matches
Mail list logo
