[clang] be795ee - [clang][deps] Allow switching between lazily/eagerly loaded PCMs

Author: Jan Svoboda Date: 2022-08-22T18:22:27-07:00 New Revision: be795ee16a7f8dba9210c26efaa6f75dc8608e1d URL: https://github.com/llvm/llvm-project/commit/be795ee16a7f8dba9210c26efaa6f75dc8608e1d DIFF: https://github.com/llvm/llvm-project/commit/be795ee16a7f8dba9210c26efaa6f75dc8608e1d.diff L

[clang] 002bfdd - [clang][modules] Track affecting modules

Author: Jan Svoboda Date: 2022-08-24T11:09:50-07:00 New Revision: 002bfdd6b119e3543415971fbb219768fd96f86f URL: https://github.com/llvm/llvm-project/commit/002bfdd6b119e3543415971fbb219768fd96f86f DIFF: https://github.com/llvm/llvm-project/commit/002bfdd6b119e3543415971fbb219768fd96f86f.diff L

[clang] 94e64df - [clang][modules] Consider M affecting after mapping M.Private to M_Private

Author: Jan Svoboda Date: 2022-08-24T14:36:06-07:00 New Revision: 94e64df5763b49d750a9a87ecdd4a6583ad6154f URL: https://github.com/llvm/llvm-project/commit/94e64df5763b49d750a9a87ecdd4a6583ad6154f DIFF: https://github.com/llvm/llvm-project/commit/94e64df5763b49d750a9a87ecdd4a6583ad6154f.diff L

[clang] 4e637fc - [clang][deps] Make sure ScanInstance outlives collector

Author: Jan Svoboda Date: 2022-09-16T09:44:12-07:00 New Revision: 4e637fcb25503cc9b3bb9af54453ac2ebc7299b1 URL: https://github.com/llvm/llvm-project/commit/4e637fcb25503cc9b3bb9af54453ac2ebc7299b1 DIFF: https://github.com/llvm/llvm-project/commit/4e637fcb25503cc9b3bb9af54453ac2ebc7299b1.diff L

[clang] 9dc0b16 - [clang][deps] Report module map describing compiled module

Author: Jan Svoboda Date: 2022-09-22T12:06:02-07:00 New Revision: 9dc0b1674841243110f95cdc9c9d97bcf30c1544 URL: https://github.com/llvm/llvm-project/commit/9dc0b1674841243110f95cdc9c9d97bcf30c1544 DIFF: https://github.com/llvm/llvm-project/commit/9dc0b1674841243110f95cdc9c9d97bcf30c1544.diff L

[clang] f35230a - [clang][modules][deps] Report modulemaps describing excluded headers

Author: Jan Svoboda Date: 2022-09-22T12:36:05-07:00 New Revision: f35230ae0a69bbdd74a4faa3ae0b69a46796dc12 URL: https://github.com/llvm/llvm-project/commit/f35230ae0a69bbdd74a4faa3ae0b69a46796dc12 DIFF: https://github.com/llvm/llvm-project/commit/f35230ae0a69bbdd74a4faa3ae0b69a46796dc12.diff L

[clang] 20fa87c - [clang][modules][deps] Preserve module map load order

Author: Jan Svoboda Date: 2022-09-22T12:54:51-07:00 New Revision: 20fa87c7e87fcb2fca403c7a73f8acc7e4dd5fa1 URL: https://github.com/llvm/llvm-project/commit/20fa87c7e87fcb2fca403c7a73f8acc7e4dd5fa1 DIFF: https://github.com/llvm/llvm-project/commit/20fa87c7e87fcb2fca403c7a73f8acc7e4dd5fa1.diff L

[clang] 715bd12 - [clang][modules] Over-align the `Module` class

Author: Jan Svoboda Date: 2022-09-26T10:55:22-07:00 New Revision: 715bd12d2e1d4373b58ce515a6e2923d9b617226 URL: https://github.com/llvm/llvm-project/commit/715bd12d2e1d4373b58ce515a6e2923d9b617226 DIFF: https://github.com/llvm/llvm-project/commit/715bd12d2e1d4373b58ce515a6e2923d9b617226.diff L

[clang] 8df1f3b - [clang][deps] Fix test on AIX

Author: Jan Svoboda Date: 2022-09-26T12:40:28-07:00 New Revision: 8df1f3bc19d7b37c9be6ce32564c9b8fd73d2aa3 URL: https://github.com/llvm/llvm-project/commit/8df1f3bc19d7b37c9be6ce32564c9b8fd73d2aa3 DIFF: https://github.com/llvm/llvm-project/commit/8df1f3bc19d7b37c9be6ce32564c9b8fd73d2aa3.diff L

[clang] 29e0435 - [libclang] Split-out parts of `Index.h`

Author: Jan Svoboda Date: 2022-09-29T11:29:53-07:00 New Revision: 29e0435ac04957861aa1f85d41291c8b19db0122 URL: https://github.com/llvm/llvm-project/commit/29e0435ac04957861aa1f85d41291c8b19db0122 DIFF: https://github.com/llvm/llvm-project/commit/29e0435ac04957861aa1f85d41291c8b19db0122.diff L

[clang] 1392126 - [clang][deps] NFC: Expose more flexible version of `Worker::computeDependencies()`

Author: Jan Svoboda Date: 2022-09-29T11:29:53-07:00 New Revision: 13921262cae0e7346e41875c1850d8861be0488e URL: https://github.com/llvm/llvm-project/commit/13921262cae0e7346e41875c1850d8861be0488e DIFF: https://github.com/llvm/llvm-project/commit/13921262cae0e7346e41875c1850d8861be0488e.diff L

[clang] b00de4d - [clang][deps] Abolish FileManager sharing

Author: Jan Svoboda Date: 2022-10-04T12:47:22-07:00 New Revision: b00de4dd4156874fd5c163e9cecd69a54e45e083 URL: https://github.com/llvm/llvm-project/commit/b00de4dd4156874fd5c163e9cecd69a54e45e083 DIFF: https://github.com/llvm/llvm-project/commit/b00de4dd4156874fd5c163e9cecd69a54e45e083.diff L

[clang] fb137ad - [clang][deps] NFC: Respect working directory on construction

Author: Jan Svoboda Date: 2022-10-04T12:47:22-07:00 New Revision: fb137adc9b3fa47989fac5cb8a346f0a3a2733bd URL: https://github.com/llvm/llvm-project/commit/fb137adc9b3fa47989fac5cb8a346f0a3a2733bd DIFF: https://github.com/llvm/llvm-project/commit/fb137adc9b3fa47989fac5cb8a346f0a3a2733bd.diff L

[clang] 5865476 - [clang][modules] Fix handling of `ModuleHeaderRole::ExcludedHeader`

Author: Jan Svoboda Date: 2022-10-06T16:20:24-07:00 New Revision: 586547687946b27a99d3bb4241226f9f126a173e URL: https://github.com/llvm/llvm-project/commit/586547687946b27a99d3bb4241226f9f126a173e DIFF: https://github.com/llvm/llvm-project/commit/586547687946b27a99d3bb4241226f9f126a173e.diff L

[clang] 060b253 - [clang][deps] Remove more codegen options

Author: Jan Svoboda Date: 2022-10-11T15:57:19-07:00 New Revision: 060b25346b95cc161d21418f31c333f9a115d77e URL: https://github.com/llvm/llvm-project/commit/060b25346b95cc161d21418f31c333f9a115d77e DIFF: https://github.com/llvm/llvm-project/commit/060b25346b95cc161d21418f31c333f9a115d77e.diff L

[clang] c1c7230 - [clang][deps] Prevent emitting diagnostics outside of source file

Author: Jan Svoboda Date: 2022-10-11T15:57:20-07:00 New Revision: c1c72302fe4553a39be37b5c310d046975e55019 URL: https://github.com/llvm/llvm-project/commit/c1c72302fe4553a39be37b5c310d046975e55019 DIFF: https://github.com/llvm/llvm-project/commit/c1c72302fe4553a39be37b5c310d046975e55019.diff L

[clang] 9867259 - [clang][deps] Don't share in-memory VFS across scans

Author: Jan Svoboda Date: 2022-10-12T18:40:34-07:00 New Revision: 98672596626862e4b21319da7c01737bf7e20ae4 URL: https://github.com/llvm/llvm-project/commit/98672596626862e4b21319da7c01737bf7e20ae4 DIFF: https://github.com/llvm/llvm-project/commit/98672596626862e4b21319da7c01737bf7e20ae4.diff L

[clang] 888daa9 - [clang][deps] Respect VFS overlays in canonical preprocessing mode

Author: Jan Svoboda Date: 2022-10-12T18:40:34-07:00 New Revision: 888daa9e83bceb6cb8fda02f5f3719391f717154 URL: https://github.com/llvm/llvm-project/commit/888daa9e83bceb6cb8fda02f5f3719391f717154 DIFF: https://github.com/llvm/llvm-project/commit/888daa9e83bceb6cb8fda02f5f3719391f717154.diff L

[clang] 6dda497 - [clang][modules] NFC: Remove unused lambda argument

Author: Jan Svoboda Date: 2022-11-01T16:58:11-07:00 New Revision: 6dda49794209e20514c58ead74fb105ff8bc6e4b URL: https://github.com/llvm/llvm-project/commit/6dda49794209e20514c58ead74fb105ff8bc6e4b DIFF: https://github.com/llvm/llvm-project/commit/6dda49794209e20514c58ead74fb105ff8bc6e4b.diff L

[clang] fdbc55a - [clang][modules] NFCI: Unify FileID writing/reading

Author: Jan Svoboda Date: 2022-11-01T18:57:13-07:00 New Revision: fdbc55a51a792c65d4a1fd1f5d8e6ab19e0187d2 URL: https://github.com/llvm/llvm-project/commit/fdbc55a51a792c65d4a1fd1f5d8e6ab19e0187d2 DIFF: https://github.com/llvm/llvm-project/commit/fdbc55a51a792c65d4a1fd1f5d8e6ab19e0187d2.diff L

[clang] f61c135 - [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

Author: Jan Svoboda Date: 2022-11-01T18:59:17-07:00 New Revision: f61c135a69084e470b73c26a8134785808ee246f URL: https://github.com/llvm/llvm-project/commit/f61c135a69084e470b73c26a8134785808ee246f DIFF: https://github.com/llvm/llvm-project/commit/f61c135a69084e470b73c26a8134785808ee246f.diff L

[clang] 0bfc97e - [clang][modules] NFCI: Scaffolding for serialization of adjusted SourceManager offsets

Author: Jan Svoboda Date: 2022-11-01T19:06:55-07:00 New Revision: 0bfc97e4f4eb352f8e080872df8fdca51147683c URL: https://github.com/llvm/llvm-project/commit/0bfc97e4f4eb352f8e080872df8fdca51147683c DIFF: https://github.com/llvm/llvm-project/commit/0bfc97e4f4eb352f8e080872df8fdca51147683c.diff L

[clang] 9ae6e6a - [clang] NFC: Extract lower-level SourceManager functions

Author: Jan Svoboda Date: 2022-11-01T19:11:24-07:00 New Revision: 9ae6e6a50273abd683f61b017a4d4c34a964c703 URL: https://github.com/llvm/llvm-project/commit/9ae6e6a50273abd683f61b017a4d4c34a964c703 DIFF: https://github.com/llvm/llvm-project/commit/9ae6e6a50273abd683f61b017a4d4c34a964c703.diff L

[clang] a13122c - [clang][modules] NFCI: Avoid unnecessary serialization logic for non-affecting files

Author: Jan Svoboda Date: 2022-11-01T19:23:02-07:00 New Revision: a13122c612a653026b2ac220e220c50783c3aa82 URL: https://github.com/llvm/llvm-project/commit/a13122c612a653026b2ac220e220c50783c3aa82 DIFF: https://github.com/llvm/llvm-project/commit/a13122c612a653026b2ac220e220c50783c3aa82.diff L

[clang] 6924a49 - [clang][modules] Account for non-affecting inputs in `ASTWriter`

Author: Jan Svoboda Date: 2022-11-01T19:31:51-07:00 New Revision: 6924a49690eee074f6c341d3ada4e98d640b8a7e URL: https://github.com/llvm/llvm-project/commit/6924a49690eee074f6c341d3ada4e98d640b8a7e DIFF: https://github.com/llvm/llvm-project/commit/6924a49690eee074f6c341d3ada4e98d640b8a7e.diff L

[clang] f33173a - [clang][modules][deps] System module maps might not be affecting

Author: Jan Svoboda Date: 2022-11-01T22:41:40-07:00 New Revision: f33173acd6875fa86448bb6d91bdac8f1296510a URL: https://github.com/llvm/llvm-project/commit/f33173acd6875fa86448bb6d91bdac8f1296510a DIFF: https://github.com/llvm/llvm-project/commit/f33173acd6875fa86448bb6d91bdac8f1296510a.diff L

[clang] 96a54b2 - [clang][deps] Account for transitive spurious dependencies

Author: Jan Svoboda Date: 2023-01-24T09:48:58-08:00 New Revision: 96a54b2258cddcb52f8c98e760b9b114a1aa4034 URL: https://github.com/llvm/llvm-project/commit/96a54b2258cddcb52f8c98e760b9b114a1aa4034 DIFF: https://github.com/llvm/llvm-project/commit/96a54b2258cddcb52f8c98e760b9b114a1aa4034.diff L

[clang] beebad9 - [clang][deps] NFC: Remove dead code

Author: Jan Svoboda Date: 2023-01-24T09:49:22-08:00 New Revision: beebad9a9b230d9c491e7e09a892689dc23240aa URL: https://github.com/llvm/llvm-project/commit/beebad9a9b230d9c491e7e09a892689dc23240aa DIFF: https://github.com/llvm/llvm-project/commit/beebad9a9b230d9c491e7e09a892689dc23240aa.diff L

[clang] e60fcfd - [clang][deps] Remove support for the deprecated driver API

Author: Jan Svoboda Date: 2023-02-01T13:46:26-08:00 New Revision: e60fcfd6e568d1471e40e6e8a14070ef126cdf4a URL: https://github.com/llvm/llvm-project/commit/e60fcfd6e568d1471e40e6e8a14070ef126cdf4a DIFF: https://github.com/llvm/llvm-project/commit/e60fcfd6e568d1471e40e6e8a14070ef126cdf4a.diff L

[clang] ba55666 - [clang][deps] NFC: Split out the module-based API from the TU-based API

Author: Jan Svoboda Date: 2023-02-01T13:46:26-08:00 New Revision: ba556660fe52a558c34556866aba4a0bb8bbbd23 URL: https://github.com/llvm/llvm-project/commit/ba556660fe52a558c34556866aba4a0bb8bbbd23 DIFF: https://github.com/llvm/llvm-project/commit/ba556660fe52a558c34556866aba4a0bb8bbbd23.diff L

[clang] 8e9f62e - [clang][deps] Give the fake file a unique name in by-module-name scans

Author: Jan Svoboda Date: 2023-02-01T13:46:26-08:00 New Revision: 8e9f62e5f833cb89b57bf4c9e80e850bcac7e15e URL: https://github.com/llvm/llvm-project/commit/8e9f62e5f833cb89b57bf4c9e80e850bcac7e15e DIFF: https://github.com/llvm/llvm-project/commit/8e9f62e5f833cb89b57bf4c9e80e850bcac7e15e.diff L

[clang] 06be346 - [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

Author: Erik Desjardins Date: 2023-02-01T13:54:09-08:00 New Revision: 06be346311b9341d3d11120a631263de863f937c URL: https://github.com/llvm/llvm-project/commit/06be346311b9341d3d11120a631263de863f937c DIFF: https://github.com/llvm/llvm-project/commit/06be346311b9341d3d11120a631263de863f937c.dif

[clang] 347028a - [clang] Report the on-disk paths for inputs to module compiles

Author: Jan Svoboda Date: 2023-01-13T18:38:11-08:00 New Revision: 347028a4d8da8aa1ae311c95424999fcd31d98cb URL: https://github.com/llvm/llvm-project/commit/347028a4d8da8aa1ae311c95424999fcd31d98cb DIFF: https://github.com/llvm/llvm-project/commit/347028a4d8da8aa1ae311c95424999fcd31d98cb.diff L

[clang] c3efd52 - [clang][modules] Disallow importing private framework in the implementation

Author: Jan Svoboda Date: 2023-01-20T13:37:36-08:00 New Revision: c3efd52770ca964ba46287298c1d2f7697fd446c URL: https://github.com/llvm/llvm-project/commit/c3efd52770ca964ba46287298c1d2f7697fd446c DIFF: https://github.com/llvm/llvm-project/commit/c3efd52770ca964ba46287298c1d2f7697fd446c.diff L

[clang] c12577c - [clang][driver] Introduce new -fdriver-only flag

Author: Jan Svoboda Date: 2022-06-13T13:30:56+02:00 New Revision: c12577c61dbf37b1b6ae25ed422a900ac71f18fe URL: https://github.com/llvm/llvm-project/commit/c12577c61dbf37b1b6ae25ed422a900ac71f18fe DIFF: https://github.com/llvm/llvm-project/commit/c12577c61dbf37b1b6ae25ed422a900ac71f18fe.diff L

[clang] a856700 - [clang][driver] Fix compilation database dump with multiple architectures

Author: Jan Svoboda Date: 2022-06-13T13:30:57+02:00 New Revision: a85670001ba2487988839656299771915ebc7633 URL: https://github.com/llvm/llvm-project/commit/a85670001ba2487988839656299771915ebc7633 DIFF: https://github.com/llvm/llvm-project/commit/a85670001ba2487988839656299771915ebc7633.diff L

[clang] 2de36d0 - [clang][driver] Only run multi-arch tests on Darwin

Author: Jan Svoboda Date: 2022-06-13T14:03:23+02:00 New Revision: 2de36d0369a5107a3f02aceebb55326adf4ad2cb URL: https://github.com/llvm/llvm-project/commit/2de36d0369a5107a3f02aceebb55326adf4ad2cb DIFF: https://github.com/llvm/llvm-project/commit/2de36d0369a5107a3f02aceebb55326adf4ad2cb.diff L

[clang] d9390b6 - Reapply "[clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()"

Author: Jan Svoboda Date: 2022-06-13T17:03:32+02:00 New Revision: d9390b6ac387345e7d3348bfc648929bc349d6b1 URL: https://github.com/llvm/llvm-project/commit/d9390b6ac387345e7d3348bfc648929bc349d6b1 DIFF: https://github.com/llvm/llvm-project/commit/d9390b6ac387345e7d3348bfc648929bc349d6b1.diff L

[clang] 92c6ffa - [clang][driver] Ensure we don't accumulate entries in -MJ files

Author: Jan Svoboda Date: 2022-06-18T00:00:43+02:00 New Revision: 92c6ffa14cdeb3edd50b46d30c830698705db9f5 URL: https://github.com/llvm/llvm-project/commit/92c6ffa14cdeb3edd50b46d30c830698705db9f5 DIFF: https://github.com/llvm/llvm-project/commit/92c6ffa14cdeb3edd50b46d30c830698705db9f5.diff L

[clang] b02d970 - [clang][sema] Generate builtin operator overloads for (volatile) _Atomic types

Author: Jan Svoboda Date: 2022-06-20T11:03:29+02:00 New Revision: b02d970b4335561940dd584f6e6497ab684c788d URL: https://github.com/llvm/llvm-project/commit/b02d970b4335561940dd584f6e6497ab684c788d DIFF: https://github.com/llvm/llvm-project/commit/b02d970b4335561940dd584f6e6497ab684c788d.diff L

[clang] 9ec7e4d - [clang][driver] NFC, test: Make test output order-independent

Author: Jan Svoboda Date: 2022-06-23T17:15:28+02:00 New Revision: 9ec7e4df57f3716018cc0ef60c5d37c8cf6a7cbc URL: https://github.com/llvm/llvm-project/commit/9ec7e4df57f3716018cc0ef60c5d37c8cf6a7cbc DIFF: https://github.com/llvm/llvm-project/commit/9ec7e4df57f3716018cc0ef60c5d37c8cf6a7cbc.diff L

[clang] [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (PR #66122)

@@ -215,44 +225,63 @@ DependencyScanningWorkerFilesystem::findEntryByFilenameWithWriteThrough( } llvm::ErrorOr -DependencyScanningWorkerFilesystem::computeAndStoreResult(StringRef Filename) { - llvm::ErrorOr Stat = getUnderlyingFS().status(Filename); +DependencyScanningWorke

[clang] [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (PR #66122)

@@ -215,44 +225,57 @@ DependencyScanningWorkerFilesystem::findEntryByFilenameWithWriteThrough( } llvm::ErrorOr -DependencyScanningWorkerFilesystem::computeAndStoreResult(StringRef Filename) { - llvm::ErrorOr Stat = getUnderlyingFS().status(Filename); +DependencyScanningWorke

[clang] [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (PR #66122)

@@ -330,3 +353,20 @@ DependencyScanningWorkerFilesystem::openFileForRead(const Twine &Path) { return Result.getError(); return DepScanFile::create(Result.get()); } + +std::error_code DependencyScanningWorkerFilesystem::setCurrentWorkingDirectory( +const Twine &Path)

[clang] [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (PR #66122)

https://github.com/jansvoboda11 resolved https://github.com/llvm/llvm-project/pull/66122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (PR #66122)

https://github.com/jansvoboda11 resolved https://github.com/llvm/llvm-project/pull/66122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (PR #66122)

https://github.com/jansvoboda11 resolved https://github.com/llvm/llvm-project/pull/66122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (PR #66122)

https://github.com/jansvoboda11 approved this pull request. https://github.com/llvm/llvm-project/pull/66122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] c03d184 - [clang] NFCI: Use `FileEntryRef` in `PreamblePatch`

Author: Jan Svoboda Date: 2023-09-20T16:10:18-07:00 New Revision: c03d18441c94a69c0b32a7882a66c8cc95c6e928 URL: https://github.com/llvm/llvm-project/commit/c03d18441c94a69c0b32a7882a66c8cc95c6e928 DIFF: https://github.com/llvm/llvm-project/commit/c03d18441c94a69c0b32a7882a66c8cc95c6e928.diff L

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/66962 This commit removes the list of SLocEntry offsets to preload eagerly from PCM files. Commit introducing this functionality (258ae54a) doesn't clarify why this would be more performant than the lazy approach

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/66966 In `getFileID()` the `SourceManager` ends up doing a binary search over its buffer of `SLocEntries`. For modules, this binary search fully deserializes the entire `SLocEntry` block for visited each entry. T

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

jansvoboda11 wrote: Marking as draft for now. We still need to cache the lightweight offset deserialization. While this patch speeds up the dependency scanner as it stands, implicit modules compile slows down by 50%. https://github.com/llvm/llvm-project/pull/66966 _

[clang-tools-extra] 3de1e30 - [clang] NFCI: Use `FileEntryRef` in `SymbolCollector`

Author: Jan Svoboda Date: 2023-09-20T18:41:25-07:00 New Revision: 3de1e30c9a59c0c2f7d498488532e1e324059082 URL: https://github.com/llvm/llvm-project/commit/3de1e30c9a59c0c2f7d498488532e1e324059082 DIFF: https://github.com/llvm/llvm-project/commit/3de1e30c9a59c0c2f7d498488532e1e324059082.diff L

[clang] 69074bf - [clang] NFCI: Use `FileEntryRef` in `FileManagerTest`

Author: Jan Svoboda Date: 2023-09-20T18:41:25-07:00 New Revision: 69074bf144c1bf54040d289584e3d1d54f883a37 URL: https://github.com/llvm/llvm-project/commit/69074bf144c1bf54040d289584e3d1d54f883a37 DIFF: https://github.com/llvm/llvm-project/commit/69074bf144c1bf54040d289584e3d1d54f883a37.diff L

[clang] [Serialization] Do less redundant work computing affecting module maps (PR #66933)

https://github.com/jansvoboda11 approved this pull request. LGTM, thank you! https://github.com/llvm/llvm-project/pull/66933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

jansvoboda11 wrote: > > in my experience, it's not actually referenced in most modules > > Can you clarify what you looked at here? I assume you checked non-scanner > modules as well? I took a typical Xcode project and chose one TU that happens to transitively depend on 37 modules. I built it

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66966 >From d26f9487dedf53ac419cbd9dfb8c29214ba0e09f Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 17:30:45 -0700 Subject: [PATCH 1/2] [clang][modules] Move `SLocEntry` search into `ASTReader`

[clang] [Driver] -include: do not probe .gch (PR #67084)

jansvoboda11 wrote: Xcode is actively using this feature: the `.pch` extension is used for headers that are to be precompiled, the `.pch.gch` extension is used for the actual precompiled header, and Clang is expected to expand the given `-include X.pch` argument into `-include-pch X.pch.gch`.

[clang] [Driver] -include: do not probe .gch (PR #67084)

https://github.com/jansvoboda11 requested changes to this pull request. Xcode is actively using this feature: the .pch extension is used for headers that are to be precompiled, the .pch.gch extension is used for the actual precompiled header, and Clang is expected to expand the given -include X

[clang] [Driver] -include: do not probe .gch (PR #67084)

https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/67084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66966 >From 4edf9d8559339a12108d9c4d1e2f3bb062a5a768 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 17:30:45 -0700 Subject: [PATCH 1/4] [clang][modules] Move `SLocEntry` search into `ASTReader`

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66966 >From 4edf9d8559339a12108d9c4d1e2f3bb062a5a768 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 17:30:45 -0700 Subject: [PATCH 1/5] [clang][modules] Move `SLocEntry` search into `ASTReader`

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

https://github.com/jansvoboda11 ready_for_review https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

https://github.com/jansvoboda11 approved this pull request. Thanks! LGTM. https://github.com/llvm/llvm-project/pull/67084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

jansvoboda11 wrote: The "Index/annotate-module.m" test fails with this patch. For run line 29, the previous input is: ``` Punctuation: "#" [1:1 - 1:2] inclusion directive=Module/Sub2.h (/Users/Jan/Code/upstream-llvm/clang/test/Index/../Modules/Inputs/Module.framework/Headers/Sub2.h) Identifier:

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

jansvoboda11 wrote: Ok, the comment below seems to suggests that the built-ins buffers are not considered to be part of any TU: ```c++ bool SourceManager::isBeforeInTranslationUnit(SourceLocation LHS, SourceLocation RHS) const { // ... if (isIn

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66962 >From 1e36c68229a98ffbdb61ea652077bc3356fc177f Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 16:50:48 -0700 Subject: [PATCH 1/2] [clang][modules] Remove preloaded SLocEntries from PCM fi

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66962 >From 1e36c68229a98ffbdb61ea652077bc3356fc177f Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 16:50:48 -0700 Subject: [PATCH 1/3] [clang][modules] Remove preloaded SLocEntries from PCM fi

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

https://github.com/jansvoboda11 resolved https://github.com/llvm/llvm-project/pull/66962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66966 >From 4edf9d8559339a12108d9c4d1e2f3bb062a5a768 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 17:30:45 -0700 Subject: [PATCH 1/6] [clang][modules] Move `SLocEntry` search into `ASTReader`

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

@@ -50,6 +50,7 @@ int y = a2; // CHECK: In module 'a': // CHECK-NEXT: a.h:1:45: error: +int z = b; // MISSING-B: could not find file '{{.*}}b.h' // MISSING-B-NOT: please delete the module cache jansvoboda11 wrote: This test relied on the fact that when diag

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/67383 This patch adopts `FileEntryRef` in the `HeaderFileInfo`-writing part of `ASTWriter`. First, this patch removes the loop over `FileManager::VirtualFileEntries`. It's redundant, since all virtual file entri

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

jansvoboda11 wrote: > test case with multiple virtual entries to the same file that would now be > serialized once? If you're asking because of this: > First, this patch removes the loop over FileManager::VirtualFileEntries. It's > redundant, since all virtual file entries have a non-virtual/

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/67383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

@@ -612,24 +612,21 @@ FileManager::getNoncachedStatValue(StringRef Path, } void FileManager::GetUniqueIDMapping( -SmallVectorImpl &UIDToFiles) const { +SmallVectorImpl &UIDToFiles) const { UIDToFiles.clear(); UIDToFiles.resize(NextFileUID); - // Map file entri

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/67383 >From e2201a10fe76be3de8efd0faca0f381f504b08d3 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Mon, 25 Sep 2023 16:37:49 -0700 Subject: [PATCH 1/2] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileI

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/67383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

jansvoboda11 wrote: > > I changed SourceManager::isInTheSameTranslationUnit() to check for that > > case explicitly instead of relying on the fact/bug that built-ins buffers > > happened to be assigned an untranslated include SourceLocation. > > What is the translated location you get here? It

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66962 >From 1e36c68229a98ffbdb61ea652077bc3356fc177f Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 16:50:48 -0700 Subject: [PATCH 1/4] [clang][modules] Remove preloaded SLocEntries from PCM fi

[clang] 12cb98f - [clang][modules] Use `FileEntryRef` in `ModuleMap` (1/2)

Author: Jan Svoboda Date: 2023-09-28T12:59:26-07:00 New Revision: 12cb98fe04d5ca1d0cec89cdffac99c4243c0819 URL: https://github.com/llvm/llvm-project/commit/12cb98fe04d5ca1d0cec89cdffac99c4243c0819 DIFF: https://github.com/llvm/llvm-project/commit/12cb98fe04d5ca1d0cec89cdffac99c4243c0819.diff L

[clang] 12866a2 - [clang][modules] Use `FileEntryRef` in `ModuleMap` (2/2)

Author: Jan Svoboda Date: 2023-09-28T12:59:26-07:00 New Revision: 12866a2b87038abf2d69f2a6040a4ff4ce27b6cd URL: https://github.com/llvm/llvm-project/commit/12866a2b87038abf2d69f2a6040a4ff4ce27b6cd DIFF: https://github.com/llvm/llvm-project/commit/12866a2b87038abf2d69f2a6040a4ff4ce27b6cd.diff L

[clang-tools-extra] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos` (PR #67742)

https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/67742 None >From 242fa18a43ced2d738fe5cbe44912293767712f9 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 28 Sep 2023 14:24:56 -0700 Subject: [PATCH] [clang] NFCI: Use `FileEntryRef` in `SourceManager::Fil

[clang] de85739 - [clang] NFCI: Use `FileEntryRef` in additional module maps

Author: Jan Svoboda Date: 2023-09-28T14:49:45-07:00 New Revision: de85739ded2edddc568f287d4f94c2dc1ab97dd7 URL: https://github.com/llvm/llvm-project/commit/de85739ded2edddc568f287d4f94c2dc1ab97dd7 DIFF: https://github.com/llvm/llvm-project/commit/de85739ded2edddc568f287d4f94c2dc1ab97dd7.diff L

[clang] 3e9c363 - [clang] NFCI: Use `FileEntryRef` in `SourceManager::setFileIsTransient()`

Author: Jan Svoboda Date: 2023-09-28T14:50:00-07:00 New Revision: 3e9c36303ca72929275fb97767af43b3aa04cab1 URL: https://github.com/llvm/llvm-project/commit/3e9c36303ca72929275fb97767af43b3aa04cab1 DIFF: https://github.com/llvm/llvm-project/commit/3e9c36303ca72929275fb97767af43b3aa04cab1.diff L

[clang-tools-extra] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos` (PR #67742)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/67742 >From 857054623edbd0917b74273cec050770f2d24a80 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 28 Sep 2023 14:24:56 -0700 Subject: [PATCH] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos

[clang] [clang][deps] Load module map file from PCM (PR #66389)

jansvoboda11 wrote: Closing. I want to achieve this by fixing the underlying issues: * Speeding up `SLocEntry` deserialization (https://github.com/llvm/llvm-project/pull/66962, https://github.com/llvm/llvm-project/pull/66966). * Either adding caching to `DependencyScanningWorkerFilesystem::getR

[clang] [clang][deps] Load module map file from PCM (PR #66389)

https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/66389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos` (PR #67742)

jansvoboda11 wrote: I understand your concern, we should definitely look into this. However, I think the inode uniquing functionality is pretty fundamental to `FileEntry`, so I'm not sure it's reasonable for type named `FileEntryRef` to do anything else. I guess we could split `FileEntryRef` i

[clang-tools-extra] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos` (PR #67742)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/67742 >From 857054623edbd0917b74273cec050770f2d24a80 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 28 Sep 2023 14:24:56 -0700 Subject: [PATCH 1/2] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileI

[clang-tools-extra] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos` (PR #67742)

https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/67742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] b0abc9d - [clang] NFCI: Use `FileEntryRef` in `ASTReader::GetHeaderFileInfo()`

Author: Jan Svoboda Date: 2023-09-29T09:07:13-07:00 New Revision: b0abc9dd44271815b3ae1ad5d009a1ca83e0fdca URL: https://github.com/llvm/llvm-project/commit/b0abc9dd44271815b3ae1ad5d009a1ca83e0fdca DIFF: https://github.com/llvm/llvm-project/commit/b0abc9dd44271815b3ae1ad5d009a1ca83e0fdca.diff L

[clang] 2da8f30 - [clang] NFCI: Use `FileEntryRef` in `SourceManager::overrideFileContents()`

Author: Jan Svoboda Date: 2023-09-29T09:30:21-07:00 New Revision: 2da8f30c5e9a26cd3ca7f5aa8489eb0f0f3c8559 URL: https://github.com/llvm/llvm-project/commit/2da8f30c5e9a26cd3ca7f5aa8489eb0f0f3c8559 DIFF: https://github.com/llvm/llvm-project/commit/2da8f30c5e9a26cd3ca7f5aa8489eb0f0f3c8559.diff L

[clang] 3661a48 - [clang] NFCI: Use `FileEntryRef` in `SourceManager::getMemoryBufferForFileOr{None,Fake}()`

Author: Jan Svoboda Date: 2023-09-29T10:31:42-07:00 New Revision: 3661a48a84731ab5086bf1fca8f7e6b9f294225a URL: https://github.com/llvm/llvm-project/commit/3661a48a84731ab5086bf1fca8f7e6b9f294225a DIFF: https://github.com/llvm/llvm-project/commit/3661a48a84731ab5086bf1fca8f7e6b9f294225a.diff L

[clang-tools-extra] [clang] NFCI: Use `FileEntryRef` for `FileID` creation (PR #67838)

https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/67838 This patch removes the `SourceManager` APIs that create `FileID` from a `const FileEntry *` in favor of APIs that take `FileEntryRef`. This also removes a misleading documentation that claims `nullptr` file

[clang-tools-extra] [clang][tidy] Ensure rewriter has the correct CWD (PR #67839)

https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/67839 This patch replaces use of the deprecated `FileEntry::getName()` with `FileEntryRef::getName()`. This code now uses the path that was used to register file entry in `SourceManager` instead of the path that

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

jansvoboda11 wrote: I got around investigating "SemaCXX/warn-unsafe-buffer-usage-fixits-parm-span.cpp" and found out it uses this pattern: ``` %clang_cc1 ... -include %s %s ``` This means `FileID(1)` is the main input file `%s` and `FileID(2)` is the built-ins buffer that includes `%s` as `Fi

<    1   2   3   4   5   6   7   8   9   10   >