[PATCH] D137649: [Clang][OpenMP] Warn and discard write to host for const variable

jplehr created this revision. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jplehr requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Resolves a potential segmentation fau

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

jplehr added a comment. Not an expert here, only some minor comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1008 + std::vector *getLLVMCompilerUsed() { +return &LLVMCompilerUsed; Return a reference instead of pointer here? Comm

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

jplehr added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1009 + std::vector getLLVMCompilerUsed() { +return static_cast &>(LLVMCompilerUsed); + } I believe that this can be simplified to ``` std::vector &getLLVMCompilerUsed() { return

[PATCH] D155776: [NFC] Add checks for self-assignment.

jplehr added a comment. Hi, it seems that this broke the AMDGPU OpenMP buildbot https://lab.llvm.org/buildbot/#/builders/193/builds/35271 Happy to help if you need more info etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://re

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

jplehr added a comment. Hi, this seems to have broken the OpenMP AMDGPU buildbot (https://lab.llvm.org/buildbot/#/builders/193/builds/35471) I'm happy to help if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153276/new/ https://reviews.llv

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

jplehr added a comment. Wow, thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153276/new/ https://reviews.llvm.org/D153276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

jplehr added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4914 + GVMode->setVisibility(llvm::GlobalVariable::ProtectedVisibility); + assert(!GVMode->isDeclaration() && + "Only globals with definition can force usage."); raghave

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

jplehr added a comment. The preparation patch (https://reviews.llvm.org/D154872) caused the AMD GPU OpenMP buildbot to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154856/new/ https://reviews.llvm.org/D154856 __

[PATCH] D136103: OpenMP asynchronous memory copy support

jplehr updated this revision to Diff 508955. jplehr added a comment. Herald added a subscriber: sunshaoce. Rebase to make ready for land Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 Files: openmp/lib

[PATCH] D136103: OpenMP asynchronous memory copy support

jplehr updated this revision to Diff 509023. jplehr added a comment. Rebased and enabled tests for generic devices. Resulted in one test failure Failed Tests (3): libomptarget :: amdgcn-amd-amdhsa :: api/omp_target_memcpy_rect_async1.c libomptarget :: x86_64-pc-linux-gnu :: api/omp_target_memcpy_

[PATCH] D136103: OpenMP asynchronous memory copy support

jplehr updated this revision to Diff 509581. jplehr added a comment. Fix bug to corectly support the maximally supported dimensions as required by the spec. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103

[PATCH] D136103: OpenMP asynchronous memory copy support

jplehr updated this revision to Diff 509583. jplehr added a comment. Removed accidentally added code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 Files: openmp/libomptarget/include/interop.h openmp

[PATCH] D136103: OpenMP asynchronous memory copy support

This revision was automatically updated to reflect the committed changes. Closed by commit rG4753a4e31169: [OpenMP] asynchronous memory copy support (authored by jz10, committed by jplehr). Changed prior to commit: https://reviews.llvm.org/D136103?vs=509583&id=509775#toc Repository: rG LLVM

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

jplehr added a comment. In D140722#4219182 , @nextsilicon-itay-bookstein wrote: > Minor fix to the clang/CodeGen/ppc64le-varargs-f128.c test. > > @jdoerfert Does the PR CI run these, or are there build bots that cover the > different target-offloading v

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

jplehr added a comment. I'll get back to this soon, enjoyed vacation. ;) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm.org/D140722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

jplehr added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10412 + CGF.Builder.GetInsertPoint()); + llvm::OpenMPIRBuilder::LocationDescription ompLoc(CodeGenIP); capitalize here? Comment at: clan

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

jplehr added a comment. Tested on AMDGPU (gfx90a) -- OpenMP tools dir in libomptarget: /home/janplehr/git/trunk17.0/build/llvm-project/runtimes/runtimes-bins/openmp/runtime/src -- LIBOMPTARGET: Building offloading runtime library libomptarget. -- LIBOMPTARGET: Not building aarch64 offloadi

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

jplehr added a comment. Hey Krzysztof, I believe this broke the openmp offload buildbot https://lab.llvm.org/buildbot/#/builders/193/builds/30576 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 _

[PATCH] D137649: [Clang][OpenMP] Warn and discard write to host for const variable

jplehr planned changes to this revision. jplehr added a comment. We had another clarifying example on the github issue, which currently is not correctly covered by this patch. I'm currently reworking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1