[PATCH] D22608: [Profile] Use a flag to enable PGO rather than the profraw filename.

jakev created this revision. jakev added reviewers: xur, davidxl, silvas. jakev added a subscriber: cfe-commits. jakev set the repository for this revision to rL LLVM. Enable instrumentation using a flag rather than the profile filename. This is the other half of: https://reviews.llvm.org/D22607

[PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev created this revision. jakev added reviewers: silvas, davidxl, friss, vsk, bob.wilson, xur. jakev added a subscriber: cfe-commits. jakev set the repository for this revision to rL LLVM. The flags: For frontend instrumentation: `-fpgo-train=source-cfg` For IR-level instrumentation: `-fpgo-tra

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev updated this revision to Diff 62282. jakev marked 5 inline comments as done. jakev added a comment. Address comments. Repository: rL LLVM http://reviews.llvm.org/D21823 Files: include/clang/Driver/Options.td lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp test/Driver/clang_f_opts

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev updated this revision to Diff 62527. jakev added a comment. Don't allow `-fpgo-train` and `-fpgo-apply` together. Add `-fpgo-train-default-output=*` to set the default profile output file. Repository: rL LLVM http://reviews.llvm.org/D21823 Files: include/clang/Driver/Options.td li

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev added a comment. In http://reviews.llvm.org/D21823#470516, @xur wrote: > (1) It seems the original options of -fprofile-instr-generate and > -fprofile-instr-use will be kept. Is so, what is the guideline to use these > two sets of options. Sorry I'm not sure I understand what you're ask

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev updated the summary for this revision. jakev updated this revision to Diff 63367. jakev marked 3 inline comments as done. jakev added a comment. Reduce instrumentation flags to `fpgo-train` and change profile output file flag to `fpgo-train-output`. Repository: rL LLVM http://reviews.l

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev updated the summary for this revision. jakev updated this revision to Diff 63634. jakev added a comment. Change patch to use `-fprofile-generate` to enable IRPGO. Repository: rL LLVM http://reviews.llvm.org/D21823 Files: include/clang/Driver/Options.td lib/Driver/Tools.cpp test/D

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev updated this revision to Diff 64056. jakev marked 3 inline comments as done. jakev added a comment. Add a couple notes to the docs and a fixme to a test. We can more thoroughly fix up the docs in a separate patch. Repository: rL LLVM https://reviews.llvm.org/D21823 Files: docs/Users

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev added inline comments. Comment at: test/Profile/gcc-flag-compatibility.c:10 @@ -9,3 +9,3 @@ -// Check that -fprofile-generate uses the runtime default profile file. +// Check that -fprofile-generate overrides the default profraw. // RUN: %clang %s -c -S -o - -emit-llvm -f

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev added a comment. Fantastic. Sean or David, could one of you commit this for me? It would be much appreciated. Repository: rL LLVM https://reviews.llvm.org/D21823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org