[PATCH] D40569: Use default IR alignment for cleanup.dest.slot.

jacobly created this revision. Forcing the 4 byte alignment caused an issue in my out of tree backend that doesn't even have a 4 byte aligned stack. Using the default target-specific alignment for i32 seems more reasonable. Repository: rC Clang https://reviews.llvm.org/D40569 Files: lib

[PATCH] D40569: Use default IR alignment for cleanup.dest.slot.

jacobly added a comment. Could someone commit this for me? Thanks. Repository: rC Clang https://reviews.llvm.org/D40569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly created this revision. Herald added a project: All. jacobly requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the Microsoft ABI, some destructors need to offset a parameter to get the derived this pointer, in which case the type

[PATCH] D145148: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly created this revision. jacobly added reviewers: efriedma, aaron.ballman. Herald added a project: All. jacobly requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the Microsoft ABI, some destructors need to offset a parameter to get

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly added a comment. In D143233#4161909 , @aaron.ballman wrote: > In D143233#4160206 , @efriedma > wrote: > >> Maybe worth cherry-picking to 16 branch? I think someone will need to >> rebase onto the branc

[PATCH] D145148: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly added a comment. cherry-picked to release/16.x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145148/new/ https://reviews.llvm.org/D145148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D145148: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly updated this revision to Diff 501811. jacobly added a comment. Fix discrepency with original patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145148/new/ https://reviews.llvm.org/D145148 Files: clang/docs/ReleaseNotes.rst clang/lib

[PATCH] D145148: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly abandoned this revision. jacobly added a comment. Following release cherry-pick workflow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145148/new/ https://reviews.llvm.org/D145148 ___ cfe-commit

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly updated this revision to Diff 495543. jacobly added a comment. Added regression test specific to the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 Files: clang/lib/CodeGen/CGCXXABI.h

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly updated this revision to Diff 495645. jacobly added a comment. Cleanup and minor fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 Files: clang/lib/CodeGen/CGCXXABI.h clang/lib/CodeGen/CG

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly updated this revision to Diff 495648. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 Files: clang/lib/CodeGen/CGCXXABI.h clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGExprCXX.cpp clang/l

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly updated this revision to Diff 497052. jacobly added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CGC

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly updated this revision to Diff 497097. jacobly added a comment. Fix bad diff update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CGCXXAB

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly added a comment. I was hoping @rnk was available for review, but otherwise this is ready to land and I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 __

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly added a comment. Jacob Young Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D27263: Address of bitfield in anonymous struct doesn't error.

jacobly added a comment. rsmith, is this ready to be commited? https://reviews.llvm.org/D27263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27263: Address of bitfield in anonymous struct doesn't error.

jacobly added a comment. Ping. https://reviews.llvm.org/D27263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27263: Address of bitfield in anonymous struct doesn't error.

jacobly created this revision. jacobly added a subscriber: cfe-commits. struct A { struct { int B : 1; } } int A::*addr_anon_bitfield() { return &A::B; } This code does not error, but instead returns a member pointer to a full int that starts at the beginning of the b