ichesnokov removed rL LLVM as the repository for this revision.
ichesnokov updated this revision to Diff 46532.
ichesnokov added a comment.
Added generic variable support and checking address space to Microsoft mangler.
Test case updated.
http://reviews.llvm.org/D16539
Files:
lib/AST/ItaniumM
Thanks Paul!
-Original Message-
From: Robinson, Paul [mailto:paul_robin...@playstation.sony.com]
Sent: Monday, February 1, 2016 11:46 PM
To: Igor Chesnokov; Anton Korobeynikov
Cc: cfe-commits (cfe-commits@lists.llvm.org)
Subject: RE: [PATCH] D16754: Bug 15785 - OpenCL errors using vector/
ichesnokov removed rL LLVM as the repository for this revision.
ichesnokov updated this revision to Diff 46634.
ichesnokov added a comment.
Warnings added to the case. Turned off by default:
Original bahavior:
"// If we have a redefinition of a typedef in C, emit a warning. This warning
// is nor
ichesnokov marked 3 inline comments as done.
Comment at: test/SemaOpenCL/implicit-typedef.cl:2
@@ +1,2 @@
+// RUN: %clang_cc1 %s -cl-std=CL2.0 -verify -pedantic -fsyntax-only
-Wsystem-headers
+typedef atomic_int atomic_flag; // expected-warning {{redefinition of typedef
'atomic_
ichesnokov removed rL LLVM as the repository for this revision.
ichesnokov updated this revision to Diff 46655.
ichesnokov added a comment.
Test cases moved to single file.
Please review and accept.
http://reviews.llvm.org/D16682
Files:
test/SemaOpenCL/ternary-implicit-casts.cl
Index: test/S
ichesnokov added inline comments.
Comment at: test/CodeGenOpenCL/ternary-implicit-casts-fail.cl:2
@@ +1,3 @@
+// RUN: %clang_cc1 %s
+// XFAIL: *
+
ichesnokov wrote:
> asl wrote:
> > ichesnokov wrote:
> > > asl wrote:
> > > > Don't do XFAIL tests - they will be "ok
ichesnokov added a comment.
Please support discussion about MicrosoftMangle+CL at
https://llvm.org/bugs/show_bug.cgi?id=26194
Comment at: tools/driver/driver.cpp:367
@@ -367,1 +366,3 @@
+int Result = ExecuteCC1Tool(argv, argv[1] + 4);
+return Result; // Useful for debugg
ichesnokov updated the summary for this revision.
ichesnokov updated this revision to Diff 46772.
ichesnokov added a comment.
This diff adds mangling check test cases for Itanium and Microsoft manglers
http://reviews.llvm.org/D16539
Files:
lib/AST/ItaniumMangle.cpp
lib/AST/MicrosoftMangle.c
ichesnokov added a comment.
I noticed that MicrosoftMangler already has many extension functions. I.e. this
MicrosoftMangler.cpp change is Ok.
Please review and accept/commit.
http://reviews.llvm.org/D16539
___
cfe-commits mailing list
cfe-commits@
ichesnokov added a comment.
Please review and approve.
Repository:
rL LLVM
http://reviews.llvm.org/D16574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov updated this revision to Diff 46876.
ichesnokov marked 2 inline comments as done.
ichesnokov added a comment.
Test case enriched to check typedef redefinition without warnings.
Minor fix of comment.
http://reviews.llvm.org/D16351
Files:
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/impli
ichesnokov marked 3 inline comments as done.
Comment at: lib/Sema/SemaDecl.cpp:2039
@@ -2038,1 +2038,3 @@
+ // Added isImplicit() check, because implicit TypeDecl::getLocation()
+ // returns 0. The're many implicit typedefs in OpenCL, e.g. atomic_flag.
Fixed
ichesnokov marked 3 inline comments as done.
ichesnokov added a comment.
Notice that redefinition of typedef defined at system header will show the same
message.
http://reviews.llvm.org/D16351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ichesnokov removed rL LLVM as the repository for this revision.
ichesnokov updated this revision to Diff 46877.
ichesnokov added a comment.
Patch improvements
http://reviews.llvm.org/D16574
Files:
test/SemaOpenCL/char-must-be-signed.cl
Index: test/SemaOpenCL/char-must-be-signed.cl
==
ichesnokov added a comment.
Please review and accept.
http://reviews.llvm.org/D16574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added inline comments.
Comment at: test/SemaOpenCL/implicit-typedef.cl:3
@@ +2,3 @@
+// RUN: %clang_cc1 %s -cl-std=CL2.0 -fsyntax-only
+
+#if defined(TEST_WARNINGS)
Anastasia wrote:
> ichesnokov wrote:
> > Are you mean another text of warning? Notice th
ichesnokov added a comment.
No, just make test case more 'standard'.
http://reviews.llvm.org/D16574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added inline comments.
Comment at: test/SemaOpenCL/ternary-implicit-casts.cl:6
@@ +5,3 @@
+ // will not compile, ptr is not generic but local
+ local int *ptr = cond ? gint : lint; // expected-warning {{pointer type
mismatch ('__global int *' and '__local int *'
ichesnokov added a comment.
Instead of checking by division by zero, I've used _StaticAssert. Functionally
bo change, but more understandable.
http://reviews.llvm.org/D16574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
ichesnokov added a comment.
Ping.
http://reviews.llvm.org/D16539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added a comment.
Ping.
http://reviews.llvm.org/D16539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added a comment.
Ping.
Repository:
rL LLVM
http://reviews.llvm.org/D16460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added a comment.
It looks like there's more todo to close this bug.
Let's go back to bug discussion at: https://llvm.org/bugs/show_bug.cgi?id=19957
http://reviews.llvm.org/D16682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
ichesnokov added inline comments.
Comment at: test/SemaOpenCL/ternary-implicit-casts.cl:10-11
@@ +9,4 @@
+kernel void implicit_cast_generic(global int* gint, local int* lint, int cond)
{
+ // will compile, ptr is generic and can accept global and local
+ int* ptr = co
ichesnokov added a comment.
Please review the last version of patch.
http://reviews.llvm.org/D16539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:2716
@@ +2715,3 @@
+ if (Ops.LHS->getType() != RHS->getType()) {
+bool isSigned =
dyn_cast(Ops.E)->getRHS()->getType().getTypePtr()->isSignedIntegerType();
+RHS = Builder.CreateIntCast(RHS, Ops.LH
ichesnokov updated this revision to Diff 47137.
ichesnokov added a comment.
Another warning text implemented for OpenCL.
Like: redefinition of OpenCL builtin typedef 'atomic_flag'
http://reviews.llvm.org/D16351
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/S
ichesnokov added inline comments.
Comment at: test/SemaOpenCL/implicit-typedef.cl:4
@@ +3,3 @@
+
+#if defined(TEST_WARNINGS)
+typedef atomic_int atomic_flag; // expected-warning {{redefinition of OpenCL
builtin typedef 'atomic_flag'}}
Thank you, Anastasia!
I just
ichesnokov marked an inline comment as done.
Comment at: lib/Sema/SemaDecl.cpp:2039
@@ +2038,3 @@
+ if (Old->isImplicit() || New->isImplicit()) {
+ return;
+ }
asl wrote:
> Please follow the LLVM's coding style guidelines. E.g. *never* use tabs.
It is no
ichesnokov updated this revision to Diff 46229.
ichesnokov marked 2 inline comments as done.
http://reviews.llvm.org/D16351
Files:
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/implicit-typedef.cl
tools/driver/driver.cpp
Index: tools/driver/driver.cpp
==
ichesnokov added inline comments.
Comment at: test/SemaOpenCL/implicit-typedef.cl:2
@@ +1,2 @@
+// RUN: %clang_cc1 "-cc1" "-emit-llvm" "-D" "cl_khr_fp64" "-D"
"cl_khr_int64_base_atomics" "-fno-dwarf-directory-asm" "-fmessage-length" "205"
"-fdiagnostics-show-option" "-cl-std=CL2
ichesnokov added a comment.
BugZilla page:
https://llvm.org/bugs/show_bug.cgi?id=25404
Repository:
rL LLVM
http://reviews.llvm.org/D16351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=25404
Please review and submit this bug.
Comment at: test/SemaOpenCL/implicit-typedef.cl:2
@@ +1,2 @@
+// RUN: %clang_cc1 "-cc1" "-emit-llvm" "-D" "cl_khr_fp64" "-D"
"cl_khr_int64_base_atomics" "-
ichesnokov set the repository for this revision to rL LLVM.
ichesnokov updated this revision to Diff 46470.
ichesnokov added a comment.
Removed unuseful patch code.
Repository:
rL LLVM
http://reviews.llvm.org/D16351
Files:
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/implicit-typedef.cl
Index:
ichesnokov added a comment.
Please review and commit.
Repository:
rL LLVM
http://reviews.llvm.org/D16351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov created this revision.
ichesnokov added reviewers: asl, kraiskil.
ichesnokov added a subscriber: cfe-commits.
ichesnokov set the repository for this revision to rL LLVM.
A simple patch to ensure that char is signed. Check assumed for OpenCL only.
Repository:
rL LLVM
http://reviews.l
ichesnokov added a comment.
Please review and commit.
Repository:
rL LLVM
http://reviews.llvm.org/D16750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=15685
Repository:
rL LLVM
http://reviews.llvm.org/D16750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=15685
Repository:
rL LLVM
http://reviews.llvm.org/D16574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ichesnokov added a comment.
Please review and commit.
There's no patch, but only unit tests.
Repository:
rL LLVM
http://reviews.llvm.org/D16682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
ichesnokov added a comment.
Please review and commit.
Repository:
rL LLVM
http://reviews.llvm.org/D16460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added a comment.
Please review and commit.
Repository:
rL LLVM
http://reviews.llvm.org/D16574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:1799
@@ -1798,2 +1798,3 @@
case LangAS::opencl_constant: ASString = "CLconstant"; break;
+ case LangAS::opencl_generic: ASString = "CLgeneric"; break;
// ::= "CU" [ "device" | "constant"
ichesnokov created this revision.
ichesnokov added a reviewer: asl.
ichesnokov added a subscriber: cfe-commits.
ichesnokov set the repository for this revision to rL LLVM.
Not a bug, thus empty patch. Older patch handles the case.
Please look at comments at: https://llvm.org/bugs/show_bug.cgi?id=1
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=15785
Please review and close the bug.
Repository:
rL LLVM
http://reviews.llvm.org/D16754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=10002
Repository:
rL LLVM
http://reviews.llvm.org/D16460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=19957
Repository:
rL LLVM
http://reviews.llvm.org/D16682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=26194
Repository:
rL LLVM
http://reviews.llvm.org/D16539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ichesnokov added a comment.
majnemer,
I'll try to find answer to your question tomorrow.
Repository:
rL LLVM
http://reviews.llvm.org/D16351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=25404
Repository:
rL LLVM
http://reviews.llvm.org/D16351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Hi Anton,
Okey, nevermore.
But what to do with a bug which needs simply be closed (NABs)?
I believe they also need a review/approval.
Igor
-Original Message-
From: Anton Korobeynikov [mailto:an...@korobeynikov.info]
Sent: Sunday, January 31, 2016 8:19 PM
To: Igor
ichesnokov added a comment.
> majnemer: Why isn't this logic buried in GetArgumentVector so that other
> tools may take advantage of it?
Sorry, I do not understand what you say.
I looked into GetArgumentVector and this function is dummy now in both Unix and
Windows, and it does not look like c
52 matches
Mail list logo
