r346131 - [Tooling] Add "-filter" option to AllTUsExecution

2018-11-05 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Nov 5 05:42:05 2018 New Revision: 346131 URL: http://llvm.org/viewvc/llvm-project?rev=346131&view=rev Log: [Tooling] Add "-filter" option to AllTUsExecution Summary: We can run the tools on a subset files of compilation database. Reviewers: ioeric Subscribers: cfe-comm

r346135 - [Tooling] Correct the total number of files being processed when `filter` is provided.

2018-11-05 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Nov 5 07:08:00 2018 New Revision: 346135 URL: http://llvm.org/viewvc/llvm-project?rev=346135&view=rev Log: [Tooling] Correct the total number of files being processed when `filter` is provided. Reviewers: ioeric Subscribers: cfe-commits Differential Revision: https://

[clang-tools-extra] r346319 - [clangd] Drop namespace references in the index.

2018-11-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Nov 7 06:59:24 2018 New Revision: 346319 URL: http://llvm.org/viewvc/llvm-project?rev=346319&view=rev Log: [clangd] Drop namespace references in the index. Summary: Namespace references is less useful compared with other symbols, and they contribute large part of the ind

[clang-tools-extra] r346666 - [clangd] Allow symbols from AnyScope in dexp.

2018-11-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Nov 12 08:03:59 2018 New Revision: 34 URL: http://llvm.org/viewvc/llvm-project?rev=34&view=rev Log: [clangd] Allow symbols from AnyScope in dexp. Summary: We should allow symbols from any scope in dexp results, othewise `find StringRef` doesn't return any results

[clang-tools-extra] r346671 - [clangd] Don't show all refs results if -name is ambiguous in dexp.

2018-11-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Nov 12 08:41:15 2018 New Revision: 346671 URL: http://llvm.org/viewvc/llvm-project?rev=346671&view=rev Log: [clangd] Don't show all refs results if -name is ambiguous in dexp. Reviewers: ioeric Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits

[clang-tools-extra] r346852 - [clangd] Replace StringRef in SymbolLocation with a char pointer.

2018-11-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Nov 14 03:55:45 2018 New Revision: 346852 URL: http://llvm.org/viewvc/llvm-project?rev=346852&view=rev Log: [clangd] Replace StringRef in SymbolLocation with a char pointer. Summary: This would save us 8 bytes per ref, and buy us ~40MB in total for llvm index (from ~300MB

[clang-tools-extra] r346947 - [clangd] Fix no results returned for global symbols in dexp

2018-11-15 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Nov 15 04:17:41 2018 New Revision: 346947 URL: http://llvm.org/viewvc/llvm-project?rev=346947&view=rev Log: [clangd] Fix no results returned for global symbols in dexp Summary: For symbols in global namespace (without any scope), we need to add global scope "" to the fuzz

[clang-tools-extra] r346955 - [clangd] global-symbol-builder => clangd-indexer

2018-11-15 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Nov 15 06:15:19 2018 New Revision: 346955 URL: http://llvm.org/viewvc/llvm-project?rev=346955&view=rev Log: [clangd] global-symbol-builder => clangd-indexer Modified: clang-tools-extra/trunk/clangd/index/dex/dexp/Dexp.cpp Modified: clang-tools-extra/trunk/clangd/inde

[clang-tools-extra] r347039 - [clangd] Fix a compiler warning and test crashes caused in rL347038.

2018-11-16 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Nov 16 01:41:14 2018 New Revision: 347039 URL: http://llvm.org/viewvc/llvm-project?rev=347039&view=rev Log: [clangd] Fix a compiler warning and test crashes caused in rL347038. Modified: clang-tools-extra/trunk/clangd/index/Background.cpp clang-tools-extra/trunk/c

[clang-tools-extra] r347044 - [clangd] Truncate SymbolID to 8 bytes.

2018-11-16 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Nov 16 02:58:40 2018 New Revision: 347044 URL: http://llvm.org/viewvc/llvm-project?rev=347044&view=rev Log: [clangd] Truncate SymbolID to 8 bytes. Summary: This is our goal. It has a non-zero rick, but so far we haven't see any collision (externally and internally). Revi

[clang-tools-extra] r347315 - [clang-tidy] Don't generate incorrect fixes for class constructed from list-initialized arguments

2018-11-20 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Nov 20 07:45:15 2018 New Revision: 347315 URL: http://llvm.org/viewvc/llvm-project?rev=347315&view=rev Log: [clang-tidy] Don't generate incorrect fixes for class constructed from list-initialized arguments Summary: Currently the smart_ptr check (modernize-make-unique) ge

[clang-tools-extra] r347449 - Move the llvm lit test dependencies to clang-tools-extra.

2018-11-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Nov 22 02:14:55 2018 New Revision: 347449 URL: http://llvm.org/viewvc/llvm-project?rev=347449&view=rev Log: Move the llvm lit test dependencies to clang-tools-extra. Summary: Part of revert r343473 Reviewers: mgorny Subscribers: cfe-commits Differential Revision: https

[clang-tools-extra] r347537 - [clang-tidy] Don't generate incorrect fixes for class with deleted copy constructor in smart_ptr check.

2018-11-26 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Nov 26 01:33:08 2018 New Revision: 347537 URL: http://llvm.org/viewvc/llvm-project?rev=347537&view=rev Log: [clang-tidy] Don't generate incorrect fixes for class with deleted copy constructor in smart_ptr check. Summary: The fix for aggregate initialization (`std::make_u

[clang-tools-extra] r347547 - [clangd] Use testPath in the test.

2018-11-26 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Nov 26 03:18:16 2018 New Revision: 347547 URL: http://llvm.org/viewvc/llvm-project?rev=347547&view=rev Log: [clangd] Use testPath in the test. Modified: clang-tools-extra/trunk/unittests/clangd/FindSymbolsTests.cpp Modified: clang-tools-extra/trunk/unittests/clangd/F

[clang-tools-extra] r347551 - [clang-tidy] No warning for auto new expression in smart check

2018-11-26 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Nov 26 04:42:08 2018 New Revision: 347551 URL: http://llvm.org/viewvc/llvm-project?rev=347551&view=rev Log: [clang-tidy] No warning for auto new expression in smart check Summary: The fix for `auto` new expression is illegal. Reviewers: aaron.ballman Subscribers: xazax.

[clang-tools-extra] r347737 - [clangd] Bump vscode-clangd v0.0.7

2018-11-28 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Nov 28 02:23:15 2018 New Revision: 347737 URL: http://llvm.org/viewvc/llvm-project?rev=347737&view=rev Log: [clangd] Bump vscode-clangd v0.0.7 Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.json Modified: clang-tools-extra/trunk/clangd/clients

[clang-tools-extra] r347753 - [clangd] Build and test IndexBenchmark in check-clangd

2018-11-28 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Nov 28 05:31:05 2018 New Revision: 347753 URL: http://llvm.org/viewvc/llvm-project?rev=347753&view=rev Log: [clangd] Build and test IndexBenchmark in check-clangd Summary: Include IndexBenchmark in check-clangd to make sure we won't forget to update it when doing breaking

[clang-tools-extra] r347968 - [clangd] Fix junk output in clangd vscode plugin

2018-11-30 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Nov 30 01:14:52 2018 New Revision: 347968 URL: http://llvm.org/viewvc/llvm-project?rev=347968&view=rev Log: [clangd] Fix junk output in clangd vscode plugin Summary: When using the vscode clangd plugin, lots and lots of junk output is printed to the output window, which

[clang-tools-extra] r347969 - [clangd] Bump vscode-clangd v0.0.8

2018-11-30 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Nov 30 01:18:31 2018 New Revision: 347969 URL: http://llvm.org/viewvc/llvm-project?rev=347969&view=rev Log: [clangd] Bump vscode-clangd v0.0.8 Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.json Modified: clang-tools-extra/trunk/clangd/clients

r347970 - Fix a use-after-scope bug.

2018-11-30 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Nov 30 01:23:01 2018 New Revision: 347970 URL: http://llvm.org/viewvc/llvm-project?rev=347970&view=rev Log: Fix a use-after-scope bug. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp Modified: cfe/trunk/lib/StaticAnalyz

[clang-tools-extra] r348130 - [clangd] Get rid of AST matchers in CodeComplete, NFC

2018-12-03 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Dec 3 04:53:19 2018 New Revision: 348130 URL: http://llvm.org/viewvc/llvm-project?rev=348130&view=rev Log: [clangd] Get rid of AST matchers in CodeComplete, NFC Summary: The isIndexedForCodeCompletion is called in the code patch of SymbolCollector. Reviewers: kadircet

[clang-tools-extra] r348133 - [clangd] Fix a stale comment, NFC.

2018-12-03 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Dec 3 05:16:04 2018 New Revision: 348133 URL: http://llvm.org/viewvc/llvm-project?rev=348133&view=rev Log: [clangd] Fix a stale comment, NFC. Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp clang-tools-extra/trunk/clangd/index/SymbolCollector.h

[clang-tools-extra] r348467 - [clangd] Fix a typo in TUSchedulerTests

2018-12-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Dec 6 00:55:24 2018 New Revision: 348467 URL: http://llvm.org/viewvc/llvm-project?rev=348467&view=rev Log: [clangd] Fix a typo in TUSchedulerTests Reviewers: ilya-biryukov Reviewed By: ilya-biryukov Subscribers: javed.absar, ioeric, MaskRay, jkorous, arphaman, kadircet

[clang-tools-extra] r348475 - [clangd] C++ API for emitting file status.

2018-12-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Dec 6 01:41:04 2018 New Revision: 348475 URL: http://llvm.org/viewvc/llvm-project?rev=348475&view=rev Log: [clangd] C++ API for emitting file status. Introduce clangd C++ API to emit the current status of file. Modified: clang-tools-extra/trunk/clangd/ClangdServer.c

[clang-tools-extra] r348478 - [clangd] Update the test code

2018-12-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Dec 6 02:22:48 2018 New Revision: 348478 URL: http://llvm.org/viewvc/llvm-project?rev=348478&view=rev Log: [clangd] Update the test code I forgot to update it in the last round of code review. Modified: clang-tools-extra/trunk/unittests/clangd/TUSchedulerTests.cpp

[clang-tools-extra] r348583 - [clang-tidy] Remove duplicated getText implementation, NFC

2018-12-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Dec 7 03:25:37 2018 New Revision: 348583 URL: http://llvm.org/viewvc/llvm-project?rev=348583&view=rev Log: [clang-tidy] Remove duplicated getText implementation, NFC Modified: clang-tools-extra/trunk/clang-tidy/readability/RedundantStringCStrCheck.cpp Modified: cla

[clang-tools-extra] r355493 - [clangd] Add Source to clangd::Diagnostic.

2019-03-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Mar 6 02:51:38 2019 New Revision: 355493 URL: http://llvm.org/viewvc/llvm-project?rev=355493&view=rev Log: [clangd] Add Source to clangd::Diagnostic. Summary: clangd embedder can distinguish diagnostics from clang or clang-tidy. Reviewers: ilya-biryukov Subscribers: io

[clang-tools-extra] r355599 - [clangd] Strip plugin arguments in clangd-indexer.

2019-03-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Mar 7 06:47:17 2019 New Revision: 355599 URL: http://llvm.org/viewvc/llvm-project?rev=355599&view=rev Log: [clangd] Strip plugin arguments in clangd-indexer. Summary: This would allow clangd-indexer runs on chromium repo. Reviewers: kadircet Reviewed By: kadircet Subs

[clang-tools-extra] r355676 - [clangd] Deduplicate Refs on the fly.

2019-03-08 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Mar 8 01:26:30 2019 New Revision: 355676 URL: http://llvm.org/viewvc/llvm-project?rev=355676&view=rev Log: [clangd] Deduplicate Refs on the fly. Summary: Currently, we only do deduplication when we flush final results. We may have huge duplications (refs from headers) du

[clang-tools-extra] r355680 - [clangd] Redirect clangd page.

2019-03-08 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Mar 8 01:56:42 2019 New Revision: 355680 URL: http://llvm.org/viewvc/llvm-project?rev=355680&view=rev Log: [clangd] Redirect clangd page. Reviewers: gribozavr Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags: #clang Different

[clang-tools-extra] r355811 - [clangd] Add TOC section to clangd doc.

2019-03-11 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Mar 11 01:45:56 2019 New Revision: 355811 URL: http://llvm.org/viewvc/llvm-project?rev=355811&view=rev Log: [clangd] Add TOC section to clangd doc. Reviewers: gribozavr Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags: #clang

[clang-tools-extra] r355934 - [clang-tidy] NOLINT support for "clang-diagnostic-*".

2019-03-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Mar 12 09:11:46 2019 New Revision: 355934 URL: http://llvm.org/viewvc/llvm-project?rev=355934&view=rev Log: [clang-tidy] NOLINT support for "clang-diagnostic-*". Reviewers: alexfh, aaron.ballman Reviewed By: alexfh Subscribers: xazax.hun, cfe-commits Tags: #clang Diff

[clang-tools-extra] r356055 - [clangd] Fix a typo in doc.

2019-03-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Mar 13 08:22:31 2019 New Revision: 356055 URL: http://llvm.org/viewvc/llvm-project?rev=356055&view=rev Log: [clangd] Fix a typo in doc. Modified: clang-tools-extra/trunk/docs/clangd/Installation.rst Modified: clang-tools-extra/trunk/docs/clangd/Installation.rst URL:

[clang-tools-extra] r356126 - [clangd] Build Dex index after loading all shards in BackgroundIndex.

2019-03-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Mar 14 02:57:10 2019 New Revision: 356126 URL: http://llvm.org/viewvc/llvm-project?rev=356126&view=rev Log: [clangd] Build Dex index after loading all shards in BackgroundIndex. Summary: Currently after loadding all shards, we use MemIndex which has poor query performance

[clang-tools-extra] r356127 - [clangd] Fix an out-of-date FIXME, NFC.

2019-03-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Mar 14 03:01:07 2019 New Revision: 356127 URL: http://llvm.org/viewvc/llvm-project?rev=356127&view=rev Log: [clangd] Fix an out-of-date FIXME, NFC. Modified: clang-tools-extra/trunk/clangd/index/Index.h Modified: clang-tools-extra/trunk/clangd/index/Index.h URL: htt

[clang-tools-extra] r356134 - [clangd] Using symbol name to map includes for STL symbols.

2019-03-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Mar 14 04:25:26 2019 New Revision: 356134 URL: http://llvm.org/viewvc/llvm-project?rev=356134&view=rev Log: [clangd] Using symbol name to map includes for STL symbols. Summary: Using suffix path mapping relies on the STL implementations, and it is not portable. This patch

[clang-tools-extra] r356878 - Add llvm:: qualifer to make_unique, NFC

2019-03-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Mar 25 02:53:19 2019 New Revision: 356878 URL: http://llvm.org/viewvc/llvm-project?rev=356878&view=rev Log: Add llvm:: qualifer to make_unique, NFC To avoid potential "make_unique is ambiguous" compiler errors. Modified: clang-tools-extra/trunk/pp-trace/PPTrace.cpp

[clang-tools-extra] r356893 - [pp-trace] Use ClangTool in pp-trace, NFC

2019-03-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Mar 25 05:49:46 2019 New Revision: 356893 URL: http://llvm.org/viewvc/llvm-project?rev=356893&view=rev Log: [pp-trace] Use ClangTool in pp-trace, NFC Summary: This patch partially reverts the commit rL356849. Unfortunately, tooling::createExecutorFromCommandLineArgs does

[clang-tools-extra] r356894 - [clangd] Add std subnamespace symbols to the symbol map.

2019-03-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Mar 25 06:14:10 2019 New Revision: 356894 URL: http://llvm.org/viewvc/llvm-project?rev=356894&view=rev Log: [clangd] Add std subnamespace symbols to the symbol map. Reviewers: ioeric, serge-sans-paille Reviewed By: ioeric Subscribers: ilya-biryukov, MaskRay, jkorous, ar

r356912 - Revert "[clang-format] Keep protobuf "package" statement on one line"

2019-03-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Mar 25 08:46:07 2019 New Revision: 356912 URL: http://llvm.org/viewvc/llvm-project?rev=356912&view=rev Log: Revert "[clang-format] Keep protobuf "package" statement on one line" This reverts commit r356835. This patch causes a regression, see the test below: verifyFormat

[clang-tools-extra] r357075 - [clangd] Add activate command to the vscode extension.

2019-03-27 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Mar 27 08:41:59 2019 New Revision: 357075 URL: http://llvm.org/viewvc/llvm-project?rev=357075&view=rev Log: [clangd] Add activate command to the vscode extension. Summary: This would help minizime the annoying part of not activating the extension for .cu file. Reviewers:

[clang-tools-extra] r357078 - [clangd] Fix the inconsistent code indent in vscode extension, NFC.

2019-03-27 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Mar 27 08:50:33 2019 New Revision: 357078 URL: http://llvm.org/viewvc/llvm-project?rev=357078&view=rev Log: [clangd] Fix the inconsistent code indent in vscode extension, NFC. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts Modified: c

[clang-tools-extra] r357082 - [clangd] Bump vscode-clangd v0.0.12.

2019-03-27 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Mar 27 09:01:25 2019 New Revision: 357082 URL: http://llvm.org/viewvc/llvm-project?rev=357082&view=rev Log: [clangd] Bump vscode-clangd v0.0.12. CHANGELOG: - add an explicit command to activate the extension. - support .cu files (the extension is not activated for .cu fil

[clang-tools-extra] r358282 - [clangd] Enable clang-tidy by default.

2019-04-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Apr 12 06:07:48 2019 New Revision: 358282 URL: http://llvm.org/viewvc/llvm-project?rev=358282&view=rev Log: [clangd] Enable clang-tidy by default. Summary: We have turned on the flag internally for a while, and we don't receive complains. Should be good to turn it on now

[clang-tools-extra] r358576 - [clang-tidy] Add fix descriptions to clang-tidy checks.

2019-04-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Apr 17 05:53:59 2019 New Revision: 358576 URL: http://llvm.org/viewvc/llvm-project?rev=358576&view=rev Log: [clang-tidy] Add fix descriptions to clang-tidy checks. Summary: Motivation/Context: in the code review system integrating with clang-tidy, clang-tidy doesn't provi

r358576 - [clang-tidy] Add fix descriptions to clang-tidy checks.

2019-04-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Apr 17 05:53:59 2019 New Revision: 358576 URL: http://llvm.org/viewvc/llvm-project?rev=358576&view=rev Log: [clang-tidy] Add fix descriptions to clang-tidy checks. Summary: Motivation/Context: in the code review system integrating with clang-tidy, clang-tidy doesn't provi

[clang-tools-extra] r358658 - [clangd] Emit better error messages when rename fails.

2019-04-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Apr 18 04:35:22 2019 New Revision: 358658 URL: http://llvm.org/viewvc/llvm-project?rev=358658&view=rev Log: [clangd] Emit better error messages when rename fails. Summary: Currently we emit an unfriendly "clang diagnostic" message when rename fails. This patch makes clan

r358666 - [clang-tidy] Address post-commit comments

2019-04-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Apr 18 07:18:14 2019 New Revision: 358666 URL: http://llvm.org/viewvc/llvm-project?rev=358666&view=rev Log: [clang-tidy] Address post-commit comments Summary: Also add a test to verify clang-tidy only apply the first alternative fix. Reviewers: alexfh Subscribers: xazax

[clang-tools-extra] r358666 - [clang-tidy] Address post-commit comments

2019-04-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Apr 18 07:18:14 2019 New Revision: 358666 URL: http://llvm.org/viewvc/llvm-project?rev=358666&view=rev Log: [clang-tidy] Address post-commit comments Summary: Also add a test to verify clang-tidy only apply the first alternative fix. Reviewers: alexfh Subscribers: xazax

r343459 - Build clang-headers when building clang tools.

2018-10-01 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 1 05:16:38 2018 New Revision: 343459 URL: http://llvm.org/viewvc/llvm-project?rev=343459&view=rev Log: Build clang-headers when building clang tools. Summary: clang tools require clang headers to work on real project, e.g. when we build clangd via `ninja clangd`, we

[clang-tools-extra] r343474 - [clangd] Add "check-clangd" target

2018-10-01 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 1 07:02:02 2018 New Revision: 343474 URL: http://llvm.org/viewvc/llvm-project?rev=343474&view=rev Log: [clangd] Add "check-clangd" target Summary: So we don't have to run "check-clang-tools" (which builds and tests all clang tools) to verify our clangd-related change

r343481 - [Preprocessor] Fix a crash when handling non-alpha include header.

2018-10-01 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 1 07:38:43 2018 New Revision: 343481 URL: http://llvm.org/viewvc/llvm-project?rev=343481&view=rev Log: [Preprocessor] Fix a crash when handling non-alpha include header. Summary: the crash is casued by an assertion in StringRef. (llvm::StringRef::front() const: Asser

[clang-tools-extra] r343526 - [clangd] exclude check-clangd from check-all, fix buildbot failure.

2018-10-01 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 1 13:21:41 2018 New Revision: 343526 URL: http://llvm.org/viewvc/llvm-project?rev=343526&view=rev Log: [clangd] exclude check-clangd from check-all, fix buildbot failure. check-clangd is included via check-clang-tools, otherwise we will run two instances of check-cla

r343591 - [Preprocessor] Hide include typo correction behind SpellChecking.

2018-10-02 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Oct 2 06:59:49 2018 New Revision: 343591 URL: http://llvm.org/viewvc/llvm-project?rev=343591&view=rev Log: [Preprocessor] Hide include typo correction behind SpellChecking. Summary: Similar to Sema typo correction, the Preprocessor typo correction should also be hidden b

r343592 - [Preprocesssor] Filename should fall back to the written name when typo correction fails.

2018-10-02 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Oct 2 07:42:51 2018 New Revision: 343592 URL: http://llvm.org/viewvc/llvm-project?rev=343592&view=rev Log: [Preprocesssor] Filename should fall back to the written name when typo correction fails. Summary: The test is added in Testcase is at https://reviews.llvm.org/D5

[clang-tools-extra] r343593 - [clangd] Add a #include completion test that triggers an assertion.

2018-10-02 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Oct 2 07:46:08 2018 New Revision: 343593 URL: http://llvm.org/viewvc/llvm-project?rev=343593&view=rev Log: [clangd] Add a #include completion test that triggers an assertion. Summary: Test for https://reviews.llvm.org/D52774. Reviewers: sammccall Reviewed By: sammccall

[clang-tools-extra] r343608 - [clangd] Don't make check-clangd as a dependency in check-clang-tools

2018-10-02 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Oct 2 10:22:11 2018 New Revision: 343608 URL: http://llvm.org/viewvc/llvm-project?rev=343608&view=rev Log: [clangd] Don't make check-clangd as a dependency in check-clang-tools Summary: check-clang-tools will run check-clangd first, and then run the rest tests. If clangd

[clang-tools-extra] r343763 - [clangd] Use canonical declarations in ReferenceFinder.

2018-10-04 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Oct 4 02:56:08 2018 New Revision: 343763 URL: http://llvm.org/viewvc/llvm-project?rev=343763&view=rev Log: [clangd] Use canonical declarations in ReferenceFinder. Summary: handleDeclOccurrencce reports a canonical declartion, so stick to use canonical declarations to det

r343767 - [Index] Respect "IndexFunctionLocals" option for type loc.

2018-10-04 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Oct 4 04:03:55 2018 New Revision: 343767 URL: http://llvm.org/viewvc/llvm-project?rev=343767&view=rev Log: [Index] Respect "IndexFunctionLocals" option for type loc. Summary: Previously, clang index ignored local symbols defined in the function body even IndexFunctionLoc

[clang-tools-extra] r343963 - [clangd] Update the out-of-date yaml-symbol-file flag in clangd.

2018-10-08 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 8 03:44:54 2018 New Revision: 343963 URL: http://llvm.org/viewvc/llvm-project?rev=343963&view=rev Log: [clangd] Update the out-of-date yaml-symbol-file flag in clangd. Summary: The flag is stale due to the recent changes of clangd indexer, this patch renames the flag

[clang-tools-extra] r353026 - [clangd] Update vscode dependencies

2019-02-04 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 4 01:20:41 2019 New Revision: 353026 URL: http://llvm.org/viewvc/llvm-project?rev=353026&view=rev Log: [clangd] Update vscode dependencies This allows us to use latest LSP v3.14.0 (for go-to-declaration feature). Modified: clang-tools-extra/trunk/clangd/clients/

[clang-tools-extra] r353027 - [clangd] Bump vscode-clangd v0.0.10

2019-02-04 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 4 01:26:42 2019 New Revision: 353027 URL: http://llvm.org/viewvc/llvm-project?rev=353027&view=rev Log: [clangd] Bump vscode-clangd v0.0.10 CHANGELOG: - cleanup filestatus caches when clangd crashes - extension workwith LSP v3.14.0, support go-to-declaration feature

[clang-tools-extra] r353283 - [clangd] Some minor fixes.

2019-02-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Feb 6 01:08:26 2019 New Revision: 353283 URL: http://llvm.org/viewvc/llvm-project?rev=353283&view=rev Log: [clangd] Some minor fixes. Reviewers: ilya-biryukov Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision: ht

[clang-tools-extra] r353284 - [clangd] Add CLI flag "-clang-tidy" to enable/disable running clang-tidy checks.

2019-02-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Feb 6 01:10:47 2019 New Revision: 353284 URL: http://llvm.org/viewvc/llvm-project?rev=353284&view=rev Log: [clangd] Add CLI flag "-clang-tidy" to enable/disable running clang-tidy checks. Reviewers: sammccall Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphama

[clang-tools-extra] r353306 - [clangd] Format tweak's replacements.

2019-02-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Feb 6 07:24:50 2019 New Revision: 353306 URL: http://llvm.org/viewvc/llvm-project?rev=353306&view=rev Log: [clangd] Format tweak's replacements. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp clang-tools-extra/trunk/clangd/ClangdUnit.cpp clang-tool

[clang-tools-extra] r353309 - [clangd] Bump vscode-clangd v0.0.11

2019-02-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Feb 6 07:29:54 2019 New Revision: 353309 URL: http://llvm.org/viewvc/llvm-project?rev=353309&view=rev Log: [clangd] Bump vscode-clangd v0.0.11 CHANGELOG: - activate the extension on ObjC files. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.j

[clang-tools-extra] r353421 - [clangd] Fix an assertion failure in Selection.

2019-02-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Feb 7 08:00:44 2019 New Revision: 353421 URL: http://llvm.org/viewvc/llvm-project?rev=353421&view=rev Log: [clangd] Fix an assertion failure in Selection. Summary: The assertion is triggered when the Decl is null. Details for the assertion: F0207 09:55:09.069385 4730

[clang-tools-extra] r353712 - Revamp the "[clangd] Format tweak's replacements"

2019-02-11 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 11 07:18:11 2019 New Revision: 353712 URL: http://llvm.org/viewvc/llvm-project?rev=353712&view=rev Log: Revamp the "[clangd] Format tweak's replacements" Summary: This patch contains two parts: 1) reverts commit r353306. 2) move the format logic out from tweaks, keep

[clang-tools-extra] r354664 - [clangd] Don't attach FixIt to the source code in macro.

2019-02-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Feb 22 01:43:56 2019 New Revision: 354664 URL: http://llvm.org/viewvc/llvm-project?rev=354664&view=rev Log: [clangd] Don't attach FixIt to the source code in macro. Summary: We are less certain it is the correct fix. Also, clang doesn't apply FixIt to the source code in m

[clang-tools-extra] r354792 - [clangd] Drop documentation in static index if symbols are not indexed for completion.

2019-02-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 25 08:00:00 2019 New Revision: 354792 URL: http://llvm.org/viewvc/llvm-project?rev=354792&view=rev Log: [clangd] Drop documentation in static index if symbols are not indexed for completion. Summary: This is a further optimization of r350803, we drop docs in static i

[clang-tools-extra] r362226 - [clangd] Add missing license for rename.cpp, NFC.

2019-05-31 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri May 31 07:38:16 2019 New Revision: 362226 URL: http://llvm.org/viewvc/llvm-project?rev=362226&view=rev Log: [clangd] Add missing license for rename.cpp, NFC. Modified: clang-tools-extra/trunk/clangd/refactor/Rename.cpp Modified: clang-tools-extra/trunk/clangd/refacto

[clang-tools-extra] r362361 - [clang-tidy] Fix make-unique check to work in C++17 mode.

2019-06-03 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Jun 3 01:14:15 2019 New Revision: 362361 URL: http://llvm.org/viewvc/llvm-project?rev=362361&view=rev Log: [clang-tidy] Fix make-unique check to work in C++17 mode. Summary: Previously, we intended to omit the check fix to the case when constructor has any braced-init-li

[clang-tools-extra] r362679 - [clang-tidy] Fix make-unique tests on C++2a.

2019-06-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jun 6 00:48:55 2019 New Revision: 362679 URL: http://llvm.org/viewvc/llvm-project?rev=362679&view=rev Log: [clang-tidy] Fix make-unique tests on C++2a. Summary: These test cases are illgal in C++2a ("new Foo{}" needs to see the default constructor), so move them to the C

[clang-tools-extra] r362701 - [clang-tidy] Fix an assertion failure in misc-redundant-expression.

2019-06-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jun 6 05:58:48 2019 New Revision: 362701 URL: http://llvm.org/viewvc/llvm-project?rev=362701&view=rev Log: [clang-tidy] Fix an assertion failure in misc-redundant-expression. Summary: The assertion "isIntegerConstantExpr" is triggered in the isIntegerConstantExpr(), we s

[clang-tools-extra] r362706 - [clang-tidy] Another attempt to fix misc-redundant-expression check.

2019-06-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jun 6 06:43:38 2019 New Revision: 362706 URL: http://llvm.org/viewvc/llvm-project?rev=362706&view=rev Log: [clang-tidy] Another attempt to fix misc-redundant-expression check. Correct the fix of rL3627011, the isValueDependent guard was added in a wrong place in rL36270

[clang-tools-extra] r363037 - [clangd] Add missing header guard.

2019-06-11 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jun 11 01:50:35 2019 New Revision: 363037 URL: http://llvm.org/viewvc/llvm-project?rev=363037&view=rev Log: [clangd] Add missing header guard. Modified: clang-tools-extra/trunk/clangd/refactor/Rename.h Modified: clang-tools-extra/trunk/clangd/refactor/Rename.h URL:

[clang-tools-extra] r363372 - [clangd] Don't maintain a list of c-family extensions in vscode extension.

2019-06-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jun 14 04:56:13 2019 New Revision: 363372 URL: http://llvm.org/viewvc/llvm-project?rev=363372&view=rev Log: [clangd] Don't maintain a list of c-family extensions in vscode extension. Summary: There is no need to maintain this list by ourself, vscode already provides this

[clang-tools-extra] r363375 - [clangd] Bump vscode-clangd v0.0.14

2019-06-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jun 14 05:11:04 2019 New Revision: 363375 URL: http://llvm.org/viewvc/llvm-project?rev=363375&view=rev Log: [clangd] Bump vscode-clangd v0.0.14 CHANGELOG: - use the vscode-buildin feature to detect language (rather than using file extensions), this fixes the extension n

[clang-tools-extra] r363554 - [clangd] Detect C++ for extension-less source files in vscode extension

2019-06-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Jun 17 05:59:14 2019 New Revision: 363554 URL: http://llvm.org/viewvc/llvm-project?rev=363554&view=rev Log: [clangd] Detect C++ for extension-less source files in vscode extension Summary: Extend our extension to support detecting these files as C++ files based on the fi

[clang-tools-extra] r363555 - [clangd] Bump vscode-clangd v0.0.15.

2019-06-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Jun 17 06:18:24 2019 New Revision: 363555 URL: http://llvm.org/viewvc/llvm-project?rev=363555&view=rev Log: [clangd] Bump vscode-clangd v0.0.15. CHANGELOG: - support detecting C++ language from first line (`-*- C++ -*-`) of the file. Modified: clang-tools-extra/trunk

[clang-tools-extra] r363568 - [clangd] Perform merge for main file symbols.

2019-06-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Jun 17 07:49:18 2019 New Revision: 363568 URL: http://llvm.org/viewvc/llvm-project?rev=363568&view=rev Log: [clangd] Perform merge for main file symbols. Summary: Previously, we randomly pick one main file symbol in dynamic index, we may loose the ideal symbol (with defin

[clang-tools-extra] r363662 - [clangd] Detect C++ language based on well-known file path in vscode extension

2019-06-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jun 18 04:53:14 2019 New Revision: 363662 URL: http://llvm.org/viewvc/llvm-project?rev=363662&view=rev Log: [clangd] Detect C++ language based on well-known file path in vscode extension Summary: Matching the "C++" pattern on the first line of the file doesn't cover all c

[clang-tools-extra] r363663 - [clangd] Parse files without extensions if we don't have a compile command.

2019-06-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jun 18 04:54:17 2019 New Revision: 363663 URL: http://llvm.org/viewvc/llvm-project?rev=363663&view=rev Log: [clangd] Parse files without extensions if we don't have a compile command. Summary: This would enable clangd for C++ standard library files. Reviewers: sammccall

[clang-tools-extra] r363681 - [clangd] Remove the extra ";", NFC

2019-06-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jun 18 06:52:00 2019 New Revision: 363681 URL: http://llvm.org/viewvc/llvm-project?rev=363681&view=rev Log: [clangd] Remove the extra ";", NFC Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/DumpAST.cpp Modified: clang-tools-extra/trunk/clangd/refactor/tweak

[clang-tools-extra] r363798 - [clangd] Correct the MessageType enum values.

2019-06-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jun 19 06:14:59 2019 New Revision: 363798 URL: http://llvm.org/viewvc/llvm-project?rev=363798&view=rev Log: [clangd] Correct the MessageType enum values. Modified: clang-tools-extra/trunk/clangd/Protocol.h Modified: clang-tools-extra/trunk/clangd/Protocol.h URL: htt

[clang-tools-extra] r365882 - [clangd] Don't run the prepare for tweaks that are disabled.

2019-07-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jul 12 01:50:20 2019 New Revision: 365882 URL: http://llvm.org/viewvc/llvm-project?rev=365882&view=rev Log: [clangd] Don't run the prepare for tweaks that are disabled. Summary: Previously, we ran the prepare, even for the tweaks that are disabled. Reviewers: sammccall

[clang-tools-extra] r365885 - [clangd] Move the expandAuto tweak from global namespace into annoymous namespace.

2019-07-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jul 12 02:38:53 2019 New Revision: 365885 URL: http://llvm.org/viewvc/llvm-project?rev=365885&view=rev Log: [clangd] Move the expandAuto tweak from global namespace into annoymous namespace. Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/ExpandAutoType.cpp

[clang-tools-extra] r366446 - [clangd] Suppress unwritten scopes when expanding auto.

2019-07-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jul 18 08:13:45 2019 New Revision: 366446 URL: http://llvm.org/viewvc/llvm-project?rev=366446&view=rev Log: [clangd] Suppress unwritten scopes when expanding auto. Summary: otherwise the replacement will break the code. Reviewers: sammccall Subscribers: ilya-biryukov, M

[clang-tools-extra] r366541 - [clangd] cleanup: unify the implemenation of checking a location is inside main file.

2019-07-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jul 19 01:33:39 2019 New Revision: 366541 URL: http://llvm.org/viewvc/llvm-project?rev=366541&view=rev Log: [clangd] cleanup: unify the implemenation of checking a location is inside main file. Summary: We have variant implementations in the codebase, this patch unifies

[clang-tools-extra] r366873 - [clangd] Implement "prepareRename"

2019-07-24 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jul 24 00:49:23 2019 New Revision: 366873 URL: http://llvm.org/viewvc/llvm-project?rev=366873&view=rev Log: [clangd] Implement "prepareRename" Summary: - "prepareRename" request is added in LSP v3.12.0 - also update the vscode-client dependency to pick-up the rename bug f

[clang-tools-extra] r366875 - [clangd] Update a stale comment, NFC.

2019-07-24 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jul 24 00:57:25 2019 New Revision: 366875 URL: http://llvm.org/viewvc/llvm-project?rev=366875&view=rev Log: [clangd] Update a stale comment, NFC. Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/ExpandAutoType.cpp Modified: clang-tools-extra/trunk/clangd/refa

[clang-tools-extra] r366877 - [clangd] Bump vscode-clangd v0.0.16

2019-07-24 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jul 24 01:14:29 2019 New Revision: 366877 URL: http://llvm.org/viewvc/llvm-project?rev=366877&view=rev Log: [clangd] Bump vscode-clangd v0.0.16 CHANGELOG: - detect C++ language based on some well-known file paths - upgrade the lsp-client and lsp-server dependencies Modif

[clang-tools-extra] r366996 - [clangd] Fix the annotate tweak after rL366893

2019-07-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jul 25 01:48:05 2019 New Revision: 366996 URL: http://llvm.org/viewvc/llvm-project?rev=366996&view=rev Log: [clangd] Fix the annotate tweak after rL366893 Summary: After rL366893, the annoate tweak is not activated when we select the whole file (the commonAncestor is TUDe

[clang-tools-extra] r367313 - [clangd] Fix a regression in rL366996.

2019-07-30 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jul 30 07:17:45 2019 New Revision: 367313 URL: http://llvm.org/viewvc/llvm-project?rev=367313&view=rev Log: [clangd] Fix a regression in rL366996. Summary: That patch made the tweak always annotate the whole file by accident. Reviewers: jvikstrom Subscribers: ilya-biryu

[clang-tools-extra] r367684 - [clangd][vscode] clang-format the the extension code.

2019-08-02 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 2 07:24:02 2019 New Revision: 367684 URL: http://llvm.org/viewvc/llvm-project?rev=367684&view=rev Log: [clangd][vscode] clang-format the the extension code. Summary: As we are going to grow the extension in the near future, it is time to formalize the TS code format/

[clang-tools-extra] r367845 - [clangd] Add a callback mechanism for handling responses from client.

2019-08-05 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Aug 5 05:48:09 2019 New Revision: 367845 URL: http://llvm.org/viewvc/llvm-project?rev=367845&view=rev Log: [clangd] Add a callback mechanism for handling responses from client. Summary: The callback will be invoked in clangd when we receive a reply from the client. This

[clang-tools-extra] r368277 - [clangd] Correct the documentation, NFC.

2019-08-08 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Aug 8 03:58:16 2019 New Revision: 368277 URL: http://llvm.org/viewvc/llvm-project?rev=368277&view=rev Log: [clangd] Correct the documentation, NFC. Modified: clang-tools-extra/trunk/clangd/unittests/TweakTesting.h Modified: clang-tools-extra/trunk/clangd/unittests/T

[clang-tools-extra] r368282 - [clangd] Remove a function accidently being added in rL368261.

2019-08-08 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Aug 8 05:19:01 2019 New Revision: 368282 URL: http://llvm.org/viewvc/llvm-project?rev=368282&view=rev Log: [clangd] Remove a function accidently being added in rL368261. Modified: clang-tools-extra/trunk/clangd/AST.cpp Modified: clang-tools-extra/trunk/clangd/AST.cp

[clang-tools-extra] r368283 - [clangd] Don't include internal gtest header.

2019-08-08 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Aug 8 05:33:12 2019 New Revision: 368283 URL: http://llvm.org/viewvc/llvm-project?rev=368283&view=rev Log: [clangd] Don't include internal gtest header. Modified: clang-tools-extra/trunk/clangd/unittests/PrintASTTests.cpp Modified: clang-tools-extra/trunk/clangd/uni

[clang-tools-extra] r368429 - [clangd] Use raw rename functions to implement the rename.

2019-08-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 9 03:55:22 2019 New Revision: 368429 URL: http://llvm.org/viewvc/llvm-project?rev=368429&view=rev Log: [clangd] Use raw rename functions to implement the rename. Summary: The API provided by refactoring lib doesn't provide enough flexibility to get clangd's rename to

<    1   2   3   4   5   6   7   8   9   10   >