[clang-tools-extra] r339116 - [clangd] Share getSymbolID implementation.

2018-08-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Aug 7 01:57:52 2018 New Revision: 339116 URL: http://llvm.org/viewvc/llvm-project?rev=339116&view=rev Log: [clangd] Share getSymbolID implementation. Summary: And remove all duplicated implementation. Reviewers: ioeric Subscribers: ilya-biryukov, MaskRay, jkorous, arph

[clang-tools-extra] r339415 - [clang-tidy] Omit cases where loop variable is not used in loop body in

2018-08-10 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 10 01:25:51 2018 New Revision: 339415 URL: http://llvm.org/viewvc/llvm-project?rev=339415&view=rev Log: [clang-tidy] Omit cases where loop variable is not used in loop body in performance-for-range-copy check. Summary: The upstream change r336737 make the check too sm

[clang-tools-extra] r339416 - [clangd] Fix a "-Wdangling-else" compiler warning in the test.

2018-08-10 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 10 01:34:16 2018 New Revision: 339416 URL: http://llvm.org/viewvc/llvm-project?rev=339416&view=rev Log: [clangd] Fix a "-Wdangling-else" compiler warning in the test. Modified: clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp Modified: clang-tools-e

r339558 - Revert "Allow relockable scopes with thread safety attributes."

2018-08-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Aug 13 05:50:30 2018 New Revision: 339558 URL: http://llvm.org/viewvc/llvm-project?rev=339558&view=rev Log: Revert "Allow relockable scopes with thread safety attributes." This reverts commit r339456. The change introduces a new crash, see class SCOPED_LOCKABLE FileLock

[clang-tools-extra] r340001 - [clangd] Always use the latest preamble

2018-08-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 17 01:15:22 2018 New Revision: 340001 URL: http://llvm.org/viewvc/llvm-project?rev=340001&view=rev Log: [clangd] Always use the latest preamble Summary: Fix an inconsistent behavior of using `LastBuiltPreamble`/`NewPreamble` in TUScheduler (see the test for details),

r340029 - [Preamble] Empty preamble is not an error.

2018-08-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 17 07:25:10 2018 New Revision: 340029 URL: http://llvm.org/viewvc/llvm-project?rev=340029&view=rev Log: [Preamble] Empty preamble is not an error. Summary: Empty preamble is valid for source file which doesn't have any preprocessor and #includes. This patch makes cla

[clang-tools-extra] r340035 - [clangd] Add a testcase for empty preamble.

2018-08-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 17 07:55:57 2018 New Revision: 340035 URL: http://llvm.org/viewvc/llvm-project?rev=340035&view=rev Log: [clangd] Add a testcase for empty preamble. Summary: This is a patch of add a testcase for https://reviews.llvm.org/D50628. Reviewers: ilya-biryukov Subscribers:

[clang-tools-extra] r340038 - [clang-tidy] Abseil: integral division of Duration check

2018-08-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 17 08:19:19 2018 New Revision: 340038 URL: http://llvm.org/viewvc/llvm-project?rev=340038&view=rev Log: [clang-tidy] Abseil: integral division of Duration check This check is an abseil specific test that tests to ensure users utilize abseil specific floating point di

[clang-tools-extra] r340075 - [clang-tidy] Add missing check documentation.

2018-08-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 17 12:50:22 2018 New Revision: 340075 URL: http://llvm.org/viewvc/llvm-project?rev=340075&view=rev Log: [clang-tidy] Add missing check documentation. Added: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-duration-division.rst Added: clang-tools-extra/trun

[clang-tools-extra] r340156 - [clangd] Add missing lock in the lookup.

2018-08-20 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Aug 20 02:07:59 2018 New Revision: 340156 URL: http://llvm.org/viewvc/llvm-project?rev=340156&view=rev Log: [clangd] Add missing lock in the lookup. Reviewers: ioeric Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential Revision: ht

[clang-tools-extra] r340161 - [clangd] Simplify the code using UniqueStringSaver, NFC.

2018-08-20 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Aug 20 02:47:12 2018 New Revision: 340161 URL: http://llvm.org/viewvc/llvm-project?rev=340161&view=rev Log: [clangd] Simplify the code using UniqueStringSaver, NFC. Modified: clang-tools-extra/trunk/clangd/index/Index.cpp clang-tools-extra/trunk/clangd/index/Index

r340403 - [Preamble] Fix an undefined behavior when checking an empty preamble can be reused.

2018-08-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Aug 22 05:34:04 2018 New Revision: 340403 URL: http://llvm.org/viewvc/llvm-project?rev=340403&view=rev Log: [Preamble] Fix an undefined behavior when checking an empty preamble can be reused. Summary: Passing nullptr to memcmp is UB. Reviewers: ilya-biryukov Reviewed B

[clang-tools-extra] r340411 - [clang-tidy] Abseil: faster strsplit delimiter check

2018-08-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Aug 22 06:58:25 2018 New Revision: 340411 URL: http://llvm.org/viewvc/llvm-project?rev=340411&view=rev Log: [clang-tidy] Abseil: faster strsplit delimiter check This check is an abseil specific check that checks for code using single character string literals as delimite

[clang-tools-extra] r340412 - [clang-tidy] Add Abseil prefix to documentation

2018-08-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Aug 22 07:03:30 2018 New Revision: 340412 URL: http://llvm.org/viewvc/llvm-project?rev=340412&view=rev Log: [clang-tidy] Add Abseil prefix to documentation Summary: Adds the Abseil prefix to the list of prefixes in the documentation Patch by Deanna Garcia! Reviewers: aa

r315286 - Fix small nits in clang-refactor doc.

2017-10-10 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Oct 10 02:00:56 2017 New Revision: 315286 URL: http://llvm.org/viewvc/llvm-project?rev=315286&view=rev Log: Fix small nits in clang-refactor doc. Modified: cfe/trunk/docs/RefactoringEngine.rst Modified: cfe/trunk/docs/RefactoringEngine.rst URL: http://llvm.org/viewv

r315290 - [clang-refactor] Fix clang-tidy misc-move-const-arg warning.

2017-10-10 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Oct 10 02:48:38 2017 New Revision: 315290 URL: http://llvm.org/viewvc/llvm-project?rev=315290&view=rev Log: [clang-refactor] Fix clang-tidy misc-move-const-arg warning. NFC Modified: cfe/trunk/tools/clang-refactor/ClangRefactor.cpp Modified: cfe/trunk/tools/clang-re

r315452 - [clang-rename] Don't add prefix qualifiers to the declaration and definition of the renamed symbol.

2017-10-11 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 11 04:15:48 2017 New Revision: 315452 URL: http://llvm.org/viewvc/llvm-project?rev=315452&view=rev Log: [clang-rename] Don't add prefix qualifiers to the declaration and definition of the renamed symbol. Reviewers: ioeric Reviewed By: ioeric Subscribers: klimek, cf

r315459 - [clang-rename] Add more unittest.

2017-10-11 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 11 07:00:42 2017 New Revision: 315459 URL: http://llvm.org/viewvc/llvm-project?rev=315459&view=rev Log: [clang-rename] Add more unittest. Modified: cfe/trunk/unittests/Rename/RenameClassTest.cpp Modified: cfe/trunk/unittests/Rename/RenameClassTest.cpp URL: http:

r315688 - Remove an unused variable.

2017-10-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 13 08:34:03 2017 New Revision: 315688 URL: http://llvm.org/viewvc/llvm-project?rev=315688&view=rev Log: Remove an unused variable. Fix -Wunused-but-set-variable warning. Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified: cfe/trunk/lib/Sema/SemaType.cpp URL: ht

r315689 - Fix an unused-variable warning.

2017-10-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 13 08:37:53 2017 New Revision: 315689 URL: http://llvm.org/viewvc/llvm-project?rev=315689&view=rev Log: Fix an unused-variable warning. Modified: cfe/trunk/lib/CodeGen/CGClass.cpp Modified: cfe/trunk/lib/CodeGen/CGClass.cpp URL: http://llvm.org/viewvc/llvm-proje

r315898 - [clang-rename] Add function unit tests.

2017-10-16 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 16 03:37:42 2017 New Revision: 315898 URL: http://llvm.org/viewvc/llvm-project?rev=315898&view=rev Log: [clang-rename] Add function unit tests. Summary: Also contain a fix: * Fix a false positive of renaming a using shadow function declaration. Reviewers: ioeric Re

r315999 - [clang-rename] Rename enum.

2017-10-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Oct 17 07:14:41 2017 New Revision: 315999 URL: http://llvm.org/viewvc/llvm-project?rev=315999&view=rev Log: [clang-rename] Rename enum. Summary: * Add unit tests for renaming enum. * Support unscoped enum constants in expressions. Reviewers: ioeric Reviewed By: ioeric

[clang-tools-extra] r316066 - New -assume-filename=param to check_clang_tidy.py (like clang-format)

2017-10-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 18 00:48:40 2017 New Revision: 316066 URL: http://llvm.org/viewvc/llvm-project?rev=316066&view=rev Log: New -assume-filename=param to check_clang_tidy.py (like clang-format) Summary: Currently, check_clang_tidy.py includes logic to select default clang flags based on

r316074 - [clang-rename] Rename alias.

2017-10-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 18 05:10:11 2017 New Revision: 316074 URL: http://llvm.org/viewvc/llvm-project?rev=316074&view=rev Log: [clang-rename] Rename alias. Summary: * Support rename alias. * Add unittests for renaming alias. * Don't generate fixes for the SourceLocations that are invalid or

[clang-tools-extra] r316090 - Support Objective-C/C++ source files in check_clang_tidy.py

2017-10-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 18 08:56:39 2017 New Revision: 316090 URL: http://llvm.org/viewvc/llvm-project?rev=316090&view=rev Log: Support Objective-C/C++ source files in check_clang_tidy.py check_clang_tidy.py currently only handles C and C++ source files. This extends the logic to also handl

r316152 - Fix a few nits in RenamingAction.

2017-10-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Oct 19 01:20:55 2017 New Revision: 316152 URL: http://llvm.org/viewvc/llvm-project?rev=316152&view=rev Log: Fix a few nits in RenamingAction. * Add missing override keyword. * avoid unnecessary copy of std::string. Modified: cfe/trunk/lib/Tooling/Refactoring/Rename/R

r316212 - [clang-refactor] Add "-Inplace" option to the commandline tool.

2017-10-20 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 20 05:37:16 2017 New Revision: 316212 URL: http://llvm.org/viewvc/llvm-project?rev=316212&view=rev Log: [clang-refactor] Add "-Inplace" option to the commandline tool. Summary: Change clang-refactor default behavior to print the new code after refactoring (instead of

[clang-tools-extra] r316221 - [clang-tidy] Add missing test files in r316090.

2017-10-20 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 20 10:54:53 2017 New Revision: 316221 URL: http://llvm.org/viewvc/llvm-project?rev=316221&view=rev Log: [clang-tidy] Add missing test files in r316090. Added: clang-tools-extra/trunk/test/clang-tidy/objc-arc-and-properties.m clang-tools-extra/trunk/test/clang-

r316314 - [rename] Don't overwrite the template argument when renaming a template function.

2017-10-23 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 23 01:58:50 2017 New Revision: 316314 URL: http://llvm.org/viewvc/llvm-project?rev=316314&view=rev Log: [rename] Don't overwrite the template argument when renaming a template function. Reviewers: ioeric Reviewed By: ioeric Subscribers: cierpuchaw, cfe-commits, kli

r316561 - [clang-rename] Fix and enable the failing TemplatedClassFunction test.

2017-10-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 25 01:25:25 2017 New Revision: 316561 URL: http://llvm.org/viewvc/llvm-project?rev=316561&view=rev Log: [clang-rename] Fix and enable the failing TemplatedClassFunction test. Reviewers: ioeric Reviewed By: ioeric Subscribers: klimek, cfe-commits Differential Revisi

r316571 - [rename] support renaming class member.

2017-10-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 25 04:54:45 2017 New Revision: 316571 URL: http://llvm.org/viewvc/llvm-project?rev=316571&view=rev Log: [rename] support renaming class member. Reviewers: ioeric Reviewed By: ioeric Subscribers: klimek, cfe-commits, mgorny Differential Revision: https://reviews.llv

[clang-tools-extra] r340800 - [clang-tidy] Abseil: no namepsace check

2018-08-28 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Aug 28 00:48:28 2018 New Revision: 340800 URL: http://llvm.org/viewvc/llvm-project?rev=340800&view=rev Log: [clang-tidy] Abseil: no namepsace check This check ensures that users of Abseil do not open namespace absl in their code, as that violates our compatibility guidel

[clang-tools-extra] r341208 - [clangd] Collect symbol occurrences in SymbolCollector.

2018-08-31 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 31 05:54:13 2018 New Revision: 341208 URL: http://llvm.org/viewvc/llvm-project?rev=341208&view=rev Log: [clangd] Collect symbol occurrences in SymbolCollector. SymbolCollector will be used for two cases: - collect Symbol type only, used for indexing preamble AST. -

[clang-tools-extra] r341242 - [clangd] Implement findOccurrences interface in dynamic index.

2018-08-31 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 31 12:53:37 2018 New Revision: 341242 URL: http://llvm.org/viewvc/llvm-project?rev=341242&view=rev Log: [clangd] Implement findOccurrences interface in dynamic index. Summary: Implement the interface in - FileIndex - MemIndex - MergeIndex Depends on https://rev

[clang-tools-extra] r341463 - [clangd] Sort GoToDefinition results.

2018-09-05 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Sep 5 05:00:15 2018 New Revision: 341463 URL: http://llvm.org/viewvc/llvm-project?rev=341463&view=rev Log: [clangd] Sort GoToDefinition results. Summary: GoToDefinition returns all declaration results (implicit/explicit) that are in the same location, and the results are

[clang-tools-extra] r338517 - [clangd] Make SymbolLocation => bool conversion explicitly.

2018-08-01 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Aug 1 04:24:50 2018 New Revision: 338517 URL: http://llvm.org/viewvc/llvm-project?rev=338517&view=rev Log: [clangd] Make SymbolLocation => bool conversion explicitly. Summary: The implicit bool conversion could happen superisingly, e.g. when checking `if (Loc1 == Loc2)`,

[clang-tools-extra] r338526 - [clangd] Correct the namespace of ParsedAST forward declaration, NFC.

2018-08-01 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Aug 1 05:50:44 2018 New Revision: 338526 URL: http://llvm.org/viewvc/llvm-project?rev=338526&view=rev Log: [clangd] Correct the namespace of ParsedAST forward declaration, NFC. Modified: clang-tools-extra/trunk/clangd/FindSymbols.h Modified: clang-tools-extra/trunk/

[clang-tools-extra] r339011 - [clangd] Index Interfaces for Xrefs

2018-08-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Aug 6 06:14:32 2018 New Revision: 339011 URL: http://llvm.org/viewvc/llvm-project?rev=339011&view=rev Log: [clangd] Index Interfaces for Xrefs Summary: This is the first step of implementing Xrefs in clangd: - add index interfaces, and related data structures. Reviewe

[clang-tools-extra] r324328 - [clangd] Fix incorrect file path for symbols defined by the compile command-line option.

2018-02-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Feb 6 01:50:35 2018 New Revision: 324328 URL: http://llvm.org/viewvc/llvm-project?rev=324328&view=rev Log: [clangd] Fix incorrect file path for symbols defined by the compile command-line option. Summary: Reviewers: ioeric Reviewed By: ioeric Subscribers: klimek, ily

[clang-tools-extra] r324742 - [clang-move] Don't dump macro symbols.

2018-02-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Feb 9 07:57:30 2018 New Revision: 324742 URL: http://llvm.org/viewvc/llvm-project?rev=324742&view=rev Log: [clang-move] Don't dump macro symbols. Reviewers: ioeric Subscribers: klimek, cfe-commits Differential Revision: https://reviews.llvm.org/D43075 Modified: cl

[clang-tools-extra] r324886 - [clang-move] Fix the incorrect expansion end location.

2018-02-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 12 04:26:12 2018 New Revision: 324886 URL: http://llvm.org/viewvc/llvm-project?rev=324886&view=rev Log: [clang-move] Fix the incorrect expansion end location. Summary: Before the fix, if clang-move decides to move the following macro statement, it only moves the firs

[clang-tools-extra] r324992 - [clangd] SymbolLocation only covers symbol name.

2018-02-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Feb 13 01:53:50 2018 New Revision: 324992 URL: http://llvm.org/viewvc/llvm-project?rev=324992&view=rev Log: [clangd] SymbolLocation only covers symbol name. Summary: * Change the offset range to half-open, [start, end). * Fix a few fixmes. Reviewers: sammccall Subscribe

[clang-tools-extra] r324993 - [clangd] Remove an already-done FIXME, NFC

2018-02-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Feb 13 01:56:45 2018 New Revision: 324993 URL: http://llvm.org/viewvc/llvm-project?rev=324993&view=rev Log: [clangd] Remove an already-done FIXME, NFC Modified: clang-tools-extra/trunk/clangd/index/Index.h Modified: clang-tools-extra/trunk/clangd/index/Index.h URL:

[clang-tools-extra] r325484 - [clangd] Bump vs-code clangd extension v0.0.3

2018-02-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 19 02:49:12 2018 New Revision: 325484 URL: http://llvm.org/viewvc/llvm-project?rev=325484&view=rev Log: [clangd] Bump vs-code clangd extension v0.0.3 Reviewers: sammccall Subscribers: klimek, ilya-biryukov, jkorous-apple, cfe-commits, ioeric Differential Revision: h

[clang-tools-extra] r325499 - [clangd] Add brief instructions on how to make a release for vscode-clangd extension.

2018-02-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 19 06:01:52 2018 New Revision: 325499 URL: http://llvm.org/viewvc/llvm-project?rev=325499&view=rev Log: [clangd] Add brief instructions on how to make a release for vscode-clangd extension. Reviewers: sammccall Subscribers: klimek, ilya-biryukov, jkorous-apple, ioer

[clang-tools-extra] r325503 - [clangd] Correct the doc, password => Personal Access Token.

2018-02-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 19 06:26:55 2018 New Revision: 325503 URL: http://llvm.org/viewvc/llvm-project?rev=325503&view=rev Log: [clangd] Correct the doc, password => Personal Access Token. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/README.md Modified: clang-tools-ext

[clang-tools-extra] r325779 - [clangd] Correct setting ignoreWarnings in CodeCompletion.

2018-02-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Feb 22 05:35:01 2018 New Revision: 325779 URL: http://llvm.org/viewvc/llvm-project?rev=325779&view=rev Log: [clangd] Correct setting ignoreWarnings in CodeCompletion. Summary: We should set the flag before creating ComplierInstance -- when CopmilerInstance gets initialize

r305898 - Fix unused-variable compilation error.

2017-06-21 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jun 21 06:26:58 2017 New Revision: 305898 URL: http://llvm.org/viewvc/llvm-project?rev=305898&view=rev Log: Fix unused-variable compilation error. Modified: cfe/trunk/lib/Frontend/PrecompiledPreamble.cpp Modified: cfe/trunk/lib/Frontend/PrecompiledPreamble.cpp URL:

[clang-tools-extra] r306091 - [clang-tidy] Fix a false positive in modernize-use-nullptr.

2017-06-23 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jun 23 04:36:49 2017 New Revision: 306091 URL: http://llvm.org/viewvc/llvm-project?rev=306091&view=rev Log: [clang-tidy] Fix a false positive in modernize-use-nullptr. Summary: The FP happens when a casting nullptr expression is used within a NULL-default-arguemnt cxx co

[clang-tools-extra] r320678 - [clangd] Fix the unitttest build error on buildbot.

2017-12-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Dec 14 01:20:21 2017 New Revision: 320678 URL: http://llvm.org/viewvc/llvm-project?rev=320678&view=rev Log: [clangd] Fix the unitttest build error on buildbot. Modified: clang-tools-extra/trunk/unittests/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk/unittes

[clang-tools-extra] r320694 - [clangd] Construct SymbolSlab from YAML format.

2017-12-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Dec 14 04:17:14 2017 New Revision: 320694 URL: http://llvm.org/viewvc/llvm-project?rev=320694&view=rev Log: [clangd] Construct SymbolSlab from YAML format. Summary: This will be used together with D40548 for the global index source (experimental). Reviewers: sammccall

[clang-tools-extra] r321106 - [clangd] Don't use the optional "severity" when comparing Diagnostic.

2017-12-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Dec 19 12:52:56 2017 New Revision: 321106 URL: http://llvm.org/viewvc/llvm-project?rev=321106&view=rev Log: [clangd] Don't use the optional "severity" when comparing Diagnostic. Summary: We use Diagnostic as a key to find the corresponding FixIt when we do the "apply-fix"

[clang-tools-extra] r321252 - [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension.

2017-12-21 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Dec 21 00:45:18 2017 New Revision: 321252 URL: http://llvm.org/viewvc/llvm-project?rev=321252&view=rev Log: [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension. Summary: Previously, we use a separate GitHub repository (https://github.co

[clang-tools-extra] r321358 - [clangd] Add a tool to build YAML-format global symbols.

2017-12-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Dec 22 06:38:05 2017 New Revision: 321358 URL: http://llvm.org/viewvc/llvm-project?rev=321358&view=rev Log: [clangd] Add a tool to build YAML-format global symbols. Summary: The tools is used to generate global symbols for clangd (global code completion), The format is Y

[clang-tools-extra] r322067 - [clangd] Catch more symbols in SymbolCollector.

2018-01-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jan 9 02:44:09 2018 New Revision: 322067 URL: http://llvm.org/viewvc/llvm-project?rev=322067&view=rev Log: [clangd] Catch more symbols in SymbolCollector. Summary: We currently only collect external-linkage symbols in the collector, which results in missing some typical

[clang-tools-extra] r322191 - [clangd] Add static index for the global code completion.

2018-01-10 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jan 10 06:44:34 2018 New Revision: 322191 URL: http://llvm.org/viewvc/llvm-project?rev=322191&view=rev Log: [clangd] Add static index for the global code completion. Summary: Use the YAML-format symbols (generated by the global-symbol-builder tool) to do the global code c

[clang-tools-extra] r326778 - [clangd] Fix -Wpedantic warning, NFC.

2018-03-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Mar 6 04:56:18 2018 New Revision: 326778 URL: http://llvm.org/viewvc/llvm-project?rev=326778&view=rev Log: [clangd] Fix -Wpedantic warning, NFC. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp URL:

[clang-tools-extra] r326799 - [clang-tidy] Fix one corner case in make-unique check.

2018-03-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Mar 6 06:34:35 2018 New Revision: 326799 URL: http://llvm.org/viewvc/llvm-project?rev=326799&view=rev Log: [clang-tidy] Fix one corner case in make-unique check. Summary: Previously, we tried to cover all "std::initializer_list" implicit conversion cases in the code, but

[clang-tools-extra] r327023 - [clangd] Early return for #include goto definition.

2018-03-08 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Mar 8 08:28:12 2018 New Revision: 327023 URL: http://llvm.org/viewvc/llvm-project?rev=327023&view=rev Log: [clangd] Early return for #include goto definition. Summary: This would save cost of walking over the AST, NFC. Reviewers: ilya-biryukov Subscribers: klimek, jkor

[clang-tools-extra] r327111 - [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

2018-03-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Mar 9 02:47:14 2018 New Revision: 327111 URL: http://llvm.org/viewvc/llvm-project?rev=327111&view=rev Log: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith Patch by Niko Weh! Reviewers: hokein Subscribers: klimek, cfe-commits, ioeric, ilya-b

[clang-tools-extra] r327129 - [clangd] Use identifier range as the definition range.

2018-03-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Mar 9 06:00:34 2018 New Revision: 327129 URL: http://llvm.org/viewvc/llvm-project?rev=327129&view=rev Log: [clangd] Use identifier range as the definition range. Summary: This also matches the range in symbol index. Reviewers: sammccall Subscribers: klimek, ilya-biryuk

[clang-tools-extra] r327131 - [clangd] Fix failing lit test.

2018-03-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Mar 9 06:16:46 2018 New Revision: 327131 URL: http://llvm.org/viewvc/llvm-project?rev=327131&view=rev Log: [clangd] Fix failing lit test. This test is missed in r327129. Modified: clang-tools-extra/trunk/test/clangd/xrefs.test Modified: clang-tools-extra/trunk/test

[clang-tools-extra] r327293 - [clangd] Fix diagnostic errors in the test code, NFC.

2018-03-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Mar 12 09:49:24 2018 New Revision: 327293 URL: http://llvm.org/viewvc/llvm-project?rev=327293&view=rev Log: [clangd] Fix diagnostic errors in the test code, NFC. Reviewers: ilya-biryukov Reviewed By: ilya-biryukov Subscribers: klimek, jkorous-apple, cfe-commits, ioeric

[clang-tools-extra] r327386 - [clangd] Remove extra ";", NFC.

2018-03-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Mar 13 05:26:28 2018 New Revision: 327386 URL: http://llvm.org/viewvc/llvm-project?rev=327386&view=rev Log: [clangd] Remove extra ";", NFC. Modified: clang-tools-extra/trunk/unittests/clangd/ClangdUnitTests.cpp Modified: clang-tools-extra/trunk/unittests/clangd/Clang

[clang-tools-extra] r327387 - [clangd] Fix irrelevant declaratations in goto definition (on macros).

2018-03-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Mar 13 05:30:59 2018 New Revision: 327387 URL: http://llvm.org/viewvc/llvm-project?rev=327387&view=rev Log: [clangd] Fix irrelevant declaratations in goto definition (on macros). Summary: DeclrationAndMacrosFinder will find some declarations (not macro!) that are referene

[clang-tools-extra] r327401 - [clangd] Use the macro name range as the definition range.

2018-03-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Mar 13 07:31:31 2018 New Revision: 327401 URL: http://llvm.org/viewvc/llvm-project?rev=327401&view=rev Log: [clangd] Use the macro name range as the definition range. Summary: This also aligns with the behavior of declarations. Reviewers: sammccall Reviewed By: sammccal

[clang-tools-extra] r327887 - [clang-move] Fix the failing test caused by changes in clang-format.

2018-03-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Mar 19 12:13:03 2018 New Revision: 327887 URL: http://llvm.org/viewvc/llvm-project?rev=327887&view=rev Log: [clang-move] Fix the failing test caused by changes in clang-format. Modified: clang-tools-extra/trunk/test/clang-move/move-used-helper-decls.cpp Modified: cla

[clang-tools-extra] r333882 - [clangd] Remove the dead offset fields in Symbol.

2018-06-04 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Jun 4 03:43:59 2018 New Revision: 333882 URL: http://llvm.org/viewvc/llvm-project?rev=333882&view=rev Log: [clangd] Remove the dead offset fields in Symbol. Reviewers: sammccall Subscribers: klimek, ilya-biryukov, ioeric, MaskRay, jkorous, cfe-commits Differential Revi

[clang-tools-extra] r334176 - [clangd] Fix using the incorrect Index for go-to-definition.

2018-06-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jun 7 01:49:55 2018 New Revision: 334176 URL: http://llvm.org/viewvc/llvm-project?rev=334176&view=rev Log: [clangd] Fix using the incorrect Index for go-to-definition. Reviewers: sammccall Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, cfe-commits Differential R

[clang-tools-extra] r334270 - [clang-tidy] Improve string type matcher for abseil-string-find-starts-with check.

2018-06-08 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jun 8 01:19:22 2018 New Revision: 334270 URL: http://llvm.org/viewvc/llvm-project?rev=334270&view=rev Log: [clang-tidy] Improve string type matcher for abseil-string-find-starts-with check. Summary: This patch improves the check to match the desugared "string" type (so

[clang-tools-extra] r334812 - [clangd] Fix buildbot error.

2018-06-15 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jun 15 02:32:36 2018 New Revision: 334812 URL: http://llvm.org/viewvc/llvm-project?rev=334812&view=rev Log: [clangd] Fix buildbot error. Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp URL: http://l

[clang-tools-extra] r344054 - [clangd] Fix an accident change in r342999.

2018-10-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Oct 9 08:16:14 2018 New Revision: 344054 URL: http://llvm.org/viewvc/llvm-project?rev=344054&view=rev Log: [clangd] Fix an accident change in r342999. Modified: clang-tools-extra/trunk/clangd/index/YAMLSerialization.cpp Modified: clang-tools-extra/trunk/clangd/index

[clang-tools-extra] r344330 - [clangd] Support hover on "aut^o *".

2018-10-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 12 03:11:02 2018 New Revision: 344330 URL: http://llvm.org/viewvc/llvm-project?rev=344330&view=rev Log: [clangd] Support hover on "aut^o *". Reviewers: kadircet Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, cfe-commits Differential Revision: https:

[clang-tools-extra] r344507 - [clangd] Fix some references missing in dynamic index.

2018-10-15 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 15 04:46:26 2018 New Revision: 344507 URL: http://llvm.org/viewvc/llvm-project?rev=344507&view=rev Log: [clangd] Fix some references missing in dynamic index. Summary: Previously, SymbolCollector postfilters all references at the end to find all references of interest

[clang-tools-extra] r344508 - [clangd] dump xrefs information in dexp tool.

2018-10-15 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 15 05:32:49 2018 New Revision: 344508 URL: http://llvm.org/viewvc/llvm-project?rev=344508&view=rev Log: [clangd] dump xrefs information in dexp tool. Reviewers: sammccall Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differen

[clang-tools-extra] r344510 - [clangd] Remove an unused include header, NFC.

2018-10-15 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 15 05:39:45 2018 New Revision: 344510 URL: http://llvm.org/viewvc/llvm-project?rev=344510&view=rev Log: [clangd] Remove an unused include header, NFC. Modified: clang-tools-extra/trunk/clangd/index/Merge.cpp Modified: clang-tools-extra/trunk/clangd/index/Merge.cp

[clang-tools-extra] r344521 - [clangd] Add createIndex in dexp

2018-10-15 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 15 08:12:40 2018 New Revision: 344521 URL: http://llvm.org/viewvc/llvm-project?rev=344521&view=rev Log: [clangd] Add createIndex in dexp Summary: This would allow easily injecting our internal customization. Also updates the stale "symbol-collection-file" flag. Revi

[clang-tools-extra] r344678 - [clangd] Collect refs from headers.

2018-10-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 17 01:38:36 2018 New Revision: 344678 URL: http://llvm.org/viewvc/llvm-project?rev=344678&view=rev Log: [clangd] Collect refs from headers. Summary: Add a flag to SymbolCollector to collect refs fdrom headers. Note that we collect refs from headers in static index, a

[clang-tools-extra] r344679 - [clangd] Print numbers of symbols and refs as well when loading the

2018-10-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 17 01:48:04 2018 New Revision: 344679 URL: http://llvm.org/viewvc/llvm-project?rev=344679&view=rev Log: [clangd] Print numbers of symbols and refs as well when loading the index. Modified: clang-tools-extra/trunk/clangd/index/Serialization.cpp Modified: clang-too

[clang-tools-extra] r344680 - [clangd] Fix buildbot failure.

2018-10-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 17 01:54:48 2018 New Revision: 344680 URL: http://llvm.org/viewvc/llvm-project?rev=344680&view=rev Log: [clangd] Fix buildbot failure. Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modified: clang-tools-extra/trunk/clangd/index/SymbolCollecto

[clang-tools-extra] r344733 - [clang-tidy] Ignore a case where the fix of make_unique check introduces side effect.

2018-10-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Oct 18 02:13:34 2018 New Revision: 344733 URL: http://llvm.org/viewvc/llvm-project?rev=344733&view=rev Log: [clang-tidy] Ignore a case where the fix of make_unique check introduces side effect. Summary: Previously, ptr.reset(new char[5]) will be replaced with `p = make_u

[clang-tools-extra] r344735 - [clangd] Encode Line/Column as a 32-bits integer.

2018-10-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Oct 18 03:43:50 2018 New Revision: 344735 URL: http://llvm.org/viewvc/llvm-project?rev=344735&view=rev Log: [clangd] Encode Line/Column as a 32-bits integer. Summary: This would buy us more memory. Using a 32-bits integer is enough for most human-readable source code (up

[clang-tools-extra] r344745 - [clangd] Clear the semantic of RefSlab::size.

2018-10-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Oct 18 08:33:20 2018 New Revision: 344745 URL: http://llvm.org/viewvc/llvm-project?rev=344745&view=rev Log: [clangd] Clear the semantic of RefSlab::size. Summary: The RefSlab::size can easily cause confusions, it returns the number of different symbols, rahter than the nu

[clang-tools-extra] r344777 - [clangd] Remove the overflow log.

2018-10-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 19 01:35:24 2018 New Revision: 344777 URL: http://llvm.org/viewvc/llvm-project?rev=344777&view=rev Log: [clangd] Remove the overflow log. Summary: LLVM codebase has generated files (all are build/Target/XXX/*.inc) that exceed the MaxLine & MaxColumn. Printing these lo

[clang-tools-extra] r345134 - [clangd] Hide position line and column fields.

2018-10-24 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 24 05:56:41 2018 New Revision: 345134 URL: http://llvm.org/viewvc/llvm-project?rev=345134&view=rev Log: [clangd] Hide position line and column fields. Reviewers: sammccall Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differe

[clang-tools-extra] r351081 - [clangd] Add Limit parameter for xref.

2019-01-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Jan 14 10:11:09 2019 New Revision: 351081 URL: http://llvm.org/viewvc/llvm-project?rev=351081&view=rev Log: [clangd] Add Limit parameter for xref. Reviewers: sammccall Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential Re

r351222 - [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

2019-01-15 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jan 15 11:05:50 2019 New Revision: 351222 URL: http://llvm.org/viewvc/llvm-project?rev=351222&view=rev Log: [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database. Summary: This is a regression of r348365. When clang-tools r

r351229 - [Tooling] Fix broken compliation databse tests.

2019-01-15 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jan 15 11:51:39 2019 New Revision: 351229 URL: http://llvm.org/viewvc/llvm-project?rev=351229&view=rev Log: [Tooling] Fix broken compliation databse tests. I forgot to update the unittest in r351222. Modified: cfe/trunk/unittests/Tooling/CompilationDatabaseTest.cpp

[clang-tools-extra] r351792 - [clangd] Support clang-tidy configuration in clangd.

2019-01-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jan 22 01:39:05 2019 New Revision: 351792 URL: http://llvm.org/viewvc/llvm-project?rev=351792&view=rev Log: [clangd] Support clang-tidy configuration in clangd. Summary: This patch adds some basic supports for clang-tidy configurations in clangd: - clangd will respe

[clang-tools-extra] r351809 - [clangd] Fix the `-Wtype-limits` warning, NFC

2019-01-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jan 22 04:21:25 2019 New Revision: 351809 URL: http://llvm.org/viewvc/llvm-project?rev=351809&view=rev Log: [clangd] Fix the `-Wtype-limits` warning, NFC The assertion is always true, and triggers a compiler warning, so remove it. Modified: clang-tools-extra/trunk/cl

[clang-tools-extra] r351812 - [clangd] Fix the broken buildbot.

2019-01-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jan 22 04:55:15 2019 New Revision: 351812 URL: http://llvm.org/viewvc/llvm-project?rev=351812&view=rev Log: [clangd] Fix the broken buildbot. Modified: clang-tools-extra/trunk/clangd/tool/CMakeLists.txt Modified: clang-tools-extra/trunk/clangd/tool/CMakeLists.txt URL

[clang-tools-extra] r351826 - [clangd] Followup fix of rL351818

2019-01-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jan 22 06:48:04 2019 New Revision: 351826 URL: http://llvm.org/viewvc/llvm-project?rev=351826&view=rev Log: [clangd] Followup fix of rL351818 ClangTidyOptions::getDefaults is not free, it will initialize all clang-tidy modules to get check-specific options, and we don't u

[clang-tools-extra] r351929 - [clangd] Link clangTidy into clangd tests

2019-01-23 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jan 23 00:04:17 2019 New Revision: 351929 URL: http://llvm.org/viewvc/llvm-project?rev=351929&view=rev Log: [clangd] Link clangTidy into clangd tests Patch by Nathan Ridge! Differential Revision: https://reviews.llvm.org/D57077 Modified: clang-tools-extra/trunk/unit

[clang-tools-extra] r352049 - [clangd] Clean the cache of file statuses on vscode-clangd when clangd crashes.

2019-01-24 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jan 24 06:25:53 2019 New Revision: 352049 URL: http://llvm.org/viewvc/llvm-project?rev=352049&view=rev Log: [clangd] Clean the cache of file statuses on vscode-clangd when clangd crashes. Summary: Clear the cached file statuses, otherwise we will leave some garbage texts

[clang-tools-extra] r352183 - [clang-tidy] Add check for underscores in googletest names.

2019-01-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jan 25 02:03:49 2019 New Revision: 352183 URL: http://llvm.org/viewvc/llvm-project?rev=352183&view=rev Log: [clang-tidy] Add check for underscores in googletest names. Summary: Adds a clang-tidy warning for underscores in googletest names. Patch by Kar Epker! Reviewers:

[clang-tools-extra] r352184 - [clangd] Log clang-tidy configuration, NFC

2019-01-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jan 25 02:14:27 2019 New Revision: 352184 URL: http://llvm.org/viewvc/llvm-project?rev=352184&view=rev Log: [clangd] Log clang-tidy configuration, NFC Summary: This is used for debugging purpose. Reviewers: sammccall Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous,

[clang-tools-extra] r352205 - [clangd] NFC: fix clang-tidy warnings.

2019-01-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jan 25 07:14:03 2019 New Revision: 352205 URL: http://llvm.org/viewvc/llvm-project?rev=352205&view=rev Log: [clangd] NFC: fix clang-tidy warnings. Most are about llvm code style violation (found via readability-identifier-naming check). Modified: clang-tools-extra/tr

[clang-tools-extra] r352364 - [clang-tidy] Fix a build error.

2019-01-28 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Jan 28 06:07:45 2019 New Revision: 352364 URL: http://llvm.org/viewvc/llvm-project?rev=352364&view=rev Log: [clang-tidy] Fix a build error. Modified: clang-tools-extra/trunk/clang-tidy/abseil/DurationAdditionCheck.cpp Modified: clang-tools-extra/trunk/clang-tidy/abse

[clang-tools-extra] r352367 - [clangd] Index main-file macros (bug 39761)

2019-01-28 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Jan 28 06:11:49 2019 New Revision: 352367 URL: http://llvm.org/viewvc/llvm-project?rev=352367&view=rev Log: [clangd] Index main-file macros (bug 39761) Patch by Nathan Ridge! Differential Revision: https://reviews.llvm.org/D55739 Modified: clang-tools-extra/trunk/cl

[clang-tools-extra] r352485 - [clangd] dlog clang-tidy configuration

2019-01-29 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jan 29 04:32:32 2019 New Revision: 352485 URL: http://llvm.org/viewvc/llvm-project?rev=352485&view=rev Log: [clangd] dlog clang-tidy configuration vlog seems to be too spammy in unittests. Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools

  1   2   3   4   5   6   7   8   9   10   >