I'm OK with it if Richard gives owner's approval.
Cheers,
Hans
On Fri, Aug 14, 2015 at 12:25 PM, Martell Malone
wrote:
> martell added a comment.
>
> Hans this is something we most definitely should have in 3.7
> It's a pretty big bugfix for this target :)
>
>
> http://reviews.llvm.org/D12037
>
hans added a comment.
I'm OK with it if Richard gives owner's approval.
Cheers,
Hans
http://reviews.llvm.org/D12037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
(+ the new cfe-commits list; sorry for the spam)
On Fri, Aug 14, 2015 at 1:25 PM, Hans Wennborg wrote:
> Reid and Nico suggested this should be merged to 3.7 together with
> r244468 as it fixes an issue with libc++ when compiled with Clang on
> x86_64 Android.
>
> John, you're the CodeGen owner.
On Fri, Aug 14, 2015 at 1:55 PM, John McCall wrote:
>> On Aug 14, 2015, at 1:25 PM, Hans Wennborg wrote:
>> Reid and Nico suggested this should be merged to 3.7 together with
>> r244468 as it fixes an issue with libc++ when compiled with Clang on
>> x86_64 Android.
>>
>> John, you're the CodeGen
Thanks! r245116.
On Fri, Aug 14, 2015 at 3:30 PM, Richard Smith wrote:
> Sorry for the delay, this LGTM for branch.
>
>
> On Wed, Aug 12, 2015 at 1:09 AM, AlexDenisov <1101.deb...@gmail.com> wrote:
>>
>> Ping
>> --
>> AlexDenisov
>> Software Engineer, http://lowlevelbits.org
>>
>> > On 06 Aug 201
hans updated the summary for this revision.
hans updated this revision to Diff 32201.
hans marked an inline comment as done.
hans added a comment.
Addressed comments.
http://reviews.llvm.org/D11850
Files:
include/clang/Sema/Sema.h
lib/Parse/ParseDeclCXX.cpp
lib/Sema/Sema.cpp
lib/Sema/Se
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245139: Delay emitting members of dllexport classes until
the class is fully parsed… (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D11850?vs=32201&id=32207#toc
Repository:
rL L
Author: hans
Date: Fri Aug 14 20:18:16 2015
New Revision: 245139
URL: http://llvm.org/viewvc/llvm-project?rev=245139&view=rev
Log:
Delay emitting members of dllexport classes until the class is fully parsed
(PR23542)
This enables Clang to correctly handle code such as:
struct __declspec(dllex
On Fri, Aug 14, 2015 at 2:02 PM, Hans Wennborg wrote:
> On Fri, Aug 14, 2015 at 1:55 PM, John McCall wrote:
>>> On Aug 14, 2015, at 1:25 PM, Hans Wennborg wrote:
>>> Reid and Nico suggested this should be merged to 3.7 together with
>>> r244468 as it fixes an issue with libc++ when compiled with
Merged in r245229.
There were merge conflicts in StmtOpenMP.h because we don't have
r244209 on the branch. I think I got it right, but I'd appreciate if
someone could double check
http://llvm.org/viewvc/llvm-project?rev=245229&view=rev
Thanks,
Hans
On Sun, Aug 16, 2015 at 8:55 PM, Bataev, Alexey
The 3.7 branch does have the include guards; they were re-added in
http://llvm.org/viewvc/llvm-project?rev=243925&view=rev. That happened
after rc2, but it will be in rc3.
Can you double check if you're still running into problems on the 3.7 branch?
- Hans
On Mon, Aug 17, 2015 at 3:04 PM, Dimi
Author: hans
Date: Mon Aug 17 18:38:56 2015
New Revision: 245259
URL: http://llvm.org/viewvc/llvm-project?rev=245259&view=rev
Log:
Doxygen: add build option to use svg instead of png files for graphs
Differential Revision: http://reviews.llvm.org/D11994
Modified:
cfe/trunk/docs/CMakeLists.tx
Author: hans
Date: Mon Aug 17 19:17:58 2015
New Revision: 245260
URL: http://llvm.org/viewvc/llvm-project?rev=245260&view=rev
Log:
Revert r245257 "Generating assumption loads of vptr after ctor call"
It caused PR24479
Removed:
cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp
Modified:
cf
I reverted this in r245260 as it caused
https://llvm.org/bugs/show_bug.cgi?id=24479
- Hans
On Mon, Aug 17, 2015 at 4:34 PM, Piotr Padlewski via cfe-commits
wrote:
> Author: prazek
> Date: Mon Aug 17 18:33:49 2015
> New Revision: 245257
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245257&vie
On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote:
> On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits
> wrote:
>> Author: rnk
>> Date: Mon Aug 10 14:39:01 2015
>> New Revision: 244488
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=rev
>> Log:
>> [dllimport] A non
Richard, I tried to ping you on the review thread but I'm not sure it
got through. Martell requested this be merged to 3.7. What do you
think?
On Thu, Aug 13, 2015 at 8:41 AM, Martell Malone via cfe-commits
wrote:
> Author: martell
> Date: Thu Aug 13 10:41:04 2015
> New Revision: 244902
>
> URL:
Richard, I tried to ping you on the review thread but I'm not sure it
got through. Martell requested this be merged to 3.7. What do you
think?
On Fri, Aug 14, 2015 at 12:05 PM, Martell Malone via cfe-commits
wrote:
> Author: martell
> Date: Fri Aug 14 14:05:56 2015
> New Revision: 245084
>
> URL:
Awesome, thanks!
On Tue, Aug 18, 2015 at 4:27 PM, Reid Kleckner wrote:
> I merged both of them and tweaked the test case to make it work.
>
> On Tue, Aug 18, 2015 at 2:55 PM, Hans Wennborg wrote:
>>
>> On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote:
>> > On Mon, Aug 10, 2015 at 12:39 PM,
On Tue, Aug 18, 2015 at 4:52 PM, Richard Smith wrote:
> On Tue, Aug 18, 2015 at 3:00 PM, Hans Wennborg via cfe-commits
> wrote:
>>
>> Richard, I tried to ping you on the review thread but I'm not sure it
>> got through. Martell requested this be merged to 3.7. Wha
On Tue, Aug 18, 2015 at 6:11 PM, Richard Smith wrote:
> On Tue, Aug 18, 2015 at 3:01 PM, Hans Wennborg wrote:
>>
>> Richard, I tried to ping you on the review thread but I'm not sure it
>> got through. Martell requested this be merged to 3.7. What do you
>> think?
>
>
> LGTM
Thanks! r245456.
>
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Thanks!
Comment at: docs/UsersManual.rst:1860
@@ +1859,3 @@
+
+clang fully implements all of standard OpenMP 3.1 directives and clauses + some
+features of OpenMP 4.0, including `
ouble size out by running
>
> #include
> int main() {
> long double a;
> std::cout< }
>
> which outputs 12 with mingw 32 bit, 16 with mingw 64 bit but always 16 with
> current clang.
> I fixed this and added test in r245459+r245462.
>
>
> 2015-08-19
It was requested that this be merged to 3.7.
Richard: OK for merging?
Thanks,
Hans
On Thu, Aug 20, 2015 at 6:11 AM, Olivier Goffart via cfe-commits
wrote:
> Author: ogoffart
> Date: Thu Aug 20 08:11:14 2015
> New Revision: 245560
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245560&view=rev
Merged in r245615.
Thanks,
Hans
On Thu, Aug 20, 2015 at 12:13 PM, Richard Smith wrote:
> LGTM for branch.
>
> On Aug 20, 2015 9:47 AM, "Hans Wennborg" wrote:
>>
>> It was requested that this be merged to 3.7.
>>
>> Richard: OK for merging?
>>
>> Thanks,
>> Hans
>>
>> On Thu, Aug 20, 2015 at 6:1
+Saleem and Renato; maybe you can take a look?
On Tue, Aug 18, 2015 at 11:24 AM, Leandro Graciá Gil
wrote:
> Hi,
>
> Please find attached a patch fixing an out-of-bounds array access present in
> the current libunwind top of tree code.
>
> The problem is caused by subtracting the wrong base regis
ctures
>>>> > and
>>>> > arrays containing long double will change their size as well as
>>>> > function
>>>> > calling convention for function taking long double will be modified.
>>>> >
>>>> &g
Author: hans
Date: Thu Aug 20 19:49:32 2015
New Revision: 245653
URL: http://llvm.org/viewvc/llvm-project?rev=245653&view=rev
Log:
Creating release candidate rc3 from release_370 branch
Added:
libcxx/tags/RELEASE_370/rc3/ (props changed)
- copied from r245652, libcxx/branches/release_
Author: hans
Date: Thu Aug 20 19:49:35 2015
New Revision: 245654
URL: http://llvm.org/viewvc/llvm-project?rev=245654&view=rev
Log:
Creating release candidate rc3 from release_370 branch
Added:
libcxxabi/tags/RELEASE_370/rc3/ (props changed)
- copied from r245653, libcxxabi/branches/re
Author: hans
Date: Thu Aug 20 19:49:55 2015
New Revision: 245660
URL: http://llvm.org/viewvc/llvm-project?rev=245660&view=rev
Log:
Creating release candidate rc3 from release_370 branch
Added:
libunwind/tags/RELEASE_370/rc3/ (props changed)
- copied from r245659, libunwind/branches/re
On Thu, Aug 20, 2015 at 8:28 PM, Saleem Abdulrasool
wrote:
> On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg wrote:
>>
>> +Saleem and Renato; maybe you can take a look?
>
>
> Thanks for pointing this out!
>
> The patch is correct and pretty safe to apply for 3.7 I think since its a
> simple bug fi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246090: Add a clang release note about raising the minimum
Windows version for the… (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D12368?vs=33208&id=33255#toc
Repository:
rL LL
hans added a comment.
Committed in r246090.
http://reviews.llvm.org/D12368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hans
Date: Wed Aug 26 18:34:53 2015
New Revision: 246113
URL: http://llvm.org/viewvc/llvm-project?rev=246113&view=rev
Log:
Creating release candidate rc4 from release_370 branch
Added:
libcxx/tags/RELEASE_370/rc4/ (props changed)
- copied from r246112, libcxx/branches/release_
Author: hans
Date: Wed Aug 26 18:34:56 2015
New Revision: 246114
URL: http://llvm.org/viewvc/llvm-project?rev=246114&view=rev
Log:
Creating release candidate rc4 from release_370 branch
Added:
libcxxabi/tags/RELEASE_370/rc4/ (props changed)
- copied from r246113, libcxxabi/branches/re
Author: hans
Date: Wed Aug 26 18:35:14 2015
New Revision: 246120
URL: http://llvm.org/viewvc/llvm-project?rev=246120&view=rev
Log:
Creating release candidate rc4 from release_370 branch
Added:
libunwind/tags/RELEASE_370/rc4/ (props changed)
- copied from r246119, libunwind/branches/re
hans created this revision.
hans added a reviewer: majnemer.
hans added a subscriber: cfe-commits.
This seems to match the MS behaviour.
http://reviews.llvm.org/D12422
Files:
lib/CodeGen/CodeGenModule.cpp
lib/Sema/SemaDecl.cpp
test/CodeGenCXX/dllimport.cpp
test/SemaCXX/dllexport.cpp
te
Author: hans
Date: Thu Aug 27 20:43:57 2015
New Revision: 246250
URL: http://llvm.org/viewvc/llvm-project?rev=246250&view=rev
Log:
Creating release candidate final from release_370 branch
Added:
libcxx/tags/RELEASE_370/final/ (props changed)
- copied from r246249, libcxx/branches/rele
Author: hans
Date: Thu Aug 27 20:44:00 2015
New Revision: 246251
URL: http://llvm.org/viewvc/llvm-project?rev=246251&view=rev
Log:
Creating release candidate final from release_370 branch
Added:
libcxxabi/tags/RELEASE_370/final/ (props changed)
- copied from r246250, libcxxabi/branche
Author: hans
Date: Thu Aug 27 20:44:18 2015
New Revision: 246257
URL: http://llvm.org/viewvc/llvm-project?rev=246257&view=rev
Log:
Creating release candidate final from release_370 branch
Added:
libunwind/tags/RELEASE_370/final/ (props changed)
- copied from r246256, libunwind/branche
Author: hans
Date: Fri Aug 28 16:47:01 2015
New Revision: 246338
URL: http://llvm.org/viewvc/llvm-project?rev=246338&view=rev
Log:
Allow TLS vars in dllimport/export functions; only inline dllimport functions
when safe (PR24593)
This patch does two things:
1) Don't error about dllimport/export
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246338: Allow TLS vars in dllimport/export functions; only
inline dllimport functions… (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D12422?vs=33388&id=33471#toc
Repository:
rL
Author: hans
Date: Fri Aug 28 17:56:21 2015
New Revision: 246348
URL: http://llvm.org/viewvc/llvm-project?rev=246348&view=rev
Log:
Follow-up to r246338: use getParentFunctionOrMethod
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL:
http://llvm.org/vie
hans added a comment.
I also don't know anything about how this plugin works, I just build it :) I'm
hoping Manuel can take a look.
http://reviews.llvm.org/D12407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: hans
Date: Mon Aug 31 16:48:52 2015
New Revision: 246492
URL: http://llvm.org/viewvc/llvm-project?rev=246492&view=rev
Log:
Fix CHECK directives that weren't checking.
Modified:
cfe/trunk/test/CodeGen/builtin-cpu-supports.c
cfe/trunk/test/CodeGen/builtins-ppc-crypto.c
cfe/trunk
This change makes Basic depend on AST.
The immediate problem I'm hitting is clang-format (which uses Basic
but not AST) failing to link on Windows [1], but I suspect this could
cause problems elsewhere too.
Is there some way to avoid this dependency?
[1].
http://build.chromium.org/p/chromium.f
Author: hans
Date: Fri Sep 4 14:59:39 2015
New Revision: 246864
URL: http://llvm.org/viewvc/llvm-project?rev=246864&view=rev
Log:
Don't allow dllexport/import on static local variables
They might technically have external linkage, but it still doesn't make sense
for the user to try and export su
On Fri, Aug 14, 2015 at 2:55 AM, Manuel Klimek via cfe-commits
wrote:
> Author: klimek
> Date: Fri Aug 14 04:55:36 2015
> New Revision: 245036
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245036&view=rev
> Log:
> Add structed way to express command line options in the compilation database.
>
>
Author: hans
Date: Thu Oct 8 18:13:28 2015
New Revision: 249775
URL: http://llvm.org/viewvc/llvm-project?rev=249775&view=rev
Log:
Expose -f[no]ms-{compatibility,extensions} in clang-cl (PR25114)
These are enabled by default in clang-cl, because the whole idea is that
it should work like cl.exe,
On Fri, Oct 9, 2015 at 1:46 PM, Douglas Gregor wrote:
>
>> On Oct 7, 2015, at 11:55 AM, Hans Wennborg wrote:
>>
>> Hi Doug,
>>
>> On Wed, Sep 30, 2015 at 2:27 PM, Douglas Gregor via cfe-commits
>> wrote:
>>> Author: dgregor
>>> Date: Wed Sep 30 16:27:42 2015
>>> New Revision: 248949
>>>
>>> URL:
On Fri, Oct 9, 2015 at 9:10 PM, Douglas Gregor wrote:
>
>
> Sent from my iPhone
>
>> On Oct 9, 2015, at 2:17 PM, Hans Wennborg wrote:
>>
>>> On Fri, Oct 9, 2015 at 1:46 PM, Douglas Gregor wrote:
>>>
On Oct 7, 2015, at 11:55 AM, Hans Wennborg wrote:
Hi Doug,
On Wed, Sep
Author: hans
Date: Mon Oct 12 15:47:58 2015
New Revision: 250099
URL: http://llvm.org/viewvc/llvm-project?rev=250099&view=rev
Log:
Parse and ignore #pragma runtime_checks in MS extensions mode (PR25138)
We already silently ignore the /RTC, which controls the same functionality.
Modified:
cfe
Author: hans
Date: Wed Oct 14 11:24:28 2015
New Revision: 250301
URL: http://llvm.org/viewvc/llvm-project?rev=250301&view=rev
Log:
Intrin.h: implement __emul and __emulu
Modified:
cfe/trunk/lib/Headers/Intrin.h
Modified: cfe/trunk/lib/Headers/Intrin.h
URL:
http://llvm.org/viewvc/llvm-projec
hans added a comment.
This is now part of the latest snapshot at http://llvm.org/builds/
Seems to work :-)
I had to dig around a bit to figure out where these settings are actually
exposed. Should we mention that in the documentation somewhere? Actually, do we
even have any documentation for th
hans added a comment.
The release script change looks good to me. Better than good actually; it's a
great improvement :-)
http://reviews.llvm.org/D13802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: hans
Date: Wed Nov 4 10:11:56 2015
New Revision: 252056
URL: http://llvm.org/viewvc/llvm-project?rev=252056&view=rev
Log:
clang-cl: Parse the /guard:cf[-] flag (PR25400)
Modified:
cfe/trunk/include/clang/Driver/CLCompatOptions.td
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D14311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
hans added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:86
@@ -69,1 +85,3 @@
+IComponentModel componentModel =
GetService(typeof(SComponentModel)) as IComponentModel;
+editorAdaptersFactoryService =
componentModel
hans added a comment.
Some of these are great improvements, especially using auto for iterators etc.
But I'm not sure we'll want to start changing "Foo *foo = new Foo;" to use auto
everywhere. I expect we'd have to do that in a huge number of places?
Comment at: include/clang/
hans added a comment.
Like the other patch, I'm not sure that using auto in all these places help
readability.
Repository:
rL LLVM
http://reviews.llvm.org/D14560
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Ah, you were referring to
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150727/134471.html
Sorry, email is hard to keep up with sometimes :-)
On Thu, Aug 6, 2015 at 9:15 AM, Hans Wennborg wrote:
> Hi Alex,
>
> What crash is that? I don't see any PR number in the commit.
>
> Richar
hans created this revision.
hans added a reviewer: rsmith.
hans added subscribers: cfe-commits, hansw.
This enables Clang to correctly handle code such as:
```
struct __declspec(dllexport) S {
int x = 42;
};
```
where it would otherwise assert due to trying to generate the default
constructor
hans updated this revision to Diff 31564.
hans added a comment.
Turns out ActOnFinishCXXMemberDefaultArgs needs to be re-entrant.
http://reviews.llvm.org/D11850
Files:
include/clang/Sema/Sema.h
lib/Sema/Sema.cpp
lib/Sema/SemaDeclCXX.cpp
test/CodeGenCXX/dllexport.cpp
Index: test/CodeGen
hans added a subscriber: hans.
hans accepted this revision.
hans added a reviewer: hans.
hans added a comment.
Out of curiosity, did you run in to something that relies on this in the wild?
Comment at: tools/driver/driver.cpp:452
@@ +451,3 @@
+// The first instance of '#' sh
On Mon, Aug 10, 2015 at 11:09 AM, Joerg Sonnenberger via cfe-commits
wrote:
> On Mon, Aug 10, 2015 at 04:58:04PM -, Joerg Sonnenberger via cfe-commits
> wrote:
>> Author: joerg
>> Date: Mon Aug 10 11:58:04 2015
>> New Revision: 244462
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=244462&
On Fri, Aug 7, 2015 at 11:57 AM, Simon Pilgrim wrote:
> On 06/08/2015 18:05, Hans Wennborg wrote:
>>
>> On Sun, Aug 2, 2015 at 8:28 AM, Simon Pilgrim
>> wrote:
>>>
>>> Author: rksimon
>>> Date: Sun Aug 2 10:28:10 2015
>>> New Revision: 243851
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=
Author: hans
Date: Mon Jul 18 12:52:59 2016
New Revision: 275833
URL: http://llvm.org/viewvc/llvm-project?rev=275833&view=rev
Log:
Creating release_39 branch off revision 275826
Added:
libcxxabi/branches/release_39/
- copied from r275826, libcxxabi/trunk/
__
Author: hans
Date: Mon Jul 18 12:52:56 2016
New Revision: 275832
URL: http://llvm.org/viewvc/llvm-project?rev=275832&view=rev
Log:
Creating release_39 branch off revision 275826
Added:
libcxx/branches/release_39/ (props changed)
- copied from r275826, libcxx/trunk/
Propchange: libcxx
Author: hans
Date: Mon Jul 18 12:53:22 2016
New Revision: 275841
URL: http://llvm.org/viewvc/llvm-project?rev=275841&view=rev
Log:
Creating release_39 branch off revision 275826
Added:
libunwind/branches/release_39/
- copied from r275826, libunwind/trunk/
__
Author: hans
Date: Mon Jul 18 13:05:19 2016
New Revision: 275844
URL: http://llvm.org/viewvc/llvm-project?rev=275844&view=rev
Log:
Trunk release notes are now for 4.0.0
The 3.9 release are on the 3.9 branch.
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
Author: hans
Date: Mon Jul 18 13:08:59 2016
New Revision: 275846
URL: http://llvm.org/viewvc/llvm-project?rev=275846&view=rev
Log:
Trunk release notes are now for 4.0.0
The 3.9 release are on the 3.9 branch.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra
Author: hans
Date: Mon Jul 18 13:13:08 2016
New Revision: 275848
URL: http://llvm.org/viewvc/llvm-project?rev=275848&view=rev
Log:
docs/conf.py: update version to 4.0
Modified:
cfe/trunk/docs/analyzer/conf.py
cfe/trunk/docs/conf.py
Modified: cfe/trunk/docs/analyzer/conf.py
URL:
http://l
Author: hans
Date: Mon Jul 18 13:13:46 2016
New Revision: 275849
URL: http://llvm.org/viewvc/llvm-project?rev=275849&view=rev
Log:
docs/conf.py: update version to 4.0
Modified:
clang-tools-extra/trunk/docs/conf.py
Modified: clang-tools-extra/trunk/docs/conf.py
URL:
http://llvm.org/viewvc/ll
Oops, as you suspected I failed at copy/paste. This is the bot that's
broken: http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/51780
On Mon, Jul 18, 2016 at 10:57 AM, Devin Coughlin wrote:
> Hans,
>
> I’m happy to revert — but I think r275820 is very unlikely to have been the
> root caus
Thanks, I've merged the revert in r275902.
Cheers,
Hans
On Mon, Jul 18, 2016 at 12:06 PM, Devin Coughlin wrote:
> Reverted in r275880. Sorry about that. I’ll have to investigate why I didn’t
> get an email from the bot about the failure.
>
> Thanks
> Devin
>
> On Jul 18, 2016, at 11:59 AM, Hans
On Wed, Jul 20, 2016 at 1:42 AM, Marshall Clow wrote:
>
>
> On Tue, Jul 19, 2016 at 11:06 AM, Eric Fiselier wrote:
>>
>> @Hans. This needs to be merged into 3.9. It fixes PR28469 which is a
>> release blocker.
>
>
> I'm fine with this.
Thanks! Eric, go ahead and merge this, or let me know if you
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276113: Add attribute abi_tag to the release notes (authored
by hans).
Changed prior to commit:
https://reviews.llvm.org/D21970?vs=62673&id=64678#toc
Repository:
rL LLVM
https://reviews.llvm.org/D21
hans added a comment.
Committed r276113. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D21970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sure, r276115.
Thanks,
Hans
On Mon, Jul 18, 2016 at 10:22 PM, Saleem Abdulrasool
wrote:
> Hey Hans,
>
> I think that we should get this merged into 3.9. Its a trivial fix and
> makes the script usable if you set g:clang_rename_path.
>
> Thanks!
>
> On Mon, Jul 18, 2016 at 7:13 PM, Saleem Abdulr
On Wed, Jul 20, 2016 at 9:00 PM, Ed Maste wrote:
> On 20 July 2016 at 15:19, Ed Maste via cfe-commits
> wrote:
>> Author: emaste
>> Date: Wed Jul 20 10:19:09 2016
>> New Revision: 276128
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=276128&view=rev
>> Log:
>> libunwind: limit stack usage in
I'm not sure we have an owner for libunwind, but things sounded
positive on the code review, so go ahead and merge.
Thanks,
Hans
On Wed, Jul 20, 2016 at 8:06 PM, Eric Fiselier wrote:
> @Hans This should be merged into 3.9.
>
> Can a code owner give this the thumbs up?
>
> /Eric
>
> On Wed, Jul 2
On Thu, Jul 21, 2016 at 6:34 PM, Robinson, Paul via cfe-commits
wrote:
>
>
>> -Original Message-
>> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
>> Simon Pilgrim via cfe-commits
>> Sent: Wednesday, July 20, 2016 3:18 AM
>> To: cfe-commits@lists.llvm.org
>> Sub
Does this apply to 3.9?
On Wed, Jul 20, 2016 at 11:28 PM, George Burgess IV via cfe-commits
wrote:
> Author: gbiv
> Date: Wed Jul 20 22:28:13 2016
> New Revision: 276232
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276232&view=rev
> Log:
> [Sema] Fix PR28623.
>
> In atomic builtins, we assume
Richard: should we merge this to 3.9?
On Thu, Jul 21, 2016 at 6:31 PM, Erik Pilkington via cfe-commits
wrote:
> Author: epilk
> Date: Thu Jul 21 17:31:40 2016
> New Revision: 276350
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276350&view=rev
> Log:
> [CodeGen] Fix a crash when constant foldi
Richard: should we merge this to 3.9?
On Thu, Jul 21, 2016 at 7:03 PM, David Majnemer via cfe-commits
wrote:
> Author: majnemer
> Date: Thu Jul 21 18:03:43 2016
> New Revision: 276352
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276352&view=rev
> Log:
> [Sema] Handle errors during rewriteBuil
Should we merge this to 3.9?
On Thu, Jul 21, 2016 at 3:38 AM, Craig Topper via cfe-commits
wrote:
> Author: ctopper
> Date: Thu Jul 21 02:38:43 2016
> New Revision: 276250
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276250&view=rev
> Log:
> [Sema,X86] Add explicit check to ensure that builti
Should this revert be merged to 3.9?
Thanks,
Hans
On Thu, Jul 21, 2016 at 4:28 PM, Wolfgang Pieb via cfe-commits
wrote:
> Author: wolfgangp
> Date: Thu Jul 21 18:28:18 2016
> New Revision: 276361
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276361&view=rev
> Log:
> Reverting r275115 which ca
I see. Since it's not a regression and there are dependencies, let's
not merge it.
Thanks,
Hans
On Fri, Jul 22, 2016 at 12:39 PM, Craig Topper wrote:
> Most of these have been broken like this for a long time so I'm not sure.
> This patch as is depends on r276249 too since we were missing qualif
Merged the revert to 3.9 in r276656.
Thanks,
Hans
On Mon, Jul 25, 2016 at 10:02 AM, Pieb, Wolfgang wrote:
> Yes, it should. I'm just now realizing that the original change got into 3.9.
>
> Thanks,
> Wolfgang
>
>> -Original Message-
>> From: hwennb...@google.com [mailto:hwennb...@google.
Actually, I now see the PR doesn't reproduce on 3.9, so this must have
broke after the branch point.
On Fri, Jul 22, 2016 at 7:02 AM, Hans Wennborg wrote:
> Richard: should we merge this to 3.9?
>
> On Thu, Jul 21, 2016 at 7:03 PM, David Majnemer via cfe-commits
> wrote:
>> Author: majnemer
>> D
Should this be merged to 3.9?
On Fri, Jul 22, 2016 at 2:08 PM, Vassil Vassilev via cfe-commits
wrote:
> Author: vvassilev
> Date: Fri Jul 22 16:08:24 2016
> New Revision: 276473
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276473&view=rev
> Log:
> [modules] Teach the ASTWriter to ignore mutat
Should me merge this to 3.9?
On Mon, Jul 25, 2016 at 10:17 AM, Sunil Srivastava via cfe-commits
wrote:
> Author: ssrivastava
> Date: Mon Jul 25 12:17:06 2016
> New Revision: 276653
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276653&view=rev
> Log:
> Support '#pragma once' in headers when usi
Merged to 3.9 in r276757.
Cheers,
Hans
On Tue, Jul 26, 2016 at 2:01 AM, Richard Smith wrote:
> Yes please :)
>
>
> On 25 Jul 2016 10:13 p.m., "Vassil Vassilev via cfe-commits"
> wrote:
>>
>> It could, it fixes a set of issues wrt to modules.
>> On 25/07/16 22:39, Hans Wennborg wrote:
>>>
>>> Sh
Sure, r276801.
Thanks,
Hans
On Tue, Jul 26, 2016 at 1:41 PM, Vedant Kumar wrote:
> Thanks Justin!
>
> @Hans, could we take this for llvm 3.9 also?
>
> best,
> vedant
>
>> On Jul 26, 2016, at 1:39 PM, Justin Bogner wrote:
>>
>> Vedant Kumar via cfe-commits writes:
>>> Hi Justin,
>>>
>>> Could y
Author: hans
Date: Wed Jul 27 11:39:45 2016
New Revision: 276887
URL: http://llvm.org/viewvc/llvm-project?rev=276887&view=rev
Log:
Update cxx_dr_Status after 3.9 branch
Modified:
cfe/trunk/www/cxx_dr_status.html
cfe/trunk/www/make_cxx_dr_status
Modified: cfe/trunk/www/cxx_dr_status.html
Author: hans
Date: Wed Jul 27 11:56:03 2016
New Revision: 276891
URL: http://llvm.org/viewvc/llvm-project?rev=276891&view=rev
Log:
UsersManual.rst: update clang-cl option list
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/llvm-
Should this be merged to 3.9?
Thanks,
Hans
On Wed, Jul 27, 2016 at 11:25 AM, Erik Pilkington via cfe-commits
wrote:
> Author: epilk
> Date: Wed Jul 27 13:25:10 2016
> New Revision: 276900
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276900&view=rev
> Log:
> [Sema] Teach getCurrentThisType to
Richard: ping?
On Fri, Jul 22, 2016 at 7:00 AM, Hans Wennborg wrote:
> Richard: should we merge this to 3.9?
>
> On Thu, Jul 21, 2016 at 6:31 PM, Erik Pilkington via cfe-commits
> wrote:
>> Author: epilk
>> Date: Thu Jul 21 17:31:40 2016
>> New Revision: 276350
>>
>> URL: http://llvm.org/viewvc/
I see, thanks.
I've taken a second look at the patch and it seems straight-forward to
me, so I've merged it in r276985.
Cheers,
Hans
On Wed, Jul 27, 2016 at 5:16 PM, David Majnemer
wrote:
> I hear that he is on vacation.
>
>
> On Wednesday, July 27, 2016, Hans Wennborg vi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276994: Mention of proper support for "__unaligned" type
qualifier in 3.9 clang… (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D22913?vs=65914&id=65943#toc
Repository:
rL LLVM
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
https://reviews.llvm.org/D22913
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
1101 - 1200 of 1668 matches
Mail list logo
