Thanks! r296001.
On Thu, Feb 23, 2017 at 2:01 AM, Anastasia Stulova
wrote:
> Sure! No objections here!
>
> Thanks,
> Anastasia
>
> -Original Message-
> From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans
> Wennborg
> Sent: 22 February 2017 18:10
> To: Jan Vesely
>
Author: hans
Date: Thu Feb 23 19:16:34 2017
New Revision: 296063
URL: http://llvm.org/viewvc/llvm-project?rev=296063&view=rev
Log:
Revert r291477 "[Frontend] Correct values of ATOMIC_*_LOCK_FREE to match
builtin"
It caused PR31864. There is a patch in progress to fix that, but let's
revert in th
This was reverted in r296063 due to PR31864.
On Mon, Jan 9, 2017 at 12:54 PM, Michal Gorny via cfe-commits
wrote:
> Author: mgorny
> Date: Mon Jan 9 14:54:20 2017
> New Revision: 291477
>
> URL: http://llvm.org/viewvc/llvm-project?rev=291477&view=rev
> Log:
> [Frontend] Correct values of ATOMIC_
Oops, it did. Thanks for reminding me; I've merged that in r296139.
On Thu, Feb 23, 2017 at 11:13 PM, Hahnfeld, Jonas
wrote:
> Hi Hans,
>
> Did r295474 fall off your radar? Sorry that I asked for both commits in one
> email, should I reply to the other original commit?
>
> Thanks,
> Jonas
>
>> -
Merged to 4.0 in r296139 as requested on the r295473 commit thread.
On Fri, Feb 17, 2017 at 10:32 AM, Jonas Hahnfeld via cfe-commits
wrote:
> Author: hahnfeld
> Date: Fri Feb 17 12:32:58 2017
> New Revision: 295474
>
> URL: http://llvm.org/viewvc/llvm-project?rev=295474&view=rev
> Log:
> [OpenMP]
Merged to 4.0 in r296152.
On Thu, Feb 23, 2017 at 5:16 PM, Hans Wennborg via cfe-commits
wrote:
> Author: hans
> Date: Thu Feb 23 19:16:34 2017
> New Revision: 296063
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296063&view=rev
> Log:
> Revert r291477 "[Front
Yes, this looks very straight-forward. Merged in r296154.
On Fri, Feb 24, 2017 at 4:29 AM, Sam McCall via cfe-commits
wrote:
> Thanks Anna, I'm new to the release process here.
>
> Hans: this is a simple fix for a null-dereference in the static analyzer.
> Does it make sense to cherrypick?
>
> On
On Mon, Jan 30, 2017 at 9:23 PM, Sam McCall via cfe-commits
wrote:
> Author: sammccall
> Date: Mon Jan 30 23:23:20 2017
> New Revision: 293604
>
> URL: http://llvm.org/viewvc/llvm-project?rev=293604&view=rev
> Log:
> In VirtualCallChecker, handle indirect calls
>
> Summary:
> In VirtualCallChecker
Author: hans
Date: Mon Feb 27 12:03:07 2017
New Revision: 296364
URL: http://llvm.org/viewvc/llvm-project?rev=296364&view=rev
Log:
Merging r296358 and r296359:
r296358 | aadg | 2017-02-27 09:33:20 -0800 (Mon, 27 Feb 2017) | 8
Merged together with r296359 to 4.0 in r296364.
On Mon, Feb 27, 2017 at 9:33 AM, Arnaud A. de Grandmaison via
cfe-commits wrote:
> Author: aadg
> Date: Mon Feb 27 11:33:20 2017
> New Revision: 296358
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296358&view=rev
> Log:
> Add libcxxabi's LICENSE
We're at the "should have tagged 'final' days ago" stage :-)
Since it's not a regression, I would prefer not to merge it unless you
feel super strongly about it.
Sounds like a good candidate for 4.0.1 (tracking bug is PR32061).
Thanks,
Hans
On Wed, Mar 1, 2017 at 1:36 AM, Eric Fiselier wrote:
Merged to 4.0 in r296762.
On Wed, Mar 1, 2017 at 11:18 AM, Bruno Cardoso Lopes via cfe-commits
wrote:
> Author: bruno
> Date: Wed Mar 1 13:18:42 2017
> New Revision: 296656
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296656&view=rev
> Log:
> [PCH] Avoid VarDecl emission attempt if no owning
Author: hans
Date: Thu Mar 2 13:31:13 2017
New Revision: 296793
URL: http://llvm.org/viewvc/llvm-project?rev=296793&view=rev
Log:
Creating release candidate rc3 from release_400 branch
Added:
libcxx/tags/RELEASE_400/rc3/ (props changed)
- copied from r296792, libcxx/branches/release_
Author: hans
Date: Thu Mar 2 13:31:16 2017
New Revision: 296794
URL: http://llvm.org/viewvc/llvm-project?rev=296794&view=rev
Log:
Creating release candidate rc3 from release_400 branch
Added:
libcxxabi/tags/RELEASE_400/rc3/ (props changed)
- copied from r296793, libcxxabi/branches/re
Author: hans
Date: Thu Mar 2 13:31:35 2017
New Revision: 296800
URL: http://llvm.org/viewvc/llvm-project?rev=296800&view=rev
Log:
Creating release candidate rc3 from release_400 branch
Added:
libunwind/tags/RELEASE_400/rc3/ (props changed)
- copied from r296799, libunwind/branches/re
Author: hans
Date: Tue Mar 7 14:59:01 2017
New Revision: 297221
URL: http://llvm.org/viewvc/llvm-project?rev=297221&view=rev
Log:
Creating release candidate rc4 from release_400 branch
Added:
libunwind/tags/RELEASE_400/rc4/ (props changed)
- copied from r297220, libunwind/branches/re
Author: hans
Date: Tue Mar 7 14:58:42 2017
New Revision: 297215
URL: http://llvm.org/viewvc/llvm-project?rev=297215&view=rev
Log:
Creating release candidate rc4 from release_400 branch
Added:
libcxxabi/tags/RELEASE_400/rc4/ (props changed)
- copied from r297214, libcxxabi/branches/re
Author: hans
Date: Tue Mar 7 14:58:39 2017
New Revision: 297214
URL: http://llvm.org/viewvc/llvm-project?rev=297214&view=rev
Log:
Creating release candidate rc4 from release_400 branch
Added:
libcxx/tags/RELEASE_400/rc4/ (props changed)
- copied from r297213, libcxx/branches/release_
Author: hans
Date: Wed Mar 8 18:39:59 2017
New Revision: 297341
URL: http://llvm.org/viewvc/llvm-project?rev=297341&view=rev
Log:
Creating release candidate final from release_400 branch
Added:
libcxxabi/tags/RELEASE_400/final/ (props changed)
- copied from r297340, libcxxabi/branche
Author: hans
Date: Wed Mar 8 18:39:56 2017
New Revision: 297340
URL: http://llvm.org/viewvc/llvm-project?rev=297340&view=rev
Log:
Creating release candidate final from release_400 branch
Added:
libcxx/tags/RELEASE_400/final/ (props changed)
- copied from r297339, libcxx/branches/rele
Author: hans
Date: Wed Mar 8 18:40:17 2017
New Revision: 297347
URL: http://llvm.org/viewvc/llvm-project?rev=297347&view=rev
Log:
Creating release candidate final from release_400 branch
Added:
libunwind/tags/RELEASE_400/final/ (props changed)
- copied from r297346, libunwind/branche
r297634 was the 4.0.0 release commit. We'll probably see similar-size
commits for 4.0.1 and 5.0.0. Can we make the buildbot svn mirror
ignore that component of the repository to avoid this happening again?
- Hans
On Tue, Mar 14, 2017 at 12:23 AM, Galina Kistanova via cfe-commits
wrote:
> The SV
hans added a comment.
> On MSVC, if an implicit instantiation already exists and an explicit
> instantiation definition with a DLL attribute is created, the DLL
> attribute still takes effect. Make clang match this behavior.
This is scary territory, and behaviour I think might be hard for us to
hans added a comment.
In https://reviews.llvm.org/D26657#596897, @smeenai wrote:
> In https://reviews.llvm.org/D26657#596759, @hans wrote:
>
> > > On MSVC, if an implicit instantiation already exists and an explicit
> > > instantiation definition with a DLL attribute is created, the DLL
> > > a
hans added a subscriber: srhines.
hans added a comment.
I'm still skeptical, but I think this is an improvement over the previous patch.
I think your best bet to get this landed is to find someone from the cfe-dev
thread who is in favour of config files and have them review it.
I'm also cc'ing
hans added a comment.
In https://reviews.llvm.org/D26657#597859, @smeenai wrote:
> In https://reviews.llvm.org/D26657#597523, @hans wrote:
>
> > In https://reviews.llvm.org/D26657#596897, @smeenai wrote:
> >
> > > In https://reviews.llvm.org/D26657#596759, @hans wrote:
> > >
> > > > > On MSVC, if
hans added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7670-7673
+if ((Old_TSK == TSK_ExplicitInstantiationDeclaration ||
+ Old_TSK == TSK_ImplicitInstantiation) &&
(TSK == TSK_ExplicitInstantiationDefinition ||
DLLImportExplicitInstantia
On Fri, Nov 25, 2016 at 6:58 PM, Antonio Maiorano wrote:
> Ah, no, that's not what I meant. The required referenced assemblies are
> versions that are normally installed with VS 2010.
>
> The first time I worked on this, I had upgraded the referenced assemblies to
> the ones that ship with VS 2015
On Mon, Nov 28, 2016 at 10:46 AM, Antonio Maiorano wrote:
> Okay, I'll see if upgrading to the 2015 assemblies would allow the VSIX to
> keep working in older versions of VS.
>
> Still waiting on an answer to this question:
>
>> In either case, though, I must ask: how is the offical vsix that's
>>
On Mon, Nov 28, 2016 at 11:11 AM, Antonio Maiorano wrote:
>> It's built with the script in utils/release/build_llvm_package.bat
> which I run manually on my machine once every few weeks.
>
> Okay, that's good news. So the simplest path to success would be to require
> the user to either pass the p
Very nice! I've tried this out and confirmed that the built plugin
also works with older Visual Studio versions.
Some comments below:
> --- /dev/null
> +++ b/tools/clang-format-vs/.gitignore
> @@ -0,0 +1,11 @@
> +# Visual Studio files
> +.vs/
> +/packages/
> +/ClangFormat/obj/
> +/ClangFormat/bin
On Tue, Nov 29, 2016 at 12:01 PM, Antonio Maiorano wrote:
> On Tue, 29 Nov 2016 at 13:42 Hans Wennborg wrote:
>>
>> Very nice! I've tried this out and confirmed that the built plugin
>> also works with older Visual Studio versions.
>>
>> Some comments below:
>>
>> > --- /dev/null
>> > +++ b/tools
Author: hans
Date: Tue Nov 29 16:31:00 2016
New Revision: 288207
URL: http://llvm.org/viewvc/llvm-project?rev=288207&view=rev
Log:
Don't try to merge DLL attributes on redeclaration of invalid decl (PR31069)
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
cfe/trunk/test/Sema/dllimport.c
Modifi
Author: hans
Date: Tue Nov 29 18:31:39 2016
New Revision: 288223
URL: http://llvm.org/viewvc/llvm-project?rev=288223&view=rev
Log:
Fix formatting issue from r288207
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL:
http://llvm.org/viewvc/llvm-project/c
On Tue, Nov 29, 2016 at 4:37 PM, David Majnemer via cfe-commits
wrote:
>
>
> On Tue, Nov 29, 2016 at 2:31 PM, Hans Wennborg via cfe-commits
> wrote:
>>
>> Author: hans
>> Date: Tue Nov 29 16:31:00 2016
>> New Revision: 288207
>>
>> URL: http://
Looks good to me!
Do you have commit access, or would you like me to commit it for you?
Thanks,
Hans
On Wed, Nov 30, 2016 at 8:10 PM, Antonio Maiorano wrote:
> Updated version of patch attached with the changes you suggested. Let me
> know if there's anything else you'd like.
>
>
> On Tue, 29 N
Author: hans
Date: Thu Dec 1 12:05:41 2016
New Revision: 288393
URL: http://llvm.org/viewvc/llvm-project?rev=288393&view=rev
Log:
Fix VS2015 build of clang-format-vsix by using NuGet to pull in required
assemblies
Also added a gitignore to help track the right items to commit.
Patch by Antonio
Committed in r288393.
Cheers,
Hans
On Thu, Dec 1, 2016 at 9:22 AM, Hans Wennborg wrote:
> Looks good to me!
>
> Do you have commit access, or would you like me to commit it for you?
>
> Thanks,
> Hans
>
> On Wed, Nov 30, 2016 at 8:10 PM, Antonio Maiorano wrote:
>> Updated version of patch attac
The bots are red, e.g.
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/4342
On Wed, Apr 26, 2017 at 12:47 PM, Frederich Munch via cfe-commits
wrote:
> Author: marsupial
> Date: Wed Apr 26 14:47:31 2017
> New Revision: 301449
>
> URL: http://llvm.org/viewvc/llvm-project?rev=301
Author: hans
Date: Thu Apr 27 12:02:25 2017
New Revision: 301564
URL: http://llvm.org/viewvc/llvm-project?rev=301564&view=rev
Log:
Fix -Wpedantic about extra semicolons in CGStmtOpenMP.cpp
Modified:
cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
URL:
Author: hans
Date: Thu Apr 27 12:19:07 2017
New Revision: 301567
URL: http://llvm.org/viewvc/llvm-project?rev=301567&view=rev
Log:
clang-cl: Alias /d1reportAllClassLayout to -fdump-record-layouts (PR32826)
Modified:
cfe/trunk/include/clang/Driver/CLCompatOptions.td
cfe/trunk/test/Driver/c
Author: hans
Date: Tue May 9 10:55:39 2017
New Revision: 302542
URL: http://llvm.org/viewvc/llvm-project?rev=302542&view=rev
Log:
Revert r302476 "Update testcase for upstream LLVM changes."
That test update was for r302469, which was reverted in r302533 due to PR32977.
Modified:
cfe/trunk/t
On Tue, May 9, 2017 at 9:24 AM, Petar Jovanovic via cfe-commits
wrote:
> Author: petarj
> Date: Tue May 9 11:24:03 2017
> New Revision: 302547
>
> URL: http://llvm.org/viewvc/llvm-project?rev=302547&view=rev
> Log:
> [mips] Impose a threshold for coercion of aggregates
>
> Modified MipsABIInfo::c
Author: hans
Date: Wed May 17 10:27:44 2017
New Revision: 303267
URL: http://llvm.org/viewvc/llvm-project?rev=303267&view=rev
Log:
clang-cl: Fix path-based MSVC version detection
The code wasn't taking the architecture-specific subdirectory into
account.
Differential Revision: https://reviews.ll
hans created this revision.
hans added a reviewer: pcc.
hans added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
getClassAtVTableLocation() was calling ASTRecordLayout::getBaseClassOffset() on
a virtual base, causing an assert.
https://reviews.llvm.org/D25779
Files:
lib/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284624: MS ABI: Fix assert when generating virtual function
call with virtual bases and… (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D25779?vs=75171&id=75177#toc
Repository:
Author: hans
Date: Wed Oct 19 13:04:27 2016
New Revision: 284624
URL: http://llvm.org/viewvc/llvm-project?rev=284624&view=rev
Log:
MS ABI: Fix assert when generating virtual function call with virtual bases and
-flto (PR30731)
getClassAtVTableLocation() was calling
ASTRecordLayout::getBaseClassO
hans added a comment.
In https://reviews.llvm.org/D25779#574630, @majnemer wrote:
> Why did this only fail with -flto? Seems strange.
I was asking myself the same thing :-) It's because of this code in
MicrosoftCXXABI::getVirtualFunctionPointer:
if (CGM.getCodeGenOpts().PrepareForLTO) // XX
Author: hans
Date: Thu Oct 20 15:54:32 2016
New Revision: 284778
URL: http://llvm.org/viewvc/llvm-project?rev=284778&view=rev
Log:
Revert r284753 "[c++1z] Teach composite pointer type computation how to compute
the composite"
It caused PR30749.
Removed:
cfe/trunk/test/CXX/expr/p13.cpp
Modif
On Thu, Oct 20, 2016 at 10:57 AM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Thu Oct 20 12:57:33 2016
> New Revision: 284753
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284753&view=rev
> Log:
> [c++1z] Teach composite pointer type computation how to compute the composite
>
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Looks good to me.
https://reviews.llvm.org/D25893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm, very nice! (with one clarifying question)
Comment at: test/SemaCXX/warn-logical-not-compare.cpp:224
+ // These already err, don't also warn.
+ !x &= 1; // expected-error{
hans added a comment.
I didn't follow the original thread too closely as I didn't really see the
problem this was trying to address, but since I'm now cc'd I'll add my opinion.
I'm not in favour of this functionality. (But I guess I might be missing the
main use case.)
The way I see it, what f
hans added a comment.
Apologies for seeming so negative here. I can see that this would possibly be
beneficial for some users. This would be a powerful feature, which is what
worries me.
Here's a specific scenario I'm worried about.
For Chromium, our build system provides a specific Clang vers
hans added inline comments.
Comment at: lib/Headers/x86intrin.h:49
+static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__))
+__tzcnt_u32(unsigned int __X) { return __X ? __builtin_ctz(__X) : 32; }
+#ifdef __x86_64__
I'm worried about the co
hans added inline comments.
Comment at: lib/Headers/x86intrin.h:49
+static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__))
+__tzcnt_u32(unsigned int __X) { return __X ? __builtin_ctz(__X) : 32; }
+#ifdef __x86_64__
probinson wrote:
> hans
Author: hans
Date: Tue Nov 8 18:56:42 2016
New Revision: 286324
URL: http://llvm.org/viewvc/llvm-project?rev=286324&view=rev
Log:
clang-cl: Pass /Zc:threadSafeInit through to MSVC with /fallback (PR30948)
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/cl-fallback.c
Modif
hans added a comment.
In https://reviews.llvm.org/D24933#590493, @sepavloff wrote:
> > For Chromium, our build system provides a specific Clang version close to
> > ToT, and obviously what flags to use when invoking it. (Developers can of
> > course override the flags when configuring if they w
hans added a comment.
In https://reviews.llvm.org/D24933#591943, @sepavloff wrote:
> >> Default config file is searched for only in the directory where clang
> >> executable resides. It allows SDK suppliers to customize compiler, for
> >> instance by turning off unneeded warnings, by providing
Yes, the run-time is now back to where it was before the regression. Thanks!
On Tue, Sep 8, 2015 at 8:16 AM, Manuel Klimek wrote:
> In r247018 I get a ~8x speedup on a synthetic benchmark I tried. Can you
> validate this fixes the regression?
>
> On Sat, Sep 5, 2015 at 12:56 AM Hans Wennborg wro
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D12741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: hans
Date: Wed Sep 9 19:24:40 2015
New Revision: 247218
URL: http://llvm.org/viewvc/llvm-project?rev=247218&view=rev
Log:
Fix Clang-tidy misc-use-override warnings, other minor fixes
Patch by Eugene Zelenko!
Differential Revision: http://reviews.llvm.org/D12741
Modified:
cfe/trunk/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247218: Fix Clang-tidy misc-use-override warnings, other
minor fixes (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D12741?vs=34385&id=34393#toc
Repository:
rL LLVM
http://revi
Author: hans
Date: Wed Sep 9 19:37:18 2015
New Revision: 247222
URL: http://llvm.org/viewvc/llvm-project?rev=247222&view=rev
Log:
Revert r247218: "Fix Clang-tidy misc-use-override warnings, other minor fixes"
Seems it broke the Polly build.
From
http://lab.llvm.org:8011/builders/perf-x86_64-pen
hans added a comment.
It seems this broke the build for some reason. I have reverted it in r247222.
Example build breakages:
http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-fast/builds/11687/steps/compile/logs/stdio,
http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/bui
hans added a comment.
In http://reviews.llvm.org/D12741#242907, @hans wrote:
> It seems this broke the build for some reason. I have reverted it in r247222.
>
> Example build breakages:
> http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-fast/builds/11687/steps/compile/logs/stdio,
>
Author: hans
Date: Thu Sep 10 12:07:54 2015
New Revision: 247302
URL: http://llvm.org/viewvc/llvm-project?rev=247302&view=rev
Log:
Re-commit r247218: "Fix Clang-tidy misc-use-override warnings, other minor
fixes"
This never broke the build; it was the LLVM side, r247216, that caused problems.
M
hans added a comment.
Re-committed in r247302.
Repository:
rL LLVM
http://reviews.llvm.org/D12741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
+Tom for 3.7.1
On Fri, Aug 21, 2015 at 6:41 PM, Saleem Abdulrasool
wrote:
> On Fri, Aug 21, 2015 at 11:02 AM, Hans Wennborg wrote:
>>
>> On Thu, Aug 20, 2015 at 8:28 PM, Saleem Abdulrasool
>> wrote:
>> > On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg
>> > wrote:
>> >>
>> >> +Saleem and Renato;
This made the Chromium build sad. For example:
http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/3092/steps/compile/logs/stdio
Reduction:
$ clang -cc1 -triple i686-pc-windows-msvc18.0.0 -w -fms-extensions
-fms-compatibility -fms-compatibility-version=18.0 -std=c++11
-fdelayed-t
hans added a comment.
In http://reviews.llvm.org/D12422#235509, @majnemer wrote:
> We should probably do something about lambdas, they can't be imported or
> exported but this can be done in a follow up patch.
Follow-up in r247718.
Repository:
rL LLVM
http://reviews.llvm.org/D12422
___
Author: hans
Date: Tue Sep 15 16:05:30 2015
New Revision: 247718
URL: http://llvm.org/viewvc/llvm-project?rev=247718&view=rev
Log:
MS ABI: Don't allow dllexport/import on lambdas
This is to follow up on David's comment in
http://reviews.llvm.org/D12422#235509
Modified:
cfe/trunk/include/clan
Author: hans
Date: Fri Sep 18 12:11:50 2015
New Revision: 248005
URL: http://llvm.org/viewvc/llvm-project?rev=248005&view=rev
Log:
clang-cl: Use 'pc' for the vendor field in the default triple
Leaving it unset can make the triple look confusing, especially
when using -m32 or -m64.
Modified:
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
LGTM
Please also add this to the tests for ignored options in
test/Driver/cl-options.c:221
http://reviews.llvm.org/D12981
___
cfe-commits mailing l
Author: hans
Date: Mon Sep 21 17:44:57 2015
New Revision: 248221
URL: http://llvm.org/viewvc/llvm-project?rev=248221&view=rev
Log:
Add msbuild-bin/cl to CLANG_LINKS_TO_CREATE
This got lost in r248043 which refactored the symlink creation.
Modified:
cfe/trunk/tools/driver/CMakeLists.txt
Modi
clang-cl if you’re not on
> Windows?
>
> It may make sense to move clang-cl under the if(WIN32).
>
> -Chris
>
>> On Sep 21, 2015, at 3:44 PM, Hans Wennborg via cfe-commits
>> wrote:
>>
>> Author: hans
>> Date: Mon Sep 21 17:44:57 2015
>> N
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D13187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: hans
Date: Tue Sep 29 15:56:43 2015
New Revision: 248828
URL: http://llvm.org/viewvc/llvm-project?rev=248828&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in headers and generated files;
other minor cleanups.
By Eugene Zelenko!
Differential Revision: http://reviews.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248828: Fix Clang-tidy modernize-use-nullptr warnings in
headers and generated files… (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D13187?vs=35789&id=36034#toc
Repository:
rL
Author: hans
Date: Tue Oct 6 18:40:43 2015
New Revision: 249484
URL: http://llvm.org/viewvc/llvm-project?rev=249484&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in source directories; other
minor cleanups
Patch by Eugene Zelenko!
Differential Revision: http://reviews.llvm.org/D1
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Sema/SemaDeclObjC.cpp:510
@@ -509,3 +509,3 @@
-if (PrevDecl && SuperClassDecl == 0) {
+if (PrevDecl && (!SuperClassDecl)) {
// The previous d
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249484: Fix Clang-tidy modernize-use-nullptr warnings in
source directories; other… (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D13406?vs=36425&id=36680#toc
Repository:
rL LL
Hi Doug,
On Wed, Sep 30, 2015 at 2:27 PM, Douglas Gregor via cfe-commits
wrote:
> Author: dgregor
> Date: Wed Sep 30 16:27:42 2015
> New Revision: 248949
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248949&view=rev
> Log:
> Don't inherit availability information when implementing a protocol
Author: hans
Date: Mon Aug 10 19:55:30 2015
New Revision: 244553
URL: http://llvm.org/viewvc/llvm-project?rev=244553&view=rev
Log:
Merging r244462:
r244462 | joerg | 2015-08-10 09:58:04 -0700 (Mon, 10 Aug 2015) | 2 lines
Pro
On Mon, Aug 10, 2015 at 5:26 PM, Marshall Clow wrote:
> On Mon, Aug 10, 2015 at 11:12 AM, Hans Wennborg wrote:
>>
>> On Mon, Aug 10, 2015 at 11:09 AM, Joerg Sonnenberger via cfe-commits
>> wrote:
>> > On Mon, Aug 10, 2015 at 04:58:04PM -, Joerg Sonnenberger via
>> > cfe-commits wrote:
>> >>
On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits
wrote:
> Author: rnk
> Date: Mon Aug 10 14:39:01 2015
> New Revision: 244488
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=rev
> Log:
> [dllimport] A non-imported class with an imported key can't have a key
>
> Summary:
On Thu, Aug 6, 2015 at 1:56 PM, David Majnemer via cfe-commits
wrote:
> Author: majnemer
> Date: Thu Aug 6 15:56:55 2015
> New Revision: 244266
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244266&view=rev
> Log:
> [ItaniumCXXABI] Don't import RTTI data for classes with key functions
>
> MinGW
Author: hans
Date: Wed Aug 12 11:40:42 2015
New Revision: 244761
URL: http://llvm.org/viewvc/llvm-project?rev=244761&view=rev
Log:
ReleaseNotes: Small version nbr fix
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewvc/llvm-project
On Wed, Aug 12, 2015 at 12:10 AM, Alexey Bataev via cfe-commits
wrote:
> Author: abataev
> Date: Wed Aug 12 02:10:54 2015
> New Revision: 244719
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244719&view=rev
> Log:
> [OPENMP] Fix for http://llvm.org/PR24430: clang hangs on invalid input with
>
Author: hans
Date: Wed Aug 12 12:15:27 2015
New Revision: 244772
URL: http://llvm.org/viewvc/llvm-project?rev=244772&view=rev
Log:
Merging r244003:
r244003 | tbrethou | 2015-08-04 20:59:14 -0700 (Tue, 04 Aug 2015) | 2 lines
Author: hans
Date: Wed Aug 12 12:16:15 2015
New Revision: 244773
URL: http://llvm.org/viewvc/llvm-project?rev=244773&view=rev
Log:
Merging r244004:
r244004 | tbrethou | 2015-08-04 21:01:26 -0700 (Tue, 04 Aug 2015) | 2 lines
Author: hans
Date: Wed Aug 12 12:16:39 2015
New Revision: 244774
URL: http://llvm.org/viewvc/llvm-project?rev=244774&view=rev
Log:
Merging r244005:
r244005 | tbrethou | 2015-08-04 21:01:47 -0700 (Tue, 04 Aug 2015) | 2 lines
Author: hans
Date: Wed Aug 12 14:35:01 2015
New Revision: 244794
URL: http://llvm.org/viewvc/llvm-project?rev=244794&view=rev
Log:
Docs: update clang-cl command-line documentation
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/l
Author: hans
Date: Wed Aug 12 14:35:05 2015
New Revision: 244795
URL: http://llvm.org/viewvc/llvm-project?rev=244795&view=rev
Log:
Options.td: Drop trailing space in -fsanitize= help text
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Driver/Options.td
Author: hans
Date: Wed Aug 12 14:45:01 2015
New Revision: 244797
URL: http://llvm.org/viewvc/llvm-project?rev=244797&view=rev
Log:
Docs: keep copyright years up-to-date
Modified:
cfe/trunk/docs/conf.py
Modified: cfe/trunk/docs/conf.py
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/
On Thu, Aug 13, 2015 at 2:45 PM, Brad Smith via cfe-commits
wrote:
> Author: brad
> Date: Thu Aug 13 16:45:57 2015
> New Revision: 244961
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244961&view=rev
> Log:
> [SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD.
>
> Modified:
> c
On Fri, Aug 14, 2015 at 5:25 AM, Alexey Bataev via cfe-commits
wrote:
> Author: abataev
> Date: Fri Aug 14 07:25:37 2015
> New Revision: 245041
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245041&view=rev
> Log:
> [OPENMP] Fix for http://llvm.org/PR24371: Assert failure compiling blender
> 2.
I'm OK with it if Richard gives owner's approval.
Cheers,
Hans
On Thu, Aug 13, 2015 at 8:27 PM, Martell Malone wrote:
> Hi Hans,
>
> Is this bugfix something that can be merged into 3.7 ?
>
> Kind Regards
> Martell
>
> On Thu, Aug 13, 2015 at 4:42 PM, Martell Malone
> wrote:
>>
>> This revision
On Fri, Aug 14, 2015 at 2:09 AM, John McCall wrote:
>> On Aug 10, 2015, at 12:40 PM, Hans Wennborg wrote:
>> On Fri, Aug 7, 2015 at 11:57 AM, Simon Pilgrim
>> wrote:
>>> On 06/08/2015 18:05, Hans Wennborg wrote:
On Sun, Aug 2, 2015 at 8:28 AM, Simon Pilgrim
wrote:
>
> Au
On Tue, Aug 11, 2015 at 1:41 PM, Hans Wennborg wrote:
> On Thu, Aug 6, 2015 at 1:56 PM, David Majnemer via cfe-commits
> wrote:
>> Author: majnemer
>> Date: Thu Aug 6 15:56:55 2015
>> New Revision: 244266
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=244266&view=rev
>> Log:
>> [ItaniumCXXAB
1001 - 1100 of 1668 matches
Mail list logo
