Re: r338627 - [test] Fix %hmaptool path for standalone builds

2018-08-06 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339102. On Wed, Aug 1, 2018 at 10:38 PM, Michal Gorny via cfe-commits wrote: > Author: mgorny > Date: Wed Aug 1 13:38:22 2018 > New Revision: 338627 > > URL: http://llvm.org/viewvc/llvm-project?rev=338627&view=rev > Log: > [test] Fix %hmaptool path for standalone builds > > Fix

Re: r339170 - [Headers] Expand _Unwind_Exception for SEH on MinGW/x86_64

2018-08-07 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339220. On Tue, Aug 7, 2018 at 10:02 PM, Martin Storsjo via cfe-commits wrote: > Author: mstorsjo > Date: Tue Aug 7 13:02:40 2018 > New Revision: 339170 > > URL: http://llvm.org/viewvc/llvm-project?rev=339170&view=rev > Log: > [Headers] Expand _Unwind_Exception for SEH on MinGW

[libunwind] r339222 - Merging r339217:

2018-08-08 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 8 00:50:31 2018 New Revision: 339222 URL: http://llvm.org/viewvc/llvm-project?rev=339222&view=rev Log: Merging r339217: r339217 | cdavis | 2018-08-08 06:21:24 +0200 (Wed, 08 Aug 2018) | 11 lines [

Re: [libunwind] r339217 - [libunwind] Fix pointer-to-integer cast warnings on LLP64.

2018-08-08 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339222. On Wed, Aug 8, 2018 at 6:21 AM, Charles Davis via cfe-commits wrote: > Author: cdavis > Date: Tue Aug 7 21:21:24 2018 > New Revision: 339217 > > URL: http://llvm.org/viewvc/llvm-project?rev=339217&view=rev > Log: > [libunwind] Fix pointer-to-integer cast warnings on LLP

Re: r339128 - [objc-gnustep] Don't emit .guess ivar offset vars.

2018-08-08 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339233. On Tue, Aug 7, 2018 at 2:02 PM, David Chisnall via cfe-commits wrote: > Author: theraven > Date: Tue Aug 7 05:02:46 2018 > New Revision: 339128 > > URL: http://llvm.org/viewvc/llvm-project?rev=339128&view=rev > Log: > [objc-gnustep] Don't emit .guess ivar offset vars. >

Re: r339210 - PR38286: Don't crash when attempting to define a constructor for an

2018-08-08 Thread Hans Wennborg via cfe-commits
Merged in r339236. Thanks! On Wed, Aug 8, 2018 at 2:46 AM, Richard Smith wrote: > Would be good to get this into the Clang 7 release. > > On Tue, 7 Aug 2018 at 17:43, Richard Smith via cfe-commits > wrote: >> >> Author: rsmith >> Date: Tue Aug 7 17:42:42 2018 >> New Revision: 339210 >> >> URL:

Re: r339317 - Correctly initialise global blocks on Windows.

2018-08-09 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339339. On Thu, Aug 9, 2018 at 10:02 AM, David Chisnall via cfe-commits wrote: > Author: theraven > Date: Thu Aug 9 01:02:42 2018 > New Revision: 339317 > > URL: http://llvm.org/viewvc/llvm-project?rev=339317&view=rev > Log: > Correctly initialise global blocks on Windows. > >

Re: r339281 - [CodeGen][Timers] Enable llvm::TimePassesIsEnabled when -ftime-report is specified

2018-08-09 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339341. On Wed, Aug 8, 2018 at 9:14 PM, Craig Topper via cfe-commits wrote: > Author: ctopper > Date: Wed Aug 8 12:14:23 2018 > New Revision: 339281 > > URL: http://llvm.org/viewvc/llvm-project?rev=339281&view=rev > Log: > [CodeGen][Timers] Enable llvm::TimePassesIsEnabled when

r339420 - clang-cl: Support /guard:cf,nochecks

2018-08-10 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 10 02:49:21 2018 New Revision: 339420 URL: http://llvm.org/viewvc/llvm-project?rev=339420&view=rev Log: clang-cl: Support /guard:cf,nochecks This extension emits the guard cf table without inserting the instrumentation. Currently that's what clang-cl does with /guard:cf

r339424 - clang-cl: accept -fcrash-diagnostics-dir=

2018-08-10 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 10 04:40:50 2018 New Revision: 339424 URL: http://llvm.org/viewvc/llvm-project?rev=339424&view=rev Log: clang-cl: accept -fcrash-diagnostics-dir= Modified: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/test/Driver/cl-options.c Modified: cfe/trunk/include/

Re: r339428 - Add Windows support for the GNUstep Objective-C ABI V2.

2018-08-13 Thread Hans Wennborg via cfe-commits
Merged both of these to 7.0 in r339538. On Sat, Aug 11, 2018 at 10:34 AM, David Chisnall via cfe-commits wrote: > Thanks, > > That fix looks exactly what is needed - and is something I didn’t realise > FileCheck could do! The order of those matters in the linked binary, but not > in the IR - t

Re: r339264 - [CGObjCGNU] Rename GetSelector helper method to fix -Woverloaded-virtual warning (PR38210)

2018-08-13 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339555. On Wed, Aug 8, 2018 at 5:53 PM, Simon Pilgrim via cfe-commits wrote: > Author: rksimon > Date: Wed Aug 8 08:53:14 2018 > New Revision: 339264 > > URL: http://llvm.org/viewvc/llvm-project?rev=339264&view=rev > Log: > [CGObjCGNU] Rename GetSelector helper method to fix -W

Re: r339074 - [lit, python] Always add quotes around the python path in lit

2018-08-13 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339554. On Tue, Aug 7, 2018 at 12:37 AM, Stella Stamenova via cfe-commits wrote: > Author: stella.stamenova > Date: Mon Aug 6 15:37:45 2018 > New Revision: 339074 > > URL: http://llvm.org/viewvc/llvm-project?rev=339074&view=rev > Log: > [lit, python] Always add quotes around th

Re: r338934 - [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

2018-08-14 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339660. On Sat, Aug 4, 2018 at 1:12 AM, Volodymyr Sapsai via cfe-commits wrote: > Author: vsapsai > Date: Fri Aug 3 16:12:37 2018 > New Revision: 338934 > > URL: http://llvm.org/viewvc/llvm-project?rev=338934&view=rev > Log: > [Preprocessor] Allow libc++ to detect when aligned

[libcxx] r339661 - Merging r339431:

2018-08-14 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Aug 14 02:13:39 2018 New Revision: 339661 URL: http://llvm.org/viewvc/llvm-project?rev=339661&view=rev Log: Merging r339431: r339431 | ldionne | 2018-08-10 15:24:56 +0200 (Fri, 10 Aug 2018) | 16 lines

Re: [libcxx] r339431 - [libc++] Enable aligned allocation based on feature test macro, irrespective of standard

2018-08-14 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339661. On Fri, Aug 10, 2018 at 3:24 PM, Louis Dionne via cfe-commits wrote: > Author: ldionne > Date: Fri Aug 10 06:24:56 2018 > New Revision: 339431 > > URL: http://llvm.org/viewvc/llvm-project?rev=339431&view=rev > Log: > [libc++] Enable aligned allocation based on feature te

Re: r339597 - Enforce instantiation of template multiversion functions

2018-08-14 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339663. On Mon, Aug 13, 2018 at 8:33 PM, Erich Keane via cfe-commits wrote: > Author: erichkeane > Date: Mon Aug 13 11:33:20 2018 > New Revision: 339597 > > URL: http://llvm.org/viewvc/llvm-project?rev=339597&view=rev > Log: > Enforce instantiation of template multiversion funct

[libcxx] r339850 - Merging r339697:

2018-08-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 16 02:03:32 2018 New Revision: 339850 URL: http://llvm.org/viewvc/llvm-project?rev=339850&view=rev Log: Merging r339697: r339697 | mstorsjo | 2018-08-14 19:33:10 +0200 (Tue, 14 Aug 2018) | 8 lines

Re: [libcxx] r339697 - [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option

2018-08-16 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339850. On Tue, Aug 14, 2018 at 7:33 PM, Martin Storsjo via cfe-commits wrote: > Author: mstorsjo > Date: Tue Aug 14 10:33:10 2018 > New Revision: 339697 > > URL: http://llvm.org/viewvc/llvm-project?rev=339697&view=rev > Log: > [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARE

Re: r339603 - [OPENMP] Fix emission of the loop doacross constructs.

2018-08-16 Thread Hans Wennborg via cfe-commits
I've gone ahead and merged it in r339851. On Wed, Aug 15, 2018 at 3:23 PM, Alexey Bataev wrote: > I think it would be good to backport it. Could you do that, Jonas? > > - > Best regards, > Alexey Bataev > > 15.08.2018 5:02, Jonas Hahnfeld via cfe-commits пишет: > > Alexey, Hans, > > d

[libcxx] r339852 - Merging r339794:

2018-08-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 16 02:45:10 2018 New Revision: 339852 URL: http://llvm.org/viewvc/llvm-project?rev=339852&view=rev Log: Merging r339794: r339794 | dim | 2018-08-15 19:30:32 +0200 (Wed, 15 Aug 2018) | 8 lines For F

Re: [libcxx] r339794 - For FreeBSD, don't define _M in nasty_macros.hpp

2018-08-16 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339852. On Wed, Aug 15, 2018 at 7:30 PM, Dimitry Andric via cfe-commits wrote: > Author: dim > Date: Wed Aug 15 10:30:32 2018 > New Revision: 339794 > > URL: http://llvm.org/viewvc/llvm-project?rev=339794&view=rev > Log: > For FreeBSD, don't define _M in nasty_macros.hpp > > Bec

[libcxx] r339854 - Merging r339743:

2018-08-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 16 02:52:16 2018 New Revision: 339854 URL: http://llvm.org/viewvc/llvm-project?rev=339854&view=rev Log: Merging r339743: r339743 | ldionne | 2018-08-15 02:30:03 +0200 (Wed, 15 Aug 2018) | 14 lines

Re: [libcxx] r339743 - [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions

2018-08-16 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339854. On Wed, Aug 15, 2018 at 2:30 AM, Louis Dionne via cfe-commits wrote: > Author: ldionne > Date: Tue Aug 14 17:30:03 2018 > New Revision: 339743 > > URL: http://llvm.org/viewvc/llvm-project?rev=339743&view=rev > Log: > [libcxx] Fix XFAILs for aligned allocation tests on ol

[libcxxabi] r339881 - Merging r339865:

2018-08-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 16 07:49:38 2018 New Revision: 339881 URL: http://llvm.org/viewvc/llvm-project?rev=339881&view=rev Log: Merging r339865: r339865 | yroux | 2018-08-16 13:38:09 +0200 (Thu, 16 Aug 2018) | 7 lines [li

Re: [libcxxabi] r339865 - [libcxxabi] Fix test_exception_address_alignment test for ARM

2018-08-16 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339881. On Thu, Aug 16, 2018 at 1:38 PM, Yvan Roux via cfe-commits wrote: > Author: yroux > Date: Thu Aug 16 04:38:09 2018 > New Revision: 339865 > > URL: http://llvm.org/viewvc/llvm-project?rev=339865&view=rev > Log: > [libcxxabi] Fix test_exception_address_alignment test for A

[libcxx] r339882 - Merging r339874:

2018-08-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 16 07:54:37 2018 New Revision: 339882 URL: http://llvm.org/viewvc/llvm-project?rev=339882&view=rev Log: Merging r339874: r339874 | ldionne | 2018-08-16 14:44:28 +0200 (Thu, 16 Aug 2018) | 25 lines

Re: [libcxx] r339874 - [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

2018-08-16 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339882. On Thu, Aug 16, 2018 at 2:44 PM, Louis Dionne via cfe-commits wrote: > Author: ldionne > Date: Thu Aug 16 05:44:28 2018 > New Revision: 339874 > > URL: http://llvm.org/viewvc/llvm-project?rev=339874&view=rev > Log: > [libcxx] By default, do not use internal_linkage to hi

[libcxx] r339987 - Merging r339675:

2018-08-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 17 00:19:32 2018 New Revision: 339987 URL: http://llvm.org/viewvc/llvm-project?rev=339987&view=rev Log: Merging r339675: r339675 | ldionne | 2018-08-14 15:29:17 +0200 (Tue, 14 Aug 2018) | 15 lines

[libcxx] r339988 - Merging r339702:

2018-08-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 17 00:20:04 2018 New Revision: 339988 URL: http://llvm.org/viewvc/llvm-project?rev=339988&view=rev Log: Merging r339702: r339702 | ldionne | 2018-08-14 20:16:56 +0200 (Tue, 14 Aug 2018) | 11 lines

[libcxx] r339989 - Merging r339741:

2018-08-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 17 00:20:30 2018 New Revision: 339989 URL: http://llvm.org/viewvc/llvm-project?rev=339989&view=rev Log: Merging r339741: r339741 | ldionne | 2018-08-15 02:16:41 +0200 (Wed, 15 Aug 2018) | 12 lines

[libcxx] r339990 - Merging r339742:

2018-08-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 17 00:20:52 2018 New Revision: 339990 URL: http://llvm.org/viewvc/llvm-project?rev=339990&view=rev Log: Merging r339742: r339742 | ldionne | 2018-08-15 02:18:01 +0200 (Wed, 15 Aug 2018) | 11 lines

[libcxx] r339991 - Merging r339804:

2018-08-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 17 00:21:26 2018 New Revision: 339991 URL: http://llvm.org/viewvc/llvm-project?rev=339991&view=rev Log: Merging r339804: r339804 | marshall | 2018-08-15 21:27:53 +0200 (Wed, 15 Aug 2018) | 1 line M

[libcxx] r339992 - Merging r339816:

2018-08-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 17 00:22:08 2018 New Revision: 339992 URL: http://llvm.org/viewvc/llvm-project?rev=339992&view=rev Log: Merging r339816: r339816 | marshall | 2018-08-15 23:19:08 +0200 (Wed, 15 Aug 2018) | 1 line S

Re: r339807 - Refactor Darwin driver to refer to runtimes by component

2018-08-17 Thread Hans Wennborg via cfe-commits
Just a heads up that this broke the Chromium build on Mac: https://crbug.com/874997 Apparently we have some target that explicitly targets 10.5. I don't know if that's really necessary, but the fact that we ran into this at all suggests others will too, so maybe this change warrants a release note

Re: r339807 - Refactor Darwin driver to refer to runtimes by component

2018-08-17 Thread Hans Wennborg via cfe-commits
Oh, and maybe the driver should diagnose if -mmacosx-version-min= is set too low? On Fri, Aug 17, 2018 at 12:38 PM, Hans Wennborg wrote: > Just a heads up that this broke the Chromium build on Mac: > https://crbug.com/874997 > > Apparently we have some target that explicitly targets 10.5. I don't

r340023 - clang-cl: Expose -fno-crash-diagnostics (PR38574)

2018-08-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 17 06:37:57 2018 New Revision: 340023 URL: http://llvm.org/viewvc/llvm-project?rev=340023&view=rev Log: clang-cl: Expose -fno-crash-diagnostics (PR38574) Modified: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/test/Driver/cl-options.c Modified: cfe/trunk/

Re: r340048 - Make __shiftleft128 / __shiftright128 real compiler built-ins.

2018-08-21 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r340289. On Fri, Aug 17, 2018 at 10:19 AM, Nico Weber via cfe-commits wrote: > Author: nico > Date: Fri Aug 17 10:19:06 2018 > New Revision: 340048 > > URL: http://llvm.org/viewvc/llvm-project?rev=340048&view=rev > Log: > Make __shiftleft128 / __shiftright128 real compiler built-

Re: [PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

2018-08-21 Thread Hans Wennborg via cfe-commits
Yes. But in practice nothing really changed though, right? It's just going forward that things might break: "This is a change in contract but not a change in behavior, since the current implementation still allows linking TUs built with different libc++ versions together." On Fri, Aug 17, 2018 at

Re: r340191 - [OPENMP] Fix crash on the emission of the weak function declaration.

2018-08-21 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r340351. On Mon, Aug 20, 2018 at 11:03 AM, Alexey Bataev via cfe-commits wrote: > Author: abataev > Date: Mon Aug 20 11:03:40 2018 > New Revision: 340191 > > URL: http://llvm.org/viewvc/llvm-project?rev=340191&view=rev > Log: > [OPENMP] Fix crash on the emission of the weak funct

Re: r340181 - [OPENMP][BLOCKS]Fix PR38923: reference to a global variable is captured

2018-08-21 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r340352. On Mon, Aug 20, 2018 at 9:00 AM, Alexey Bataev via cfe-commits wrote: > Author: abataev > Date: Mon Aug 20 09:00:22 2018 > New Revision: 340181 > > URL: http://llvm.org/viewvc/llvm-project?rev=340181&view=rev > Log: > [OPENMP][BLOCKS]Fix PR38923: reference to a global va

[libcxx] r340419 - Merging r340406:

2018-08-22 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 22 09:39:24 2018 New Revision: 340419 URL: http://llvm.org/viewvc/llvm-project?rev=340419&view=rev Log: Merging r340406: r340406 | ericwf | 2018-08-22 15:29:52 +0200 (Wed, 22 Aug 2018) | 12 lines A

Re: r339667 - Add a stub mangling for ObjC selectors in the Microsoft ABI.

2018-08-22 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r340437. On Tue, Aug 14, 2018 at 3:04 AM, David Chisnall via cfe-commits wrote: > Author: theraven > Date: Tue Aug 14 03:04:36 2018 > New Revision: 339667 > > URL: http://llvm.org/viewvc/llvm-project?rev=339667&view=rev > Log: > Add a stub mangling for ObjC selectors in the Micro

[libcxx] r340489 - Creating release candidate rc2 from release_700 branch

2018-08-22 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 22 16:52:29 2018 New Revision: 340489 URL: http://llvm.org/viewvc/llvm-project?rev=340489&view=rev Log: Creating release candidate rc2 from release_700 branch Added: libcxx/tags/RELEASE_700/rc2/ (props changed) - copied from r340488, libcxx/branches/release_

[libcxxabi] r340490 - Creating release candidate rc2 from release_700 branch

2018-08-22 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 22 16:52:36 2018 New Revision: 340490 URL: http://llvm.org/viewvc/llvm-project?rev=340490&view=rev Log: Creating release candidate rc2 from release_700 branch Added: libcxxabi/tags/RELEASE_700/rc2/ (props changed) - copied from r340489, libcxxabi/branches/re

[libunwind] r340496 - Creating release candidate rc2 from release_700 branch

2018-08-22 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 22 16:53:29 2018 New Revision: 340496 URL: http://llvm.org/viewvc/llvm-project?rev=340496&view=rev Log: Creating release candidate rc2 from release_700 branch Added: libunwind/tags/RELEASE_700/rc2/ (props changed) - copied from r340495, libunwind/branches/re

r331861 - Revert r331843 "[DebugInfo] Generate debug information for labels."

2018-05-09 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed May 9 02:29:58 2018 New Revision: 331861 URL: http://llvm.org/viewvc/llvm-project?rev=331861&view=rev Log: Revert r331843 "[DebugInfo] Generate debug information for labels." It broke the Chromium build (see reply on the review). > Generate DILabel metadata and call llvm.

r332335 - Make ast-print-record-decl.c pass on Windows after r332314

2018-05-15 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue May 15 03:19:24 2018 New Revision: 332335 URL: http://llvm.org/viewvc/llvm-project?rev=332335&view=rev Log: Make ast-print-record-decl.c pass on Windows after r332314 It was failing because on Windows, -ast-print prints __single_inheritance(1) before T1. Adding a triple is

Re: r332314 - [AST] Fix printing tag decl groups in decl contexts

2018-05-15 Thread Hans Wennborg via cfe-commits
This broke the ast-print-record-decl.c test on Windows, see for example http://lab.llvm.org:8011/builders/clang-with-thin-lto-windows/builds/9066 One way to reproduce the failure on Linux is to pass a Windows triple to this ast-print command: --- a/test/Misc/ast-print-record-decl.c +++ b/test/Mi

Re: r332314 - [AST] Fix printing tag decl groups in decl contexts

2018-05-16 Thread Hans Wennborg via cfe-commits
On Tue, May 15, 2018 at 7:30 PM, Joel E. Denny wrote: > Hi Hans, > > On Tue, May 15, 2018 at 6:23 AM, Hans Wennborg wrote: >> >> This broke the ast-print-record-decl.c test on Windows, see for >> example >> http://lab.llvm.org:8011/builders/clang-with-thin-lto-windows/builds/9066 >> >> One way to

Re: [PATCH] D46052: GNUstep Objective-C ABI version 2

2018-05-22 Thread Hans Wennborg via cfe-commits
On Tue, May 22, 2018 at 10:31 AM, David Chisnall via Phabricator via cfe-commits wrote: > theraven added inline comments. > > > > Comment at: lib/CodeGen/CGObjCGNU.cpp:1056 > +char c = Str[i]; > +if (isalpha(c) || isnumber(c)) > + StringName += c; > --

Re: r332963 - Revert "Revert r332955 "GNUstep Objective-C ABI version 2""

2018-05-23 Thread Hans Wennborg via cfe-commits
Hi David, On Tue, May 22, 2018 at 12:13 PM, David Chisnall via cfe-commits wrote: > Author: theraven > Date: Tue May 22 03:13:06 2018 > New Revision: 332963 > > URL: http://llvm.org/viewvc/llvm-project?rev=332963&view=rev > Log: > Revert "Revert r332955 "GNUstep Objective-C ABI version 2"" > > Ad

r333067 - Revert r333044 "Use zeroinitializer for (trailing zero portion of) large array initializers"

2018-05-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed May 23 01:24:01 2018 New Revision: 333067 URL: http://llvm.org/viewvc/llvm-project?rev=333067&view=rev Log: Revert r333044 "Use zeroinitializer for (trailing zero portion of) large array initializers" It caused asserts, see PR37560. > Use zeroinitializer for (trailing zer

Re: r332963 - Revert "Revert r332955 "GNUstep Objective-C ABI version 2""

2018-05-23 Thread Hans Wennborg via cfe-commits
Sounds good, thanks! On Wed, May 23, 2018 at 10:26 AM, David Chisnall wrote: > On 23 May 2018, at 08:38, Hans Wennborg wrote: >> >> Hi David, >> >> On Tue, May 22, 2018 at 12:13 PM, David Chisnall via cfe-commits >> wrote: >>> Author: theraven >>> Date: Tue May 22 03:13:06 2018 >>> New Revision

Re: r333044 - Use zeroinitializer for (trailing zero portion of) large array initializers

2018-05-23 Thread Hans Wennborg via cfe-commits
We're hitting asserts after this in Chromium. I've filed PR37560 and reverted in r333067. On Wed, May 23, 2018 at 2:09 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Tue May 22 17:09:29 2018 > New Revision: 333044 > > URL: http://llvm.org/viewvc/llvm-project?rev=333044&view=rev

r333170 - Fix ASTImporterTest on Windows after r333082

2018-05-24 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu May 24 03:49:38 2018 New Revision: 333170 URL: http://llvm.org/viewvc/llvm-project?rev=333170&view=rev Log: Fix ASTImporterTest on Windows after r333082 With MS compatibility, Sema adds an implicit definition of type_info, which was causing the matchers to return 3 instead

Re: r333082 - Fix duplicate class template definitions problem

2018-05-24 Thread Hans Wennborg via cfe-commits
On Wed, May 23, 2018 at 3:53 PM, Gabor Marton via cfe-commits wrote: > Author: martong > Date: Wed May 23 06:53:36 2018 > New Revision: 333082 > > URL: http://llvm.org/viewvc/llvm-project?rev=333082&view=rev > Log: > Fix duplicate class template definitions problem > > Summary: > We fail to import

r333515 - Add missing curly from r333509

2018-05-30 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed May 30 01:05:24 2018 New Revision: 333515 URL: http://llvm.org/viewvc/llvm-project?rev=333515&view=rev Log: Add missing curly from r333509 Modified: cfe/trunk/lib/Headers/avx512vlvnniintrin.h Modified: cfe/trunk/lib/Headers/avx512vlvnniintrin.h URL: http://llvm.org/vi

Re: r333509 - [X86] Remove masking from the AVX512VNNI builtins. Use a select in IR instead.

2018-05-30 Thread Hans Wennborg via cfe-commits
On Wed, May 30, 2018 at 7:26 AM, Craig Topper via cfe-commits wrote: > Author: ctopper > Date: Tue May 29 22:26:04 2018 > New Revision: 333509 > > URL: http://llvm.org/viewvc/llvm-project?rev=333509&view=rev > Log: > [X86] Remove masking from the AVX512VNNI builtins. Use a select in IR instead. >

Re: r314689 - Revert "[Sema] Warn on attribute nothrow conflicting with language specifiers"

2017-10-02 Thread Hans Wennborg via cfe-commits
This is https://bugs.llvm.org/show_bug.cgi?id=34805 On Mon, Oct 2, 2017 at 10:16 AM, Reid Kleckner via cfe-commits wrote: > Author: rnk > Date: Mon Oct 2 10:16:14 2017 > New Revision: 314689 > > URL: http://llvm.org/viewvc/llvm-project?rev=314689&view=rev > Log: > Revert "[Sema] Warn on attribut

r315025 - For dllexport class templates, export specializations of member functions (PR34849)

2017-10-05 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Oct 5 14:45:27 2017 New Revision: 315025 URL: http://llvm.org/viewvc/llvm-project?rev=315025&view=rev Log: For dllexport class templates, export specializations of member functions (PR34849) Modified: cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/test/CodeGenCXX/dllex

Re: r315251 - [Modules TS] Module ownership semantics for redeclarations.

2017-10-10 Thread Hans Wennborg via cfe-commits
Thanks for reverting. We saw build failures in Chromium too. E.g. from https://build.chromium.org/p/chromium.clang/builders/ToTLinux/builds/134: In file included from ../../third_party/breakpad/breakpad/src/common/linux/symbol_upload.cc:34: ../../third_party/breakpad/breakpad/src/common/linux/sym

r315330 - For dllexport class templates, export specializations of member functions (PR34849) (take 2)

2017-10-10 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Oct 10 09:53:25 2017 New Revision: 315330 URL: http://llvm.org/viewvc/llvm-project?rev=315330&view=rev Log: For dllexport class templates, export specializations of member functions (PR34849) (take 2) This is a re-commit of r315025, but making sure to only apply this to sp

Re: r316268 - [Sema] Fixes for enum handling for tautological comparison diagnostics

2017-10-23 Thread Hans Wennborg via cfe-commits
This seems to have had the side effect of introducing a new warning in Chromium builds: ../../third_party/expat/files/lib/xmlparse.c(2429,24): error: comparison of integers of different signs: 'enum XML_Error' and 'unsigned int' [-Werror,-Wsign-compare] if (code > 0 && code < sizeof(message)/si

Re: r316268 - [Sema] Fixes for enum handling for tautological comparison diagnostics

2017-10-24 Thread Hans Wennborg via cfe-commits
On Mon, Oct 23, 2017 at 2:02 PM, Roman Lebedev wrote: > On Mon, Oct 23, 2017 at 2:13 PM, Hans Wennborg wrote: > Hi. > >> This seems to have had the side effect of introducing a new warning in >> Chromium builds: >> >> ../../third_party/expat/files/lib/xmlparse.c(2429,24): error: >> comparison of

[libcxx] r340662 - Merging r340544:

2018-08-24 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 24 15:16:24 2018 New Revision: 340662 URL: http://llvm.org/viewvc/llvm-project?rev=340662&view=rev Log: Merging r340544: r340544 | epilk | 2018-08-23 19:08:02 +0200 (Thu, 23 Aug 2018) | 3 lines Com

Re: [libcxx] r340544 - Comment out #define __cpp_lib_node_extract, we only support half of that functionality

2018-08-24 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r340662. On Thu, Aug 23, 2018 at 10:08 AM, Erik Pilkington via cfe-commits wrote: > Author: epilk > Date: Thu Aug 23 10:08:02 2018 > New Revision: 340544 > > URL: http://llvm.org/viewvc/llvm-project?rev=340544&view=rev > Log: > Comment out #define __cpp_lib_node_extract, we only

r340666 - Revert r323281 "Adjust MaxAtomicInlineWidth for i386/i486 targets."

2018-08-24 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 24 15:46:33 2018 New Revision: 340666 URL: http://llvm.org/viewvc/llvm-project?rev=340666&view=rev Log: Revert r323281 "Adjust MaxAtomicInlineWidth for i386/i486 targets." As reported on http://lists.llvm.org/pipermail/cfe-dev/2018-August/058760.html, this broke i386-fr

Re: r340376 - Update the docs for using LLVM toolset in Visual Studio

2018-08-27 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r340730. On Wed, Aug 22, 2018 at 3:11 AM, Stephen Kelly via cfe-commits wrote: > Author: steveire > Date: Tue Aug 21 18:11:18 2018 > New Revision: 340376 > > URL: http://llvm.org/viewvc/llvm-project?rev=340376&view=rev > Log: > Update the docs for using LLVM toolset in Visual Stu

[libcxx] r341034 - Merging r340823:

2018-08-30 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 30 01:19:15 2018 New Revision: 341034 URL: http://llvm.org/viewvc/llvm-project?rev=341034&view=rev Log: Merging r340823: r340823 | marshall | 2018-08-28 15:29:30 +0200 (Tue, 28 Aug 2018) | 1 line U

Re: [libcxx] r340823 - Use addressof instead of operator& in make_shared. Fixes PR38729. As a drive-by, make the same change in raw_storage_iterator (twice).

2018-08-30 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r341034. On Tue, Aug 28, 2018 at 3:29 PM, Marshall Clow via cfe-commits wrote: > Author: marshall > Date: Tue Aug 28 06:29:30 2018 > New Revision: 340823 > > URL: http://llvm.org/viewvc/llvm-project?rev=340823&view=rev > Log: > Use addressof instead of operator& in make_shared. F

[libcxx] r341529 - Merging r340609:

2018-09-06 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Sep 6 01:54:44 2018 New Revision: 341529 URL: http://llvm.org/viewvc/llvm-project?rev=341529&view=rev Log: Merging r340609: r340609 | ldionne | 2018-08-24 16:10:28 +0200 (Fri, 24 Aug 2018) | 13 lines

Re: [libcxx] r340609 - [libc++] Fix handling of negated character classes in regex

2018-09-06 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r341529. On Fri, Aug 24, 2018 at 4:10 PM, Louis Dionne via cfe-commits wrote: > Author: ldionne > Date: Fri Aug 24 07:10:28 2018 > New Revision: 340609 > > URL: http://llvm.org/viewvc/llvm-project?rev=340609&view=rev > Log: > [libc++] Fix handling of negated character classes in

r341786 - ReleaseNotes: update links to use https

2018-09-10 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Sep 10 01:51:25 2018 New Revision: 341786 URL: http://llvm.org/viewvc/llvm-project?rev=341786&view=rev Log: ReleaseNotes: update links to use https Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-pro

[clang-tools-extra] r341787 - ReleaseNotes: update links to use https

2018-09-10 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Sep 10 01:52:04 2018 New Revision: 341787 URL: http://llvm.org/viewvc/llvm-project?rev=341787&view=rev Log: ReleaseNotes: update links to use https Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL: htt

[libcxx] r341789 - ReleaseNotes: update links to use https

2018-09-10 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Sep 10 01:57:12 2018 New Revision: 341789 URL: http://llvm.org/viewvc/llvm-project?rev=341789&view=rev Log: ReleaseNotes: update links to use https Modified: libcxx/trunk/docs/ReleaseNotes.rst Modified: libcxx/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/ll

[libcxxabi] r341812 - Creating release candidate rc3 from release_700 branch

2018-09-10 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Sep 10 05:17:27 2018 New Revision: 341812 URL: http://llvm.org/viewvc/llvm-project?rev=341812&view=rev Log: Creating release candidate rc3 from release_700 branch Added: libcxxabi/tags/RELEASE_700/rc3/ (props changed) - copied from r341811, libcxxabi/branches/re

[libcxx] r341811 - Creating release candidate rc3 from release_700 branch

2018-09-10 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Sep 10 05:17:20 2018 New Revision: 341811 URL: http://llvm.org/viewvc/llvm-project?rev=341811&view=rev Log: Creating release candidate rc3 from release_700 branch Added: libcxx/tags/RELEASE_700/rc3/ (props changed) - copied from r341810, libcxx/branches/release_

[libunwind] r341818 - Creating release candidate rc3 from release_700 branch

2018-09-10 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Sep 10 05:18:15 2018 New Revision: 341818 URL: http://llvm.org/viewvc/llvm-project?rev=341818&view=rev Log: Creating release candidate rc3 from release_700 branch Added: libunwind/tags/RELEASE_700/rc3/ (props changed) - copied from r341817, libunwind/branches/re

r342240 - [clang-cl] Fix PR38934: failing to dllexport class template member w/ explicit instantiation and PCH

2018-09-14 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Sep 14 08:18:30 2018 New Revision: 342240 URL: http://llvm.org/viewvc/llvm-project?rev=342240&view=rev Log: [clang-cl] Fix PR38934: failing to dllexport class template member w/ explicit instantiation and PCH The code in ASTContext::DeclMustBeEmitted was supposed to handle

r338366 - clang-format: try to make the doc for ConstructorInitializerAllOnOneLineOrOnePerLine more clear

2018-07-31 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jul 31 05:42:02 2018 New Revision: 338366 URL: http://llvm.org/viewvc/llvm-project?rev=338366&view=rev Log: clang-format: try to make the doc for ConstructorInitializerAllOnOneLineOrOnePerLine more clear PR38080 complained that the "OnePerLine" case wasn't previously shown

r338528 - UserManual: Update with the latest clang-cl flags

2018-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 1 05:58:57 2018 New Revision: 338528 URL: http://llvm.org/viewvc/llvm-project?rev=338528&view=rev Log: UserManual: Update with the latest clang-cl flags Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL: http://llvm.org/viewvc/

r338534 - Make test/Frontend/clang-abi-compat.cpp pass when the version goes to 8

2018-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 1 06:19:14 2018 New Revision: 338534 URL: http://llvm.org/viewvc/llvm-project?rev=338534&view=rev Log: Make test/Frontend/clang-abi-compat.cpp pass when the version goes to 8 Modified: cfe/trunk/test/Frontend/clang-abi-compat.cpp Modified: cfe/trunk/test/Frontend/

[libcxx] r338542 - Creating release_70 branch off revision 338536

2018-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 1 06:30:36 2018 New Revision: 338542 URL: http://llvm.org/viewvc/llvm-project?rev=338542&view=rev Log: Creating release_70 branch off revision 338536 Added: libcxx/branches/release_70/ (props changed) - copied from r338536, libcxx/trunk/ Propchange: libcxx

[libcxxabi] r338543 - Creating release_70 branch off revision 338536

2018-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 1 06:30:41 2018 New Revision: 338543 URL: http://llvm.org/viewvc/llvm-project?rev=338543&view=rev Log: Creating release_70 branch off revision 338536 Added: libcxxabi/branches/release_70/ - copied from r338536, libcxxabi/trunk/ __

[libunwind] r338549 - Creating release_70 branch off revision 338536

2018-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 1 06:31:22 2018 New Revision: 338549 URL: http://llvm.org/viewvc/llvm-project?rev=338549&view=rev Log: Creating release_70 branch off revision 338536 Added: libunwind/branches/release_70/ - copied from r338536, libunwind/trunk/ __

[libcxx] r338555 - Update version to 8.0.0svn: cmake, includes files and docs

2018-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 1 06:54:28 2018 New Revision: 338555 URL: http://llvm.org/viewvc/llvm-project?rev=338555&view=rev Log: Update version to 8.0.0svn: cmake, includes files and docs Modified: libcxx/trunk/CMakeLists.txt libcxx/trunk/docs/conf.py libcxx/trunk/include/__config

r338557 - Update docs version and clear release notes after 8.0.0 version bump

2018-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 1 07:01:27 2018 New Revision: 338557 URL: http://llvm.org/viewvc/llvm-project?rev=338557&view=rev Log: Update docs version and clear release notes after 8.0.0 version bump Modified: cfe/trunk/docs/ReleaseNotes.rst cfe/trunk/docs/conf.py Modified: cfe/trunk/doc

[clang-tools-extra] r338559 - Update docs version and clear release notes after 8.0.0 version bump

2018-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 1 07:09:00 2018 New Revision: 338559 URL: http://llvm.org/viewvc/llvm-project?rev=338559&view=rev Log: Update docs version and clear release notes after 8.0.0 version bump Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst clang-tools-extra/trunk/docs/conf

[libunwind] r338561 - Update docs version and clear release notes after 8.0.0 version bump

2018-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 1 07:14:09 2018 New Revision: 338561 URL: http://llvm.org/viewvc/llvm-project?rev=338561&view=rev Log: Update docs version and clear release notes after 8.0.0 version bump Modified: libunwind/trunk/docs/conf.py Modified: libunwind/trunk/docs/conf.py URL: http://l

[libcxxabi] r338564 - Update version to 8.0.0svn

2018-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 1 07:25:03 2018 New Revision: 338564 URL: http://llvm.org/viewvc/llvm-project?rev=338564&view=rev Log: Update version to 8.0.0svn Modified: libcxxabi/trunk/CMakeLists.txt Modified: libcxxabi/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/libcxxabi/

[libunwind] r338570 - Bump version number to 8.0.0svn

2018-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 1 08:22:27 2018 New Revision: 338570 URL: http://llvm.org/viewvc/llvm-project?rev=338570&view=rev Log: Bump version number to 8.0.0svn Modified: libunwind/trunk/CMakeLists.txt Modified: libunwind/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/libun

[libcxx] r338571 - Drop 'svn' suffix from the version number.

2018-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 1 08:23:47 2018 New Revision: 338571 URL: http://llvm.org/viewvc/llvm-project?rev=338571&view=rev Log: Drop 'svn' suffix from the version number. Modified: libcxx/branches/release_70/CMakeLists.txt Modified: libcxx/branches/release_70/CMakeLists.txt URL: http://l

[libunwind] r338572 - Drop 'svn' suffix from the version number.

2018-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 1 08:24:06 2018 New Revision: 338572 URL: http://llvm.org/viewvc/llvm-project?rev=338572&view=rev Log: Drop 'svn' suffix from the version number. Modified: libunwind/branches/release_70/CMakeLists.txt Modified: libunwind/branches/release_70/CMakeLists.txt URL: ht

r338602 - Revert r338455 "[constexpr] Support for constant evaluation of __builtin_memcpy and __builtin_memmove (in non-type-punning cases)."

2018-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 1 10:51:23 2018 New Revision: 338602 URL: http://llvm.org/viewvc/llvm-project?rev=338602&view=rev Log: Revert r338455 "[constexpr] Support for constant evaluation of __builtin_memcpy and __builtin_memmove (in non-type-punning cases)." It caused asserts during Chromium

Re: r338455 - [constexpr] Support for constant evaluation of __builtin_memcpy and

2018-08-01 Thread Hans Wennborg via cfe-commits
We hit this in Chromium too, see crbug.com/869824 I've reverted in r338602 On Wed, Aug 1, 2018 at 5:26 PM, Benjamin Kramer via cfe-commits wrote: > It's pretty easy to make this crash > > $ cat memcpy.c > void foo() { > int a[1], b; > memcpy((char*)a, (const char*)&b, (unsigned long)4); > }

Re: r338602 - Revert r338455 "[constexpr] Support for constant evaluation of __builtin_memcpy and __builtin_memmove (in non-type-punning cases)."

2018-08-01 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r338674. On Wed, Aug 1, 2018 at 7:51 PM, Hans Wennborg via cfe-commits wrote: > Author: hans > Date: Wed Aug 1 10:51:23 2018 > New Revision: 338602 > > URL: http://llvm.org/viewvc/llvm-project?rev=338602&view=rev > Log: > Revert r338455 "[c

Re: r338552 - Add REQUIRES: native to a test that assumes it

2018-08-02 Thread Hans Wennborg via cfe-commits
Merged to 6.0 in r338687. On Wed, Aug 1, 2018 at 3:41 PM, Filipe Cabecinhas via cfe-commits wrote: > Author: filcab > Date: Wed Aug 1 06:41:11 2018 > New Revision: 338552 > > URL: http://llvm.org/viewvc/llvm-project?rev=338552&view=rev > Log: > Add REQUIRES: native to a test that assumes it > >

Re: r338553 - Use a dummy target so the test passes when default target is for a toolchain implements useIntegratedAs() -> true

2018-08-02 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r338688. On Wed, Aug 1, 2018 at 3:41 PM, Filipe Cabecinhas via cfe-commits wrote: > Author: filcab > Date: Wed Aug 1 06:41:42 2018 > New Revision: 338553 > > URL: http://llvm.org/viewvc/llvm-project?rev=338553&view=rev > Log: > Use a dummy target so the test passes when default

Re: r338749 - Work around more GCC miscompiles exposed by r338464.

2018-08-03 Thread Hans Wennborg via cfe-commits
Merged in r338845. Thanks! On Thu, Aug 2, 2018 at 10:48 PM, Richard Smith wrote: > (+Hans) +1 > > On Thu, 2 Aug 2018 at 11:37, Martin Storsjö via cfe-commits > wrote: >> >> Hans, >> >> I think this commit should be merged to the 7.0 release branch; the first >> half of the GCC workaround made it

  1   2   3   4   5   6   7   8   9   10   >