giulianobelinassi wrote:
I am not sure how I feel about dropping the canPrintOnRight/printOnRight logic.
We use it as a fallback when the SourceRange of a function is unreliable,
otherwise we always copy and paste the code the user wrote.
Regardless of that I will check for fallbacks on clang-
giulianobelinassi wrote:
> > > > > @erichkeane, thank you. What's the process of including this in the
> > > > > next release?
> > > >
> > > >
> > > > After CI is complete, you can click "Squash and Merge" below (if you
> > > > cannot, let us know and someone can do it for you), and it'll be
giulianobelinassi wrote:
We would like this fixed in 18.1 as well. We are expanding to support C++ and
we will hit this bug at some point.
https://github.com/llvm/llvm-project/pull/87281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
giulianobelinassi wrote:
> Maybe you can open a PR against the branch?
Sorry, but I can only do this tomorrow. Feel free to open the PR if you need it
immediately.
> And `final` as well as `override`? (This is why I'm not convinced we should
> be backporting anything -- the problem is with pr
https://github.com/giulianobelinassi created
https://github.com/llvm/llvm-project/pull/105591
Previoulsy, calling `ASTUnit::LoadFromCompilerInvocation` with
`PrecompilePreambleAfterNParses > 0` caused the `__COUNT__` macro value to be
restarted. This commit fixes this by remembering the value
https://github.com/giulianobelinassi updated
https://github.com/llvm/llvm-project/pull/105591
>From 914427af9b83848ac395bbff663133aadf387161 Mon Sep 17 00:00:00 2001
From: Giuliano Belinassi
Date: Wed, 21 Aug 2024 18:31:36 -0300
Subject: [PATCH] Fix the behavior of __COUNT__ macros when PCH is
https://github.com/giulianobelinassi updated
https://github.com/llvm/llvm-project/pull/105591
>From 3a1a241f925e7b6dcc6c8701ab83b5fb04f18853 Mon Sep 17 00:00:00 2001
From: Giuliano Belinassi
Date: Wed, 21 Aug 2024 18:31:36 -0300
Subject: [PATCH] Fix the behavior of __COUNT__ macros when PCH is
@@ -1243,12 +1247,19 @@ bool
ASTUnit::Parse(std::shared_ptr PCHContainerOps,
}
std::unique_ptr Act(
- new TopLevelDeclTrackerAction(*this));
+ new TopLevelDeclTrackerAction(*this, true));
giulianobelinassi wrote:
The problem is that when you ar
