r339079 - [analyzer] Add ASTContext to CheckerManager

2018-08-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Aug 6 16:09:07 2018 New Revision: 339079 URL: http://llvm.org/viewvc/llvm-project?rev=339079&view=rev Log: [analyzer] Add ASTContext to CheckerManager Some checkers require ASTContext. Having it in the constructor saves a lot of boilerplate of having to pass it

r339183 - [analyzer] [tests] Do not be verbose by default when updating reference results.

2018-08-07 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Aug 7 14:14:35 2018 New Revision: 339183 URL: http://llvm.org/viewvc/llvm-project?rev=339183&view=rev Log: [analyzer] [tests] Do not be verbose by default when updating reference results. Modified: cfe/trunk/utils/analyzer/SATestUpdateDiffs.py Modified: cf

r339369 - [analyzer] Fix the bug in UninitializedObjectChecker caused by not handling block pointers

2018-08-09 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Aug 9 12:03:12 2018 New Revision: 339369 URL: http://llvm.org/viewvc/llvm-project?rev=339369&view=rev Log: [analyzer] Fix the bug in UninitializedObjectChecker caused by not handling block pointers Differential Revision: https://reviews.llvm.org/D50523 Added:

r339459 - Invalidate static locals when escaping lambdas

2018-08-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Aug 10 11:28:04 2018 New Revision: 339459 URL: http://llvm.org/viewvc/llvm-project?rev=339459&view=rev Log: Invalidate static locals when escaping lambdas Lambdas can affect static locals even without an explicit capture. rdar://39537031 Differential Revision:

r339476 - [analyzer] Fix tracking expressions through negation operator

2018-08-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Aug 10 14:42:19 2018 New Revision: 339476 URL: http://llvm.org/viewvc/llvm-project?rev=339476&view=rev Log: [analyzer] Fix tracking expressions through negation operator Differential Revision: https://reviews.llvm.org/D50537 Modified: cfe/trunk/lib/StaticAn

r339482 - [analyzer] Record nullability implications on getting items from NSDictionary

2018-08-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Aug 10 15:27:04 2018 New Revision: 339482 URL: http://llvm.org/viewvc/llvm-project?rev=339482&view=rev Log: [analyzer] Record nullability implications on getting items from NSDictionary If we get an item from a dictionary, we know that the item is non-null if an

r339493 - [analyzer] Fix keyboard navigation for .msgNote events

2018-08-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Aug 10 18:47:41 2018 New Revision: 339493 URL: http://llvm.org/viewvc/llvm-project?rev=339493&view=rev Log: [analyzer] Fix keyboard navigation for .msgNote events Does not go to msgNote's. Differential Revision: https://reviews.llvm.org/D50595 Modified: cf

r339629 - [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

2018-08-13 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Aug 13 16:12:43 2018 New Revision: 339629 URL: http://llvm.org/viewvc/llvm-project?rev=339629&view=rev Log: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3 Current testing setup for analyzer

r339631 - [analyzer] Fix UninitializedObjectChecker to not crash on uninitialized "id" fields

2018-08-13 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Aug 13 16:32:15 2018 New Revision: 339631 URL: http://llvm.org/viewvc/llvm-project?rev=339631&view=rev Log: [analyzer] Fix UninitializedObjectChecker to not crash on uninitialized "id" fields Differential Revision: https://reviews.llvm.org/D50673 Modified:

Re: [PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

2018-08-14 Thread George Karpenkov via cfe-commits
Yes, investigating. Will rollback if not fixed in a few hours. > On Aug 14, 2018, at 3:17 AM, Yvan Roux via Phabricator > wrote: > > yroux added a comment. > > Notice that the affected bots run two times the test cases where one > execution passes and one fails, as you can see in (search > A

r339709 - [analyzer] Fix bots by removing new check-clang-analyzer commands from CHECK-ALL

2018-08-14 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Aug 14 11:55:34 2018 New Revision: 339709 URL: http://llvm.org/viewvc/llvm-project?rev=339709&view=rev Log: [analyzer] Fix bots by removing new check-clang-analyzer commands from CHECK-ALL Modified: cfe/trunk/test/CMakeLists.txt Modified: cfe/trunk/test/CMa

Re: [PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

2018-08-14 Thread George Karpenkov via cfe-commits
Should be fixed. > On Aug 14, 2018, at 10:32 AM, George Karpenkov via cfe-commits > wrote: > > Yes, investigating. Will rollback if not fixed in a few hours. > >> On Aug 14, 2018, at 3:17 AM, Yvan Roux via Phabricator >> wrote: >> >> yroux added a c

Re: [PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

2018-08-14 Thread George Karpenkov via cfe-commits
Should be fixed now. > On Aug 14, 2018, at 1:10 AM, Thomas Preud'homme via Phabricator > wrote: > > thopre added a comment. > > Hi George, > > This commit seems to be causing some testsuite regression on Armv8 (both > Aarch64 and ARM) architectures: > http://lab.llvm.org:8011/builders/clang-

Re: r339629 - [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

2018-08-14 Thread George Karpenkov via cfe-commits
alysis/plist-html-macros.c > Clang :: Analysis/retain-release-path-notes-gc.m > Clang :: Analysis/temp-obj-dtors-cfg-output.cpp > > Please have a look ASAP? > > Thanks > > Galina > > > On Mon, Aug 13, 2018 at 4:12 PM, George Karpenkov via cfe-commits > mail

Re: r339629 - [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

2018-08-14 Thread George Karpenkov via cfe-commits
rks for me, and the buildbots are quiet this time. Sorry for the trouble. Your change seems safe in either case. > > On Mon, Aug 13, 2018 at 4:13 PM George Karpenkov via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: george.karpenkov > Date: Mon Aug 13

r340093 - [analyzer] [NFC] Split up summary generation in RetainCountChecker in two methods

2018-08-17 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Aug 17 14:41:37 2018 New Revision: 340093 URL: http://llvm.org/viewvc/llvm-project?rev=340093&view=rev Log: [analyzer] [NFC] Split up summary generation in RetainCountChecker in two methods Differential Revision: https://reviews.llvm.org/D50830 Modified:

r340094 - [analyzer] [NFC] Move canEval function from RetainCountChecker to RetainCountSummaries

2018-08-17 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Aug 17 14:42:05 2018 New Revision: 340094 URL: http://llvm.org/viewvc/llvm-project?rev=340094&view=rev Log: [analyzer] [NFC] Move canEval function from RetainCountChecker to RetainCountSummaries Differential Revision: https://reviews.llvm.org/D50863 Modified:

r340096 - [analyzer] [NFC] Move ObjCRetainCount to include/Analysis

2018-08-17 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Aug 17 14:42:32 2018 New Revision: 340096 URL: http://llvm.org/viewvc/llvm-project?rev=340096&view=rev Log: [analyzer] [NFC] Move ObjCRetainCount to include/Analysis Differential Revision: https://reviews.llvm.org/D50869 Added: cfe/trunk/include/clang/Analy

r340098 - [analyzer] [NFC] Minor refactoring of ISL-specific code in RetainCountChecker

2018-08-17 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Aug 17 14:43:27 2018 New Revision: 340098 URL: http://llvm.org/viewvc/llvm-project?rev=340098&view=rev Log: [analyzer] [NFC] Minor refactoring of ISL-specific code in RetainCountChecker Differential Revision: https://reviews.llvm.org/D50879 Modified: cfe/t

r340110 - Quickfix for failing tests.

2018-08-17 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Aug 17 16:54:00 2018 New Revision: 340110 URL: http://llvm.org/viewvc/llvm-project?rev=340110&view=rev Log: Quickfix for failing tests. Modified: cfe/trunk/test/ARCMT/objcmt-arc-cf-annotations.m.result Modified: cfe/trunk/test/ARCMT/objcmt-arc-cf-annotation

r340377 - [analyzer] [NFC] Extract a method for creating RefVal from RetEffect in RetainCountChecker

2018-08-21 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Aug 21 18:16:49 2018 New Revision: 340377 URL: http://llvm.org/viewvc/llvm-project?rev=340377&view=rev Log: [analyzer] [NFC] Extract a method for creating RefVal from RetEffect in RetainCountChecker Differential Revision: https://reviews.llvm.org/D51071 Modifi

r340378 - [analyzer] [NFC] Fix minor formatting issues in RetainCountChecker

2018-08-21 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Aug 21 18:17:09 2018 New Revision: 340378 URL: http://llvm.org/viewvc/llvm-project?rev=340378&view=rev Log: [analyzer] [NFC] Fix minor formatting issues in RetainCountChecker Differential Revision: https://reviews.llvm.org/D51072 Modified: cfe/trunk/lib/St

r340473 - [analyzer] [NFC] Minor refactoring of BugReporterVisitors

2018-08-22 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 22 16:16:44 2018 New Revision: 340473 URL: http://llvm.org/viewvc/llvm-project?rev=340473&view=rev Log: [analyzer] [NFC] Minor refactoring of BugReporterVisitors Differential Revision: https://reviews.llvm.org/D51130 Modified: cfe/trunk/lib/StaticAnalyz

r340474 - [analyzer] Track the problematic subexpression in UndefResultChecker

2018-08-22 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 22 16:17:02 2018 New Revision: 340474 URL: http://llvm.org/viewvc/llvm-project?rev=340474&view=rev Log: [analyzer] Track the problematic subexpression in UndefResultChecker This is tested in a subsequent commit, which allows tracking those values. Different

r340475 - [analyzer] Track non-zero values in ReturnVisitor

2018-08-22 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 22 16:17:25 2018 New Revision: 340475 URL: http://llvm.org/viewvc/llvm-project?rev=340475&view=rev Log: [analyzer] Track non-zero values in ReturnVisitor Tracking those can help to provide much better diagnostics in many cases. In general, most of the visit

r340479 - [NFC] Add tags file to .gitignore

2018-08-22 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 22 16:23:17 2018 New Revision: 340479 URL: http://llvm.org/viewvc/llvm-project?rev=340479&view=rev Log: [NFC] Add tags file to .gitignore Differential Revision: https://reviews.llvm.org/D50109 Modified: cfe/trunk/.gitignore Modified: cfe/trunk/.gitigno

r340500 - Revert "[CStringSyntaxChecker] Reduces space around error message for strlcat."

2018-08-22 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 22 17:02:12 2018 New Revision: 340500 URL: http://llvm.org/viewvc/llvm-project?rev=340500&view=rev Log: Revert "[CStringSyntaxChecker] Reduces space around error message for strlcat." This reverts commit 6b43b80320722da41ca6ef7a3b57cc300fb83094. Modified:

r340501 - Revert "[CStringSyntaxChecker] Check strlcat sizeof check"

2018-08-22 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 22 17:02:35 2018 New Revision: 340501 URL: http://llvm.org/viewvc/llvm-project?rev=340501&view=rev Log: Revert "[CStringSyntaxChecker] Check strlcat sizeof check" This reverts commit 3073790e87378fea9a68fb052185fec9596ef135. The check is not correct, strlac

r340502 - [analyzer] Preliminary version of retain count checking for OSObjects

2018-08-22 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 22 17:26:59 2018 New Revision: 340502 URL: http://llvm.org/viewvc/llvm-project?rev=340502&view=rev Log: [analyzer] Preliminary version of retain count checking for OSObjects Has quite a lot of false positives, disabled behind the flag. Differential Revision

r332135 - [analyzer] Fix the filename for the exploration_order test.

2018-05-11 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri May 11 13:38:39 2018 New Revision: 332135 URL: http://llvm.org/viewvc/llvm-project?rev=332135&view=rev Log: [analyzer] Fix the filename for the exploration_order test. Ensures that the test is being run. Added: cfe/trunk/test/Analysis/exploration_order/pref

r332136 - [analyzer] Ignore the nullability quantifiers for autoreleasewritechecker

2018-05-11 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri May 11 13:39:19 2018 New Revision: 332136 URL: http://llvm.org/viewvc/llvm-project?rev=332136&view=rev Log: [analyzer] Ignore the nullability quantifiers for autoreleasewritechecker Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/ObjCAutoreleaseWriteChecker.

r332288 - Remove the fixit for the diagnostics regarding capturing autoreleasing variables in a block

2018-05-14 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon May 14 13:29:16 2018 New Revision: 332288 URL: http://llvm.org/viewvc/llvm-project?rev=332288&view=rev Log: Remove the fixit for the diagnostics regarding capturing autoreleasing variables in a block The fixit is actively harmful, as it encourages developers to

r332300 - [analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well

2018-05-14 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon May 14 14:39:54 2018 New Revision: 332300 URL: http://llvm.org/viewvc/llvm-project?rev=332300&view=rev Log: [analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well A common pattern is that the code in the block does not write into the varia

r332422 - [analyzer] Do not crash on callback for call_once passed by value

2018-05-15 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue May 15 17:29:13 2018 New Revision: 332422 URL: http://llvm.org/viewvc/llvm-project?rev=332422&view=rev Log: [analyzer] Do not crash on callback for call_once passed by value https://bugs.llvm.org/show_bug.cgi?id=37312 rdar://40270582 Differential Revision: http

r332545 - [ASTMatchers] Introduce a blockDecl matcher for matching block declarations

2018-05-16 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed May 16 15:47:03 2018 New Revision: 332545 URL: http://llvm.org/viewvc/llvm-project?rev=332545&view=rev Log: [ASTMatchers] Introduce a blockDecl matcher for matching block declarations Blocks can be matched just as well as functions or Objective-C methods. Diffe

r332546 - [analyzer] Extend ObjCAutoreleaseWriteChecker to catch block declarations with autoreleasing variables

2018-05-16 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed May 16 15:47:05 2018 New Revision: 332546 URL: http://llvm.org/viewvc/llvm-project?rev=332546&view=rev Log: [analyzer] Extend ObjCAutoreleaseWriteChecker to catch block declarations with autoreleasing variables Differential Revision: https://reviews.llvm.org/D4

r332544 - [analyzer] Change the warning message for GCD antipattern checker

2018-05-16 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed May 16 15:46:47 2018 New Revision: 332544 URL: http://llvm.org/viewvc/llvm-project?rev=332544&view=rev Log: [analyzer] Change the warning message for GCD antipattern checker Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp cfe/tr

r314571 - [Analyzer] Synthesize function body for std::call_once

2017-09-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Sep 29 17:03:22 2017 New Revision: 314571 URL: http://llvm.org/viewvc/llvm-project?rev=314571&view=rev Log: [Analyzer] Synthesize function body for std::call_once Differential Revision: https://reviews.llvm.org/D37840 Added: cfe/trunk/test/Analysis/call_onc

r314572 - [Analyzer] Add nullability to the list of tested checkers in SATestBuild

2017-09-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Sep 29 17:05:24 2017 New Revision: 314572 URL: http://llvm.org/viewvc/llvm-project?rev=314572&view=rev Log: [Analyzer] Add nullability to the list of tested checkers in SATestBuild Differential Revision: https://reviews.llvm.org/D38162 Modified: cfe/trunk/u

r314573 - [Analyzer] Document a gotcha: for C++ -analyze-function requires parameters in function name

2017-09-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Sep 29 17:07:22 2017 New Revision: 314573 URL: http://llvm.org/viewvc/llvm-project?rev=314573&view=rev Log: [Analyzer] Document a gotcha: for C++ -analyze-function requires parameters in function name Differential Revision: https://reviews.llvm.org/D37596 Modi

r314580 - [Analyzer] Add dummy implementation to call_once to avoid linkage warnings in tests.

2017-09-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Sep 29 18:15:35 2017 New Revision: 314580 URL: http://llvm.org/viewvc/llvm-project?rev=314580&view=rev Log: [Analyzer] Add dummy implementation to call_once to avoid linkage warnings in tests. Modified: cfe/trunk/test/Analysis/call_once.cpp Modified: cfe/t

r314692 - [Analyzer] Make testing scripts flake8 compliant

2017-10-02 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Oct 2 10:59:12 2017 New Revision: 314692 URL: http://llvm.org/viewvc/llvm-project?rev=314692&view=rev Log: [Analyzer] Make testing scripts flake8 compliant Differential Review: https://reviews.llvm.org/D38213 Modified: cfe/trunk/utils/analyzer/CmpRuns.py

Re: [PATCH] D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds

2017-10-02 Thread George Karpenkov via cfe-commits
> On Oct 2, 2017, at 12:57 PM, Michał Górny via Phabricator > wrote: > > mgorny added a comment. > > In https://reviews.llvm.org/D38444#886138, @george.karpenkov wrote: > >>> breaking stand-alone builds as a result >> >> That's a strong statement. Could you clarify? We have a lot of buildbo

r314722 - [Analyzer] Avoid copy and modifying passed reference in BodyFarm::create_call_once

2017-10-02 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Oct 2 14:01:46 2017 New Revision: 314722 URL: http://llvm.org/viewvc/llvm-project?rev=314722&view=rev Log: [Analyzer] Avoid copy and modifying passed reference in BodyFarm::create_call_once Differential Revision: https://reviews.llvm.org/D38475 Modified:

r314820 - [Analyzer] More granular special casing in RetainCountChecker

2017-10-03 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Oct 3 11:12:15 2017 New Revision: 314820 URL: http://llvm.org/viewvc/llvm-project?rev=314820&view=rev Log: [Analyzer] More granular special casing in RetainCountChecker Only assume that IOBSDNameMatching and friends increment a reference counter if their return

r314859 - [Analyzer] Re-apply r314820 with a fix for StringRef lifetime.

2017-10-03 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Oct 3 16:15:35 2017 New Revision: 314859 URL: http://llvm.org/viewvc/llvm-project?rev=314859&view=rev Log: [Analyzer] Re-apply r314820 with a fix for StringRef lifetime. Fixes the test failure: temporary is now bound to std::string, tests fully pass on Linux.

r314960 - [Analyzer Tests] Fix misc bugs in analyzer reference results updater.

2017-10-04 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Oct 4 18:02:20 2017 New Revision: 314960 URL: http://llvm.org/viewvc/llvm-project?rev=314960&view=rev Log: [Analyzer Tests] Fix misc bugs in analyzer reference results updater. Modified: cfe/trunk/utils/analyzer/SATestUpdateDiffs.py Modified: cfe/trunk/uti

r314992 - [Analyzer Tests] Run static analyzer integration tests until the end,

2017-10-05 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Oct 5 10:32:06 2017 New Revision: 314992 URL: http://llvm.org/viewvc/llvm-project?rev=314992&view=rev Log: [Analyzer Tests] Run static analyzer integration tests until the end, Do not stop at the first failure. Differential Revision: https://reviews.llvm.org/D

r315250 - [Analyzer] Do not segfault on unexpected call_once implementation

2017-10-09 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Oct 9 16:20:46 2017 New Revision: 315250 URL: http://llvm.org/viewvc/llvm-project?rev=315250&view=rev Log: [Analyzer] Do not segfault on unexpected call_once implementation Fixes https://bugs.llvm.org/show_bug.cgi?id=34869 Differential Revision: https://review

r315488 - [Analyzer] Assume that string-like const globals are non-nil.

2017-10-11 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Oct 11 11:39:40 2017 New Revision: 315488 URL: http://llvm.org/viewvc/llvm-project?rev=315488&view=rev Log: [Analyzer] Assume that string-like const globals are non-nil. Differential Revision: https://reviews.llvm.org/D38764 Added: cfe/trunk/lib/StaticAnaly

r315489 - [Analyzer] Remove dead code from testing scripts

2017-10-11 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Oct 11 11:42:39 2017 New Revision: 315489 URL: http://llvm.org/viewvc/llvm-project?rev=315489&view=rev Log: [Analyzer] Remove dead code from testing scripts Differential Revision: https://reviews.llvm.org/D38488 Modified: cfe/trunk/utils/analyzer/SATestBuil

r315492 - [Analyzer] Fix introduced regression: properly check for nullable attribute.

2017-10-11 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Oct 11 12:13:15 2017 New Revision: 315492 URL: http://llvm.org/viewvc/llvm-project?rev=315492&view=rev Log: [Analyzer] Fix introduced regression: properly check for nullable attribute. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/NonnullStringConstantsChe

r315508 - [Analyzer] Support bodyfarming libstdc++ implementation of std::call_once.

2017-10-11 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Oct 11 13:53:01 2017 New Revision: 315508 URL: http://llvm.org/viewvc/llvm-project?rev=315508&view=rev Log: [Analyzer] Support bodyfarming libstdc++ implementation of std::call_once. Differential Revision: https://reviews.llvm.org/D38810 Modified: cfe/trunk

r315655 - [Analyzer] Assume that CFBooleanRef const globals are non-null

2017-10-12 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Oct 12 17:51:41 2017 New Revision: 315655 URL: http://llvm.org/viewvc/llvm-project?rev=315655&view=rev Log: [Analyzer] Assume that CFBooleanRef const globals are non-null Differential Revision: https://reviews.llvm.org/D38867 Added: cfe/trunk/lib/StaticAnal

r315771 - Allow building libFuzzer in two-stage compiler-rt build

2017-10-13 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Oct 13 15:03:09 2017 New Revision: 315771 URL: http://llvm.org/viewvc/llvm-project?rev=315771&view=rev Log: Allow building libFuzzer in two-stage compiler-rt build When LLVM_BUILD_EXTERNAL_COMPILER_RT option is set to true, all of projects in compiler-rt are bui

r315776 - Allow building libFuzzer tests in two-stage compiler-rt build.

2017-10-13 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Oct 13 16:50:53 2017 New Revision: 315776 URL: http://llvm.org/viewvc/llvm-project?rev=315776&view=rev Log: Allow building libFuzzer tests in two-stage compiler-rt build. Modified: cfe/trunk/runtime/CMakeLists.txt Modified: cfe/trunk/runtime/CMakeLists.txt

r316041 - [Analyzer] Always use non-reference types when creating expressions in BodyFarm.

2017-10-17 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Oct 17 15:28:18 2017 New Revision: 316041 URL: http://llvm.org/viewvc/llvm-project?rev=316041&view=rev Log: [Analyzer] Always use non-reference types when creating expressions in BodyFarm. Remove an option to use a reference type (on by default!) since a non-ref

r316249 - [Analyzer] Correctly handle parameters passed by reference when bodyfarming std::call_once

2017-10-20 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Oct 20 16:29:59 2017 New Revision: 316249 URL: http://llvm.org/viewvc/llvm-project?rev=316249&view=rev Log: [Analyzer] Correctly handle parameters passed by reference when bodyfarming std::call_once Explicitly not supporting functor objects. Differential Revis

r316400 - [Analyzer] Do not use static storage to for implementations created in BodyFarm.cpp

2017-10-23 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Oct 23 16:59:52 2017 New Revision: 316400 URL: http://llvm.org/viewvc/llvm-project?rev=316400&view=rev Log: [Analyzer] Do not use static storage to for implementations created in BodyFarm.cpp Differential Revision: https://reviews.llvm.org/D39208 Added: cf

r316402 - [Analyzer] Handle implicit function reference in bodyfarming std::call_once

2017-10-23 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Oct 23 17:13:18 2017 New Revision: 316402 URL: http://llvm.org/viewvc/llvm-project?rev=316402&view=rev Log: [Analyzer] Handle implicit function reference in bodyfarming std::call_once Differential Revision: https://reviews.llvm.org/D39201 Modified: cfe/trun

r316403 - [Analyzer] Fix for the memory leak: fix typo in if-statement.

2017-10-23 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Oct 23 18:09:43 2017 New Revision: 316403 URL: http://llvm.org/viewvc/llvm-project?rev=316403&view=rev Log: [Analyzer] Fix for the memory leak: fix typo in if-statement. Modified: cfe/trunk/lib/Analysis/AnalysisDeclContext.cpp Modified: cfe/trunk/lib/Analys

r316522 - [Analyzer] Fix bug in testing scripts, which always marked result as failure.

2017-10-24 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Oct 24 15:24:13 2017 New Revision: 316522 URL: http://llvm.org/viewvc/llvm-project?rev=316522&view=rev Log: [Analyzer] Fix bug in testing scripts, which always marked result as failure. Modified: cfe/trunk/utils/analyzer/SATestBuild.py Modified: cfe/trunk/u

r316535 - [Analyzer] [Tests] Minor refactor of testing infrastructure:

2017-10-24 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Oct 24 16:52:48 2017 New Revision: 316535 URL: http://llvm.org/viewvc/llvm-project?rev=316535&view=rev Log: [Analyzer] [Tests] Minor refactor of testing infrastructure: Move utilities functions into a separate file to make comprehension easier. Added: cfe/t

r316534 - [Analyzer] [Tests] Remove temporary fields from generated reference results.

2017-10-24 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Oct 24 16:52:46 2017 New Revision: 316534 URL: http://llvm.org/viewvc/llvm-project?rev=316534&view=rev Log: [Analyzer] [Tests] Remove temporary fields from generated reference results. Pointer to HTML diagnostics is removed (as it is not stored) as well as the v

r316536 - [Analyzer] Store BodyFarm in std::unique_ptr

2017-10-24 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Oct 24 16:53:19 2017 New Revision: 316536 URL: http://llvm.org/viewvc/llvm-project?rev=316536&view=rev Log: [Analyzer] Store BodyFarm in std::unique_ptr Differential Revision: https://reviews.llvm.org/D39220 Modified: cfe/trunk/include/clang/Analysis/Analys

r316538 - [Analyzer] Remove unnecessary semicolon in analyzer tests.

2017-10-24 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Oct 24 17:03:45 2017 New Revision: 316538 URL: http://llvm.org/viewvc/llvm-project?rev=316538&view=rev Log: [Analyzer] Remove unnecessary semicolon in analyzer tests. Modified: cfe/trunk/test/Analysis/call_once.cpp Modified: cfe/trunk/test/Analysis/call_onc

r316539 - [Analyzer] Remove spaces inside comments mentioning the parameter name,

2017-10-24 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Oct 24 17:03:45 2017 New Revision: 316539 URL: http://llvm.org/viewvc/llvm-project?rev=316539&view=rev Log: [Analyzer] Remove spaces inside comments mentioning the parameter name, to aid clang-tidy comprehension. Requested by @alexfh in https://reviews.llvm.org/

r340960 - [analyzer] [NFC] Follow the convention when naming classes

2018-08-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 29 13:28:13 2018 New Revision: 340960 URL: http://llvm.org/viewvc/llvm-project?rev=340960&view=rev Log: [analyzer] [NFC] Follow the convention when naming classes Renames InvalidateRegionsWorker and RemoveDeadBindingsWorker Differential Revision: https://re

r340961 - [analyzer] Better retain count rules for OSObjects

2018-08-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 29 13:28:33 2018 New Revision: 340961 URL: http://llvm.org/viewvc/llvm-project?rev=340961&view=rev Log: [analyzer] Better retain count rules for OSObjects Differential Revision: https://reviews.llvm.org/D51184 Modified: cfe/trunk/lib/StaticAnalyzer/Che

r340962 - [analyzer] [NFC] Remove unused "state" argument from makeSymExprValNN

2018-08-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 29 13:28:54 2018 New Revision: 340962 URL: http://llvm.org/viewvc/llvm-project?rev=340962&view=rev Log: [analyzer] [NFC] Remove unused "state" argument from makeSymExprValNN Differential Revision: https://reviews.llvm.org/D51250 Modified: cfe/trunk/incl

r340964 - [analyzer] [NFC] Move class definition out of the function

2018-08-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 29 13:29:39 2018 New Revision: 340964 URL: http://llvm.org/viewvc/llvm-project?rev=340964&view=rev Log: [analyzer] [NFC] Move class definition out of the function Differential Revision: https://reviews.llvm.org/D51322 Modified: cfe/trunk/lib/StaticAnaly

r340963 - [analyzer] Move analyzer-eagerly-assume to AnalyzerOptions, enable by default

2018-08-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 29 13:29:17 2018 New Revision: 340963 URL: http://llvm.org/viewvc/llvm-project?rev=340963&view=rev Log: [analyzer] Move analyzer-eagerly-assume to AnalyzerOptions, enable by default Differential Revision: https://reviews.llvm.org/D51251 Modified: cfe/tr

r340965 - [analyzer] Resolve the crash in ReturnUndefChecker

2018-08-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 29 13:29:59 2018 New Revision: 340965 URL: http://llvm.org/viewvc/llvm-project?rev=340965&view=rev Log: [analyzer] Resolve the crash in ReturnUndefChecker By making sure the returned value from getKnownSVal is consistent with the value used inside expression

r340972 - [analyzer] Fix tests on 32-bit platforms by specifying the tuple explicitly

2018-08-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 29 14:18:47 2018 New Revision: 340972 URL: http://llvm.org/viewvc/llvm-project?rev=340972&view=rev Log: [analyzer] Fix tests on 32-bit platforms by specifying the tuple explicitly Modified: cfe/trunk/test/Analysis/casts.c Modified: cfe/trunk/test/Analys

r340986 - [analyzer] Improve tracing for uninitialized struct fields

2018-08-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 29 15:48:50 2018 New Revision: 340986 URL: http://llvm.org/viewvc/llvm-project?rev=340986&view=rev Log: [analyzer] Improve tracing for uninitialized struct fields rdar://13729267 Differential Revision: https://reviews.llvm.org/D51323 Added: cfe/trunk/t

r341600 - [analyzer] Dump a reproducible, deterministic ID of program state to exploded graph

2018-09-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Sep 6 16:07:26 2018 New Revision: 341600 URL: http://llvm.org/viewvc/llvm-project?rev=341600&view=rev Log: [analyzer] Dump a reproducible, deterministic ID of program state to exploded graph Differential Revision: https://reviews.llvm.org/D51395 Modified:

r341601 - [analyzer] Remove traces of ubigraph visualization

2018-09-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Sep 6 16:07:47 2018 New Revision: 341601 URL: http://llvm.org/viewvc/llvm-project?rev=341601&view=rev Log: [analyzer] Remove traces of ubigraph visualization Ubigraph project has been dead since about 2008, and to the best of my knowledge, no one was using it.

r341602 - [analyzer] Dump stable identifiers for exploded nodes

2018-09-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Sep 6 16:08:07 2018 New Revision: 341602 URL: http://llvm.org/viewvc/llvm-project?rev=341602&view=rev Log: [analyzer] Dump stable identifiers for exploded nodes Differential Revision: https://reviews.llvm.org/D51667 Modified: cfe/trunk/include/clang/Static

r341603 - [analyzer] [NFC] Move dumping program point into a separate function

2018-09-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Sep 6 16:08:27 2018 New Revision: 341603 URL: http://llvm.org/viewvc/llvm-project?rev=341603&view=rev Log: [analyzer] [NFC] Move dumping program point into a separate function Differential Revision: https://reviews.llvm.org/D51666 Modified: cfe/trunk/lib/S

r341617 - [analyzer] Push updating-the-executed-lines logic into the BugReporter.

2018-09-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Sep 6 17:42:53 2018 New Revision: 341617 URL: http://llvm.org/viewvc/llvm-project?rev=341617&view=rev Log: [analyzer] Push updating-the-executed-lines logic into the BugReporter. So it can be reused across different consumers. Differential Revision: https://re

r341616 - [analyzer] Skip printing trivial nodes in exploded graph

2018-09-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Sep 6 17:42:32 2018 New Revision: 341616 URL: http://llvm.org/viewvc/llvm-project?rev=341616&view=rev Log: [analyzer] Skip printing trivial nodes in exploded graph A node is considered to be trivial if it only has one successor, one predecessor, and a state equ

r341619 - [analyzer] Executed lines: store file IDs, not hashes.

2018-09-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Sep 6 17:43:37 2018 New Revision: 341619 URL: http://llvm.org/viewvc/llvm-project?rev=341619&view=rev Log: [analyzer] Executed lines: store file IDs, not hashes. Raw FileIDs are needed for the PlistDiagnostics to produce stable filenames. Differential Revision

cfe-commits@lists.llvm.org

2018-09-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Sep 6 17:43:55 2018 New Revision: 341620 URL: http://llvm.org/viewvc/llvm-project?rev=341620&view=rev Log: [analyzer] [NFC] Prefer passing around reference to std::unique_ptr& When object is owned elsewhere Differential Revision: https://reviews.llvm.org/D5166

r341618 - [analyzer] Do not add invalid source location to the coverage information

2018-09-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Sep 6 17:43:17 2018 New Revision: 341618 URL: http://llvm.org/viewvc/llvm-project?rev=341618&view=rev Log: [analyzer] Do not add invalid source location to the coverage information Invalid source locations may arise from generated code. Differential Revision:

r341722 - [analyzer] Remove the "postponed" hack, deal with derived symbols using an extra map

2018-09-07 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Sep 7 15:07:57 2018 New Revision: 341722 URL: http://llvm.org/viewvc/llvm-project?rev=341722&view=rev Log: [analyzer] Remove the "postponed" hack, deal with derived symbols using an extra map The "derived" symbols indicate children fields of a larger symbol. A

r341723 - [analyzer] [NFC] Use StringRef when returning a large string literal in HTMLDiagnostics

2018-09-07 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Sep 7 15:13:15 2018 New Revision: 341723 URL: http://llvm.org/viewvc/llvm-project?rev=341723&view=rev Log: [analyzer] [NFC] Use StringRef when returning a large string literal in HTMLDiagnostics (NB: could be a clang-tidy / analyzer check) Differential Revisi

r341724 - [analyzer] [NFC] Move methods for dumping the coverage in HTMLDiagnostics into the class

2018-09-07 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Sep 7 15:13:35 2018 New Revision: 341724 URL: http://llvm.org/viewvc/llvm-project?rev=341724&view=rev Log: [analyzer] [NFC] Move methods for dumping the coverage in HTMLDiagnostics into the class Differential Revision: https://reviews.llvm.org/D51513 Modified

r341978 - [analyzer] [NFC] Change the tests by making the version check more resilient

2018-09-11 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Sep 11 11:45:15 2018 New Revision: 341978 URL: http://llvm.org/viewvc/llvm-project?rev=341978&view=rev Log: [analyzer] [NFC] Change the tests by making the version check more resilient Modified: cfe/trunk/test/Analysis/MismatchedDeallocator-path-notes.cpp

r337635 - [Driver] Sanitizer support based on runtime library presence

2018-07-20 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Jul 20 16:34:39 2018 New Revision: 337635 URL: http://llvm.org/viewvc/llvm-project?rev=337635&view=rev Log: [Driver] Sanitizer support based on runtime library presence The runtime libraries of sanitizers are built in compiler-rt, and Clang can be built without

r337760 - [ASTMatchers] [NFC] Regenerate HTML docs.

2018-07-23 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Jul 23 15:29:10 2018 New Revision: 337760 URL: http://llvm.org/viewvc/llvm-project?rev=337760&view=rev Log: [ASTMatchers] [NFC] Regenerate HTML docs. Modified: cfe/trunk/docs/LibASTMatchersReference.html Modified: cfe/trunk/docs/LibASTMatchersReference.html

r337761 - [ASTMatchers] Add an isMain() matcher

2018-07-23 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Jul 23 15:29:35 2018 New Revision: 337761 URL: http://llvm.org/viewvc/llvm-project?rev=337761&view=rev Log: [ASTMatchers] Add an isMain() matcher Differential Revision: https://reviews.llvm.org/D49615 Modified: cfe/trunk/docs/LibASTMatchersReference.html

r337864 - [analyzer] Extend NoStoreFuncVisitor to insert a note on IVars

2018-07-24 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jul 24 16:14:29 2018 New Revision: 337864 URL: http://llvm.org/viewvc/llvm-project?rev=337864&view=rev Log: [analyzer] Extend NoStoreFuncVisitor to insert a note on IVars The note is added in the following situation: - We are throwing a nullability-related war

r337866 - Revert "[analyzer] Extend NoStoreFuncVisitor to insert a note on IVars"

2018-07-24 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jul 24 16:23:33 2018 New Revision: 337866 URL: http://llvm.org/viewvc/llvm-project?rev=337866&view=rev Log: Revert "[analyzer] Extend NoStoreFuncVisitor to insert a note on IVars" This reverts commit a9e21bd727112cd69eabc1af648c5da6b773d06e. Reverted because the

r337876 - [analyzer] Syntactic matcher for leaks associated with run loop and autoreleasepool

2018-07-24 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jul 24 18:27:15 2018 New Revision: 337876 URL: http://llvm.org/viewvc/llvm-project?rev=337876&view=rev Log: [analyzer] Syntactic matcher for leaks associated with run loop and autoreleasepool A checker for detecting leaks resulting from allocating temporary aut

r338137 - [ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting it's declaration.

2018-07-27 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Jul 27 10:26:11 2018 New Revision: 338137 URL: http://llvm.org/viewvc/llvm-project?rev=338137&view=rev Log: [ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting it's declaration. ObjCIvarExpr is *not* a subclass of MemberExpr, and a separate ma

r338140 - [ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting it's declaration

2018-07-27 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Jul 27 10:40:59 2018 New Revision: 338140 URL: http://llvm.org/viewvc/llvm-project?rev=338140&view=rev Log: [ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting it's declaration ObjCIvarExpr is *not* a subclass of MemberExpr, and a separate mat

r338149 - [analyzer] Extend NoStoreFuncVisitor to insert a note on IVars

2018-07-27 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Jul 27 11:26:40 2018 New Revision: 338149 URL: http://llvm.org/viewvc/llvm-project?rev=338149&view=rev Log: [analyzer] Extend NoStoreFuncVisitor to insert a note on IVars The note is added in the following situation: - We are throwing a nullability-related war

r338187 - [AST] Add a convenient getter from QualType to RecordDecl

2018-07-27 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Jul 27 19:16:13 2018 New Revision: 338187 URL: http://llvm.org/viewvc/llvm-project?rev=338187&view=rev Log: [AST] Add a convenient getter from QualType to RecordDecl Differential Revision: https://reviews.llvm.org/D49951 Modified: cfe/trunk/include/clang/AS

r338286 - [analyzer] Store ValueDecl in DeclRegion

2018-07-30 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Jul 30 11:57:13 2018 New Revision: 338286 URL: http://llvm.org/viewvc/llvm-project?rev=338286&view=rev Log: [analyzer] Store ValueDecl in DeclRegion All use cases of DeclRegion actually have ValueDecl there, and getting the name from declaration comes in very ha

r338312 - [analyzer] Fix crash in RunLoopAutoreleaseChecker on empty children

2018-07-30 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Jul 30 14:44:15 2018 New Revision: 338312 URL: http://llvm.org/viewvc/llvm-project?rev=338312&view=rev Log: [analyzer] Fix crash in RunLoopAutoreleaseChecker on empty children Differential Revision: https://reviews.llvm.org/D50012 Modified: cfe/trunk/lib/St

  1   2   3   4   5   >