fmayer wrote:
LGTM. Could you explain in the description why we are doing this?
https://github.com/llvm/llvm-project/pull/76130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/76130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer approved this pull request.
Lgtm thanks
https://github.com/llvm/llvm-project/pull/76132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -221,29 +221,55 @@ static void PrintStackAllocations(const
StackAllocationsRingBuffer *sa,
for (LocalInfo &local : frame.locals) {
if (!local.has_frame_offset || !local.has_size ||
!local.has_tag_offset)
continue;
+if (!(local.name && intern
@@ -221,29 +221,55 @@ static void PrintStackAllocations(const
StackAllocationsRingBuffer *sa,
for (LocalInfo &local : frame.locals) {
if (!local.has_frame_offset || !local.has_size ||
!local.has_tag_offset)
continue;
+if (!(local.name && intern
https://github.com/fmayer commented:
Remove this comment?
Line 780
```
// TODO(fmayer): figure out how to distinguish use-after-return and
// stack-buffer-overflow.
```
https://github.com/llvm/llvm-project/pull/76133
___
cfe-commits mailing l
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/76133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer approved this pull request.
LGTM, but maybe be more explicit in the commit message how we work around this.
https://github.com/llvm/llvm-project/pull/76547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
Author: Florian Mayer
Date: 2022-08-04T19:55:40-07:00
New Revision: fc6a6ee507ec2df0df7d34ba19feccb776297e4c
URL:
https://github.com/llvm/llvm-project/commit/fc6a6ee507ec2df0df7d34ba19feccb776297e4c
DIFF:
https://github.com/llvm/llvm-project/commit/fc6a6ee507ec2df0df7d34ba19feccb776297e4c.diff
Author: Florian Mayer
Date: 2021-07-19T11:54:44+01:00
New Revision: 12268fe14a1a65d4b62f0b6e5beab46ba8501ae7
URL:
https://github.com/llvm/llvm-project/commit/12268fe14a1a65d4b62f0b6e5beab46ba8501ae7
DIFF:
https://github.com/llvm/llvm-project/commit/12268fe14a1a65d4b62f0b6e5beab46ba8501ae7.diff
Author: Florian Mayer
Date: 2021-07-19T12:08:32+01:00
New Revision: 807d50100c3c6cd5e6ec89d6ac1afddd0c3f7133
URL:
https://github.com/llvm/llvm-project/commit/807d50100c3c6cd5e6ec89d6ac1afddd0c3f7133
DIFF:
https://github.com/llvm/llvm-project/commit/807d50100c3c6cd5e6ec89d6ac1afddd0c3f7133.diff
Author: Florian Mayer
Date: 2021-07-20T10:06:35+01:00
New Revision: e9c63ed10b3bdf6eb3fa76d1a3eb403d6fc6a118
URL:
https://github.com/llvm/llvm-project/commit/e9c63ed10b3bdf6eb3fa76d1a3eb403d6fc6a118
DIFF:
https://github.com/llvm/llvm-project/commit/e9c63ed10b3bdf6eb3fa76d1a3eb403d6fc6a118.diff
Author: Florian Mayer
Date: 2021-07-20T10:36:46+01:00
New Revision: 5f08219322456b867605e4a19003f58ee418758f
URL:
https://github.com/llvm/llvm-project/commit/5f08219322456b867605e4a19003f58ee418758f
DIFF:
https://github.com/llvm/llvm-project/commit/5f08219322456b867605e4a19003f58ee418758f.diff
Author: Florian Mayer
Date: 2021-07-22T12:04:54+01:00
New Revision: bde9415fef25e9ff6e10595a2f4f5004dd62f10a
URL:
https://github.com/llvm/llvm-project/commit/bde9415fef25e9ff6e10595a2f4f5004dd62f10a
DIFF:
https://github.com/llvm/llvm-project/commit/bde9415fef25e9ff6e10595a2f4f5004dd62f10a.diff
Author: Florian Mayer
Date: 2021-07-22T12:16:16+01:00
New Revision: 789a4a2e5c30b3eee632446d5b99bba808587836
URL:
https://github.com/llvm/llvm-project/commit/789a4a2e5c30b3eee632446d5b99bba808587836
DIFF:
https://github.com/llvm/llvm-project/commit/789a4a2e5c30b3eee632446d5b99bba808587836.diff
Author: Florian Mayer
Date: 2021-07-27T20:50:46+01:00
New Revision: 835ef6f93d5789d3d7d905462e7574a38b30577d
URL:
https://github.com/llvm/llvm-project/commit/835ef6f93d5789d3d7d905462e7574a38b30577d
DIFF:
https://github.com/llvm/llvm-project/commit/835ef6f93d5789d3d7d905462e7574a38b30577d.diff
fmayer wrote:
I don't have a strong opinion, but fundamentally I would prefer if the source
control system stored exactly the files I have in my checkout, not mess with
them in any way. I understand there are practical concerns, but a linter for
unexpected CRLF would maybe be an option?
https
fmayer wrote:
> That wish is fine until you start working with others.
Do we actually have that little faith in developers that we think they will
check in a 50k line diff?
https://github.com/llvm/llvm-project/pull/86318
___
cfe-commits mailing list
fmayer wrote:
> . The point of this patch is not to lambast developers or interfere with
> their local setups; it's to get the line-ending issues out of the way for
> good so they can focus on what they do best.
Fair enough. I don't think it will fully make them go away for good, as you
menti
fmayer wrote:
LGTM, verified the two strings are the same
```
>>> r"^(.*) \(in (.*)\) \((.*:\d*)\)$" == "^(.*) \(in (.*)\) \((.*:\d*)\)$"
True
>>> "^( *#([0-9]+) *)(0x[0-9a-f]+) *(?:in *.+)? *\((.*)\+(0x[0-9a-f]+)\)" ==
>>> r"^( *#([0-9]+) *)(0x[0-9a-f]+) *(?:
fmayer wrote:
This triggers the leak detector in our HWASan build bot
```
Note: This is test shard 1 of 23.
[==] Running 1 test from 1 test suite.
[--] Global test environment set-up.
[--] 1 test from IncrementalCompilerBuilder
[ RUN ] IncrementalCompilerBuilder.SetC
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/79924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer closed https://github.com/llvm/llvm-project/pull/79081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/78492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fmayer wrote:
This broke Sanitizer bots:
```
[5/25] Building CXX object
tools/clang/lib/Driver/CMakeFiles/obj.clangDriver.dir/ToolChains/Hurd.cpp.o
FAILED:
tools/clang/lib/Driver/CMakeFiles/obj.clangDriver.dir/ToolChains/Hurd.cpp.o
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache
/b/sanit
fmayer wrote:
Drive-by: is the `llvm_unreachable` actually unreachable? I.e. we never call
this function with this case? Otherwise we are introducing UB in `NDEBUG` builds
```
/// In NDEBUG builds, if the platform does not support a builtin unreachable
/// then we call an internal LLVM runtime
https://github.com/fmayer approved this pull request.
Is there a reason you put this first? Otherwise IMO it is slightly neater to
put it last.
https://github.com/llvm/llvm-project/pull/78520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/79081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Florian Mayer
Date: 2021-08-10T14:25:52+01:00
New Revision: 45abbaf2e5fbdf27c9f8ba01b34018b0be45b7c9
URL:
https://github.com/llvm/llvm-project/commit/45abbaf2e5fbdf27c9f8ba01b34018b0be45b7c9
DIFF:
https://github.com/llvm/llvm-project/commit/45abbaf2e5fbdf27c9f8ba01b34018b0be45b7c9.diff
Author: Florian Mayer
Date: 2022-09-21T14:13:32-07:00
New Revision: a3153381af48b2e704750255a704748a13c4c4de
URL:
https://github.com/llvm/llvm-project/commit/a3153381af48b2e704750255a704748a13c4c4de
DIFF:
https://github.com/llvm/llvm-project/commit/a3153381af48b2e704750255a704748a13c4c4de.diff
Author: Florian Mayer
Date: 2022-09-30T12:04:19-07:00
New Revision: f5c9931fefcab8de07a6c08c39b582fa58859dc9
URL:
https://github.com/llvm/llvm-project/commit/f5c9931fefcab8de07a6c08c39b582fa58859dc9
DIFF:
https://github.com/llvm/llvm-project/commit/f5c9931fefcab8de07a6c08c39b582fa58859dc9.diff
Author: Florian Mayer
Date: 2022-06-01T19:48:19-07:00
New Revision: 13b8bfc51451fcfc00f3e3480abaf64b337a43d4
URL:
https://github.com/llvm/llvm-project/commit/13b8bfc51451fcfc00f3e3480abaf64b337a43d4
DIFF:
https://github.com/llvm/llvm-project/commit/13b8bfc51451fcfc00f3e3480abaf64b337a43d4.diff
Author: Florian Mayer
Date: 2022-06-03T16:32:42-07:00
New Revision: 53c1584063e8f3225bfe71724cc7de79576ea61a
URL:
https://github.com/llvm/llvm-project/commit/53c1584063e8f3225bfe71724cc7de79576ea61a
DIFF:
https://github.com/llvm/llvm-project/commit/53c1584063e8f3225bfe71724cc7de79576ea61a.diff
Author: Florian Mayer
Date: 2023-08-04T14:24:26-07:00
New Revision: 043d03d25bd7eadef66685de298342b35fe6b466
URL:
https://github.com/llvm/llvm-project/commit/043d03d25bd7eadef66685de298342b35fe6b466
DIFF:
https://github.com/llvm/llvm-project/commit/043d03d25bd7eadef66685de298342b35fe6b466.diff
Author: Florian Mayer
Date: 2023-05-26T14:25:46-07:00
New Revision: a2684acfb61d40f441e240035d7f1ba50da637c8
URL:
https://github.com/llvm/llvm-project/commit/a2684acfb61d40f441e240035d7f1ba50da637c8
DIFF:
https://github.com/llvm/llvm-project/commit/a2684acfb61d40f441e240035d7f1ba50da637c8.diff
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/107280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fmayer wrote:
super-nit: add `[sanitizers]` and remove `.` from commit message?
https://github.com/llvm/llvm-project/pull/107280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fmayer wrote:
LGTM, but would like @vitalybuka to also take a quick look.
https://github.com/llvm/llvm-project/pull/104741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fmayer wrote:
> ⚠️ We detected that you are using a GitHub private e-mail address to
> contribute to the repo. Please turn off [Keep my email addresses
> private](https://github.com/settings/emails) setting in your account. See
> [LLVM
> Discourse](https://discourse.llvm.org/t/hidden-emails-o
@@ -313,6 +313,14 @@ Limitations
usually expected.
* Static linking of executables is not supported.
+Security Considerations
+===
+
+AddressSanitizer is a bug detection tool and is not meant to be linked
fmayer wrote:
nit: maybe "its ru
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/95299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fmayer wrote:
This broke our buildbot:
https://lab.llvm.org/buildbot/#/builders/37/builds/35987
```
FAILED:
tools/clang/lib/Driver/CMakeFiles/obj.clangDriver.dir/ToolChains/Darwin.cpp.o
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache
/b/sanitizer-x86_64-linux/build/llvm_build0/bin/clang++
https://github.com/fmayer created
https://github.com/llvm/llvm-project/pull/95325
Reverts llvm/llvm-project#95164
This broke a buildbot: https://lab.llvm.org/buildbot/#/builders/37/builds/35987
>From fc671bbb1ceb94f8aac63bc0e4963e5894bc660e Mon Sep 17 00:00:00 2001
From: Florian Mayer
Date: W
https://github.com/fmayer closed https://github.com/llvm/llvm-project/pull/95325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fmayer wrote:
Breakage looks related: https://lab.llvm.org/buildbot/#/builders/72/builds/265
```
FAIL: UBSan-MemorySanitizer-powerpc64le :: TestCases/Integer/bit-int.c (4716 of
4745)
TEST 'UBSan-MemorySanitizer-powerpc64le ::
TestCases/Integer/bit-int.c' FAILED ***
fmayer wrote:
This broke the sanitizer bots, e.g.
https://lab.llvm.org/buildbot/#/builders/239/builds/6587/steps/10/logs/stdio
```
[==] Running 2 tests from 1 test suite.
[--] Global test environment set-up.
[--] 2 tests from ExprMutationAnalyzerTest
[ RUN ] ExprMut
https://github.com/fmayer created
https://github.com/llvm/llvm-project/pull/88765
Reverts llvm/llvm-project#87954
Broke sanitizer bots, e.g.
https://lab.llvm.org/buildbot/#/builders/239/builds/6587/steps/10/logs/stdio
>From 82b9a06f73df5301ffd950775055304124f63e02 Mon Sep 17 00:00:00 2001
Fro
https://github.com/fmayer closed https://github.com/llvm/llvm-project/pull/88765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer closed
https://github.com/llvm/llvm-project/pull/106624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer closed
https://github.com/llvm/llvm-project/pull/106758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/100937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Florian Mayer
Date: 2022-03-01T14:47:33-08:00
New Revision: 1d730d80ce592fde66b1ba6153f08f72778f94ce
URL:
https://github.com/llvm/llvm-project/commit/1d730d80ce592fde66b1ba6153f08f72778f94ce
DIFF:
https://github.com/llvm/llvm-project/commit/1d730d80ce592fde66b1ba6153f08f72778f94ce.diff
@@ -1,8 +1,9 @@
-// RUN: %clang_hwasan -Wl,--build-id -g %s -o %t
-// RUN: echo '[{"prefix": "'"$(realpath $(dirname %s))"'/", "link":
"http://test.invalid/{file}:{line}"}]' > %t.linkify
-// RUN: %env_hwasan_opts=symbolize=0 not %run %t 2>&1 | hwasan_symbolize
--html --symbols $
https://github.com/fmayer approved this pull request.
LGTM for the hwasan test.
https://github.com/llvm/llvm-project/pull/105754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fmayer wrote:
This caused a UBSan violation:
```
[--] 1 test from ConfigCompileTests
[ RUN ] ConfigCompileTests.DiagnosticSuppression
Config fragment: compiling :0 -> 0x7B8366E2F7D8 (trusted=false)
/usr/local/google/home/fmayer/large/llvm-project/llvm/include/llvm/ADT/IntrusiveR
https://github.com/fmayer created
https://github.com/llvm/llvm-project/pull/108646
This reverts commit 90a2e0bb423629b7e70f4b91adb44851199dd5ea.
Reverting parent CL
>From 6bc1ea84e078d01546286e6443d761e2a685902d Mon Sep 17 00:00:00 2001
From: Florian Mayer
Date: Fri, 13 Sep 2024 14:02:14 -07
Author: Florian Mayer
Date: 2024-09-13T15:01:27-07:00
New Revision: f885e02cf7cac1b08cab4cd526773420076029dd
URL:
https://github.com/llvm/llvm-project/commit/f885e02cf7cac1b08cab4cd526773420076029dd
DIFF:
https://github.com/llvm/llvm-project/commit/f885e02cf7cac1b08cab4cd526773420076029dd.diff
Author: Florian Mayer
Date: 2024-09-13T15:01:33-07:00
New Revision: e1bd9740faa62c11cc785a7b70ec1ad17e286bd1
URL:
https://github.com/llvm/llvm-project/commit/e1bd9740faa62c11cc785a7b70ec1ad17e286bd1
DIFF:
https://github.com/llvm/llvm-project/commit/e1bd9740faa62c11cc785a7b70ec1ad17e286bd1.diff
Author: Florian Mayer
Date: 2024-09-13T15:01:33-07:00
New Revision: e1bd9740faa62c11cc785a7b70ec1ad17e286bd1
URL:
https://github.com/llvm/llvm-project/commit/e1bd9740faa62c11cc785a7b70ec1ad17e286bd1
DIFF:
https://github.com/llvm/llvm-project/commit/e1bd9740faa62c11cc785a7b70ec1ad17e286bd1.diff
https://github.com/fmayer closed
https://github.com/llvm/llvm-project/pull/108646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer closed
https://github.com/llvm/llvm-project/pull/112050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer ready_for_review
https://github.com/llvm/llvm-project/pull/111918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -764,11 +764,17 @@ void AsmPrinter::emitGlobalVariable(const GlobalVariable
*GV) {
const DataLayout &DL = GV->getDataLayout();
uint64_t Size = DL.getTypeAllocSize(GV->getValueType());
+ if (GV->isTagged())
+Size = alignTo(Size, 16);
// If the alignment is spe
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/100937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer closed
https://github.com/llvm/llvm-project/pull/100937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer created
https://github.com/llvm/llvm-project/pull/111918
This greatly simplifies the code, and makes sure no optimizations are
applied that assume the bigger alignment or size, which could be
incorrect if we link together with non-instrumented code.
>From 3a962270521a
https://github.com/fmayer updated
https://github.com/llvm/llvm-project/pull/111918
>From 3a962270521aa7b48b64e5ac5fa0edb900990023 Mon Sep 17 00:00:00 2001
From: Florian Mayer
Date: Thu, 10 Oct 2024 16:05:50 -0700
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
https://github.com/fmayer edited
https://github.com/llvm/llvm-project/pull/111918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer edited
https://github.com/llvm/llvm-project/pull/111918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer updated
https://github.com/llvm/llvm-project/pull/111918
>From 3a962270521aa7b48b64e5ac5fa0edb900990023 Mon Sep 17 00:00:00 2001
From: Florian Mayer
Date: Thu, 10 Oct 2024 16:05:50 -0700
Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
https://github.com/fmayer updated
https://github.com/llvm/llvm-project/pull/112050
>From 78e91cb54bed6ee8deda61a054776bbd3102d79d Mon Sep 17 00:00:00 2001
From: Florian Mayer
Date: Fri, 11 Oct 2024 14:28:59 -0700
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
https://github.com/fmayer created
https://github.com/llvm/llvm-project/pull/112050
It doesn't make a difference currently, but MTE globals are only
supported on Android, so that's the more natural target to use.
>From 78e91cb54bed6ee8deda61a054776bbd3102d79d Mon Sep 17 00:00:00 2001
From: Flor
https://github.com/fmayer updated
https://github.com/llvm/llvm-project/pull/111918
>From 3a962270521aa7b48b64e5ac5fa0edb900990023 Mon Sep 17 00:00:00 2001
From: Florian Mayer
Date: Thu, 10 Oct 2024 16:05:50 -0700
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
@@ -764,11 +764,18 @@ void AsmPrinter::emitGlobalVariable(const GlobalVariable
*GV) {
const DataLayout &DL = GV->getDataLayout();
uint64_t Size = DL.getTypeAllocSize(GV->getValueType());
+ if (GV->isTagged())
+Size = alignTo(Size, 16);
// If the alignment is spe
@@ -764,11 +764,18 @@ void AsmPrinter::emitGlobalVariable(const GlobalVariable
*GV) {
const DataLayout &DL = GV->getDataLayout();
uint64_t Size = DL.getTypeAllocSize(GV->getValueType());
+ if (GV->isTagged())
+Size = alignTo(Size, 16);
fmayer wrote:
@@ -194,12 +198,43 @@ Some issues with flags can be debugged using the
``verbosity=$NUM`` flag:
misspelled_flag
...
-Disabling
--
+Disabling and suppressing
+-
-In some circumstances, you may want to suppress error reporting in a specif
@@ -194,12 +198,43 @@ Some issues with flags can be debugged using the
``verbosity=$NUM`` flag:
misspelled_flag
...
-Disabling
--
+Disabling and suppressing
+-
-In some circumstances, you may want to suppress error reporting in a specif
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/100937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fmayer wrote:
> With the function effects warnings (as errors) activated, blocking functions
> cannot be called from non-blocking functions, and this is enforced at compile
> time. The purpose of this series of PRs is to introduce similar functionality
> into RealtimeSanitizer, so that it can
fmayer wrote:
> > > With the function effects warnings (as errors) activated, blocking
> > > functions cannot be called from non-blocking functions, and this is
> > > enforced at compile time. The purpose of this series of PRs is to
> > > introduce similar functionality into RealtimeSanitizer,
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/111055
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fmayer wrote:
> I would suggest a brief comment explaining the choice not to filter.
I'm not sure I understand. There wasn't a choice to filter before, there was
just the (incorrect) assumption that we don't have nested
`RecordStorageLocation`, leading to a crash.
https://github.com/llvm/llvm
https://github.com/fmayer updated
https://github.com/llvm/llvm-project/pull/112050
>From 78e91cb54bed6ee8deda61a054776bbd3102d79d Mon Sep 17 00:00:00 2001
From: Florian Mayer
Date: Fri, 11 Oct 2024 14:28:59 -0700
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
@@ -11,11 +11,16 @@ RealtimeSanitizer (a.k.a. RTSan) is a real-time safety
testing tool for C and C+
projects. RTSan can be used to detect real-time violations, i.e. calls to
methods
that are not safe for use in functions with deterministic run time
requirements.
RTSan consi
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/113979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/113931
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fmayer wrote:
> I think this is the right change.
>
> What I don't understand, though, is why you were getting an assert failure
> before. (Which line is the assertion on that failed?) I would have thought if
> you don't dump the nested record, you just get less information. Apparently
> not
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/112727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer closed
https://github.com/llvm/llvm-project/pull/112457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer edited
https://github.com/llvm/llvm-project/pull/111918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer updated
https://github.com/llvm/llvm-project/pull/111918
>From 3a962270521aa7b48b64e5ac5fa0edb900990023 Mon Sep 17 00:00:00 2001
From: Florian Mayer
Date: Thu, 10 Oct 2024 16:05:50 -0700
Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
https://github.com/fmayer updated
https://github.com/llvm/llvm-project/pull/111918
>From 3a962270521aa7b48b64e5ac5fa0edb900990023 Mon Sep 17 00:00:00 2001
From: Florian Mayer
Date: Thu, 10 Oct 2024 16:05:50 -0700
Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
@@ -84,6 +84,14 @@ void test_macro_expansion4() {
#undef MY_NULL
}
+template struct pear {
+ T x;
+};
+void test_templated() {
+ pear p = { NULL };
fmayer wrote:
Doesn't this need some `CHECK` or `CHECK-NOT`?
https://github.com/llvm/llvm-project/pull/1091
@@ -489,13 +485,7 @@ static DiagnosticIDs::Level toLevel(diag::Severity SV) {
DiagnosticIDs::Level
DiagnosticIDs::getDiagnosticLevel(unsigned DiagID, SourceLocation Loc,
const DiagnosticsEngine &Diag) const {
- // Handle custom diagnostics, wh
@@ -84,6 +84,75 @@ non-zero exit code.
#14 0x0001958960dc ()
#15 0x2f557ffc ()
+Run-time flags
+--
+
+RealtimeSanitizer supports a number of run-time flags, which can be specified
in the ``RTSAN_OPTIONS`` environment variable:
+
+.. code-block::
@@ -84,6 +84,75 @@ non-zero exit code.
#14 0x0001958960dc ()
#15 0x2f557ffc ()
+Run-time flags
+--
+
+RealtimeSanitizer supports a number of run-time flags, which can be specified
in the ``RTSAN_OPTIONS`` environment variable:
+
+.. code-block::
@@ -84,6 +84,75 @@ non-zero exit code.
#14 0x0001958960dc ()
#15 0x2f557ffc ()
+Run-time flags
+--
+
+RealtimeSanitizer supports a number of run-time flags, which can be specified
in the ``RTSAN_OPTIONS`` environment variable:
+
+.. code-block::
@@ -84,6 +84,75 @@ non-zero exit code.
#14 0x0001958960dc ()
#15 0x2f557ffc ()
+Run-time flags
+--
+
+RealtimeSanitizer supports a number of run-time flags, which can be specified
in the ``RTSAN_OPTIONS`` environment variable:
+
+.. code-block::
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/110296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 260 matches
Mail list logo
