[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Herald added a subscriber: jplehr. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D143704: [flang] Feature list plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rGbde91fd03f72: [flang] Feature list plugin (authored by elmcdonough). Changed prior to commit: https://reviews.llvm.org/D143704?vs=502691&id=505991#toc Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Haven't been able to check this yet, but I think it might be due to the tests expecting a deterministic output. I've only ever tested on Ubuntu WSL, so its possible the order is different on different platforms. I think replacing CHECK-NEXT with CHECK-DAG might fi

[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Sorry about that. I was trying to look for a fix, and I think it has something to do with these recent changes . I'll have a new revision soon. Repository: rG LLVM Github Mon

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 507231. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt flang/examples/FeatureList/FeatureList.cpp flang/test/CMakeL

[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Could you post a link to the failed build please @Renaud-K? I'd like to see if I can diagnose what's going wrong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 ___ cf

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 507486. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt flang/examples/FeatureL

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 507572. Herald added a subscriber: mgrang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMake

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 509395. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt flang/examples/FeatureL

[PATCH] D143704: [Flang] Part one of Feature List action

elmcdonough updated this revision to Diff 501720. elmcdonough edited the summary of this revision. elmcdonough removed reviewers: klausler, clementval. elmcdonough added a comment. Herald added a subscriber: sstefan1. Tests + total coverage of elements inside dump-parse-tree.h Repository: rG L

[PATCH] D143704: [Flang] Part one of Feature List action

elmcdonough updated this revision to Diff 501919. elmcdonough added a comment. Clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureL

[PATCH] D143704: [flang] Part one of Feature List action

elmcdonough updated this revision to Diff 502691. elmcdonough retitled this revision from "[Flang] Part one of Feature List action" to "[flang] Part one of Feature List action". elmcdonough added a comment. Allow for plugin to parse semantically incorrect files. Repository: rG LLVM Github Mon

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 510553. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt flang/examples/FeatureL

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 511537. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt flang/examples/FeatureL

[PATCH] D143301: Emit warning for unsupported gfortran flags

elmcdonough updated this revision to Diff 496730. elmcdonough retitled this revision from "Emit warning for `-Wextra` instead of error" to "Emit warning for unsupported gfortran flags". elmcdonough added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. This update

[PATCH] D143301: Emit warning for unsupported gfortran flags

elmcdonough added a comment. Thanks for the feedback everyone. This is my current understanding on what I should do: I am to rename gfortran_unsupported_Group to flang_ignored_w_Group and move the non W group gfortran options into another patch. I have these changes locally and am currently b

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 497405. elmcdonough retitled this revision from "Emit warning for unsupported gfortran flags" to "[flang] Handle unsupported warning flags". elmcdonough edited the summary of this revision. Herald added a subscriber: sunshaoce. Repository: rG LLVM Githu

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 498164. elmcdonough added a comment. Change multiclass name for the sake of clarity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D143301 Files: clang/include/clang/

[PATCH] D143704: [Flang] Part one of Feature List action

elmcdonough added a comment. Thank you all for your feedback. We're putting the second part off for now and I'm going to retool this as a plugin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 498511. elmcdonough marked an inline comment as done. Herald added a subscriber: MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D143301 Files: clang/include/cla

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough added a comment. In D143301#4135301 , @awarzynski wrote: > @elmcdonough , let me rephrase this (should've been clearer before, sorry): > >> One thing that's not clear to me - how come "-Wextra" is not treated as an >> error and "-Wblah" is?

[PATCH] D143704: [Flang] Part one of Feature List action

elmcdonough updated this revision to Diff 498561. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt flang/examples/FeatureL

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 498944. elmcdonough added a comment. Clang format + documentation update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D143301 Files: clang/include/clang/Basic/Diagno

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 499259. elmcdonough marked 3 inline comments as done. elmcdonough added a comment. Comment edit + exhuastive testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D14330

[PATCH] D143301: [flang] Handle unsupported warning flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce3a1c59e180: [flang] Handle unsupported warning flags (authored by elmcdonough). Changed prior to commit: https://reviews.llvm.org/D143301?vs=499

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough added a comment. In D143301#4143241 , @PeteSteinfeld wrote: > In D143301#4143108 , @vzakhari > wrote: > >> The new tests fail to link: > > That is, these new tests cause check-flang to fail. @elmcdo

[PATCH] D143704: [flang] Feature list plugin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00d0749f92ec: [flang] Feature list plugin (authored by elmcdonough). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi