r342672 - [Sema] Retain __restrict qualifiers when substituting a reference type.

Author: epilk Date: Thu Sep 20 11:12:24 2018 New Revision: 342672 URL: http://llvm.org/viewvc/llvm-project?rev=342672&view=rev Log: [Sema] Retain __restrict qualifiers when substituting a reference type. Fixes rdar://43760099 Differential revision: https://reviews.llvm.org/D52271 Added: cfe

r342679 - Fix an assert in -Wquoted-include-in-framework-header

Author: epilk Date: Thu Sep 20 12:00:03 2018 New Revision: 342679 URL: http://llvm.org/viewvc/llvm-project?rev=342679&view=rev Log: Fix an assert in -Wquoted-include-in-framework-header Fixes rdar://43692300 Differential revision: https://reviews.llvm.org/D52253 Added: cfe/trunk/test/Module

r343042 - [Sema] Use a more civilized hash map to implement -Wduplicate-enum.

Author: epilk Date: Tue Sep 25 15:53:06 2018 New Revision: 343042 URL: http://llvm.org/viewvc/llvm-project?rev=343042&view=rev Log: [Sema] Use a more civilized hash map to implement -Wduplicate-enum. DenseMap used LONG_MAX as a tombstone, so it asserts when you try to insert it! rdar://44774672

r343050 - Fix a bot failure from r343042.

Author: epilk Date: Tue Sep 25 16:52:29 2018 New Revision: 343050 URL: http://llvm.org/viewvc/llvm-project?rev=343050&view=rev Log: Fix a bot failure from r343042. Modified: cfe/trunk/test/Sema/warn-duplicate-enum.c Modified: cfe/trunk/test/Sema/warn-duplicate-enum.c URL: http://llvm.org/vi

Re: r338385 - [RISCV] Add driver for riscv32-unknown-elf baremetal target

I put a patch up to fix this here: https://reviews.llvm.org/D52574 Please take these warnings more seriously next time. It's the committer's responsibility to fix these warnings [1], and they often identify legitimate issues in the patch. Thanks, Erik [1]: https://llvm.org/docs/DeveloperPoli

r343263 - NFC: Fix some darwin linker warnings introduced in r338385

Author: epilk Date: Thu Sep 27 13:36:28 2018 New Revision: 343263 URL: http://llvm.org/viewvc/llvm-project?rev=343263&view=rev Log: NFC: Fix some darwin linker warnings introduced in r338385 The darwin linker was complaining about Toolchains/RISCV.cpp and Toolchains/Arch/RISCV.cpp had the same na

r343360 - Support enums with a fixed underlying type in all language modes.

Author: epilk Date: Fri Sep 28 13:24:58 2018 New Revision: 343360 URL: http://llvm.org/viewvc/llvm-project?rev=343360&view=rev Log: Support enums with a fixed underlying type in all language modes. Previously we supported these in C++, ObjC, and C with -fms-extensions. rdar://43831380 Different

r353115 - [SemaObjC] Don't infer the availabilty of +new from -init if the receiver has Class type

Author: epilk Date: Mon Feb 4 15:30:57 2019 New Revision: 353115 URL: http://llvm.org/viewvc/llvm-project?rev=353115&view=rev Log: [SemaObjC] Don't infer the availabilty of +new from -init if the receiver has Class type rdar://47713266 Differential revision: https://reviews.llvm.org/D57712 Mo

r353765 - Add a new attribute, fortify_stdlib

Author: epilk Date: Mon Feb 11 15:21:39 2019 New Revision: 353765 URL: http://llvm.org/viewvc/llvm-project?rev=353765&view=rev Log: Add a new attribute, fortify_stdlib This attribute applies to declarations of C stdlib functions (sprintf, memcpy...) that have known fortified variants (__sprintf_c

r353976 - [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

Author: epilk Date: Wed Feb 13 12:32:37 2019 New Revision: 353976 URL: http://llvm.org/viewvc/llvm-project?rev=353976&view=rev Log: [Sema] Delay checking whether objc_designated_initializer is being applied to an init method This fixes a regression that was caused by r335084, which reversed the

Re: r353976 - [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

being fixed is, but it caught my eye. > > From: cfe-commits <mailto:cfe-commits-boun...@lists.llvm.org>> on behalf of Erik Pilkington via > cfe-commits mailto:cfe-commits@lists.llvm.org>> > Reply-To: Erik Pilkington <mailto:erik.pilking...@gmail.com>> > Date

r354056 - [CodeGenObjC] Emit [[X alloc] init] as objc_alloc_init(X) when available

Author: epilk Date: Thu Feb 14 11:58:37 2019 New Revision: 354056 URL: http://llvm.org/viewvc/llvm-project?rev=354056&view=rev Log: [CodeGenObjC] Emit [[X alloc] init] as objc_alloc_init(X) when available This provides a code size win on the caller side, since the init message send is done in the

r354074 - [Sema] Fix-up a -Wfloat-conversion diagnostic

Author: epilk Date: Thu Feb 14 14:48:01 2019 New Revision: 354074 URL: http://llvm.org/viewvc/llvm-project?rev=354074&view=rev Log: [Sema] Fix-up a -Wfloat-conversion diagnostic We were warning on valid ObjC property reference exprs, and passing in the wrong arguments to DiagnoseFloatingImpCast (

Re: r354074 - [Sema] Fix-up a -Wfloat-conversion diagnostic

Hans, can you merge this diagnostic regression fix into LLVM 8? Thanks! > On Feb 14, 2019, at 2:48 PM, Erik Pilkington via cfe-commits > wrote: > > Author: epilk > Date: Thu Feb 14 14:48:01 2019 > New Revision: 354074 > > URL: http://llvm.org/viewvc/llvm-project?r

r354190 - [Sema] Diagnose floating point conversions based on target semantics

Author: epilk Date: Fri Feb 15 17:11:47 2019 New Revision: 354190 URL: http://llvm.org/viewvc/llvm-project?rev=354190&view=rev Log: [Sema] Diagnose floating point conversions based on target semantics ...instead of just comparing rank. Also, fix a bad warning about _Float16, since its declared ou

r354192 - Fix some tests I broke in r354190

Author: epilk Date: Fri Feb 15 17:51:19 2019 New Revision: 354192 URL: http://llvm.org/viewvc/llvm-project?rev=354192&view=rev Log: Fix some tests I broke in r354190 This was breaking on MSVC, since long double and double have the same semantics there. Modified: cfe/trunk/test/Misc/warn-in-s

r367346 - [Parser] Lambda capture lists can start with '*'

Author: epilk Date: Tue Jul 30 12:21:20 2019 New Revision: 367346 URL: http://llvm.org/viewvc/llvm-project?rev=367346&view=rev Log: [Parser] Lambda capture lists can start with '*' Fixes llvm.org/PR42778 Modified: cfe/trunk/lib/Parse/ParseInit.cpp cfe/trunk/test/Parser/cxx0x-lambda-expre

r367367 - [Sema] Actually map a variable template specialization from pattern to instantiation

Author: epilk Date: Tue Jul 30 16:38:18 2019 New Revision: 367367 URL: http://llvm.org/viewvc/llvm-project?rev=367367&view=rev Log: [Sema] Actually map a variable template specialization from pattern to instantiation We were previously just using a specialization in the class template instead of

r367708 - Remove a dead diagnostic, NFC

Author: epilk Date: Fri Aug 2 12:25:58 2019 New Revision: 367708 URL: http://llvm.org/viewvc/llvm-project?rev=367708&view=rev Log: Remove a dead diagnostic, NFC This was issued in Objective-C 1 mode, but we not longer support that, so this is just unreachable. Modified: cfe/trunk/include/cl

r368600 - [Sema] Require a complete type for __builtin_bit_cast operands

Author: epilk Date: Mon Aug 12 11:31:27 2019 New Revision: 368600 URL: http://llvm.org/viewvc/llvm-project?rev=368600&view=rev Log: [Sema] Require a complete type for __builtin_bit_cast operands Fixes llvm.org/PR42936 Modified: cfe/trunk/lib/Sema/SemaCast.cpp cfe/trunk/test/SemaCXX/built

r368610 - [Sema] Check __builtin_bit_cast operand for completeness before materializing it.

Author: epilk Date: Mon Aug 12 12:29:43 2019 New Revision: 368610 URL: http://llvm.org/viewvc/llvm-project?rev=368610&view=rev Log: [Sema] Check __builtin_bit_cast operand for completeness before materializing it. This shouldn't be observable, but it doesn't make sense to materialize an incomple

Re: r368600 - [Sema] Require a complete type for __builtin_bit_cast operands

Sure, I fixed this in r368610. Erik > On Aug 12, 2019, at 11:39 AM, Richard Smith wrote: > > On Mon, 12 Aug 2019 at 11:30, Erik Pilkington via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: epilk > Date: Mon Aug 12 11:31:27 2019 > New Revi

r368754 - Add a missing header comment, NFC

Author: epilk Date: Tue Aug 13 15:01:39 2019 New Revision: 368754 URL: http://llvm.org/viewvc/llvm-project?rev=368754&view=rev Log: Add a missing header comment, NFC Modified: cfe/trunk/lib/AST/FormatStringParsing.h Modified: cfe/trunk/lib/AST/FormatStringParsing.h URL: http://llvm.org/view

r368878 - [Sema][ObjC] Fix a -Wformat false positive with localizedStringForKey

Author: epilk Date: Wed Aug 14 09:57:11 2019 New Revision: 368878 URL: http://llvm.org/viewvc/llvm-project?rev=368878&view=rev Log: [Sema][ObjC] Fix a -Wformat false positive with localizedStringForKey Only honour format_arg attributes on -[NSBundle localizedStringForKey] when its argument has a

r364489 - [ObjC] Improve error message for a malformed objc-type-name

Author: epilk Date: Wed Jun 26 16:39:23 2019 New Revision: 364489 URL: http://llvm.org/viewvc/llvm-project?rev=364489&view=rev Log: [ObjC] Improve error message for a malformed objc-type-name If the type didn't exist, we used to emit a really bad error: t.m:3:12: error: expected ')' -(nullable N

r364954 - [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

Author: epilk Date: Tue Jul 2 11:28:13 2019 New Revision: 364954 URL: http://llvm.org/viewvc/llvm-project?rev=364954&view=rev Log: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast This commit adds a new builtin, __builtin_bit_cast(T, v), which performs a bit_cast from a value v to

r365408 - [ObjC] Add a -Wtautological-compare warning for BOOL

Author: epilk Date: Mon Jul 8 16:42:52 2019 New Revision: 365408 URL: http://llvm.org/viewvc/llvm-project?rev=365408&view=rev Log: [ObjC] Add a -Wtautological-compare warning for BOOL On macOS, BOOL is a typedef for signed char, but it should never hold a value that isn't 1 or 0. Any code that e

r365518 - [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL

Author: epilk Date: Tue Jul 9 10:29:40 2019 New Revision: 365518 URL: http://llvm.org/viewvc/llvm-project?rev=365518&view=rev Log: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL rdar://51954400 Differential revision: https://reviews.llvm.org/D63912 Added

r360446 - [Sema] Mark array element destructors referenced during initialization

Author: epilk Date: Fri May 10 10:52:26 2019 New Revision: 360446 URL: http://llvm.org/viewvc/llvm-project?rev=360446&view=rev Log: [Sema] Mark array element destructors referenced during initialization This fixes a crash where we would neglect to mark a destructor referenced for an __attribute__

r360802 - [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary

Author: epilk Date: Wed May 15 13:15:01 2019 New Revision: 360802 URL: http://llvm.org/viewvc/llvm-project?rev=360802&view=rev Log: [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary Any of these methods can be overridden, so we need to invoke these functions. Differential revisio

r349845 - Add support for namespaces on #pragma clang attribute

Author: epilk Date: Thu Dec 20 14:32:04 2018 New Revision: 349845 URL: http://llvm.org/viewvc/llvm-project?rev=349845&view=rev Log: Add support for namespaces on #pragma clang attribute Namespaces are introduced by adding an "identifier." before a push/pop directive. Pop directives with namespace

r350422 - [ObjCARC] Add an new attribute, objc_externally_retained

Author: epilk Date: Fri Jan 4 10:33:06 2019 New Revision: 350422 URL: http://llvm.org/viewvc/llvm-project?rev=350422&view=rev Log: [ObjCARC] Add an new attribute, objc_externally_retained This attribute, called "objc_externally_retained", exposes clang's notion of pseudo-__strong variables in AR

r350572 - Add a __has_feature check for namespaces on #pragma clang attribute.

Author: epilk Date: Mon Jan 7 13:54:00 2019 New Revision: 350572 URL: http://llvm.org/viewvc/llvm-project?rev=350572&view=rev Log: Add a __has_feature check for namespaces on #pragma clang attribute. Support for this was added in r349845. Modified: cfe/trunk/docs/LanguageExtensions.rst

Re: r350572 - Add a __has_feature check for namespaces on #pragma clang attribute.

On 1/7/19 3:51 PM, Richard Smith wrote: On Mon, 7 Jan 2019 at 13:57, Erik Pilkington via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: epilk Date: Mon Jan  7 13:54:00 2019 New Revision: 350572 URL: http://llvm.org/viewvc/llvm-project?rev=350572&am

r350585 - Split -Wdelete-non-virtual-dtor into -Wdelete-abstract-non-virtual-dtor

Author: epilk Date: Mon Jan 7 16:21:05 2019 New Revision: 350585 URL: http://llvm.org/viewvc/llvm-project?rev=350585&view=rev Log: Split -Wdelete-non-virtual-dtor into -Wdelete-abstract-non-virtual-dtor -Wdelete-non-virtual-dtor previously controlled two diagnostics: 1) calling a non-virtual dto

r350639 - Revert "Split -Wdelete-non-virtual-dtor into -Wdelete-abstract-non-virtual-dtor"

Author: epilk Date: Tue Jan 8 09:04:38 2019 New Revision: 350639 URL: http://llvm.org/viewvc/llvm-project?rev=350639&view=rev Log: Revert "Split -Wdelete-non-virtual-dtor into -Wdelete-abstract-non-virtual-dtor" This reverts commit r350585. There was some late post-commit review on phab. Remove

r350642 - __has_feature(pragma_clang_attribute_namespaces) should be __has_extension

Author: epilk Date: Tue Jan 8 10:24:39 2019 New Revision: 350642 URL: http://llvm.org/viewvc/llvm-project?rev=350642&view=rev Log: __has_feature(pragma_clang_attribute_namespaces) should be __has_extension Thanks to Richard Smith for pointing this out. Modified: cfe/trunk/docs/LanguageExten

Re: r350572 - Add a __has_feature check for namespaces on #pragma clang attribute.

On 1/7/19 4:43 PM, Richard Smith wrote: On Mon, 7 Jan 2019 at 16:12, Erik Pilkington via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: On 1/7/19 3:51 PM, Richard Smith wrote: On Mon, 7 Jan 2019 at 13:57, Erik Pilkington via cfe-commits mailto:cfe-commits@lists.ll

r350856 - Split -Wdelete-non-virtual-dtor into two groups

Author: epilk Date: Thu Jan 10 10:03:07 2019 New Revision: 350856 URL: http://llvm.org/viewvc/llvm-project?rev=350856&view=rev Log: Split -Wdelete-non-virtual-dtor into two groups This group controls two diagnostics: deleting an abstract class with a non-virtual dtor, which is a guaranteed crash,

r372152 - Use 'BOOL' instead of BOOL in diagnostic messages

Author: epilk Date: Tue Sep 17 11:02:45 2019 New Revision: 372152 URL: http://llvm.org/viewvc/llvm-project?rev=372152&view=rev Log: Use 'BOOL' instead of BOOL in diagnostic messages Type names should be enclosed in single quotes. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

r372183 - [Sema] Split of versions of -Wimplicit-{float, int}-conversion for Objective-C BOOL

Author: epilk Date: Tue Sep 17 14:11:51 2019 New Revision: 372183 URL: http://llvm.org/viewvc/llvm-project?rev=372183&view=rev Log: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL Also, add a diagnostic group, -Wobjc-signed-char-bool, to control all these relat

r372247 - [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

Author: epilk Date: Wed Sep 18 12:05:14 2019 New Revision: 372247 URL: http://llvm.org/viewvc/llvm-project?rev=372247&view=rev Log: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd Also, add a diagnostic under -Wformat for printing a boolean value as a character. rdar:

r372631 - NFC: Fix a poorly-written test

Author: epilk Date: Mon Sep 23 10:16:55 2019 New Revision: 372631 URL: http://llvm.org/viewvc/llvm-project?rev=372631&view=rev Log: NFC: Fix a poorly-written test The author of r364954 foolishly forgot that == binds tighter than ?: Modified: cfe/trunk/test/SemaCXX/constexpr-builtin-bit-cast.

[libcxxabi] r329950 - [demangler] NFC: Some refactoring to support partial demangling.

Author: epilk Date: Thu Apr 12 13:41:06 2018 New Revision: 329950 URL: http://llvm.org/viewvc/llvm-project?rev=329950&view=rev Log: [demangler] NFC: Some refactoring to support partial demangling. I'm committing this to libcxxabi too so that the two demanglers remain as simular as possible. Modi

r331098 - [ItaniumMangle] Undeduced auto type shouldn't be substitutable.

Author: epilk Date: Fri Apr 27 19:40:28 2018 New Revision: 331098 URL: http://llvm.org/viewvc/llvm-project?rev=331098&view=rev Log: [ItaniumMangle] Undeduced auto type shouldn't be substitutable. We still support the old mangling if we're trying to be ABI-compatible with Clang 6.0, though. Diffe

[libcxxabi] r336157 - [demangler] Fix a MSVC alignment warning.

Author: epilk Date: Mon Jul 2 17:23:18 2018 New Revision: 336157 URL: http://llvm.org/viewvc/llvm-project?rev=336157&view=rev Log: [demangler] Fix a MSVC alignment warning. This should fix llvm.org/PR37944 Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/trunk/src/cxa_dem

[libcxxabi] r336159 - Some buildbots were choking on std::max_align_t, try using the global alias.

Author: epilk Date: Mon Jul 2 17:48:27 2018 New Revision: 336159 URL: http://llvm.org/viewvc/llvm-project?rev=336159&view=rev Log: Some buildbots were choking on std::max_align_t, try using the global alias. Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/trunk/src/cxa_de

[libcxxabi] r336162 - Revert r336159, r336157. Some bots failed on qualified std::max_align_t, and other on unqualified max_align_t.

Author: epilk Date: Mon Jul 2 18:30:53 2018 New Revision: 336162 URL: http://llvm.org/viewvc/llvm-project?rev=336162&view=rev Log: Revert r336159, r336157. Some bots failed on qualified std::max_align_t, and other on unqualified max_align_t. I'll take another stab at this tomorrow. Any ideas fo

r336233 - [Sema] Discarded statment should be an evaluatable context.

Author: epilk Date: Tue Jul 3 15:15:36 2018 New Revision: 336233 URL: http://llvm.org/viewvc/llvm-project?rev=336233&view=rev Log: [Sema] Discarded statment should be an evaluatable context. The constexpr evaluator was erroring out because these templates weren't defined. Despite being used in a

r336478 - [Sema] Emit -Wincomplete-implementation for partial methods.

Author: epilk Date: Fri Jul 6 18:50:20 2018 New Revision: 336478 URL: http://llvm.org/viewvc/llvm-project?rev=336478&view=rev Log: [Sema] Emit -Wincomplete-implementation for partial methods. Fixes rdar://40634455 Modified: cfe/trunk/lib/Sema/SemaDeclObjC.cpp cfe/trunk/test/SemaObjC/inc

r336634 - [Sema] Fix a structured binding typo correction bug

Author: epilk Date: Mon Jul 9 19:15:07 2018 New Revision: 336634 URL: http://llvm.org/viewvc/llvm-project?rev=336634&view=rev Log: [Sema] Fix a structured binding typo correction bug BindingDecls have null type until their initializer is processed, so we can't assume that a correction candidate

r373774 - [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

Author: epilk Date: Fri Oct 4 12:20:27 2019 New Revision: 373774 URL: http://llvm.org/viewvc/llvm-project?rev=373774&view=rev Log: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic The warnings now in -Wformat-type-confusion don't align with how we interpret 'pedantic' in clang, an

[clang] d33c7de - [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct

Author: Erik Pilkington Date: 2020-04-06T16:04:13-04:00 New Revision: d33c7de8e11f2727ef5e325d931ae94af8619bf9 URL: https://github.com/llvm/llvm-project/commit/d33c7de8e11f2727ef5e325d931ae94af8619bf9 DIFF: https://github.com/llvm/llvm-project/commit/d33c7de8e11f2727ef5e325d931ae94af8619bf9.dif

[clang] 8b529e3 - [ObjC] Fix AST serialization for pseudo-strong parameters

Author: David Goldman Date: 2020-06-08T11:54:01-04:00 New Revision: 8b529e311a9052ee7a0676a1b517728efa44a3ba URL: https://github.com/llvm/llvm-project/commit/8b529e311a9052ee7a0676a1b517728efa44a3ba DIFF: https://github.com/llvm/llvm-project/commit/8b529e311a9052ee7a0676a1b517728efa44a3ba.diff

[clang] 95d7ccb - [PCH] Support writing BuiltinBitCastExprs to PCHs

Author: hyd-dev Date: 2020-06-11T13:37:01-04:00 New Revision: 95d7ccb70b9cbd53f1f137c0b2411852c42c122b URL: https://github.com/llvm/llvm-project/commit/95d7ccb70b9cbd53f1f137c0b2411852c42c122b DIFF: https://github.com/llvm/llvm-project/commit/95d7ccb70b9cbd53f1f137c0b2411852c42c122b.diff LOG:

[clang] 7437a94 - [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

Author: Erik Pilkington Date: 2020-07-07T13:29:54-04:00 New Revision: 7437a9496528b838e6939dbcbb69a0acb5e1332d URL: https://github.com/llvm/llvm-project/commit/7437a9496528b838e6939dbcbb69a0acb5e1332d DIFF: https://github.com/llvm/llvm-project/commit/7437a9496528b838e6939dbcbb69a0acb5e1332d.dif

[clang] 2f71cf6 - [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

Author: Erik Pilkington Date: 2020-07-07T13:29:54-04:00 New Revision: 2f71cf6d77c5cc679968851080d0513d84ddccb6 URL: https://github.com/llvm/llvm-project/commit/2f71cf6d77c5cc679968851080d0513d84ddccb6 DIFF: https://github.com/llvm/llvm-project/commit/2f71cf6d77c5cc679968851080d0513d84ddccb6.dif

[clang] dafc310 - [Sema] Emit a -Wformat warning for printf("%s", (void*)p)

Author: Erik Pilkington Date: 2020-07-10T15:10:24-04:00 New Revision: dafc3106d2069b806a10e072306a2196f1cda585 URL: https://github.com/llvm/llvm-project/commit/dafc3106d2069b806a10e072306a2196f1cda585 DIFF: https://github.com/llvm/llvm-project/commit/dafc3106d2069b806a10e072306a2196f1cda585.dif

[clang] 69d2fa9 - [SemaObjC] Fix a crash on invalid when 'auto' is used in a @property

Author: Erik Pilkington Date: 2020-06-24T12:11:39-04:00 New Revision: 69d2fa9ed1c1aba6f473feb03cad257e69a0cf52 URL: https://github.com/llvm/llvm-project/commit/69d2fa9ed1c1aba6f473feb03cad257e69a0cf52 DIFF: https://github.com/llvm/llvm-project/commit/69d2fa9ed1c1aba6f473feb03cad257e69a0cf52.dif

[clang] 85cca94 - [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber

Author: Erik Pilkington Date: 2020-04-20T15:22:51-04:00 New Revision: 85cca945b4c93ecfd3f3bb7a7b2d5fa4104c3560 URL: https://github.com/llvm/llvm-project/commit/85cca945b4c93ecfd3f3bb7a7b2d5fa4104c3560 DIFF: https://github.com/llvm/llvm-project/commit/85cca945b4c93ecfd3f3bb7a7b2d5fa4104c3560.dif

[clang] 2bb686b - [AST] Fix a crash on a dependent vector_size attribute

Author: Erik Pilkington Date: 2020-04-28T12:54:49-04:00 New Revision: 2bb686b4b629e3565dab239fd53b49f3a882d856 URL: https://github.com/llvm/llvm-project/commit/2bb686b4b629e3565dab239fd53b49f3a882d856 DIFF: https://github.com/llvm/llvm-project/commit/2bb686b4b629e3565dab239fd53b49f3a882d856.dif

[clang-tools-extra] fc915d1 - [clang-tidy] use stable_sort instead of sort to fix EXPENSIVE_CHECKS tests

Author: Erik Pilkington Date: 2020-08-12T12:12:10-04:00 New Revision: fc915d13b8671ceddea06e3f2f2d0e18869c41fe URL: https://github.com/llvm/llvm-project/commit/fc915d13b8671ceddea06e3f2f2d0e18869c41fe DIFF: https://github.com/llvm/llvm-project/commit/fc915d13b8671ceddea06e3f2f2d0e18869c41fe.dif

[clang] 873e279 - [SemaObjC] Add a warning for dictionary literals with duplicate keys

Author: Erik Pilkington Date: 2020-05-05T15:30:39-04:00 New Revision: 873e279095391df347b58ba4bab26dbfecab1262 URL: https://github.com/llvm/llvm-project/commit/873e279095391df347b58ba4bab26dbfecab1262 DIFF: https://github.com/llvm/llvm-project/commit/873e279095391df347b58ba4bab26dbfecab1262.dif

[clang] 86e50af - [AST] Print fixed enum type regardless of language mode

Author: Erik Pilkington Date: 2020-05-05T15:30:39-04:00 New Revision: 86e50af72d0a0f5cddd2cb487681709eda7934e8 URL: https://github.com/llvm/llvm-project/commit/86e50af72d0a0f5cddd2cb487681709eda7934e8 DIFF: https://github.com/llvm/llvm-project/commit/86e50af72d0a0f5cddd2cb487681709eda7934e8.dif

[PATCH] D25283: AvailabilityAttrs: Refactor context checking when diagnosing an availability violation

erik.pilkington created this revision. erik.pilkington added a reviewer: manmanren. erik.pilkington added a subscriber: cfe-commits. This patch removes some redundant functions that implement checking availability against context, and implements a new, more correct one: `ShouldDiagnoseAvailabili

[PATCH] D25284: AvailabilityAttrs: Delay partial availability diagnostics

erik.pilkington created this revision. erik.pilkington added a reviewer: manmanren. erik.pilkington added a subscriber: cfe-commits. Note: this patch depends on: https://reviews.llvm.org/D25283 This patch delays handling of `AR_NotYetIntroduced` diagnostics, so that the following compiles with n

[PATCH] D25283: AvailabilityAttrs: Refactor context checking when diagnosing an availability violation

erik.pilkington updated this revision to Diff 74547. erik.pilkington added a comment. This new patch fixes the style issues @aaron.ballman and @manmanren brought up. Thanks, Erik https://reviews.llvm.org/D25283 Files: include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp lib/Sema/SemaDeclAttr.c

[PATCH] D25283: AvailabilityAttrs: Refactor context checking when diagnosing an availability violation

erik.pilkington added inline comments. Comment at: lib/Sema/SemaExpr.cpp:179 - if (const DeclContext *DC = S.getCurObjCLexicalContext()) -ContextVersion = S.getVersionForDecl(cast(DC)); - manmanren wrote: > I don't quite get why we can remove the above logic

r284265 - [Sema] Refactor context checking for availability diagnostics

Author: epilk Date: Fri Oct 14 14:08:01 2016 New Revision: 284265 URL: http://llvm.org/viewvc/llvm-project?rev=284265&view=rev Log: [Sema] Refactor context checking for availability diagnostics This commit combines a couple of redundant functions that do availability attribute context checking in

[PATCH] D25284: AvailabilityAttrs: Delay partial availability diagnostics

erik.pilkington updated this revision to Diff 74738. erik.pilkington added a comment. This new patch renames `DelayedDiagnostic::DeprecationData` to `DelayedDiagnostic::AvailabilityData`, because now that it can hold information about deprecated, unavailable, and partial diagnostics. Thanks, Eri

[libcxxabi] r318874 - [demangler] Support for abi_tag attribute

Author: epilk Date: Wed Nov 22 12:38:22 2017 New Revision: 318874 URL: http://llvm.org/viewvc/llvm-project?rev=318874&view=rev Log: [demangler] Support for abi_tag attribute Differential revision: https://reviews.llvm.org/D40279 Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/tr

Re: r369705 - [Clang][CodeGen] set alias linkage on QualType

This commit is causing test failures on darwin: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/1464/consoleFull#-18314650158254eaf0-7326-4999-85b0-388101f2d404

r370270 - Fix a passing XFAIL test

Author: epilk Date: Wed Aug 28 15:38:36 2019 New Revision: 370270 URL: http://llvm.org/viewvc/llvm-project?rev=370270&view=rev Log: Fix a passing XFAIL test Now that we can gracefully handle stack exhaustion, this test was passing in darwin && asan. Instead, just unsupport it when threading is un

Re: r371080 - [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

Hi Alexandre, Looks like this commit is causing crashes on darwin, can you take a look please? Here is a failing bot: http://lab.llvm.org:8080/green/job/clang-stage1-RA/1671/ Thanks! Erik On Thu, Sep 5, 2019 at 11:23 AM Alexandre Ganea via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Auth

[libcxxabi] r309520 - [demangler] Fix some bugs in r309340 found by oss-fuzz

Author: epilk Date: Sun Jul 30 13:09:55 2017 New Revision: 309520 URL: http://llvm.org/viewvc/llvm-project?rev=309520&view=rev Log: [demangler] Fix some bugs in r309340 found by oss-fuzz Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.cpp Modified:

[libcxxabi] r309649 - [demangler] Use _LIBCPP_UNREACHABLE()

Author: epilk Date: Mon Jul 31 19:38:40 2017 New Revision: 309649 URL: http://llvm.org/viewvc/llvm-project?rev=309649&view=rev Log: [demangler] Use _LIBCPP_UNREACHABLE() Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/trunk/src/cxa_demangle.cpp URL: http://llvm.org/viewvc

[libcxxabi] r309650 - [demangler] Fix another bug found by oss-fuzz in r309340

Author: epilk Date: Mon Jul 31 19:38:41 2017 New Revision: 309650 URL: http://llvm.org/viewvc/llvm-project?rev=309650&view=rev Log: [demangler] Fix another bug found by oss-fuzz in r309340 Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.cpp Modified

Re: [libcxxabi] r309349 - [demangler] Fix some overzealous -Wreturn-type errors

On 7/31/17 11:44 AM, David Blaikie wrote: On Thu, Jul 27, 2017 at 6:35 PM Erik Pilkington via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: epilk Date: Thu Jul 27 18:35:14 2017 New Revision: 309349 URL: http://llvm.org/viewvc/llvm-project?rev=30934

[libcxxabi] r310226 - [demangler] Fix another oss-fuzz bug

Author: epilk Date: Sun Aug 6 13:46:33 2017 New Revision: 310226 URL: http://llvm.org/viewvc/llvm-project?rev=310226&view=rev Log: [demangler] Fix another oss-fuzz bug Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.cpp Modified: libcxxabi/trunk/sr

r310382 - [Availability] Don't make an availability attribute imply default visibility on macOS

Author: epilk Date: Tue Aug 8 10:09:09 2017 New Revision: 310382 URL: http://llvm.org/viewvc/llvm-project?rev=310382&view=rev Log: [Availability] Don't make an availability attribute imply default visibility on macOS Fixes PR33796, rdar://33655115 Differential revision: https://reviews.llvm.or

[libcxxabi] r310525 - [demangler] Improve representation of substitutions/templates

Author: epilk Date: Wed Aug 9 14:30:57 2017 New Revision: 310525 URL: http://llvm.org/viewvc/llvm-project?rev=310525&view=rev Log: [demangler] Improve representation of substitutions/templates Differential revision: https://reviews.llvm.org/D36427 Added: libcxxabi/trunk/test/unittest_demang

[libcxxabi] r310530 - Mark test as unsupported c++98/03 to fix buildbots

Author: epilk Date: Wed Aug 9 14:51:56 2017 New Revision: 310530 URL: http://llvm.org/viewvc/llvm-project?rev=310530&view=rev Log: Mark test as unsupported c++98/03 to fix buildbots Modified: libcxxabi/trunk/test/unittest_demangle.pass.cpp Modified: libcxxabi/trunk/test/unittest_demangle.pa

[libcxxabi] r310535 - [demangler] Fix a bunch of -Wshadow warnings

Author: epilk Date: Wed Aug 9 15:45:35 2017 New Revision: 310535 URL: http://llvm.org/viewvc/llvm-project?rev=310535&view=rev Log: [demangler] Fix a bunch of -Wshadow warnings These were causing failures in -Werror builds. Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/

[libcxxabi] r310546 - [demangler] Fix some more -Wshadow warnings I missed in r310535

Author: epilk Date: Wed Aug 9 19:48:13 2017 New Revision: 310546 URL: http://llvm.org/viewvc/llvm-project?rev=310546&view=rev Log: [demangler] Fix some more -Wshadow warnings I missed in r310535 Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/trunk/src/cxa_demangle.cpp UR

r310874 - [Sema] Improve some -Wunguarded-availability diagnostics

Author: epilk Date: Mon Aug 14 12:49:12 2017 New Revision: 310874 URL: http://llvm.org/viewvc/llvm-project?rev=310874&view=rev Log: [Sema] Improve some -Wunguarded-availability diagnostics rdar://33543523 Differential revision: https://reviews.llvm.org/D36200 Modified: cfe/trunk/include/clan

Re: r310382 - [Availability] Don't make an availability attribute imply default visibility on macOS

Probably not, this might be a risky change. - Erik On 8/15/17 9:15 AM, Nico Weber wrote: Do we want to merge this to 5.0? On Tue, Aug 8, 2017 at 1:09 PM, Erik Pilkington via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: epilk Date: Tue Aug 8 10:09:09 2017

r311191 - [Sema] Don't emit -Wunguarded-availability for switch cases

Author: epilk Date: Fri Aug 18 13:20:56 2017 New Revision: 311191 URL: http://llvm.org/viewvc/llvm-project?rev=311191&view=rev Log: [Sema] Don't emit -Wunguarded-availability for switch cases This made it awkward to switch over an enum where some entries are partial and is unlikley to catch any b

[clang] a9a6e62 - [CodeGen] Make sure the EH cleanup for block captures is conditional when the block literal is in a conditional context

Author: Erik Pilkington Date: 2020-08-31T10:12:17-04:00 New Revision: a9a6e62ddff21c597b82f0f6d26bca6a1a473a6f URL: https://github.com/llvm/llvm-project/commit/a9a6e62ddff21c597b82f0f6d26bca6a1a473a6f DIFF: https://github.com/llvm/llvm-project/commit/a9a6e62ddff21c597b82f0f6d26bca6a1a473a6f.dif

[clang] 8ff44e6 - [IRGen] Fix an assert when __attribute__((used)) is used on an ObjC method

Author: Erik Pilkington Date: 2020-09-02T12:19:11-04:00 New Revision: 8ff44e644bb70dfb8decc397a42679df6e6f8ba1 URL: https://github.com/llvm/llvm-project/commit/8ff44e644bb70dfb8decc397a42679df6e6f8ba1 DIFF: https://github.com/llvm/llvm-project/commit/8ff44e644bb70dfb8decc397a42679df6e6f8ba1.dif

[clang] d46f2c5 - Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

Author: Erik Pilkington Date: 2020-09-02T12:19:12-04:00 New Revision: d46f2c51e4c849683434bb5a0fb6164957474b8f URL: https://github.com/llvm/llvm-project/commit/d46f2c51e4c849683434bb5a0fb6164957474b8f DIFF: https://github.com/llvm/llvm-project/commit/d46f2c51e4c849683434bb5a0fb6164957474b8f.dif

[clang] 2d11ae0 - Fix a -Wparenthesis warning in 8ff44e644bb7, NFC

Author: Erik Pilkington Date: 2020-09-02T15:01:54-04:00 New Revision: 2d11ae0a40e209a7b91aeff0c9cf28fe41dce93c URL: https://github.com/llvm/llvm-project/commit/2d11ae0a40e209a7b91aeff0c9cf28fe41dce93c DIFF: https://github.com/llvm/llvm-project/commit/2d11ae0a40e209a7b91aeff0c9cf28fe41dce93c.dif

[clang] 9523cf0 - [AST] Fix handling of long double and bool in __builtin_bit_cast

Author: Erik Pilkington Date: 2020-09-02T15:01:53-04:00 New Revision: 9523cf02c22a83bece8d81080693a0cbf4098bb5 URL: https://github.com/llvm/llvm-project/commit/9523cf02c22a83bece8d81080693a0cbf4098bb5 DIFF: https://github.com/llvm/llvm-project/commit/9523cf02c22a83bece8d81080693a0cbf4098bb5.dif

[clang] 0f1be87 - [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once

Author: Erik Pilkington Date: 2020-09-03T16:56:35-04:00 New Revision: 0f1be87e294751a0941f1d9b7785ebf4d8072149 URL: https://github.com/llvm/llvm-project/commit/0f1be87e294751a0941f1d9b7785ebf4d8072149 DIFF: https://github.com/llvm/llvm-project/commit/0f1be87e294751a0941f1d9b7785ebf4d8072149.dif

[clang] 95b2dab - [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays

Author: Erik Pilkington Date: 2020-12-16T10:01:24-05:00 New Revision: 95b2dab199100f5a86d3f73a995afea879886d65 URL: https://github.com/llvm/llvm-project/commit/95b2dab199100f5a86d3f73a995afea879886d65 DIFF: https://github.com/llvm/llvm-project/commit/95b2dab199100f5a86d3f73a995afea879886d65.dif

[clang] 92d6e80 - NFC: balance a quote in AttrDocs.td

Author: Erik Pilkington Date: 2020-12-16T10:01:24-05:00 New Revision: 92d6e8001e20d6d0f457ac7cab8b64f3b1a131bf URL: https://github.com/llvm/llvm-project/commit/92d6e8001e20d6d0f457ac7cab8b64f3b1a131bf DIFF: https://github.com/llvm/llvm-project/commit/92d6e8001e20d6d0f457ac7cab8b64f3b1a131bf.dif

[clang] 498c7fa - [SemaObjC] Fix a crash on an invalid ternary with ARC pointers

Author: Erik Pilkington Date: 2020-10-13T21:20:20-04:00 New Revision: 498c7fa48a02a5e0c12bbb90ef8c0d8468affcdd URL: https://github.com/llvm/llvm-project/commit/498c7fa48a02a5e0c12bbb90ef8c0d8468affcdd DIFF: https://github.com/llvm/llvm-project/commit/498c7fa48a02a5e0c12bbb90ef8c0d8468affcdd.dif

[clang] 3513171 - [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type

Author: Erik Pilkington Date: 2020-10-15T15:21:01-04:00 New Revision: 351317167e2b28aad03f8e45e0ed0acbbff18c61 URL: https://github.com/llvm/llvm-project/commit/351317167e2b28aad03f8e45e0ed0acbbff18c61 DIFF: https://github.com/llvm/llvm-project/commit/351317167e2b28aad03f8e45e0ed0acbbff18c61.dif

[clang] 090dd64 - [Sema] Fold VLAs to constant arrays in a few more contexts

Author: Erik Pilkington Date: 2020-12-04T10:03:23-05:00 New Revision: 090dd647d98dc50a56a42fbba0f3f11b10a3a187 URL: https://github.com/llvm/llvm-project/commit/090dd647d98dc50a56a42fbba0f3f11b10a3a187 DIFF: https://github.com/llvm/llvm-project/commit/090dd647d98dc50a56a42fbba0f3f11b10a3a187.dif

[clang] 4fa0dbd - Fix a test failing on windows

Author: Erik Pilkington Date: 2020-12-04T11:20:17-05:00 New Revision: 4fa0dbd6885bc4a48ceecdbb0fca9638792762cf URL: https://github.com/llvm/llvm-project/commit/4fa0dbd6885bc4a48ceecdbb0fca9638792762cf DIFF: https://github.com/llvm/llvm-project/commit/4fa0dbd6885bc4a48ceecdbb0fca9638792762cf.dif

[clang] 9cd2413 - [clang] Add a new nullability annotation for swift async: _Nullable_result

Author: Erik Pilkington Date: 2020-12-07T17:19:20-05:00 New Revision: 9cd2413f1ca7a7f40132ea3c44f251851aa325c2 URL: https://github.com/llvm/llvm-project/commit/9cd2413f1ca7a7f40132ea3c44f251851aa325c2 DIFF: https://github.com/llvm/llvm-project/commit/9cd2413f1ca7a7f40132ea3c44f251851aa325c2.dif

<    1   2   3   4   >