r306156 - Add test for 306149, warn on throw from noexcept

2017-06-23 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jun 23 15:30:33 2017 New Revision: 306156 URL: http://llvm.org/viewvc/llvm-project?rev=306156&view=rev Log: Add test for 306149, warn on throw from noexcept Added: cfe/trunk/test/SemaCXX/warn-throw-out-noexcept-func.cpp Added: cfe/trunk/test/SemaCXX/warn-throw-ou

r320765 - Correct UnaryTransformTypeLoc to properly initialize.

2017-12-14 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Dec 14 15:37:08 2017 New Revision: 320765 URL: http://llvm.org/viewvc/llvm-project?rev=320765&view=rev Log: Correct UnaryTransformTypeLoc to properly initialize. The initializeLocal function of UnaryTransformTypeLoc missed the UnderlyingTInfo member. This caused a nu

r320829 - Remove "FunctionName -" from docs on FunctionDecl(NFC)

2017-12-15 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Dec 15 08:37:14 2017 New Revision: 320829 URL: http://llvm.org/viewvc/llvm-project?rev=320829&view=rev Log: Remove "FunctionName -" from docs on FunctionDecl(NFC) Removed the repetative usage of the operator name on the documentation for FunctionDecl. Also reflowed s

r321201 - Add support for ObjectFormat to TargetSpecificAttr

2017-12-20 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Dec 20 10:51:08 2017 New Revision: 321201 URL: http://llvm.org/viewvc/llvm-project?rev=321201&view=rev Log: Add support for ObjectFormat to TargetSpecificAttr Looking through the code, I saw a FIXME on IFunc to switch it to a target specific attribute. In looking thro

r321239 - Fix for PR32990

2017-12-20 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Dec 20 18:07:46 2017 New Revision: 321239 URL: http://llvm.org/viewvc/llvm-project?rev=321239&view=rev Log: Fix for PR32990 This fixes the bug in https://bugs.llvm.org/show_bug.cgi?id=32990. Patch By: zahiraam Differential Revision: https://reviews.llvm.org/D39063 A

r321324 - Correct hasFeature/isValidFeatureName's handling of shstk/adx/mwaitx

2017-12-21 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Dec 21 15:27:36 2017 New Revision: 321324 URL: http://llvm.org/viewvc/llvm-project?rev=321324&view=rev Log: Correct hasFeature/isValidFeatureName's handling of shstk/adx/mwaitx https://bugs.llvm.org/show_bug.cgi?id=35721 reports that x86intrin.h is issuing a few warni

r322028 - Implement Attribute Target MultiVersioning

2018-01-08 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Jan 8 13:34:17 2018 New Revision: 322028 URL: http://llvm.org/viewvc/llvm-project?rev=322028&view=rev Log: Implement Attribute Target MultiVersioning GCC's attribute 'target', in addition to being an optimization hint, also allows function multiversioning. We current

r322043 - Document attribute target multiversioning.

2018-01-08 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Jan 8 15:36:29 2018 New Revision: 322043 URL: http://llvm.org/viewvc/llvm-project?rev=322043&view=rev Log: Document attribute target multiversioning. Add attribute target multiversioning to the release notes. Additionally adds multiversioning support to the attribut

r322052 - Fix use-after-free found by address-san on -r322028.

2018-01-08 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Jan 8 17:09:12 2018 New Revision: 322052 URL: http://llvm.org/viewvc/llvm-project?rev=322052&view=rev Log: Fix use-after-free found by address-san on -r322028. r322028 attempted to remove something from the "Manglings" list when it was no longer valid, and did so wit

r326623 - Remove -i command line option, add -imultilib

2018-03-02 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Mar 2 13:53:25 2018 New Revision: 326623 URL: http://llvm.org/viewvc/llvm-project?rev=326623&view=rev Log: Remove -i command line option, add -imultilib I discovered that '-i' is a command line option for the driver, however it actually does not do anything and is no

r333746 - [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file

2018-06-01 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jun 1 06:04:26 2018 New Revision: 333746 URL: http://llvm.org/viewvc/llvm-project?rev=333746&view=rev Log: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file Compiler crashes when omp simd is used in an OpenCL file: clang -c -fopenmp omp_simd.cl __kernel vo

r333752 - Fix unused variable warning from r333718

2018-06-01 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jun 1 07:16:18 2018 New Revision: 333752 URL: http://llvm.org/viewvc/llvm-project?rev=333752&view=rev Log: Fix unused variable warning from r333718 Modified: cfe/trunk/lib/Lex/ModuleMap.cpp Modified: cfe/trunk/lib/Lex/ModuleMap.cpp URL: http://llvm.org/viewvc/

r334503 - Fix overload resolution between Ptr-To-Member and Bool

2018-06-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Jun 12 06:59:32 2018 New Revision: 334503 URL: http://llvm.org/viewvc/llvm-project?rev=334503&view=rev Log: Fix overload resolution between Ptr-To-Member and Bool As reported here (https://bugs.llvm.org/show_bug.cgi?id=19808) and discovered independently when looking

r334597 - Correct behavior of __builtin_*_overflow and constexpr.

2018-06-13 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Jun 13 06:25:11 2018 New Revision: 334597 URL: http://llvm.org/viewvc/llvm-project?rev=334597&view=rev Log: Correct behavior of __builtin_*_overflow and constexpr. Enable these builtins to be called across a lambda boundary with captureless const/constexpr, as brought

r334650 - Implement constexpr __builtin_*_overflow

2018-06-13 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Jun 13 13:43:27 2018 New Revision: 334650 URL: http://llvm.org/viewvc/llvm-project?rev=334650&view=rev Log: Implement constexpr __builtin_*_overflow As requested here:https://bugs.llvm.org/show_bug.cgi?id=37633 permit the __builtin_*_overflow builtins in constexpr fun

r334652 - Simplify test from r334650

2018-06-13 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Jun 13 13:47:12 2018 New Revision: 334652 URL: http://llvm.org/viewvc/llvm-project?rev=334652&view=rev Log: Simplify test from r334650 No reason to have the 'bool' as an intermediary value, simply use the fact that curley braces enforce eval order. Modified: cfe/

r335372 - [NFC] Fix AttributeList allocated_size for ParsedType.

2018-06-22 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jun 22 10:34:44 2018 New Revision: 335372 URL: http://llvm.org/viewvc/llvm-project?rev=335372&view=rev Log: [NFC] Fix AttributeList allocated_size for ParsedType. This if/elseif structure seems to be missing this case. Previously, this would report a size of 1 pointer

r344957 - Give Multiversion-inline functions linkonce linkage

2018-10-22 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Oct 22 14:20:45 2018 New Revision: 344957 URL: http://llvm.org/viewvc/llvm-project?rev=344957&view=rev Log: Give Multiversion-inline functions linkonce linkage Since multiversion variant functions can be inline, in C they become available-externally linkage. This end

r345145 - Remove a pair of unused dispatch multiversion declarations.

2018-10-24 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Oct 24 07:33:30 2018 New Revision: 345145 URL: http://llvm.org/viewvc/llvm-project?rev=345145&view=rev Log: Remove a pair of unused dispatch multiversion declarations. These declarations somehow survived a cleanup that combined them with the target multiversioning fun

r345298 - Implement Function Multiversioning for Non-ELF Systems.

2018-10-25 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Oct 25 11:57:19 2018 New Revision: 345298 URL: http://llvm.org/viewvc/llvm-project?rev=345298&view=rev Log: Implement Function Multiversioning for Non-ELF Systems. Similar to how ICC handles CPU-Dispatch on Windows, this patch uses the resolver function directly to fo

r345302 - Change keep-static-consts to work on static storage duration, not

2018-10-25 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Oct 25 12:13:46 2018 New Revision: 345302 URL: http://llvm.org/viewvc/llvm-project?rev=345302&view=rev Log: Change keep-static-consts to work on static storage duration, not storage class. To be more in line with what GCC does, switch the condition to be based on the

r350941 - Fix a pair of Wfallthrough warnings in ScanfFormatString.

2019-01-11 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jan 11 10:01:40 2019 New Revision: 350941 URL: http://llvm.org/viewvc/llvm-project?rev=350941&view=rev Log: Fix a pair of Wfallthrough warnings in ScanfFormatString. Change-Id: Ia73a34fdd93fc974224583505f9e6432493cb0da Modified: cfe/trunk/lib/AST/ScanfFormatStrin

r351212 - Fix cpu-dispatch MV regression caused by r347812

2019-01-15 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Jan 15 09:51:09 2019 New Revision: 351212 URL: http://llvm.org/viewvc/llvm-project?rev=351212&view=rev Log: Fix cpu-dispatch MV regression caused by r347812 r347812 permitted forward declarations for cpu-dispatch functions, which are occassionally useful as exposition

r351495 - Make integral-o-pointer conversions in SFINAE illegal.

2019-01-17 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Jan 17 15:11:15 2019 New Revision: 351495 URL: http://llvm.org/viewvc/llvm-project?rev=351495&view=rev Log: Make integral-o-pointer conversions in SFINAE illegal. As reported in PR40362, allowing the conversion from an integral to a pointer type (despite being illegal

r351550 - Fix test failure from r351495

2019-01-18 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jan 18 05:58:10 2019 New Revision: 351550 URL: http://llvm.org/viewvc/llvm-project?rev=351550&view=rev Log: Fix test failure from r351495 The test has problems due to some platforms having a different type for ptrdiff_t, so the error message is different. The error m

r351576 - [NFC] Fix wParentheses warning in ASTContext getFixedPointSemantics

2019-01-18 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jan 18 11:31:54 2019 New Revision: 351576 URL: http://llvm.org/viewvc/llvm-project?rev=351576&view=rev Log: [NFC] Fix wParentheses warning in ASTContext getFixedPointSemantics Change-Id: I862f00a548236872fe24f7da8eb2bf7917e123ff Modified: cfe/trunk/lib/AST/ASTCon

r352054 - [CPU-Dispatch] Make pentium_iii_no_xmm_regs and pentium_iii alias.

2019-01-24 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Jan 24 07:28:57 2019 New Revision: 352054 URL: http://llvm.org/viewvc/llvm-project?rev=352054&view=rev Log: [CPU-Dispatch] Make pentium_iii_no_xmm_regs and pentium_iii alias. I discovered that in ICC (where this list comes from), that the two pentium_iii versions were

r352219 - Allow 'static' storage specifier on an out-of-line member function template

2019-01-25 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jan 25 09:01:42 2019 New Revision: 352219 URL: http://llvm.org/viewvc/llvm-project?rev=352219&view=rev Log: Allow 'static' storage specifier on an out-of-line member function template declaration in MSVCCompat mode Microsoft compiler permits the use of 'static' storag

r352221 - Disable _Float16 for non ARM/SPIR Targets

2019-01-25 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jan 25 09:27:57 2019 New Revision: 352221 URL: http://llvm.org/viewvc/llvm-project?rev=352221&view=rev Log: Disable _Float16 for non ARM/SPIR Targets As Discussed here: http://lists.llvm.org/pipermail/llvm-dev/2019-January/129543.html There are problems exposing the

r352222 - Fix incorrect indent from r352221

2019-01-25 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jan 25 09:39:57 2019 New Revision: 35 URL: http://llvm.org/viewvc/llvm-project?rev=35&view=rev Log: Fix incorrect indent from r352221 Change-Id: I0a7b1443eb6912ef7bea1a4cf2f696fc01726557 Modified: cfe/trunk/docs/LanguageExtensions.rst Modified: cfe/trunk

r352229 - Remove F16 literal support based on Float16 support.

2019-01-25 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jan 25 10:36:20 2019 New Revision: 352229 URL: http://llvm.org/viewvc/llvm-project?rev=352229&view=rev Log: Remove F16 literal support based on Float16 support. Float16 support was disabled recently on many platforms, however that commit still allowed literals of Floa

r345826 - CPU-Dispatch-- Fix conflict between 'generic' and 'pentium'

2018-11-01 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Nov 1 05:50:37 2018 New Revision: 345826 URL: http://llvm.org/viewvc/llvm-project?rev=345826&view=rev Log: CPU-Dispatch-- Fix conflict between 'generic' and 'pentium' When a dispatch function was being emitted that had both a generic and a pentium configuration liste

r345839 - Multiversioning- Ensure all MV functions are emitted.

2018-11-01 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Nov 1 08:11:43 2018 New Revision: 345839 URL: http://llvm.org/viewvc/llvm-project?rev=345839&view=rev Log: Multiversioning- Ensure all MV functions are emitted. Multiverson function versions are always used (by the resolver), so ensure that they are always emitted.

r345838 - CPU-Dispatch- Fix type of a member function, prevent deferrals

2018-11-01 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Nov 1 08:11:41 2018 New Revision: 345838 URL: http://llvm.org/viewvc/llvm-project?rev=345838&view=rev Log: CPU-Dispatch- Fix type of a member function, prevent deferrals The member type creation for a cpu-dispatch function was not correctly including the 'this' param

r346677 - Implement P1094R2 (nested inline namespaces)

2018-11-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Nov 12 09:19:48 2018 New Revision: 346677 URL: http://llvm.org/viewvc/llvm-project?rev=346677&view=rev Log: Implement P1094R2 (nested inline namespaces) As approved for the Working Paper in San Diego, support annotating inline namespaces with 'inline'. Change-Id: I51

r346696 - [NFC] Fix formatting in inline nested namespace definition.

2018-11-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Nov 12 11:29:26 2018 New Revision: 346696 URL: http://llvm.org/viewvc/llvm-project?rev=346696&view=rev Log: [NFC] Fix formatting in inline nested namespace definition. Apparently my invocation of clang-format in VIM didn't get this right, but the patch-version DID. Th

r346705 - Fix the 'fixit' for inline namespace replacement.

2018-11-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Nov 12 13:08:41 2018 New Revision: 346705 URL: http://llvm.org/viewvc/llvm-project?rev=346705&view=rev Log: Fix the 'fixit' for inline namespace replacement. I'd neglected to add to the fixit for r346677. Richard Smith mentioned this in a review-after-commit, so fixi

r346757 - [NFC] Move storage of dispatch-version to GlobalDecl

2018-11-13 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Nov 13 07:48:08 2018 New Revision: 346757 URL: http://llvm.org/viewvc/llvm-project?rev=346757&view=rev Log: [NFC] Move storage of dispatch-version to GlobalDecl As suggested by Richard Smith, and initially put up for review here: https://reviews.llvm.org/D53341, this

r346996 - Fix parens warning in assert in ASTMatchFinder

2018-11-15 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Nov 15 13:35:35 2018 New Revision: 346996 URL: http://llvm.org/viewvc/llvm-project?rev=346996&view=rev Log: Fix parens warning in assert in ASTMatchFinder Change-Id: Ie34f9c6846b98fba87449e73299519fc2346bac1 Modified: cfe/trunk/lib/ASTMatchers/ASTMatchFinder.cpp

r347322 - [NFC] Remove MS line endings in diagnostics file.

2018-11-20 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Nov 20 08:32:46 2018 New Revision: 347322 URL: http://llvm.org/viewvc/llvm-project?rev=347322&view=rev Log: [NFC] Remove MS line endings in diagnostics file. Change-Id: I74704acf052e2e8fe707f18230bc5655c2bf2a91 Modified: cfe/trunk/include/clang/Basic/DiagnosticSe

r347791 - [NFC] Move MultIversioning::Type into Decl so that it can be used in

2018-11-28 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Nov 28 10:34:14 2018 New Revision: 347791 URL: http://llvm.org/viewvc/llvm-project?rev=347791&view=rev Log: [NFC] Move MultIversioning::Type into Decl so that it can be used in CodeGen Change-Id: I32b14edca3501277e0e65672eafe3eea38c6f9ae Modified: cfe/trunk/inclu

r347805 - Correct 'target' default behavior on redecl, allow forward declaration.

2018-11-28 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Nov 28 12:58:43 2018 New Revision: 347805 URL: http://llvm.org/viewvc/llvm-project?rev=347805&view=rev Log: Correct 'target' default behavior on redecl, allow forward declaration. Declarations without the attribute were disallowed because it would be ambiguous which '

r347812 - Allow cpu-dispatch forward declarations.

2018-11-28 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Nov 28 13:54:04 2018 New Revision: 347812 URL: http://llvm.org/viewvc/llvm-project?rev=347812&view=rev Log: Allow cpu-dispatch forward declarations. As a followup to r347805, allow forward declarations of cpu-dispatch and cpu-specific for the same reasons. Change-Id:

r348268 - Remove reference to recently removed PTH Documentation.

2018-12-04 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Dec 4 06:46:25 2018 New Revision: 348268 URL: http://llvm.org/viewvc/llvm-project?rev=348268&view=rev Log: Remove reference to recently removed PTH Documentation. Removed in r348266 Change-Id: Icff0212f57c42ca84ec174ddd4366ae63a7923fa Modified: cfe/trunk/docs/i

r348595 - Revert "Multiversioning- Ensure all MV functions are emitted."

2018-12-07 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Dec 7 06:56:50 2018 New Revision: 348595 URL: http://llvm.org/viewvc/llvm-project?rev=348595&view=rev Log: Revert "Multiversioning- Ensure all MV functions are emitted." This reverts commit 65df29f9318ac13a633c0ce13b2b0bccf06e79ca. AS suggested by @rsmith here: http

r348598 - Fix spelling of WINDOWS in a test

2018-12-07 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Dec 7 07:06:43 2018 New Revision: 348598 URL: http://llvm.org/viewvc/llvm-project?rev=348598&view=rev Log: Fix spelling of WINDOWS in a test Change-Id: I232515655359f14308e1c5509c4b7db96d1fafcb Modified: cfe/trunk/test/CodeGen/attr-target-mv.c Modified: cfe/tru

r348600 - Make CPUDispatch resolver emit dependent functions.

2018-12-07 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Dec 7 07:31:23 2018 New Revision: 348600 URL: http://llvm.org/viewvc/llvm-project?rev=348600&view=rev Log: Make CPUDispatch resolver emit dependent functions. Inline cpu_specific versions referenced before the cpu_dispatch function weren't properly emitted, since the

r348899 - Replace Const-Member checking with non-recursive version.

2018-12-11 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Dec 11 13:54:52 2018 New Revision: 348899 URL: http://llvm.org/viewvc/llvm-project?rev=348899&view=rev Log: Replace Const-Member checking with non-recursive version. As reported in PR39946, these two implementations cause stack overflows to occur when a type recursive

r355317 - Give builtins and alloc/dealloc operators the default calling convention.

2019-03-04 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Mar 4 06:54:52 2019 New Revision: 355317 URL: http://llvm.org/viewvc/llvm-project?rev=355317&view=rev Log: Give builtins and alloc/dealloc operators the default calling convention. On SPIR targets, the default calling convention is SpirFunction. However, operator new

r355322 - Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.

2019-03-04 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Mar 4 10:47:21 2019 New Revision: 355322 URL: http://llvm.org/viewvc/llvm-project?rev=355322&view=rev Log: Enable _rotl, _lrotl, _rotr, _lrotr on all platforms. The above builtins are currently implemented for MSVC mode, however GCC also implements these. This patch

r355697 - Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms."

2019-03-08 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Mar 8 07:10:05 2019 New Revision: 355697 URL: http://llvm.org/viewvc/llvm-project?rev=355697&view=rev Log: Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms." This reverts commit 24400dafe16716f28cd0e7e5fa6e004c0e50686a. Removed: cfe/trunk/test/CodeGe

r355698 - Re-fix _lrotl/_lrotr to always take Long, no matter the platform.

2019-03-08 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Mar 8 07:10:07 2019 New Revision: 355698 URL: http://llvm.org/viewvc/llvm-project?rev=355698&view=rev Log: Re-fix _lrotl/_lrotr to always take Long, no matter the platform. r355322 fixed this, however is being reverted due to concerns with enabling it in other modes.

r356663 - Permit redeclarations of a builtin to specify calling convention.

2019-03-21 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Mar 21 06:30:56 2019 New Revision: 356663 URL: http://llvm.org/viewvc/llvm-project?rev=356663&view=rev Log: Permit redeclarations of a builtin to specify calling convention. After https://reviews.llvm.org/rL355317 we noticed that quite a decent amount of code redeclar

r353411 - Fix r350643 to limit COFF emission to <= 32 BYTES instead of BITS.

2019-02-07 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Feb 7 07:14:11 2019 New Revision: 353411 URL: http://llvm.org/viewvc/llvm-project?rev=353411&view=rev Log: Fix r350643 to limit COFF emission to <= 32 BYTES instead of BITS. The patch in r350643 incorrectly sets the COFF emission based on bits instead of bytes. This

r311905 - Change Diagnostic Category size error from runtime to compiletime

2017-08-28 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Aug 28 11:53:17 2017 New Revision: 311905 URL: http://llvm.org/viewvc/llvm-project?rev=311905&view=rev Log: Change Diagnostic Category size error from runtime to compiletime Diagnostic Categories are fairly annoying, and are only enforced by a runtime-debug-only asser

r312173 - [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

2017-08-30 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Aug 30 14:17:40 2017 New Revision: 312173 URL: http://llvm.org/viewvc/llvm-project?rev=312173&view=rev Log: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64 This attribute is useful in OS development when we jump from 32 to 64 bit code and expect

r312281 - Add documentation for force_align_arg_pointer function attribute

2017-08-31 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Aug 31 14:08:24 2017 New Revision: 312281 URL: http://llvm.org/viewvc/llvm-project?rev=312281&view=rev Log: Add documentation for force_align_arg_pointer function attribute Patch By: anatol.pomozov (anatol.pomo...@gmail.com) Differential Revision: https://reviews.ll

r312355 - [CodeGen]Refactor CpuSupports/CPUIs Builtin Code Gen to better work with

2017-09-01 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Sep 1 12:42:45 2017 New Revision: 312355 URL: http://llvm.org/viewvc/llvm-project?rev=312355&view=rev Log: [CodeGen]Refactor CpuSupports/CPUIs Builtin Code Gen to better work with "target" implementation A small set of refactors that'll make it easier for me to impl

r312542 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

2017-09-05 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Sep 5 10:32:36 2017 New Revision: 312542 URL: http://llvm.org/viewvc/llvm-project?rev=312542&view=rev Log: [Preprocessor] Correct internal token parsing of newline characters in CRLF Correct implementation: Apparently I managed in r311683 to submit the wrong version

r313364 - Fix the __interface inheritence rules to work better with IUnknown and IDispatch

2017-09-15 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Sep 15 09:03:35 2017 New Revision: 313364 URL: http://llvm.org/viewvc/llvm-project?rev=313364&view=rev Log: Fix the __interface inheritence rules to work better with IUnknown and IDispatch __interface objects in MSVC are permitted to inherit from __interface types, a

r313569 - [Sema] Fix a pair of crashes when generating exception specifiers with an

2017-09-18 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Sep 18 14:28:55 2017 New Revision: 313569 URL: http://llvm.org/viewvc/llvm-project?rev=313569&view=rev Log: [Sema] Fix a pair of crashes when generating exception specifiers with an error'ed field for a template class' default ctor. The two examples in the test would

r313828 - [MS Compat]Allow __interfaces to have properties.

2017-09-20 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Sep 20 15:28:24 2017 New Revision: 313828 URL: http://llvm.org/viewvc/llvm-project?rev=313828&view=rev Log: [MS Compat]Allow __interfaces to have properties. __interface types are allowed in MSVC to have "property" data members (marked with declspec property). This pa

r313907 - Suppress Wsign-conversion for enums with matching underlying type

2017-09-21 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Sep 21 12:58:55 2017 New Revision: 313907 URL: http://llvm.org/viewvc/llvm-project?rev=313907&view=rev Log: Suppress Wsign-conversion for enums with matching underlying type As reported here: https://bugs.llvm.org/show_bug.cgi?id=34692 A non-defined enum with a backi

r313909 - Add testcase I forgot to add in R313907.

2017-09-21 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Sep 21 13:14:08 2017 New Revision: 313909 URL: http://llvm.org/viewvc/llvm-project?rev=313909&view=rev Log: Add testcase I forgot to add in R313907. Added: cfe/trunk/test/SemaCXX/warn-sign-conversion-cpp11.cpp (with props) Added: cfe/trunk/test/SemaCXX/warn-sig

r313911 - Remove svn-properties for file added in 313909 (NFC)

2017-09-21 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Sep 21 13:31:01 2017 New Revision: 313911 URL: http://llvm.org/viewvc/llvm-project?rev=313911&view=rev Log: Remove svn-properties for file added in 313909 (NFC) Modified: cfe/trunk/test/SemaCXX/warn-sign-conversion-cpp11.cpp (props changed) Propchange: cfe/trun

r362106 - Revert "clang support gnu asm goto."

2019-05-30 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu May 30 08:38:02 2019 New Revision: 362106 URL: http://llvm.org/viewvc/llvm-project?rev=362106&view=rev Log: Revert "clang support gnu asm goto." This reverts commit 954ec09aed4f2be04bb5f4e10dbb4ea8bd19ef9a. Reverting due to test failures as requested by Jennifer Yu.

r362119 - Add Attribute NoThrow as an Exception Specifier Type

2019-05-30 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu May 30 10:31:54 2019 New Revision: 362119 URL: http://llvm.org/viewvc/llvm-project?rev=362119&view=rev Log: Add Attribute NoThrow as an Exception Specifier Type In response to https://bugs.llvm.org/show_bug.cgi?id=33235, it became clear that the current mechanism of h

r362157 - Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

2019-05-30 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu May 30 14:35:32 2019 New Revision: 362157 URL: http://llvm.org/viewvc/llvm-project?rev=362157&view=rev Log: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand. As reported here https://bugs.llvm.org/show_bug.cgi?id=42000, it was possible to get the

r362225 - Fix for PR42089, regression from r362119

2019-05-31 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri May 31 07:26:19 2019 New Revision: 362225 URL: http://llvm.org/viewvc/llvm-project?rev=362225&view=rev Log: Fix for PR42089, regression from r362119 The implementation of the NoThrow ExceptionSpecificationType missed a switch statement for forming the diagnostic when

r362236 - Suppress nothrow/exception spec conflict warning when ES is parsed.

2019-05-31 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri May 31 08:56:27 2019 New Revision: 362236 URL: http://llvm.org/viewvc/llvm-project?rev=362236&view=rev Log: Suppress nothrow/exception spec conflict warning when ES is parsed. The previously added warning ended up causing false positives when nothrow was used on membe

r362243 - Suppress nothrow/Exception spec conflict warning when we dont know the ES.

2019-05-31 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri May 31 09:46:38 2019 New Revision: 362243 URL: http://llvm.org/viewvc/llvm-project?rev=362243&view=rev Log: Suppress nothrow/Exception spec conflict warning when we dont know the ES. In any situation where the Exception Spec isn't clear, suppress the warning to avoid

r362245 - Replace 'default' in an enum-over-a-switch with the missing list.

2019-05-31 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri May 31 10:00:48 2019 New Revision: 362245 URL: http://llvm.org/viewvc/llvm-project?rev=362245&view=rev Log: Replace 'default' in an enum-over-a-switch with the missing list. This suppressed the Wswitch warning causing me to miss it and write an assertion failure. Mod

r362434 - Permit Exception Spec mismatch with NoThrow on inherited Virtual

2019-06-03 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Jun 3 11:36:26 2019 New Revision: 362434 URL: http://llvm.org/viewvc/llvm-project?rev=362434&view=rev Log: Permit Exception Spec mismatch with NoThrow on inherited Virtual As reported here: https://bugs.llvm.org/show_bug.cgi?id=42100 This fairly common pattern ends

r362435 - Make NoThrow FunctionLike, make FunctionLike include references, fix

2019-06-03 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Jun 3 11:36:33 2019 New Revision: 362435 URL: http://llvm.org/viewvc/llvm-project?rev=362435&view=rev Log: Make NoThrow FunctionLike, make FunctionLike include references, fix prettyprint __declspec(nothrow) should work on function pointers as well as function refere

r362443 - Fix test failure from r362435

2019-06-03 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Jun 3 12:57:52 2019 New Revision: 362443 URL: http://llvm.org/viewvc/llvm-project?rev=362443&view=rev Log: Fix test failure from r362435 Apparently I forgot to do an open brace in a namespace, so we get an error about an extra closing brace. Modified: cfe/trunk/

r362607 - Avoid using NoThrow Exception Specifier in non-C++ Modes.

2019-06-05 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Jun 5 07:10:39 2019 New Revision: 362607 URL: http://llvm.org/viewvc/llvm-project?rev=362607&view=rev Log: Avoid using NoThrow Exception Specifier in non-C++ Modes. As reported in https://bugs.llvm.org/show_bug.cgi?id=42113, there are a number of locations in Clang w

r363074 - Fix for r42230, MSVC test failure in DependencyDirectivesSourceMinimizerTest.cpp

2019-06-11 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Jun 11 07:58:26 2019 New Revision: 363074 URL: http://llvm.org/viewvc/llvm-project?rev=363074&view=rev Log: Fix for r42230, MSVC test failure in DependencyDirectivesSourceMinimizerTest.cpp r362459 introduced DependencyDirectivesSourceMinimizerTest.cpp, which hits an M

r363288 - PR42182: Allow thread-local to use __cxa_thread_atexit when

2019-06-13 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Jun 13 11:20:19 2019 New Revision: 363288 URL: http://llvm.org/viewvc/llvm-project?rev=363288&view=rev Log: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used This matches the GCC behavior, __cxa_thread_atexit should be permissible

r367027 - Implement P1771

2019-07-25 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Jul 25 08:10:56 2019 New Revision: 367027 URL: http://llvm.org/viewvc/llvm-project?rev=367027&view=rev Log: Implement P1771 As passed in the Cologne meeting and treated by Core as a DR, [[nodiscard]] was applied to constructors so that they can be diagnosed in cases w

r367038 - Fix cxx_status html for r367027

2019-07-25 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Jul 25 10:14:37 2019 New Revision: 367038 URL: http://llvm.org/viewvc/llvm-project?rev=367038&view=rev Log: Fix cxx_status html for r367027 Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm-project/c

r367039 - Remove CallingConvMethodType

2019-07-25 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Jul 25 10:14:45 2019 New Revision: 367039 URL: http://llvm.org/viewvc/llvm-project?rev=367039&view=rev Log: Remove CallingConvMethodType This seems to be an old vestage of a previous implementation of getting the default calling convention, and everything is now using

r367103 - Make the CXXABIs respect the target's default calling convention.

2019-07-26 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jul 26 05:36:12 2019 New Revision: 367103 URL: http://llvm.org/viewvc/llvm-project?rev=367103&view=rev Log: Make the CXXABIs respect the target's default calling convention. SPIR targets need to have all functions be SPIR calling convention, however the CXXABIs were j

r369281 - Implement P1668R1

2019-08-19 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Aug 19 10:39:59 2019 New Revision: 369281 URL: http://llvm.org/viewvc/llvm-project?rev=369281&view=rev Log: Implement P1668R1 Allow inline assembly statements in unexecuted branches of constexpr functions. Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp

r369282 - Update cxx_status.html with P1668 status.

2019-08-19 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Aug 19 10:57:27 2019 New Revision: 369282 URL: http://llvm.org/viewvc/llvm-project?rev=369282&view=rev Log: Update cxx_status.html with P1668 status. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm

r369284 - Fix test where diagnostics changed in P1668 implementation

2019-08-19 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Aug 19 11:08:52 2019 New Revision: 369284 URL: http://llvm.org/viewvc/llvm-project?rev=369284&view=rev Log: Fix test where diagnostics changed in P1668 implementation Modified: cfe/trunk/test/SemaCXX/cxx1z-constexpr-lambdas.cpp Modified: cfe/trunk/test/SemaCXX/cx

r369286 - Fix poorly formatted HTML in the cxx_status.html file caused by adding

2019-08-19 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Aug 19 11:14:22 2019 New Revision: 369286 URL: http://llvm.org/viewvc/llvm-project?rev=369286&view=rev Log: Fix poorly formatted HTML in the cxx_status.html file caused by adding 1668. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.htm

r364109 - Ensure Target Features always_inline error happens in C++ cases.

2019-06-21 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jun 21 15:29:32 2019 New Revision: 364109 URL: http://llvm.org/viewvc/llvm-project?rev=364109&view=rev Log: Ensure Target Features always_inline error happens in C++ cases. A handful of C++ cases as reported in PR42352 didn't actually give an error when always_inlinin

r364110 - Remove binary finally accidentially committed in r364109

2019-06-21 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jun 21 15:31:59 2019 New Revision: 364110 URL: http://llvm.org/viewvc/llvm-project?rev=364110&view=rev Log: Remove binary finally accidentially committed in r364109 Removed: cfe/trunk/test/CodeGenCXX/target-builtin-error.o Removed: cfe/trunk/test/CodeGenCXX/targe

r361507 - Ensure builtins use the target default Calling Convention

2019-05-23 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu May 23 09:05:21 2019 New Revision: 361507 URL: http://llvm.org/viewvc/llvm-project?rev=361507&view=rev Log: Ensure builtins use the target default Calling Convention r355317 changed builtins/allocation functions to use the default calling convention in order to suppor

r361992 - Add curley brackets to case statement that declares a variable.

2019-05-29 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed May 29 10:04:48 2019 New Revision: 361992 URL: http://llvm.org/viewvc/llvm-project?rev=361992&view=rev Log: Add curley brackets to case statement that declares a variable. Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp

r348932 - Remove TODO leftover from my devleopment branch

2018-12-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Dec 12 07:13:00 2018 New Revision: 348932 URL: http://llvm.org/viewvc/llvm-project?rev=348932&view=rev Log: Remove TODO leftover from my devleopment branch Accidentially checked in a TODO line from r348899. This removes it. Change-Id: I74b59c0ecfe147af8a08dd7fd10893a

r348942 - Make clang::CallGraph look into template instantiations

2018-12-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Dec 12 09:22:52 2018 New Revision: 348942 URL: http://llvm.org/viewvc/llvm-project?rev=348942&view=rev Log: Make clang::CallGraph look into template instantiations Clang's CallGraph analysis doesn't use the RecursiveASTVisitor's setting togo into template instantiatio

r348950 - Change CallGraph print to show the fully qualified name

2018-12-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Dec 12 10:11:36 2018 New Revision: 348950 URL: http://llvm.org/viewvc/llvm-project?rev=348950&view=rev Log: Change CallGraph print to show the fully qualified name CallGraph previously would just show the normal name of a function, which gets really confusing when usi

r348969 - Teach __builtin_unpredictable to work through implicit casts.

2018-12-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Dec 12 12:30:53 2018 New Revision: 348969 URL: http://llvm.org/viewvc/llvm-project?rev=348969&view=rev Log: Teach __builtin_unpredictable to work through implicit casts. The __builtin_unpredictable implementation is confused by any implicit casts, which happen in C++.

r349201 - Add extension to always default-initialize nullptr_t.

2018-12-14 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Dec 14 14:22:29 2018 New Revision: 349201 URL: http://llvm.org/viewvc/llvm-project?rev=349201&view=rev Log: Add extension to always default-initialize nullptr_t. Core issue 1013 suggests that having an uninitialied std::nullptr_t be UB is a bit foolish, since there is

r349206 - Revert "Add extension to always default-initialize nullptr_t."

2018-12-14 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Dec 14 14:41:18 2018 New Revision: 349206 URL: http://llvm.org/viewvc/llvm-project?rev=349206&view=rev Log: Revert "Add extension to always default-initialize nullptr_t." This reverts commit 46efdf2ccc2a80aefebf8433dbf9c7c959f6e629. Richard Smith commented just after

r349209 - Add AddressSpace mangling to MS mode

2018-12-14 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Dec 14 15:17:34 2018 New Revision: 349209 URL: http://llvm.org/viewvc/llvm-project?rev=349209&view=rev Log: Add AddressSpace mangling to MS mode All of the symbols demangle on llvm-undname and demangler.com. This address space qualifier is useful for when we want to u

r349506 - [NFC] Fix usage of Builder.insert(new Bitcast...)in CodeGenFunction

2018-12-18 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Dec 18 08:22:21 2018 New Revision: 349506 URL: http://llvm.org/viewvc/llvm-project?rev=349506&view=rev Log: [NFC] Fix usage of Builder.insert(new Bitcast...)in CodeGenFunction This is exactly a "CreateBitCast", so refactor this to get rid of a 'new'. Note that this s

r350398 - Prevent unreachable when checking invalid multiversion decls.

2019-01-04 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jan 4 07:24:06 2019 New Revision: 350398 URL: http://llvm.org/viewvc/llvm-project?rev=350398&view=rev Log: Prevent unreachable when checking invalid multiversion decls. CPUSpecifc/CPUDispatch call resolution assumed that all declarations that would be passed are vali

r350643 - Limit COFF 'common' emission to <=32 alignment types.

2019-01-08 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Jan 8 10:44:22 2019 New Revision: 350643 URL: http://llvm.org/viewvc/llvm-project?rev=350643&view=rev Log: Limit COFF 'common' emission to <=32 alignment types. As reported in PR33035, LLVM crashes if given a common object with an alignment of greater than 32 bits. T

<    1   2   3   4   5   6   7   8   9   10   >