r339039 - [NFC] Remove TODO comment that no longer applies (ParsedAttr)

2018-08-06 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Aug 6 11:11:48 2018 New Revision: 339039 URL: http://llvm.org/viewvc/llvm-project?rev=339039&view=rev Log: [NFC] Remove TODO comment that no longer applies (ParsedAttr) Modified: cfe/trunk/include/clang/Sema/ParsedAttr.h Modified: cfe/trunk/include/clang/Sema/Pa

r339344 - Implement diagnostic stream operator for ParsedAttr.

2018-08-09 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Aug 9 06:21:32 2018 New Revision: 339344 URL: http://llvm.org/viewvc/llvm-project?rev=339344&view=rev Log: Implement diagnostic stream operator for ParsedAttr. As a part of attempting to clean up the way attributes are printed, this patch adds an operator << to the

r339380 - [NFC] Convert ParsedAttr to use llvm::TrailingObjects

2018-08-09 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Aug 9 13:25:12 2018 New Revision: 339380 URL: http://llvm.org/viewvc/llvm-project?rev=339380&view=rev Log: [NFC] Convert ParsedAttr to use llvm::TrailingObjects ParsedAttr is using a hand-rolled trailing-objects implementation that gets cleaned up quite a bit by just

r339382 - [NFC] Simplify 'friend' declaration in ParsedAttr

2018-08-09 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Aug 9 14:03:39 2018 New Revision: 339382 URL: http://llvm.org/viewvc/llvm-project?rev=339382&view=rev Log: [NFC] Simplify 'friend' declaration in ParsedAttr As suggested in the post-commit review for D50531, change from the templatized TrailingObjects friend declarat

r339383 - [NFC] Complete the rule-of-5 for ParsedAttr

2018-08-09 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Aug 9 14:04:34 2018 New Revision: 339383 URL: http://llvm.org/viewvc/llvm-project?rev=339383&view=rev Log: [NFC] Complete the rule-of-5 for ParsedAttr Add move assign/construct as 'deleted' to ParsedAttr to complete the rule-of-5. Modified: cfe/trunk/include/cla

r339387 - Revert -r339382, which apparently breaks the Windows build.

2018-08-09 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Aug 9 14:13:46 2018 New Revision: 339387 URL: http://llvm.org/viewvc/llvm-project?rev=339387&view=rev Log: Revert -r339382, which apparently breaks the Windows build. Modified: cfe/trunk/include/clang/Sema/ParsedAttr.h Modified: cfe/trunk/include/clang/Sema/Pars

r339389 - Fix and recommit r339382 based on solution from RSmith:

2018-08-09 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Aug 9 14:18:13 2018 New Revision: 339389 URL: http://llvm.org/viewvc/llvm-project?rev=339389&view=rev Log: Fix and recommit r339382 based on solution from RSmith: As sent on cfe-commits: "You need to use "friend TrailingObjects;" here, not "friend class TrailingOb

r339597 - Enforce instantiation of template multiversion functions

2018-08-13 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Aug 13 11:33:20 2018 New Revision: 339597 URL: http://llvm.org/viewvc/llvm-project?rev=339597&view=rev Log: Enforce instantiation of template multiversion functions Multiversioned member functions inside of a template type were not properly being emitted. The soluti

r340025 - Fix for bug 38508 - Don't do PCH processing when only generating preprocessor output

2018-08-17 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Aug 17 06:43:39 2018 New Revision: 340025 URL: http://llvm.org/viewvc/llvm-project?rev=340025&view=rev Log: Fix for bug 38508 - Don't do PCH processing when only generating preprocessor output This clang-cl driver change removes the PCH options when we are only gener

r331812 - Fix float->int conversion warnings when near barriers.

2018-05-08 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue May 8 14:26:21 2018 New Revision: 331812 URL: http://llvm.org/viewvc/llvm-project?rev=331812&view=rev Log: Fix float->int conversion warnings when near barriers. As Eli brought up here: https://reviews.llvm.org/D46535 I'd previously messed up this fix by missing conv

r332470 - Add support for __declspec(code_seg("segname"))

2018-05-16 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed May 16 06:57:17 2018 New Revision: 332470 URL: http://llvm.org/viewvc/llvm-project?rev=332470&view=rev Log: Add support for __declspec(code_seg("segname")) Add support for __declspec(code_seg("segname")) This patch is built on the existing support for #pragma code_se

r332492 - Add lit tests forgotten for R332470

2018-05-16 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed May 16 10:04:47 2018 New Revision: 332492 URL: http://llvm.org/viewvc/llvm-project?rev=332492&view=rev Log: Add lit tests forgotten for R332470 I forgot to svn-add the lit tests for R332470. Added here! Added: cfe/trunk/test/CodeGenCXX/code_seg1.cpp (with pro

r314229 - [Sema] Corrected the warn-on-throw-from-noexcept behavior to include nothrow

2017-09-26 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Sep 26 11:20:39 2017 New Revision: 314229 URL: http://llvm.org/viewvc/llvm-project?rev=314229&view=rev Log: [Sema] Corrected the warn-on-throw-from-noexcept behavior to include nothrow Discovered that 'nothrow' (which is supposed to be an alias for noexcept) was not w

r314235 - Allow IUnknown/IInterface types to come from extern C++

2017-09-26 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Sep 26 11:55:16 2017 New Revision: 314235 URL: http://llvm.org/viewvc/llvm-project?rev=314235&view=rev Log: Allow IUnknown/IInterface types to come from extern C++ It was brought up in response to my last implementation for this struct-as-interface features that at l

r314262 - Emit section information for extern variables.

2017-09-26 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Sep 26 16:42:34 2017 New Revision: 314262 URL: http://llvm.org/viewvc/llvm-project?rev=314262&view=rev Log: Emit section information for extern variables. Currently, if _attribute_((section())) is used for extern variables, section information is not emitted in gene

r314267 - Fix capitalization of a bunch of parameters in SemaDeclAttr [NFC]

2017-09-26 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Sep 26 20:20:13 2017 New Revision: 314267 URL: http://llvm.org/viewvc/llvm-project?rev=314267&view=rev Log: Fix capitalization of a bunch of parameters in SemaDeclAttr [NFC] Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp Modified: cfe/trunk/lib/Sema/SemaDeclAttr.c

r314268 - Add test forgotten in r314262.

2017-09-26 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Sep 26 20:23:02 2017 New Revision: 314268 URL: http://llvm.org/viewvc/llvm-project?rev=314268&view=rev Log: Add test forgotten in r314262. Added: cfe/trunk/test/CodeGenCXX/extern-section-attribute.cpp (with props) Added: cfe/trunk/test/CodeGenCXX/extern-section

r314456 - Add Documentation to attribute-nothrow. Additionally, limit to functions.

2017-09-28 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Sep 28 13:08:03 2017 New Revision: 314456 URL: http://llvm.org/viewvc/llvm-project?rev=314456&view=rev Log: Add Documentation to attribute-nothrow. Additionally, limit to functions. Attribute nothrow is only allowed on functions, so I added that. Additionally, it lack

r314460 - Fix test change missed in r314456

2017-09-28 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Sep 28 13:23:43 2017 New Revision: 314460 URL: http://llvm.org/viewvc/llvm-project?rev=314460&view=rev Log: Fix test change missed in r314456 Modified: cfe/trunk/test/Misc/pragma-attribute-supported-attributes-list.test Modified: cfe/trunk/test/Misc/pragma-attrib

r314461 - [Sema] Warn on attribute nothrow conflicting with language specifiers

2017-09-28 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Sep 28 13:36:53 2017 New Revision: 314461 URL: http://llvm.org/viewvc/llvm-project?rev=314461&view=rev Log: [Sema] Warn on attribute nothrow conflicting with language specifiers I discovered it was possible to create a 'nothrow' noexcept(false) function, which is both

r314462 - [Sema] Correct nothrow inherited by noexcept

2017-09-28 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Sep 28 13:47:10 2017 New Revision: 314462 URL: http://llvm.org/viewvc/llvm-project?rev=314462&view=rev Log: [Sema] Correct nothrow inherited by noexcept As reported in https://bugs.llvm.org/show_bug.cgi?id=33235, a noexcept function was unable to inherit from a nothro

r314557 - [Sema] Correct IUnknown to support Unknwnbase.h Header.

2017-09-29 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Sep 29 14:06:00 2017 New Revision: 314557 URL: http://llvm.org/viewvc/llvm-project?rev=314557&view=rev Log: [Sema] Correct IUnknown to support Unknwnbase.h Header. Apparently, the MSVC SDK has a strange implementation that causes a number of implicit functions as well

r314687 - Update IUnknown lit test to pass on Win32

2017-10-02 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Oct 2 09:49:32 2017 New Revision: 314687 URL: http://llvm.org/viewvc/llvm-project?rev=314687&view=rev Log: Update IUnknown lit test to pass on Win32 Modified: cfe/trunk/test/SemaCXX/ms-iunknown-template-function.cpp Modified: cfe/trunk/test/SemaCXX/ms-iunknown-t

r314939 - Fix 'section' warning behavior with tentatively-defined values

2017-10-04 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Oct 4 15:16:24 2017 New Revision: 314939 URL: http://llvm.org/viewvc/llvm-project?rev=314939&view=rev Log: Fix 'section' warning behavior with tentatively-defined values As reported on cfe-commits, r314262 resulted in tentatively-defined variables not being excluded

r315075 - Split X86::BI__builtin_cpu_init handling into own function[NFC]

2017-10-06 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Oct 6 09:40:45 2017 New Revision: 315075 URL: http://llvm.org/viewvc/llvm-project?rev=315075&view=rev Log: Split X86::BI__builtin_cpu_init handling into own function[NFC] The Cpu Init functionality is required for the target attribute, so this patch simply splits it

r315638 - [Sema][Crash] Correctly handle an non-dependent noexcept expr in function template

2017-10-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Oct 12 16:01:53 2017 New Revision: 315638 URL: http://llvm.org/viewvc/llvm-project?rev=315638&view=rev Log: [Sema][Crash] Correctly handle an non-dependent noexcept expr in function template It seems that all of the other templated cases are handled correctly, howeve

r315929 - Clarify the 'interrupt' names in Attribute Docs

2017-10-16 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Oct 16 13:13:36 2017 New Revision: 315929 URL: http://llvm.org/viewvc/llvm-project?rev=315929&view=rev Log: Clarify the 'interrupt' names in Attribute Docs All 4 of the 'interrupt' headers were automatically named 'interrupt'. This patch gives them unique names. Modi

r315931 - Sort Attributes by "HeaderName"

2017-10-16 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Oct 16 13:31:05 2017 New Revision: 315931 URL: http://llvm.org/viewvc/llvm-project?rev=315931&view=rev Log: Sort Attributes by "HeaderName" Attributes in the docs were previously sorted (apparently) by the attribute name, so AnyX86Interrupt ended up being the first o

r315934 - Remove AnyX86Interrupt documentation

2017-10-16 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Oct 16 13:44:14 2017 New Revision: 315934 URL: http://llvm.org/viewvc/llvm-project?rev=315934&view=rev Log: Remove AnyX86Interrupt documentation This documentation was copied directly from the GCC documentaiton in r257867. Reverting and alterting the original author

r315950 - Replace usage of std::stringstream with raw_string_ostream

2017-10-16 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Oct 16 15:47:26 2017 New Revision: 315950 URL: http://llvm.org/viewvc/llvm-project?rev=315950&view=rev Log: Replace usage of std::stringstream with raw_string_ostream Typically we don't use the stringstream, so instead use raw_string_stream. Additionally, the depende

r315956 - Fix usage in TableGen of getValueAsString

2017-10-16 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Oct 16 16:25:24 2017 New Revision: 315956 URL: http://llvm.org/viewvc/llvm-project?rev=315956&view=rev Log: Fix usage in TableGen of getValueAsString Record::getValueAsString returns a stringref to an interned string (apparently had been changed since most of tablegen

r316015 - Replace use of SmallVector::back + pop_back with pop_back_val

2017-10-17 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Oct 17 10:45:21 2017 New Revision: 316015 URL: http://llvm.org/viewvc/llvm-project?rev=316015&view=rev Log: Replace use of SmallVector::back + pop_back with pop_back_val I ran across an instance where the value was being loaded out via back, then immediately popped.

r316030 - [CFG] Relax Wexceptions warning on rethrow

2017-10-17 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Oct 17 13:57:24 2017 New Revision: 316030 URL: http://llvm.org/viewvc/llvm-project?rev=316030&view=rev Log: [CFG] Relax Wexceptions warning on rethrow As reported here: https://bugs.llvm.org/show_bug.cgi?id=34973 "catch(...)" should catch EVERYTHING, even a rethrow.

r316132 - Fix capitalization of parameter

2017-10-18 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Oct 18 15:17:16 2017 New Revision: 316132 URL: http://llvm.org/viewvc/llvm-project?rev=316132&view=rev Log: Fix capitalization of parameter The .cpp file has this properly capitalized, but the header does not. Simply fixed it. Modified: cfe/trunk/include/clang/

r316166 - Fix nodiscard for volatile references

2017-10-19 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Oct 19 08:58:58 2017 New Revision: 316166 URL: http://llvm.org/viewvc/llvm-project?rev=316166&view=rev Log: Fix nodiscard for volatile references As reported here https://bugs.llvm.org/show_bug.cgi?id=34988 [[nodiscard]] warnings were not being suppressed for volatile

r316225 - Allow /showIncludes with /P

2017-10-20 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Oct 20 12:18:30 2017 New Revision: 316225 URL: http://llvm.org/viewvc/llvm-project?rev=316225&view=rev Log: Allow /showIncludes with /P r213589 was checked in as a solution to https://bugs.llvm.org/show_bug.cgi?id=20336. However, it is possible to use /EP with /P to

r316338 - Pull X86 "CPUKind" checking into .cpp file. [NFC]

2017-10-23 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Oct 23 09:20:15 2017 New Revision: 316338 URL: http://llvm.org/viewvc/llvm-project?rev=316338&view=rev Log: Pull X86 "CPUKind" checking into .cpp file. [NFC] Preparing to do a refactor of CPU/feature checking, this patch pulls the one CPU implementation from the .h fi

r316405 - Fix template parameter default args missed if redecled

2017-10-23 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Oct 23 18:39:56 2017 New Revision: 316405 URL: http://llvm.org/viewvc/llvm-project?rev=316405&view=rev Log: Fix template parameter default args missed if redecled This bug was found via self-build on lld, and worked around here: https://reviews.llvm.org/rL316180 The

r316437 - Add Forgotten test for: Fix template parameter default args missed if redecled

2017-10-24 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Oct 24 06:51:07 2017 New Revision: 316437 URL: http://llvm.org/viewvc/llvm-project?rev=316437&view=rev Log: Add Forgotten test for: Fix template parameter default args missed if redecled Addendum to differential revision: https://reviews.llvm.org/D39127 Added: cf

r316447 - Fix spelling in comment, field is isMsStruct, not Strust

2017-10-24 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Oct 24 08:34:59 2017 New Revision: 316447 URL: http://llvm.org/viewvc/llvm-project?rev=316447&view=rev Log: Fix spelling in comment, field is isMsStruct, not Strust Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: ht

r316453 - Remove repeated function name in doxygen comment.

2017-10-24 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Oct 24 09:16:34 2017 New Revision: 316453 URL: http://llvm.org/viewvc/llvm-project?rev=316453&view=rev Log: Remove repeated function name in doxygen comment. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: http://ll

r316518 - mplement __has_unique_object_representations

2017-10-24 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Oct 24 14:31:50 2017 New Revision: 316518 URL: http://llvm.org/viewvc/llvm-project?rev=316518&view=rev Log: mplement __has_unique_object_representations A helper builtin to facilitate implementing the std::has_unique_object_representations type trait. Requested here:

r316521 - Replaced unicode characters with ASCII, as introduced in r316518.

2017-10-24 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Oct 24 15:00:25 2017 New Revision: 316521 URL: http://llvm.org/viewvc/llvm-project?rev=316521&view=rev Log: Replaced unicode characters with ASCII, as introduced in r316518. Modified: cfe/trunk/lib/AST/Type.cpp Modified: cfe/trunk/lib/AST/Type.cpp URL: http://ll

r316528 - Correct behavior of fastcall when default CC is set.

2017-10-24 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Oct 24 16:12:01 2017 New Revision: 316528 URL: http://llvm.org/viewvc/llvm-project?rev=316528&view=rev Log: Correct behavior of fastcall when default CC is set. Fastcall doesn't support variadic function calls, so setting the default calling convention to Fastcall wou

r341484 - Test Commit for git-svn-cleanup comment.

2018-09-05 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Sep 5 10:14:21 2018 New Revision: 341484 URL: http://llvm.org/viewvc/llvm-project?rev=341484&view=rev Log: Test Commit for git-svn-cleanup comment. Removes the class name for the Expr class, which isn't necessary. Modified: cfe/trunk/include/clang/AST/Expr.h Mo

r341833 - Prevent cpu-specific/cpu-dispatch from giong on a lambda.

2018-09-10 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Sep 10 07:31:56 2018 New Revision: 341833 URL: http://llvm.org/viewvc/llvm-project?rev=341833&view=rev Log: Prevent cpu-specific/cpu-dispatch from giong on a lambda. It is non-sensical to use cpu-specific/cpu-dispatch multiversioning on a lambda, so prevent it when tr

r341862 - Move AESNI generation to Skylake and Goldmont

2018-09-10 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Sep 10 14:12:21 2018 New Revision: 341862 URL: http://llvm.org/viewvc/llvm-project?rev=341862&view=rev Log: Move AESNI generation to Skylake and Goldmont The instruction set first appeared with Westmere, but not all processors in that and the next few generations have

r341871 - Fix test regression in r341862

2018-09-10 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Sep 10 14:57:53 2018 New Revision: 341871 URL: http://llvm.org/viewvc/llvm-project?rev=341871&view=rev Log: Fix test regression in r341862 The commit updates when AES is enabled, but failed to update the tests. This patch fixes them. Modified: cfe/trunk/test/Code

r342152 - [NFC]Refactor MultiVersion Resolver Emission to combine types

2018-09-13 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Sep 13 09:58:24 2018 New Revision: 342152 URL: http://llvm.org/viewvc/llvm-project?rev=342152&view=rev Log: [NFC]Refactor MultiVersion Resolver Emission to combine types Previously, both types (plus the future target-clones) of multiversioning had a separate ResolverO

r337454 - Enable C++2a Chrono Literals

2018-07-19 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Jul 19 06:36:57 2018 New Revision: 337454 URL: http://llvm.org/viewvc/llvm-project?rev=337454&view=rev Log: Enable C++2a Chrono Literals C++2a via http://wg21.link/p0355 permits the library literals of 'd' and 'y'. This patch enables them in the Lexer so that they can

r337473 - Fix unused variable warning.

2018-07-19 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Jul 19 10:19:16 2018 New Revision: 337473 URL: http://llvm.org/viewvc/llvm-project?rev=337473&view=rev Log: Fix unused variable warning. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp URL: http://llvm.org/

r337552 - Implement cpu_dispatch/cpu_specific Multiversioning

2018-07-20 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jul 20 07:13:28 2018 New Revision: 337552 URL: http://llvm.org/viewvc/llvm-project?rev=337552&view=rev Log: Implement cpu_dispatch/cpu_specific Multiversioning As documented here: https://software.intel.com/en-us/node/682969 and https://software.intel.com/en-us/node/5

r337585 - Prevent Scoped Enums from being Integral constant expressions:

2018-07-20 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jul 20 10:42:09 2018 New Revision: 337585 URL: http://llvm.org/viewvc/llvm-project?rev=337585&view=rev Log: Prevent Scoped Enums from being Integral constant expressions: Discovered because of: https://bugs.llvm.org/show_bug.cgi?id=38235 It seems to me that a scoped

r337738 - Update to -r337585, allow scoped enum inits in -pedantic

2018-07-23 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Jul 23 14:08:13 2018 New Revision: 337738 URL: http://llvm.org/viewvc/llvm-project?rev=337738&view=rev Log: Update to -r337585, allow scoped enum inits in -pedantic Modified: cfe/trunk/include/clang/AST/Type.h cfe/trunk/lib/AST/Type.cpp cfe/trunk/lib/Sema/

r337835 - Remove stale documentation from InternalsManual.rst

2018-07-24 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Jul 24 09:11:30 2018 New Revision: 337835 URL: http://llvm.org/viewvc/llvm-project?rev=337835&view=rev Log: Remove stale documentation from InternalsManual.rst The DuplicatesAllowedWhileMerging was removed a while ago, but the documentation remained. Modified: cf

r338630 - [AST][1/4] Move the bit-fields from TagDecl, EnumDecl and RecordDecl into DeclContext

2018-08-01 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Aug 1 13:48:16 2018 New Revision: 338630 URL: http://llvm.org/viewvc/llvm-project?rev=338630&view=rev Log: [AST][1/4] Move the bit-fields from TagDecl, EnumDecl and RecordDecl into DeclContext DeclContext has a little less than 8 bytes free due to the alignment requ

r338636 - [AST][2/4] Move the bit-fields from FunctionDecl and CXXConstructorDecl into DeclContext

2018-08-01 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Aug 1 14:02:40 2018 New Revision: 338636 URL: http://llvm.org/viewvc/llvm-project?rev=338636&view=rev Log: [AST][2/4] Move the bit-fields from FunctionDecl and CXXConstructorDecl into DeclContext This patch follows https://reviews.llvm.org/D49729 and is followed by

r338639 - [AST][3/4] Move the bit-fields from BlockDecl, LinkageSpecDecl and OMPDeclareReductionDecl into DeclContext

2018-08-01 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Aug 1 14:16:54 2018 New Revision: 338639 URL: http://llvm.org/viewvc/llvm-project?rev=338639&view=rev Log: [AST][3/4] Move the bit-fields from BlockDecl, LinkageSpecDecl and OMPDeclareReductionDecl into DeclContext This patch follows https://reviews.llvm.org/D49729

r338641 - [AST][4/4] Move the bit-fields from ObjCMethodDecl and ObjCContainerDecl into DeclContext

2018-08-01 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Aug 1 14:31:08 2018 New Revision: 338641 URL: http://llvm.org/viewvc/llvm-project?rev=338641&view=rev Log: [AST][4/4] Move the bit-fields from ObjCMethodDecl and ObjCContainerDecl into DeclContext This patch follows https://reviews.llvm.org/D49729, https://reviews.l

r338884 - [NFC] Silence unused variable warning in Attr.td/AttrParsedAttrImpl.inc

2018-08-03 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Aug 3 06:01:32 2018 New Revision: 338884 URL: http://llvm.org/viewvc/llvm-project?rev=338884&view=rev Log: [NFC] Silence unused variable warning in Attr.td/AttrParsedAttrImpl.inc Modified: cfe/trunk/include/clang/Basic/Attr.td Modified: cfe/trunk/include/clang/B

r338886 - [NFC] Fix unused expression warning introduced in r338884

2018-08-03 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Aug 3 06:23:04 2018 New Revision: 338886 URL: http://llvm.org/viewvc/llvm-project?rev=338886&view=rev Log: [NFC] Fix unused expression warning introduced in r338884 Modified: cfe/trunk/include/clang/Basic/Attr.td Modified: cfe/trunk/include/clang/Basic/Attr.td U

r338889 - [NFCI] My attempt to fix a warning in r338886 broke the build! Fix it.

2018-08-03 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Aug 3 06:51:35 2018 New Revision: 338889 URL: http://llvm.org/viewvc/llvm-project?rev=338889&view=rev Log: [NFCI] My attempt to fix a warning in r338886 broke the build! Fix it. Clang format got the best of me... it introduced spaces around something in a table-genn

r338893 - revert r338831 - Fix unused variable warning in tablegen generated code

2018-08-03 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Aug 3 07:24:34 2018 New Revision: 338893 URL: http://llvm.org/viewvc/llvm-project?rev=338893&view=rev Log: revert r338831 - Fix unused variable warning in tablegen generated code No longer necessary thanks to r338889 (and friends). Modified: cfe/trunk/utils/Tabl

r338909 - [NFC] Initialize a variable to prevent future invalid deref.

2018-08-03 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Aug 3 11:08:36 2018 New Revision: 338909 URL: http://llvm.org/viewvc/llvm-project?rev=338909&view=rev Log: [NFC] Initialize a variable to prevent future invalid deref. Found by KlockWorks, this variable is properly protected, however the conditions in the test that i

r324430 - [NFC] Correct a typo'ed comment and reworded, since it is awkward.

2018-02-06 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Feb 6 16:19:58 2018 New Revision: 324430 URL: http://llvm.org/viewvc/llvm-project?rev=324430&view=rev Log: [NFC] Correct a typo'ed comment and reworded, since it is awkward. Modified: cfe/trunk/lib/Driver/Driver.cpp Modified: cfe/trunk/lib/Driver/Driver.cpp URL

r324433 - [NFC] Change odd cast-through-unknown behavior to an Optional

2018-02-06 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Feb 6 16:37:19 2018 New Revision: 324433 URL: http://llvm.org/viewvc/llvm-project?rev=324433&view=rev Log: [NFC] Change odd cast-through-unknown behavior to an Optional This bit of code in the driver uses '~0U' as a sentinel value. The result is an odd mishmash of ca

r324540 - [NFCi] Replace a couple of usages of const StringRef& with StringRef

2018-02-07 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Feb 7 15:04:38 2018 New Revision: 324540 URL: http://llvm.org/viewvc/llvm-project?rev=324540&view=rev Log: [NFCi] Replace a couple of usages of const StringRef& with StringRef No sense passing these by reference when a copy is about as free, and saves on potential in

r324644 - Fix improper indentation issue in CodeGenModule [NFC]

2018-02-08 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Feb 8 12:04:22 2018 New Revision: 324644 URL: http://llvm.org/viewvc/llvm-project?rev=324644&view=rev Log: Fix improper indentation issue in CodeGenModule [NFC] Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp U

r324673 - Make march/target-cpu print a note with the list of valid values for ARM

2018-02-08 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Feb 8 15:14:15 2018 New Revision: 324673 URL: http://llvm.org/viewvc/llvm-project?rev=324673&view=rev Log: Make march/target-cpu print a note with the list of valid values for ARM When rejecting a march= or target-cpu command line parameter, the message is quite lack

r324674 - Add X86 Support to ValidCPUList (enabling march notes)

2018-02-08 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Feb 8 15:15:02 2018 New Revision: 324674 URL: http://llvm.org/viewvc/llvm-project?rev=324674&view=rev Log: Add X86 Support to ValidCPUList (enabling march notes) A followup to: https://reviews.llvm.org/D42978 This patch adds X86 and X86_64 support for enabling the ma

r324675 - Add NVPTX Support to ValidCPUList (enabling march notes)

2018-02-08 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Feb 8 15:16:00 2018 New Revision: 324675 URL: http://llvm.org/viewvc/llvm-project?rev=324675&view=rev Log: Add NVPTX Support to ValidCPUList (enabling march notes) A followup to: https://reviews.llvm.org/D42978 This patch adds NVPTX support for enabling the march not

r324676 - Add Rest of Targets Support to ValidCPUList (enabling march notes)

2018-02-08 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Feb 8 15:16:55 2018 New Revision: 324676 URL: http://llvm.org/viewvc/llvm-project?rev=324676&view=rev Log: Add Rest of Targets Support to ValidCPUList (enabling march notes) A followup to: https://reviews.llvm.org/D42978 Most of the rest of the Targets were pretty r

r324682 - Add size to constexpr Arrays

2018-02-08 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Feb 8 15:49:40 2018 New Revision: 324682 URL: http://llvm.org/viewvc/llvm-project?rev=324682&view=rev Log: Add size to constexpr Arrays What seems to be a bug in older versions of MSVC, constexpr member arrays with a redefinition (to force emission) require their ini

r324687 - Fix UBSan issue with PPC::isValidCPUName

2018-02-08 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Feb 8 16:13:49 2018 New Revision: 324687 URL: http://llvm.org/viewvc/llvm-project?rev=324687&view=rev Log: Fix UBSan issue with PPC::isValidCPUName Apparently storing the pointer to a StringLiteral as a StringRef caused this section of code to issue a ubsan warning.

r324902 - Add Invalid-note test negllected in R324673, 324674, 324675, 324676

2018-02-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Feb 12 08:24:08 2018 New Revision: 324902 URL: http://llvm.org/viewvc/llvm-project?rev=324902&view=rev Log: Add Invalid-note test negllected in R324673,324674,324675,324676 Added: cfe/trunk/test/Misc/target-invalid-cpu-note.c Added: cfe/trunk/test/Misc/target-inv

r324907 - Make attribute-target on a Definition-after-use update the LLVM attributes

2018-02-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Feb 12 09:01:41 2018 New Revision: 324907 URL: http://llvm.org/viewvc/llvm-project?rev=324907&view=rev Log: Make attribute-target on a Definition-after-use update the LLVM attributes As reported here: https://bugs.llvm.org/show_bug.cgi?id=36301 The issue is that the '

r324909 - Update target-note-test to be current with the AMDGPU changes

2018-02-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Feb 12 09:19:57 2018 New Revision: 324909 URL: http://llvm.org/viewvc/llvm-project?rev=324909&view=rev Log: Update target-note-test to be current with the AMDGPU changes Modified: cfe/trunk/test/Misc/target-invalid-cpu-note.c Modified: cfe/trunk/test/Misc/target-

r324915 - Further cleanup to Driver mode code, as suggested by dblaikie [NFC]

2018-02-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Feb 12 09:47:01 2018 New Revision: 324915 URL: http://llvm.org/viewvc/llvm-project?rev=324915&view=rev Log: Further cleanup to Driver mode code, as suggested by dblaikie [NFC] Modified: cfe/trunk/lib/Driver/Driver.cpp Modified: cfe/trunk/lib/Driver/Driver.cpp URL

r325081 - Implement function attribute artificial

2018-02-13 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Feb 13 16:14:07 2018 New Revision: 325081 URL: http://llvm.org/viewvc/llvm-project?rev=325081&view=rev Log: Implement function attribute artificial Added support in clang for GCC function attribute 'artificial'. This attribute is used to control stepping behavior of

r325186 - Improve documentation for attribute artificial

2018-02-14 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Feb 14 15:00:31 2018 New Revision: 325186 URL: http://llvm.org/viewvc/llvm-project?rev=325186&view=rev Log: Improve documentation for attribute artificial This patch is related to https://reviews.llvm.org/rC325081 The patch improves documentation for the attribute an

r325364 - Clean up 'target' attribute diagnostics

2018-02-16 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Feb 16 09:31:59 2018 New Revision: 325364 URL: http://llvm.org/viewvc/llvm-project?rev=325364&view=rev Log: Clean up 'target' attribute diagnostics There were a few issues previously with the target attribute diagnostics implementation that lead to the attribute being

r325610 - Correct multiversion unsupported target behavior, add a test.

2018-02-20 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Feb 20 10:44:50 2018 New Revision: 325610 URL: http://llvm.org/viewvc/llvm-project?rev=325610&view=rev Log: Correct multiversion unsupported target behavior, add a test. Multiversioning SEMA failed to set the declaration as invalid on unsupported targets. This patch

r325633 - [NFC] In Multiversion Check function, switch to return Diag

2018-02-20 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Feb 20 14:25:28 2018 New Revision: 325633 URL: http://llvm.org/viewvc/llvm-project?rev=325633&view=rev Log: [NFC] In Multiversion Check function, switch to return Diag This function did a lot of 'Diag, return true' stuff. This resulted in needing to introduce scopes

r325716 - Replace incorrect usage of isInvalidDecl with intended setInvalidDecl

2018-02-21 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Feb 21 12:29:05 2018 New Revision: 325716 URL: http://llvm.org/viewvc/llvm-project?rev=325716&view=rev Log: Replace incorrect usage of isInvalidDecl with intended setInvalidDecl This typo would cause an attempt to multiversion 'main' to issue an error, but not mark t

r303798 - For Microsoft compatibility, set fno_operator_names

2017-05-24 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed May 24 14:31:19 2017 New Revision: 303798 URL: http://llvm.org/viewvc/llvm-project?rev=303798&view=rev Log: For Microsoft compatibility, set fno_operator_names There's a Microsoft header in the Windows SDK which won't compile with clang because it uses an operator na

[clang-tools-extra] r303872 - Disable MSVC-Compat mode for two tests that use C++Operator Names

2017-05-25 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu May 25 10:39:24 2017 New Revision: 303872 URL: http://llvm.org/viewvc/llvm-project?rev=303872&view=rev Log: Disable MSVC-Compat mode for two tests that use C++Operator Names MSVC doesn't support C++ operator names (using 'or' instead of ||, 'not' instead of '!', etc)

[clang-tools-extra] r303877 - Clang-tidy doesn't understand -fno-ms-compatibility, so just removing 'not'

2017-05-25 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu May 25 11:07:19 2017 New Revision: 303877 URL: http://llvm.org/viewvc/llvm-project?rev=303877&view=rev Log: Clang-tidy doesn't understand -fno-ms-compatibility, so just removing 'not' Modified: clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cas

[clang-tools-extra] r303881 - Revert 303872/303877 since the patch that caused these issues

2017-05-25 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu May 25 11:23:00 2017 New Revision: 303881 URL: http://llvm.org/viewvc/llvm-project?rev=303881&view=rev Log: Revert 303872/303877 since the patch that caused these issues is also being reverted. Modified: clang-tools-extra/trunk/test/clang-tidy/readability-implic

r303882 - Revert MSVC CXXOperatorNames patch due to issues with Chromium

2017-05-25 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu May 25 11:24:49 2017 New Revision: 303882 URL: http://llvm.org/viewvc/llvm-project?rev=303882&view=rev Log: Revert MSVC CXXOperatorNames patch due to issues with Chromium Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp cfe/trunk/test/Parser/MicrosoftEx

[clang-tools-extra] r303909 - Earlier revert introduced an extra space, remove it.

2017-05-25 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu May 25 15:29:17 2017 New Revision: 303909 URL: http://llvm.org/viewvc/llvm-project?rev=303909&view=rev Log: Earlier revert introduced an extra space, remove it. Modified: clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cast.cpp Modified: clang-

r305087 - support operator keywords used in Windows SDK

2017-06-09 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jun 9 11:29:35 2017 New Revision: 305087 URL: http://llvm.org/viewvc/llvm-project?rev=305087&view=rev Log: support operator keywords used in Windows SDK to support operator keywords used in Windows SDK, alter token type when seen in system headers Hello, I submitte

r305128 - Support operator keywords used in Windows SDK(fix ubsan)

2017-06-09 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jun 9 17:50:02 2017 New Revision: 305128 URL: http://llvm.org/viewvc/llvm-project?rev=305128&view=rev Log: Support operator keywords used in Windows SDK(fix ubsan) UBSan found an issue with a nullptr being assigned to a reference. This was because a following functio

r305425 - [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments,

2017-06-14 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Jun 14 18:09:01 2017 New Revision: 305425 URL: http://llvm.org/viewvc/llvm-project?rev=305425&view=rev Log: [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments, correct getNumArguments StringifiedArguments is allocated (resized) based on the size the

[clang-tools-extra] r305426 - Update callbacks tracker to match change in 305425

2017-06-14 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Jun 14 18:15:51 2017 New Revision: 305426 URL: http://llvm.org/viewvc/llvm-project?rev=305426&view=rev Log: Update callbacks tracker to match change in 305425 Modified: clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp Modified: clang-tools-extra/trunk/pp-t

[clang-tools-extra] r305434 - Update Append Argument to more efficiently traverse tokens

2017-06-14 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Jun 14 19:27:23 2017 New Revision: 305434 URL: http://llvm.org/viewvc/llvm-project?rev=305434&view=rev Log: Update Append Argument to more efficiently traverse tokens This function was previously making (correct) assumptions without complete knowledge of MacroArgs gua

r305435 - Fix LexerTest signed/unsigned comparison.

2017-06-14 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Jun 14 19:28:13 2017 New Revision: 305435 URL: http://llvm.org/viewvc/llvm-project?rev=305435&view=rev Log: Fix LexerTest signed/unsigned comparison. Werror was catching a signed/unsigned compare in an assert, correct the signed 'expected' value to be unsigned. Modi

r305491 - LexerTest memory leak fix-

2017-06-15 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Jun 15 13:34:47 2017 New Revision: 305491 URL: http://llvm.org/viewvc/llvm-project?rev=305491&view=rev Log: LexerTest memory leak fix- A new LexerTest unittest introduced a memory leak. This patch uses a unique_ptr with a custom deleter to ensure it is properly delet

r305812 - Fix for Bug 33471: Preventing operator auto from resolving to a template operator.

2017-06-20 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Jun 20 12:38:07 2017 New Revision: 305812 URL: http://llvm.org/viewvc/llvm-project?rev=305812&view=rev Log: Fix for Bug 33471: Preventing operator auto from resolving to a template operator. As the bug report says, struct A { template operator T(); }; void foo()

r305928 - Correct VectorCall x86 (32 bit) behavior for SSE Register Assignment

2017-06-21 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Jun 21 11:37:22 2017 New Revision: 305928 URL: http://llvm.org/viewvc/llvm-project?rev=305928&view=rev Log: Correct VectorCall x86 (32 bit) behavior for SSE Register Assignment In running some internal vectorcall tests in 32 bit mode, we discovered that the behavior

r306149 - Emit warning when throw exception in destruct or dealloc functions which has a

2017-06-23 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Jun 23 15:22:19 2017 New Revision: 306149 URL: http://llvm.org/viewvc/llvm-project?rev=306149&view=rev Log: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier Throwing in the destructor is not good (C

  1   2   3   4   5   6   7   8   9   10   >