ioeric updated this revision to Diff 61824.
ioeric added a comment.
- Addressed reviewer's recomments in the other patch.
http://reviews.llvm.org/D21602
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/tool/ClangIncludeFixer.cpp
unittests/clang-tidy/Clang
ioeric updated this revision to Diff 61823.
ioeric added a comment.
- Addressed reviewer's comments
http://reviews.llvm.org/D21601
Files:
include/clang/Format/Format.h
include/clang/Tooling/Core/Replacement.h
lib/Format/Format.cpp
lib/Tooling/Core/Replacement.cpp
lib/Tooling/Refactori
ioeric created this revision.
ioeric added a reviewer: bkramer.
ioeric added subscribers: hokein, cfe-commits.
this enables us to map a group of headers to one header name,
e.g. headers from one directory can be mapped to the same header.
http://reviews.llvm.org/D21787
Files:
include-fixer/fin
ioeric marked 3 inline comments as done.
ioeric added a comment.
Friendly ping
http://reviews.llvm.org/D21601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added a comment.
Ping
http://reviews.llvm.org/D21601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added a comment.
Ping
http://reviews.llvm.org/D21602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 62352.
ioeric added a comment.
- Always handle error.
http://reviews.llvm.org/D21602
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/tool/ClangIncludeFixer.cpp
unittests/clang-tidy/ClangTidyTest.h
unittests/include-
ioeric added a comment.
Ping
http://reviews.llvm.org/D21787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added inline comments.
Comment at: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp:16
@@ -15,2 +15,3 @@
const HeaderMapCollector::HeaderMap *getSTLPostfixHeaderMap() {
static const HeaderMapCollector::HeaderMap STLPostfixHeaderMap = {
+ {"include/__stddef_ma
ioeric updated this revision to Diff 62656.
ioeric marked an inline comment as done.
ioeric added a comment.
- Change RegexHeaderMap from StringMap to std::vector>.
http://reviews.llvm.org/D21787
Files:
include-fixer/find-all-symbols/FindAllSymbolsAction.cpp
include-fixer/find-all-symbols/F
Author: ioeric
Date: Mon Jul 4 06:22:35 2016
New Revision: 274494
URL: http://llvm.org/viewvc/llvm-project?rev=274494&view=rev
Log:
[include-fixer] make HeaderMapCollector maps from regex instead of postfix.
Summary:
this enables us to map a group of headers to one header name,
e.g. headers from
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274494: [include-fixer] make HeaderMapCollector maps from
regex instead of postfix. (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D21787?vs=62656&id=62664#toc
Repository:
rL
Author: ioeric
Date: Mon Jul 4 06:42:37 2016
New Revision: 274495
URL: http://llvm.org/viewvc/llvm-project?rev=274495&view=rev
Log:
Fix broken build caused by r274494.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/HeaderMapCollector.h
Modified:
clang-tools-extra/trunk/in
ioeric added a comment.
PING
http://reviews.llvm.org/D21601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Mon Jul 4 08:34:11 2016
New Revision: 274501
URL: http://llvm.org/viewvc/llvm-project?rev=274501&view=rev
Log:
[include-fixer] reduce stack size by changing RegexHeaderMap to use const char
* pair.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/HeaderM
ioeric updated this revision to Diff 62685.
ioeric marked an inline comment as done.
ioeric added a comment.
- Addressed reviewer's comment.
http://reviews.llvm.org/D21602
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/tool/ClangIncludeFixer.cpp
unittes
ioeric added inline comments.
Comment at: clang-rename/tool/clang-rename.py:12
@@ +11,3 @@
+
+map ,cf :pyf /clang-include-fixer.py
+
Maybe a different key binding so that it doesn't conflict with include-fixer's
suggested key binding? `,cr` for clang-rename m
ioeric updated this revision to Diff 63504.
ioeric added a comment.
- Merged with origin/master. Resolved a few conflicts.
http://reviews.llvm.org/D21602
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/tool/ClangIncludeFixer.cpp
unittests/clang-tidy/Clan
Author: ioeric
Date: Mon Jul 11 08:53:12 2016
New Revision: 275062
URL: http://llvm.org/viewvc/llvm-project?rev=275062&view=rev
Log:
Make tooling::applyAllReplacements return llvm::Expected instead of
empty string to indicate potential error.
Summary:
return llvm::Expected<> to carry error statu
Author: ioeric
Date: Mon Jul 11 08:53:21 2016
New Revision: 275063
URL: http://llvm.org/viewvc/llvm-project?rev=275063&view=rev
Log:
Changes related to tooling::applyAllReplacements interface change in D21601.
Summary:
this patch contains changes related to the interface change from
http://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275062: Make tooling::applyAllReplacements return
llvm::Expected instead of… (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D21601?vs=61823&id=63505#toc
Repository:
rL LLVM
h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275063: Changes related to tooling::applyAllReplacements
interface change in D21601. (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D21602?vs=63504&id=63506#toc
Repository:
rL
ioeric updated this revision to Diff 64016.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- Merge branch 'master' of http://llvm.org/git/clang into replace
- Addressed reviewer's comments.
https://reviews.llvm.org/D21748
Files:
include/clang/Tooling/Core/Replacement.h
inc
ioeric updated this revision to Diff 64015.
ioeric added a comment.
- merged with origin/master
- Addressed reviewer's comments in the corresponding patch.
https://reviews.llvm.org/D21749
Files:
clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h
clang-app
ioeric added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:300
@@ +299,3 @@
+Replacements Replacements::merge(const Replacement &R) const {
+ Replacements Rs;
+ llvm::consumeError(Rs.add(R));
klimek wrote:
> I'd probably add a single-replacement
ioeric updated this revision to Diff 49355.
ioeric marked 8 inline comments as done.
ioeric added a comment.
- removed applyAllReplacementsAndFormat with Rewritter interface. reduced the
column limit in test case; some formatting.
http://reviews.llvm.org/D17704
Files:
include/clang/Tooling/C
ioeric created this revision.
ioeric added a reviewer: klimek.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Merge branch 'master' of http://llvm.org/git/clang
http://reviews.llvm.org/D17704
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replace
ioeric updated this revision to Diff 49359.
ioeric marked an inline comment as done.
ioeric added a comment.
- return Replacements() instead of the empty Replaces.
http://reviews.llvm.org/D17704
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unittests/Too
ioeric created this revision.
ioeric added a reviewer: klimek.
ioeric added subscribers: klimek, cfe-commits.
Merge branch 'master' of http://llvm.org/git/clang
Moved applyAllReplacementsAndFormat to clangFormat to avoid cyclic dependency.
http://reviews.llvm.org/D17727
Files:
include/clang/Fo
ioeric updated this revision to Diff 49470.
ioeric marked 5 inline comments as done.
ioeric added a comment.
- Fixed commenting.
http://reviews.llvm.org/D17727
Files:
include/clang/Format/Format.h
include/clang/Tooling/Core/Replacement.h
lib/Format/Format.cpp
lib/Tooling/Core/Replacemen
ioeric created this revision.
ioeric added a reviewer: klimek.
ioeric added subscribers: klimek, cfe-commits.
Added applyAllReplacementsAndFormat that works for multiple files.
http://reviews.llvm.org/D17761
Files:
include/clang/Format/Format.h
include/clang/Tooling/Core/Replacement.h
lib/
ioeric updated this revision to Diff 49487.
ioeric added a comment.
- Fixed commenting issue due to merge.
http://reviews.llvm.org/D17761
Files:
include/clang/Format/Format.h
include/clang/Tooling/Core/Replacement.h
lib/Format/CMakeLists.txt
lib/Format/Format.cpp
lib/Tooling/Core/Repl
ioeric updated this revision to Diff 49493.
ioeric added a comment.
- Added getOrCreateFileID interface in SourceManager.
http://reviews.llvm.org/D17761
Files:
include/clang/Basic/SourceManager.h
include/clang/Format/Format.h
include/clang/Tooling/Core/Replacement.h
lib/Format/CMakeList
ioeric updated this revision to Diff 49619.
ioeric added a comment.
- Removed all applyAllReplacementsAndFormat(*); added formatRewrittenCode in
clangTooling.
http://reviews.llvm.org/D17761
Files:
include/clang/Basic/SourceManager.h
include/clang/Format/Format.h
include/clang/Tooling/Cor
ioeric updated this revision to Diff 49620.
ioeric added a comment.
- Removed definitions that were forgotten.
http://reviews.llvm.org/D17761
Files:
include/clang/Basic/SourceManager.h
include/clang/Format/Format.h
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Replaceme
ioeric abandoned this revision.
ioeric added a comment.
Start a new revision to put applyAllReplacementsAndFormat into non-core
libTooling .
http://reviews.llvm.org/D17761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
ioeric created this revision.
ioeric added reviewers: klimek, djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
formatAndApplyAllReplacements takes a set of Replacements, applies them on a
Rewriter, and reformats the changed code.
http://reviews.llvm.org/D17852
ioeric updated this revision to Diff 49806.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Moved formatAndApplyAllReplacements to Tooling/Refactoing; added an
overloaded version of formatAndApplyAllReplacements that takes no Style;
groupReplacementsByFile groups Replacements
ioeric added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:237
@@ +236,3 @@
+/// related to the same file entry are put into the same vector.
+FileToReplacementsMap groupReplacementsByFile(const Replacements &Replaces,
+
ioeric updated this revision to Diff 49807.
ioeric added a comment.
- removed unused forward declarations.
http://reviews.llvm.org/D17852
Files:
include/clang/Basic/SourceManager.h
include/clang/Format/Format.h
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
ioeric marked an inline comment as done.
Comment at: include/clang/Tooling/Core/Replacement.h:228
@@ -226,3 +227,3 @@
/// \pre Replacements must be for the same file.
-std::vector
-calculateChangedRangesInFile(const tooling::Replacements &Replaces);
+std::vector calculateChangedR
ioeric added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:230
@@ +229,3 @@
+
+typedef std::map
+FileToReplacementsMap;
djasper wrote:
> ioeric wrote:
> > djasper wrote:
> > > I think the key type in a map is always const, so no need fo
Friendly PING.
@klimek
Hi Manuel, what do you think about the return type for
groupReplacementsByFile?
Daniel suggests that instead of "std::map", it
returns "std::vector".
On Sun, Mar 6, 2016 at 9:32 PM Eric Liu wrote:
> ioeric added inline comments.
>
>
> Comment at: include/
ioeric updated this revision to Diff 50627.
ioeric marked 10 inline comments as done.
ioeric added a comment.
- renamed calculateChangedRangesInFile to calculateChangedRanges; removed const
from FileToReplacementsMap key type.
http://reviews.llvm.org/D17852
Files:
include/clang/Basic/SourceM
PING
On Mon, Mar 14, 2016 at 8:18 PM Eric Liu wrote:
> ioeric updated this revision to Diff 50627.
> ioeric marked 10 inline comments as done.
> ioeric added a comment.
>
> - renamed calculateChangedRangesInFile to calculateChangedRanges; removed
> const from FileToReplacementsMap key type.
>
>
ioeric added inline comments.
Comment at: lib/Tooling/Refactoring.cpp:90
@@ +89,3 @@
+
+// FIXME: duplicated code here. Any better way to overload?
+bool formatAndApplyAllReplacements(const Replacements &Replaces,
klimek wrote:
> Just call the above with the forma
ioeric added inline comments.
Comment at: lib/Tooling/Refactoring.cpp:90
@@ +89,3 @@
+
+// FIXME: duplicated code here. Any better way to overload?
+bool formatAndApplyAllReplacements(const Replacements &Replaces,
klimek wrote:
> ioeric wrote:
> > klimek wrote:
>
ioeric updated this revision to Diff 51166.
ioeric marked 8 inline comments as done.
ioeric added a comment.
- removed FileToReplacementsMap typedef; refactored formatAndApplyReplacements
to reduce duplicated code.
http://reviews.llvm.org/D17852
Files:
include/clang/Basic/SourceManager.h
i
ioeric added inline comments.
Comment at: unittests/Tooling/RefactoringTest.cpp:206
@@ +205,3 @@
+TEST_F(ReplacementTest, ReplaceAndFormatNoStyle) {
+ std::string Code = "MyType012345678901234567890123456789 *a =\n"
+ "new MyType012345678901234567890123456
Just wanted to check if there are existing test cases for format::getStyle.
If there is no test for it, I'll add test cases for sure :=)
On Mon, Mar 21, 2016, 21:20 Manuel Klimek wrote:
> On Mon, Mar 21, 2016 at 6:36 PM Eric Liu wrote:
>
>> ioeric added inline comments.
>>
>>
>
ioeric created this revision.
ioeric added reviewers: klimek, djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Previously, format::getStyle assumes that the given file resides in
the real file system, which prevents the use of virtual file system in testing
etc.
ioeric updated this revision to Diff 51426.
ioeric added a comment.
- removed redundant code.
http://reviews.llvm.org/D18399
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
ioeric updated this revision to Diff 51431.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- some more redundancy removed
http://reviews.llvm.org/D18399
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/Fo
ioeric updated this revision to Diff 51433.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- removed format::getStyle test case from ToolingTests;
http://reviews.llvm.org/D17852
Files:
include/clang/Basic/SourceManager.h
include/clang/Format/Format.h
include/clang/Toolin
ioeric updated this revision to Diff 51440.
ioeric added a comment.
- changed c_str() to str()
http://reviews.llvm.org/D18399
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
ioeric created this revision.
ioeric added a reviewer: cfe-commits.
Herald added a subscriber: klimek.
Test commit access to clang repo.
http://reviews.llvm.org/D18432
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
===
ioeric closed this revision.
ioeric added a comment.
I should have submitted to llvm-commits instead of cfe-commits.
http://reviews.llvm.org/D18432
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Author: ioeric
Date: Thu Mar 24 05:21:00 2016
New Revision: 264252
URL: http://llvm.org/viewvc/llvm-project?rev=264252&view=rev
Log:
Test commit access to clang repo.
Summary: Test commit access to clang repo.
Reviewers: cfe-commits
Subscribers: klimek
Differential Revision: http://reviews.llv
Author: ioeric
Date: Thu Mar 24 05:50:17 2016
New Revision: 264253
URL: http://llvm.org/viewvc/llvm-project?rev=264253&view=rev
Log:
Added support for different VFSs in format::getStyle.
Summary:
Previously, format::getStyle assumes that the given file resides in
the real file system, which preve
Author: ioeric
Date: Thu Mar 24 05:50:26 2016
New Revision: 264254
URL: http://llvm.org/viewvc/llvm-project?rev=264254&view=rev
Log:
removed redundant comment in format::getStyle.
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/Format.cpp
URL:
http://llvm.org/viewvc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264253: Added support for different VFSs in
format::getStyle. (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D18399?vs=51440&id=51534#toc
Repository:
rL LLVM
http://reviews.l
ioeric added a comment.
@Daniel, now that Manuel is on vacation. Could you have a look at the patch?
Comment at: unittests/Tooling/RefactoringTest.cpp:206
@@ -169,3 +205,3 @@
TEST(ShiftedCodePositionTest, FindsNewCodePosition) {
Replacements Replaces;
Replaces.insert(Repl
Author: ioeric
Date: Thu Mar 24 06:24:49 2016
New Revision: 264256
URL: http://llvm.org/viewvc/llvm-project?rev=264256&view=rev
Log:
Revert "removed redundant comment in format::getStyle."
This reverts commit r264254.
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/
Author: ioeric
Date: Thu Mar 24 06:25:28 2016
New Revision: 264257
URL: http://llvm.org/viewvc/llvm-project?rev=264257&view=rev
Log:
Revert "Added support for different VFSs in format::getStyle."
This reverts commit r264253. It is breaking the buildbot
http://lab.llvm.org:8011/builders/llvm-clan
Author: ioeric
Date: Thu Mar 24 08:22:37 2016
New Revision: 264276
URL: http://llvm.org/viewvc/llvm-project?rev=264276&view=rev
Log:
Revert "Added support for different VFSs in format::getStyle."
This reverts commit r264253. It is breaking the buildbot
http://lab.llvm.org:8011/builders/llvm-clan
Author: ioeric
Date: Thu Mar 24 08:22:28 2016
New Revision: 264275
URL: http://llvm.org/viewvc/llvm-project?rev=264275&view=rev
Log:
Revert "removed redundant comment in format::getStyle."
This reverts commit r264254.
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/
Author: ioeric
Date: Thu Mar 24 08:22:42 2016
New Revision: 264277
URL: http://llvm.org/viewvc/llvm-project?rev=264277&view=rev
Log:
Added support for different VFSs in format::getStyle. Disable platform-related
test case for MS compilers to avoid breaking buildbot.
Modified:
cfe/trunk/inclu
I am looking into it now.
On Thu, Mar 24, 2016 at 2:39 PM Nico Weber wrote:
> Won't this still be broken in mingw (GCC, but on Windows)?
> On Mar 24, 2016 9:28 AM, "Eric Liu via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: ioeric
&
Author: ioeric
Date: Thu Mar 24 09:59:39 2016
New Revision: 264289
URL: http://llvm.org/viewvc/llvm-project?rev=264289&view=rev
Log:
Dsiable FormatStyle::GetStyleOfFile test case for mingw.
Modified:
cfe/trunk/unittests/Format/FormatTest.cpp
Modified: cfe/trunk/unittests/Format/FormatTest.cp
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
After applying replacements, redundant code like extra commas or empty
namespaces
might be introduced. Fixer can detect and remove any redundant code introduc
901 - 970 of 970 matches
Mail list logo
