[clang-tools-extra] r320743 - [clangd] Put all #includes in one block in clangd source files. NFC

2017-12-14 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Dec 14 13:22:03 2017 New Revision: 320743 URL: http://llvm.org/viewvc/llvm-project?rev=320743&view=rev Log: [clangd] Put all #includes in one block in clangd source files. NFC Clang-format categorizes and sorts #includes with style. It doesn't make sense to manually manag

[clang-tools-extra] r320807 - [clangd] Build in-memory index on symbols in files.

2017-12-15 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Dec 15 04:25:02 2017 New Revision: 320807 URL: http://llvm.org/viewvc/llvm-project?rev=320807&view=rev Log: [clangd] Build in-memory index on symbols in files. Reviewers: sammccall Reviewed By: sammccall Subscribers: klimek, mgorny, ilya-biryukov, cfe-commits Different

[clang-tools-extra] r321067 - [clangd] Support filtering by fixing scopes in fuzzyFind.

2017-12-19 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Dec 19 03:37:40 2017 New Revision: 321067 URL: http://llvm.org/viewvc/llvm-project?rev=321067&view=rev Log: [clangd] Support filtering by fixing scopes in fuzzyFind. Summary: When scopes are specified, only match symbols from scopes. Reviewers: sammccall Reviewed By: sa

[clang-tools-extra] r321083 - [clangd] Index-based code completion.

2017-12-19 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Dec 19 08:50:37 2017 New Revision: 321083 URL: http://llvm.org/viewvc/llvm-project?rev=321083&view=rev Log: [clangd] Index-based code completion. Summary: Use symbol index to populate completion results for qualfified IDs e.g. "nx::A^". Reviewers: ilya-biryukov, sammcca

[clang-tools-extra] r321092 - [clangd] Build dynamic index and use it for code completion.

2017-12-19 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Dec 19 10:00:37 2017 New Revision: 321092 URL: http://llvm.org/viewvc/llvm-project?rev=321092&view=rev Log: [clangd] Build dynamic index and use it for code completion. Reviewers: sammccall Reviewed By: sammccall Subscribers: klimek, ilya-biryukov, cfe-commits Differen

[clang-tools-extra] r321094 - [clangd] Supress a log warning by putting it behind a condition.

2017-12-19 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Dec 19 10:10:32 2017 New Revision: 321094 URL: http://llvm.org/viewvc/llvm-project?rev=321094&view=rev Log: [clangd] Supress a log warning by putting it behind a condition. Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp Modified: clang-tools-extra/trunk/cl

[clang-tools-extra] r321157 - [clangd] Igore cases in index fuzzy find.

2017-12-20 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Dec 20 01:29:54 2017 New Revision: 321157 URL: http://llvm.org/viewvc/llvm-project?rev=321157&view=rev Log: [clangd] Igore cases in index fuzzy find. Modified: clang-tools-extra/trunk/clangd/index/MemIndex.cpp clang-tools-extra/trunk/unittests/clangd/IndexTests.cp

[clang-tools-extra] r321192 - [clangd] Remove an unused lambda capture.

2017-12-20 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Dec 20 09:22:56 2017 New Revision: 321192 URL: http://llvm.org/viewvc/llvm-project?rev=321192&view=rev Log: [clangd] Remove an unused lambda capture. Modified: clang-tools-extra/trunk/unittests/clangd/Annotations.cpp Modified: clang-tools-extra/trunk/unittests/clangd

[clang-tools-extra] r321193 - [clangd] Pull CodeCompletionString handling logic into its own file and add unit test.

2017-12-20 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Dec 20 09:24:31 2017 New Revision: 321193 URL: http://llvm.org/viewvc/llvm-project?rev=321193&view=rev Log: [clangd] Pull CodeCompletionString handling logic into its own file and add unit test. Reviewers: sammccall Subscribers: klimek, mgorny, ilya-biryukov, cfe-commit

r321864 - Add a tool executor that runs actions on all TUs in the compilation database.

2018-01-05 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Jan 5 02:32:16 2018 New Revision: 321864 URL: http://llvm.org/viewvc/llvm-project?rev=321864&view=rev Log: Add a tool executor that runs actions on all TUs in the compilation database. Summary: Tool results are deduplicated by the result key. Reviewers: hokein Subscrib

[clang-tools-extra] r322084 - [clangd] Use ToolExecutor to write the global-symbol-builder tool.

2018-01-09 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Jan 9 07:21:45 2018 New Revision: 322084 URL: http://llvm.org/viewvc/llvm-project?rev=322084&view=rev Log: [clangd] Use ToolExecutor to write the global-symbol-builder tool. Summary: This enables more execution modes like standalone and Mapreduce-style execution. See al

[clang-tools-extra] r322097 - [clangd] Add more symbol information for code completion.

2018-01-09 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Jan 9 09:32:00 2018 New Revision: 322097 URL: http://llvm.org/viewvc/llvm-project?rev=322097&view=rev Log: [clangd] Add more symbol information for code completion. Reviewers: hokein, sammccall Reviewed By: sammccall Subscribers: klimek, ilya-biryukov, cfe-commits Dif

[clang-tools-extra] r322116 - Try to fix build failure caused by r322097

2018-01-09 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Jan 9 12:26:49 2018 New Revision: 322116 URL: http://llvm.org/viewvc/llvm-project?rev=322116&view=rev Log: Try to fix build failure caused by r322097 Avoid mapping during output when Detail is nullptr; otherwise, an empty "Detail" field will be populated in YAML output.

[clang-tools-extra] r322193 - [clangd] Add more filters for collected symbols.

2018-01-10 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Jan 10 06:57:58 2018 New Revision: 322193 URL: http://llvm.org/viewvc/llvm-project?rev=322193&view=rev Log: [clangd] Add more filters for collected symbols. Summary: o We only collect symbols in namespace or translation unit scopes. o Add an option to only collect symbols

[clang-tools-extra] r322194 - Add a missing dependency for r322192

2018-01-10 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Jan 10 07:11:26 2018 New Revision: 322194 URL: http://llvm.org/viewvc/llvm-project?rev=322194&view=rev Log: Add a missing dependency for r322192 Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt URL: http

[clang-tools-extra] r326310 - [clangd] A few minor fixes for STL internal header mapping.

2018-02-28 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Feb 28 00:56:11 2018 New Revision: 326310 URL: http://llvm.org/viewvc/llvm-project?rev=326310&view=rev Log: [clangd] A few minor fixes for STL internal header mapping. Modified: clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp Modified: clang-tools-extra/tr

[clang-tools-extra] r326313 - [clangd] Prefer the definition of a TagDecl (e.g. class) as CanonicalDeclaration.

2018-02-28 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Feb 28 01:33:15 2018 New Revision: 326313 URL: http://llvm.org/viewvc/llvm-project?rev=326313&view=rev Log: [clangd] Prefer the definition of a TagDecl (e.g. class) as CanonicalDeclaration. Summary: Currently, we pick the first declaration of a symbol in a TU, which is

[clang-tools-extra] r326325 - [clangd] A few more fixes for STL header mapping.

2018-02-28 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Feb 28 06:02:18 2018 New Revision: 326325 URL: http://llvm.org/viewvc/llvm-project?rev=326325&view=rev Log: [clangd] A few more fixes for STL header mapping. Modified: clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp Modified: clang-tools-extra/trunk/clangd

[clang-tools-extra] r326365 - [clangd] Try to fix failures on clang-x64-ninja-win7 build bot.

2018-02-28 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Feb 28 12:31:00 2018 New Revision: 326365 URL: http://llvm.org/viewvc/llvm-project?rev=326365&view=rev Log: [clangd] Try to fix failures on clang-x64-ninja-win7 build bot. Modified: clang-tools-extra/trunk/test/clangd/crash-non-added-files.test clang-tools-extra/t

[clang-tools-extra] r326452 - [clangd] Forward all environment variables along with CLANGD_TRACE to clangd.

2018-03-01 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Mar 1 09:42:27 2018 New Revision: 326452 URL: http://llvm.org/viewvc/llvm-project?rev=326452&view=rev Log: [clangd] Forward all environment variables along with CLANGD_TRACE to clangd. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts M

[clang-tools-extra] r326456 - [clangd] Support include canonicalization in symbol leve.

2018-03-01 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Mar 1 10:06:40 2018 New Revision: 326456 URL: http://llvm.org/viewvc/llvm-project?rev=326456&view=rev Log: [clangd] Support include canonicalization in symbol leve. Summary: Symbols with different canonical includes might be defined in the same header (e.g. symbols defin

[clang-tools-extra] r326458 - [clangd] Make symbol name a required parameter for CanonicalIncludes::mapHeader

2018-03-01 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Mar 1 10:30:48 2018 New Revision: 326458 URL: http://llvm.org/viewvc/llvm-project?rev=326458&view=rev Log: [clangd] Make symbol name a required parameter for CanonicalIncludes::mapHeader Modified: clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp clang-t

[clang-tools-extra] r326547 - [clangd:vscode] check empty/null string correctly.

2018-03-02 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Mar 2 01:21:41 2018 New Revision: 326547 URL: http://llvm.org/viewvc/llvm-project?rev=326547&view=rev Log: [clangd:vscode] check empty/null string correctly. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts Modified: clang-tools-extra/

[clang-tools-extra] r326548 - [clangd:vscode] Bump clangd-vscode version to 0.0.4.

2018-03-02 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Mar 2 01:26:17 2018 New Revision: 326548 URL: http://llvm.org/viewvc/llvm-project?rev=326548&view=rev Log: [clangd:vscode] Bump clangd-vscode version to 0.0.4. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.json Modified: clang-tools-extra/tr

[clang-tools-extra] r326773 - [clangd] Sort includes when formatting code or inserting new includes.

2018-03-06 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Mar 6 02:42:50 2018 New Revision: 326773 URL: http://llvm.org/viewvc/llvm-project?rev=326773&view=rev Log: [clangd] Sort includes when formatting code or inserting new includes. Reviewers: hokein, ilya-biryukov Subscribers: klimek, jkorous-apple, cfe-commits Differenti

[clang-tools-extra] r327009 - [clangd:vscode] Resolve symlinks for file paths from clangd.

2018-03-08 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Mar 8 07:28:42 2018 New Revision: 327009 URL: http://llvm.org/viewvc/llvm-project?rev=327009&view=rev Log: [clangd:vscode] Resolve symlinks for file paths from clangd. Summary: For features like go-to-definition, clangd can point clients to symlink paths (e.g. in bazel e

[clang-tools-extra] r327019 - [clangd] Bump vscode extension version to 0.0.5

2018-03-08 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Mar 8 08:14:11 2018 New Revision: 327019 URL: http://llvm.org/viewvc/llvm-project?rev=327019&view=rev Log: [clangd] Bump vscode extension version to 0.0.5 Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.json Modified: clang-tools-extra/trunk/c

[clang-tools-extra] r327130 - [clangd-vscode] Add package-lock.json to .gitignore

2018-03-09 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Mar 9 06:06:43 2018 New Revision: 327130 URL: http://llvm.org/viewvc/llvm-project?rev=327130&view=rev Log: [clangd-vscode] Add package-lock.json to .gitignore Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/.gitignore Modified: clang-tools-extra/trunk

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

2018-03-12 Thread Eric Liu via cfe-commits
Hi Akira, It seems that this commit also changes behavior for compiling C++ code as we are seeing test failures caused by this change in our internal tests. I'm still trying to reduce a reproducer for the failure. In the meantime, could you please double check if this affects C++? Thanks, Eric

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

2018-03-12 Thread Eric Liu via cfe-commits
The tests only failed with module enabled. FWIW, I think the change in ASTImporter (https://reviews.llvm.org/rL327206#change-1q8vFFjJ6Cqk) needs additional changes to make imports work for RecordDecl. On Mon, Mar 12, 2018 at 3:56 PM Eric Liu wrote: > Hi Akira, > > It seems that this commit also

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

2018-03-12 Thread Eric Liu via cfe-commits
I think there is a bug in the ASTImporter/Reader/Writer, but I'm not sure what's the right way to fix it. I'll revert this commit for now to unblock integration. Let me know if you need more information from us. Regards, Eric On Mon, Mar 12, 2018 at 4:51 PM Eric Liu wrote: > The tests only fail

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

2018-03-12 Thread Eric Liu via cfe-commits
I have been trying to reduce a reproducer for this but haven't gotten any luck yet. The error happens in conversion between different version of STL containers and is a bit hard to reduce. I'll keep trying to create a reproducer. Could you please also take a quick look to see if ASTImporter/Reader

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

2018-03-12 Thread Eric Liu via cfe-commits
I think it's likely as our tests only fail with module enabled (without module, ASTImporter isn't really used). On Mon, Mar 12, 2018 at 5:51 PM Akira Hatanaka wrote: > The patch I committed moved CXXRecordDecl::CanPassInRegisters to > RecordDecl. It looks like ASTImporter::ImportDefinition no lo

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

2018-03-12 Thread Eric Liu via cfe-commits
Thanks a lot Akira! FWIW, it seems that the FIXME here might be related https://github.com/llvm-mirror/clang/blob/master/include/clang/AST/DeclCXX.h#L1484 On Mon, Mar 12, 2018 at 6:03 PM Akira Hatanaka wrote: > I’m not sure if this a bug r327206 introduced or an existing bug in > ASTImporter as

[clang-tools-extra] r327487 - [clangd] Add an interface that finds symbol by SymbolID in SymbolIndex.

2018-03-14 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Mar 14 02:48:05 2018 New Revision: 327487 URL: http://llvm.org/viewvc/llvm-project?rev=327487&view=rev Log: [clangd] Add an interface that finds symbol by SymbolID in SymbolIndex. Summary: Potential use case: argument go-to-definition result with symbol information (e.g.

[clang-tools-extra] r327629 - [change-namespace] Don't match a function call/ref multiple times.

2018-03-15 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Mar 15 07:45:02 2018 New Revision: 327629 URL: http://llvm.org/viewvc/llvm-project?rev=327629&view=rev Log: [change-namespace] Don't match a function call/ref multiple times. Summary: Previously, the matcher matches a function call/ref multiple times, one for each decl an

r333532 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

2018-05-30 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed May 30 04:51:48 2018 New Revision: 333532 URL: http://llvm.org/viewvc/llvm-project?rev=333532&view=rev Log: Reland "Move #include manipulation code to new lib/Tooling/Inclusions." This reverts commit r332751 (i.e. reland r332720) after fixing module build. Differential R

[clang-tools-extra] r333533 - Reland "[clangd] Adapt file migration in r332720"

2018-05-30 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed May 30 04:52:01 2018 New Revision: 333533 URL: http://llvm.org/viewvc/llvm-project?rev=333533&view=rev Log: Reland "[clangd] Adapt file migration in r332720" This reverts commit r332752 (i.e. reland r332721). Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt

r333534 - Revert "Reland "Move #include manipulation code to new lib/Tooling/Inclusions.""

2018-05-30 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed May 30 05:09:58 2018 New Revision: 333534 URL: http://llvm.org/viewvc/llvm-project?rev=333534&view=rev Log: Revert "Reland "Move #include manipulation code to new lib/Tooling/Inclusions."" This reverts commit r333532. Revert for now to fix an internal bot issue. Added:

[clang-tools-extra] r333535 - Revert "Reland "[clangd] Adapt file migration in r332720""

2018-05-30 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed May 30 05:10:07 2018 New Revision: 333535 URL: http://llvm.org/viewvc/llvm-project?rev=333535&view=rev Log: Revert "Reland "[clangd] Adapt file migration in r332720"" This reverts commit r333533. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt clang-tools

[clang-tools-extra] r333877 - Reland "[clangd] Adapt file migration in r332720"

2018-06-04 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Jun 4 02:04:28 2018 New Revision: 333877 URL: http://llvm.org/viewvc/llvm-project?rev=333877&view=rev Log: Reland "[clangd] Adapt file migration in r332720" This reverts commit r333535. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt clang-tools-extra/tr

[clang-tools-extra] r333876 - Revert "Reland "[clangd] Adapt file migration in r332720""

2018-06-04 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Jun 4 02:04:25 2018 New Revision: 333876 URL: http://llvm.org/viewvc/llvm-project?rev=333876&view=rev Log: Revert "Reland "[clangd] Adapt file migration in r332720"" This reverts commit r333533. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt clang-tools

r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

2018-06-04 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Jun 4 02:04:12 2018 New Revision: 333874 URL: http://llvm.org/viewvc/llvm-project?rev=333874&view=rev Log: Reland "Move #include manipulation code to new lib/Tooling/Inclusions." This reverts commit r333534 (i.e. reland r332720) after fixing module build. Differential R

[clang-tools-extra] r333875 - Reland "[clangd] Adapt file migration in r332720"

2018-06-04 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Jun 4 02:04:19 2018 New Revision: 333875 URL: http://llvm.org/viewvc/llvm-project?rev=333875&view=rev Log: Reland "[clangd] Adapt file migration in r332720" This reverts commit r332752 (i.e. reland r332721). Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt

[clang-tools-extra] r333885 - [clangd] Avoid indexing decls associated with friend decls.

2018-06-04 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Jun 4 04:31:55 2018 New Revision: 333885 URL: http://llvm.org/viewvc/llvm-project?rev=333885&view=rev Log: [clangd] Avoid indexing decls associated with friend decls. Summary: These decls are sometime used as the canonical declarations (e.g. for go-to-def), which seems

Re: r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

2018-06-04 Thread Eric Liu via cfe-commits
Mon, Jun 4, 2018 at 12:04 PM, Eric Liu via cfe-commits > wrote: > > Author: ioeric > > Date: Mon Jun 4 02:04:12 2018 > > New Revision: 333874 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=333874&view=rev > > Log: > > Reland "Move #in

[clang-tools-extra] r334485 - [clangd] Support proximity paths in index fuzzy find.

2018-06-12 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Jun 12 01:48:20 2018 New Revision: 334485 URL: http://llvm.org/viewvc/llvm-project?rev=334485&view=rev Log: [clangd] Support proximity paths in index fuzzy find. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, cfe-commits Differential Revision: https:

[clang-tools-extra] r334809 - [clangd] Customizable URI schemes for dynamic index.

2018-06-15 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Jun 15 01:55:00 2018 New Revision: 334809 URL: http://llvm.org/viewvc/llvm-project?rev=334809&view=rev Log: [clangd] Customizable URI schemes for dynamic index. Summary: This allows dynamic index to have consistent URI schemes with the static index which can have customiz

[clang-tools-extra] r334810 - [clangd] Boost completion score according to file proximity.

2018-06-15 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Jun 15 01:58:12 2018 New Revision: 334810 URL: http://llvm.org/viewvc/llvm-project?rev=334810&view=rev Log: [clangd] Boost completion score according to file proximity. Summary: Also move unittest: URI scheme to TestFS so that it can be shared by different tests. Reviewe

[clang-tools-extra] r334828 - [clangd] UI for completion items that would trigger include insertion.

2018-06-15 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Jun 15 06:34:18 2018 New Revision: 334828 URL: http://llvm.org/viewvc/llvm-project?rev=334828&view=rev Log: [clangd] UI for completion items that would trigger include insertion. Summary: For completion items that would trigger include insertions (i.e. index symbols that

[clang-tools-extra] r335035 - [clangd] Use workspace root path as hint path for resolving URIs in workspace/symbol

2018-06-19 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Jun 19 02:33:53 2018 New Revision: 335035 URL: http://llvm.org/viewvc/llvm-project?rev=335035&view=rev Log: [clangd] Use workspace root path as hint path for resolving URIs in workspace/symbol Summary: Some URI schemes require a hint path to be provided, and workspace ro

[clang-tools-extra] r335212 - [clangd] Fix proximity signal output format. NFC

2018-06-21 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Jun 21 02:51:28 2018 New Revision: 335212 URL: http://llvm.org/viewvc/llvm-project?rev=335212&view=rev Log: [clangd] Fix proximity signal output format. NFC Modified: clang-tools-extra/trunk/clangd/Quality.cpp Modified: clang-tools-extra/trunk/clangd/Quality.cpp URL:

[clang-tools-extra] r335218 - [clangd] Expose 'shouldCollectSymbol' helper from SymbolCollector.

2018-06-21 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Jun 21 05:12:26 2018 New Revision: 335218 URL: http://llvm.org/viewvc/llvm-project?rev=335218&view=rev Log: [clangd] Expose 'shouldCollectSymbol' helper from SymbolCollector. Summary: This allows tools to examine symbols that would be collected in a symbol index. For exa

[clang-tools-extra] r335334 - [clangd] Expose qualified symbol names in CompletionItem (C++ structure only, no json).

2018-06-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Jun 22 03:46:59 2018 New Revision: 335334 URL: http://llvm.org/viewvc/llvm-project?rev=335334&view=rev Log: [clangd] Expose qualified symbol names in CompletionItem (C++ structure only, no json). Summary: The qualified name can be used to match a completion item to its c

[clang-tools-extra] r344055 - [clang-move] Fix broken json output.

2018-10-09 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Oct 9 08:17:16 2018 New Revision: 344055 URL: http://llvm.org/viewvc/llvm-project?rev=344055&view=rev Log: [clang-move] Fix broken json output. Modified: clang-tools-extra/trunk/clang-move/tool/ClangMoveMain.cpp Modified: clang-tools-extra/trunk/clang-move/tool/Clan

r344262 - [Lex] TokenConcatenation now takes const Preprocessor

2018-10-11 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Oct 11 10:35:29 2018 New Revision: 344262 URL: http://llvm.org/viewvc/llvm-project?rev=344262&view=rev Log: [Lex] TokenConcatenation now takes const Preprocessor Differential Revision: https://reviews.llvm.org/D52502 Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/U

r344266 - clang-cl: set output of lit-test to a tmp file after r344234

2018-10-11 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Oct 11 10:49:20 2018 New Revision: 344266 URL: http://llvm.org/viewvc/llvm-project?rev=344266&view=rev Log: clang-cl: set output of lit-test to a tmp file after r344234 Some test frameworks do not allow output file in CWD. Modified: cfe/trunk/test/Driver/cl-showfilen

r344267 - Revert "[Lex] TokenConcatenation now takes const Preprocessor"

2018-10-11 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Oct 11 10:50:04 2018 New Revision: 344267 URL: http://llvm.org/viewvc/llvm-project?rev=344267&view=rev Log: Revert "[Lex] TokenConcatenation now takes const Preprocessor" This reverts commit r344262. This was an unintentional commit. Modified: cfe/trunk/lib/StaticAn

r344335 - [Tooling] Expose ExecutorName option.

2018-10-12 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Oct 12 04:47:36 2018 New Revision: 344335 URL: http://llvm.org/viewvc/llvm-project?rev=344335&view=rev Log: [Tooling] Expose ExecutorName option. Modified: cfe/trunk/include/clang/Tooling/Execution.h cfe/trunk/lib/Tooling/Execution.cpp Modified: cfe/trunk/include

r344509 - [CodeComplete] Make sure keyword 'template' is added even when code pattern is disabled.

2018-10-15 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Oct 15 05:37:23 2018 New Revision: 344509 URL: http://llvm.org/viewvc/llvm-project?rev=344509&view=rev Log: [CodeComplete] Make sure keyword 'template' is added even when code pattern is disabled. Reviewers: sammccall, hokein Subscribers: arphaman, cfe-commits Differen

[clang-tools-extra] r344604 - [clangd] Allow disble down traversals from root.

2018-10-16 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Oct 16 03:41:17 2018 New Revision: 344604 URL: http://llvm.org/viewvc/llvm-project?rev=344604&view=rev Log: [clangd] Allow disble down traversals from root. Summary: This is useful for symbo scope proximity, where down traversals from the global scope if not desired. Rev

[clang-tools-extra] r344688 - [clangd] Support scope proximity in code completion.

2018-10-17 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Oct 17 04:19:02 2018 New Revision: 344688 URL: http://llvm.org/viewvc/llvm-project?rev=344688&view=rev Log: [clangd] Support scope proximity in code completion. Summary: This should make all-scope completion more usable. Scope proximity for indexes will be added in follow

[clang-tools-extra] r344736 - [clangd] Names that are not spelled in source code are reserved.

2018-10-18 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Oct 18 05:23:05 2018 New Revision: 344736 URL: http://llvm.org/viewvc/llvm-project?rev=344736&view=rev Log: [clangd] Names that are not spelled in source code are reserved. Summary: These are often not expected to be used directly e.g. ``` TEST_F(Fixture, X) { ^ // "Fi

r344889 - [CodeComplete] Fix accessibility of protected members when accessing members implicitly.

2018-10-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Oct 22 01:47:31 2018 New Revision: 344889 URL: http://llvm.org/viewvc/llvm-project?rev=344889&view=rev Log: [CodeComplete] Fix accessibility of protected members when accessing members implicitly. Reviewers: ilya-biryukov Subscribers: arphaman, cfe-commits Differential

[clang-tools-extra] r344897 - [change-namespace] Enhance detection of conflicting namespaces.

2018-10-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Oct 22 05:48:49 2018 New Revision: 344897 URL: http://llvm.org/viewvc/llvm-project?rev=344897&view=rev Log: [change-namespace] Enhance detection of conflicting namespaces. Summary: For example: ``` namespace util { class Base; } namespace new { namespace util { class Int

[clang-tools-extra] r344912 - [clangd] Support URISchemes configuration in BackgroundIndex.

2018-10-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Oct 22 08:37:58 2018 New Revision: 344912 URL: http://llvm.org/viewvc/llvm-project?rev=344912&view=rev Log: [clangd] Support URISchemes configuration in BackgroundIndex. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits D

r345135 - [CodeComplete] Expose InBaseClass signal in code completion results.

2018-10-24 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Oct 24 05:57:27 2018 New Revision: 345135 URL: http://llvm.org/viewvc/llvm-project?rev=345135&view=rev Log: [CodeComplete] Expose InBaseClass signal in code completion results. Summary: No new tests as the existing tests for result priority should give us coverage. Also a

[clang-tools-extra] r345140 - [clangd] Downrank members from base class

2018-10-24 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Oct 24 06:45:17 2018 New Revision: 345140 URL: http://llvm.org/viewvc/llvm-project?rev=345140&view=rev Log: [clangd] Downrank members from base class Reviewers: sammccall, ilya-biryukov Reviewed By: sammccall Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commit

[clang-tools-extra] r351813 - [clangd] NFC: reduce log noise from Diagnostics.

2019-01-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Jan 22 04:55:27 2019 New Revision: 351813 URL: http://llvm.org/viewvc/llvm-project?rev=351813&view=rev Log: [clangd] NFC: reduce log noise from Diagnostics. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential R

[clang-tools-extra] r352361 - [clangd] Suggest adding missing includes for incomplete type diagnostics.

2019-01-28 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Jan 28 06:01:55 2019 New Revision: 352361 URL: http://llvm.org/viewvc/llvm-project?rev=352361&view=rev Log: [clangd] Suggest adding missing includes for incomplete type diagnostics. Summary: This enables clangd to intercept compiler diagnostics and attach fixes (e.g. by q

r352503 - [Tooling] Handle #pragma once header guard in include insertion.

2019-01-29 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Jan 29 06:40:01 2019 New Revision: 352503 URL: http://llvm.org/viewvc/llvm-project?rev=352503&view=rev Log: [Tooling] Handle #pragma once header guard in include insertion. Reviewers: ilya-biryukov Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org

r352618 - [OpenGL] Fix test on PPC after r352540

2019-01-30 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Jan 30 03:24:04 2019 New Revision: 352618 URL: http://llvm.org/viewvc/llvm-project?rev=352618&view=rev Log: [OpenGL] Fix test on PPC after r352540 Summary: Specify -triple like test/SemaOpenCL/logical-ops.cl. Otherwise, this test fails on PPC. Reviewers: bkramer Subscri

Re: r352690 - [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

2019-01-31 Thread Eric Liu via cfe-commits
And the stack trace is: ``` 1. parser at end of file [31/1788] 2. Code generation 3. Running pass 'Function Pass Manager' on module 'absl/base/internal/throw_delegate.cc'. 4. Running pass 'X86 DAG->DAG Instruction Selectio

r352755 - Revert "[Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls"

2019-01-31 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Jan 31 06:20:02 2019 New Revision: 352755 URL: http://llvm.org/viewvc/llvm-project?rev=352755&view=rev Log: Revert "[Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls" This reverts commit r352690. This causes clang to crash. Sent re

[clang-tools-extra] r352764 - [clangd] Append "(fix available)" to diagnostic message when fixes are present.

2019-01-31 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Jan 31 08:09:25 2019 New Revision: 352764 URL: http://llvm.org/viewvc/llvm-project?rev=352764&view=rev Log: [clangd] Append "(fix available)" to diagnostic message when fixes are present. Summary: This would make diagnostic fixits more discoverable, especially for plugins

[clang-tools-extra] r346221 - [clangd] auto-index stores symbols per-file instead of per-TU.

2018-11-06 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Nov 6 02:55:21 2018 New Revision: 346221 URL: http://llvm.org/viewvc/llvm-project?rev=346221&view=rev Log: [clangd] auto-index stores symbols per-file instead of per-TU. Summary: This allows us to deduplicate header symbols across TUs. File digests are collects when coll

[clang-tools-extra] r346223 - [clangd] Get rid of QueryScopes.empty() == AnyScope special case.

2018-11-06 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Nov 6 03:08:17 2018 New Revision: 346223 URL: http://llvm.org/viewvc/llvm-project?rev=346223&view=rev Log: [clangd] Get rid of QueryScopes.empty() == AnyScope special case. Reviewers: sammccall Reviewed By: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arpham

[clang-tools-extra] r346224 - [clangd] Deduplicate query scopes.

2018-11-06 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Nov 6 03:17:40 2018 New Revision: 346224 URL: http://llvm.org/viewvc/llvm-project?rev=346224&view=rev Log: [clangd] Deduplicate query scopes. Summary: For example, when anonymous namespace is present, duplicated namespaces might be generated for the enclosing namespace.

[clang-tools-extra] r346648 - [clangd] Remember to serialize AnyScope in FuzzyFindRequest json.

2018-11-12 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Nov 12 04:24:08 2018 New Revision: 346648 URL: http://llvm.org/viewvc/llvm-project?rev=346648&view=rev Log: [clangd] Remember to serialize AnyScope in FuzzyFindRequest json. Modified: clang-tools-extra/trunk/clangd/index/Index.cpp Modified: clang-tools-extra/trunk/cl

[clang-tools-extra] r347466 - [clangd] Cleanup: use index file instead of header in workspace symbols lit test.

2018-11-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Nov 22 06:59:22 2018 New Revision: 347466 URL: http://llvm.org/viewvc/llvm-project?rev=347466&view=rev Log: [clangd] Cleanup: use index file instead of header in workspace symbols lit test. Summary: The full path of the input header depends on the execution environment a

[clang-tools-extra] r347467 - [clangd] Cleanup: stop passing around list of supported URI schemes.

2018-11-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Nov 22 07:02:05 2018 New Revision: 347467 URL: http://llvm.org/viewvc/llvm-project?rev=347467&view=rev Log: [clangd] Cleanup: stop passing around list of supported URI schemes. Summary: Instead of passing around a list of supported URI schemes in clangd, we expose an inte

[clang-tools-extra] r347548 - [clangd] Tune down scope boost for global scope

2018-11-26 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Nov 26 04:12:01 2018 New Revision: 347548 URL: http://llvm.org/viewvc/llvm-project?rev=347548&view=rev Log: [clangd] Tune down scope boost for global scope Summary: This improves cross-namespace completions and has ignorable impact on other completion types. Metrics ```

[clang-tools-extra] r347739 - [clangd] Canonicalize file path in URIForFile.

2018-11-28 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Nov 28 02:30:42 2018 New Revision: 347739 URL: http://llvm.org/viewvc/llvm-project?rev=347739&view=rev Log: [clangd] Canonicalize file path in URIForFile. Summary: File paths in URIForFile can come from index or local AST. Path from index goes through URI transformation a

[clang-tools-extra] r347754 - [clangd] Less penalty for cross-namespace completions.

2018-11-28 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Nov 28 05:45:25 2018 New Revision: 347754 URL: http://llvm.org/viewvc/llvm-project?rev=347754&view=rev Log: [clangd] Less penalty for cross-namespace completions. Modified: clang-tools-extra/trunk/clangd/Quality.cpp Modified: clang-tools-extra/trunk/clangd/Quality.cp

[clang-tools-extra] r347755 - [clangd] Fix test broken in r347754.

2018-11-28 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Nov 28 06:00:09 2018 New Revision: 347755 URL: http://llvm.org/viewvc/llvm-project?rev=347755&view=rev Log: [clangd] Fix test broken in r347754. Modified: clang-tools-extra/trunk/clangd/Quality.cpp Modified: clang-tools-extra/trunk/clangd/Quality.cpp URL: http://llv

[clang-tools-extra] r347982 - [clangd] Drop injected class name when class scope is not explicitly specified.

2018-11-30 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Nov 30 03:12:40 2018 New Revision: 347982 URL: http://llvm.org/viewvc/llvm-project?rev=347982&view=rev Log: [clangd] Drop injected class name when class scope is not explicitly specified. Summary: E.g. allow injected "A::A" in `using A::A^` but not in "A^". Reviewers: ka

[clang-tools-extra] r347983 - [clangd] Penalize destructor and overloaded operators in code completion.

2018-11-30 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Nov 30 03:17:15 2018 New Revision: 347983 URL: http://llvm.org/viewvc/llvm-project?rev=347983&view=rev Log: [clangd] Penalize destructor and overloaded operators in code completion. Reviewers: hokein Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-c

Re: [PATCH] D58448: [clangd] Improve global code completion when scope specifier is unresolved.

2019-02-26 Thread Eric Liu via cfe-commits
Unfortunately, the evaluation tool I use only works on compilable code, so it doesn't capture the unsolved specifier case in this patch. I didn't try to collect the metrics because I think this is more of a bug fix than quality improvement. On Tue, Feb 26, 2019, 10:25 Kadir Cetinkaya via Phabricat

[clang-tools-extra] r354963 - [clangd] Improve global code completion when scope specifier is unresolved.

2019-02-27 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Feb 27 03:42:37 2019 New Revision: 354963 URL: http://llvm.org/viewvc/llvm-project?rev=354963&view=rev Log: [clangd] Improve global code completion when scope specifier is unresolved. Summary: Suppose `clangd::` is unresolved in the following example. Currently, we simply

[clang-tools-extra] r355200 - [clangd] Enable SuggestMissingIncludes by default.

2019-03-01 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Mar 1 06:17:55 2019 New Revision: 355200 URL: http://llvm.org/viewvc/llvm-project?rev=355200&view=rev Log: [clangd] Enable SuggestMissingIncludes by default. Summary: This seems to work stably now. Turn on by default. Reviewers: kadircet Subscribers: ilya-biryukov, Mas

r356446 - [Tooling] Add more scope specifiers until spelling is not ambiguous.

2019-03-19 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Mar 19 03:12:15 2019 New Revision: 356446 URL: http://llvm.org/viewvc/llvm-project?rev=356446&view=rev Log: [Tooling] Add more scope specifiers until spelling is not ambiguous. Summary: Previously, when the renamed spelling is ambiguous, we simply use the full-qualfied na

r357567 - [clang-format] Regroup #includes into blocks for Google style

2019-04-03 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Apr 3 02:25:16 2019 New Revision: 357567 URL: http://llvm.org/viewvc/llvm-project?rev=357567&view=rev Log: [clang-format] Regroup #includes into blocks for Google style Summary: Regrouping #includes in blocks separated by blank lines when sorting C++ #include headers wa

[clang-tools-extra] r357916 - [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

2019-04-08 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Apr 8 07:53:16 2019 New Revision: 357916 URL: http://llvm.org/viewvc/llvm-project?rev=357916&view=rev Log: [clangd] Add fallback mode for code completion when compile command or preamble is not ready. Summary: When calling TUScehduler::runWithPreamble (e.g. in code comp

[clang-tools-extra] r358159 - [clangd] Use identifiers in file as completion candidates when build is not ready.

2019-04-11 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Apr 11 02:36:36 2019 New Revision: 358159 URL: http://llvm.org/viewvc/llvm-project?rev=358159&view=rev Log: [clangd] Use identifiers in file as completion candidates when build is not ready. Summary: o Lex the code to get the identifiers and put them into a "symbol" inde

r358378 - [Lookup] Invisible decls should not be ambiguous when renaming.

2019-04-15 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Apr 15 01:46:34 2019 New Revision: 358378 URL: http://llvm.org/viewvc/llvm-project?rev=358378&view=rev Log: [Lookup] Invisible decls should not be ambiguous when renaming. Summary: For example, a renamed type in a header file can conflict with declaration in a random file

[clang-tools-extra] r358400 - [clangd] Wait for compile command in ASTWorker instead of ClangdServer

2019-04-15 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Apr 15 05:32:28 2019 New Revision: 358400 URL: http://llvm.org/viewvc/llvm-project?rev=358400&view=rev Log: [clangd] Wait for compile command in ASTWorker instead of ClangdServer Summary: This makes addDocument non-blocking and would also allow code completion (in fallbac

[clang-tools-extra] r358496 - [clangd] Check file path of declaring header when deciding whether to insert include.

2019-04-16 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Apr 16 07:35:49 2019 New Revision: 358496 URL: http://llvm.org/viewvc/llvm-project?rev=358496&view=rev Log: [clangd] Check file path of declaring header when deciding whether to insert include. Summary: Previously, we would use include spelling of the declaring header to

[clang-tools-extra] r342362 - [clangd] Get rid of AST matchers in SymbolCollector. NFC

2018-09-17 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Sep 17 00:43:49 2018 New Revision: 342362 URL: http://llvm.org/viewvc/llvm-project?rev=342362&view=rev Log: [clangd] Get rid of AST matchers in SymbolCollector. NFC Reviewers: ilya-biryukov, kadircet Subscribers: MaskRay, jkorous, arphaman, cfe-commits Differential Revi

r342451 - [Index] Add an option to collect macros from preprocesor.

2018-09-18 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Sep 18 01:51:08 2018 New Revision: 342451 URL: http://llvm.org/viewvc/llvm-project?rev=342451&view=rev Log: [Index] Add an option to collect macros from preprocesor. Summary: Also added unit tests for the index library; lit+c-index-test is painful... Reviewers: ilya-bir

[clang-tools-extra] r342452 - [clangd] Adapt API change after 342451.

2018-09-18 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Sep 18 01:52:14 2018 New Revision: 342452 URL: http://llvm.org/viewvc/llvm-project?rev=342452&view=rev Log: [clangd] Adapt API change after 342451. Modified: clang-tools-extra/trunk/clangd/FindSymbols.cpp clang-tools-extra/trunk/clangd/XRefs.cpp clang-tools-ex

<    1   2   3   4   5   6   7   8   9   10   >