echristo added a comment.
Can you add an explicit test for soft/hard-float.
One inline comment as well, waiting on Richard to pipe up.
-eric
Comment at: lib/Basic/Targets.cpp:2603
@@ -2599,3 +2602,3 @@
case CK_i386:
case CK_i486:
case CK_i586:
Waiting
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks!
-eric
http://reviews.llvm.org/D13980
___
cfe-commits mailing list
cfe-commits@lists.llvm
This appears to be a different direction from what we'd agreed upon. Please
update the original thread with discussion and your intentions and a
breakdown of costs, long-term maintainability, and your plans here.
Thanks.
On Mon, Apr 18, 2016 at 2:07 PM Eric Christopher via cfe-commits
Seems a much more principled solution yes.
On Fri, Apr 29, 2016, 9:19 AM Hal Finkel wrote:
> hfinkel updated this revision to Diff 55610.
> hfinkel added a comment.
>
> Use David's suggested approach: Modify the preferred expression location
> for member calls. If the callee has a valid location
echristo added a subscriber: echristo.
echristo added a comment.
Seems a much more principled solution yes.
http://reviews.llvm.org/D19708
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Nice. If you wouldn't mind splitting out into 3 patches (all ok):
a) The initial testcase,
b) the mno-cx16 patch and associated test
c) The x87 part and associated test.
You'll also want t
echristo added a comment.
Hi,
Couple of inline comments. The direction is getting there, but there's some
overall architecture issues to sort out I think.
Thanks!
-eric
Comment at: include/clang/AST/Stmt.h:1555
@@ +1554,3 @@
+ // target feature (by attribute or invocation o
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
Please do add tests before committing. Otherwise ok.
Thanks.
-eric
Comment at: lib/Basic/Targets.cpp:1239
@@ -1227,1 +1238,3 @@
+ if (defs & ArchDefinePwr9)
+Builder.defineMacr
Sounds great. Thanks!
-eric
On Wed, May 4, 2016 at 4:36 AM Andrey Turetskiy
wrote:
> aturetsk added a comment.
>
> Hi,
> Thanks for the review.
>
> Committed:
>
> 1. Add a test for driver options from m_x86_Features_Group (
> http://reviews.llvm.org/rL268487)
> 2. Add missing -mno-cx16 driver o
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks.
-eric
http://reviews.llvm.org/D19796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
So, why are you doing this for more than just the avx512 headers? I
understand that you're unhappy with all of the intrinsics, but you've added
an incompatibility here for MS mode. Does MS use header guards locking off
particular intrinsics?
What "better intrinsic story" are you looking for? This
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
Not sure if that's clang-formatted, but please do so if not :)
-eric
http://reviews.llvm.org/D18629
___
Nah, just worth knowing. It was probably more useful to know last month.
-eric
On Mon, Apr 4, 2016 at 11:56 AM Kit Barton wrote:
> I forgot to edit the message.
> Do you think it's worth going back and fixing the log message at this
> point?
>
> Kit Barton, Ph.D.
> LLVM Development on POWER
> I
echristo added a comment.
That's fascinating and terrifying all at once.
Can you rename the test to avx-v-modifier-inline-asm.c please?
One inline comment as well.
Thanks!
-eric
Comment at: lib/AST/Stmt.cpp:639
@@ +638,3 @@
+ // into "pcmpestri" otherwise.
+ if (C.
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
I'm not real fond of the testcase being in attr-target-x86, but there's not a
better place at the moment either.
-eric
http://reviews.llvm.org/D18651
_
echristo added inline comments.
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:477-479
@@ -476,2 +476,5 @@
+ unsigned DebugCUs = 0;
for (MDNode *N : CU_Nodes->operands()) {
auto *CUNode = cast(N);
+if (CUNode->getEmissionKind() == DICompileUnit::NoDebug)
+ con
echristo accepted this revision.
echristo added a comment.
This all seems reasonable to me, one inline rewording comment, and check with
rjmccall before committing.
Thanks!
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute
echristo added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute. ELF targets support this attribute
when using binutils v2.20.1 or higher and glibc v2.11.1 or higher. Non-ELF
targets currently do not supp
On Fri, Apr 8, 2016, 10:45 AM Paul Robinson <
paul_robin...@playstation.sony.com> wrote:
> probinson added inline comments.
>
>
> Comment at: include/clang/Basic/AttrDocs.td:2371
> @@ +2370,3 @@
> +
> +Not all targets support this attribute. ELF targets support this
> attribute w
echristo added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute. ELF targets support this attribute
when using binutils v2.20.1 or higher and glibc v2.11.1 or higher. Non-ELF
targets currently do not supp
echristo added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute. ELF targets support this attribute
when using binutils v2.20.1 or higher and glibc v2.11.1 or higher. Non-ELF
targets currently do not supp
Author: echristo
Date: Tue Apr 12 16:08:54 2016
New Revision: 266122
URL: http://llvm.org/viewvc/llvm-project?rev=266122&view=rev
Log:
Add a couple of missing vsx load and store intrinsics.
Patch by Jing Yu!
Modified:
cfe/trunk/lib/Headers/altivec.h
cfe/trunk/test/CodeGen/builtins-ppc-vs
echristo added inline comments.
Comment at: lib/CodeGen/CodeGenModule.h:292
@@ -291,3 +291,3 @@
CGCUDARuntime* CUDARuntime;
- CGDebugInfo* DebugInfo;
+ std::unique_ptr DebugInfo;
ObjCEntrypoints *ObjCData;
aprantl wrote:
> This could be a separate useful N
echristo requested changes to this revision.
echristo added a comment.
This revision now requires changes to proceed.
As a note I'm going to want to review this before it goes in.
http://reviews.llvm.org/D19072
___
cfe-commits mailing list
cfe-commi
Author: echristo
Date: Tue May 24 17:25:06 2016
New Revision: 270625
URL: http://llvm.org/viewvc/llvm-project?rev=270625&view=rev
Log:
Make the altivec intrinsics that require immediate constant propagation
macros rather than functions.
Unfortunately couldn't come up with a simple testcase that d
echristo requested changes to this revision.
echristo added a comment.
This revision now requires changes to proceed.
I followed up in the original thread, I don't think this is going to be the
right direction.
Thanks.
-eric
http://reviews.llvm.org/D21066
__
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Seems pretty reasonable. If I missed anything we can pick it up later.
-eric
Comment at: lib/Basic/Targets.cpp:2010
@@ +2009,3 @@
+
+ // XXX - What does the member GPU m
Hi Steven,
Great to see the commentary and updates here. I've got a few questions
about some of this work. It might be nice to see some separate RFCs for a
couple of things, but we'll figure that out after you send out patches
probably :)
What needs to be improved:
> 1. Whitelist for command line
echristo added a comment.
The 128 bit versions should only be selecting for sse functions and shouldn't
need avx to work? What instructions are getting emitted here?
http://reviews.llvm.org/D21306
___
cfe-commits mailing list
cfe-commits@lists.llvm
echristo added inline comments.
Comment at: lib/Basic/Targets.cpp:5709
@@ -5715,1 +5708,3 @@
+
+return false;
}
compnerd wrote:
> Please collapse this:
>
> return Name == "generic" || llvm::AArch64::parseCPUArch(Name) !=
> llvm::ARM::AK_INVALID;
... w
On Mon, Jun 13, 2016 at 9:37 AM Steven Wu wrote:
> Thanks for the feedback! Replies inline.
>
> On Jun 12, 2016, at 11:44 PM, Eric Christopher wrote:
>
> Hi Steven,
>
> Great to see the commentary and updates here. I've got a few questions
> about some of this work. It might be nice to see some
On Tue, Jun 14, 2016 at 6:09 PM Adrian Prantl wrote:
> On Jun 13, 2016, at 9:37 AM, Steven Wu wrote:
>
> Thanks for the feedback! Replies inline.
>
> On Jun 12, 2016, at 11:44 PM, Eric Christopher wrote:
>
> Hi Steven,
>
> Great to see the commentary and updates here. I've got a few questions
>
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Fine with me.
-eric
Comment at: lib/Basic/Targets.cpp:5709
@@ -5716,3 +5708,3 @@
void getTargetDefines(const LangOptions &Opts,
MacroBuilder
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
OK.
-eric
http://reviews.llvm.org/D21469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
echristo added a reviewer: aaron.ballman.
echristo added a comment.
Couple of inline comments. Also adding Aaron since he normally reviews the
attributes :)
-eric
Comment at: include/clang/Driver/Options.td:753
@@ +752,3 @@
+ HelpText<"Generate XRay instrumentation sleds on f
echristo added a subscriber: echristo.
echristo added a comment.
Why is this in clang rather than in llvm?
Repository:
rL LLVM
http://reviews.llvm.org/D21542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
echristo added a comment.
OK, that works for me. :)
Repository:
rL LLVM
http://reviews.llvm.org/D21542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Please reformat with clang-format and then OK.
-eric
http://reviews.llvm.org/D21334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
echristo added a comment.
In http://reviews.llvm.org/D21334#472548, @pirama wrote:
> Reformatted with clang-format for just the parts I added. I ignored
> clang-format-suggested changes in code unrelated to this patch.
Yep.
> Is there a policy or practise on periodically fixing format-relate
echristo added a comment.
In http://reviews.llvm.org/D20352#477203, @rnk wrote:
> In http://reviews.llvm.org/D20352#477084, @aaron.ballman wrote:
>
> > No, I'm not. I am worried about how this conflicts with another in-flight
> > patch for supporting MS hotpatchable functions since it seems thes
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
-eric
http://reviews.llvm.org/D22338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: echristo
Date: Fri Jul 15 19:58:34 2016
New Revision: 275655
URL: http://llvm.org/viewvc/llvm-project?rev=275655&view=rev
Log:
Remove extra semi-colon. Fixes warning and Werror bots.
Modified:
cfe/trunk/lib/Driver/Action.cpp
Modified: cfe/trunk/lib/Driver/Action.cpp
URL:
http://llvm
That's fine, thanks.
On Tue, Mar 1, 2016 at 10:52 AM Romanova, Katya <
katya_roman...@playstation.sony.com> wrote:
> Hi Dmitri,
> Thank you for your reply. I have double-checked that compiling a test
> invoking an intrinsic that has C++ style doxygen comments in the
> corresponding header doesn't
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Sorry, I've been waffling on this, but I think this is fine.
Thanks!
-eric
http://reviews.llvm.org/D17183
___
cfe-commits mailing list
cfe-
Test case?
On Fri, Mar 4, 2016, 4:02 AM Bhushan D. Attarde via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bhushan.attarde
> Date: Fri Mar 4 00:56:29 2016
> New Revision: 262691
>
> URL: http://llvm.org/viewvc/llvm-project?rev=262691&view=rev
> Log:
> [MIPS] initFeatureMap() to ha
I've followed up to the original thread, but I'm fairly certain this isn't
the right patch here.
-eric
On Fri, Mar 4, 2016 at 10:28 AM Eric Christopher wrote:
> Test case?
>
> On Fri, Mar 4, 2016, 4:02 AM Bhushan D. Attarde via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: bhu
echristo added a subscriber: echristo.
echristo added a comment.
This seems wrong. You should fix setCPU instead or set a default CPU.
Repository:
rL LLVM
http://reviews.llvm.org/D16139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
echristo added a subscriber: echristo.
echristo added a comment.
Needs a testcase, but otherwise should be fine.
Repository:
rL LLVM
http://reviews.llvm.org/D17952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
-eric
Repository:
rL LLVM
http://reviews.llvm.org/D17952
___
cfe-commits mailing list
On Sat, Mar 5, 2016 at 6:16 AM Daniel Sanders
wrote:
> dsanders added a comment.
>
> In http://reviews.llvm.org/D16139#368217, @echristo wrote:
>
> > This seems wrong. You should fix setCPU instead or set a default CPU.
>
>
> We already set a default CPU in the constructor (e.g.
> Mips32TargetInf
echristo added a comment.
Replied inline, I hope this is helpful :)
Comment at: lib/Basic/Targets.cpp:2059-2063
@@ +2058,7 @@
+
+ if (Has16BitInsts)
+Features["16-bit-insts"] = true;
+
+ if (hasSMemRealTime)
+Features["s-memrealtime"] = true;
+
arsenm
echristo added a subscriber: echristo.
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
This is a compromise I can live with :)
Thanks for doing this Tim.
-eric
http://reviews.llvm.org/D17999
___
On Wed, Mar 9, 2016 at 1:32 PM Tim Northover via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 9 March 2016 at 13:20, David Blaikie via cfe-commits
> wrote:
> > If we are touching these tests at all, as a cleanup, why aren't we
> adjusting
> > them to not pass through the llvm optimizers/
On Wed, Mar 9, 2016 at 11:33 AM Kit Barton via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: kbarton
> Date: Wed Mar 9 13:28:31 2016
> New Revision: 263051
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263051&view=rev
> Log:
> [PPC] FE support for generating VSX [negated] absolute
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM, nice catch Daniel.
(Yes, weird that nothing changed in the IR, but the patch is correct).
-eric
http://reviews.llvm.org/D18015
___
cf
echristo added a comment.
Since you're changing everything anyways? Sure why not! :)
-eric
http://reviews.llvm.org/D18015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: echristo
Date: Fri Mar 11 19:47:11 2016
New Revision: 263320
URL: http://llvm.org/viewvc/llvm-project?rev=263320&view=rev
Log:
Temporarily revert these patches:
commit 60d9845f6a037122d9be9a6d92d4de617ef45b04
Author: Mehdi Amini
Date: Fri Mar 11 18:48:02 2016 +
Fix clang crash
To be clear these were due to test failures under Release (no Asserts)
coming from clang. Mehdi already has a fix in mind.
The bot I mention in followup to the original patch has the test failures.
-eric
On Fri, Mar 11, 2016 at 5:52 PM Eric Christopher via cfe-commits <
cfe-comm
Author: echristo
Date: Mon Mar 14 01:21:07 2016
New Revision: 263410
URL: http://llvm.org/viewvc/llvm-project?rev=263410&view=rev
Log:
Give the test a temporary output so it can be cleaned up.
Modified:
cfe/trunk/test/Driver/cl-pch-showincludes.cpp
Modified: cfe/trunk/test/Driver/cl-pch-show
Author: echristo
Date: Mon Mar 14 03:10:47 2016
New Revision: 263412
URL: http://llvm.org/viewvc/llvm-project?rev=263412&view=rev
Log:
Temporarily make discard value names depend on whether or not we're
trying to track origins in the memory sanitizer since the backend
instrumentation pass currentl
Hi Mehdi,
Just letting you know that I committed a bit of a workaround for
-fsanitize-memory-track-origins after this, the backend instrumentation
pass was depending on the name of the alloca as a way of getting the name
of the variable. I figured though that reverting was probably a bit
overkill
echristo added a comment.
First I'd like to note that the code quality here is really high, most of my
comments are higher level design decisions going with the driver and the
implementation here rather than that.
One meta comment: offload appears to be something that could be used for CUDA
an
Hi Daniel,
Sorry for the delay, but I've been both away and catching up:
On Wed, Mar 9, 2016 at 4:00 AM Daniel Sanders
wrote:
> > > From: Eric Christopher [echri...@gmail.com]
> > > Sent: 09 March 2016 06:50
> > > To: reviews+d16139+public+275805419034a...@reviews.llvm.org; Bhushan
> Attarde; V
Author: echristo
Date: Wed Mar 23 19:34:02 2016
New Revision: 264227
URL: http://llvm.org/viewvc/llvm-project?rev=264227&view=rev
Log:
Modules builds are necessarily compile actions, but they don't
necessarily produce object files. Turn off split dwarf if we're not
producing a file that the driver
Author: echristo
Date: Wed Mar 23 20:26:08 2016
New Revision: 264235
URL: http://llvm.org/viewvc/llvm-project?rev=264235&view=rev
Log:
The time when -faltivec (or, on clang only, -maltivec) will magically
include altivec.h has come and gone.
Rationale: This causes modules, rewrite-includes, etc t
Author: echristo
Date: Wed Mar 23 20:28:25 2016
New Revision: 264236
URL: http://llvm.org/viewvc/llvm-project?rev=264236&view=rev
Log:
Add release notes for the removal of the silent include of altivec.h.
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL
Great, thanks!
On Thu, Mar 24, 2016, 5:26 PM Adrian Prantl wrote:
> I added a testcase that demonstrates the problem with this commit in
> r264366.
>
> -- adrian
> > On Feb 23, 2016, at 11:07 AM, Eric Christopher
> wrote:
> >
> > Thanks Adrian!
> >
> > On Tue, Feb 23, 2016 at 9:19 AM Adrian Pra
echristo added a subscriber: echristo.
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
LGTM, thanks.
-eric
http://reviews.llvm.org/D17002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
Author: echristo
Date: Mon Dec 28 13:07:46 2015
New Revision: 256508
URL: http://llvm.org/viewvc/llvm-project?rev=256508&view=rev
Log:
Fix up comment in header.
Modified:
cfe/trunk/lib/Headers/altivec.h
Modified: cfe/trunk/lib/Headers/altivec.h
URL:
http://llvm.org/viewvc/llvm-project/cfe/t
Author: echristo
Date: Mon Dec 28 13:07:48 2015
New Revision: 256509
URL: http://llvm.org/viewvc/llvm-project?rev=256509&view=rev
Log:
Comment and reorganize some of the target feature option sets.
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Driver/O
Author: echristo
Date: Mon Dec 28 13:58:44 2015
New Revision: 256516
URL: http://llvm.org/viewvc/llvm-project?rev=256516&view=rev
Log:
We check for dwarf 5 in the backend, so go ahead and pass it along via
the front end as well.
Note that DWARF5 isn't finalized and any feature support is subject
Author: echristo
Date: Mon Dec 28 15:57:05 2015
New Revision: 256525
URL: http://llvm.org/viewvc/llvm-project?rev=256525&view=rev
Log:
Fix up a comment and a bit of trailing whitespace.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
http://llvm.org/vi
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM, and thanks for all of the iteration.
-eric
http://reviews.llvm.org/D15223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
echristo accepted this revision.
echristo added a comment.
Sure.
-eric
http://reviews.llvm.org/D15899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Jan 5, 2016 at 12:29 PM Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Jan 05, 2016 at 08:12:34PM +, Dimitry Andric via cfe-commits
> wrote:
> > In rL256641, @davide turned off movt generation by default for FreeBSD.
> > This was because our ld is ver
On Tue, Jan 5, 2016 at 12:43 PM Ed Maste wrote:
> >> Is there a precendent for the option name? It should be -m* and not -f*,
> >> since it is not target independent.
> >
> > Yes, agreed, thanks for the catch Joerg.
>
> Presumably -ffixed_r9 should become -mfixed_r9 as well?
>
That's a bit diffe
Author: echristo
Date: Wed Jan 6 01:24:45 2016
New Revision: 256919
URL: http://llvm.org/viewvc/llvm-project?rev=256919&view=rev
Log:
Change the set of actions built for external gcc tools.
A gcc tool has an "integrated" assembler (usually gas) that it
will call to produce an object. Let it use
Author: echristo
Date: Wed Jan 6 19:23:12 2016
New Revision: 257009
URL: http://llvm.org/viewvc/llvm-project?rev=257009&view=rev
Log:
Test that we're not forwarding on -g options to the non integrated assembler.
This is adding a test for an old fixed PR to make sure we don't regress.
Modified:
Author: echristo
Date: Wed Jan 6 19:23:21 2016
New Revision: 257011
URL: http://llvm.org/viewvc/llvm-project?rev=257011&view=rev
Log:
Remove leading space added in r227312.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaK
Author: echristo
Date: Wed Jan 6 19:23:19 2016
New Revision: 257010
URL: http://llvm.org/viewvc/llvm-project?rev=257010&view=rev
Log:
Use an actual real architecture and massage a couple of comments.
Modified:
cfe/trunk/test/Driver/gcc_forward.c
Modified: cfe/trunk/test/Driver/gcc_forward.c
Author: echristo
Date: Wed Jan 6 20:00:55 2016
New Revision: 257014
URL: http://llvm.org/viewvc/llvm-project?rev=257014&view=rev
Log:
Replace a loop with the call that does the same thing.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
http://llvm.or
echristo added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:363-370
@@ -362,2 +362,10 @@
+// Convenience functions for debugger tuning.
+static bool tuneForGDB(CodeGenOptions &Opts) {
+ return Opts.getDebuggerTuning() == CodeGenOptions::DebuggerKindGDB;
+}
+
echristo added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning() !
echristo added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning() !
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
-eric
http://reviews.llvm.org/D16079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
echristo added a comment.
One question inline, one nit, and one more question here: You've got a couple
of checks inline for null names/architectures, where do you expect those to
come from and can you test for them? Or, another question, is if they're
multiple architectures shouldn't we be abl
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Sure. Seems reasonable.
-eric
http://reviews.llvm.org/D16078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for doing this :)
-eric
http://reviews.llvm.org/D15911
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
echristo added a comment.
So, how are you getting to the point where you're trying to create the same
action twice?
-eric
http://reviews.llvm.org/D15960
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
echristo added a comment.
Yep it's fine. Thanks!
-eric
http://reviews.llvm.org/D16079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo added a comment.
Seems reasonable. Why remove all of the tests though?
http://reviews.llvm.org/D16097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo added a comment.
As long as the list of BAD things is somewhat conclusive I don't mind either
way. Just making sure that this was the reason :)
-eric
http://reviews.llvm.org/D16097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
echristo added a comment.
Still good. much nicer now.
http://reviews.llvm.org/D16097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo accepted this revision.
echristo added a comment.
This is terrible, but the only other option is fixing bind arch and inverting
the graph which is a major rewrite to the driver.
So, LGTM.
-eric
http://reviews.llvm.org/D16082
___
cfe-comm
I'm afk at the moment please revert and add a test case if you can?
On Fri, Jan 15, 2016, 5:24 PM Chris Bieneman wrote:
> +Eric,
>
> If this patch can’t be quickly fixed, can it please be reverted?
>
> -Chris
>
> On Jan 15, 2016, at 4:36 PM, Chris Bieneman via cfe-commits <
> cfe-commits@lists.l
echristo added a comment.
Ultimately they probably shouldn't map to the same toolchain and we can use
that as a key. Looks OK for now though.
http://reviews.llvm.org/D16250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Ultimately they probably shouldn't map to the same toolchain and we can use
that as a key. Looks OK for now though.
On Fri, Jan 15, 2016, 5:48 PM Justin Lebar wrote:
> jlebar created this revision.
> jlebar added a reviewer: tra.
> jlebar added subscribers: cfe-commits, beanz, echristo.
> Herald
At a quick glance Os and Oz should probably map to O2.
On Mon, Jan 18, 2016, 4:19 PM Justin Lebar wrote:
> jlebar created this revision.
> jlebar added a reviewer: tra.
> jlebar added subscribers: jhen, echristo, cfe-commits.
>
> Previously we'd crash the driver if you passed -O0. Now we try to
On Wed, Jan 20, 2016 at 2:32 PM Katya Romanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> kromanova added a comment.
>
> In http://reviews.llvm.org/D15999#330794, @silvas wrote:
>
> > This may sound stupid, but: can you benchmark the time it takes to build
> some project (that actually
On Wed, Jan 20, 2016 at 3:12 PM Sean Silva wrote:
> silvas added a comment.
>
> In http://reviews.llvm.org/D15999#331601, @kromanova wrote:
>
> > In http://reviews.llvm.org/D15999#330794, @silvas wrote:
> >
> > > This may sound stupid, but: can you benchmark the time it takes to
> build some proj
401 - 500 of 571 matches
Mail list logo
