hintonda added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428
@@ -3402,6 +3402,7 @@
// If we already had a dynamic specification, parse the noexcept for,
// recovery, but emit a diagnostic and don't store the results.
- SourceRange NoexceptRange;
+ Sourc
hintonda abandoned this revision.
hintonda added a comment.
This revision is OBE.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Ping...
http://reviews.llvm.org/D20687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
This marcher was recently added, and has never been in a release.
Specifically, it was added by me in support of a checker that has now been
abandoned in lieu of a better approach -- the new approach requires this change
-- so I doubt it would break anything.
That sa
hintonda updated this revision to Diff 59726.
hintonda added a comment.
Update narrowing matchers, isNoThrow and hasDynamicExceptionSpec, to
work with both functionDecl and functionProtoType matchers. Update
tests and regenerate documentation.
Since FunctionDecl and FunctionProtoType are not pol
hintonda updated this revision to Diff 59747.
hintonda added a comment.
Use FunctionProtoType instead of auto for clarity.
http://reviews.llvm.org/D20687
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInternal.h
unit
hintonda updated this revision to Diff 59794.
hintonda added a comment.
Update matcher to use functionProtoType instead of functionType.
http://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptC
hintonda added a comment.
Thanks Aaron. If you could commit for me, I'd appreciate it. Thanks again...
http://reviews.llvm.org/D20687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
hintonda added a comment.
The comment says to rebuild TypeSourceInfo, but isn't that what this does?
if (TSInfo->getType() != FD->getType())
Updated = getFunctionTypeWithExceptionSpec(*this, TSInfo->getType(), ESI);
TSInfo->overrideType(Updated);
If so, could you fix this by either remov
hintonda added a comment.
Current diff is incorrect, but I did find the problem.
When iterating over the fields of a record, we use an iterator. The problem is
that if we use a designator, we reset the iterator value, so we can no longer
check Field != FieldEnd if the designators are out of or
hintonda updated this revision to Diff 49281.
hintonda added a comment.
When checking record initialization, maintain a vector of remaining
fields that were not explicitly initialized and check only those
fields to see if they can be default initialized.
http://reviews.llvm.org/D17407
Files:
hintonda updated this revision to Diff 49295.
hintonda added a comment.
Improve efficiency by using pair<> to maintain counts instead of purging seen
fields.
http://reviews.llvm.org/D17407
Files:
lib/Sema/SemaInit.cpp
test/SemaCXX/cxx0x-initializer-constructor.cpp
Index: test/SemaCXX/cxx0
hintonda created this revision.
hintonda added a reviewer: mclow.lists.
hintonda added a subscriber: cfe-commits.
If you use ccache to build libcxx by setting CXX="ccache
clang++", check-libcxx will fail since LIBCXX_COMPILER will be set to
"ccache".
We can't just include CMAKE_CXX_COMPILER_ARG1
hintonda created this revision.
hintonda added a reviewer: mclow.lists.
hintonda added a subscriber: cfe-commits.
If you use ccache to build libcxxabi by setting CXX="ccache
clang++", check-libcxxabi will fail since LIBCXXABI_COMPILER will be
set to "ccache".
We can't just include CMAKE_CXX_COMPI
hintonda updated this revision to Diff 49772.
hintonda added a comment.
Improve efficiency by only keeping track of seen fields, and only when
designators have been used.
http://reviews.llvm.org/D17407
Files:
lib/Sema/SemaInit.cpp
test/SemaCXX/cxx0x-initializer-constructor.cpp
Index: test/
hintonda added a comment.
ping...
http://reviews.llvm.org/D16971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
I don't have commit access, so could someone commit for me. Thanks...
http://reviews.llvm.org/D17248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Great, thanks David.
http://reviews.llvm.org/D17248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda created this revision.
hintonda added a reviewer: krememek.
hintonda added a subscriber: cfe-commits.
The GR prefix was removed form file and class names, so make
docs and comments match. Also, fix a few minor typos.
http://reviews.llvm.org/D17968
Files:
lib/StaticAnalyzer/README.txt
hintonda created this revision.
hintonda added a reviewer: rjmccall.
hintonda added a subscriber: cfe-commits.
Fix implicit copy ctor and copy assignment operator warnings
when -Wdeprecated passed.
http://reviews.llvm.org/D18123
Files:
include/clang/AST/UnresolvedSet.h
include/clang/Sema/Loo
hintonda added a comment.
LookupResult's copy ctor and assignment operator are used in
Sema::LookupInlineAsmField(). Looks like these were added back in December.
I'll remove the defaults, from this patch, but not sure how to handle
LookupInlineAsmField(). Will add author of that change.
OTO
hintonda added a comment.
Sure, that would be great. Thanks.
http://reviews.llvm.org/D18123
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda updated this revision to Diff 50611.
hintonda added a comment.
Add move ctor and assignment operator defauls to match
UnresolvedSetImpl's contained SmallVector.
Add FIXME note to LookupResult. Will address FIXME once Marina's
pending change to Sema::LookupInlineAsmField() is available.
hintonda added a comment.
Btw, what do you think about making -Wdeprecated the default for llvm/clang
builds?
With this change, llvm/clang will be clean. However, libcxx and libcxxabi have
a bunch of throw warnings.
http://reviews.llvm.org/D18123
__
tdlibs, etc. It'd be great to finish
> the cleanup, or suppress it in system headers, etc, and get it turned on.
>
> On Mon, Mar 14, 2016 at 12:29 PM, don hinton via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> hintonda added a comment.
>>
>> Btw, w
StmtAsm from Marina?
>>>
>>> Are you planning to cleanup -Wdeprecated in libcxx and libcxxabi too?
>>>
>>> I did most of the -Wdeprecated cleanup late last year - but when I tried
>>> to turn it on I hit issues in various stdlibs, etc. It'd be gr
> Sure, that's fine. However, I think we should delete them in
>> LookupResult, right? The implicit copy and assignment ops are wrong and
>> leak otherwise.
>>
>
> Yep. But I'm happy enough to wait for the correct fix from Marina there.
>
Sounds good, just wanted to get the diff out there. than
hintonda updated this revision to Diff 51099.
hintonda added a comment.
Addressed comments.
http://reviews.llvm.org/D17407
Files:
lib/Sema/SemaInit.cpp
test/SemaCXX/cxx0x-initializer-constructor.cpp
Index: test/SemaCXX/cxx0x-initializer-constructor.cpp
=
Done, however, I don't have commit access, so once it's approved, could you
commit it for me?
thanks...
don
On Wed, Mar 16, 2016 at 6:00 PM, David Blaikie wrote:
>
>
> On Wed, Mar 16, 2016 at 11:38 AM, don hinton via cfe-commits <
> cfe-commits@lists.llvm.org> wrote
y ifdef them away. Keeping the clang build -Werror
> clean is a pretty well established bar, so if anyone accidentally
> introduced a call to any of these, we'd find/fix it pretty quickly as we do
> other errors/mistakes, even when they're not hard language-required errors.
>
away for some future compiler that no longer
implicitly defines them.
Just not sure it's worth it. Deleting them will be valid no matter what
the future holds.
On Wed, Mar 16, 2016 at 12:56 PM, David Blaikie wrote:
>
>
> On Wed, Mar 16, 2016 at 7:54 AM, don hinton via cfe-commits <
xplicitly delete these ops if that's
>>> going to be our approach)
>>>
>>> I don't think we'd only ifdef them away. Keeping the clang build -Werror
>>> clean is a pretty well established bar, so if anyone accidentally
>>> introduced a ca
I just did some tests, and when a derived class is explicitly moved, e.g.,
with std::move(), the current behavior is (clang++/g++/vc++):
1) if base has implicit move, it gets called
2) if base doesn't have an implicit move (because a copy ctor was define,
etc) copy ctor is called
3) if base class
hintonda created this revision.
hintonda added reviewers: rsmith, howard.hinnant, logan.
hintonda added a subscriber: cfe-commits.
Fix -Wdeprecated warning for throw() specs and implicit copy
ctor's and assignmen oper's.
http://reviews.llvm.org/D18217
Files:
include/__bit_reference
include/_
btw, in each case, the derived class's move ctor was called.
On Thu, Mar 17, 2016 at 5:36 PM, don hinton wrote:
> I just did some tests, and when a derived class is explicitly moved, e.g.,
> with std::move(), the current behavior is (clang++/g++/vc++):
>
> 1) if base has implicit move, it gets c
hintonda updated this revision to Diff 50843.
hintonda added a comment.
Added FIXME comment, and reformated with clang-format.
http://reviews.llvm.org/D18123
Files:
include/clang/AST/UnresolvedSet.h
include/clang/Sema/Lookup.h
Index: include/clang/Sema/Lookup.h
Dave:
Won't this prevent UnresolvedSet from being movable?
I was under the impression that all subobjects (base class in this case)
had to be movable in order for the compiler to generate implicit move ops.
Is that not the case?
thanks...
don
On Thu, Mar 17, 2016 at 2:28 PM, David Blaikie via c
hintonda added a comment.
Implicit copy ctor's and and assignment operators are deprecated in c++11,
which is why I added them as = default, but you raise a good point. Perhaps it
would be better to wrap them in #ifdef's.
http://reviews.llvm.org/D18217
_
Just to clarify, they are deprecated with an explicit dtor's are provided.
On Sat, Mar 19, 2016 at 11:26 AM, don hinton wrote:
> hintonda added a comment.
>
> Implicit copy ctor's and and assignment operators are deprecated in c++11,
> which is why I added them as = default, but you raise a good
hintonda updated this revision to Diff 51114.
hintonda added a comment.
Address additional comments.
Always maintain SeenFields, not just when designators are seen which
simplies the logic. Note that there is no getNumFields() method, so
we still need to determine the total FieldSize to initiali
hintonda updated this revision to Diff 50823.
hintonda added a comment.
Address FIXME now that Sema::LookupInlineAsmField() has been fixed.
http://reviews.llvm.org/D18123
Files:
include/clang/AST/UnresolvedSet.h
include/clang/Sema/Lookup.h
Index: include/clang/Sema/Lookup.h
===
hintonda added a comment.
Okay, but should I fix the 146 cases of " = default;" that were already there?
That's a lot of churn, so I don't want to step on anyone...
http://reviews.llvm.org/D18217
___
cfe-commits mailing list
cfe-commits@lists.llvm
hintonda added a comment.
Yes, those were mostly in comments. I'd just done a simple find/grep that
didn't take context into account.
I agree that multiple checkins would be best which will make it much easy to
review.
http://reviews.llvm.org/D18217
___
hintonda updated this revision to Diff 50930.
hintonda added a comment.
Fixed comment per Dave's recommendation.
http://reviews.llvm.org/D18123
Files:
include/clang/AST/UnresolvedSet.h
include/clang/Sema/Lookup.h
Index: include/clang/Sema/Lookup.h
==
hintonda marked 7 inline comments as done.
Comment at: lib/Sema/SemaInit.cpp:1815-1816
@@ -1814,3 +1814,4 @@
// worthwhile to skip over the rest of the initializer, though.
RecordDecl *RD = DeclType->getAs()->getDecl();
RecordDecl::field_iterator FieldEnd = RD->field_end(
hintonda added a comment.
I'm probably missing something, but isn't
InitListChecker::CheckStructUnionTypes() called recursively, if indirectly? In
which case we'd want to start from the Field iterator we were given, not the
look at all the fields.
http://reviews.llvm.org/D17407
__
hintonda added inline comments.
Comment at: lib/Sema/SemaInit.cpp:1926-1927
@@ +1925,4 @@
+ assert(Field != FieldEnd);
+ if (SeenFields[i])
+continue;
+ if (!Field->isUnnamedBitfield() && !Field->hasInClassInitializer() &&
rsmith wrote:
> Us
hintonda added a comment.
Sorry the previous change caused this configuration to break. However, I'm not
sure about adding LLVMExports here. Shouldn't that be handled in
llvm/CMakeLists.txt?
In fact, this looks like a cmake bug (or feature) that won't let you export a
target that depends on
hintonda added a comment.
Ah, great. That is simpler.
http://reviews.llvm.org/D16158
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
201 - 249 of 249 matches
Mail list logo
