hintonda created this revision.
hintonda added reviewers: doug.gregor, lvoufo.
hintonda added a subscriber: cfe-commits.
The code sets isPartialSpecialization = false instead of returning true, which
will cause a crash later when the missing template parameter is referenced.
http://reviews.llvm.
hintonda added a comment.
Here's a snippet of code that will crash:
lass DB {};
template class RemovePolicy : public T {};
template >
class Crash : T, Policy {};
template
class Crash : public DB, public Policy {
public:
Crash(){}
};
http://reviews.llvm.org/D16971
hintonda added a comment.
ping
http://reviews.llvm.org/D13622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Great, thanks. Btw, I don't have commit access, so could you commit for me?
thanks don
http://reviews.llvm.org/D13622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
hintonda added a comment.
This patch fixes bug 26077.
https://llvm.org/bugs/show_bug.cgi?id=26077
http://reviews.llvm.org/D16971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda created this revision.
hintonda added reviewers: doug.gregor, rnk.
hintonda added a subscriber: cfe-commits.
Fixes crash referenced in PR25181 where dyn_cast is called on a null instance
of LM.Method.
http://reviews.llvm.org/D17072
Files:
lib/Parse/ParseCXXInlineMethods.cpp
Index: l
hintonda updated this revision to Diff 47456.
hintonda added a comment.
- Reformatted change with clang-format
http://reviews.llvm.org/D17072
Files:
lib/Parse/ParseCXXInlineMethods.cpp
Index: lib/Parse/ParseCXXInlineMethods.cpp
hintonda updated this revision to Diff 47499.
hintonda added a comment.
- Added test for PR26077
http://reviews.llvm.org/D16971
Files:
lib/Sema/SemaTemplate.cpp
test/SemaCXX/pr26077-crash-on-invalid.cpp
Index: test/SemaCXX/pr26077-crash-on-invalid.cpp
==
hintonda updated this revision to Diff 47501.
hintonda added a comment.
- Added test for PR25181
http://reviews.llvm.org/D17072
Files:
lib/Parse/ParseCXXInlineMethods.cpp
test/SemaCXX/pr25181-crash-on-invalid.cpp
Index: test/SemaCXX/pr25181-crash-on-invalid.cpp
hintonda added a comment.
I don't have commit access, so if this patch is accepted, could someone please
commit it for me?
http://reviews.llvm.org/D17072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
hintonda added a comment.
I don't have commit access, so if this patch is accepted, could someone please
commit it for me?
http://reviews.llvm.org/D16971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
hintonda created this revision.
hintonda added reviewers: doug.gregor, majnemer.
hintonda added a subscriber: cfe-commits.
Fix crash from PR25156 where getDestructorName() calls LookupQualifiedName() on
incomplete type.
http://reviews.llvm.org/D17143
Files:
lib/Sema/SemaExprCXX.cpp
test/Sem
hintonda added a comment.
Thanks Marshall.
Btw, I don't have commit access, so if approved, could someone commit this for
me?
http://reviews.llvm.org/D16946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
hintonda created this revision.
hintonda added reviewers: lvoufo, rjmccall.
hintonda added a subscriber: cfe-commits.
Fix PR14211
Only add FunctionDecl's that are actual template methods to the set of
matches passed to getMostSpecializied() -- otherwise it will
assert/crash. If a match to a non-
hintonda updated this revision to Diff 47914.
hintonda added a comment.
- Simplify diff
http://reviews.llvm.org/D17143
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/pr25156-crash-on-invalid.cpp
Index: test/SemaCXX/pr25156-crash-on-invalid.cpp
hintonda updated this revision to Diff 47923.
hintonda added a comment.
- Only call HandleMemberFunctionDeclDelays() for valid NamedDecl pointers.
HandleMemberFunctionDeclDelays() adds LateParsedMethodDeclaration elements to
LateParsedDeclarations if the method has default args or
exception-s
hintonda created this revision.
hintonda added a reviewer: majnemer.
hintonda added a subscriber: cfe-commits.
Sema allows max values up to 2**28, use unsigned instead of unsiged
short to hold values that large.
http://reviews.llvm.org/D17248
Files:
lib/CodeGen/CGValue.h
test/Sema/attr-align
hintonda updated this revision to Diff 47999.
hintonda added a comment.
- Renamed variables to make code self-documenting
http://reviews.llvm.org/D17215
Files:
lib/Sema/SemaTemplate.cpp
test/SemaCXX/pr14211-crash-on-invalid.cpp
Index: test/SemaCXX/pr14211-crash-on-invalid.cpp
=
hintonda added a comment.
Btw, I don't have commit access, so if accepted, could you please commit for me.
http://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
hintonda added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7845
@@ -7842,1 +7844,3 @@
+ } else
+NonTemplateMatch = Method;
}
rjmccall wrote:
> Could you add an assertion here that NonTemplateMatch is still null? That
> sh
hintonda updated this revision to Diff 48031.
hintonda added a comment.
- Added assert and additional test
http://reviews.llvm.org/D17215
Files:
lib/Sema/SemaTemplate.cpp
test/SemaCXX/pr14211-crash-on-invalid.cpp
Index: test/SemaCXX/pr14211-crash-on-invalid.cpp
hintonda added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7848
@@ -7842,2 +7847,3 @@
+ }
}
}
Got it...
http://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lis
hintonda added a comment.
Ping,..
Could someone commit this for me?
http://reviews.llvm.org/D13622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda created this revision.
hintonda added reviewers: majnemer, rsmith.
hintonda added a subscriber: cfe-commits.
Added checks to make sure the return type and parameter types for functions
declared as extern "C" have external linkage.
http://reviews.llvm.org/D17362
Files:
include/clang/Ba
hintonda added a comment.
Here's an example of when this will cause a crash:
namespace {
Struct G;
extern "C" G *f(); // has external linkage
G *f();// will assert since it has internal linkage because of G
and doesn't match previous declaration
}
http://reviews.llvm.org/D17362
hintonda added a comment.
This also causes a few other test failures (~8) which will need to be fixed if
this patch is accepted.
http://reviews.llvm.org/D17362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
hintonda created this revision.
hintonda added a reviewer: rsmith.
hintonda added a subscriber: cfe-commits.
Remove assert that fired whenever initialization lists had
errors, and pass VerifyOnly=false to PerformEmptyInit so we'll get diagnostics.
http://reviews.llvm.org/D17407
Files:
lib/Sema
hintonda updated this revision to Diff 48561.
hintonda added a comment.
- Fix additional tests
http://reviews.llvm.org/D17407
Files:
lib/Sema/SemaInit.cpp
test/CXX/dcl.decl/dcl.init/dcl.init.list/p3-0x.cpp
test/SemaCXX/cxx0x-initializer-aggregates.cpp
test/SemaCXX/cxx0x-initializer-cons
hintonda added a comment.
This change breaks a couple tests in test/SemaCXX/linkage.cpp where we no
longer allow mixing internal and external linkage, i.e., extern "C" functions
have external linkage no matter where they are declared, but return types and
parameters declared in anonymous namesp
hintonda updated this revision to Diff 48601.
hintonda added a comment.
Fixed additional tests.
http://reviews.llvm.org/D17362
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/CXX/drs/dr3xx.cpp
test/Sema/pr23090-crash-on-invalid.cpp
test/SemaCXX/warn-unused
hintonda updated this revision to Diff 48617.
hintonda added a comment.
- Fix remaining test failures caused by linkage errors.
http://reviews.llvm.org/D17362
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/CXX/drs/dr3xx.cpp
test/Sema/pr23090-crash-on-invali
hintonda updated this revision to Diff 48742.
hintonda added a comment.
Added comment
Added comment to test file.
http://reviews.llvm.org/D17248
Files:
lib/CodeGen/CGValue.h
test/Sema/attr-aligned.c
Index: test/Sema/attr-aligned.c
===
hintonda added a comment.
Thanks David. Btw, could you commit it for me? I don't have commit access.
http://reviews.llvm.org/D17248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda updated this revision to Diff 48815.
hintonda added a comment.
Moved new test into existing test file.
http://reviews.llvm.org/D17407
Files:
lib/Sema/SemaInit.cpp
test/CXX/dcl.decl/dcl.init/dcl.init.list/p3-0x.cpp
test/SemaCXX/cxx0x-initializer-aggregates.cpp
test/SemaCXX/cxx0x
hintonda created this revision.
hintonda added a reviewer: alexfh.
hintonda added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Add new ASTMatcher that matches dynamic exception specifications.
http://reviews.llvm.org/D20052
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index
hintonda updated this revision to Diff 56511.
hintonda added a comment.
Addressed additional comments.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/Us
hintonda updated this revision to Diff 56521.
hintonda added a comment.
- Fix typo in docs.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/UseNoexceptCh
hintonda updated this revision to Diff 56522.
hintonda added a comment.
- Added test, re-generated documentation, and add new matcher to the dynamic
matchers registry.
http://reviews.llvm.org/D20052
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTM
hintonda added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3229
@@ +3228,3 @@
+/// matches the declarations of j, k, and l, but not f, g, h, or i.
+AST_MATCHER(FunctionDecl, hasDynamicExceptionSpec) {
+ if (const auto *FnTy = Node.getType()->getAs())
--
hintonda added a comment.
Great, thanks. Btw, I don't have commit access, so could you land it for me?
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda updated this revision to Diff 56984.
hintonda added a comment.
Created helper function and moved most logic there. Also address a
few comments.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/moder
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:36
@@ +35,3 @@
+
+bool UseNoexceptCheck::helper(const MatchFinder::MatchResult &Result,
+ const SourceRange &Range,
alexfh wrote:
> The name "helper"
hintonda updated this revision to Diff 57065.
hintonda added a comment.
- Renamed private helper method
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/U
hintonda updated this revision to Diff 57070.
hintonda added a comment.
- Added 's around keywords in docs.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/moderni
hintonda added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:32
@@ +31,3 @@
+``noexcept(false)``. Additinally, users can also use
+:option:``ReplacementString`` to specify a macro to use instead of
+``noexcept``. This is useful when maintaining s
hintonda added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:32
@@ +31,3 @@
+``noexcept(false)``. Additinally, users can also use
+:option:``ReplacementString`` to specify a macro to use instead of
+``noexcept``. This is useful when maintaining s
hintonda updated this revision to Diff 57078.
hintonda added a comment.
- Fix quote problem in docs.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/UseN
hintonda updated this revision to Diff 57080.
hintonda added a comment.
- Add :option: prefix for clarity.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/moderniz
hintonda added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:50
@@ +49,2 @@
+
+if the :option:`ReplacementString` option is set to `NOEXCEPT`.
I'll get it eventually... ;-)
http://reviews.llvm.org/D18575
_
hintonda updated this revision to Diff 57097.
hintonda added a comment.
- Addressed a few comments for clarity/readability.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
cl
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:97
@@ +96,3 @@
+void UseNoexceptCheck::check(const MatchFinder::MatchResult &Result) {
+ auto FuncDecl = Result.Nodes.getNodeAs("functionDecl");
+ if (!FuncDecl)
etienneb wrote
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:99
@@ +98,3 @@
+ if (Tok.is(tok::l_paren)) {
+Tok = getPreviousNonCommentToken(Context, Tok.getLocation());
+found = std::string(GetText(Tok, SM)) + "(true)";
---
hintonda updated this revision to Diff 57103.
hintonda added a comment.
Regenerated diff to make sure I pick up all changed files.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.c
hintonda added inline comments.
Comment at: clang-tidy/utils/LexerUtils.cpp:38
@@ -37,1 +37,3 @@
+SmallVector ParseTokens(const ASTContext &Context,
+ const SourceManager &Sources,
I regenerated the diff -- the last few arc diff
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.h:44-45
@@ +43,4 @@
+ unsigned &Len);
+ const std::string ReplacementStr;
+ StringRef Replacement;
+};
aaron.ballman wrote:
> What is the difference between these
hintonda added a comment.
I agree -- things got messy.
I'm in the process of completely refactoring the whole thing -- including the
ast matchers that I'll checkin later today. Thanks for your patience.
http://reviews.llvm.org/D18575
___
cfe-comm
hintonda updated this revision to Diff 57290.
hintonda added a comment.
- Added new isThrow matcher to complement isNoThrow, and changed
hadDynamicExceptionSpec to take a parameter, e.g., isThrow() or isNoThrow().
http://reviews.llvm.org/D20052
Files:
docs/LibASTMatchersReference.html
incl
hintonda updated this revision to Diff 57298.
hintonda added a comment.
- Complete refactor
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/UseNoexceptCh
hintonda updated this revision to Diff 57299.
hintonda added a comment.
- Make helper functions static.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/U
hintonda updated this revision to Diff 57301.
hintonda added a comment.
- Added asserts for indexes into Tokens array.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-t
hintonda updated this revision to Diff 57305.
hintonda added a comment.
- A bit more refactoring and cleanup.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/moder
hintonda added a comment.
I think this is now ready for review.
Thanks again for your patience...
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda updated this revision to Diff 57315.
hintonda added a comment.
- Fix some function names.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/UseNoe
hintonda added a comment.
Great, unless() was what I was missing. I'll refactor along those lines.
As for what I'm trying to achieve, I want a set containing "throw()" and
another set containing "throw(something)". If there's a cleaner way to achieve
that with an existing matcher, please let
hintonda added a comment.
Great, that's exactly what I needed. I'll revert back to the previous version.
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
hintonda updated this revision to Diff 57356.
hintonda added a comment.
Revert back to previous version.
http://reviews.llvm.org/D20052
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchers
hintonda updated this revision to Diff 57357.
hintonda added a comment.
- Revert back to previous version of the matcher and use Aaron's syntax with
allOf and unless to achieve the same results -- much simpler.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang
hintonda added a comment.
Great, thanks again. This has been a great learning experience.
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:21
@@ +20,3 @@
+
+static StringRef
+makeDynamicExceptionString(const SourceManager &SM,
aaron.ballman wrote:
> Instead of a bunch of static functions, would an unnamed namespace
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:46
@@ +45,3 @@
+ const SmallVector &Tokens) {
+ // Find throw token -- it's a keyword, so there can't be more than one.
Also,
+ // it should be near the end of the decla
hintonda updated this revision to Diff 57432.
hintonda added a comment.
- Address additional comments.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/Us
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:39
@@ +38,3 @@
+
+ // FIXME: Add paren matching so we can parse more complex throw statements,
+ // e.g., (examples provided by Aaron Ballman):
aaron.ballman wrote:
> @alexfh,
hintonda updated this revision to Diff 57547.
hintonda added a comment.
- First cut on a simple parser for decls.
Successfully parses all the examples I've been given so far. Please
help me break it.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/mode
hintonda updated this revision to Diff 57555.
hintonda added a comment.
- Added another test.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/UseNoexcept
hintonda updated this revision to Diff 57686.
hintonda added a comment.
Improved matcher logic and add better range handling to try to deal
with multiple asserts concerning bad ranges when running checker again
real code, e.g., libcxx.
Even so, still seeing some asserts in Lexer::getSourceLocatio
hintonda added a comment.
I can already catch all of these cases, but I can't catch this one, will this
catch it too?
void g(void (*fp)(void) throw()) throw();
^^^
http://reviews.llvm.org/D20428
___
cfe-commits mail
hintonda updated this revision to Diff 57811.
hintonda added a comment.
Adjust matcher, add better error checking, and additional test cases.
We can now parse all dynamic exception specifications, but haven't
been able to develop a matcher that will find the following function
declaration without
hintonda added a comment.
Btw, this version can successfully check libcxx.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Sure that sounds good to me. However, I would like to learn how to write
better ASTMatchers.
In any case, this has been a great learning experience.
http://reviews.llvm.org/D20428
___
cfe-commits mailing list
cfe-commits
hintonda created this revision.
hintonda added a reviewer: alexfh.
hintonda added a subscriber: cfe-commits.
This checker allows users to replace deprecated throw()
specifications with noexcept.
It also allows users to replace an arbitrary list of macros with
either noexcept or a user defined mac
hintonda added a comment.
Will do, but that will have to be done in it's own patch.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Sounds like a good idea. I'll add the additional transformations you mentioned
and remove s/noexcept(true)/noexcept/.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:24
@@ +23,3 @@
+ char delimiter) {
+ SmallVector Cand
hintonda added a subscriber: hintonda.
hintonda added a comment.
With this change, won't you need to update 2 different repos: clang and extra?
Is it possible to update both with a single Phabricator patch?
http://reviews.llvm.org/D18509
___
cfe-c
hintonda updated this revision to Diff 52322.
hintonda added a comment.
Address comments and refactor.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/Us
hintonda marked 8 inline comments as done.
hintonda added a comment.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Addressed comments and believe it's ready for review.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
I moved over the weekend, but will try to take a look at this tonight and
address all your comments. Thanks again...
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
hintonda added a comment.
Will do -- moved and started new job, so got a bit behind.
Btw, I have a new checker that's under review that will take care of the
noexcept for you. And I think someone else has something that might take care
of the implicit copy/assignment.
So this should be trivia
hintonda abandoned this revision.
hintonda added a comment.
If *_COMPILER_ARG1 is set, then it shall be the compiler, and the value for
CMAKE__COMPILER may be ccache, but could also be something else, e.g.,
distcc, etc. Therefore, I don't see a clean way to check it.
However, newer versions of
hintonda abandoned this revision.
hintonda added a comment.
If *_COMPILER_ARG1 is set, then it shall be the compiler, and the value for
CMAKE__COMPILER may be ccache, but could also be something else, e.g.,
distcc, etc. Therefore, I don't see a clean way to check it.
However, newer versions of
hintonda updated this revision to Diff 54022.
hintonda added a comment.
Addressed most comments.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/UseNoexc
hintonda marked 9 inline comments as done.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:62
@@ +61,3 @@
+
+ const FunctionDecl *FuncDecl =
+ Result.Nodes.getNodeAs("functionDecl");
Still need to fix the call in UseOverrideCheck.cpp, but will wait til
hintonda updated this revision to Diff 58151.
hintonda added a comment.
Fixed matcher -- added 'unless(isImplicit())'. Thanks to Aaron Ballman for the
suggestion.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang
hintonda added a comment.
In http://reviews.llvm.org/D18575#435388, @alexfh wrote:
> Let's wait for http://reviews.llvm.org/D20428
No worries.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
hintonda added a comment.
Actually, this will never work correctly -- in fact, raw lexing will always be
problematic. Consider:
void foo()
#if !__has_feature(cxx_noexcept)
throw(std::bad_alloc)
#endif
{}
In this case we *could* figure out if __has_feature(cxx_noexcept) evaluated to
true o
hintonda created this revision.
hintonda added a reviewer: aaron.ballman.
hintonda added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Update hasDynamicExceptionSpec to use functionType instead of
functionDecl.
http://reviews.llvm.org/D20687
Files:
docs/LibASTMatchersReference.
hintonda created this revision.
hintonda added reviewers: alexfh, aaron.ballman.
hintonda added subscribers: etienneb, Eugene.Zelenko, cfe-commits.
[clang-tidy] New checker to replace dynamic exception
specifications
This is an alternative to D18575 which relied on reparsing the decl to
find the
hintonda added a comment.
Please see http://reviews.llvm.org/D20693 for an alternative approach.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428
@@ -3402,6 +3402,7 @@
// If we already had a dynamic specification, parse the noexcept for,
// recovery, but emit a diagnostic and don't store the results.
- SourceRange NoexceptRange;
+ Sourc
hintonda added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428
@@ -3402,6 +3402,7 @@
// If we already had a dynamic specification, parse the noexcept for,
// recovery, but emit a diagnostic and don't store the results.
- SourceRange NoexceptRange;
+ Sourc
101 - 200 of 249 matches
Mail list logo
