[PATCH] D52696: Update ifunc attribute support documentation

DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D52696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

DmitryPolukhin added a comment. @mgehre @yvvan it seems that the issue still not fixed and '\n' gets duplicated in the replacements. Are you going to fix this issue or I should create a patch to fix it? Before this change '\n' was actually processed correctly `ReplacementText: '#include \n\n'`

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: gribozavr, mgehre, yvvan. DmitryPolukhin added projects: clang-tools-extra, clang. Herald added subscribers: hiraditya, xazax.hun. Herald added a project: LLVM. DmitryPolukhin edited the summary of this revision. Move new line d

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

DmitryPolukhin added a comment. Sent D80301 for review. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63482/new/ https://reviews.llvm.org/D63482 ___ cfe-commits mailing list cfe-commi

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 265292. DmitryPolukhin added a comment. Fix clang-tidy warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: clang/include/clang/Tooling/Replacements

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 265329. DmitryPolukhin added a comment. Fixed second string after new line + more test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: clang/includ

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin added reviewers: Eugene.Zelenko, thegameg. DmitryPolukhin marked an inline comment as done. DmitryPolukhin added subscribers: thegameg, Eugene.Zelenko. DmitryPolukhin added a comment. + @gribozavr, @Eugene.Zelenko, @thegameg who touched/reviewed this code, please take a look. ==

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:116-121 + unsigned Priority = 0; for (ClangTidyModuleRegistry::iterator I = ClangTidyModuleRegistry::begin(), E = ClangTidyModuleRegis

[PATCH] D84850: [clang-tidy] Fix module options being registered with different priorities

DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. Thank you for identifying and fixing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84850/new/ https://reviews.llvm.org/D84850

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @alexfh friend ping, please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 ___ cfe-commits mailing list cfe-commit

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @alexfh thank you for review! Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.h:101-104 +ClangTidyValue(const char *Value) : Value(Value), Priority(0) {} +ClangTidyValue(const std::string &Value) : Value(Value), Priority(0) {} +

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 257336. DmitryPolukhin marked 6 inline comments as done. DmitryPolukhin added a comment. Comments resolved + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D7518

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 257338. DmitryPolukhin added a comment. Remove clang-format errors in diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files: clang-tools-extra/clang-tidy/

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 257344. DmitryPolukhin added a comment. One more try to remove useless lint issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files: clang-tools-extra/cla

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 257405. DmitryPolukhin added a comment. And one more time :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 257633. DmitryPolukhin added a comment. Split BitOffset in DeclOffset in high/low parts; rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files: clang/in

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 257632. DmitryPolukhin added a comment. Split BitOffset in DeclOffset in high/low parts; rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files: clang/in

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 257635. DmitryPolukhin added a comment. Fix nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files: clang/include/clang/Serialization/ASTBitCodes.h clang/

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. @sammccall thank you for review! I'll wait for one more day for additional feedback if any, and land this diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb1ee34e9d32: [clang-tidy] Optional inheritance of file configs from parent directories  (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @thakis sorry, I didn't notice the issue because of massive breakage with diff landed just be bore mine and also cmake issues on Windows bots. Thank you for trying to fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @thakis, I don't see this bot on LLVM http://lab.llvm.org:8011/console Windows bots there still fail due to cmake issues. The issue is very real and thank you for pointing out but how should I find the bot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 268583. DmitryPolukhin added a comment. Apply suggested changes with string split Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: clang/include/clang/To

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin added inline comments. Comment at: llvm/lib/Support/YAMLTraits.cpp:894 + std::string &Val) { + Val.clear(); + size_t CurrentPos = 0; njames93 wrote: > If you want to do the same here... > ``` > SmallVec

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 268736. DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. Rewrite input string split too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 268737. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. Fix spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: cl

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 270206. DmitryPolukhin added a comment. Fix single new line handling, it should be replace with space Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: cl

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 270351. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: clang/include/clang/Tooling/ReplacementsYaml.h llvm/lib

[PATCH] D79285: [clang-tidy] Add diagnostics level to YAML output

DmitryPolukhin added a reviewer: aaron.ballman. DmitryPolukhin added a subscriber: aaron.ballman. DmitryPolukhin added a comment. @alexfh, @gribozavr2, @aaron.ballman - friendly ping, please take a look to this diff. It is just trivial implementation of TODO in the code. Repository: rG LLVM G

[PATCH] D79285: [clang-tidy] Add diagnostics level to YAML output

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added inline comments. Comment at: clang/include/clang/Tooling/DiagnosticsYaml.h:109 + static void enumeration(IO &IO, clang::tooling::Diagnostic::Level &Value) { +IO.enumCase(Value, "Warning", clang::tooling::D

[PATCH] D79285: [clang-tidy] Add diagnostics level to YAML output

DmitryPolukhin added a comment. @aaron.ballman thank you for review and quick response! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79285/new/ https://reviews.llvm.org/D79285 ___ cfe-commits mailing

[PATCH] D79285: [clang-tidy] Add diagnostics level to YAML output

This revision was automatically updated to reflect the committed changes. Closed by commit rGc98c94d85f85: [clang-tidy] Add diagnostics level to YAML output (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79285/new/ https

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. In D75184#2093089 , @njames93 wrote: > As an afterthought, Would you think it a good idea to extend this logic to > the `ConfigOptionsProvider` That way you can use something along the lines of: > > clang-tidy --config='{

[PATCH] D81949: [clang-tidy] Extend InheritParentConfig to CommandLineConfig

DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81949/new/ https://reviews.llvm.org/D81949 ___

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 271232. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: clang/include/clang/Tooling/ReplacementsYaml.h llvm/lib

[PATCH] D80301: [yaml][clang-tidy] Fix multiline YAML serialization

DmitryPolukhin added a comment. @njames93 and @aaron.ballman - please take a look to this diff. Multiline replacements in YAML are broken and cannot be applied correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llv

[PATCH] D80301: [yaml][clang-tidy] Fix multiline YAML serialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e7fddbd36f5: [yaml][clang-tidy] Fix multiline YAML serialization (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ htt

[PATCH] D80301: [yaml][clang-tidy] Fix multiline YAML serialization

DmitryPolukhin added a comment. @aaron.ballman - thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 ___ cfe-commits mailing list cfe-comm

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin added a comment. @njames93 - friendly ping, could you please take another look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 ___ cfe-commits m

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin added a comment. It looks like there is no support for the proposed solution so I found alternative solution that might be even better. We can use double quotation `"` for multiline strings. It solves problem because in case of double quotation LLVM escapes new line like `\n` so

[PATCH] D80301: [yaml][clang-tidy] Fix multiline YAML serialization

DmitryPolukhin updated this revision to Diff 272952. DmitryPolukhin added a comment. Use double quotation for multiline strings. It solves problems with internal newlines because now they are escaped. Also double quotation solves the problem with leading whitespace after newline. In case of sing

[PATCH] D80301: [yaml][clang-tidy] Fix multiline YAML serialization

DmitryPolukhin updated this revision to Diff 272996. DmitryPolukhin added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: clang/include/clang/Tooling/ReplacementsYaml.h clang/

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

This revision was automatically updated to reflect the committed changes. Closed by commit rG30d5946db95f: [clang][AST] Support AST files larger than 512M (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https:/

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin added a comment. In D76594#1986846 , @martong wrote: > I am not sure, but maybe this patch causes an undefined behavior? > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/40472/steps/check-clang%20ubsan/logs/stdio >

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 258088. DmitryPolukhin added a comment. Split TypeOffsets to low/high parts too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files: clang/include/clang/Seri

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:228 + /// value in the padding affects AST hash. + uint32_t BitOffsetLow = 0; + uint32_t BitOffsetHigh = 0; sammccall wrote: > consider making this a

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 258192. DmitryPolukhin marked 3 inline comments as done. DmitryPolukhin added a comment. Comments resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files:

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7afb211dc46: [clang][AST] Support AST files larger than 512M (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https:/

[PATCH] D79285: [clang-tidy] Add diagnostics level to YAML output

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: alexfh, gribozavr2. DmitryPolukhin added projects: clang-tools-extra, clang. Herald added a subscriber: xazax.hun. Also added BuildDirectory for completness and removed unused `Fix`. Test Plan: check-all Repository: rG LLVM

[PATCH] D79285: [clang-tidy] Add diagnostics level to YAML output

DmitryPolukhin added a comment. @alexfh and @gribozavr2 friendly ping could you please take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79285/new/ https://reviews.llvm.org/D79285 ___ cfe-commi

[PATCH] D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: Tyker, rsmith, aaron.ballman. DmitryPolukhin added a project: clang. Herald added subscribers: kadircet, arphaman. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added subscribers: cfe-commi

[PATCH] D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors

DmitryPolukhin updated this revision to Diff 460437. DmitryPolukhin added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133948/new/ https://reviews.llvm.org/D133948 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

DmitryPolukhin added a comment. @ivanmurashko Overall looks good to me but please re-upload patch on top of some stable revision where failed test passes (it seems unrelated to your changes). `struct Include` is a light weight structure so having a copy seems to be the simplest solution. Rep

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added a comment. Sorry, I don't think it's worth reverting and resubmitting the same changes in such a case. Commit attribution is correct and there is link to this code review. After all, most clang-tidy users will never read commit messages and will only use `--help` for discov

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: alexfh, njames93, thakis. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added subscribers: kbarton, xazax.hun, nemanjai. DmitryPolukhin requested review of this revision. This diff is an attempt to workaround a

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin updated this revision to Diff 303121. DmitryPolukhin added a comment. Fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90835/new/ https://reviews.llvm.org/D90835 Files: clang-tools-extra/clang-tidy/ClangTidyDia

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin updated this revision to Diff 306046. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. - addressed comments in the diff - stop ignoring system macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90835/n

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin added a comment. @njames93 thank you for the feedback! Still waiting for more feedback and especially high level one about this feature in general. Does it look useful? Should it be behind a flag i.e. changing default behaviour is too dangerous? Comment at: cl

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: alexfh, gribozavr, klimek. DmitryPolukhin added a project: clang-tools-extra. Herald added subscribers: kbarton, xazax.hun, nemanjai. Herald added a project: clang. DmitryPolukhin requested review of this revision. In memory VFS

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

DmitryPolukhin updated this revision to Diff 299697. DmitryPolukhin added a comment. Linting diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89886/new/ https://reviews.llvm.org/D89886 Files: clang-tools-extra/clang-tidy/ExpandModularHeadersPP

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

DmitryPolukhin updated this revision to Diff 299698. DmitryPolukhin added a comment. And one more time linting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89886/new/ https://reviews.llvm.org/D89886 Files: clang-tools-extra/clang-tidy/ExpandMod

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

DmitryPolukhin updated this revision to Diff 299977. DmitryPolukhin added a comment. Added all module map file names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89886/new/ https://reviews.llvm.org/D89886 Files: clang-tools-extra/clang-tidy/Exp

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. In D89886#2346851 , @alexfh wrote: > Ah, btw, any chance of adding a test for this? Oh, I was not able to create small reproducer that without including large Apple Framewor

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

This revision was automatically updated to reflect the committed changes. DmitryPolukhin marked an inline comment as done. Closed by commit rG55a2deed075b: [clang-tidy] Fix redefinition of module in the same module.modulemap file (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo

[PATCH] D89936: clang-tidy: adding "--clang-tidy-config=" to specify custom config file

DmitryPolukhin added a comment. I'm not sure that we need additional option to read configuration from file but, if we do need, I think this diff needs some improvements + test for new option. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:324 +llvm::sys::f

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

DmitryPolukhin added a comment. @Hiralo, it looks like you uploaded wrong diff because your previous revision is shown as "base" version. Base revision should be clang-tidy sources without your changes. Please add Lit test for the new option, see https://llvm.org/docs/TestingGuide.html for mor

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

DmitryPolukhin added a comment. Yes, it is what I meant as a simpler solution. But please add Lit test even for such trivial option. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:337 + +Config.assign((*Text)->getBuffer()); + } I suggest

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/config-file.cpp:2 +// REQUIRES: shell +// RUN: mkdir -p %T/config-file/ +// RUN: cp %s %T/read-file-config/test.cpp I think it is better to use some file in `%S/Inp

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

DmitryPolukhin added a comment. I think this diff looks very close to what we need. I hope it will be the last iteration. Please also update title and description with the new name of the option, etc. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/config-file.cp

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:337 + +Config.assign((*Text)->getBuffer()); + } DmitryPolukhin wrote: > I suggest creating new local variable with text of the config from `Config` > or `C

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added a comment. In D89936#2361580 , @njames93 wrote: > It's also be nice if --config-file would also support being passed a > directory. If a directory was passed it would append ".clang-tidy" to the > path and load that file, WDYT? It m

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:320-324 +if (!Checks.empty()) { + llvm::errs() << "Error: --config-file and --checks are mutually " + "exclusive. Specify only one.\n"; + retur

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:320-324 +if (!Checks.empty()) { + llvm::errs() << "Error: --config-file and --checks are mutually " + "exclusive. Specify only one.\n"; + retur

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89936/new/ https://reviews.llvm.org/D89936

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added a comment. In D89936#2370163 , @Hiralo wrote: > When this patch will be merged and available in master? @Hiralo I can push this changes to master for you. Please let me know if you need it. Repository: rG LLVM Github Monorepo CH

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6a468d622b2: [clang-tidy] adding "--config-file=" to specify custom config file. (authored by Hiralo, committed by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added a comment. > Hello @@DmitryPolukhin , > > When I submitted latest via 'arc diff' my commit-message was... > Can you please help to have following commit message? Below commit message is > more clear and helpful. > Sorry for inconvenience caused! It is not possible to update

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

DmitryPolukhin added inline comments. Comment at: clang/include/clang/Tooling/Core/Diagnostic.h:72 +Error = DiagnosticsEngine::Error, +Remark = DiagnosticsEngine::Remark }; nit, I would move remark first to have list by increasing severity. It looks l

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: dexonsmith, bruno, rsmith. DmitryPolukhin added a project: clang. Herald added subscribers: usaxena95, ormris, kadircet, arphaman. DmitryPolukhin requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 347862. DmitryPolukhin added a comment. Fix clang-format issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D103142 Files: clang/include/clang/Lex/HeaderMap.h c

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 347864. DmitryPolukhin added a comment. Fix linter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D103142 Files: clang/include/clang/Lex/HeaderMap.h clang/lib/Lex

[PATCH] D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin updated this revision to Diff 347968. DmitryPolukhin added a comment. Herald added a subscriber: dexonsmith. Added test for system like object macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90835/new/ https://reviews.llvm.org/D9

[PATCH] D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin added a comment. @alexfh, @njames93 and @thakis please take a look! I added all tests cases and put new logic behind a flag to make it as safe as possible. Issue with diagnostics from macro expansion from third-party headers is the one of the biggest problem with deployment that w

[PATCH] D103229: [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: dexonsmith, bruno. DmitryPolukhin added a project: clang. DmitryPolukhin requested review of this revision. NFC changes required for https://reviews.llvm.org/D103142 Test Plan: check-clang Repository: rG LLVM Github Monorep

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 348183. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. Split changes into NFC https://reviews.llvm.org/D103229 and the rest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin added a subscriber: bkramer. DmitryPolukhin added a comment. In D103142#2783665 , @dexonsmith wrote: > Naively, this sounds like it could be a non-trivial tax on build times. But > it looks like it's only called in Clang from `Sema::diagn

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 348264. DmitryPolukhin added a comment. Fix forgotten comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D103142 Files: clang/include/clang/Lex/HeaderMap.h cl

[PATCH] D103229: [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing

This revision was automatically updated to reflect the committed changes. Closed by commit rG37b530a2ea8b: [clang] NFC: split HeaderMapTest to have re-usable header map implementation… (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 348900. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. Resolved comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D103142 File

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin added inline comments. Comment at: clang/lib/Lex/HeaderMap.cpp:245 +StringRef HeaderMapImpl::reverseLookupFilename(StringRef DestPath) const { + if (ReverseMap.empty()) { +const HMapHeader &Hdr = getHeader(); bruno wrote: > Please rewrite this

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 348965. DmitryPolukhin added a comment. Rebase + try build on Windows again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D103142 Files: clang/include/clang/Lex/He

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 349199. DmitryPolukhin added a comment. Updated HeaderMapImpl::reverseLookupFilename according to the review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D10

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin added inline comments. Comment at: clang/lib/Lex/HeaderMap.cpp:265 + } + return ReverseMap.lookup(DestPath); +} bruno wrote: > How about something along the lines of: > > ``` > ... > StringRef Key; > for (unsigned i = 0; i != NumBuckets; ++i) {

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG178ad93e3f1f: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin added a comment. @bruno and @dexonsmith thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D103142 ___ cfe-commits mailing list cf

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1908 +uint64_t Offset = Stream.GetCurrentBitNo() - SLocEntryOffsetsBase; +assert((Offset >> 32) == 0 && "SLocEntry offset too large"); +SLocEntryOffsets.push_back(Offset);

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

DmitryPolukhin added a comment. @shixiao do you have plans to keep working on this diff? If not, do you have any objections if I send for review a similar diff that will eliminate the check `Sources.isInMainFile` and will rely on generic header filtration mechanism in clang-tidy? We have faced

[PATCH] D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText()

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: teemperor, obruns, bruno. DmitryPolukhin requested review of this revision. Herald added a project: clang. This diff adds testcase for the issue fixed in https://reviews.llvm.org/D77468 but regression test was not added in the d

[PATCH] D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText()

DmitryPolukhin updated this revision to Diff 350205. DmitryPolukhin added a comment. Fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103722/new/ https://reviews.llvm.org/D103722 Files: clang/unittests/AST/CommentTextTest.cpp

[PATCH] D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText()

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa0d7179bbb3: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText() (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

  1   2   3   >