[PATCH] D87187: [Driver] Perform Linux distribution detection just once

dmantipov updated this revision to Diff 292710. dmantipov added a comment. Updated (style adjustments). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87187/new/ https://reviews.llvm.org/D87187 Files: clang/include/clang/Driver/Distro.h clang/l

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

dmantipov created this revision. dmantipov added reviewers: manojgupta, sthibaul, dlj. Herald added subscribers: cfe-commits, fedor.sergeev. Herald added a project: clang. dmantipov requested review of this revision. For the regular (system-wide) installation it's OK to assume that Clang is insta

[PATCH] D87143: Check whether Gentoo-specific configuration directory exists

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd882ca7f1f1d: [Driver] Check whether Gentoo-specific configuration directory exists (authored by dmantipov). Changed prior to commit: https://revi

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

dmantipov added a comment. What's next with this? Should I add more reviewers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87187/new/ https://reviews.llvm.org/D87187 ___ cfe-commits mailing list cfe-co

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

dmantipov updated this revision to Diff 293949. dmantipov added a comment. IIUC compiler driver is not intended to be multithreaded. But OK, here is the version with llvm::call_once(...). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87187/new/ ht

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

dmantipov updated this revision to Diff 293955. dmantipov added a comment. Prefer a bit more meaningful variable names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87901/new/ https://reviews.llvm.org/D87901 Files: clang/lib/Driver/ToolChains/G

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

dmantipov updated this revision to Diff 294302. dmantipov marked an inline comment as done. dmantipov added a comment. Well, the problem with tests seems to be a bit wider - tests uses llvm::vfs::InMemoryFileSystem, which is not "real", so detection will return Distro::UnknownDistro anyway. So

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

This revision was automatically updated to reflect the committed changes. Closed by commit rG96318f64a786: [Driver] Perform Linux distribution detection only once (authored by dmantipov). Changed prior to commit: https://reviews.llvm.org/D87187?vs=294302&id=294478#toc Repository: rG LLVM Git

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

dmantipov added a comment. In D87901#2296392 , @aganea wrote: > > Thanks for the patch! I'll let others review it, but I was just being > curious: what tool do you use for intercepting & printing `stat(` and > `openat(`? How can I repro locally? man

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

dmantipov added a comment. @MaskRay Sure clang does not need to be installed and does not need to be beside GCC. But usually it is, and IMO this is the convenient setup for the most users who are not involved in development of clang itself and probably rely on tools installed as OS vendor's def

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

dmantipov updated this revision to Diff 294625. dmantipov added a comment. Initialize GCCDirExists and GCCCrossDirExists before calling ScanLibDirForGCCTriple(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87901/new/ https://reviews.llvm.org/D87

[PATCH] D87143: Check whether Gentoo-specific configuration directory exists

dmantipov created this revision. dmantipov added a reviewer: manojgupta. Herald added a project: clang. Herald added a subscriber: cfe-commits. dmantipov requested review of this revision. Check whether /etc/env.d/gcc exists before trying to read from any file from there. This saves a few OS calls

[PATCH] D87143: Check whether Gentoo-specific configuration directory exists

dmantipov updated this revision to Diff 289998. dmantipov added a comment. Add D.SysRoot as suggested during initial review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87143/new/ https://reviews.llvm.org/D87143 Files: clang/lib/Driver/ToolCha

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

dmantipov created this revision. dmantipov added reviewers: mgorny, aganea. dmantipov added a project: clang. Herald added a subscriber: cfe-commits. dmantipov requested review of this revision. When running regular ('clang++ foo.cc') native compilation on Linux target in a typical configuration,

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

dmantipov updated this revision to Diff 290281. dmantipov added a comment. Add trivial {/etc,/usr/lib}/os-release parser and fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87187/new/ https://reviews.llvm.org/D87187 Files: clang/include

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

dmantipov updated this revision to Diff 294873. dmantipov added a comment. Prefer locals and function parameters to class members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87901/new/ https://reviews.llvm.org/D87901 Files: clang/lib/Driver/T

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

dmantipov added a comment. Thanks @MaskRay for the method, some of my numbers are shown below. Before: # strace -fc -e file /home/antipov/.local/llvm-12.0.0/bin/clang++ test.cc % time seconds usecs/call callserrors syscall -- --- --- - - --

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc868da0e77a: [Driver] Filter out /gcc and /gcc-cross if they do not exists (authored by dmantipov). Repository: rG LLVM Github Mo

[PATCH] D96402: [Driver] Recognize arm-none-linux-gnueabihf as valid ARMHF triple

dmantipov created this revision. dmantipov added a reviewer: clang. Herald added subscribers: pengfei, kristof.beyls. dmantipov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After installing official 10.2-2020.11 AARCH64 / ARM toolchains