[clang] [WebAssembly] Enable Wasm EH features only once (PR #124042)

https://github.com/dschuff approved this pull request. https://github.com/llvm/llvm-project/pull/124042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Fix EH feature flags when compiling multiple files (PR #124374)

https://github.com/dschuff approved this pull request. https://github.com/llvm/llvm-project/pull/124374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][docs] Fix typos concerning wasm __funcref (PR #124365)

https://github.com/dschuff approved this pull request. Do you need me to commit? https://github.com/llvm/llvm-project/pull/124365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][docs] Fix typos concerning wasm __funcref (PR #124365)

@@ -1211,6 +1211,15 @@ WebAssemblyTargetLowering::LowerCall(CallLoweringInfo &CLI, } } } + +// If outgoing arguments are passed via the stack, we cannot tail call +for (const ISD::OutputArg &Out : CLI.Outs) { dschuff wrote: This is a

[clang] [llvm] [clang][docs] Fix typos concerning wasm __funcref (PR #124365)

@@ -1211,6 +1211,15 @@ WebAssemblyTargetLowering::LowerCall(CallLoweringInfo &CLI, } } } + +// If outgoing arguments are passed via the stack, we cannot tail call +for (const ISD::OutputArg &Out : CLI.Outs) { dschuff wrote: Aha, i ju

[clang] [WebAssembly] Refactor Wasm EH/SjLj error checking (PR #122466)

https://github.com/dschuff approved this pull request. https://github.com/llvm/llvm-project/pull/122466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove Native Client support (PR #133661)

dschuff wrote: Thanks for working on this! This will be the first time I'm not going to oppose an effort to remove Native Client support 🎉 Although I am going to ask you to wait a couple of months to land it, until we finally turn it off for good and start deleting the support code from Chromi

[clang] [WebAssembly] Rename functions in wasm-eh.cpp (PR #130220)

https://github.com/dschuff approved this pull request. https://github.com/llvm/llvm-project/pull/130220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Generate __clang_call_terminate for Emscripten EH (PR #129020)

https://github.com/dschuff approved this pull request. https://github.com/llvm/llvm-project/pull/129020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Generate __clang_call_terminate for Emscripten EH (PR #129020)

@@ -5150,9 +5150,14 @@ WebAssemblyCXXABI::emitTerminateForUnexpectedException(CodeGenFunction &CGF, // Itanium ABI calls __clang_call_terminate(), which __cxa_begin_catch() on // the violating exception to mark it handled, but it is currently hard to do // with wasm EH i

[clang] [WebAssembly] Generate __clang_call_terminate for Emscripten EH (PR #129020)

@@ -0,0 +1,13 @@ +// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fexceptions -fcxx-exceptions -emit-llvm -o - -std=c++11 2>&1 | FileCheck %s dschuff wrote: should this triple be wasm32-unknown-emscripten? Or do we use em-exceptions by default on all wasm

[clang] [WebAssembly] Generate __clang_call_terminate for Emscripten EH (PR #129020)

@@ -5150,9 +5150,14 @@ WebAssemblyCXXABI::emitTerminateForUnexpectedException(CodeGenFunction &CGF, // Itanium ABI calls __clang_call_terminate(), which __cxa_begin_catch() on // the violating exception to mark it handled, but it is currently hard to do // with wasm EH i

[clang] [clang][WebAssembly] Always have `-pthread` imply `--shared-memory` linker flag (PR #127939)

https://github.com/dschuff approved this pull request. https://github.com/llvm/llvm-project/pull/127939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Generate invokes with llvm.wasm.(re)throw (PR #128105)

@@ -0,0 +1,20 @@ +// RUN: %clang_cc1 -triple wasm32-unknown-unknown -fexceptions -fcxx-exceptions -target-feature +reference-types -target-feature +exception-handling -target-feature +multivalue -exception-model=wasm -emit-llvm -o - %s | FileCheck %s + +// Check if __builtin_wa

[clang] [WebAssembly] Generate invokes with llvm.wasm.(re)throw (PR #128105)

https://github.com/dschuff approved this pull request. https://github.com/llvm/llvm-project/pull/128105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Support ASan on WASI (PR #139014)

dschuff wrote: This looks good to me, @sbc100 and @sunfishcode might also be interested (presumably the sanitizer runtime will end up alongside wasi-libc in the wasi SDK?) https://github.com/llvm/llvm-project/pull/139014 ___ cfe-commits mailing list

[clang] [Clang] Fix Sema::checkArgCount for 0-arg functions (PR #139638)

https://github.com/dschuff approved this pull request. LGTM from the wasm side. As @hoodmane noted, the underlying wasm instruction has no arguments. https://github.com/llvm/llvm-project/pull/139638 ___ cfe-commits mailing list cfe-commits@lists.llvm.

<    1   2