[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
@@ -38,6 +38,10 @@ endif() include(LLDBConfig) include(AddLLDB) +if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX") + add_definitions("-D__AIX__") DavidSpickett wrote: Also remember that users may be debugging AIX from a non-AIX host where the compiler would

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/102601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] Add handling for new/delete expressions (PR #104033)

2024-08-16 Thread David Spickett via cfe-commits
DavidSpickett wrote: Note that that bot is 32 bit, so size_t is 32 bit there. https://github.com/llvm/llvm-project/pull/104033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-04-05 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/81869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] aff197f - Reland "[flang][clang] Add Visibility specific help text for options (#81869)"

2024-04-05 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-04-05T08:27:59Z New Revision: aff197ff2163a4b7732d08b833906cc21f4a5c89 URL: https://github.com/llvm/llvm-project/commit/aff197ff2163a4b7732d08b833906cc21f4a5c89 DIFF: https://github.com/llvm/llvm-project/commit/aff197ff2163a4b7732d08b833906cc21f4a5c89.diff LOG

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-06 Thread David Spickett via cfe-commits
DavidSpickett wrote: > Thanks. Reproduced. But it surprised me that I can't run the commands you > mentioned, but I need to run: > ./bin/lldb-dotest -p TestTemplateWithSameArg.py -G gmodules Running the tests as modules is perhaps opt in, we have the ability to run them with different debug in

[clang] Testing32 bit for https://github.com/llvm/llvm-project/pull/92083 (PR #94603)

2024-06-06 Thread David Spickett via cfe-commits
DavidSpickett wrote: I tested locally and this fixes all the test failures. https://github.com/llvm/llvm-project/pull/94603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

2024-06-06 Thread David Spickett via cfe-commits
DavidSpickett wrote: I have bisected a 32 bit Arm failure down to this change: https://lab.llvm.org/buildbot/#/builders/245/builds/25526 Is it possible that something in this code is truncating a value when interpreting types intended for a 64 bit system, on a 32 bit system? I don't see this

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

2024-06-06 Thread David Spickett via cfe-commits
DavidSpickett wrote: It is a 32 bit container running on an arm64 host. As far as the compiler and tests know, it's a 32 bit system. > But in either case the width of the int type should be the same, right? Yes. So I am wondering if someone of the assumptions about types being larger than on

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

2024-06-06 Thread David Spickett via cfe-commits
DavidSpickett wrote: > My feeling is the latter but how can we get a debug build and debug? I'm going to try a UBSAN build on the chance it pinpoints the issue right away, but failing that it'll be cross compiling to Arm 32 bit and using qemu-user to run the unit test binary. I will get you in

[clang] Testing32 bit for https://github.com/llvm/llvm-project/pull/92083 (PR #94603)

2024-06-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: Sure I'll test it now. BTW if you see `Clang-Unit::ClangReplInterpreterTests/InterpreterTest/Value` failing on one of our bots, that's not due to your change. https://github.com/llvm/llvm-project/pull/94603 ___ cfe-commits mailin

[clang] Testing32 bit for https://github.com/llvm/llvm-project/pull/92083 (PR #94603)

2024-06-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: Ok, this new version passes `check-llvm` and `check-clang` (ignoring the pre-existing failure), using the exact config from [clang-armv8-quick](https://lab.llvm.org/buildbot/#/builders/245). https://github.com/llvm/llvm-project/pull/94603 __

[clang] 54c5dbe - [clang][test] Skip interpreter value test on Arm 32 bit

2024-06-07 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-06-07T10:38:25Z New Revision: 54c5dbe7c3812461decbccb6ed122e41777e02bd URL: https://github.com/llvm/llvm-project/commit/54c5dbe7c3812461decbccb6ed122e41777e02bd DIFF: https://github.com/llvm/llvm-project/commit/54c5dbe7c3812461decbccb6ed122e41777e02bd.diff LOG

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

2024-06-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: > I will get you instructions on how to do that (will be tomorrow at this > point). https://github.com/llvm/llvm-project/issues/94741#issuecomment-2154656315 There is some underlying issue (https://github.com/llvm/llvm-project/issues/94741), so if you want to try and fix

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

2024-06-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: Actually, as someone pointed out, I've been conflating clang-repl with the constant expression interpreter. So the issue covers the latter and this must be something else. https://github.com/llvm/llvm-project/pull/89811 ___ cfe-c

[clang] Testing32 bit for https://github.com/llvm/llvm-project/pull/92083 (PR #94603)

2024-06-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: Looks like this fixed things: https://lab.llvm.org/buildbot/#/builders/245/builds/25578 Thanks for working with me on this. https://github.com/llvm/llvm-project/pull/94603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

2024-06-10 Thread David Spickett via cfe-commits
DavidSpickett wrote: You can debug it by cross-compiling a debug build, then running the unit tests binary and connecting to qemu's built in gdbserver. The Arm toolchain might have a copy of gdb in it already, but if not, gdb multiarch and lldb would also work (which are both installable from

[clang] c324281 - [clang][test] Update link for Arm clang-repl test disable

2024-06-10 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-06-10T16:14:53+01:00 New Revision: c32428151678f05fa3a9b5996e07f1e67094626c URL: https://github.com/llvm/llvm-project/commit/c32428151678f05fa3a9b5996e07f1e67094626c DIFF: https://github.com/llvm/llvm-project/commit/c32428151678f05fa3a9b5996e07f1e67094626c.diff

[clang] [clang][ARM] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/91870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/91870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett commented: I can't fully approve this, I leave that to other members of @llvm/pr-subscribers-arm . 2 overall comments: * Calling a function marked interrupt from a function marked interrupt is still UB isn't it? Should there be another warning to cover that sce

[clang] [clang][ARM] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-12 Thread David Spickett via cfe-commits
@@ -336,9 +336,10 @@ def warn_anyx86_excessive_regsave : Warning< " with attribute 'no_caller_saved_registers'" " or be compiled with '-mgeneral-regs-only'">, InGroup>; -def warn_arm_interrupt_calling_convention : Warning< - "call to function without interrupt attribute

[clang] [clang][ARM] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-12 Thread David Spickett via cfe-commits
@@ -384,6 +384,10 @@ Modified Compiler Flags evaluating to ``true`` and an empty body such as ``while(1);``) are considered infinite, even when the ``-ffinite-loop`` flag is set. +- Removed "arm interrupt calling convention" warning that was included in Da

[clang] [clang][ARM] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-12 Thread David Spickett via cfe-commits
@@ -544,6 +548,14 @@ Improvements to Clang's diagnostics - Clang no longer emits a "declared here" note for a builtin function that has no declaration in source. Fixes #GH93369. +- On ARM, Clang no longer suggests adding ``__attribute__((interrupt))`` to Da

[clang] [clang][ARM] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-12 Thread David Spickett via cfe-commits
DavidSpickett wrote: > I'd like to also address https://github.com/llvm/llvm-project/issues/47815, > but I wasn't able to find the right path to answer "is this M-profile" from > TargetInfo. Any ARM folks know if there are existing M profile only warnings to learn from? https://github.com/llv

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-17 Thread David Spickett via cfe-commits
@@ -5703,6 +5703,11 @@ def print_supported_extensions : Flag<["-", "--"], "print-supported-extensions"> Visibility<[ClangOption, CC1Option, CLOption]>, HelpText<"Print supported -march extensions (RISC-V, AArch64 and ARM only)">, MarshallingInfoFlag>; +def print_enabled_

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-17 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/95805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-17 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett commented: Cool idea, should be very useful. The TableGen has changed so much since I last looked so I didn't look over that myself. https://github.com/llvm/llvm-project/pull/95805 ___ cfe-commits mailing list cfe-com

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-17 Thread David Spickett via cfe-commits
@@ -19,3 +19,19 @@ // RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1a -### -c %s 2>&1 | FileCheck -check-prefix=ARM64-GENERICV81A %s // RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1-a -### -c %s 2>&1 | FileCheck -check-prefix=ARM64-GENERICV81A %s // ARM

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-17 Thread David Spickett via cfe-commits
@@ -161,6 +162,39 @@ static int PrintSupportedExtensions(std::string TargetStr) { return 0; } +static int PrintEnabledExtensions(const TargetOptions& TargetOpts) { DavidSpickett wrote: Is int here just following the local code style or would bool do? Since

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-17 Thread David Spickett via cfe-commits
@@ -13,3 +13,57 @@ // RUN: %clang --target=aarch64_be -mbig-endian -march=armv8.6a -### -c %s 2>&1 | FileCheck -check-prefix=GENERICV86A-BE %s // RUN: %clang --target=aarch64_be -mbig-endian -march=armv8.6-a -### -c %s 2>&1 | FileCheck -check-prefix=GENERICV86A-BE %s // GENER

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-17 Thread David Spickett via cfe-commits
@@ -134,17 +136,39 @@ std::optional AArch64::parseCpu(StringRef Name) { return {}; } -void AArch64::PrintSupportedExtensions(StringMap DescMap) { +void AArch64::PrintSupportedExtensions() { outs() << "All available -march extensions for AArch64\n\n" << "" <

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-17 Thread David Spickett via cfe-commits
@@ -204,6 +238,10 @@ int cc1_main(ArrayRef Argv, const char *Argv0, void *MainAddr) { if (Clang->getFrontendOpts().PrintSupportedExtensions) return PrintSupportedExtensions(Clang->getTargetOpts().Triple); + // --print-enabled-extensions takes priority over the actual c

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-17 Thread David Spickett via cfe-commits
DavidSpickett wrote: Also please list the impact, if any, on `--print-supported-extensions` in the commit message. I think it got a column with the FEAT_ names added, which is a nice improvement. https://github.com/llvm/llvm-project/pull/95805 ___ cf

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-17 Thread David Spickett via cfe-commits
@@ -19,3 +19,19 @@ // RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1a -### -c %s 2>&1 | FileCheck -check-prefix=ARM64-GENERICV81A %s // RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1-a -### -c %s 2>&1 | FileCheck -check-prefix=ARM64-GENERICV81A %s // ARM

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-18 Thread David Spickett via cfe-commits
@@ -13,3 +13,57 @@ // RUN: %clang --target=aarch64_be -mbig-endian -march=armv8.6a -### -c %s 2>&1 | FileCheck -check-prefix=GENERICV86A-BE %s // RUN: %clang --target=aarch64_be -mbig-endian -march=armv8.6-a -### -c %s 2>&1 | FileCheck -check-prefix=GENERICV86A-BE %s // GENER

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-18 Thread David Spickett via cfe-commits
@@ -161,6 +162,39 @@ static int PrintSupportedExtensions(std::string TargetStr) { return 0; } +static int PrintEnabledExtensions(const TargetOptions& TargetOpts) { DavidSpickett wrote: Cool, happy to "when in Rome" here and leave it as is. https://github.

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-18 Thread David Spickett via cfe-commits
@@ -19,3 +19,19 @@ // RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1a -### -c %s 2>&1 | FileCheck -check-prefix=ARM64-GENERICV81A %s // RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1-a -### -c %s 2>&1 | FileCheck -check-prefix=ARM64-GENERICV81A %s // ARM

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-18 Thread David Spickett via cfe-commits
@@ -204,6 +238,10 @@ int cc1_main(ArrayRef Argv, const char *Argv0, void *MainAddr) { if (Clang->getFrontendOpts().PrintSupportedExtensions) return PrintSupportedExtensions(Clang->getTargetOpts().Triple); + // --print-enabled-extensions takes priority over the actual c

[libunwind] [llvm] [runtimes] remove workaround for old CMake when setting `--unwindlib=none` (PR #93429)

2024-06-21 Thread David Spickett via cfe-commits
DavidSpickett wrote: Linaro will look into this. Reproducing the build is quite easy if you do want to look yourselves in the meantime: ``` $ ./libcxx/utils/ci/run-buildbot armv7m-picolibc-no-exceptions ``` You'll need a recent `qemu-system-arm` installed to run the tests, I have 8.1.3 locall

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: This also broke an lldb test: https://lab.llvm.org/buildbot/#/builders/96/builds/58449 `lldb-test: ../llvm-project/clang/lib/AST/DeclBase.cpp:132: void clang::Decl::setOwningModuleID(unsigned int): Assertion `!((*IDAddress) >> 48) && "We should only set the module ID once

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: > lldb-shell :: SymbolFile/DWARF/x86/module-ownership.mm This is due to https://github.com/llvm/llvm-project/pull/92083, it's been reverted now. https://github.com/llvm/llvm-project/pull/94208 ___ cfe-commits mailing list cfe-com

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: And I would bet that a majority of the unresolved are due to: ``` ModuleNotFoundError: No module named 'pexpect' ``` You can either install it with `pip` or pass `-DLLDB_TEST_USER_ARGS=--skip-category=pexpect` to CMake. https://github.com/llvm/llvm-project/pull/94208 __

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: > First Windows CI results: LLDB unit tests do not even build. Linaro's Windows bot uses clang-cl, but I do remember something like this there too. I will do a local build with msvc and see what I can do. https://github.com/llvm/llvm-project/pull/94208

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: > I'll do that, but I think LLDB should follow the example of MLIR here https://github.com/llvm/llvm-project/pull/94220 https://github.com/llvm/llvm-project/pull/94208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-04 Thread David Spickett via cfe-commits
DavidSpickett wrote: > MSVC 14.29.30133 is VS 2019. We are using VS 2022 with the latest Windows SDK > to build lldb w/o problems. I also couldn't reproduce it locally with `19.34.31937`, but I may still be able to reproduce by making my own version of this PR so I can use the CI's version.

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-04 Thread David Spickett via cfe-commits
DavidSpickett wrote: I think the issue is https://developercommunity.visualstudio.com/t/c-shared-state-futuresstate-default-constructs-the/60897 which appears to have been fixed in 19.32 (https://godbolt.org/z/P594qGrc9). But @slydiman reports 14.29.30133 which is earlier than that. Perhaps th

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-04 Thread David Spickett via cfe-commits
DavidSpickett wrote: Maybe you can run individual tests with lit but generally I use `lldb-dotest` instead: ``` ./bin/lldb-dotest.py -p TestTemplateWithSameArg.py ``` (you only need the filename) https://github.com/llvm/llvm-project/pull/92083 ___ cfe

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-04 Thread David Spickett via cfe-commits
DavidSpickett wrote: https://github.com/llvm/llvm-project/pull/94325 will get us past the compiler error. Some things I noticed testing that: * There is an lld installed on the machine but it's in a path with spaces so lit can't run it. Generally we'd build lld along with lldb and use that in

[clang] [clang][AArch64] Add validation for Global Register Variable. (PR #94271)

2024-06-04 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/94271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread David Spickett via cfe-commits
@@ -807,8 +807,12 @@ def gcc_install_dir_EQ : Joined<["--"], "gcc-install-dir=">, "Note: executables (e.g. ld) used by the compiler are not overridden by the selected GCC installation">; def gcc_toolchain : Joined<["--"], "gcc-toolchain=">, Flags<[NoXarchOption]>, Visibil

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread David Spickett via cfe-commits
DavidSpickett wrote: > Clang is also mentioned for the diagnostic warnings reference, which mostly > applies to C/C++/Obj-C, not Fortran. > https://github.com/llvm/llvm-project/pull/81726 already tried to fix this, > and I don't know a better solution. Do you mean that this PR fixes this, or

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread David Spickett via cfe-commits
DavidSpickett wrote: > The docbrief strings already use %Program/GlobalDocumentation.Program which > seems to work and made me think that HelpTextForVariants was actually > unnecessary. Would you like me to introduce DocBriefForVariants? IIRC it was unnessecary for the documentation because it

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. The changes themselves LGTM, thanks for fixing this. https://github.com/llvm/llvm-project/pull/88932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [compiler-rt] [llvm] Revert "[FMV] Remove useless features according the latest ACLE spec." (PR #89184)

2024-04-18 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [lld] [llvm] Triple::normalize: Set OS for 3-component triple with none as middle (PR #89638)

2024-04-23 Thread David Spickett via cfe-commits
DavidSpickett wrote: > Ohh, there is so many -none-unknown- in current code. I guess it may be > widely used. Do we really want to change all of them? In current test cases, which were likely generated using clang. So they are likely not relying on that exact form of the triple, it's just what

[clang] [clang][Interp] Implement dynamic memory allocation handling (PR #70306)

2024-07-16 Thread David Spickett via cfe-commits
DavidSpickett wrote: @luporl please help reproduce the bot failure https://lab.llvm.org/buildbot/#/builders/39/builds/528. You can also try it under qemu - https://linaro.atlassian.net/wiki/spaces/TCWGPUB/pages/29360783374/How+to+Reproduce+32+bit+Arm+Builds+Without+Hardware. https://github.co

[clang] [clang][Interp] Implement dynamic memory allocation handling (PR #70306)

2024-07-16 Thread David Spickett via cfe-commits
DavidSpickett wrote: I know there is UB in there (https://github.com/llvm/llvm-project/issues/94741) so this is not unsurprising. Though so far none of that has been the cause of failures natively. Let's see what Leandro finds. https://github.com/llvm/llvm-project/pull/70306 _

[clang-tools-extra] [clang-tools-extra] Fix typos in Modularize.rst (PR #99256)

2024-07-17 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/99256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tools-extra] Fix typos in Modularize.rst (PR #99256)

2024-07-17 Thread David Spickett via cfe-commits
DavidSpickett wrote: I saw your email in the merge box so I've gone ahead and landed it (I think the workflow that checks for a private email may only be re-run when the changes in the PR are updated). https://github.com/llvm/llvm-project/pull/99256

[clang] [flang] [mlir] Add basic -mtune support (PR #98517)

2024-07-17 Thread David Spickett via cfe-commits
DavidSpickett wrote: This was failing on our bots that build all backends, I've fixed that: https://github.com/llvm/llvm-project/commit/8bf952d77fbe63f979e4293e95a5ca379e26eede It will help you in future if you set an email address for your commits in this Github project. Buildbot will then use

[clang] [llvm] [llvm][RISC-V] Improve error message for invalid extension letters (PR #90468)

2024-04-29 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/90468 Previously you got: clang: error: invalid arch name 'rv64v', first letter should be 'e', 'i' or 'g' Which to me, unfamiliar with riscv, reads as if I should have used "[eig]rv64v". Which is not what clang

[clang] [llvm] [llvm][RISCV] Improve error message for invalid extension letters (PR #90468)

2024-04-29 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/90468 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][RISCV] Improve error message for invalid extension letters (PR #90468)

2024-04-29 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90468 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reapply "[HWASan] remove incorrectly inferred attributes" (#106622) (PR #106624)

2024-08-30 Thread David Spickett via cfe-commits
DavidSpickett wrote: The added test is timing out on Linaro's bots, before we had this many tests: ``` PASS: lit :: shtest-define.py (92379 of 92379) ``` And after this patch we have: ``` PASS: lit :: shtest-define.py (92379 of 92380) ``` So it's the one that's timing out. These bots are AArch64

[clang] [llvm] Reapply "[HWASan] remove incorrectly inferred attributes" (#106622) (PR #106624)

2024-08-30 Thread David Spickett via cfe-commits
DavidSpickett wrote: I'm wary of reverting because I'm not 100% sure your later commit isn't related to this. So I'll leave it to you to decide. I/ we (Linaro) can look into this on the hardware but I myself will be finished work for the week by the time you start I expect. Feel free to ping m

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-08-30 Thread David Spickett via cfe-commits
DavidSpickett wrote: The flang failure also came up on Linaro's 2 stage bots: https://lab.llvm.org/buildbot/#/builders/4/builds/1670 https://github.com/llvm/llvm-project/pull/100692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [llvm] [AArch64][RISCV] Improve the tests for --print-enabled-extensions and --print-supported-extensions (PR #97829)

2024-07-09 Thread David Spickett via cfe-commits
DavidSpickett wrote: Re. the test failure, I've been disabling these and collecting them in https://github.com/llvm/llvm-project/issues/97712. Let me know if you see any others. https://github.com/llvm/llvm-project/pull/97829 ___ cfe-commits mailing

[clang] [lldb] [llvm] [llvm][TargetParser] Return optional from getHostCPUFeatures (PR #97824)

2024-07-09 Thread David Spickett via cfe-commits
DavidSpickett wrote: Fair point, iirc all the callers go on to iterate the map so no one is handling failure in a special way. I'll update this. https://github.com/llvm/llvm-project/pull/97824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [lldb] [llvm] [llvm][TargetParser] Return optional from getHostCPUFeatures (PR #97824)

2024-07-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/97824 >From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 5 Jul 2024 08:42:22 + Subject: [PATCH 1/4] [llvm][TargetParser] Return optional from getHostCPUFe

[clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

2024-07-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/97824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

2024-07-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/97824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

2024-07-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/97824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

2024-07-09 Thread David Spickett via cfe-commits
DavidSpickett wrote: > Why not return a map every time? Done. https://github.com/llvm/llvm-project/pull/97824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

2024-07-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/97824 >From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 5 Jul 2024 08:42:22 + Subject: [PATCH 1/5] [llvm][TargetParser] Return optional from getHostCPUFe

[clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

2024-07-09 Thread David Spickett via cfe-commits
@@ -15,21 +15,22 @@ #include "llvm/Support/raw_ostream.h" #include "llvm/TargetParser/Host.h" +#include + DavidSpickett wrote: Done. https://github.com/llvm/llvm-project/pull/97824 ___ cfe-commits mailing list cfe

[clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

2024-07-09 Thread David Spickett via cfe-commits
@@ -13,6 +13,7 @@ #ifndef LLVM_TARGETPARSER_HOST_H #define LLVM_TARGETPARSER_HOST_H +#include DavidSpickett wrote: Done. https://github.com/llvm/llvm-project/pull/97824 ___ cfe-commits mailing list cfe-commits@lis

[clang] [clang][ARM] Fix warning for using VFP from interrupts. (PR #91870)

2024-07-10 Thread David Spickett via cfe-commits
@@ -1329,6 +1329,11 @@ void SemaARM::handleInterruptAttr(Decl *D, const ParsedAttr &AL) { return; } + const TargetInfo &TI = getASTContext().getTargetInfo(); + if (TI.hasFeature("vfp")) { +Diag(D->getLocation(), diag::warn_arm_interrupt_vfp_clobber); + }

[clang] [clang][ARM] Fix warning for using VFP from interrupts. (PR #91870)

2024-07-10 Thread David Spickett via cfe-commits
DavidSpickett wrote: Everything LGTM but I'd like someone who works on Arm's downstream compiler to approve. @ostannard perhaps? (thanks for your patience @chrisnc) https://github.com/llvm/llvm-project/pull/91870 ___ cfe-commits mailing list cfe-com

[clang] [clang][ARM] Fix warning for using VFP from interrupts. (PR #91870)

2024-07-10 Thread David Spickett via cfe-commits
@@ -492,6 +495,13 @@ Modified Compiler Flags now include dianostics about C++26 features that are not present in older versions. +- Removed the "arm interrupt calling convention" warning that was included in + ``-Wextra`` without its own flag. This warning suggested addin

[clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

2024-07-11 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/97824 >From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 5 Jul 2024 08:42:22 + Subject: [PATCH 1/9] [llvm][TargetParser] Return optional from getHostCPUFe

[clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

2024-07-11 Thread David Spickett via cfe-commits
@@ -20,16 +20,15 @@ using namespace llvm; int main(int argc, char **argv) { #if defined(__i386__) || defined(_M_IX86) || \ defined(__x86_64__) || defined(_M_X64) - StringMap features; - - if (!sys::getHostCPUFeatures(features)) + const StringMap features = sys::getHostCP

[clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

2024-07-11 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/97824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-05-01 Thread David Spickett via cfe-commits
DavidSpickett wrote: I'm checking the picolib libcxx build right now so please hold off on landing this. https://github.com/llvm/llvm-project/pull/89638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [libcxx] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-05-01 Thread David Spickett via cfe-commits
@@ -217,7 +217,7 @@ function test-armv7m-picolibc() { "${@}" ${NINJA} -vC "${BUILD_DIR}/compiler-rt" install -mv "${BUILD_DIR}/install/lib/armv7m-none-unknown-eabi"/* "${BUILD_DIR}/install/lib" +mv "${BUILD_DIR}/install/lib/armv7m-unknown-none-eabi"/* "${

[clang] [libcxx] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-05-01 Thread David Spickett via cfe-commits
DavidSpickett wrote: Also this change should be release noted with a tip that build scripts may want to change to asking clang for the triple instead. https://github.com/llvm/llvm-project/pull/89638 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-05-01 Thread David Spickett via cfe-commits
DavidSpickett wrote: libcxx is sorted, and I will write up the release note given that I suggested it and have been fixing some builds myself. https://github.com/llvm/llvm-project/pull/89638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [clang][Docs] Add release note for *-none-* triple normalization changes (PR #90734)

2024-05-01 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/90734 That were implemented by https://github.com/llvm/llvm-project/pull/89638. >From 2d4d5e1885cc8e722b9ebaab81caf2d39c9994da Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 1 May 2024 15:39:31 +0100 S

[clang] [clang][Docs] Add release note for {target}-none-{environment} triple normalization changes (PR #90734)

2024-05-01 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/90734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Docs] Add release note for {target}-none-{environment} triple normalization changes (PR #90734)

2024-05-02 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-05-02 Thread David Spickett via cfe-commits
DavidSpickett wrote: @wzssyqa thanks for working with us on this. Bare metal is always a wild card but I think in the end we'll all have cleaner builds because of these changes. https://github.com/llvm/llvm-project/pull/89638 ___ cfe-commits mailing l

[clang] fb1c2db - Revert "Reapply "[clang][Interp] Create full type info for dummy pointers""

2024-05-03 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-05-03T09:56:23Z New Revision: fb1c2dbc0a6ba641e0b39e0692ec6a4eec4b URL: https://github.com/llvm/llvm-project/commit/fb1c2dbc0a6ba641e0b39e0692ec6a4eec4b DIFF: https://github.com/llvm/llvm-project/commit/fb1c2dbc0a6ba641e0b39e0692ec6a4eec4b.diff LOG

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-13 Thread David Spickett via cfe-commits
DavidSpickett wrote: LLVM uses a GitHub setting where the PR is squashed, and the commit message is taken from the PR description rather than the commits themselves. So all you have to do here is copy the commit message you updated into the PR's description. https://github.com/llvm/llvm-proje

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-13 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. LLDB changes look good to me. https://github.com/llvm/llvm-project/pull/91857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-14 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/91858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-14 Thread David Spickett via cfe-commits
DavidSpickett wrote: If this is split out from the other larger PR, should there be `clang/` changes in here? I've copied your commit message into the PR description, because with the way llvm is setup, we use the PR's description as the commit message for a squashed version of the changes.

[clang] e4b790c - [OpenMP] Temporarily require X86 target for parallel_for_codegen.cpp test

2021-05-06 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2021-05-06T14:16:43Z New Revision: e4b790c5e3653053819182a67c593bc65de860ac URL: https://github.com/llvm/llvm-project/commit/e4b790c5e3653053819182a67c593bc65de860ac DIFF: https://github.com/llvm/llvm-project/commit/e4b790c5e3653053819182a67c593bc65de860ac.diff LOG

[clang] 09036be - [clang] Require x86 target for tbaa test

2021-12-15 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2021-12-15T16:40:26Z New Revision: 09036be1266355e73775c5c949a69a25312ee18a URL: https://github.com/llvm/llvm-project/commit/09036be1266355e73775c5c949a69a25312ee18a DIFF: https://github.com/llvm/llvm-project/commit/09036be1266355e73775c5c949a69a25312ee18a.diff LOG

[clang] [clang][ARM] Fix warning for using VFP from interrupts. (PR #91870)

2024-06-26 Thread David Spickett via cfe-commits
@@ -336,9 +336,12 @@ def warn_anyx86_excessive_regsave : Warning< " with attribute 'no_caller_saved_registers'" " or be compiled with '-mgeneral-regs-only'">, InGroup>; -def warn_arm_interrupt_calling_convention : Warning< - "call to function without interrupt attribute

[clang] [clang][ARM] Fix warning for using VFP from interrupts. (PR #91870)

2024-06-26 Thread David Spickett via cfe-commits
@@ -448,6 +448,11 @@ Modified Compiler Flags evaluating to ``true`` and an empty body such as ``while(1);``) are considered infinite, even when the ``-ffinite-loop`` flag is set. +- Removed "arm interrupt calling convention" warning that was included in + ``-Wextra`` with

<    1   2   3   4   5   6   7   >