devnexen added a comment.
ping but will be for 8.0 :)
https://reviews.llvm.org/D49722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen updated this revision to Diff 160272.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
===
--- test/Analysi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339641: [CStringSyntaxChecker] Check strlcat sizeof check
(authored by devnexen, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49722?vs=1602
devnexen updated this revision to Diff 162139.
devnexen added a comment.
- Returns immediately for both case when sizeof destination.
- Adding few more cases.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: t
devnexen added a comment.
ping
https://reviews.llvm.org/D45177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen added a comment.
Thanks ! I would be grateful if anybody could land it for me.
https://reviews.llvm.org/D45177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1560-1566
// If the size is known to be zero, we're done.
if (StateZeroSize && !StateNonZeroSize) {
StateZeroSize = StateZeroSize->BindExpr(CE, LCtx, DstVal);
devnexen created this revision.
devnexen added reviewers: NoQ, george.karpenkov.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
Again strlc* does not return a pointer so the zero size case does not fit.
Repository:
rC Clang
https://reviews.ll
devnexen added a comment.
In https://reviews.llvm.org/D45177#1102887, @alexfh wrote:
> This is reproducible in r332425.
I posted this PR https://reviews.llvm.org/D47007 hopes it helps.
Repository:
rC Clang
https://reviews.llvm.org/D45177
___
c
devnexen added a comment.
In https://reviews.llvm.org/D47007#1103551, @george.karpenkov wrote:
> Is it a fix for https://bugs.llvm.org/show_bug.cgi?id=37503 ?
Nope. more for last NoQ comment. Will try for this one once I finish setting it
up.
Repository:
rC Clang
https://reviews.llvm.org/
devnexen added a comment.
In https://reviews.llvm.org/D45177#1103162, @alexfh wrote:
> See https://bugs.llvm.org/show_bug.cgi?id=37503 for a test case.
I was unable to reproduce both FreeBSD and Linux. Plus my changes come after
checkNonNull.
Repository:
rC Clang
https://reviews.llvm.org/
devnexen added a comment.
I admit I do not due to much longer compilation time, I ll recompile all with
and will see tomorrow if I can reproduce.
Repository:
rC Clang
https://reviews.llvm.org/D45177
___
cfe-commits mailing list
cfe-commits@lists
devnexen added a comment.
In https://reviews.llvm.org/D45177#1103781, @alexfh wrote:
> In https://reviews.llvm.org/D45177#1103774, @devnexen wrote:
>
> > In https://reviews.llvm.org/D45177#1103162, @alexfh wrote:
> >
> > > See https://bugs.llvm.org/show_bug.cgi?id=37503 for a test case.
> >
> >
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333060: [analyzer] CStringChecker fix for strlcpy when no
bytes are copied to the dest… (authored by devnexen, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D47007
Files:
lib/StaticA
devnexen created this revision.
devnexen added a reviewer: dberris.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D51269
Files:
lib/Driver/ToolChains/Darwin.cpp
lib/Driver/ToolChains/Darwin.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340712: [Xray] Darwin - Enable in the driver side (authored
by devnexen, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51269?vs=162583&id=16
devnexen added a comment.
Good point :-)
Repository:
rL LLVM
https://reviews.llvm.org/D51269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen added a comment.
ping
https://reviews.llvm.org/D49722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen added a comment.
ping
https://reviews.llvm.org/D49722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen added a comment.
ping @george.karpenkov after that I won t bother you for a long time :)
https://reviews.llvm.org/D49722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen added inline comments.
Comment at: test/Analysis/cstring-syntax.c:49
+ strlcat(dest, "0123456789", badlen / 2);
+ strlcat(dest, "0123456789", badlen); // expected-warning {{The third
argument allows to potentially copy more bytes than it should. Replace with the
valu
devnexen updated this revision to Diff 164355.
devnexen added a comment.
- Correcting misleading message and advising proper fix.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
devnexen added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:199
+if (Append)
+ RemainingBufferLen -= 1;
+if (RemainingBufferLen < ILRawVal)
MaskRay wrote:
> `RemainingBufferLen` is `uint64_t`. Can the
devnexen updated this revision to Diff 165604.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
===
--- test/Analysi
devnexen created this revision.
devnexen added reviewers: george.karpenkov, NoQ.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
- Assuming strlcat is used with strlcpy we check as we can if the last argument
does not equal os not larger than the
devnexen added a comment.
Hopefully will try to push it before the freeze just announced, that s my last
change in this area (except potential fixes) :)
Repository:
rC Clang
https://reviews.llvm.org/D49722
___
cfe-commits mailing list
cfe-commit
devnexen created this revision.
devnexen added reviewers: morehouse, krytarowski.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D49788
Files:
docs/AddressSanitizer.rst
docs/MemorySanitizer.rst
devnexen added a comment.
This is the first time I m involved into a release so I do not know if it s too
early to update those docs but with the freeze incoming, I thought it was worth
before it get forgotten.
Repository:
rC Clang
https://reviews.llvm.org/D49788
devnexen added a comment.
Ah I forgot NetBSD sorry yes you re right.
Repository:
rC Clang
https://reviews.llvm.org/D49788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen updated this revision to Diff 157237.
https://reviews.llvm.org/D49788
Files:
docs/AddressSanitizer.rst
docs/MemorySanitizer.rst
docs/SafeStack.rst
docs/ThreadSanitizer.rst
docs/UndefinedBehaviorSanitizer.rst
Index: docs/UndefinedBehaviorSanitizer.rst
=
devnexen closed this revision.
devnexen added a comment.
Exited too early fro the editor ,.. did not write all the lines but commited
with https://reviews.llvm.org/rC337926
https://reviews.llvm.org/D49788
___
cfe-commits mailing list
cfe-commits@li
devnexen updated this revision to Diff 157381.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
===
--- test/Analysi
devnexen created this revision.
devnexen added a reviewer: pcc.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D49873
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
=
devnexen created this revision.
devnexen added a reviewer: eugenis.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
- Adding new option detect_write_exec=1 available.
Repository:
rC Clang
https://reviews.llvm.org/D49906
Files:
docs/AddressS
devnexen added a comment.
ping :)
https://reviews.llvm.org/D49722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen updated this revision to Diff 158062.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
===
--- test/Analysi
devnexen added a comment.
ping :)
https://reviews.llvm.org/D49722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen added a comment.
ping :)
Repository:
rC Clang
https://reviews.llvm.org/D49873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen added a comment.
ping :)
Repository:
rC Clang
https://reviews.llvm.org/D49906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen abandoned this revision.
devnexen added a comment.
Commited in the branch.
Repository:
rC Clang
https://reviews.llvm.org/D49906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
devnexen abandoned this revision.
devnexen added a comment.
Committed in the branch.
Repository:
rC Clang
https://reviews.llvm.org/D49873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
devnexen updated this revision to Diff 132873.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp
test/Analysis/mmap-writeexec.c
I
devnexen added a comment.
In https://reviews.llvm.org/D42645#998732, @a.sidorin wrote:
> Hello David,
>
> I have looked into mmap constant definitions in different implementations and
> found them pretty inconsistent. For example, MMAP_EXEC can be 0x01, 0x04 and
> I even found 0x00 in some file
devnexen updated this revision to Diff 132969.
Herald added a subscriber: emaste.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/Driver/ToolChains/FreeBSD.cpp
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyze
devnexen updated this revision to Diff 133008.
devnexen added a comment.
Both Linux/Darwin unit tests passed.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/Driver/ToolChains/FreeBSD.cpp
lib/StaticAnalyzer/Checkers/CMak
devnexen updated this revision to Diff 133010.
devnexen added a comment.
Will work on most modern Linux/Glibc versions, BSD variants and Illumos.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/Driver/ToolChains/FreeBSD.cp
devnexen added a comment.
Repository:
rC Clang
https://reviews.llvm.org/D42645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen updated this revision to Diff 133164.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp
test/Analysis/mmap-writeexec.c
I
devnexen added a comment.
None of the possible solutions are ideal, but I think I chose the least complex
(e.g. via analyzer-config), less edgy one, and 4 is the most common value I ve
found so far for PROT_EXEC.
Repository:
rC Clang
https://reviews.llvm.org/D42645
__
devnexen updated this revision to Diff 133564.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp
test/Analysis/mmap-writeexec.c
I
devnexen created this revision.
devnexen added a reviewer: krytarowski.
devnexen created this object with visibility "All Users".
Herald added subscribers: cfe-commits, emaste.
Enabling memory sanitiser for X86_64 arch only. To match the sanitiser
counterpart.
Repository:
rC Clang
https://re
devnexen created this revision.
devnexen added reviewers: vitalybuka, krytarowski.
devnexen created this object with visibility "All Users".
Herald added subscribers: cfe-commits, dberris, emaste.
Similarly to the GNU driver version, adding proper compile and linker flags.
Repository:
rC Clang
devnexen added a comment.
Counterpart of the compiler-rt work here https://reviews.llvm.org/D43278
Repository:
rC Clang
https://reviews.llvm.org/D43279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
devnexen added inline comments.
Comment at: FreeBSD.cpp:139
+ CmdArgs.push_back("--no-as-needed");
+ CmdArgs.push_back("-lpthread");
+ CmdArgs.push_back("-lrt");
krytarowski wrote:
> `-pthread`?
Did not seem needed maybe it s different for NetBSD ?
Repositor
devnexen updated this revision to Diff 134244.
devnexen added a comment.
Changing to pthread flag.
https://reviews.llvm.org/D43279
Files:
lib/Driver/ToolChains/FreeBSD.cpp
Index: lib/Driver/ToolChains/FreeBSD.cpp
===
--- lib/Dr
devnexen updated this revision to Diff 134331.
https://reviews.llvm.org/D43148
Files:
lib/Driver/ToolChains/FreeBSD.cpp
Index: lib/Driver/ToolChains/FreeBSD.cpp
===
--- lib/Driver/ToolChains/FreeBSD.cpp
+++ lib/Driver/ToolChains/
devnexen created this revision.
devnexen added reviewers: krytarowski, vitalybuka, dberris.
devnexen created this object with visibility "All Users".
Herald added subscribers: cfe-commits, emaste.
devnexen edited the summary of this revision.
-pthread was into linkage step.
-Warning about the -fxr
devnexen updated this revision to Diff 134586.
devnexen edited the summary of this revision.
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
Index: lib/Driver/XRayArgs.cpp
===
--
devnexen updated this revision to Diff 134605.
devnexen added a comment.
Updating the warning messages.
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
Index: lib/Driver/XRayArgs.cpp
=
devnexen added inline comments.
Comment at: lib/Driver/XRayArgs.cpp:56
+<< (std::string(XRayInstrumentOption) + " only on "
+"FreeBSD x86_64");
+}
krytarowski wrote:
> krytarowski wrote:
> > I think it's better to not h
devnexen updated this revision to Diff 134622.
devnexen added a comment.
Reusing generic message/reformating.
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
Index: lib/Driver/XRayArgs.cpp
===
devnexen updated this revision to Diff 134628.
devnexen added a comment.
Herald added a subscriber: srhines.
Enabling one test for FreeBSD
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
test/Driver/XRay/lit.local.cfg
test/Driver/XRay/xra
devnexen updated this revision to Diff 134634.
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
test/Driver/XRay/lit.local.cfg
test/Driver/XRay/xray-instrument-os.c
test/Driver/XRay/xray-shared-noxray.cpp
Index: test/Driver/XRay/xray-shar
devnexen added inline comments.
Comment at: lib/Driver/XRayArgs.cpp:54
+if (Triple.getArch() != llvm::Triple::x86_64) {
+ D.Diag(diag::err_drv_clang_unsupported)
+ << (std::string(XRayInstrumentOption) + " on " + Triple.str());
kryta
devnexen added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D42645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen updated this revision to Diff 134659.
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
test/Driver/XRay/lit.local.cfg
test/Driver/XRay/xray-instrument-os.c
test/Driver/XRay/xray-shared-noxray.cpp
Index: lib/Driver/XRayArgs.cpp
==
devnexen added a comment.
In https://reviews.llvm.org/D43378#1010464, @emaste wrote:
> LGTM with one small note.
>
> What will it take for us to enable this on the rest of the platforms
> Clang/FreeBSD supports?
As I see only x86_64 arch implements everything (e.g. custom event), making
thing
devnexen updated this revision to Diff 135027.
devnexen added a comment.
Moving back the checker to alpha.security level.
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWri
devnexen updated this revision to Diff 135067.
devnexen added a comment.
Updating tests accordingly
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp
te
devnexen added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419
+// Operating systems specific PROT_READ/PROT_WRITE values is not implemented,
+// thus ought to be overriden with the proper analyser-config variables
+// remain in alpha until
devnexen added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419
+// Operating systems specific PROT_READ/PROT_WRITE values is not implemented,
+// thus ought to be overriden with the proper analyser-config variables
+// remain in alpha until
devnexen updated this revision to Diff 135258.
devnexen added a comment.
Rephrasing Checkers.td comment
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp
devnexen created this revision.
Herald added subscribers: cfe-commits, emaste.
Repository:
rC Clang
https://reviews.llvm.org/D41809
Files:
lib/Driver/ToolChains/FreeBSD.cpp
Index: lib/Driver/ToolChains/FreeBSD.cpp
===
--- lib/
devnexen updated this revision to Diff 129329.
https://reviews.llvm.org/D41809
Files:
lib/Driver/ToolChains/FreeBSD.cpp
Index: lib/Driver/ToolChains/FreeBSD.cpp
===
--- lib/Driver/ToolChains/FreeBSD.cpp
+++ lib/Driver/ToolChains/
devnexen updated this revision to Diff 129364.
https://reviews.llvm.org/D41809
Files:
lib/Driver/ToolChains/FreeBSD.cpp
Index: lib/Driver/ToolChains/FreeBSD.cpp
===
--- lib/Driver/ToolChains/FreeBSD.cpp
+++ lib/Driver/ToolChains/
devnexen created this revision.
devnexen created this object with visibility "All Users".
Herald added subscribers: cfe-commits, krytarowski.
devnexen added reviewers: dlj, krytarowski.
- Like other *BSD, conditioning certain flags to pass
- To prepare future OpenBSD sanitisers.
Repository:
rC
devnexen added a comment.
In https://reviews.llvm.org/D43818#1020577, @krytarowski wrote:
> OpenBSD ships with an aggressive ASLR (or ASR) implementation with
> fragmentation of user address space. As far as I can tell, it's not possible
> to disable it. This means that you are restricted to UB
devnexen added a comment.
Also true ... on OpenBSD the number of sanitisers support list won t be
enormous ... ubsan maybe tsan ... the xray instrumentation perharps ...
Repository:
rC Clang
https://reviews.llvm.org/D43818
___
cfe-commits mailin
devnexen added a comment.
Alright then. I ll probably try to push the compiler-rt counterpart (for only
ubsan) within the week, it can detects integer overflow already rightfully.
Repository:
rC Clang
https://reviews.llvm.org/D43818
___
cfe-comm
devnexen added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:545
CmdArgs.push_back("-lpthread");
-CmdArgs.push_back("-lrt");
+if (TC.getTriple().getOS() != llvm::Triple::OpenBSD)
+ CmdArgs.push_back("-lrt");
krytarowski wrote
devnexen added a comment.
ping :)
https://reviews.llvm.org/D42645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen created this revision.
devnexen added reviewers: krytarowski, vitalybuka, kettenis.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
Basic support of Sanitiser to follow-up ubsan support in compiler-rt.
Needs to use lld instead of base ld t
devnexen updated this revision to Diff 136804.
devnexen added a comment.
backtrace on OpenBSD is not base library but a package. Plus not needed for the
UBsan subset.
https://reviews.llvm.org/D43818
Files:
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains/CommonArgs.cpp
lib/Driver/ToolChain
devnexen created this revision.
devnexen added a reviewer: krytarowski.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
OpenBSD supporting only UBsan unsupported this particular test
Repository:
rC Clang
https://reviews.llvm.org/D44069
Files:
devnexen added a comment.
In https://reviews.llvm.org/D44069#1026551, @krytarowski wrote:
> This is not breaking (only?) on OpenBSD, but the triple is breaking all
> tested platforms.
> Please support it properly.
What needs to be done ? I mean I have all OpenBSD compiler-rt code in my side
devnexen updated this revision to Diff 136919.
devnexen added a comment.
- Only Asan is not working under OpenBSD
- unknown-arg test fails under OpenBSD
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
test/Driver/unknown-arg.c
Index: test/Driver/unknown-arg.c
==
devnexen added a comment.
In https://reviews.llvm.org/D44069#1026563, @krytarowski wrote:
> Revert: http://llvm.org/viewvc/llvm-project?revision=326652&view=revision
>
> And fix.
I launched llvm-lit to the whole directory and this is the fixes.
https://reviews.llvm.org/D44069
_
devnexen updated this revision to Diff 136924.
devnexen added a comment.
Enable UBsan test
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
test/Driver/unknown-arg.c
Index: test/Driver/unknown-arg.c
===
--- test
devnexen updated this revision to Diff 137284.
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
===
--- test/Driver/fsanitize.c
+++ test/Driver/fsanitize.c
@@ -388,6 +388,12 @@
// RUN
devnexen added inline comments.
Comment at: test/Driver/fsanitize.c:392
+// RUN %clang -target i386-pc-openbsd -fsanitize=undefined %s -### 2>&1 |
FileCheck --check-prefix=CHECK_UBSAN-OPENBSD
+// CHECK-UBSAN-OPENBSD: -fsanitize=undefined
+
vsk wrote:
> Why does
devnexen updated this revision to Diff 137447.
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
===
--- test/Driver/fsanitize.c
+++ test/Driver/fsanitize.c
@@ -388,6 +388,21 @@
// RUN
devnexen updated this revision to Diff 137448.
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
===
--- test/Driver/fsanitize.c
+++ test/Driver/fsanitize.c
@@ -388,6 +388,25 @@
// RUN
devnexen created this revision.
devnexen added a reviewer: dergachev.a.
Herald added a subscriber: cfe-commits.
In addition of checking mmap call, checking as well mprotect to detect possible
writable-executable promotions.
Repository:
rC Clang
https://reviews.llvm.org/D44250
Files:
lib/S
devnexen added a comment.
ping would be nice if it was commited this week :-) especially the other bits
are already
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
devnexen added a comment.
Yes I do ☺ thanks.
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:323
Opts.ToolType = EfficiencySanitizerOptions::ESAN_CacheFrag;
- else if (LangOpts.Sanitize.has(SanitizerKind::EfficiencyWorkingSet))
+ else if (T.getOS() == Triple::Linux &&
+LangOpts.Sanitize.ha
devnexen added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:323
Opts.ToolType = EfficiencySanitizerOptions::ESAN_CacheFrag;
- else if (LangOpts.Sanitize.has(SanitizerKind::EfficiencyWorkingSet))
+ else if (T.getOS() == Triple::Linux &&
+LangOpts.Sanitize.ha
devnexen added a comment.
ping working-set on FreeBSD does not seem doable.
Repository:
rC Clang
https://reviews.llvm.org/D52610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen added a comment.
- FreeBSD does not have real Linux's clone equivalent.
- Hangs or crashes during the final report (the shadow mapping is similar as
Linux's though).
Repository:
rC Clang
https://reviews.llvm.org/D52610
___
cfe-commits m
devnexen added a comment.
Things might differ between NetBSD and FreeBSD about the feasibility. So maybe
for the former it is more reachable (only would need to set specific
application mappings maybe ?).
- So once the non writable addresses are created, it processes the working sets
to make i
1 - 100 of 219 matches
Mail list logo
