This revision was automatically updated to reflect the committed changes.
Closed by commit rL258403: [libcxx] Add appropriate 'REQUIRE' directives to
tests that require en_US.UTF-8. (authored by dsanders).
Changed prior to commit:
http://reviews.llvm.org/D16406?vs=45531&id=45533#toc
Repository
Author: dsanders
Date: Thu Jan 21 09:35:15 2016
New Revision: 258403
URL: http://llvm.org/viewvc/llvm-project?rev=258403&view=rev
Log:
[libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.
Reviewers: mclow.lists, hans
Subscribers: bcraig, cfe-commits
Differential Revi
dsanders created this revision.
dsanders added reviewers: bcraig, mclow.lists, hans.
dsanders added a subscriber: cfe-commits.
These are the tests that didn't fail in the release candidate because they were
covered by another 'REQUIRES' directive.
http://reviews.llvm.org/D16408
Files:
test/st
dsanders added a comment.
There's only 7 instead of the 8 we were expecting because one match turned out
to be the python script that checks for the availability of the locale.
http://reviews.llvm.org/D16408
___
cfe-commits mailing list
cfe-commits
>
> Is this OK for 3.8?
>
> Daniel, I assume we want reviews.llvm.org/D16408 too when that lands,
> right?
>
> Thanks,
> Hans
>
> On Thu, Jan 21, 2016 at 7:35 AM, Daniel Sanders via cfe-commits
> wrote:
> > Author: dsanders
> > Date: Thu Jan 21 09:35:15 2016
&g
t
reviews.llvm.org/D16408<http://reviews.llvm.org/D16408> too when that lands,
right?
Thanks,
Hans
On Thu, Jan 21, 2016 at 7:35 AM, Daniel Sanders via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: dsanders
> Date: Thu Jan 21 09:35:15 2016
> New Revisi
.org/D16408> too when that lands,
right?
Thanks,
Hans
On Thu, Jan 21, 2016 at 7:35 AM, Daniel Sanders via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: dsanders
> Date: Thu Jan 21 09:35:15 2016
> New Revision: 258403
>
> URL: http://llvm.org/viewvc/llvm-p
I'm not sure why my reply-all dropped Hans from the recipients. Re-added him.
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
Daniel Sanders via cfe-commits
Sent: 21 January 2016 17:31
To: Marshall Clow
Cc: cfe-commits
Subject: RE: [libcxx] r258403 - [libcxx
dsanders added a comment.
Thanks.
> May want to wait on mclow though considering the trouble I helped cause with
> the last one of these.
Sure. That wasn't your fault though, it was mine. I should have asked for
clarification first.
http://reviews.llvm.org/D16408
dsanders created this revision.
dsanders added reviewers: EricWF, mclow.lists, hans.
dsanders added a subscriber: cfe-commits.
This is a workaround to a clang bug which causes libcxx tests to fail in the 3.8
release. The clang bug is currently being investigated. It seems that clang
does not stop
dsanders added a comment.
Thanks
> @dsanders: What platform are you on that doesn't have en_US.UTF-8? If your
> serious about testing libc++ you should install the locale. (but I understand
> that's not always possible).
It's Debian Jessie but it was configured for the Europe/London region du
Author: dsanders
Date: Wed Jan 27 04:45:07 2016
New Revision: 258920
URL: http://llvm.org/viewvc/llvm-project?rev=258920&view=rev
Log:
[libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.
Summary:
These are the tests that didn't fail in the release candidate because they w
dsanders added a comment.
Thanks. Given that you're the patch author should I wait for someone else to
LGTM too?
http://reviews.llvm.org/D16584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: dsanders
Date: Thu Jan 28 07:49:33 2016
New Revision: 259046
URL: http://llvm.org/viewvc/llvm-project?rev=259046&view=rev
Log:
[libcxx] Work around for clang calling GAS after having already failed.
Summary:
This is a workaround to a clang bug which causes libcxx tests to fail in the 3.8
Hi Hans,
Is it ok to merge this into 3.8? Eric Fiselier has already approved on the
review.
From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of Daniel
Sanders via cfe-commits [cfe-commits@lists.llvm.org]
Sent: 28 January 2016 13:49
To
Author: dsanders
Date: Thu Jan 28 10:51:36 2016
New Revision: 259058
URL: http://llvm.org/viewvc/llvm-project?rev=259058&view=rev
Log:
Merging r258920:
r258920 | dsanders | 2016-01-27 10:45:07 + (Wed, 27 Jan 2016) | 11 li
> review.
>
> From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of Daniel
> Sanders via cfe-commits [cfe-commits@lists.llvm.org]
> Sent: 28 January 2016 13:49
> To: cfe-commits@lists.llvm.org
> Subject: [libcxx] r259046 - [libcxx] Work around for clang calling GAS
Author: dsanders
Date: Thu Jan 28 15:03:16 2016
New Revision: 259092
URL: http://llvm.org/viewvc/llvm-project?rev=259092&view=rev
Log:
Merging r259046:
r259046 | dsanders | 2016-01-28 13:49:33 + (Thu, 28 Jan 2016) | 18 li
Author: dsanders
Date: Fri Nov 27 11:39:20 2015
New Revision: 254203
URL: http://llvm.org/viewvc/llvm-project?rev=254203&view=rev
Log:
[mips] Interrupt attribute support.
Summary: This patch adds support for the interrupt attribute for mips32r2+.
Reviewers: dsanders, aaron.ballman
Subscribers:
Author: dsanders
Date: Fri Nov 27 12:00:36 2015
New Revision: 254204
URL: http://llvm.org/viewvc/llvm-project?rev=254204&view=rev
Log:
Revert r254203: [mips] Interrupt attribute support.
I forgot to credit the author.
Removed:
cfe/trunk/test/CodeGen/mips-interrupt-attr.c
cfe/trunk/test/S
Author: dsanders
Date: Fri Nov 27 12:03:44 2015
New Revision: 254205
URL: http://llvm.org/viewvc/llvm-project?rev=254205&view=rev
Log:
[mips] Interrupt attribute support.
Summary: This patch adds support for the interrupt attribute for mips32r2+.
Patch by Simon Dardis.
Reviewers: dsanders, aaro
Author: dsanders
Date: Fri Nov 27 13:49:24 2015
New Revision: 254208
URL: http://llvm.org/viewvc/llvm-project?rev=254208&view=rev
Log:
Fixed default label in fully covered switch warning that was introduced in
r254203.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/C
dsanders requested changes to this revision.
This revision now requires changes to proceed.
Comment at: lib/Driver/Tools.cpp:2501-2524
@@ -2500,2 +2500,26 @@
}
+
+const char *Feature = llvm::StringSwitch(Value)
+ .Case("-mips1", "+
dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.
With a couple small changes it will LGTM
Comment at: lib/Driver/Tools.cpp:2567-2568
@@ -2547,1 +2566,4 @@
}
+ StringRef MipsFeatureStringRef = MipsTargetFeature;
+ if
Author: dsanders
Date: Tue Dec 22 06:59:30 2015
New Revision: 256240
URL: http://llvm.org/viewvc/llvm-project?rev=256240&view=rev
Log:
[mips] Add _GCC_HAVE_SYNC_COMPARE_AND_SWAP macros.
This fixes the 'pure virtual function called' failure with ThreadPool in a
clang-built clang. This fixes the ll
101 - 125 of 125 matches
Mail list logo
